- 27 Oct, 2020 40 commits
-
-
Morten Stenshorne authored
PaintLayer does one fragmentainer at a time, but we were painting and hit-testing everything in each iteration, leading to DCHECK failures (duplicate paint entries) for painting, and false hit-test matches. Bug: 829028 Change-Id: Iededd014d84b4db9c29e4df6332033b0138da42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490111Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#821117}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4296.0-1603705354-benchmark-88.0.4303.0-r1 to 88-4296.0-1603705354-benchmark-88.0.4304.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I4aa127cd9adacf06946f6b7d0080d479191a022d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500373Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821116}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=caseq@chromium.org Bug: 1142671 Change-Id: I3f7d51a37c7a4343cb5e5c891992f4a21aa3fef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500615 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#821115}
-
Daniel Hosseinian authored
The original tests in PDFExtensionJSTest.AnnotationsFeatureEnabled tested the behaviors of the ink controller, and did not clear the DOM. The new tests, which only test parts of the UI inside the toolbar, clear the DOM, exposing the tests to potential flakiness if any calls are made to the plugin near when the DOM is being cleared. When the DOM is cleared, references to the plugin's members, including the postMessage() function, vanish. Bug: 1136319 Change-Id: I3e6b4dd8c1ef8a23281c100c4a8748d36e642365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478104 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#821114}
-
Nidhi Jaju authored
In an effort to change the blink implementation of readable streams to better match the Web IDL descriptions in the Streams API Standard, this CL adds the StreamPipeOptions dictionary [1] to the ReadableStream class. [1] https://streams.spec.whatwg.org/#dictdef-streampipeoptions Bug: 1093862 Change-Id: Ic03fff0d645786dd48c4d8b7cd8682e0442bff0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488329 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#821113}
-
David Munro authored
The max value gets set automatically when we set the ticks on the slider, but if the observer on slider ticks changing fires after the observer on value changing, then the value gets clamped to the old max meaning even if the user has a larger disk, we'll start the slider off at tick 100. To fix this we explicitly set max, to ensure it's set to the right value when the clamping happens. Bug: chromium:1139722 Test: Manual Change-Id: Ic35d84ce17febdf83ae607e12e0288aa669d55aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497720Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
calamity <calamity@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#821112}
-
Kunihiko Sakamoto authored
This reverts commit 314e453b. Reason for revert: HoldingSpaceTrayTest.ShowTrayButtonOnFirstUse is crashing on linux-chromeos-dbg: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21023 Original change's description: > Introduce partially initialized holding space items > > Introduces a concept of partially initialized HoldingSpaceItem - this > state will be used when loading items from persistent storage in case > the item file system URL cannot immediately be resolved (e.g. if the > associated mount point hasn't been loaded yet). > HoldingSpacePersistenceDelegate will deserialize persisted items into > partial state when they are first loaded from the storage, and > "finalize" them when their file system URL can be resolved. > > Compared to an alternative approach where items whose initialization has > to be deferred, this approach keeps the order in which items are added > to the model. > > Updates holding space UI not to show partially initialized items. > > BUG=1140150 > > Change-Id: Ie19997ec02f6323434f4053f6ba41a2998e72efa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493323 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#821024} TBR=tbarzic@chromium.org,dmblack@google.com Change-Id: Ie916d1b4f15eab360b7124c481105733736c671c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500688Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821111}
-
Daniel Hosseinian authored
Currently an event is fired to the top-level PDFViewerElement to make requests to the plugin for painting thumbnails. Now that the PluginController is a singleton accessible throughout the PDF Viewer's UI code, make the plugin requests directly inside ViewerThumbnailBarElement. Bug: 1134208 Change-Id: I2867effddf43d06b0a6f8cf13fbe2e0881d0e0c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494245 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#821110}
-
Christopher Lam authored
This is a reland of 43831226 Original change's description: > Use grd generation in the Sample System Web App. > > Bug: None > Change-Id: I4485ddbb595ade6ef078abda2436fa887a0d8b7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489060 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820135} Bug: None Change-Id: I296319fc96965ca36eae58990a3c1018796b8c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497900Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#821109}
-
Trent Apted authored
The PiexLoader module used for loading RAW image types in chrome://media-app returns the JPEG "preview", with an orientation field from the Exif data embedded in the RAW file headers separate. Currently, chrome://media-app ignores this orientation. To fix, "splice" in a minimal Exif header at the front of the returned JPEG data in the RAW loading codepath. Bug: 1030935, b/169717921 Change-Id: Ie5454736078d6ece854318b5f6142d7ee42f187b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500684 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#821108}
-
Hirokazu Honda authored
DynamicFramerate/BitrateChange test cases encodes 600 frames and also validates them. It takes too time that it times out on low end devices. This resolves the failures by setting longer event time out. Bug: b:170790027 Test: video_encode_accelerator_tests crowd-3840x2160 --codec=vp8 Change-Id: I2add724637a42175123a64bb5aeb426a03d8528a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470285Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#821107}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6dce2946f57c..ac6e1a61d86e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ksakamoto@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080853,chromium:1102995,chromium:1129937 Tbr: ksakamoto@google.com Change-Id: I4ca85a31ac76378496272a16e8b55848b3ff12a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500909Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821106}
-
Nicholas Hollingum authored
This is preferred for type-safety reasons. Bug: b/171760827 Change-Id: Ib589b5f16f99097b9d885a5d99a04741945c55ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500645Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#821105}
-
Joel Hockey authored
This change replaces the word "modify" with "access" when the user is asked to confirm that they want to share a folder or google Drive with Crostini. Bug: 1133618 Change-Id: I06b107efaa5f4200a7546c5b1d64754cf07ff047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500464 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#821104}
-
Melissa Zhang authored
This reverts commit 2374eacf. Reason for revert: Punting sharesheet to 89 so flags need to be disabled. Original change's description: > [Sharesheet] Turn on flags to enable sharesheet by default. > > This CL turns on the kIntentHandlingSharing and kSharesheet flags to > enable sharesheet feature by default. > > BUG=1097623 > > Change-Id: Idff4e37934fb730b7f83b86206d555a8c049f12e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460206 > Commit-Queue: Maggie Cai <mxcai@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816071} TBR=dominickn@chromium.org,mxcai@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1097623 Change-Id: I4d4914ad4ec363c2a63fdaaf7c55163dd1205f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501161Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821103}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 1142671 Change-Id: Ic42c517716103f0e8f27bce69e054ab54a5e27f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500210 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#821102}
-
Sophey Dong authored
This reverts commit 6769a912. Reason for revert: Causing crashes (https://crbug.com/1142672) Original change's description: > [ShareCCT] Implement sharing in the toolbar and by default in CCT. > > Bug: 1135311 > Change-Id: I967300591d383a21b9f3f40233422b763180ddb0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459403 > Reviewed-by: Tanya Gupta <tgupta@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Commit-Queue: Sophey Dong <sophey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820029} TBR=agrieve@chromium.org,peconn@chromium.org,tgupta@chromium.org,sophey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1135311, 1142672 Change-Id: Id0a3d68fc60893c39eef76c6fa79379dfe8faf2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500591Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Auto-Submit: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#821101}
-
Matt Mueller authored
Bug: b/170619368 Change-Id: I2f882da7205380ecceb471c6fec553a27e69421d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495710 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821100}
-
Dominik Röttsches authored
Issue 996410 shows that this can occur, perhaps due to file corruption or the system being unable to open the file. It's too strict to DCHECK on it. Fixed: 996410 Change-Id: I386afb02b6762b29c7d337646809cccd54133817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498604Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#821099}
-
Xiaocheng Hu authored
CompositeEditCommand::MoveParagraphs() serailizes part of the DOM and then re-parse it and insert it at some other place of the document. This is essentially a copy-and-paste, and can be exploited in the same way how copy-and-paste is exploited. So we should also sanitize markup in the function. Bug: 1141350 Change-Id: I25c1dfc61c20b9134b23e057c5a3a0f56c190b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500633 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821098}
-
Kent Tamura authored
... to LayoutNGTextControlSingleLine. This CL has no behavior changes for now, however this CL fixes at least four unit test failures with LayoutNGTextField flag. Bug: 1040826 Change-Id: I9c6677b7de9d595602caa312678856d79ffb94d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501103 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821097}
-
Andre Le authored
BUG=1106937,1126208 Change-Id: I8dde09f28cee1c1390f32ebf9ec200d9ecd8f4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492740 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#821096}
-
Melissa Zhang authored
This reverts commit efbf947b. Reason for revert: Reverting because we are disabling sharesheet flags by default. Original change's description: > [Sharesheet] Run file manager browser tests with sharesheet enable. > > This CL updates the option.enable_sharesheet default value to be true to > run all tests with sharesheet enabled. This is because we turn on the > sharesheet flags by default. > > BUG=1097623 > > Change-Id: I8714da4bffa30992ca0caf40a34b5237423c34b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461666 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Maggie Cai <mxcai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816074} TBR=lucmult@chromium.org,mxcai@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1097623 Change-Id: I48580601e1287ae27b3c8be32e199963b8cdc713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501164Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821095}
-
Keishi Hattori authored
This reverts commit 77307244. Reason for revert: collected crash dumps so we can turn it back to DCHECK Original change's description: > [PartitionAlloc] Temporarily use CHECK in SetFreelistHead > > Temporarily use CHECK in SetFreelistHead to debug a crash. > Should be reverted after a Canary release. > > Bug: 1137799 > Change-Id: I9e01a5cdfafb7da2af76997f8c42716394ac4cd3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491724 > Reviewed-by: Benoit L <lizeb@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819797} TBR=yukishiino@chromium.org,tasak@google.com,haraken@chromium.org,keishi@chromium.org,lizeb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1137799 Change-Id: I645119e34f6767b9e6a6d1fc739efb0e2c85aff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500387Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821094}
-
Xianzhu Wang authored
Bug: 1101002 Change-Id: I326d9949765f6f821502e439f0b2bfc7156023c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496186Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821093}
-
Kent Tamura authored
They referred to the container of the fieldset incorrectly. Bug: 1140595 Change-Id: Ib70048c4e5e59bfd96f44b04ae0c23271e47e840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497945 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#821092}
-
David Dorwin authored
These unit tests have their own CMX files that enable running hermetically with run-test-component. As discussed in the bug, these don't need security review, and renaming them avoids the presubmit check when maintaining them. Also remove OWNERS rules that applied only to the renamed files. Bug: 1132878 Change-Id: I3f211584d164e99455e98c3837ec3cea80c50910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482028Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821091}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=caseq@chromium.org Bug: 1142671 Change-Id: I2a5d18034d8ec6279ba8330d54e2f093b45fbb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500607 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#821090}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=avi@chromium.org Bug: 1142671 Change-Id: Ic9abe2e32995cdd2f1e50ae5b86d8980fc167e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501121 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821089}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=caseq@chromium.org Bug: 1142671 Change-Id: Iade09088b5a7da8fb5bc0604facb2e0f9cb63218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500496 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#821088}
-
John Abd-El-Malek authored
Bug: 908955, 997108, 997109, 990868 Change-Id: Ieb98aa1b22a8b16c45a41a523b562d7b091d01dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500447Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#821087}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8d0801430595..160e3844d960 2020-10-27 soxia@microsoft.com Roll-deps and generate protocol resources. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I757e9fd3b79f6bb051e5b0c5bfb7b99aa565ceec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500253Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821086}
-
Lukasz Anforowicz authored
Fixed: 1133097 Change-Id: I7f3da3d24bd21797719ad7b5980d2d5d8def7511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493661 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#821085}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=avi@chromium.org Bug: 1142671 Change-Id: I5c57953a34cbab3cdafb0ce371a75297bfc7abde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500571 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821084}
-
Shakti Sahu authored
This CL updates the field trial testing config for the launch group, and removes the non-launch groups for query tiles experiment. Bug: None Change-Id: Ie3a61d3d61df175bb815818ac351be4471bede1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495871Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821083}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=falken@chromium.org Bug: 1142671 Change-Id: Ie6c1889b3eff87c5c7edb4071f31767be2c8a1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500614 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#821082}
-
Takashi Sakamoto authored
Bug: 1086388 Change-Id: I6d10c4f8289cc6555f5d71a664fbc3d3d677ca7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498023Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#821081}
-
Jason Lin authored
We are making the permissions persistent across chrome restarts, so we have to change the way the permissions are stored (currently, they are stored as member variables initialized to false). Note that this CL still resets the prefs values to false in `PluginVmManagerImpl::OnPrimaryUserProfilePrepared()` because the required permission indicators/notifications are not ready yet, so the behavior for now is actually going to be the same. This CL also fixes the bug that pressing <esc> key on the relaunch dialog does not recover the toggle state. This CL also simplfies the code by: * removing <plugin-vm-permission-dialog> --- it is simpler to use <cr-dialog> directly. * replacing `wouldPermissionChangeRequireRelaunch()` with `isRelaunchNeededForNewPermissions()` --- The toggle is the only way the user can change the value, so there is no need for the c++ code to check whether the values are actually different. Bug: b/167491603 Change-Id: I423e1d03db6e4d2b52fefc052c22eb4f27733425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488262 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#821080}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib58ad8f95c2e33f5765c878d25f47ff52a035e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500908Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821079}
-
Rachel Carpenter authored
This launched successfully in M86, and removing the feature will allow us to clean up the code paths and make suggestion chip logic cleaner. Also add an OWNERS file for release_notes seeing as our team owns this code now. Bug: b/171516802 Change-Id: Ic23d531548fce8c68ab481c49bbdf760db7de747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493740Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#821078}
-