- 23 May, 2018 40 commits
-
-
Yoshifumi Inoue authored
This patch changes |WhitespaceAttacherTest| to use |AttachShadowRootInternal()| instead of |Element::attachShadow()| to avoid using script only functions for improving code health. Change-Id: I8b646df53a1316c2c987f7599a16573c75f82896 Reviewed-on: https://chromium-review.googlesource.com/1067566Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560990}
-
Abhishek Bhardwaj authored
Clang format message logic files. BUG=None TEST=Compile. Change-Id: Ia13728381fd16705fba8091236622a42e7e59f0e Reviewed-on: https://chromium-review.googlesource.com/1069685Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#560989}
-
Michael Lippautz authored
Adds helper for computing whether a number is power of two. Change-Id: Ifd7e01ec1aad644fd9c6ac78600edd013076c9fb Reviewed-on: https://chromium-review.googlesource.com/1065960 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#560988}
-
Hannes Payer authored
CompleteSweep() needs to be called before we call ReportMemoryToV8(). This change makes this dependency more explicit. Change-Id: I044af54bcfdc8a7457edbb492fba6bfe4ff210aa Reviewed-on: https://chromium-review.googlesource.com/1069271Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#560987}
-
chromite-chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/07dfd789cb28..fdd7e08cde5d $ git log 07dfd789c..fdd7e08cd --date=short --no-merges --format='%ad %ae %s' 2018-05-21 yunlian cros_gdb: support simple chrome 2018-05-21 bmgordon chroot_lib: Remove ChrootManager 2018-05-21 ayatane sysmon: Refactor prod_metrics: Remove _LoggingSink 2018-05-21 ayatane sysmon: Refactor prod_metrics: Remove _AtestSource 2018-05-21 ayatane sysmon: Refactor prod_metrics: Remove _ProdHostReporter Created with: roll-dep src/third_party/chromite BUG=chromium:843275,chromium:845174,chromium:None,chromium:None,chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I32201b36652a22d6f98c4c470ae1319206badc92 Reviewed-on: https://chromium-review.googlesource.com/1069979 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560986}
-
Yuta Kitamura authored
This test is flaky on Linux, ChromeOS and Windows. This test was also disabled on Mac for another reason, so this test is disabled on four platforms in total. TBR=jbroman@chromium.org Bug: 845638, 811893 Change-Id: Iff963f4075c34dd3ecc27596ab6ac96489b80bce No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1070017Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#560985}
-
Michael Lippautz authored
Bug: chromium:841830 Change-Id: Ica721b07df8b50b22fd801e83abf7403653a9474 Reviewed-on: https://chromium-review.googlesource.com/1068576Reviewed-by:
-
Andrew Moylan authored
These conf files are installed in /opt/google/chrome/dbus not /etc/dbus-1/system.d/. Change-Id: I1d3d454662fbcfc56f05112dbd97ec83e6e2281a Reviewed-on: https://chromium-review.googlesource.com/1067567Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#560983}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b1e913801502..be7f44fb5741 $ git log b1e913801..be7f44fb5 --date=short --no-merges --format='%ad %ae %s' 2018-05-21 jie.a.chen Vulkan: Use push constant for masked clear color Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: Iafe1b5773398814bdc1563d6dbc7cb39e4ab2129 Reviewed-on: https://chromium-review.googlesource.com/1069986 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560982}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 R=thakis@chromium.org Change-Id: I20af35b11d3e538250fd2eea406f4c22e5d6bd42 Reviewed-on: https://chromium-review.googlesource.com/1068871Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#560981}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 R=thakis@chromium.org Change-Id: I9a5cdf61e6b001cf8dae6cab3eee457cf74bbf76 Reviewed-on: https://chromium-review.googlesource.com/1068741Reviewed-by:
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 R=thakis@chromium.org Change-Id: I39bb8f5b82392e1043b748c8e3cefb7ac5741616 Reviewed-on: https://chromium-review.googlesource.com/1068874Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |CustomElementUpgradeSorterTest| to use |AttachShadowRootInternal()| instead of |Element::attachShadow()| to avoid using script only functions for improving code health. Change-Id: I625737366659a64ee26d4802c2972e1fd0488348 Reviewed-on: https://chromium-review.googlesource.com/1068537Reviewed-by:
-
Dominick Ng authored
This CL reduces the annoyingness of the ambient badge infobar on Android when browsing a PWA. If the infobar is dismissed, it will not be shown for 90 days, mirroring the existing block time for infobar app banners. The infobar will continue to be shown on navigations until it is dismissed. BUG=782120,834259 Change-Id: Idbbb9e9451fd01f639e859a1b65470330929f993 Reviewed-on: https://chromium-review.googlesource.com/1068903Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#560977}
-
Yoshifumi Inoue authored
This patch changes |StyleEngineTest| to use |AttachShadowRootInternal()| instead of |Element::attachShadow()| to avoid using script only functions for improving code health. Change-Id: I29bb95e0e70015aaca4ed35a5ed440fd9ec7d9e3 Reviewed-on: https://chromium-review.googlesource.com/1068574Reviewed-by:
-
Yoshifumi Inoue authored
This patch gets rid of unused member function |AttachShadowTo()| from |CustomElementRegistryTest| class for improving code health. Change-Id: I6eb81bb67c2b0521cd1c9c4fb554ab3ce71e9ea4 Reviewed-on: https://chromium-review.googlesource.com/1067563Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560975}
-
Yoshifumi Inoue authored
This patch changes |NodeTest| to use |AttachShadowRootInternal()| instead of |Element::attachShadow()| to avoid using script only functions for improving code health. Change-Id: I341eacc5f53418f816c50a98a4e062f9692a0fab Reviewed-on: https://chromium-review.googlesource.com/1067564Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |ApplyRulesetsTest| to use |AttachShadowRootInternal()| instead of |Element::attachShadow()| to avoid using script only functions for improving code health. Change-Id: Iafe926240feca77ee87b345aa0688398db119110 Reviewed-on: https://chromium-review.googlesource.com/1067565Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/91dfa3b571f1..7257e22e43a5 $ git log 91dfa3b57..7257e22e4 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 mtklein Revert "fonts: Add support for distance field text to font remoting." 2018-05-23 mtklein Revert "fonts: Cleanup cache miss logging for font remoting." 2018-05-23 mtklein Revert "start cleaning up non-skcms SkColorSpaceXforms" 2018-05-22 angle-skia-autoroll Roll third_party/externals/angle2/ 534b00dbd..64ac5d9eb (2 commits) 2018-05-22 khushalsagar fonts: Cleanup cache miss logging for font remoting. 2018-05-22 bungeman IWYU for tools/fiddle/egl_context.cpp 2018-05-22 brianosman Clip to perspective quad in viewer 2018-05-22 egdaniel MoltenVk fix for fuchsia again. 2018-05-22 bungeman Remove include/gpu/vk from include paths. 2018-05-22 khushalsagar fonts: Add support for distance field text to font remoting. 2018-05-22 csmartdalton ccpr: Remove local matrix data from path instances Created with: roll-dep src/third_party/skia BUG=chromium:829622,chromium:829622 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: I6c530de43df351c926623d3543b37ddca1e3a26f Reviewed-on: https://chromium-review.googlesource.com/1069938Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560972}
-
Yuta Kitamura authored
TBR=jbroman@chromium.org Bug: 845661 Change-Id: Ief62b072b1b27213d3402afcf9f47a6cfc9b5aea No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1070012Reviewed-by:
-
Dominick Ng authored
Until the Chrome OS app registry is implemented, we cannot persist "Remember my choice" for desktop PWAs in the intent picker. On the advice of UI review, this CL suppresses popping out the intent picker and instead shows the intent picker omnibox icon if only desktop PWAs are available for the picker. This reduces user annoyance until the persistence mechanism is available, at which point we will pop out the picker for desktop PWAs again. The picker will pop out if any ARC app is present in the list of apps. BUG=824598 Change-Id: I027f231bae533f077a8a85acca41b64ae7a81444 Reviewed-on: https://chromium-review.googlesource.com/1068579 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#560970}
-
Cathy Li authored
[Offline pages]: Add information to broadcasted intent to help mitigate need for re-fetching the data Bug: 812022 Change-Id: I58b99dd7b841c1312016217117b2ecd62c65188e Reviewed-on: https://chromium-review.googlesource.com/991456 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#560969}
-
Xianzhu Wang authored
ClipPath in a ClipPaintPropertyNode may clip off pixels within the clip bounds, so the result clip rect should clear the tight flag. During raster invalidation, we won't compare non-tight clip rects for change of clip but will check the changed flag of the clip nodes to ensure correct raster invalidation. Bug: 845269 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I41e48e3eb15232d6cf88bd8986df5c3d8075d7db Reviewed-on: https://chromium-review.googlesource.com/1069671 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#560968}
-
Marc Treib authored
This way, GetSyncTokenStatus can just return token_status_, rather than make a copy and fix it up. Bug: 842697 Change-Id: Ic0522cb83ee1da425d88b6e58e57d843720bcad7 Reviewed-on: https://chromium-review.googlesource.com/1068875 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#560967}
-
Yoshifumi Inoue authored
This patch changes |FocusControllerTest| to use |AttachShadowRootInternal()| instead of |Element::attachShadow()| to avoid using script only functions for improving code health. Change-Id: I8e3f0a8f13e3497411f2cbc15865c1281758d706 Reviewed-on: https://chromium-review.googlesource.com/1068583Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |ScopedStyleResolverTest| to use |AttachShadowRootInternal()| instead of |Element::attachShadow()| to avoid using script only functions for improving code health. Change-Id: I7f8b93fd8616a95b0f382db5931f6e403f9cdd94 Reviewed-on: https://chromium-review.googlesource.com/1068580Reviewed-by:
-
Sasha Morrissey authored
Bug: 844391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I37f651e972e290447e1de0312b62c647bc6835e5 Reviewed-on: https://chromium-review.googlesource.com/1068585Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#560964}
-
Dmitry Skiba authored
LibraryManager indirectly passes LibraryProcessType value to the native code via getLibraryProcessType() static method, which is only invoked in the context of nativeLibraryLoaded() call. I.e. the indirection is unnecessary and only makes data flow harder to understand. This CL removes getLibraryProcessType() method and passes process type value directly to nativeLibraryLoaded(). Bug: 841403 Change-Id: Ib15d765f968029d46d1603cdc7a5d5e7d280bb06 Reviewed-on: https://chromium-review.googlesource.com/1067578 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#560963}
-
Sasha Morrissey authored
Fixed 'Share' option to open drive.google.com for files and folders in Team Drives. Previously, the URL opened was just the alternateUrl (views the file or folder in drive.google.com). Appending ?userstoinvite="" opens the sharing dialog. In the future, this URL will be returned from the Drive API. The file/folder should open in drive.google.com with the sharing dialog open. Test: Right-click on a file or folder in Team Drives and select 'Share'. Bug: 716301 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id7d738fd1b16f67af3a012426b8eea0032489450 Reviewed-on: https://chromium-review.googlesource.com/1065834 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#560962}
-
Yuichiro Hanada authored
This CL adds input_method_manager.mojom file and stub implementation for InputMethodManagerHost interface. input_method_manager.mojom file defines the bridge interface between Chrome OS's InputMethodManager and Android's InputMethodManager. Bug: 845079 Test: unit_tests Change-Id: I3d5a25c7774a1258fc0e1494fc351571327a89dd Reviewed-on: https://chromium-review.googlesource.com/1065560 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#560961}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3792c386..0e4815cd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ieb74b1c0a1a90f8ad43a38466cd166dc54a0f1c7 Reviewed-on: https://chromium-review.googlesource.com/1069179Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#560960}
-
Hayato Ito authored
It would be safe to disable Incremental Shadow DOM for M68, whose branch cut is soon. Let's defer it to M69 so that we can address http://crbug.com/845770 surely. Bug: 776656, 845770 Change-Id: I5d2efeca4b44c0b4a84948233d7b3447cdf4f64e Reviewed-on: https://chromium-review.googlesource.com/1069952Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Ben Wells authored
Bug: 703927 Change-Id: If62f613aab52f8573a48d874c7bc70a720e792b9 Reviewed-on: https://chromium-review.googlesource.com/1068532 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#560958}
-
Donna Wu authored
BUG=769630 Change-Id: I30146f723275f40dbf25956f62110612be5d1a14 Reviewed-on: https://chromium-review.googlesource.com/1063567 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#560957}
-
Keishi Hattori authored
PersistentHeapCollectionBase::persistent_node_ was being copied on copy assignment. PersistentHeapCollectionBase::persistent_node_ should never change once assigned. When they get overwritten, the old PersistentNode might point to a freed PersistentHeapCollection. Bug: 843550 Change-Id: Ic2397683c346ba019a24bfe9c241f6bcd81a1c2d Reviewed-on: https://chromium-review.googlesource.com/1068557Reviewed-by:
-
Donna Wu authored
BUG=769630 Change-Id: If9caefc4a503430648bd6cfccb56adcc066b1f62 Reviewed-on: https://chromium-review.googlesource.com/1063554Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7f472cd8abe4..86688dea3b0d $ git log 7f472cd8a..86688dea3 --date=short --no-merges --format='%ad %ae %s' 2018-05-22 thestig Make friend RetainPtr<T> statements consistently public. 2018-05-22 thestig Fix nits in fxjs. 2018-05-22 thestig Simplify CPDF_ShadingPattern::Validate(). Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I284bf7cc2464e552f0fadf8433244cd17bd81a72 Reviewed-on: https://chromium-review.googlesource.com/1069968Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560954}
-
Yoichi Osato authored
This patch adds assert_selection tests converted from editing/selection/move-left-right.html. Here is generator: crrev.com/c/1032319 This patch includes #11-#20 tests in original 43 tests. Bug: 679977 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3551a787a53958ae7a306a1a005770e503db9f09 Reviewed-on: https://chromium-review.googlesource.com/1063450 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Bence Béky authored
Sometimes handshake_stream_ is null in PerformUpgrade(), causing a crash. These CHECKs will allow us to distinguish between the following three possible causes: * OnHandshakeStreamCreated() has never been called; * OnHandshakeStreamCreated() has been called with nullptr; * PerformUpgrade() has already been called. Bug: 842575 Change-Id: Idd0ff4fecdeadee2d8286363a3b81ca6246b709e Reviewed-on: https://chromium-review.googlesource.com/1069191 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#560952}
-
Yuta Kitamura authored
This reverts commit 3a2babeb. Reason for revert: Suspected cause of ASAN failure (bug 845687) and Mac-only flakiness (bug 845760, but 845759, bug 845690). Original change's description: > Add supports for Objective-C blocks to base::Bind* > > Add template specifialization allowing to use base::Bind* with > Objective-C block. To avoid breaking ODR, it is necessary to > use base::WrapBlock() when ARC support is disabled, but when > it is enabled, the block can be directly bound by base::Bind*. > > This also allow to use base::BindOnce() with blocks and thus > pass them move-only objects, allowing the following: > > __weak Foo* weakSelf = self; > std::unique_ptr<Bar> bar = ...; > base::OnceClosure closure = base::BindOnce( > ^(std::unique_ptr<Bar> bar) { > [weakSelf adoptBar:std::move(bar)]; > }, std::move(bar)); > > The base::BindBlock and base::BindBlockArc templates are kept for > compatibility but are now just wrapper for base::BindRepeating. > > Bug: 701275 > Change-Id: I6e5d5309bcae768b2d1e8425b27ca295098e30b1 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/977912 > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560634} TBR=thakis@chromium.org,sdefresne@chromium.org,tzik@chromium.org Change-Id: Id72a1806176f830a1887243fcd2795a927e7d638 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 701275 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1068588Reviewed-by:
-
