GitLab

This reverts commit 932dfd17.

Reason for revert: Dex fusing has been fixed in bundletool and
a new version has been rolled: crrev.com/c/1789178

Original change's description:
> Revert "Enable dist fusing for all feature modules. (reland)"
> 
> This reverts commit 78fac991.
> 
> Reason for revert: Breaking some internal builders. Will reland once they are no longer building these targets.
> 
> Original change's description:
> > Enable dist fusing for all feature modules. (reland)
> > 
> > Fixed: I have disabled building of the system image in next-* builds
> > so there should no longer be an issue. next-* builds can be re-enabled
> > when bundletool is updated.
> > 
> > This reverts commit 7c77403d.
> > 
> > Original change's description:
> > > Revert "Enable dist fusing for all feature modules."
> > > 
> > > This reverts commit 27ca1df7.
> > > 
> > > Reason for revert: This CL causes an official build failure
> > > https://crbug.com/996658
> > > 
> > > Original change's description:
> > > > Enable dist fusing for all feature modules.
> > > > 
> > > > Change-Id: I66848fec159450a6d531e0af3f867988aa8b148f
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763431
> > > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> > > > Commit-Queue: Ben Mason <benmason@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#689075}
> > > 
> > > TBR=tiborg@chromium.org,benmason@chromium.org
> > > 
> > > Change-Id: Ib696df42847a54c1257fae41ecb544df40f47e75
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764159
> > > Reviewed-by: Alex Ilin <alexilin@chromium.org>
> > > Commit-Queue: Alex Ilin <alexilin@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#689454}
> > 
> > TBR=alexilin@chromium.org,tiborg@chromium.org,benmason@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Change-Id: Id4687e7980b238cdbea04a1c8921b57a974f7cd0
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768946
> > Reviewed-by: Ben Mason <benmason@chromium.org>
> > Commit-Queue: Ben Mason <benmason@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#689947}
> 
> TBR=alexilin@chromium.org,tiborg@chromium.org,benmason@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: Ib1558378a9b2a12b7f0260a04eeb1fbe4d1330b1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773836
> Reviewed-by: Ben Mason <benmason@chromium.org>
> Commit-Queue: Ben Mason <benmason@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#690995}

TBR=alexilin@chromium.org,tiborg@chromium.org,benmason@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I5f5e2aa67eebca73b2109116b4d1beba82755d55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789826Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694329}

"tree id=67228E93CA923929527DFFCB9DE1AB88
node id=2 role=rootWebArea state={"focusable":true} parentID=369 childIds=[5]
  node id=5 role=textField state={"editable":true,"focusable":true,"multiline":true,"richlyEditable":true,"focused":true} parentID=2 childIds=[7] name=Document content
    node id=7 role=paragraph state={"editable":true,"richlyEditable":true} parentID=5 childIds=[9,14,19]
      node id=9 role=staticText state={"editable":true,"richlyEditable":true} parentID=7 childIds=[278] name=One two three four five six seven eight nine ten eleven twelve thirteen fourteen fifteen sixteen
        node id=278 role=inlineTextBox state={} parentID=9 childIds=[] name=One two three four five six seven eight nine ten eleven twelve thirteen fourteen fifteen sixteen
      node id=14 role=staticText state={"editable":true,"richlyEditable":true} parentID=7 childIds=[280] name=seventeen eighteen nineteen twenty One two three four five six seven eight nine ten eleven
        node id=280 role=inlineTextBox state={} parentID=14 childIds=[] name=seventeen eighteen nineteen twenty One two three four five six seven eight nine ten eleven
      node id=19 role=staticText state={"editable":true,"richlyEditable":true} parentID=7 childIds=[282] name=twelve thirteen fourteen fifteen sixteen seventeen eighteen nineteen twenty
        node id=282 role=inlineTextBox state={} parentID=19 childIds=[] name=twelve thirteen fourteen fifteen sixteen seventeen eighteen nineteen twenty
"
js> id9.toString()
"node id=9 role=staticText state={"editable":true,"richlyEditable":true} parentID=7 childIds=[278] name=One two three four five six seven eight nine ten eleven twelve thirteen fourteen fifteen sixteen"
js> id9.firstChild.toString()
"node id=278 role=inlineTextBox state={} parentID=9 childIds=[] name=One two three four five six seven eight nine ten eleven twelve thirteen fourteen fifteen sixteen"
js> id9.nextOnLine.toString()
"node id=279 role=inlineTextBox state={"ignored":true,"offscreen":true} parentID=7 childIds=[] name=
"

Node 279 isn't actually in the tree and triggers bad editable line output.

Bug: b:140615809,1001562
Change-Id: I4eeaeb1019f77d6fcba688f65230843c7ff4ff48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790042
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694328}

Also, remove any references to the word "virtual", as from now on
the feature will be just called "Desks".

BUG=1001568
TEST=Manually.

Change-Id: If3832d2b58fb0b4c1c20ecd85887e86cc20dad58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790285Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694327}

https://skia.googlesource.com/skia.git/+log/6d1c0d4196f1..172bb44f2d66

git log 6d1c0d4196f1..172bb44f2d66 --date=short --no-merges --format='%ad %ae %s'
2019-09-06 brianosman@google.com Make the size of program/pipeline caches configurable in GrContextOptions
2019-09-06 reed@google.com use scratch path to save on mallocs in drawAtlas
2019-09-06 robertphillips@google.com Remove IORefs from GrSurface
2019-09-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0c35e0f44dbd..df0ce01870fa (5 commits)
2019-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src e96090c3..64926377 (605 commits)
2019-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader cf0e2fe12289..5d0faf9be9d7 (4 commits)
2019-09-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-05 herb@google.com Remove bool for RemoteStrike send
2019-09-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-05 reed@google.com reverse/restore order of verbs in path to be forward (normal)
2019-09-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2019-09-05 khushalsagar@chromium.org Reland: Only send the RemoteStrikes that have pending glyphs.
2019-09-05 egdaniel@google.com Begin renderpasses immediately in GrVkOpsRenderPass.
2019-09-05 jvanverth@google.com Add touch support to viewer
2019-09-05 michaelludwig@google.com Clean up prior backdrop-filter CL
2019-09-05 egdaniel@google.com Update some ops to create their buffers in onPrepare.
2019-09-05 ethannicholas@google.com Revert "switched SkSL interpreter over to threaded code"
2019-09-05 ethannicholas@google.com switched SkSL interpreter over to threaded code
2019-09-05 rmistry@google.com Allow PRIVATE_SKPS_GS to be empty in assets/skp/create.py

Created with:
  gclient setdep -r src/third_party/skia@172bb44f2d66

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jlavrova@google.com

Bug: chromium:None,chromium:None,chromium:None,chromium:999682
Change-Id: I474cd2dc07896c2c1a91e4fdc9b473021e1ddb6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789870Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694326}

The Windows bits were outdated.

Bug: none
Change-Id: I45fd6b70e013491080bc7028b7ce5be600e8fab2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790124
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694325}

Changes:
	- Added label to 'Emulate CSS media' combobox

Screen Reader on Rendering Page:
        - https://imgur.com/YsTeXiW

SR reading label twice bug present in this tool's checkboxes:
        - https://github.com/nvaccess/nvda/issues/7948
        - https://github.com/nvaccess/nvda/issues/8885

Bug: 963183
Change-Id: I4711ef42b573f62770fb64b237077de5d20ee06e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656733
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694324}

Add LoginScreenStorageListKeys() and LoginScreenStorageDelete() methods
to the SessionManagerClient.

Bug: 980171
Change-Id: Ib4492bc9dc9019798895b84f08d3c35c7d516994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753924Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Zakhar Voit <voit@google.com>
Cr-Commit-Position: refs/heads/master@{#694323}

https://webrtc.googlesource.com/src.git/+log/30323e2fb25a..b64d65e67bff

git log 30323e2fb25a..b64d65e67bff --date=short --no-merges --format='%ad %ae %s'
2019-09-06 yvesg@webrtc.org Fix NetworkEmulationManagerTest.ThroughputStats flakiness.
2019-09-06 saza@webrtc.org Remove completed TODOs

Created with:
  gclient setdep -r src/third_party/webrtc@b64d65e67bff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: Ic38017053810823c7b2b212a00e8aee592dc386b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790088Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694322}

This change:
1) Adds support to run-swarmed for targeting macOS
2) Adds a --swarming-os argument that allows specifying the OS the
   targets should run on, which is useful for targeting specific OS
   versions and such
3) Makes the outdir and target arguments mandatory positional args
   instead of named args, since they were/are required anyway (the
   script crashes if they aren't given)
4) Removes Fuchsia-specific defaults and documentation references
5) Renames the test_name argument to target_name for more consistency
   with gn/ninja parlance
6) Updates doc references, especially for #3

Bug: None
Change-Id: I64051d3e35d6b143d7688083a3c0877ffbf06ff3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787587
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694321}

We would like the bitmap list in BitmapCursorOzone to be either empty
or every bitmap be valid. If the provided bitmap is null, just don't
add it to the list. Instances created from WebCursors can sometimes
have null bitmaps.

Bug: 620927
Change-Id: I0e78bfcb544fe6751dc48e378e495feaec220af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789909Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694320}

This brings the frame context menu available on other platforms to Mac
and allows users to restore the previously closed tab within the
tabstrip.

BUG=997637
TEST=Right clicking at frame and contents boundaries in tabbed Chrome.

Change-Id: I3c4129641d398e38786cfa7d501edc32f2e92252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786935
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694319}

https://chromium.googlesource.com/angle/angle.git/+log/e64cea302acd..32d6006bf2ef

git log e64cea302acd..32d6006bf2ef --date=short --no-merges --format='%ad %ae %s'
2019-09-06 geofflang@chromium.org Don't block setting the DEPTH_STENCIL attachment based on the resource format.
2019-09-06 timvp@google.com Refactor ShaderVariable to Remove Specializations
2019-09-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 34953810a62c..664ad418f845 (1 commits)

Created with:
  gclient setdep -r src/third_party/angle@32d6006bf2ef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org,jmadill@google.com

Bug: chromium:997702,chromium:None
Change-Id: I707d0c92cc6c6f2a65565493576b0f2a6eb536bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790082Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694318}

The storage setting including "External storage preferences" page was
moved out of Chrome settings.
To open OS settings correctly for this sub page,
chrome::IsOSSettingsSubPage() should return true.

Bug: 1001419
Test: Manually tested following the repro step in the bug description.
Change-Id: I379479111cbf0bda6cb930750c94063be9c1f56c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789182
Auto-Submit: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694317}

Creates the EnterpriseMemoryLimitEvaluator as part of the Enterprise
memory limit project described here:
https://docs.google.com/document/d/1W3FPDyjIAKBcFGNYsHA3EKR1FHrJlbBaqT4_RUnxzq0/edit#heading=h.7nki9mck5t64.
This Evaluator receives periodic updates on Chrome's current total memory
usage via a GraphObserver object (which is also created in this cl). The
Evaluator compares that usage to the limit set via an Enterprise policy,
and uses a MemoryLimitVoter to send its vote on the MemoryPressureLevel
to the MultiSourceMemoryPressureMonitor. A new
EnterpriseMemoryLimitPreferenceMonitor (to be created in a future CL)
class will be used to create an instance of this object when the policy
(also to be created in a future CL) is enabled, update its
|resident_set_limit_mb_| when the preference is updated, and destroy the
Evaluator when the policy is disabled.

Bug: 980965
Change-Id: I124595c776e4500d3b4152c7697ba07ff28715bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783401Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Ryan Powell <ryanpow@google.com>
Cr-Commit-Position: refs/heads/master@{#694316}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chrome/browser/android/contextualsearch.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=donnd@chromium.org

Bug: 891670
Change-Id: I4eafad717c740b5168d1f61dd7ad65fdafd756fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786755
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694315}

The timer crashes if stopped is called before started. Add a null pointer
check to avoid that.

Also add a DCHECK for Reset() which should never be called before Start().

Bug: 956237
Change-Id: I76c0d3522c4aa0793a2375f3c1b94723c03db915
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787701
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694314}

We can just set an override containing block height to ensure that
percentages resolve to auto, as desired.

This resolved a long-standing bug we had and improves compat with
Firefox.

Bug: 998080
Change-Id: I43510e69f360c32d2739d9514a659ca517ccfd7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786297
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694313}

This serves to identify app shims that should be treated as
multi-profile (only shortcut apps and PWAs are to be multi-profile),
so that, in a future patch, they can ignore their profile path.
Also (in the future), in the event that an app is not installed on any
profile, but the shim still exists (e.g, a user wipes their prefs),
then this URL can be used to open that shortcut URL in a browser tab
(rather than just fail).

Rename the function that is called when a shim connects to the browser
from LaunchApp to OnShimConnected. Change the function from taking a
half-dozen arguments to taking an AppShimInfo structure, and pass that
structure directly to AppShimHostBootstrap.

Bug: 982024
Change-Id: Iae45c54751fd66e3dbdb3b711e0bf07b7f901dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786560
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694312}

Using wpt-import in Chromium 848cf7a6.
With Chromium commits locally applied on WPT:
36b875c4 "[WPT/mixed-content] Regenerate test files
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your diff.renameLimit variable to at least 648 and retry the command."
c1907c87 "[WPT/common/security-features] Rename common.js to common.sub.js"
1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js"
bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I0b422bf727f6f91b26640bac1b49d363f70aee02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789882Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694311}

It allows a comparison of UMA data lost when Chrome is running in background
and reduced mode.

Bug: 954310
Change-Id: I2d7a6ac4d4eb5b53e043cbbe2e1e217a3a9a1838
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787463Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694310}

The images stayed black because they were not template images. As
template images, they are tinted by default in
SettingsImageDetailTextCell, so everything looks fine.

Bug: 1001495
Change-Id: Ie06f62b78e28200a2ec6f963c173687eeaeba5df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789313
Auto-Submit: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694309}

This reverts commit 1e78e311.

Reason for revert: crbug.com/1001518

BUG=1001518

Original change's description:
> Enable crOS Account Manager by default
> 
> Chrome OS Account Manager has been enabled for 1% on Stable channel.
> Enable it on ToT as preparation for 100% Stable ramp up.
> 
> TBR=droger@chromium.org
> 
> Bug: 816954
> Change-Id: I6e0097237600e40c39a98e59af063deddd1da9a1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761588
> Reviewed-by: Kush Sinha <sinhak@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Aga Wronska <agawronska@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Commit-Queue: Kush Sinha <sinhak@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689126}

TBR=jamescook@chromium.org,xiyuan@chromium.org,droger@chromium.org,bcwhite@chromium.org,agawronska@chromium.org,sinhak@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 816954
Change-Id: Id32dac1bfd71c618560b5e1ab75ed64b8e3a2e87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789209Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694308}

NVDA now reads table in HungRendererDialogView. AxVirtualView needed to
implement GetTargetForNativeAccessibilityEvent. As of now, this works
for the repro steps in http://crbug.com/998237.

Bug: 998237
Change-Id: Idadf5be2345e56dc6aa14107710adc7685d07584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773569Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Adina Shanholtz <adinas@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#694307}

The present CL addresses what happens in tablet mode if you switch away
from a virtual desk where
(1) There is one window snapped in split view,
(2) There is at least one overview window, and
(3) There is no overview window that can be snapped in split view.

BEFORE: The cannot snap toast appears. If you switch back, you will find
that split view has been ended, and the snapped window became maximized.
AFTER: The cannot snap toast does not appear. You can switch back and
find split view as you left it.

Test: ash_unittests TabletModeDesksTest.SnappedStateRetainedOnSwitchingDesksWithOverviewFullOfUnsnappableWindows
Bug: 996002
Change-Id: I232d8b4a977a51728a61e835c8cbc135b418e37b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780954
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694306}

A lot of things happened during the last few weeks. A lot of tests are
now passing. The filters can be removed.

TBR: lowell@chromium.org
Bug: 999850, 990354
Change-Id: I3c09ff2df036a89efe8bb14ca3b40824fe482f21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789314Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694305}

This IPC was used for tests to synchronize with the renderer from the
browser process. The RenderFrameSubmissionObserver does this job for
us instead now and does not rely on legacy mojo or test-only IPCs. This
CL converts the 3 test cases relying on the old IPC over to use the
RenderFrameSubmissionObserver utility instead.

R=avi@chromium.org, rouslan@chromium.org

Bug: 419087
Change-Id: I61d3cf37f55bfbbf97e73f8523605613d4e9be39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787406Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694304}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/208e343dafad..b3b46a268903

git log 208e343dafad..b3b46a268903 --date=short --no-merges --format='%ad %ae %s'
2019-09-06 brucedawson@chromium.org Have autoninja use -d stats when NINJA_SUMMARIZE_BUILD=1

Created with:
  gclient setdep -r src/third_party/depot_tools@b3b46a268903

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: I389c33af9a0b74b72e4c0016a284a223929c9d27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789944Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694303}

The bindings layer implicitly converts thrown exceptions in promise-returning
functions to promise rejections, and using ExceptionState makes this more
similar to ordinarily throwing exceptions, notably by including the auto-
generated exception context that makes it easier to see what IDL operation
caused an exception to be thrown.

This CL was uploaded by git cl split.

R=reillyg@chromium.org

Bug: 1001114
Change-Id: I6126a5183b44f492dd91a2f74a07b063e87ca0d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787351
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694302}

event_id is calculated by taking a hash from (event, context) pair. Both
event and context are flat dictionaries, they contain only primitive
types. Inside base::DictionaryValue is implemented with flat_map which
stores keys in sorted vector. This gives a stable result when
serializing to json string. Hash will be calculated from those stable
json strings, which gives stable hashes.

Bug: 996213
Change-Id: I2c88ab709bc78dd54471185e52e99a62054752de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783145
Commit-Queue: Askar Aitzhan <askaraitzhan@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694301}

Updating to the latest bundletool version which rolls the R8
version to fix dex fusing issues.

Bug: 996658,1000653
Change-Id: Id635bfdf2d4e839ead74103c507ad80a9759a7c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789178
Commit-Queue: Ben Mason <benmason@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694300}

Not cleanning web_contents pointer can
cause unit tests in the same batch to fail

Bug: 1001181
Change-Id: I0b3178b9afe21302c1316faf34768d1a2856274f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783731Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#694299}

This is to differentiate it from the "frozen" state being applied to
RenderView/Page for BFCache when the Page is navigated away from but the
objects are kept alive.

R=dcheng@chromium.org

Bug: 419087
Change-Id: I6108792f03a3f5cf46acbcf9f113b63256342b03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693169
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694298}

This patch protects against downgrading login database coming from the
future.
This is relevant for use cases when using an old version of Chrome
with a DB created with a new version.

Change-Id: I9744387872bafae758e76de883c219990cbef8c6
Bug: 999514
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787388
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694297}

Authenticators may not include extensions in responses that were not
requested by the platform.

Change-Id: I24c33077b83f90e91cc9c5ccba31366b89be81ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788592Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694296}

Most of this CL was generated by
//base/android/jni_generator/jni_refactorer.py.

This CL was split out from a larger refactoring CL
(crrev.com/c/1782676) because WebsitePreferenceBridge shadows are used
in some unit tests. These now use proxy natives mocking TEST_HOOKS.

Bug: 929661
Change-Id: Ia5d564074b987c0b440b2958635a8cb9fcef33a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784535Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694295}

Bug: 1001371
Change-Id: I1bbf963db8f77ba122f47821e36b491e137dfb1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788685Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Qingsi Wang <qingsi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694294}

Currently ARC++ apps stored as protos defined in
components/policy/proto/device_management_backend.proto, and are being
uploaded to DMServer. In turn DMServer converts those reports to a proto
format defined in
google3/chrome/cros/reporting/proto/chrome_app_install_events.proto,
appends serial_number and gaia_id and redirects those reports to Chrome
Reporting API.

Refactor AppInstall Reporting system to report directly to Chrome
Reporting API.

Bug: 996213
Change-Id: I32239e4713f3d2b804d9710fee60141ce39c0c61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763421Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Askar Aitzhan <askaraitzhan@google.com>
Cr-Commit-Position: refs/heads/master@{#694293}

https://android.googlesource.com/platform/external/perfetto.git/+log/2fb6e6107309..debe648a37fc

git log 2fb6e6107309..debe648a37fc --date=short --no-merges --format='%ad %ae %s'
2019-09-06 fmayer@google.com Add bookkeeping test for empty callstack.

Created with:
  gclient setdep -r src/third_party/perfetto@debe648a37fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I45f824b53264c2c6398b4bb82e30fb7244efa769
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789781Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694292}

Bug: 999287
Change-Id: Ibaded6a03a8b84741c735a20228d84202581901c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788515Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694291}

The current header is being stripped out by GFE, and therefore doesn't
affect the response from the server. Without this current change, we
cannot conduct any server-side experiments based on the Finch
parameter.

Read more about the policy here:
go/gfe-headers

Server-side equivalent:
cl/267619352

Bug: 1001537
Change-Id: I13b2a177bcc4527bb6dd294954da83cedae476b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789665
Commit-Queue: Sebastien Lalancette <seblalancette@google.com>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694290}