- 27 Feb, 2020 39 commits
-
-
John Budorick authored
Noticed this following a discussion about the possibility of gatekeeper for branches. Change-Id: I6b77691936591bd3e6ad8e9938f58e4c742df4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076535Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#744889}
-
sczs authored
We now are sending the animated parameter into dismissViewControllerAnimated, and not YES. Everytime a Banner is finished being presented bannerIsBeingDismissed is set to NO, that way the only way to dismiss a Banner again is to present a new one. Bug: 1049088 Change-Id: Id1bc2adc0bc84a417f2bb320ca815673830b7bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075658Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#744888}
-
Joe Mason authored
Add chrome-memory@google.com as an owner so a larger group will be notified when they expire in a year. Change-Id: I7675e59d27b4d6647fa936fb5da56a41a15e8b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072585Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#744887}
-
Mike Wittman authored
Extends the ModuleCache API to support removing non-native modules via a function that handles adding and removing modules in bulk. This is required for the new V8 unwind API which provides a dynamically updated list of modules at each sample, rather than a static set over the lifetime of the profile collection. Changes the internal native module representation to a set to support efficient lookup. The new V8 unwind API could provide hundreds of modules rather than the few in the existing API. Bug: 1035855 Change-Id: Ib8bc854b613db6f76d55d69aa440067c456e7900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067092Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#744886}
-
dalyk authored
In cases where the secure DNS setting is forcefully overridden by Chrome (e.g. detection of parental controls), this cl replaces the setting subtitle with an explanation. In these cases as well as when the underlying prefs are managed, the setting is locked and the radio buttons are not shown. Change-Id: I27e5b580e09f43bd36a4a924ce4795c06c947c44 Bug: 1040145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984660 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#744885}
-
nancy authored
AppUninstallDialogView replaced the ARC uninstall dialog. https://cs.chromium.org/chromium/src/chrome/browser/ui/views/apps/app_uninstall_dialog_view.h?l=44 Remove ARC uninstall dialog to prepare for "Uninstall" dialog language consistency. Because some variables are used by ARC uninstall dialog, e.g. IDS_APP_UNINSTALL_PROMPT_TITLE, and those variable can be re-used for the AppUninstallDialogView. BUG=1010303 Change-Id: I8af8feb2dfaed62ce5a9ee3c87a490d0af1ff469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073179Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744884}
-
Christopher Thompson authored
This special-cases the LEGACY_TLS status in Page Info on Desktop so that it doesn't cause the certificate to be marked as "Invalid". This also updates the identity status logic to always check and mark legacy TLS pages so that we use the more specific security summary text (which refers to outdated security configurations specifically) for sites that use legacy TLS. Bug: 1056376 Change-Id: I399b79832ba6ffd0b82f8906bc09afe0576c198b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076517Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#744883}
-
sczs authored
These were only needed for iOS10 Bug: 863606 Change-Id: Ie57563c89abc7848d9731d007624c0425205028f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058083Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#744882}
-
Hiroki Sato authored
This is a preparation of exposing accessibility actions of type expand/collapse from Android. Currently there are 32 accessibility actions including kNone, and AXNodeData holds action information as 32 bit integer. This CL changes it to use 64 bit. This CL also changes AddState, RemoveState, AddAction not to return mojom enum because the returned value doesn't makes sense now. Bug: none Test: accessibility_unittests --gtest_filter="AXNodeDataTest*" Change-Id: I07b35f3d2c00c49a74dfdd0af041f7f7e2b4f04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071520Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#744881}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d9a5b6e2c1d2..e7fcd7dde1d9 git log d9a5b6e2c1d2..e7fcd7dde1d9 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 aerotwist@chromium.org Reland "[e2e] Add user metrics tests" 2020-02-26 tvanderlippe@chromium.org Remove tsbuildinfo files from ts_library outputs Created with: gclient setdep -r src/third_party/devtools-frontend/src@e7fcd7dde1d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632,chromium:1053887 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5edb8a6a513e7ad7bc1329bd0798df872e478d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076322Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744880}
-
Chris Cunningham authored
TBR=afakhry@chromium.org Bug: 1049178 Change-Id: I82ef50ebf23e905f45c0bcdc8f3ac4b31cfd026c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075400Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#744879}
-
Yue Zhang authored
After http://crrev.com/c/2026380, TabGridIphItemTest is no longer in use. This CL removes this test class. Bug: 1002678 Change-Id: I00e7cfaca83ec42d45143ef70eef31bc837ba670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076079 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#744878}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8aea6d5a87b8..0a450363dbdc git log 8aea6d5a87b8..0a450363dbdc --date=short --first-parent --format='%ad %ae %s' 2020-02-26 jmadill@chromium.org Fix MultipleDrawBuffers sample. 2020-02-26 tobine@google.com Vulkan:Include precision qualifier in GLSL Created with: gclient setdep -r src/third_party/angle@0a450363dbdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: Icd5d5dee4f3fdafd83281f057e9223f7422e41ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076319Reviewed-by:
-
Henrique Ferreiro authored
ui::CursorType and ui::mojom::CursorType where duplicated enums. This CL extracts the mojom version into its own file to allow ui::Cursor to depend on it avoiding a dependency cycle. It also migrates the codebase to use that version and removes the then unused cursor_types.h. Bug: 1040499 Change-Id: Ic913047a283cf03d0c5fc5f61ee6853d2aa789c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052103Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#744876}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9abfc467c79f..624dae6917b2 git log 9abfc467c79f..624dae6917b2 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 dberris@chromium.org Pinpoint: Preserve parsing specific failures Created with: gclient setdep -r src/third_party/catapult@624dae6917b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1041818 Tbr: sadrul@google.com Change-Id: I6594e7fdb7f72801cf958a0c3e24d0eee1e6868f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076323Reviewed-by:
-
James Cook authored
The file is only compiled on Chrome OS, so the #if isn't needed. Bug: none Change-Id: I6dc128fab4527e12c7d26593922d06143b567343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073220 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#744874}
-
David Staessens authored
This CL moves the AlignedAllocator used in the video encode accelerator unittest to the video test helpers. This allows it to be reused in a subsequent CL introducing new video encoder tests. TEST=./video_encode_accelerator_unittest on nocturne BUG=1045825 Change-Id: I6a4d837d6f365d6b79878a35b69a5f3267a69c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026513 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#744873}
-
Rakesh Soma authored
This can happen in the "AD existing user" scenario where there is no email associated for the ReauthCredential Bug: 1055719 Change-Id: Id6be3412875c9c117da7fb4f36fff20967734620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075974Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#744872}
-
David Staessens authored
This CL Merges the video_accelerator_unittest_helpers.h into the video_test_helpers.h file, to make the video test code cleaner. TEST=./video_encode_accelerator_unittest on nocturne BUG=1045825 Change-Id: I676906f27e5738efb6bd4601c2c715a65592b8e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026632 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
-
David Tseng authored
See go/unified-accessibility-component-extensions for details Test: browser_tests --gtest_filter=SwitchAccess*.* Change-Id: Idfaf157b4b734ce48addaf7961d26832cee960d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075880Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#744870}
-
Clark DuVall authored
Previously, ResourceMapper::MapFromChromiumId has to be called on native resource IDs, which generated an intermediate ID mapping, which then was resolved to a drawable ID when ResourceId.mapToDrawableId() was called on it. This was confusing as the intermediate ID was not a valid native or drawable ID. Now ResourceMapper::MapToJavaDrawableId() returns the drawable ID that can be used directly in java code, eliminating the intermediate mapping. This will also help when componentizing code that depends on ResourceMapper, since we will not need to use ResourceId.mapToDrawableId() on the java side anymore. Bug: 1025609 Change-Id: Ia19a8b915880d974f4d2d6fff87aac9640976656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067656 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#744869}
-
Ella Ge authored
This CL replaces fetching the badge icon with fetching splash icon in WebApk update. With This CL, webapk will request update if the splash icon is changed. Bug: 1043271 Change-Id: Ia297e7cc20fdacd652262fdb9101717526e1a341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037819 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744868}
-
Joel Hockey authored
Add docs for [Export|Import]Container and make functions consistent with ContainerId as first param. Change-Id: I6cc9e4eaf7543050d4a144c61ea9b411d4610c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073917 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#744867}
-
Ahmed Fakhry authored
A layout of the desks bar must be guaranteed even if we think that a bounds change would trigger one implicitly. Otherwise, mini views may not show up at all. See bug for detailed explanation of why this is needed. BUG=1056371 TEST=Manual Change-Id: I0a8464ed1b78f83504924993b9437c25113003d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076659Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#744866}
-
Forest Fraser authored
Bug: b/149108108 Test: Build Change-Id: I59f91b0d042f4d74f16192cd1d693ddcdec53426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076700Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Forest Fraser <ffraser@google.com> Cr-Commit-Position: refs/heads/master@{#744865}
-
Rahul Arakeri authored
This CL fixes an issue where clicking on a faded out scrollbar on Mac caused a gesture scroll. This is fixed by querying the opacity of the PaintedScrollbarLayerImpl and returning a zero delta if the scrollbar opacity is 0. Bug: 1054155 Change-Id: I9ae3b8284b1843b99f15e70a66f7336d956aa810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068204 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#744864}
-
Tomasz Wiszkowski authored
This change adds two new flags to control and modify the Omnibox suggestions behavior: - compact suggestions, aiming at conserving the screen real estate and shrinking suggestions size (allowing more suggestions to be shown by the AdaptiveSuggestions feature), - deferred keyboard popup, that will prevent keyboard from automatically appearing on screen when we have suggestions that we can present to the user. Change-Id: I0965b069048e4a48d013882974668930c790ea13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070604Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#744863}
-
Min Qin authored
BUG=1055425 Change-Id: I25152dd3fbba463d54e0f784359ee335f810e9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073122Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
-
James Darpinian authored
Change-Id: Ifbef2fe8be8ac43a82dccb0151f77048fc7ec664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073063 Auto-Submit: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#744861}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9bda3eea9509..ccb3a54defb5 git log 9bda3eea9509..ccb3a54defb5 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 rsavitski@google.com Merge "traced_perf: enable the static libunwindstack cache" Created with: gclient setdep -r src/third_party/perfetto@ccb3a54defb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7faa07ec00be207dfc46ffd1054d757bd9df43af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076317Reviewed-by:
-
Sean Gilhuly authored
ui::Compositor now interacts with DisplayPrivate directly instead of going through ContextFactoryPrivate. Remove these outdated comments. Bug: 1042259 Change-Id: Ie6ffe831e5cad188a415156feae9eeadde83d055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074816Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#744859}
-
Wez authored
ComponentContextForCurrentProcess() returns a sys::ComponentContext connected to the process' incoming service directory, outgoing directory for services & debugging APIs, etc. Provide a TestComponentContextForProcess, which overrides the process' ComponentContext with one which by default has no services available, and which allows services to be provided by the test itself, and for services available in the test process environment to be exposed to the test. Bug: 1038786 Change-Id: I0d754a1629ab25527dce377d6ffaa039791ef3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064908Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#744858}
-
Peng Huang authored
The device level layers are depercated, and there is no device level layers for now, so remove it. https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#extendingvulkan-layers-devicelayerdeprecation Bug: None Change-Id: I9507191ca515876a8d97140261bd4099f284dfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075965Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
The windows of removed desks should be demoted to be LRU across all desks. That's why they're appended at the end of the overview grid list. However, their relative order should be maintained. This CL makes sure the MRU order is updated to match the above expectation, as well as the windows' stacking order (that is windows of the removed desk should be stacked at the bottom of the target desk's container's children). BUG=1048271 TEST=Expanded existing tests. Change-Id: I06bc69e068e3ffc29bccf7a5983ed6d56fc04830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073366Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#744856}
-
Stefan Zager authored
BUG=1040262 R=pdr@chromium.org Change-Id: I57a115724aac7060de00ece59b8a7da8ca2c347f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076181 Auto-Submit: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#744855}
-
Kent Tamura authored
Fold ControlClipRect implementations into LayoutBox::OverflowClipRect(). De-virtualize LayoutBox::HasControlClip(). As for LayoutFileUploadControl, fold ControlClipRect() into OverflowClipRect(). This CL is a preparation to remove LayoutMenuList. This CL has no behavior changes. Bug: 1040828 Change-Id: I7b68b0498e1554e44bf48de2778631859be2d1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073177Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#744854}
-
Jun Mukai authored
Bug: 1053039, 1053040 Test: none Change-Id: I422c5e2cb1a9511a55cb77c3c75c5fbc712ca792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071254 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#744853}
-
Mike Wittman authored
Requests that the sampling profiler apply metadata to samples between navigation start and first contentful paint, at the time when first contentful paint is sent to the browser process. This metadata will support analysis of execution during page load. This change introduces monotonic time interfaces for the required metrics because the existing interfaces are limited to 1ms resolution. If used they would result in up to 2% of samples being misidentified as occurring during loading when they weren't, or vice versa. This is a reland of http://crrev.com/742717 and adds logic to avoid applying metadata on time ranges that don't make sense but are occasionally seen in practice. TBR=npm@chromium.org,schenney@chromium.org Bug: 1034756, 1054357 Change-Id: Ie7e7a26b4e2c86219eb30dd678e5de296d2f59be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067287Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#744852}
-
Etienne Pierre-doray authored
Android doesn't support shared_library (see native_library_unittest.cc). base_profiler_test_support_library is defined as a loadable_module for upcoming support for android in stack_sampling_profiler_test https://chromium-review.googlesource.com/c/chromium/src/+/2055743/20 Bug: 989102 Change-Id: Iac0f2764f5177820436db93cc4966782a879308d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075158Reviewed-by:
-
- 26 Feb, 2020 1 commit
-
-
Pete Williamson authored
Feedback was being discarded at the server because the contextTag was of the wrong format. Bug: 1054987 Change-Id: I50032b571937a29e2ae63ce550efd25fda004ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076397Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#744850}
-
