- 05 Oct, 2018 40 commits
-
-
Maggie Chen authored
According to Intel, the NV12 overlay format should not be used if DXGI_COLOR_SPACE_YCBCR_STUDIO_G22_LEFT_P709 is not supported. At least one Intel Gen9 SKU will not support NV12 overlay. This color space info is recorded through UMA. BUG=889633 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0406b833e8cfbe0af0a9a408f8e665e3d6e87d77 Reviewed-on: https://chromium-review.googlesource.com/c/1247183Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596970}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d945698c5dfa..1b4ad765627f git log d945698c5dfa..1b4ad765627f --date=short --no-merges --format='%ad %ae %s' 2018-10-05 csmartdalton@google.com ccpr: Unblacklist PowerVR Rogue Created with: gclient setdep -r src/third_party/skia@1b4ad765627f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Ib0c8aa8e1e9b19ccf2a98e5b71a0e8cdf112980b Reviewed-on: https://chromium-review.googlesource.com/c/1262992Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596969}
-
Devlin Cronin authored
If an extension using the webRequest API has access to a.com, and the user visits b.com, and b.com requests a script from a.com, the request will be withheld from the extension. However, we shouldn't badge the extension as wanting to run in this scenario, since invoking the extension won't grant access to a.com (because it's not the tab's origin) or b.com (because the extension didn't request access). Thus, the extension still won't be able to intercept the request. Because there's no actionable behavior, don't badge. Add a test for the same. Bug: 891586 Change-Id: I673bac4cd936f0c659d3c32467c4976daaafe6a7 Reviewed-on: https://chromium-review.googlesource.com/c/1260211 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596968}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b52a7683757..56f1cb670eca Created with: gclient setdep -r src-internal@56f1cb670eca The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I75298dc30da5661706edf7a5e7986132e4fe1b8b Reviewed-on: https://chromium-review.googlesource.com/c/1262991Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596967}
-
Sam McNally authored
TtsHandler doesn't remove itself as a VoicesChangedDelegate on destruction, causing use after frees. Bug: 885311 Change-Id: Id6ed9cd5e9a1caa16e7f095eeeeb6baae1baa327 Reviewed-on: https://chromium-review.googlesource.com/c/1260604 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#596966}
-
Ian Clelland authored
This queues a report through the Reporting API whenever requestMediaKeySystemAccess is called in a frame in which the 'encrypted-media' feature is not allowed according to feature policy. Bug: 867471 Change-Id: I781cf9d9719bcbaffe0b328c2b6bfa5ca197920a Reviewed-on: https://chromium-review.googlesource.com/c/1261921Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#596965}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5b1fa949bba4..8e9443f5b7f8 git log 5b1fa949bba4..8e9443f5b7f8 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@8e9443f5b7f8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I79e3204fc145a5370c84a4f7daf0cbc38821be58 Reviewed-on: https://chromium-review.googlesource.com/c/1262990Reviewed-by:
-
Lei Zhang authored
Change-Id: Ie5b7ffcc5c3e57a0c19895885f8fcdfb843ff59e Reviewed-on: https://chromium-review.googlesource.com/c/1256061Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#596963}
-
Philip Rogers authored
This is a followup to https://crrev.com/593254 and stops changing property trees via the cc::Layer API when using layer lists. The only remaining change is through Layer::UpdateScrollOffset. Bug: 879650 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id2ff7211b7717f0954fe37d6c9aedb7f9a6f7d14 Reviewed-on: https://chromium-review.googlesource.com/c/1262455Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596962}
-
Sam McNally authored
Rename the remaining uses of print_style to histograms_print_style left from https://crrev.com/596921. Bug: 714123 Change-Id: Ia5caab102a50bbee2c28573808ad592d48c6cc1b Tbr: asvitkine@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1263636 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#596961}
-
Tetsui Ohkubo authored
This CL fixes the condition of IME feature pod button to be shown. It should hide the button when a separate IME tray is shown in Shelf. TEST=manual BUG=882824 Change-Id: I4907f3cb01facbcbe7e14cd3329c413bb1adce24 Reviewed-on: https://chromium-review.googlesource.com/c/1255753Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#596960}
-
Istiaque Ahmed authored
Bug: None Change-Id: Idf29937d34e7709957b483a6f25754eb9bf68cdb Reviewed-on: https://chromium-review.googlesource.com/c/1263558Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#596959}
-
John Abd-El-Malek authored
It appears in these crashes that AppCacheURLLoaderJob::Start was never called. Specifically, we know that it's not called with a null client (since binding_ is empty and has no connection error handler). Bug: 882538 Change-Id: I68f1f32cab8d8c2150177702aaa33dccc876f0a0 Reviewed-on: https://chromium-review.googlesource.com/c/1261560Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#596958}
-
Yuichiro Hanada authored
To provide a way to switch IME while ARC IMEs show up, we want to show the IME menu button while the virtual keyboard shows up even if the option is not enabled. Bug: 845079, 882373 Test: manual testing on DUT. Change-Id: Icd5119f3b880e1bf5243d422b9e075c73396d8d0 Reviewed-on: https://chromium-review.googlesource.com/c/1257471 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#596957}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/264079a57aec..aa43b7bb2fcd git log 264079a57aec..aa43b7bb2fcd --date=short --no-merges --format='%ad %ae %s' 2018-10-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c5c13a1e..0af97cea (596716:596847) Created with: gclient setdep -r src/third_party/webrtc@aa43b7bb2fcd The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iac69c67b1742bf683c73600c70fb8ca50db9a171 Reviewed-on: https://chromium-review.googlesource.com/c/1262984Reviewed-by:
-
Kent Tamura authored
Some unit-tests refers files in LayoutTests/. If third_party/blink/web_tests exists, we use it instead of third_party/WebKit/LayoutTests. Bug: 843412 Change-Id: If40d4f8318ccc4914fec07021f1f102b0b68e41b Reviewed-on: https://chromium-review.googlesource.com/c/1260742Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#596955}
-
Matt Wolenetz authored
To prevent potentially regressing legacy buffering-by-DTS MSE apps that may deliberately provide incorrect video keyframeness metadata in their MP4, this change preserves trust in that metadata when MseBufferByPts is not enabled. If MseBufferByPts is enabled, this change preserves the recently added behavior where video frame analysis results' keyframeness (if implemented and determined) is used instead of the MP4's metadata. BUG=892365 R=sandersd@chromium.org TEST=MP4StreamParserTest.*AVC*Mismatches*, also manually confirmed SPS/PPS injection/lack of injection matches the expected sequence of Parsed{Non}Keyframe in those tests. Change-Id: If756e0ee882ec17c0d13d7b400aa43626cedaca9 Reviewed-on: https://chromium-review.googlesource.com/c/1263426 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#596954}
-
Noel Gordon authored
Add a small 100x100px jpeg test image. No change in behavior so no new tests, just adding a resource. Bug: 891150 Change-Id: I3ce460b3e8778b55fdd04fd9fd63891f32b7259f Reviewed-on: https://chromium-review.googlesource.com/c/1263515 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#596953}
-
Vadim Shtayura authored
These configs will be used from LUCI builders. Old configs can be removed all at once when chromium.webkit Buildbot master is brought down. R=dpranke@chromium.org, jchinlee@chromium.org BUG=864817, 818301 Change-Id: Iddc309c9fcd7b5fdce168171524ed051bada9e0e Reviewed-on: https://chromium-review.googlesource.com/c/1262974 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#596952}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6a311a5b505c..7b52a7683757 Created with: gclient setdep -r src-internal@7b52a7683757 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:792928 TBR=mmoss@chromium.org Change-Id: I2a629aa1a09826eb78b178766e1636b9100cde8a Reviewed-on: https://chromium-review.googlesource.com/c/1262983Reviewed-by:
-
Luciano Pacheco authored
This is dead code, since "Add service" migrated to "gear menu" crrev.com/c/1139944. Remove: 1. ADD_NEW_SERVICES_MENU constant from VolumeManagerCommon.RootType. 2. Style and icons specific for displaying "Add service" in the directory tree. 3. Icons that was used for "Add service" in directory tree. 4. NavigationModelMenuItem and MenuItem types. NOTE: Translation strings are still in use in the gear menu so we won't remove them. Bug: 869252 Change-Id: Ic6c0abf74dff6cf2ebf2821b88d930dcd1653bbf Reviewed-on: https://chromium-review.googlesource.com/c/1260882Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#596950}
-
Alex Leung authored
Bug: b:116044941 Change-Id: I9c9ed2bf82164e8fa390ffcc98405085caa5b3ae Reviewed-on: https://chromium-review.googlesource.com/c/1260496Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#596949}
-
Xianzhu Wang authored
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I864d97e21e666b5820e6a17154c1ef8523ba2f45 Reviewed-on: https://chromium-review.googlesource.com/c/1263116Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596948}
-
Xianzhu Wang authored
Sticky constraints are rare, but the structure is relatively big in TransformPaintPropertyNode. Store the field as a unique_ptr to save about 80 bytes in each TransformPaintPropertyNode. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6a1a827049c3e554330fc9462a89a7bc515b6504 Reviewed-on: https://chromium-review.googlesource.com/c/1259982 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e8f574a2167a..5b1fa949bba4 git log e8f574a2167a..5b1fa949bba4 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 ehmaldonado@chromium.org gclient: Sync CIPD deps before running hooks. Created with: gclient setdep -r src/third_party/depot_tools@5b1fa949bba4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:882611 TBR=agable@chromium.org Change-Id: I8c8c5f7ac1ad2e7d92d5cb16224fee000f3b3d80 Reviewed-on: https://chromium-review.googlesource.com/c/1262986Reviewed-by:
-
smut authored
Snapshots will be used to run the actual snapshot tasks, triggered by Snapshot Builder on every VM that needs a snapshot taken. Bug: 723130 Change-Id: I150a38cb4513a5c3c6a8c7f2517d6e0b2ff1f08e Reviewed-on: https://chromium-review.googlesource.com/c/1247523Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#596945}
-
Noel Gordon authored
The tall.html file size is actually 589 bytes. Bug: 891150 Change-Id: I60e695a11dca5043312d6134257a6407612cefe2 Reviewed-on: https://chromium-review.googlesource.com/c/1263536Reviewed-by:
-
Eric Karl authored
As OOP-D doesn't create the surface-backed context in the Browser process, it doesn't receive context creation failures. This patch adds a new function, OnFatalOrSurfaceContextCreationFailure to DisplayClient which notifies the browser on such errors. If the error is fatal, we now crash, matching our previous behavior. Bug: 787086 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1feeae493291a0c4ab5a4fb966311a1ee334a449 Reviewed-on: https://chromium-review.googlesource.com/c/1249572Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#596943}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4302eb9a6e14..d945698c5dfa git log 4302eb9a6e14..d945698c5dfa --date=short --no-merges --format='%ad %ae %s' 2018-10-04 mtklein@google.com remove SkColorSpaceTransferFn::operator()() 2018-10-04 mtklein@google.com Reland "remove deprecated SkRect::MakeFromIRect()" 2018-10-04 csmartdalton@google.com ccpr: Fix a divide-by-zero in corner attenuation 2018-10-04 halcanary@google.com SkDynamicMemoryWStream: make moveable Created with: gclient setdep -r src/third_party/skia@d945698c5dfa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Ic9cb6989f5a0b7bee090d1a76d0656766c3a4ecd Reviewed-on: https://chromium-review.googlesource.com/c/1262985Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/047347605c81..39cf6a765ae3 git log 047347605c81..39cf6a765ae3 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 tsepez@chromium.org Change |virtual ~Foo(){}| to |virtual ~Foo()=default;| 2018-10-04 tsepez@chromium.org Remove some unused code in fxcrt strings. 2018-10-04 thestig@chromium.org Refer to const smart pointers consistently. 2018-10-04 thestig@chromium.org Remove unreachable code in CPDFXFA_Page. 2018-10-04 tsepez@chromium.org Remove null m_page checks from CPDFSDK_PageView. 2018-10-04 tsepez@chromium.org Make some CPWL_FontMap methods pure virtual. Created with: gclient setdep -r src/third_party/pdfium@39cf6a765ae3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I48223bba23e6be14cb4908ee24f873674706ca4c Reviewed-on: https://chromium-review.googlesource.com/c/1262988Reviewed-by:
-
Alexei Svitkine authored
This is a reland of 5e2f1f3a Original change's description: > Fix build breakage caused by Python file rename. > > This was broken by: > https://chromium.googlesource.com/chromium/src/+/5c5ce638e36966b872f26e2df86116388e06fd51 > > TBR=holte@chromium.org > > Bug: 892444 > Change-Id: I8e379fe5d1a76ce01e21cc96c9b4d953dfad40d9 > Reviewed-on: https://chromium-review.googlesource.com/c/1263237 > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596933} Bug: 892444 Change-Id: I3863865f1fd9d322a638d9853e3144428ceacad5 Reviewed-on: https://chromium-review.googlesource.com/c/1263258Reviewed-by:
-
Robert Ogden authored
Uses the standard DRP utilities to do this. Bug: 864658 Change-Id: Ib8b4d5a3df7d89df172138ac3d556e21b5387a81 Reviewed-on: https://chromium-review.googlesource.com/c/1262416 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#596939}
-
Lei Zhang authored
Tbr: lazyboy@chromium.org,sdefresne@chromium.org,vmpstr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I83a254be63d9f07eb06bed1761493110087e69f2 Reviewed-on: https://chromium-review.googlesource.com/c/1253074 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#596938}
-
Findit authored
This reverts commit 5e2f1f3a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 596933 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVlMmYxZjNhNzcyNTU1ODNhZjdkMzU0NGViN2Y0MTljYmM2YWExYmQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-ozone-rel/34894 Sample Failed Step: compile Original change's description: > Fix build breakage caused by Python file rename. > > This was broken by: > https://chromium.googlesource.com/chromium/src/+/5c5ce638e36966b872f26e2df86116388e06fd51 > > TBR=holte@chromium.org > > Bug: 892444 > Change-Id: I8e379fe5d1a76ce01e21cc96c9b4d953dfad40d9 > Reviewed-on: https://chromium-review.googlesource.com/c/1263237 > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596933} Change-Id: Iac4fc3a5f051d899ade31ca7ee2443d029721fd1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 892444 Reviewed-on: https://chromium-review.googlesource.com/c/1263580 Cr-Commit-Position: refs/heads/master@{#596937}
-
Alexei Svitkine authored
This reverts commit 9cf546ab. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Make histograms/pretty_print_test.py run on the bots." > > This reverts commit 5c5ce638. > > Reason for revert: broke the build > > Original change's description: > > Make histograms/pretty_print_test.py run on the bots. > > > > This test was added via: > > https://chromium-review.googlesource.com/1244553 > > > > This is a follow-up CL to add it to metrics_python_tests so > > that it will run on the bots. > > > > Renames Python files to avoid name collisions between > > different scripts, so that they can run together as part of > > metrics_python_tests. Also fixes up the rappor model test > > and adds it to the suite. > > > > Bug: 714123 > > Change-Id: I466584493f7090decdb8b21217347a905b3e6391 > > Reviewed-on: https://chromium-review.googlesource.com/c/1255596 > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#596921} > > TBR=dpranke@chromium.org,asvitkine@chromium.org,holte@chromium.org > > Change-Id: Iebebe68f9c4c4da11e6e79fc14b9853bea737e5c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 714123 > Reviewed-on: https://chromium-review.googlesource.com/c/1263434 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596931} TBR=dcheng@chromium.org,dpranke@chromium.org,asvitkine@chromium.org,holte@chromium.org Change-Id: Ie026170296321cd0cbd4a6fd57506f88388ba295 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 714123 Reviewed-on: https://chromium-review.googlesource.com/c/1263238Reviewed-by:
-
Robert Ma authored
Previously, we only encode the arguments on Windows Python 2.X. This turns out not sufficient. On POSIX systems, if the locale does not use a Unicode encoding (e.g. the default "C" locale when locale isn't set), subprocess.Popen will raise a TypeError if arguments contain non-ASCII characters. This is the case on Swarming bots. This change makes the Executive class also encode the arguments if the system encoding is not UTF-8. Bug: 891831 Change-Id: Idc6fb9201997b5c53e7f29b2d499fce486033b3b Reviewed-on: https://chromium-review.googlesource.com/c/1263045 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
-
Joey Arhar authored
receiveEnd is supposed to be relative to requestTime like waitEnd, and since it was relative to issueTime, having a long queueing time for a request would cause timings.receive to be unreasonably large. Changing it to this also makes it match up with the "Content Download" value in the Timing panel of the request. Bug: 881588 Change-Id: Ib7101b2be6be845464c48958a9b3ad716227844a Reviewed-on: https://chromium-review.googlesource.com/c/1262875Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#596934}
-
Alexei Svitkine authored
This was broken by: https://chromium.googlesource.com/chromium/src/+/5c5ce638e36966b872f26e2df86116388e06fd51 TBR=holte@chromium.org Bug: 892444 Change-Id: I8e379fe5d1a76ce01e21cc96c9b4d953dfad40d9 Reviewed-on: https://chromium-review.googlesource.com/c/1263237 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
dpapad authored
The code still accomodates both the DICE and non-DICE cases, which makes it complicated. Hopefully the non-DICE code can be removed soon. Bug: 876661 Change-Id: I7b457dd79aa4ce88fa301fda9c8f6894d64fa99b Reviewed-on: https://chromium-review.googlesource.com/c/1258091Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#596932}
-
Daniel Cheng authored
This reverts commit 5c5ce638. Reason for revert: broke the build Original change's description: > Make histograms/pretty_print_test.py run on the bots. > > This test was added via: > https://chromium-review.googlesource.com/1244553 > > This is a follow-up CL to add it to metrics_python_tests so > that it will run on the bots. > > Renames Python files to avoid name collisions between > different scripts, so that they can run together as part of > metrics_python_tests. Also fixes up the rappor model test > and adds it to the suite. > > Bug: 714123 > Change-Id: I466584493f7090decdb8b21217347a905b3e6391 > Reviewed-on: https://chromium-review.googlesource.com/c/1255596 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596921} TBR=dpranke@chromium.org,asvitkine@chromium.org,holte@chromium.org Change-Id: Iebebe68f9c4c4da11e6e79fc14b9853bea737e5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 714123 Reviewed-on: https://chromium-review.googlesource.com/c/1263434Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#596931}
-
