- 10 Apr, 2009 25 commits
-
-
aroben@apple.com authored
Rubber-stamped by Steve Falkenburg. No test possible. * platform/win/PopupMenuWin.cpp: (WebCore::registerPopup): Use the CS_DROPSHADOW window class style. git-svn-id: svn://svn.chromium.org/blink/trunk@42401 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
timothy@apple.com authored
from previous pages when toggling the debugger off and back on. https://bugs.webkit.org/show_bug.cgi?id=25095 rdar://problem/6769970 Reviewed by John Sullivan. * bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): Null out the debugger for the scriptController. This balances the attachDebugger that was already in ScriptCachedFrameData::restore. (WebCore::ScriptCachedFrameData::restore): Clean up an if statement. * bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): Clear the debugger from the current window before setting the new window. * inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): Only accumulate source providers for code associated this as the debugger. git-svn-id: svn://svn.chromium.org/blink/trunk@42400 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric.carlson@apple.com authored
Reviewed by Adele Peterson. <rdar://problem/6646998> Avoid starting QTKitServer if possible When possible avoid asking QTKit for the MIME types that require QTKitServer when running 64-bit. * WebCore.base.exp: Added new entry point. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::addFileTypesToCache): Add an NSArray of types to the cache. (WebCore::mimeCommonTypesCache): Add all "common" QTKit types to the cache. (WebCore::mimeModernTypesCache): Add only "modern" QTKit types to the cache (this list does not start QTKitServer if it is not already running). (WebCore::MediaPlayerPrivate::getSupportedTypes): Refactored. (WebCore::MediaPlayerPrivate::supportsType): Look in list of "modern" types first to avoid starting QTKitServer if possible. * platform/mac/WebCoreSystemInterface.h: Add wkQTIncludeOnlyModernMediaFileTypes. * platform/mac/WebCoreSystemInterface.mm: Ditto. 2009-04-10 Pierre d'Herbemont <pdherbemont@apple.com> Reviewed by Adele Peterson. <rdar://problem/6646998> Avoid starting QTKitServer if possible * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Init QTIncludeOnlyModernMediaFileTypes. git-svn-id: svn://svn.chromium.org/blink/trunk@42399 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
We turned these off back when <select> popup menus were partially transparent. Now that they're opaque, there's no reason not to animate them. Reviewed by Steve Falkenburg. No test possible. * platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Remove the #ifdef that was disabling the window animation. git-svn-id: svn://svn.chromium.org/blink/trunk@42398 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mitz@apple.com authored
changes or test changes * platform/win/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@42397 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mitz@apple.com authored
Reviewed by Sam Weinig. - fix a regression from r42379 which made zero-width characters affect line height Test: fixes fast/text/wide-zero-width-space.html * platform/graphics/mac/FontMacATSUI.mm: (WebCore::overrideLayoutOperation): Add to the fallback font list set here, and only if the glyph is not zero-width... (WebCore::ATSULayoutParameters::initialize): ...instead of doing it here. This matches WidthIterator's behavior. LayoutTests: Reviewed by Sam Weinig. - revert broken test results that were checked in with r42379, now that the regression is fixed * platform/mac/fast/text/wide-zero-width-space-expected.checksum: * platform/mac/fast/text/wide-zero-width-space-expected.png: * platform/mac/fast/text/wide-zero-width-space-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@42396 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
Rubber-stamped by Dan Bernstein. * platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: * platform/win/fast/text/international/complex-character-based-fallback-expected.png: * platform/win/fast/text/international/complex-character-based-fallback-expected.txt: Updated. git-svn-id: svn://svn.chromium.org/blink/trunk@42395 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
darin@chromium.org authored
Fixing build bustage caused by warnings being treated as errors. 1- A local variable was only be used inside a debug assertion, which caused grief for the release build. 2- Missing initializer for member 'DocumentMarker::activeMatch' * dom/Document.cpp: (WebCore::Document::addMarker): (WebCore::Document::setMarkersActive): git-svn-id: svn://svn.chromium.org/blink/trunk@42394 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
darin@chromium.org authored
Reviewed by John Sullivan. Fixing: https://bugs.webkit.org/show_bug.cgi?id=25117 (TextMatches don't have a concept of active match) For the ports that use the DocumentMarker as highlighting for FindInPage it is useful to have a flag that specifies which marker is active, so it can be drawn in a different color. This allows me to remove the hack to use the SelectionController to highlight the active match (in the ChromiumWin port). * dom/Document.cpp: (WebCore::Document::setMarkersActive): * dom/Document.h: * dom/DocumentMarker.h: * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintTextMatchMarker): * rendering/RenderTheme.cpp: (WebCore::RenderTheme::platformActiveTextSearchHighlightColor): (WebCore::RenderTheme::platformInactiveTextSearchHighlightColor): * rendering/RenderTheme.h: * rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor): (WebCore::RenderThemeChromiumWin::platformInactiveTextSearchHighlightColor): * rendering/RenderThemeChromiumWin.h: git-svn-id: svn://svn.chromium.org/blink/trunk@42393 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pam@chromium.org authored
Reviewed by Dimitri Glazkov. Build fix for Chromium. https://bugs.webkit.org/show_bug.cgi?id=12440 * page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame): change docWidth() to overflowWidth() git-svn-id: svn://svn.chromium.org/blink/trunk@42392 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kov@webkit.org authored
2009-04-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> Reviewed by Holger Freyther. https://bugs.webkit.org/show_bug.cgi?id=25124 [GTK] many strings still missing translation calls Mark the missing strings for translation. * webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_cancel): * webkit/webkitsoupauthdialog.c: (show_auth_dialog): * webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init): * webkit/webkitwebinspector.cpp: (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init): * webkit/webkitwebnavigationaction.cpp: (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init): * webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): * webkit/webkitwebview.cpp: WebKit/gtk/po/ 2009-04-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> Reviewed by Holger Freyther. https://bugs.webkit.org/show_bug.cgi?id=25124 [GTK] many strings still missing translation calls Extracting translation for the files that got translation calls. * POTFILES: * de.po: * pt_BR.po: * webkit.pot: git-svn-id: svn://svn.chromium.org/blink/trunk@42391 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mitz@apple.com authored
* platform/mac/fast/events/pointer-events-expected.txt: Removed. * platform/mac/fast/events/pointer-events.html: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@42390 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mitz@apple.com authored
- moved some Leopard-and-earlier results into platform/mac-leopard and added new results under platform/mac * platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.checksum. * platform/mac-leopard/fast/text/complex-text-opacity-expected.png: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.png. * platform/mac-leopard/fast/text/complex-text-opacity-expected.txt: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.txt. * platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum. * platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.png. * platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.txt. * platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum. * platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png. * platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt. * platform/mac/fast/events/pointer-events-expected.txt: Added. * platform/mac/fast/events/pointer-events.html: Added. * platform/mac/fast/text/atsui-multiple-renderers-expected.checksum: * platform/mac/fast/text/atsui-multiple-renderers-expected.png: * platform/mac/fast/text/atsui-multiple-renderers-expected.txt: * platform/mac/fast/text/complex-text-opacity-expected.checksum: Replaced. * platform/mac/fast/text/complex-text-opacity-expected.png: Replaced. * platform/mac/fast/text/complex-text-opacity-expected.txt: Replaced. * platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum: Replaced. * platform/mac/fast/text/international/bidi-AN-after-L-expected.png: Replaced. * platform/mac/fast/text/international/bidi-AN-after-L-expected.txt: Replaced. * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Added. * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added. * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt: * platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum: Added. * platform/mac/fast/text/international/bidi-CS-after-AN-expected.png: Added. * platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt: * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Replaced. * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Replaced. * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Replaced. * platform/mac/fast/text/international/bidi-neutral-run-expected.checksum: Added. * platform/mac/fast/text/international/bidi-neutral-run-expected.png: Added. * platform/mac/fast/text/international/bidi-neutral-run-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@42389 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jmalonzo@webkit.org authored
Unreviewed Gtk build fix for undefined reference: g_thread_init. Add GLIB_LIBS to DRT and GtkLauncher build config. * GNUmakefile.am: git-svn-id: svn://svn.chromium.org/blink/trunk@42388 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rdar://problem/6718460mrowe@apple.com authored
* platform/mac-snowleopard/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@42387 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrowe@apple.com authored
Rubber-stamped by Oliver Hunt. * platform/mac-snowleopard/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@42386 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mitz@apple.com authored
- update Tiger-only test results after r42379 * platform/mac-tiger/fast/lists/w3-list-styles-expected.txt: * platform/mac-tiger/fast/text/cg-fallback-bolding-expected.txt: * platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@42385 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hyatt@apple.com authored
Reviewed by Oliver Hunt Add a timer for style recalc (similar to the one used for scheduling layouts). For now in order to reduce the risk of regressions, I have left in all the synchronous machinery for updating style following DOM events and JavaScript timeouts. Eventually these calls will be removed. Where the timer will really kick in and be useful is for clients that do style changes from Objective-C DOM bindings or that execute JavaScript to manipulate style from the JavaScriptCore C API. * dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::appendChild): * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::unscheduleStyleRecalc): (WebCore::Document::styleRecalcTimerFired): (WebCore::Document::updateStyleForAllDocuments): (WebCore::Document::detach): * dom/Document.h: * dom/Node.cpp: (WebCore::Node::setNeedsStyleRecalc): (WebCore::Node::lazyAttach): git-svn-id: svn://svn.chromium.org/blink/trunk@42384 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrowe@apple.com authored
Land Windows-specific results for three forms tests since the Windows results match the Leopard results. Rubber-stamped by Adam Roben. * platform/win/fast/forms/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-disabled-expected.txt. * platform/win/fast/forms/input-text-maxlength-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt. * platform/win/fast/forms/input-text-paste-maxlength-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt. git-svn-id: svn://svn.chromium.org/blink/trunk@42383 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rdar://problem/6586787oliver@apple.com authored
Reviewed by Gavin Barraclough Don't truncate the source id in JSCallFrame git-svn-id: svn://svn.chromium.org/blink/trunk@42382 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rdar://problem/5438063aroben@apple.com authored
Windows part 1 of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing WebCore: Start compiling HistoryPropertyList on Windows Reviewed by Darin Adler. * WebCore.vcproj/WebCore.vcproj: Added HistoryPropertyList and its dependencies to the project. Copy headers from history/cf to $WebKitOutputDir. * history/cf/HistoryPropertyList.cpp: Added StringExtras.h so that this file will compile on Windows. WebKit/win: Windows part 1 of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing Use HistoryPropertyListWriter to implement IWebHistory::saveToURL. Reviewed by Darin Adler. * WebHistory.cpp: (WebHistoryWriter::WebHistoryWriter): Added. (WebHistoryWriter::writeHistoryItems): Added. Loop backwards through the entries for each date, and pass the corresponding WebCore::HistoryItem to writeHistoryItem. (WebHistory::saveHistoryGuts): Use WebHistoryWriter to serialize m_entriesByDate, then write the serialized data to disk using CFWriteStream. * WebHistory.h: Removed datesArray. git-svn-id: svn://svn.chromium.org/blink/trunk@42381 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrowe@apple.com authored
Rubber-stamped by Dan Bernstein. * platform/mac-leopard/fast/forms/disabled-select-change-index-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.checksum. * platform/mac-leopard/fast/forms/disabled-select-change-index-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.png. * platform/mac-leopard/fast/forms/disabled-select-change-index-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.txt. * platform/mac-leopard/fast/forms/file-input-disabled-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.checksum. * platform/mac-leopard/fast/forms/file-input-disabled-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.png. * platform/mac-leopard/fast/forms/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.txt. * platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.checksum. * platform/mac-leopard/fast/forms/input-text-maxlength-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.png. * platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.txt. * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.checksum. * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.png. * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.txt. * platform/mac/fast/forms/disabled-select-change-index-expected.txt: * platform/mac/fast/forms/file-input-disabled-expected.txt: * platform/mac/fast/forms/input-text-maxlength-expected.txt: * platform/mac/fast/forms/input-text-paste-maxlength-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@42380 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mitz@apple.com authored
2009-04-09 Dan Bernstein <mitz@apple.com> Reviewed by Dave Hyatt. - fix <rdar://problem/6166612> Text boxes' metrics should be based on the actual fonts used in them, not just the primary font Covered by many existing layout tests * platform/graphics/Font.cpp: (WebCore::Font::floatWidth): Added a fallbackFonts parameter. If the platform supports collecting fallback fonts in its complex font path and fallbackFonts is not null, all fallback fonts used for the text run will be added to it. * platform/graphics/Font.h: (WebCore::Font::width): Ditto. * platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Removed an unnecessary namespace qualifier. (WebCore::Font::floatWidthForSimpleText): Added a fallbackFonts parameter, which is passed down to WidthIterator. * platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::WidthIterator): Added a fallbackFonts parameter and used it to initialize the m_fallbackFonts member. (WebCore::WidthIterator::advance): Track the fonts being used and add any fallback fonts to the m_fallbackFonts set. Make sure to only add non-small-caps fonts. * platform/graphics/WidthIterator.h: * platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns false, meaning this platform's implementation of floatWidthForComplexText() does not populate the fallbackFonts set. (WebCore::Font::floatWidthForComplexText): Updated for the new prototype. * platform/graphics/chromium/FontLinux.cpp: Ditto. * platform/graphics/gtk/FontGtk.cpp: Ditto. * platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::CoreTextController): Added a fallbackFonts parameter and used it to initialize the m_fallbackFonts member. (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Add fallback fonts to m_fallbackFonts. * platform/graphics/mac/CoreTextController.h: * platform/graphics/mac/FontMac.mm: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns true, indicating that the Mac implementations of floatWidthForComplexText() populate the fallbackFonts set. * platform/graphics/mac/FontMacATSUI.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): Added a fallbackFonts parameter and used it to initialize the m_fallbackFonts member. (WebCore::ATSULayoutParameters::initialize): Add fallback fonts to m_fallbackFonts. (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts parameter, which is passed down to ATSULayoutParameters. * platform/graphics/mac/FontMacCoreText.cpp: (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts parameter, which is passed down to CoreTextController. * platform/graphics/win/FontWin.cpp: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns true, indicating that the UniscribeController-based implementations of floatWidthForComplexText() populate the fallbackFonts set. (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts parameter, which is passed down to UniscribeController. * platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::UniscribeController): Added a fallbackfonts parameter and used it to initialize m_fallbackFonts. (WebCore::UniscribeController::advance): Add fallback fonts to m_fallbackFonts. * platform/graphics/win/UniscribeController.h: * platform/graphics/wx/FontWx.cpp: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns false, meaning this platform's implementation of floatWidthForComplexText() does not populate the fallbackFonts set. (WebCore::Font::floatWidthForComplexText): Updated for the new prototype. * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeLogicalBoxHeights): For an InlineTextBox with multiple fonts, compute a common baseline and line height by considering all fonts' ascents and descents (and line spacing, if applicable). * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::setFallbackFonts): Added. Temporarily stores the set of fallback fonts in a vector. (WebCore::InlineTextBox::takeFallbackFonts): Added. Returns the fallback fonts previously stored and removes them from storage. * rendering/InlineTextBox.h: * rendering/RenderText.cpp: (WebCore::RenderText::RenderText): Initialized the m_knownNotToUseFallbackFonts to false. (WebCore::RenderText::styleDidChange): Reset m_knownNotToUseFallbackFonts to false if the style difference is such that affects layout. (WebCore::RenderText::widthFromCache): Added a fallbackFonts parameter, which is passed down to Font::width(). (WebCore::RenderText::trimmedPrefWidths): Updated for the change to widthFromCache(). (WebCore::RenderText::calcPrefWidths): Made this call a private version of calcPrefWidths() that takes a fallbackFonts parameter and set the m_knownNotToUseFallbackFonts to true if the set comes back empty. The private version passes the fallbackFonts set to widthFromCache(). (WebCore::RenderText::setText): Reset m_knownNotToUseFallbackFonts to false. (WebCore::RenderText::createFallbackFontMetricsBox): Added. (WebCore::RenderText::width): Added a fallbackFonts parameter, which is passed down to calcPrefWidths(), widthFromCache() and Font::width(). Set m_knownNotToUseFallbackFonts to true when appropriate. * rendering/RenderText.h: * rendering/bidi.cpp: (WebCore::RenderBlock::constructLine): Added an assertion and a continue statement to remove one level of indentation. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Temporarily store the set of fallback fonts in the InlineTextBox. (WebCore::RenderBlock::computeVerticalPositionsForLine): Added an assertion. LayoutTests: 2009-04-09 Dan Bernstein <mitz@apple.com> Reviewed by Dave Hyatt. - updated results for <rdar://problem/6166612> Text boxes' metrics should be based on the actual fonts used in them, not just the primary font * editing/selection/extend-selection-bidi-expected.txt: * fast/text/offsetForPosition-cluster-at-zero-expected.txt: * platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.checksum: * platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.png: * platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.txt: * platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.checksum: * platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.png: * platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: * platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.checksum: * platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.png: * platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt: * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png: * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: * platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: * platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png: * platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: * platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum: * platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png: * platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: * platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum: * platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png: * platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: * platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum: * platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png: * platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: * platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum: * platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png: * platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: * platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum: * platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: * platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: * platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum: * platform/mac/css2.1/t0905-c414-flt-02-c-expected.png: * platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt: * platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum: * platform/mac/css2.1/t0905-c414-flt-03-c-expected.png: * platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt: * platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum: * platform/mac/css2.1/t0905-c414-flt-04-c-expected.png: * platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt: * platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum: * platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: * platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: * platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum: * platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png: * platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt: * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt: * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: * platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum: * platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png: * platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt: * platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum: * platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png: * platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt: * platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum: * platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png: * platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt: * platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum: * platform/mac/css2.1/t090501-c414-flt-01-b-expected.png: * platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt: * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum: * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png: * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt: * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum: * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt: * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum: * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt: * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum: * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png: * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt: * platform/mac/css2.1/t1202-counter-03-b-expected.checksum: * platform/mac/css2.1/t1202-counter-03-b-expected.png: * platform/mac/css2.1/t1202-counter-03-b-expected.txt: * platform/mac/css2.1/t1202-counter-04-b-expected.checksum: * platform/mac/css2.1/t1202-counter-04-b-expected.png: * platform/mac/css2.1/t1202-counter-04-b-expected.txt: * platform/mac/css2.1/t1202-counter-09-b-expected.checksum: * platform/mac/css2.1/t1202-counter-09-b-expected.png: * platform/mac/css2.1/t1202-counter-09-b-expected.txt: * platform/mac/css2.1/t1202-counters-03-b-expected.checksum: * platform/mac/css2.1/t1202-counters-03-b-expected.png: * platform/mac/css2.1/t1202-counters-03-b-expected.txt: * platform/mac/css2.1/t1202-counters-04-b-expected.checksum: * platform/mac/css2.1/t1202-counters-04-b-expected.png: * platform/mac/css2.1/t1202-counters-04-b-expected.txt: * platform/mac/css2.1/t1202-counters-09-b-expected.checksum: * platform/mac/css2.1/t1202-counters-09-b-expected.png: * platform/mac/css2.1/t1202-counters-09-b-expected.txt: * platform/mac/editing/deleting/5144139-2-expected.checksum: * platform/mac/editing/deleting/5144139-2-expected.png: * platform/mac/editing/deleting/5144139-2-expected.txt: * platform/mac/editing/input/devanagari-ligature-expected.checksum: * platform/mac/editing/input/devanagari-ligature-expected.png: * platform/mac/editing/input/devanagari-ligature-expected.txt: * platform/mac/editing/pasteboard/copy-paste-bidi-expected.checksum: * platform/mac/editing/pasteboard/copy-paste-bidi-expected.png: * platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt: * platform/mac/editing/selection/caret-rtl-2-expected.checksum: * platform/mac/editing/selection/caret-rtl-2-expected.png: * platform/mac/editing/selection/caret-rtl-2-expected.txt: * platform/mac/editing/selection/caret-rtl-expected.checksum: * platform/mac/editing/selection/caret-rtl-expected.png: * platform/mac/editing/selection/caret-rtl-expected.txt: * platform/mac/editing/selection/extend-selection-bidi-expected.checksum: * platform/mac/editing/selection/extend-selection-bidi-expected.png: * platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum: * platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png: * platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt: * platform/mac/fast/css/rtl-ordering-expected.checksum: * platform/mac/fast/css/rtl-ordering-expected.png: * platform/mac/fast/css/rtl-ordering-expected.txt: * platform/mac/fast/css/text-overflow-ellipsis-expected.checksum: * platform/mac/fast/css/text-overflow-ellipsis-expected.png: * platform/mac/fast/css/text-overflow-ellipsis-expected.txt: * platform/mac/fast/css/text-security-expected.checksum: * platform/mac/fast/css/text-security-expected.png: * platform/mac/fast/css/text-security-expected.txt: * platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum: * platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png: * platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt: * platform/mac/fast/encoding/invalid-UTF-8-expected.checksum: * platform/mac/fast/encoding/invalid-UTF-8-expected.png: * platform/mac/fast/encoding/invalid-UTF-8-expected.txt: * platform/mac/fast/events/updateLayoutForHitTest-expected.checksum: * platform/mac/fast/events/updateLayoutForHitTest-expected.png: * platform/mac/fast/events/updateLayoutForHitTest-expected.txt: * platform/mac/fast/forms/select-visual-hebrew-expected.checksum: * platform/mac/fast/forms/select-visual-hebrew-expected.png: * platform/mac/fast/forms/select-visual-hebrew-expected.txt: * platform/mac/fast/forms/select-writing-direction-natural-expected.checksum: * platform/mac/fast/forms/select-writing-direction-natural-expected.png: * platform/mac/fast/forms/select-writing-direction-natural-expected.txt: * platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum: * platform/mac/fast/forms/visual-hebrew-text-field-expected.png: * platform/mac/fast/forms/visual-hebrew-text-field-expected.txt: * platform/mac/fast/lists/w3-list-styles-expected.checksum: * platform/mac/fast/lists/w3-list-styles-expected.png: * platform/mac/fast/lists/w3-list-styles-expected.txt: * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt: * platform/mac/fast/text/capitalize-boundaries-expected.checksum: * platform/mac/fast/text/capitalize-boundaries-expected.png: * platform/mac/fast/text/capitalize-boundaries-expected.txt: * platform/mac/fast/text/cg-fallback-bolding-expected.checksum: * platform/mac/fast/text/cg-fallback-bolding-expected.png: * platform/mac/fast/text/cg-fallback-bolding-expected.txt: * platform/mac/fast/text/complex-text-opacity-expected.checksum: * platform/mac/fast/text/complex-text-opacity-expected.png: * platform/mac/fast/text/complex-text-opacity-expected.txt: * platform/mac/fast/text/in-rendered-text-rtl-expected.checksum: * platform/mac/fast/text/in-rendered-text-rtl-expected.png: * platform/mac/fast/text/in-rendered-text-rtl-expected.txt: * platform/mac/fast/text/international/001-expected.checksum: * platform/mac/fast/text/international/001-expected.png: * platform/mac/fast/text/international/001-expected.txt: * platform/mac/fast/text/international/002-expected.checksum: * platform/mac/fast/text/international/002-expected.png: * platform/mac/fast/text/international/002-expected.txt: * platform/mac/fast/text/international/003-expected.checksum: * platform/mac/fast/text/international/003-expected.png: * platform/mac/fast/text/international/003-expected.txt: * platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum: * platform/mac/fast/text/international/bidi-AN-after-L-expected.png: * platform/mac/fast/text/international/bidi-AN-after-L-expected.txt: * platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum: * platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png: * platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt: * platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum: * platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png: * platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt: * platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum: * platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png: * platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt: * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png: * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt: * platform/mac/fast/text/international/bidi-european-terminators-expected.checksum: * platform/mac/fast/text/international/bidi-european-terminators-expected.png: * platform/mac/fast/text/international/bidi-european-terminators-expected.txt: * platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum: * platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png: * platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt: * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: * platform/mac/fast/text/international/bidi-innertext-expected.checksum: * platform/mac/fast/text/international/bidi-innertext-expected.png: * platform/mac/fast/text/international/bidi-innertext-expected.txt: * platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum: * platform/mac/fast/text/international/bidi-linebreak-001-expected.png: * platform/mac/fast/text/international/bidi-linebreak-001-expected.txt: * platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum: * platform/mac/fast/text/international/bidi-linebreak-002-expected.png: * platform/mac/fast/text/international/bidi-linebreak-002-expected.txt: * platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum: * platform/mac/fast/text/international/bidi-linebreak-003-expected.png: * platform/mac/fast/text/international/bidi-linebreak-003-expected.txt: * platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum: * platform/mac/fast/text/international/bidi-listbox-atsui-expected.png: * platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt: * platform/mac/fast/text/international/bidi-listbox-expected.checksum: * platform/mac/fast/text/international/bidi-listbox-expected.png: * platform/mac/fast/text/international/bidi-listbox-expected.txt: * platform/mac/fast/text/international/bidi-menulist-expected.checksum: * platform/mac/fast/text/international/bidi-menulist-expected.png: * platform/mac/fast/text/international/bidi-menulist-expected.txt: * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: * platform/mac/fast/text/international/bidi-override-expected.checksum: * platform/mac/fast/text/international/bidi-override-expected.png: * platform/mac/fast/text/international/bidi-override-expected.txt: * platform/mac/fast/text/international/hindi-spacing-expected.checksum: * platform/mac/fast/text/international/hindi-spacing-expected.png: * platform/mac/fast/text/international/hindi-spacing-expected.txt: * platform/mac/fast/text/international/rtl-caret-expected.checksum: * platform/mac/fast/text/international/rtl-caret-expected.png: * platform/mac/fast/text/international/rtl-caret-expected.txt: * platform/mac/fast/text/international/thai-line-breaks-expected.checksum: * platform/mac/fast/text/international/thai-line-breaks-expected.png: * platform/mac/fast/text/international/thai-line-breaks-expected.txt: * platform/mac/fast/text/international/wrap-CJK-001-expected.checksum: * platform/mac/fast/text/international/wrap-CJK-001-expected.png: * platform/mac/fast/text/international/wrap-CJK-001-expected.txt: * platform/mac/fast/text/wide-zero-width-space-expected.checksum: * platform/mac/fast/text/wide-zero-width-space-expected.png: * platform/mac/fast/text/wide-zero-width-space-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@42379 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kdecker@apple.com authored
<rdar://problem/4680397> tearing seen because deferred updates are disabled * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): Don't call WKDisableCGDeferredUpdates on post-Leopard if NSAppKitVersionNumberWithDeferredWindowDisplaySupport is defined. git-svn-id: svn://svn.chromium.org/blink/trunk@42378 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hyatt@apple.com authored
Reviewed by Adam Roben Rename all of the changed()/setChanged()/setDocumentChanged() methods to mention style recalc explicitly instead. * bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent): * bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent): * bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent): * bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent): * bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent): * bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent): * bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent): * bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI): * bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): * bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): * bindings/js/ScriptControllerMac.mm: (WebCore::updateStyleIfNeededForBindings): (WebCore::ScriptController::initJavaJSBindings): * css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removeProperty): (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc): (WebCore::CSSMutableStyleDeclaration::setProperty): (WebCore::CSSMutableStyleDeclaration::setStringProperty): (WebCore::CSSMutableStyleDeclaration::setImageProperty): (WebCore::CSSMutableStyleDeclaration::parseDeclaration): (WebCore::CSSMutableStyleDeclaration::addParsedProperties): (WebCore::CSSMutableStyleDeclaration::setCssText): (WebCore::CSSMutableStyleDeclaration::merge): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): * css/CSSMutableStyleDeclaration.h: * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::allVisitedStateChanged): (WebCore::CSSStyleSelector::SelectorChecker::visitedStateChanged): * css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::setVariable): (WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc): * css/CSSVariablesDeclaration.h: * dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::detach): (WebCore::ContainerNode::setFocus): (WebCore::ContainerNode::setActive): (WebCore::ContainerNode::setHovered): * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::unscheduleStyleRecalc): (WebCore::Document::recalcStyle): (WebCore::Document::updateStyleIfNeeded): (WebCore::Document::updateStyleForAllDocuments): (WebCore::Document::updateLayout): (WebCore::Document::implicitClose): (WebCore::Document::prepareMouseEvent): (WebCore::Document::setFocusedNode): (WebCore::Document::setCSSTarget): * dom/Document.h: * dom/Element.cpp: (WebCore::Element::recalcStyle): (WebCore::checkForSiblingStyleChanges): * dom/InputElement.cpp: (WebCore::InputElement::parseMaxLengthAttribute): * dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget): * dom/Node.cpp: (WebCore::Node::Node): (WebCore::Node::setNeedsStyleRecalc): (WebCore::Node::lazyAttach): (WebCore::Node::dispatchGenericEvent): * dom/Node.h: (WebCore::Node::needsStyleRecalc): (WebCore::Node::childNeedsStyleRecalc): (WebCore::Node::setChildNeedsStyleRecalc): * dom/OptionElement.cpp: (WebCore::OptionElement::setSelectedState): * dom/ScriptElement.cpp: (WebCore::ScriptElementData::evaluateScript): * dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged): (WebCore::StyledElement::classAttributeChanged): (WebCore::StyledElement::parseMappedAttribute): * dom/Text.cpp: (WebCore::Text::recalcStyle): * dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::insertErrorMessageBlock): * editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::enable): * editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection): * editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): (WebCore::SelectionController::layout): (WebCore::SelectionController::focusedOrActiveStateChanged): * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute): * html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerText): (WebCore::HTMLElement::isContentEditable): (WebCore::HTMLElement::isContentRichlyEditable): (WebCore::HTMLElement::contentEditable): * html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget): * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::parseMappedAttribute): * html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::recalcStyle): * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::setIndeterminate): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setAutofilled): * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::finishParsingChildren): * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget): (WebCore::HTMLObjectElement::finishParsingChildren): (WebCore::HTMLObjectElement::childrenChanged): * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::restoreState): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::typeAheadFind): * html/HTMLTableElement.cpp: (WebCore::setTableCellsChanged): (WebCore::HTMLTableElement::parseMappedAttribute): * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): * loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::gotoAnchor): * page/DOMWindow.cpp: (WebCore::DOMWindow::alert): (WebCore::DOMWindow::confirm): (WebCore::DOMWindow::prompt): * page/EventHandler.cpp: (WebCore::EventHandler::hoverTimerFired): * page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::needsLayout): * page/animation/AnimationBase.cpp: (WebCore::AnimationBase::setNeedsStyleRecalc): (WebCore::AnimationBase::updateStateMachine): * page/animation/AnimationBase.h: * page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::clear): (WebCore::AnimationControllerPrivate::updateAnimationTimer): (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired): (WebCore::AnimationControllerPrivate::startupdateStyleIfNeededDispatcher): (WebCore::AnimationControllerPrivate::addEventToDispatch): (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch): (WebCore::AnimationControllerPrivate::animationTimerFired): (WebCore::AnimationControllerPrivate::pauseAnimationAtTime): (WebCore::AnimationControllerPrivate::pauseTransitionAtTime): (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList): (WebCore::AnimationController::cancelAnimations): * page/animation/AnimationControllerPrivate.h: * page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::sendTransitionEvent): * page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::endAnimation): (WebCore::KeyframeAnimation::sendAnimationEvent): * rendering/RenderObject.cpp: (WebCore::RenderObject::updateDragState): * rendering/RenderView.cpp: (WebCore::RenderView::selectionBounds): * svg/SVGAElement.cpp: (WebCore::SVGAElement::svgAttributeChanged): * svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): * svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::svgAttributeChanged): * svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::setNeedsUpdate): * svg/SVGForeignObjectElement.cpp: (WebCore::addCSSPropertyAndNotifyAttributeMap): * svg/SVGStopElement.cpp: (WebCore::SVGStopElement::parseMappedAttribute): * svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::parseMappedAttribute): * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::childrenChanged): (WebCore::SVGUseElement::recalcStyle): * svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::updateAnimations): * wml/WMLAElement.cpp: (WebCore::WMLAElement::parseMappedAttribute): * wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::parseMappedAttribute): * wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument): git-svn-id: svn://svn.chromium.org/blink/trunk@42377 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 09 Apr, 2009 15 commits
-
-
sullivan@apple.com authored
<rdar://problem/6775682> WebKit's support for SnowLeopard sudden termination for downloads is broken and should be removed Reviewed by Darin Adler * Misc/WebDownload.m: (-[WebDownloadInternal downloadDidBegin:]): remove disableSuddenTermination call (-[WebDownloadInternal downloadDidFinish:]): remove enableSuddenTermination call (-[WebDownloadInternal download:didFailWithError:]): remove enableSuddenTermination call git-svn-id: svn://svn.chromium.org/blink/trunk@42376 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
brettw@chromium.org authored
Reviewed by NOBODY (OOPS!). When there is a shadow set but it specifies "no shadow", clear the shadow shader. This will prevent Chromium from thinking there's a shadow and using the Skia codepath rather than Windows. * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow): git-svn-id: svn://svn.chromium.org/blink/trunk@42375 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Crash when accessing svg.viewport on a detached SVGSVGElement https://bugs.webkit.org/show_bug.cgi?id=25105 * svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::isOutermostSVG): return "true" that we are the "outermost" SVG element if we have no parent. (The spec is unclear as t o what behavior we should have in this case, and I doubt anyone cares for now). git-svn-id: svn://svn.chromium.org/blink/trunk@42374 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dimich@chromium.org authored
Reviewed by Dimitri Glazkov. https://bugs.webkit.org/show_bug.cgi?id=25084 Upstream changes to V8 bindings for XHR so that it can work under either DOMWindow or WorkerContext. * bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::retrieve): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper): (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener): (WebCore::WorkerContextExecutionProxy::findOrCreateObjectEventListener): * bindings/v8/WorkerContextExecutionProxy.h: * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): git-svn-id: svn://svn.chromium.org/blink/trunk@42373 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
darin@apple.com authored
2009-04-09 Darin Adler <darin@apple.com> Reviewed by Anders Carlsson and Sam Weinig. Part of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing Longer term solution is to change the design so Safari doesn't read and write all of history. This patch is step one: Do the serializing, which is done on the main thread, much faster. * WebCore.base.exp: Added new entry points. * WebCore.xcodeproj/project.pbxproj: Added new source files. * history/cf: Added. * history/cf/HistoryPropertyList.cpp: Added. * history/cf/HistoryPropertyList.h: Added. Code to write history files. In the future we'll also have code for reading here too. * platform/cf/BinaryPropertyList.cpp: Added. * platform/cf/BinaryPropertyList.h: Added. Code to write binary property list files. WebKit/mac: 2009-04-09 Darin Adler <darin@apple.com> Reviewed by Anders Carlsson and Sam Weinig. Part of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing Longer term solution is to change the design so Safari doesn't read and write all of history. This patch is step one: Do the serializing, which is done on the main thread, much faster. * History/WebHistory.mm: (-[WebHistoryPrivate data]): Added. Returns the NSData object containing serialized history. For creating new SPI so you can get the data in memory instead of on disk. Uses WebHistoryWriter. (-[WebHistoryPrivate saveToURL:error:]): Changed to call [self data (-[WebHistory _data]): Added. (WebHistoryWriter::WebHistoryWriter): Added. (WebHistoryWriter::writeHistoryItems): Added. * History/WebHistoryPrivate.h: Added a new _data method. git-svn-id: svn://svn.chromium.org/blink/trunk@42372 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
simon.fraser@apple.com authored
Reviewed by Antti Koivisto https://bugs.webkit.org/show_bug.cgi?id=25122 If deferred repainting is active, we need to ensure that there are no repaints pending at the end of layoutIfNeededRecursive, which is called just before painting via -viewWillDraw. * page/FrameView.cpp: (WebCore::FrameView::layoutIfNeededRecursive): git-svn-id: svn://svn.chromium.org/blink/trunk@42371 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ddkilzer@apple.com authored
git-svn-id: svn://svn.chromium.org/blink/trunk@42370 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mthole@apple.com authored
Rubber-stamped by Mark Rowe. Fix 64-bit build * Panels/WebAuthenticationPanel.h: Declare the 'separateRealmLabel' IBOutlet as an NSTextField instead of 'id'. This fixes a duplicate method warning (setAutoresizingMask: on NSView and CALayer) git-svn-id: svn://svn.chromium.org/blink/trunk@42369 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
levin@chromium.org authored
Reviewed by Darin Fisher. https://bugs.webkit.org/show_bug.cgi?id=25117 Fix Mac Chromium form controls. * rendering/RenderThemeChromiumMac.mm: When rendering native controls in Mac Chromium, use a clean NSGraphicsContext. Properly save and restore native graphics context. (WebCore::RenderThemeChromiumMac::paintCheckbox): (WebCore::RenderThemeChromiumMac::paintRadio): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton): git-svn-id: svn://svn.chromium.org/blink/trunk@42368 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
levin@chromium.org authored
Reviewed by Alexey Proskuryakov. https://bugs.webkit.org/show_bug.cgi?id=25030 Refactor MessagePort code to enable Chrome to use a MessagePortProxy object instead of a real MessagePort for the entangledPort, since it could theoretically live in a separate process. The goal of this refactoring is to remove all assumptions that the object representing the entangled port is actually of type MessagePort. All operations that were previously directly modifying private MessagePort member variables in the entangled port (i.e. entangle(), postMessage()) have been changed to invoke functions in the MessagePortProxy interface instead which will allow the Chrome bindings to proxy these calls to another process. No new layout tests, as this is just a refactoring with no bug fixes or new functionality. * GNUmakefile.am: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): * dom/MessagePort.cpp: (WebCore::MessagePort::clone): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::deliverMessage): (WebCore::MessagePort::startConversation): (WebCore::MessagePort::close): (WebCore::MessagePort::entangle): (WebCore::MessagePort::unentangle): * dom/MessagePort.h: (WebCore::MessagePort::entangledPort): * dom/MessagePortProxy.h: Added. (WebCore::MessagePortProxy::~MessagePortProxy): git-svn-id: svn://svn.chromium.org/blink/trunk@42367 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
levin@chromium.org authored
Reviewed by Alexey Proskuryakov. The Android platform requires threads to be registered with the VM. This patch implements this behaviour inside ThreadingPthreads.cpp. * wtf/ThreadingPthreads.cpp: Add a level above threadEntryPoint that takes care of (un)registering threads with the VM. (WTF::runThreadWithRegistration): register the thread and run entryPoint. Unregister the thread afterwards. (WTF::createThreadInternal): call runThreadWithRegistration instead of entryPoint directly. git-svn-id: svn://svn.chromium.org/blink/trunk@42366 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
weinig@apple.com authored
2009-04-08 Sam Weinig <sam@webkit.org> Reviewed by Geoffrey "Big Boy" Garen. Fix for <rdar://problem/5745677> Possible to stop load during an unload event Also fixes https://bugs.webkit.org/show_bug.cgi?id=20605 Tests: fast/events/stop-load-in-unload-handler-using-document-write.html fast/events/stop-load-in-unload-handler-using-window-stop.html Don't allow calling methods that would stop the new load inside the unload event. * loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stopAllLoaders): * loader/FrameLoader.h: LayoutTests: 2009-04-08 Sam Weinig <sam@webkit.org> Reviewed by Geoffrey "Big Boy" Garen. Tests for <rdar://problem/5745677> Possible to stop load during an unload event * fast/events/resources/pass.html: Added. * fast/events/resources/subframe-stop-load-in-unload-handler-using-document-write.html: Added. * fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html: Added. * fast/events/stop-load-in-unload-handler-using-document-write-expected.txt: Added. * fast/events/stop-load-in-unload-handler-using-document-write.html: Added. * fast/events/stop-load-in-unload-handler-using-window-stop-expected.txt: Added. * fast/events/stop-load-in-unload-handler-using-window-stop.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@42365 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mthole@apple.com authored
Reviewed by Adam Roben. * WebKit.xcodeproj/project.pbxproj: Set the Localizable.strings encoding to UTF-16. git-svn-id: svn://svn.chromium.org/blink/trunk@42364 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mthole@apple.com authored
Reviewed by Ada Chan. <rdar://problem/5697111> Basic authentication dialog spoofing vulnerability * Panels/WebAuthenticationPanel.h: Added IBOutlet for separateRealmLabel * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): In the realm case, decide if it is a simple or complex realm name. A realm name is considered complex if it has any whitespace or newline characters. Present alternative text and layout for the complex case, where the realm name isn't inline with the rest of the sheet's text. * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Updated the nib with a new 'separateRealmLabel' outlet. Updated the File's Owner to correctly be WebAuthenticationPanel. Fixed springs on the sheet's icon to keep it from moving during a resize. git-svn-id: svn://svn.chromium.org/blink/trunk@42363 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
It looks like the test was changed without updating the results before it was committed. Rubber-stamped by Adele Peterson. * fast/dom/DOMImplementation/createDocument-namespace-err-expected.txt: Updated. git-svn-id: svn://svn.chromium.org/blink/trunk@42362 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-