GitLab

Add a deprecation message if both 'audioCapabilities' and
'videoCapabilities' passed to navigator.requestMediaKeySystemAccess()
are empty. Support for this non-standard configuration will be removed
in M58.

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/aG_QGiPErlE

BUG=616233
TEST=message logged with EME layout tests

Review-Url: https://codereview.chromium.org/2528563005
Cr-Commit-Position: refs/heads/master@{#439004}

InnerDetach destroyes the current session and domain handlers, as opposite to
NotifyDetached, which prevents stale pointers and inconsistent state at the time
of DTAHI destruction.

BUG=674474

Review-Url: https://codereview.chromium.org/2579923002
Cr-Commit-Position: refs/heads/master@{#439003}

Following some recommendations in the spec [1] and [2],
this CL adds "video/x-matroska;codecs=avc1" and
"video/webm;codecs=avc1" to the supported list, reusing
the existing H264 encode path.

[1] https://github.com/w3c/mediacapture-record/issues/93
[2] https://github.com/w3c/mediacapture-record/issues/94

BUG=

Review-Url: https://codereview.chromium.org/2585533002
Cr-Commit-Position: refs/heads/master@{#439002}

Currently, clicking "Cancel" in an external protocol dialog with the
"Always open links for <app>" option checked will permanently silence
all protocol requests for that scheme. This result is unexpected given
the strings. This CL updates the strings to clarify the behaviour.
This is a stopgap fix for M56; future milestones will see further
changes to the behaviour of this dialog to improve its usability.

BUG=671658

Review-Url: https://codereview.chromium.org/2581623002
Cr-Commit-Position: refs/heads/master@{#439001}

There was a regression not showing web search menu item in
select action mode on Chrome if an activity for ACTION_WEB_SEARCH
cannot be found in the system. Chrome should always show it
since it can show the search result on a new tab. This CL fixes it
by showing the item by default, and having other embedder (webview)
configure it.

BUG=674104

Review-Url: https://codereview.chromium.org/2577963002
Cr-Commit-Position: refs/heads/master@{#439000}

Pressing Ctrl+Enter in a regualr source value attempts to run a snippet,
failing an assertion and showing red squiggles under the selected source
line.

BUG=None

Review-Url: https://codereview.chromium.org/2576983004
Cr-Commit-Position: refs/heads/master@{#438999}

Currently, the UI.ComboBoxFilterUI uses UI.ToolbarComboBox for the select
element. However, the component should be used only as a toolbar child,
since the toolbar has a bunch of CSS for the component.

This patch migrates UI.ComboBoxFilterUI from UI.ToolbarComboBox to a
simple <select>

BUG=674463
R=dgozman

Review-Url: https://codereview.chromium.org/2577953004
Cr-Commit-Position: refs/heads/master@{#438998}

BUG=570441

Review-Url: https://codereview.chromium.org/2581003002
Cr-Commit-Position: refs/heads/master@{#438997}

Revert of Add Windows 10 build number to user-agent (patchset #1 id:1 of https://codereview.chromium.org/2533303003/ )

Reason for revert:
This can cause services expecting a Windows user-agent of only two version tokens (10.0) to break.

Original issue's description:
> Add Windows 10 build number to user-agent
>
> The build number would be added to the version string in UA
> only if the major version of Windows is equal or greater than 10.
> Nothing would be changed for the old version of Windows.
>
> BUG=664622
>
> Committed: https://crrev.com/bb034491431fa28ce9b2be66b17c0417dffebc13
> Cr-Commit-Position: refs/heads/master@{#437532}

TBR=jochen@chromium.org,dcheng@chromium.org,pkasting@chromium.org,rbyers@chromium.org,ratsunny@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664622, 674723

Review-Url: https://codereview.chromium.org/2581033002
Cr-Commit-Position: refs/heads/master@{#438996}

Intent to implement and ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/IoIxRpn6l9g/ux1C1Cj7AQAJ

Spec:
https://w3c.github.io/browser-payment-api/#canmakepayment-method

Added in:
https://github.com/w3c/browser-payment-api/pull/380

BUG=664619

Review-Url: https://codereview.chromium.org/2579793003
Cr-Commit-Position: refs/heads/master@{#438995}

Desired size of content view added in https://crrev.com/2536223003
is supposed to be used for a particular instance like overlay panel.
This should be initialized back to default values after it was used
in adjusting backing size of the content in order not to affect
the size of other content views.

BUG=671967

Review-Url: https://codereview.chromium.org/2574693002
Cr-Commit-Position: refs/heads/master@{#438994}

Currently DidSwap runs before the swap, but we need a method
that is run after it. DidSwap is also not the best name because
it's called before the swap is done, so we believe WillSwap will
be a better name for it. So DidSwap will be renamed to WillSwap
and we will create a new DidSwap method that is run after the swap.

BUG=659598
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2580493002
Cr-Commit-Position: refs/heads/master@{#438993}

BUG=624136

Review-Url: https://codereview.chromium.org/2584763002
Cr-Commit-Position: refs/heads/master@{#438992}

BUG=581717
R=rohitrao@chromium.org,sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2579003003
Cr-Commit-Position: refs/heads/master@{#438991}

I couldn't find where in the code these were used and I couldn't find
them in the UI either ( chrome://settings/cookies ). I tried without
success to sleuth out when, if ever, these were actually used. js
lists don't show icons the way js trees do.

BUG=522168

Review-Url: https://codereview.chromium.org/2574803003
Cr-Commit-Position: refs/heads/master@{#438990}

These aren't used by the default theme, which renders programmatically
or with colors. (For example, the ntp background image was a 42x42
white square, but we don't need it because we set the bg color to
white.)

I left the IDR_s in place because they're still needed to identify
custom theme images. We could replace them with a C++ enum, but since
they occupy the same namespace as other themed/not-themed images (ints),
leaving them here seems the best way to avoid potential collisions.

BUG=522168

Review-Url: https://codereview.chromium.org/2568403004
Cr-Commit-Position: refs/heads/master@{#438989}

For setting time in an webpage (<input type=time>), clank currently
displays a spinner to set the time. This CL updates it to show the
standard clock UI provided by android. However the clock UI doesn't
have precision for seconds and milliseconds. In those cases, the
multi-field spinner will be displayed.

BUG=541353

Review-Url: https://codereview.chromium.org/2569943002
Cr-Commit-Position: refs/heads/master@{#438988}

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/of6S04dUf54/ScZJdp37BAAJ

Per the discussion on the bug and on the intent we're just going to
remove the prefixed items without any further deprecation warnings.

BUG=665887

Review-Url: https://codereview.chromium.org/2557523002
Cr-Commit-Position: refs/heads/master@{#438987}

This CL aims to make html canvas to match to CSS style restriction regardless
whether it is transferred to OffscreenCanvas or not.

In a usual compositor commit, when a css style is imposed on the html canvas
to change its width and height, its layer will reset a different bounds.
However, in the case when html canvas has transferred control to offscreen,
it is using a SurfaceLayer, which directly use surface_size_ without
incorporating layer bounds to append SurfaceDrawQuad. This CL changes
SurfaceLayerImpl to take into account the special case when layer bounds is
different from surface_size by doing a transformation on the
Quad, especially when the aspect ratio is different.

The CL respects existing non-canvas cases on high-dpi devices and settings
when enable-use-zoom-for-dsf is on or off.

Also, it is also possible that the compositor commit due to style change
happens before the Surface Layer for html canvas is created. To prevent
flakiness, we force a compositor commit at the time when Surface Layer is
created and registered to GraphicsLayers.

TBR=khushalsagar@chromium.org, twellington@chromium.org, pfeldman@chromium.org
BUG=655335, 652931
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2495373003
Cr-Commit-Position: refs/heads/master@{#438986}

This error is produced if get_pointer_stylus method is called with
a pointer object that is already associated with a pointer stylus
object.

BUG=673666

Review-Url: https://codereview.chromium.org/2575693002
Cr-Commit-Position: refs/heads/master@{#438985}

This was raised in https://codereview.chromium.org/2582483002/#msg9

getInstance() would be more common name for a function to get a singleton
instance and less confusing for code readers.

BUG=n/a

Review-Url: https://codereview.chromium.org/2579823002
Cr-Commit-Position: refs/heads/master@{#438984}

BUG=672829
TEST=try

Review-Url: https://codereview.chromium.org/2583523002
Cr-Commit-Position: refs/heads/master@{#438983}

This CL allows caller of the me2me NMH to override the path to save the host
config, so that we can have separate host config file when testing NMH against
test gaia environment.

BUG=674685

Review-Url: https://codereview.chromium.org/2581043002
Cr-Commit-Position: refs/heads/master@{#438982}

This blocklist allows access to particular models of USB device via the
WebUSB API to be blocked via either a binary push or Finch experiment.

Manual testing of this is difficult. I added a real device to the
blocklist and verified that it was not returned by
navigator.usb.getDevices() and was not listed in the chooser.

BUG=674353

Review-Url: https://codereview.chromium.org/2581543002
Cr-Commit-Position: refs/heads/master@{#438981}

Peoriodically (every 1s) check whether video/viewport intersection is
changed when video is rendered remotely.

BUG=643964

Review-Url: https://codereview.chromium.org/2556333002
Cr-Commit-Position: refs/heads/master@{#438980}

This is the sub-patch (1/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |EditCommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

This CL shouldn't have any behavior change.

BUG=673789

Review-Url: https://codereview.chromium.org/2578753002
Cr-Commit-Position: refs/heads/master@{#438979}

Add thread checkers to request options class.

Force the generation of the chrome-proxy header, and use it later when
generating the MockWrite for the sockets in tests.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=634061

Review-Url: https://codereview.chromium.org/2571993002
Cr-Commit-Position: refs/heads/master@{#438978}

FrameView::dispose() doesn't guarantee that the owner's widget is cleared
and this could be problematic when it's overwritten in
LocalFrame::createView() a short time later.

BUG=673170

Review-Url: https://codereview.chromium.org/2563313002
Cr-Commit-Position: refs/heads/master@{#438977}

This patch adds a few more items into traced value for picture layer
impls, in order to help diagnose issues.

R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2578193003
Cr-Commit-Position: refs/heads/master@{#438976}

This patch adds a query parameter "panel" which sets the default panel
when devtools loads.

BUG=673472
TBR=sky

Review-Url: https://codereview.chromium.org/2566573002
Cr-Commit-Position: refs/heads/master@{#438975}

Mark tests with pre-existing lines above as possible duplicates. Will follow up on each of those.

BUG=674313

Review-Url: https://codereview.chromium.org/2575293002
Cr-Commit-Position: refs/heads/master@{#438974}

It also makes binding to a raw handle easier.

BUG=579646

Review-Url: https://codereview.chromium.org/2578333002
Cr-Commit-Position: refs/heads/master@{#438973}

BUG=555865

Review-Url: https://codereview.chromium.org/2579693003
Cr-Commit-Position: refs/heads/master@{#438972}

BUG=666986

Review-Url: https://codereview.chromium.org/2570723002
Cr-Commit-Position: refs/heads/master@{#438971}

BUG=674742
TBR=paulmeyer@chromium.org

Review-Url: https://codereview.chromium.org/2578353002
Cr-Commit-Position: refs/heads/master@{#438970}

This is in response to problems with loading.mobile on Android One/3G,
where almost all stories were timing out.

BUG=673461

Review-Url: https://codereview.chromium.org/2577243002
Cr-Commit-Position: refs/heads/master@{#438969}

When a Safe Browsing warning is showing, the Developer Tools Security
panel should show custom text in the summary area.

BUG=654600

Review-Url: https://codereview.chromium.org/2542533004
Cr-Commit-Position: refs/heads/master@{#438968}

Blink objects that implement (Active)ScriptWrappable have the ability
to keep their corresponding v8 wrapper object alive across GCs by
overriding and implementing ScriptWrappable::hasPendingActivity().

Once an ExecutionContext has become detached, we no longer want to
retain wrappers belonging to it, as that will lead to memory leaks.
With full bi-directional tracing of references across the v8 and Blink
heaps, it is possible to make the lifetime of objects "more accurate",
but not keeping a wrapper alive once in a detached setting, has proven
to work out well in practice.

Consequently, a ScriptWrappable in a detached ExecutionContext should
not be retained, even if hasPendingActivity() return |true|. That is,
we should simply ignore hasPendingActivity()'s result, freeing the
implementations of it from having to take care of this 'detached'
detail.

This behavior is already provided by the 'standard' Blink wrapper
visitors that v8 invokes during GC, but not with wrapper tracing,
which is what this CL brings.

It does so by extending ActiveScriptWrappable with a predicate for
checking if the object's ExecutionContext has signalled destruction.

(The natural(?) way to express that is to parameterize ActiveScriptWrappable<>
over the class that implements the interface. This makes for a CL
with a larger footprint.)

R=haraken, mlippautz
BUG=468240

Review-Url: https://codereview.chromium.org/2577053002
Cr-Commit-Position: refs/heads/master@{#438967}

BUG=622400

Review-Url: https://codereview.chromium.org/2574403002
Cr-Commit-Position: refs/heads/master@{#438966}

If the last tab is moved to the other window and the device has a home
page, the original activity closes, which leads to a weird, confusing
animation. There's not a strong use case for having two windows open
with only one tab.

BUG=674684

Review-Url: https://codereview.chromium.org/2575343003
Cr-Commit-Position: refs/heads/master@{#438965}