- 18 Sep, 2019 40 commits
-
-
chromium-autoroll authored
Roll ChromeOS orderfile from 78-3877.0-1568022778-benchmark-78.0.3902.0-r1 to 79-3903.0-1568628088-benchmark-78.0.3902.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ic39e133c13d6180aac724f2f7487a70c9c804786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810180Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697496}
-
Hitoshi Yoshida authored
Web IDL does not allow to have null as a constant value. https://heycam.github.io/webidl/#index-prod-ConstValue This CL drops the keyword from parser, and does not change actual behaviors of Chrome. Bug: 839389 Change-Id: Ia22c901fc71517ce74a8859a1fd74994c6c65e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809118Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#697495}
-
Richard Knoll authored
This will hide the settings button for native notifications if they should not have one. This is specific to the feature that displays the notification and is already working for non-native notifications. Additionally, the settings button will now show for extension native notifications, a previous CL (923877) only added it for non-native ones. Bug: 999979,810622 Change-Id: I26d94e275dab76d1748afdfefae78aba77977473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801759Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697494}
-
Alan Cutter authored
Test background installation flag over install_params presence when deciding to open Play store installation for PWAs on Chrome OS This CL updates the logic for checking whether a PWA installation should go via the Play store to branch on the "background installation" bool instead of whether we have install_params_ set. This is in preparation for adding background updating as a new install entry point which breaks the existing expectations. Bug: 926083 Change-Id: I5d0f987fa04bc9dcc02452cc5c1ea5515b6b59ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788781Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#697493}
-
Alexei Filippov authored
The class is quite big containing a string and a flat_map. We're observing its copy constructor being called quite extensively at places where it would otherwise be using move. BUG=1003042 Change-Id: I011b267427f8c9790047a5b7adf9c2cd3dd27399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807702Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#697492}
-
Fergus Dall authored
TBR=khmel@chromium.org TBR=malaykeshav@chromium.org Bug: 1005069 Change-Id: I4a9bfbfc683587714eeb960c8d2e58f739932b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810171Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697491}
-
sczs authored
There was a retain cycle per bug 1004690. The ContainerCoordinator had a strong pointer to the Mediator, which in turn had a strong pointer to infobar_container_ios, which had a strong pointer to its consumer (ContainerCoordinator). This would only happen on non Messages, since on the legacy implementation the consumer is the ContainerViewController. Still I think both consumers should be weakly retained since the mediator(infobar_container_ios) don't really own these objects. Bug: 1004690 Change-Id: Ic5d30b444177e216ffe2f8cdce9b0cf7d012383c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809744Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#697490}
-
Hitoshi Yoshida authored
Reorders IDL parser's patterns to follow Web IDL grammar[1] as much as possible. This CL is to reduce diffs of follow-up CLs, and does not change any behaviors. [1] https://heycam.github.io/webidl/#idl-grammar Bug: 650150, 839389 Change-Id: I8885016db13f9b9af2fed18eb3e6ccf99c6365b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807652Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3c4a829c64f..a37ea9246e1e git log f3c4a829c64f..a37ea9246e1e --date=short --no-merges --format='%ad %ae %s' 2019-09-18 csmartdalton@google.com Use a "decal" domain for filterMaskGPU Created with: gclient setdep -r src/third_party/skia@a37ea9246e1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I63d45595957388d31658ae5d2c87e3d4dcb9f148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810357Reviewed-by:
-
Eric Willigers authored
WebDisplayMode was being passes by const reference. It is now passed by value, as usual for enums. Change-Id: I12f192cdd92251a606cec66071445cb875eac0dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809133 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Asanka Herath authored
R=qinmin@chromium.org Bug: None Change-Id: I30174f066b72f3f6a7930ebe0509efb06738397f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808434Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697486}
-
Toby Huang authored
Currently, GetDialogId() starts out as the empty string, gets set to kChromeUIAddSupervisionURL="chrome://add-supervision" when the Add Supervision dialog is opened, and sometimes gets reset to empty string when the dialog is closed depending on which button is pressed. This CL ensures kChromeUIAddSupervisionURL is always passed to FindInstance() instead of the empty string which can lead to unpredictable behavior and can easily return something other than null. Bug: 1000978 Change-Id: I0287aefdb3451db2e8f388dbff659623d4e7f982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787339 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#697485}
-
Fergus Dall authored
This reverts commit 8d32b638. Reason for revert: Broke the build: [56563/84904] CXX obj/third_party/blink/common/common/logging_utils.obj FAILED: obj/third_party/blink/common/common/logging_utils.obj C:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../third_party/blink/common/logging/logging_utils.cc(7,10): fatal error: 'third_party/blink/public/mojom/devtools/console_message.mojom-blink.h' file not found #include "third_party/blink/public/mojom/devtools/console_message.mojom-blink.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Reland "Include *.mojom-forward.h instead of .mojom.h from logging_utils.h" > > This is a reland of be56a0b9 > > Fix the build break caused by the missing dependency. > > Original change's description: > > Include *.mojom-forward.h instead of .mojom.h from logging_utils.h > > > > This CL replaces .mojom.h with .mojom-forward.h to reduce pre-processed > > size of logging_utils.h > > > > This CL has no behavior changes. > > > > Bug: 1001360 > > Change-Id: Idd305572c67e46a5f7a01937ec1d2e31fc62d8ea > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808619 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#697134} > > Bug: 1001360 > Change-Id: I5a8112a21782863c6420eddd2fe717d368419b90 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808953 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#697475} TBR=haraken@chromium.org,tkent@chromium.org,tikuta@chromium.org,gyuyoung@igalia.com Change-Id: Ie875b1e2e62833b5042444e4f3a1af3400467217 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810169Reviewed-by:
-
Wei Wang authored
In this patch, the helper test utils {StartServiceWorker, StopServiceWorker} are used in other tests. Bug: 930195 Change-Id: Ib163c25eac1ffd13b57e1333084db98ab7ad3e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809969 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#697483}
-
Miyoung Shin authored
This CL converts HidManagerClient{AssociatedPtr, AssociatedPtrInfo and AssociatedRequest} in device, services and extensions to the new Mojo type. Bug: 955171 Change-Id: I86e47ad4d6bdb35a89cca8337bd066aa167b2c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803938 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Alan Cutter authored
This is a cleanup refactor, the bookmark star is the last PageActionIconView that isn't contained by OmniboxPageActionIconContainerView. This CL updates its implementation to conform with all the other PAIVs and remove specialised LocationBar methods now that it fits generic interface. Bug: 788051 Change-Id: I5f382b2eddc767e896f7853c3cc27595dacd3f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808940 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#697481}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8e462ce33b7b..dca254aeeec6 Created with: gclient setdep -r src-internal@dca254aeeec6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I08924e71114945fe6775f8a2a5372ed41fdf907a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809968Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697480}
-
Fergus Dall authored
TBR=nhiroki@chromium.org Bug: 1003217 Change-Id: I0f0ea6f8a33dc9a4e9291fbe7cccbe0318a5c3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810165Reviewed-by:
-
Fergus Dall authored
TBR=alexmos@chromium.org Bug: 1005049 Change-Id: If88be75391cc296b8b3f178f74dcb7f5f0c719ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809132Reviewed-by:
-
Khushal authored
We should clear these maps on every navigation to keep them from growing unbounded, and because its safe to clear this state after a navigation. R=ericrk@chromium.org Bug: 1003886 Change-Id: I68dae1d564039c27795e63ac18144ea955bac8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804515 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#697477}
-
Timothy Loh authored
This CL extracts the engagement metrics logic from ArcMetricsService into a new class GuestOsEngagementMetrics, to allow it to be used for both Crostini and Plugin VM. TEST=Manually verified chrome://histograms had sensible entries over a couple of days. Bug: 990252 Change-Id: I395bca7dd2c3d4688c33683cd163c18c8ecc90f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738447Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#697476}
-
Gyuyoung Kim authored
This is a reland of be56a0b9 Fix the build break caused by the missing dependency. Original change's description: > Include *.mojom-forward.h instead of .mojom.h from logging_utils.h > > This CL replaces .mojom.h with .mojom-forward.h to reduce pre-processed > size of logging_utils.h > > This CL has no behavior changes. > > Bug: 1001360 > Change-Id: Idd305572c67e46a5f7a01937ec1d2e31fc62d8ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808619 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#697134} Bug: 1001360 Change-Id: I5a8112a21782863c6420eddd2fe717d368419b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808953Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#697475}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/20791fdb3e91..da39c6d82324 git log 20791fdb3e91..da39c6d82324 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 saklein@chromium.org PackagesService: Add HasChromePrebuilt method. Created with: gclient setdep -r src/third_party/chromite@da39c6d82324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I15bc8370e988d2efacd6fdab79a8d590e2b995f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808435Reviewed-by:
-
Fergus Dall authored
TBR=qinmin@chromium.org Bug: 994789 Change-Id: Id9e87e7f424997b8511dfc2a5d2150b35571c201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810145Reviewed-by:
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of resource.h from 5.01MB to 4.55MB. Bug: 242216 Change-Id: Ica5c80d5c5d645dfe199f5ea4db346324f1439a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809040Reviewed-by:
-
Fergus Dall authored
TBR=malaykeshav@chromium.org Bug: 974349 Change-Id: I7cdc3d945a641ddf8ff42fb10909f99bbd403f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810144Reviewed-by:
-
Miyoung Shin authored
This CL converts SpeechRecognitionSessionClient{Ptr, PtrInfo} in blink and content to the new Mojo type, and uses pending_remote<SpeechRecognitionSessionClient> in speech_recognizer.mojom. Bug: 955171, 978694 Change-Id: Ie6316bc231d269bf95439d30c3952db7cf458e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809042Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
-
Austin Tankiang authored
With the switch to DriveFS, the legacy drive client is no longer needed, so remove it. Bug: 1003238 Change-Id: I7e2bf4afb1bc518962f5629eebfba929c918792e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803947Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#697469}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c6642beb8c78..9d3a62e82627 git log c6642beb8c78..9d3a62e82627 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 awscreen@chromium.org [FXJS] Use double precision when converting textboxes 2019-09-17 awscreen@chromium.org [FXCRT] Test StringTo{Float,Double} with byte and wide strings 2019-09-17 thestig@chromium.org Roll third_party/freetype/src/ 3de1b8d0b..99f23d6ff (2 commits) 2019-09-17 thestig@chromium.org Add helper methods for getting objects in CPDF_FormField. Created with: gclient setdep -r src/third_party/pdfium@9d3a62e82627 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:611744,chromium:611744 Change-Id: I17d8271682de47d90a9a12cd8ea87f0336ba5c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810008Reviewed-by:
-
Jiacheng Guo authored
This change allows all users in the same group to access external mojo service. Bug: 140592503 Test: Build and verified with external client Change-Id: I1f82378460fd8ae002f02d09103841541b1aa788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808630Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Jiacheng Guo <gjc@google.com> Cr-Commit-Position: refs/heads/master@{#697467}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I984eb1770e7e60fd159ca7d1220489b6d213fd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808356Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697466}
-
Jeevan Shikaram authored
The Play Store ARC app has the storage permission granted by default and the storage permission is hidden from the user in Android Settings. This CL hides the storage permission in App Management for the Play Store to align with this decision. Bug: 1002015, 982576 Change-Id: I3c4e4180882dac89730e4941e5557b3a8a41f29a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807639Reviewed-by:
-
Austin Tankiang authored
With the move to DriveFS, drive paths no longer need to be special cased, and can be treated as local paths. Bug: 1003238 Change-Id: I8c2840e6b7ec318904b290aca9b98ebb5d588adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802899 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#697464}
-
Alex Keng authored
This CL implements the new look of radio (accent color), checkbox (accent color and indeterminate state), range (accent color) and also addresses several underlying issues: 1. The drawing code is not ready for dark theme. This is addressed by introducing a new set of color ids in NativeThemeAura and using GetControlColor instead of color constants to draw controls. This way when the colors for dark theme are designed, we can just add new colors to GetControlColor and the drawing codes in NativeThemeAura can be left untouched. 2. Downstream needs a way to implement bifurcation of styles and limit the merge conflicts. This can also be achieved by redirecting logics in NativeThemeAura ::GetControlColor and define new colors in the new code path. 3. Too many duplicated color constants. This is addressed by consolidating 24 constants into 11 color ids. Ex (kCheckboxAndRadioBorderHoveredColor, kInputBorderHoveredColor, and kButtonBorderHoveredColor are mapped to kHoveredBorder) 4. The expected files for high contrast tests are prone to have conflicts. This is because upstream and downstream use different colors for disabled UI so every time upstream file is updated, downstream would need to re-baseline. This is addressed by providing default HC color for web tests mode, which also make the test results more readable. Bug: 1001546,1001553,1001554,986850 Change-Id: Icd6c4a0b96dd974b6500ba4365d22435d9e30f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792578 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Lily Chen authored
This makes CookieSameSite into two separate enums, CookieSameSite (representing the SameSite attribute value of the parsed cookie), and CookieEffectiveSameSite (representing the SameSite mode to be applied to inclusion/exclusion of that cookie). Previously they were the same enum, which resulted in overlapping sets of enum values that were possibly valid for one but not the other. This change removes the need to check whether a value is valid, because only valid semantically values are now included in the respective enums. Bug: None Change-Id: I467e7ac0551511e1afea74828886f40a57065d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808019 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#697462}
-
Jesse Schettler authored
Now that legacy printing IPC messages are being converted to Mojo, the IPC nesting level needs to be incremented/decremented in each Mojo method. This change moves the incrementing/decrementing of the IPC nesting level to helper methods that are used by the new Mojo methods and OnMessageReceived(). Bug: b:140576300 Test: Print a webpage or PDF Change-Id: Ib71796367cd36eef9293dfad455504b3ee2b57c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809803Reviewed-by:
-
Miyoung Shin authored
This CL converts InputDeviceManagerClient{AssociatedPtr, AssociatedPtrInfo} in services and chrome to the new Mojo type, and uses pending_associated_remote<InputDeviceManagerClient> in input_service.mojom. Bug: 955171 Change-Id: I348e6e41558c9529c4c713f1fd1409f37d95db18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806165 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by: -
Rakib M. Hasan authored
Bug: 994943 Change-Id: I1f8f1119eff48292f5c00f7b1e152ebb6f059c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809751Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#697459}
-
Joshua Peraza authored
e97cf7b29c16 update gyp_crashpad_android.py 2bfd3c4edcff [POSIX] stop logging on ENOENT 12bc30cdf58a Check if attachment directories exist before open edbbc4609d2d chromeos: fix typo Change-Id: Icb1d0ca0eaf1aa854ac9fcdd083b75f8ec8ec59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809512Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#697458}
-
Robert Ogden authored
This is a reland of 75273409 TBR=tbansal@chromium.org,dullweber@chromium.org Original change's description: > Remove DRP Pingbacks > > Removes all the pingback code. There's still some stale code left but > that's all related to v1 HTTPS Server Previews which will be removed > soon. > > Bug: 957753 > Change-Id: I4d5cccd5e402a786c49b8ea1c5b1d95a396f8850 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807962 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Robert Ogden <robertogden@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697311} Bug: 957753 Change-Id: I5203db014d4a219a9f3c3b2da1bd69e62b0781c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809606Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#697457}
-
