- 07 Nov, 2018 40 commits
-
-
Antoine Labour authored
Bug: 882513, 897214 Change-Id: I3d7dc804db292b7a9844eda856195b7b7b1450d3 Reviewed-on: https://chromium-review.googlesource.com/c/1316347 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#606210}
-
Tibor Goldschwendt authored
Bug: 889985 Change-Id: If65ba8da760c0d9c0e79e71c8a2d2b6f240c5e9d Reviewed-on: https://chromium-review.googlesource.com/c/1319849 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#606209}
-
Wenzhao Zang authored
1. It's not easy to capture the "proceeded to logout" state because the logout is not initiated by Chrome. Also, it can't guarantee to be captured every time? Instead, we could record "shown" and "canceled", and in the comments emphasize that "show and proceeded" should be calculated by subtracting the two. 2. In |IdleActionWarningObserver::IdleActionImminent|, there's a check for if |warning_dialog_| already exists. I think this is a check for a rare case that the policy is updated while the dialog is showing. We should not record UMA in this case. Bug: 900263 Change-Id: Ied2f4b03252933e9ced3c792655e981b38105039 Reviewed-on: https://chromium-review.googlesource.com/c/1313118Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#606208}
-
Tommy Steimel authored
This CL adds a feature flag to toggle hardware key handling. This is currently unused and disabled by default. Bug: 902792 Change-Id: Ic1dfd70a81f6aa7abb8fd79b504b0d3bd05843e3 Reviewed-on: https://chromium-review.googlesource.com/c/1323798Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606207}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/273fe31d..b90faf57 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I009b8b395445986d46cb7f560bd6566490e3d829 Reviewed-on: https://chromium-review.googlesource.com/c/1323617Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606206}
-
Chris Morin authored
Workaround for patchoat intermittently taking much longer than normal to complete on startup. This will be reverted once issue is root caused and fixed. Bug: 117832337 Test: Add a sleep 30 before patchoat and ensure container starts Change-Id: I3c66110dff876b8aa61fa4fb12c658038db978a3 Reviewed-on: https://chromium-review.googlesource.com/c/1322352 Commit-Queue: Christopher Morin <cmtm@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#606205}
-
Jian Li authored
Bug: 898834 Change-Id: I1194e4805e4504f4be120a1f89bdd99cb6bc34e7 Reviewed-on: https://chromium-review.googlesource.com/c/1324421Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#606204}
-
Yue Cen authored
This is required after the change in https://chromium-review.googlesource.com/c/1297172 Bug: 900793 Change-Id: I6f21fefc9d24f7209e7cfc8569c009c27a90c236 Reviewed-on: https://chromium-review.googlesource.com/c/1315968Reviewed-by:
-
John Budorick authored
https://chromium.googlesource.com/catapult.git/+log/2e722b007d34..1a1b38dabca6 $ git log 2e722b007..1a1b38dab --date=short --no-merges --format='%ad %ae %s' 2018-11-06 bpastene devil: Add an option to reset USB devices when no HealthyDevices are found. Created with: roll-dep src/third_party/catapult Tbr: nednguyen@google.com,sullivan@chromium.org Bug: 892670 Change-Id: Ief672aa6656cd757ddc1b75657c4831af4f9e81f Reviewed-on: https://chromium-review.googlesource.com/c/1323905Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#606202}
-
Tony de Luna authored
It might take some seconds between users submit pin update and operation completes. In the meantime users shouldn't be able to modify the PIN input fields. Bug: 901290 Change-Id: I21aa06288d3f0aaf00db8dae72715a8a4e94d85d Reviewed-on: https://chromium-review.googlesource.com/c/1323903Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Cr-Commit-Position: refs/heads/master@{#606201}
-
Francois Doray authored
Previously, SetCurrentThreadPriority(BACKGROUND) did not affect CPU priority on Windows in a IDLE process when the "WindowsThreadModeBackground" feature was enabled. It only affected I/O and memory priorities. With this CL, a second call to ::SetThreadPriority() is made to ensure that CPU priority is affected. Bug: 901483 Change-Id: I22640c8fa56eeec489fbf0fe516359b828e39541 Reviewed-on: https://chromium-review.googlesource.com/c/1318438 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#606200}
-
dpapad authored
Test steps: 1) Build Android Chrome once ninja -C out/gchrome/ chrome_public_apk 2) Touch a WebUI target that was previously unnecessarily included as a dependency, for example: touch chrome/browser/resources/md_history/app.js 3) Build Android Chrome again. There should be nothing to do. Bug: 901261 Change-Id: If81312b54bc785bc4faced24d3f516b029fd1d86 Reviewed-on: https://chromium-review.googlesource.com/c/1324195Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#606199}
-
Xiaohan Wang authored
When ENABLE_MOJO_CDM is false, we should still support ClearKey key system, hence use DefaultCdmFactory in this case. Thanks to yucliu@ for finding this issue. Change-Id: I72d730497daefb6c0c2709915a9ee3ec482e1125 Reviewed-on: https://chromium-review.googlesource.com/c/1324191Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#606198}
-
Dale Curtis authored
Variably length arrays tend be less efficient than alloca(); see https://www.phoronix.com/scan.php?page=news_item&px=Linux-Kills-The-VLA BUG=none TEST=cq R=sergeyu Change-Id: Ibb16415b960b1ab5b262fab39537c7cf63ce5586 Reviewed-on: https://chromium-review.googlesource.com/c/1324196 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606197}
-
Erik Luo authored
(Behind experiment) - Navigate to linkified substrings via keyboard - Press Enter on a selected link to navigate to it This CL does NOT cover anchors. Links produced outside of Console will be addressed in a followup, e.g. BrowserConsole's Network logs, JSPresentationUtils' stack trace Bug: 865674 Change-Id: Ib0e1c39823801a9403dcdcf8b68d884197ed9690 Reviewed-on: https://chromium-review.googlesource.com/c/1317925Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#606196}
-
Antoine Labour authored
Previously, InProcessGpuThreadHolder initialized texture_target_exception_list according to the production expectations, in particular assuming native GMB types when available. However all unit tests use viz::TestGpuMemoryBufferManager (if any GMBManager at all) which only produces shared memory GMBs. This means the wrong target will be used for those. It's mostly harmless on Mac (GL_TEXTURE_RECTANGLE_ARB) but no so much on other platforms (GL_TEXTURE_EXTERNAL_OES which doesn't allow glTex*Image*). Instead, leave texture_target_exception_list empty, individual tests can initialize it if they need (e.g. if they use a GpuMemoryBufferFactory). Bug: 897214 Change-Id: I55984ef49797fa97f00e2bda35b60a4e6ba734bc Reviewed-on: https://chromium-review.googlesource.com/c/1322610 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#606195}
-
Vlad Tsyrklevich authored
A subsequent refactor moves the singleton into client/. Remove it from common, turn :common back to a static_library, and restructure the constructor back into an Init() method to accomodate the new singleton design. Bug: 896019 Change-Id: I7bfe4b996b165ba34831565160c8ef46f3e48498 Reviewed-on: https://chromium-review.googlesource.com/c/1322111 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#606194}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d5ee1c6aed6c..fd5e90efc65a git log d5ee1c6aed6c..fd5e90efc65a --date=short --no-merges --format='%ad %ae %s' 2018-11-07 derat@chromium.org chromeos_config: Run Tast VM tests on betty-pre-cq. Created with: gclient setdep -r src/third_party/chromite@fd5e90efc65a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I17fdd4d6ec54e413e95e0ca5f91c31b6ca5acca5 Reviewed-on: https://chromium-review.googlesource.com/c/1323634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606193}
-
Christian Biesinger authored
R=dgrogan@chromium.org Change-Id: I9570f9a1821c137f23df235393e8b99ce980a8fe Reviewed-on: https://chromium-review.googlesource.com/c/1324235 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#606192}
-
Shakti Sahu authored
This CL attempts to limit scaling of very tiny images to a certain factor. The contents would still be drawn within the rounded rect. It also separates the full-width image to a different view holder which would prevent resizing issues of AsyncImageView on reuse. Bug: 902950 Change-Id: I804ae1ba44db7c875860a395161b5c9eba4e7147 Reviewed-on: https://chromium-review.googlesource.com/c/1297357 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606191}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/28f76deac908..19757a1acfeb git log 28f76deac908..19757a1acfeb --date=short --no-merges --format='%ad %ae %s' 2018-11-07 tsepez@chromium.org Remove some redundant C-style casts in cjs_event.cpp 2018-11-07 tsepez@chromium.org No V8: ifdef out more of cpdfsdk_formfillenvironment.h 2018-11-07 tsepez@chromium.org Beef up cfx_globaldata_unittest.cpp. 2018-11-07 thestig@chromium.org Remove some checks that are never true in patterns code. 2018-11-07 tsepez@chromium.org Fix stray whitespace in fpdfsdk/DEPS. 2018-11-07 tsepez@chromium.org Render annotation in annotation_ink_multiple.pdf. 2018-11-07 tsepez@chromium.org Add EmbedderTest::LoadPageNoEvents() and UnloadPageNoEvents() Created with: gclient setdep -r src/third_party/pdfium@19757a1acfeb The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1a3435681dc1227c93c6af34b2f46ca549fc3efb Reviewed-on: https://chromium-review.googlesource.com/c/1323635Reviewed-by:
-
Kristi Park authored
Allow users to reorder their custom links with drag and drop. Screencast: https://screencast.googleplex.com/cast/NDkxMzY1Mzc2OTgzMDQwMHxmY2JhMTNkYy01NQ Bug: 851335 Change-Id: I8e77fbdd7c10ec95f60dc5a41e45ae06f7a62543 Reviewed-on: https://chromium-review.googlesource.com/c/1309228 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#606189}
-
Matt Falkenhagen authored
This reverts r581129. The metric is expiring and not needed, see bug. Bug: 902100 Change-Id: I3af413975f42dbf12003746fefd08f1b2245e78f Reviewed-on: https://chromium-review.googlesource.com/c/1322171Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#606188}
-
Matt Falkenhagen authored
The owner is auto cc'd on restricted bugs. Also UMA cannot be accessed externally anyway, so it's more appropriate for the internal group. Change-Id: I077d287a6951ec153224628b3597ea3e77b02acf Reviewed-on: https://chromium-review.googlesource.com/c/1321654Reviewed-by:
-
Dan Harrington authored
Auto-fetch requests will be canceled if the page is loaded in the foreground. This CL ensures that background loading doesn't take place while the foreground active tab still points to the requested URL, since it has a good chance of eventually loading. Bug: 883486 Change-Id: I4cf8b039ed5dc92aea08c9e0f7b597893f880113 Reviewed-on: https://chromium-review.googlesource.com/c/1313567 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#606186}
-
Mitsuru Oshima authored
This is a workaround. Using fully opaque color somehow causes the content clipping on the arc content window. It'll be investigated separately. Bug: 901538 Test: manual. Change-Id: Ifee1ccdeb3e877008f33ef62ba1dd5024bb4b196 Reviewed-on: https://chromium-review.googlesource.com/c/1324393Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#606185}
-
Robert Ma authored
Using wpt-import in Chromium bc37aee6. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." d2f6756a "Window onerror is not triggered bug fix" Manual import because of https://crbug.com/869360 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc meade@chromium.org: external/wpt/web-animations msisov@igalia.com: external/wpt/webvtt NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I54fc4f16d88df8a3d2ba0ca948c728407e81adba Reviewed-on: https://chromium-review.googlesource.com/c/1323696 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#606184}
-
Douglas Stockwell authored
web-animations-js has some performance impact in wrapping native `requestAnimationFrame`. In the case of PDF, none of the polyfilled behavior is necessary as the animation effects are trivially implemented through native `element.animate`. R=dsinclair@chromium.org, hnakashima@chromium.org Change-Id: I9ab09a91e697a491f0c57009293333053a79f618 Reviewed-on: https://chromium-review.googlesource.com/c/1322178Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#606183}
-
Adrienne Walker authored
Followup to 3212ece4 which only handled single thread. FindIt indicates that multithread is at fault as well. Bug: 902644 Change-Id: If774e275f4a7f146993661ac4472978856eb1b00 Reviewed-on: https://chromium-review.googlesource.com/c/1324416 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#606182}
-
Mihai Sardarescu authored
This CL add a source for update and revoke credentials operations. It then surfaces the source in the chrome://signin-internals page. This CL also records the following histograms that track refresh token events: * Signin.RefreshTokenUpdated.ToValidToken.Source * Signin.RefreshTokenUpdated.ToInvalidToken.Source * Signin.RefreshTokenRevoked.Source These histograms are needed to validate the assumptions of how often tokens are revoked by the browser and the sources for the token revocations. Bug: 896182 Change-Id: I2fcab80ee8e5699708e695bc3289fa6d34859a90 Reviewed-on: https://chromium-review.googlesource.com/c/1286464Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Ben Wells authored
These were previously prevented due to strict checking by the installation pipeline that isn't appropriate for web apps that have been explicitly installed (either by users or the system). The specific check was that the display in the manifest is one of standalone, full screen or minimal. This meant web apps that were installed with a browser display setting (e.g. showtime) would fail. This check is now gated behind an option, that is on by default. The desktop web app installation disables this option. Bug: 882945 Change-Id: I84d97d713d358c849d8480299604310dd08efb2a Reviewed-on: https://chromium-review.googlesource.com/c/1322262Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#606180}
-
Roger Tawa authored
When the user enters an old password into the credential provider after a password change, make sure to use an appropriate message. At the same time make sure that all error paths return a valid string otherwise a blank error will be shown. Bug: 902706 Change-Id: I2835f8b11d8f1f116e64333d47515115b642b066 Reviewed-on: https://chromium-review.googlesource.com/c/1323270Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606179}
-
Dale Curtis authored
Apparently it's in the 96th percentile by size and we haven't a need for it anymore. BUG=902185 TEST=none Change-Id: I12dec552bacb9942eea15ccd4e139527155f77ea Reviewed-on: https://chromium-review.googlesource.com/c/1321587Reviewed-by:
-
Dale Curtis authored
Extremely high frequency, but apparently useless, so remove. BUG=none TEST=none Change-Id: I6da011e77b724914be1a9829c1464397e3523cf0 Reviewed-on: https://chromium-review.googlesource.com/c/1321790Reviewed-by:
-
Saman Sami authored
There is no reason to keep the surface alive if it's explicitly evicted. Bug: 893793 Change-Id: I95b77abb386345368dbb8a295b695543aa94a749 Reviewed-on: https://chromium-review.googlesource.com/c/1321259 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606176}
-
Jun Mukai authored
TabDragging's PressSecondFingerWhileDetached/0 is still failing, and this fails due to a corner case of focus and visibility handling in the window system; - the test scenario falls into a certain gesture, which will minimize the dragged window https://cs.chromium.org/chromium/src/ash/wm/workspace/workspace_window_resizer.cc?g=0&l=594 - TabDragController restores focus at the end of dragging https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_drag_controller.cc?g=0&l=1433 On the classic environment, this shows the dragged window and re-activates it, while it fails to activate on Mash, and so it fails at https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc?sq=package:chromium&g=0&l=2576 This CL allows focus directly on the minimized window; - DesktopWindowTreeHostMus shouldn't early-return if the window is invisible because of minimized status - DesktopFocusRules should check the minimized status too, otherwise FocusController can't find the focusable / activatable windows - TestWindowService should take care of synchronizing the window's show state and its visibility. The DesktopWindowTreeHostMusTest's case is changing the window state but not changing the visibility. - sometimes a window is created with minimized status. DesktopWindowTreeHostMus::Show() needs to take care of such situation, otherwise it isn't starting with minimized status. BUG=902598 TEST=the edited test case and unfiltered test case Change-Id: Icae808806ba134a3789b39438179818011379064 Reviewed-on: https://chromium-review.googlesource.com/c/1321859Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#606175}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39f97da7dc62..1f3ebd2b9a65 Created with: gclient setdep -r src-internal@1f3ebd2b9a65 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic61fca0fbecff9a628b4e545821d25d61515edb3 Reviewed-on: https://chromium-review.googlesource.com/c/1323633Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606174}
-
Tien Mai authored
Fix some missing permissions for the logon stub process needed to be able to run Chrome during winlogon Bug: 887444 Change-Id: Ie6c54855cee2b95ef6cb0de1829251d324548733 Reviewed-on: https://chromium-review.googlesource.com/c/1301850 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606173}
-
Livvie Lin authored
Bug: 900031 Change-Id: I58e2846c9dd447bed42983db49b1d1ecf0e235b6 Reviewed-on: https://chromium-review.googlesource.com/c/1321671 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#606172}
-
Stephen Martinis authored
This reverts commit 3b04594a. Reason for revert: builder has recovered. Original change's description: > Remove chromeos-amd64-generic-rel from CQ > > The bot is broken at the moment. > > NOTRY=true > > Bug: 902806 > Change-Id: I1ee551c95617444e5ec4edbdb3d8d4fde6d7dc5f > Reviewed-on: https://chromium-review.googlesource.com/c/1324090 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606093} TBR=martiniss@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: I6c4f751514d9fc67ccf4004643f2368cc5effc68 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902806 Reviewed-on: https://chromium-review.googlesource.com/c/1324415Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#606171}
-
