- 01 Oct, 2020 29 commits
-
-
Jiewei Qian authored
This reverts commit 7b3ea4c4. Reason for revert: Tests on linux-trusty-rel are failing Get error message: "Unrecognized option: -maxclients" when starting X server. Sample failing job: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/16372 Original change's description: > xvfb.py: explicitly specify -maxclients=512 > > When running ash_unittests on CloudTop instance, many tests would fail > with "Maximum number of clients reached" X11 error. This does not repro > on physical gLinux workstation though. Adding explicitly -maxclients > parameter to make it consistent across platforms. > > Bug: None > Test: Run testing/xvfb.py out/Release/ash_unittests > Change-Id: Iac41378470d87df4b5d8140b3ee03a9a93a8c5ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438577 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812336} TBR=dpranke@google.com,xiaohuic@chromium.org Change-Id: I814c0cec7a6b36eaf498838e5ecb27c3564d8ae6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440720Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#812484}
-
Andrew Xu authored
This CL adds rounded corners to the images shown by the multipaste menu. RoundedImageView, instead of layer, is used to achieve it. Because the multipaste menu's ancestors do not cut the children's layers outside of the multipaste menu's container bounds. Meanwhile we have no control on the context menu view hierarchy. This CL does two things: (1) Move rounded_image_view.h and rounded_image_view.cc under ash/public/cpp (2) RoundedImageView replaces ImageView in ClipboardHistoryBitmapItemView Bug: 1133020 Change-Id: Ib56466cfa574410cc83c7f5a125416a27dcabd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436769 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#812483}
-
Scott Violet authored
Necessary as behavior landed in 86. BUG=1127518 TEST=test only change TBR=jam@chromium.org Change-Id: Id7706fcd19329e4975a1ef7b358ee9d1aec8cb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441931Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#812482}
-
Kartik Hegde authored
To call utility functions more clearly, wrap them in a "util" namespace. TEST=unit_tests --gtest_filter=NetworkDiagnosticsUtilTest* BUG=chromium:956783 Change-Id: I2874dbdbda7fe84c04f7484c876845d75f99f928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438757Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#812481}
-
Matthew Mourgos authored
This change adds an announcement which occurs when focusing a shelf item with a notification badge. Also, this change updates the notification badge announcement string for items in the launcher. Bug: 1126492 Change-Id: If4fb6fe203bf3aa5984e9811c407224cf40044e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427021 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812480}
-
mwakizaka authored
Previously adb uses a random port number for forwarding devtools port to Android device. It makes difficult to filter packages based on port number. Now we can specify the port number via chromeOption. Bug: chromedriver:3598 Change-Id: Ib8de0b3abfc7f5c66898739314d552c85852680f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433746Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#812479}
-
Matthew Denton authored
For USER_NOTIF support in the syscall broker, the broker will need to send two fds to the CLONE_FILES process (temporary IPC socket for reply, and the newly opened FD). The current BrokerSimpleMessage only supports sending and receiving a single FD, so this CL adds support for async-signal-safe sending/receiving of multiple FDs. Bug: 1117351 Change-Id: I708f200b047857816a9c2958535a360811e25741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412761Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#812478}
-
Mark Schillaci authored
This CL updates the behavior of ListBox on Android. With this change, the state of a Listbox ("x items") will now be read during swipe navigation when a node is initially selected. For ListBoxItem, the state of the item will read as "in list, item x of y". We append the state of the ListBox or items in the stateDescription element of the node's corresponding AccessibilityNodeInfo object. This CL also updates associated unit test expectations. AX-Relnotes: ListBoxes and ListBoxItems now explicitly announce their count and item index. Bug: 1101656 Change-Id: I41bf46d2f11ea9fb0c744ccd3802855c028ecb79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436382 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812477}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e92e2156. With Chromium commits locally applied on WPT: 09255d96 "[client-hints] Test client hint availability in service workers" 678dd97f "Revert "[client-hints] Test client hint availability in service workers"" c47ff7fb "[COOP] access reporting: openeeURL, openerURL, otherDocumentURL" af91c973 "Move the default framebuffer scale off of VRDisplayInfo" 432af8c1 "FontAccess: Replace Sticky Activation with Page Visibility check" 2a639e51 "[css-grid] Test for % max-height of image grid items" 98314cbf "[AspectRatio] Fix flex-aspect-ratio-01{3,4} tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id783ecddfdf2cd178773c5eff8995dc49b0edafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440291Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812476}
-
Anastasia Helfinstein authored
This is a pure refactor. AX-Relnotes: n/a. Bug: None. Change-Id: I6fab3b1663a7f4f8e2b2bcfe8d9b373f9c820ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382398Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#812475}
-
Xida Chen authored
TBR=qjw@chromium.org NOTRY=true Bug: 1133821 Change-Id: I12e6a29f930b2106aa9306f9f136e3460a975d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442151Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812474}
-
Khushal Sagar authored
This was added as a smoke test while OOPR was still under development. The feature has now been enabled by default and is used by all accelerated rendering tests. So this test is not necessary anymore. R=avi@chromium.org Bug: 757605,1067662 Change-Id: I6d9ab38d7e7291b645dac56b31cba4d79ee31155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441676 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#812473}
-
Jian Li authored
This reverts commit 4f97ffeb. Reason for revert: suspect of causing a lot of NTP test failures. Please see https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8867 Original change's description: > [ntp][modules] Add info dialog to shopping module > > Screenshot: https://screenshot.googleplex.com/7pbxJMPP2QgAgkM > > Fixed: 1130862 > Change-Id: Ied56500f9384fc9bedc15eef4cb8ffcde4830b5d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437473 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812227} TBR=mahmadi@chromium.org,tiborg@chromium.org Change-Id: I95a99407b60c89e7640a0e58055f05299c582c0c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442170Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#812472}
-
Jimmy Gong authored
PhoneStatusProcessor is responsible for converting incoming proto messages to PhoneHub objects and have clients be notified of the incoming changes. Bug: 1106937 Test: unittest Change-Id: Ib22c626ccd7c571692ae8c687935243a948c0581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427107 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812471}
-
Asanka Herath authored
Bug: 973801 Change-Id: Ieb11b4c1c187b85198470a130f38661b4ef7a292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438982Reviewed-by:
Dylan Cutler <dylancutler@google.com> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#812470}
-
Dirk Pranke authored
This CL reverts f60eb053 from March of this year; we were generating the big //testing/buildbot/*.{ci,try}.json files that combined all of the different buckets/masters, but we weren't using the files. By reverting the change this reduces the churn in the repo (and in CLs). Bug: 1028719 Change-Id: If394897d072836d744f7cd72a2b2b6deb8e06f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441651Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#812469}
-
Rachel Wong authored
This CL fixes a bug where results are never set to be answers due to circular logic. Bug: 1130372 Change-Id: I177dcaaa7a67e23cc31e49ea2f17f1a3ca249fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437317Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#812468}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ac160bd364cb..de0105d0bb7a 2020-09-30 nicolascapens@google.com Fix delegating eglCreateWindowSurface to CreatePlatformWindowSurface 2020-09-30 amaiorano@google.com Fix GN build 2020-09-30 amaiorano@google.com Optimize transcendentals for Subzero 2020-09-29 caramelli.devel@gmail.com EGL_KHR_platform_x11: wrong implementation in CreatePlatformWindowSurface() 2020-09-29 caramelli.devel@gmail.com Add DirectFB support for Vulkan WSI 2020-09-29 srisser@google.com Add VK_KHR_imageless_framebuffer 2020-09-29 bclayton@google.com SpirvShaderDebugger: Mark II 2020-09-29 bclayton@google.com Vulkan/Debug: Support Locations as hashmap keys If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1af877c3c004414bdd1d6f795c62ae5650e4aef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441669Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812467}
-
Tom Anderson authored
This is a reland of 63eccefc Original change's description: > Dynamically load libwayland-client and libwayland-egl on Linux > > This is needed since some distros do not have libwayland-client > available. If systems don't have libwayland-client, they definitely > won't have a wayland server either, so it doesn't make sense to > statically link libwayland-client, which won't make wayland work and > will only waste binary size. Instead, this CL dynamically loads > libwayland-client if available. > > Also, this CL includes some misc fixes to fix the 'ninja all' build > for Linux/ozone. > > R=msisov > > Bug: 1126894 > Change-Id: Ice0fd0b113f5d804cd05089bfad54168d94c53e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416941 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#810784} TBR=thakis CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng Bug: 1126894 Change-Id: Ie923f5203b3a42b0c6fe512f78e24724a5b16a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437704 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#812466}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/a528cef8c93e..8b462fcdef40 2020-09-30 jophba@chromium.org Properly use message router for cast message port If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ib9191acaa5cc72159eadfbba4a4240e99e323251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441330Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Jordan Bayles <jophba@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812465}
-
Brian Geffon authored
Add to simple UMA metrics so we can better track the frequency that working set trim is used. Bug: b:169771540 Change-Id: I77b9bb5d7bd17207b08513429748e90cc82f6d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441313Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#812464}
-
Dominic Farolino authored
R=haraken@chromium.org, kouhei@chromium.org, talp@chromium.org Bug: 1111231 Change-Id: Ia7151587a3459c5262edd5721c63dfec60870cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438709 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#812463}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aac5728a8260..8e0aa441a550 2020-09-30 bsalomon@google.com Get GrBackendRenderTarget's sample count from MtlTexture. 2020-09-30 robertphillips@google.com Have the GrShadowRRectOp make use of the thread-safe view cache 2020-09-30 robertphillips@google.com Have GrMatrixConvolutionEffect use the thread-safe view cache 2020-09-30 johnstiles@google.com Update TextureEffect to avoid extraneous out variable. 2020-09-30 brianosman@google.com Add Variable::fBuiltin, to track Variables owned by pre-includes 2020-09-30 bsalomon@google.com Return GrBackendTexture from SkPromiseImageTexture by value. 2020-09-30 johnstiles@google.com Update MatrixEffect to avoid extraneous out variable. 2020-09-30 ethannicholas@google.com moved SkSL ExternalFunctionCall's data into IRNode 2020-09-30 johnstiles@google.com Simplify generated GLSL code for trivial FPs. 2020-09-30 senorblanco@chromium.org Dawn: remove persistent TextureView from GrDawnTexture. 2020-09-30 smoreland@google.com Avoid heap initialization for skia allocations. 2020-09-30 brianosman@google.com Move VariableReference ref-adjusting into helper functions 2020-09-30 robertphillips@google.com Make GrRectBlurEffect use the thread-safe view cache 2020-09-30 johnstiles@google.com Calculate texture clamping X/Y coordinates in parallel. 2020-09-30 johnstiles@google.com Inline trivial single-argument constructors directly. 2020-09-30 michaelludwig@google.com Fix GrClipStackClip::preApply to report kClippedOut If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408,chromium:131355925 Tbr: brianosman@google.com Test: Test: removes large hwuimacro regressions w/ heap initialiation Change-Id: Id69e5298725680e0041331bce8b1f00c7153b4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441236Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812462}
-
Ben Goldberger authored
Bug: 1099982 Change-Id: Iec2303ba5485c52808e150a5aee2737a9ccbcd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436759Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ben Goldberger <benwgold@google.com> Cr-Commit-Position: refs/heads/master@{#812461}
-
Sebastien Lalancette authored
Adding EG test coverage for the following context menu actions: - Open in New Tab - Open in Incognito - Mark as Read/Unread - Copy Link - Share - Delete Bug: 1131831 Change-Id: I204073dfbf06905145363ecb75a4ae4272891073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435878 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812460}
-
Tommy Martino authored
This CL rolls the text-fragments-polyfill dep to pick up the util function for cleaning up the <mark> elements, and updates the Chromium JS "glue" file to attach this as a click event. Change-Id: I493fac576c52ded175fcf3957acb567cc5664690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435812 Commit-Queue: Tommy Martino <tmartino@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#812459}
-
Kartik Hegde authored
When a user is not logged in, ProfileManager::GetPrimaryUserProfile() returns an off-the-record profile. Instead of defining our own logic when a user is not logged in, use the existing logic of the function. BUG=chromium:956783 TEST=none Change-Id: I66efde824df0c4b5a22d1f1abdb293ddbea011fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436510 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812458}
-
Mustafa Emre Acer authored
Simplified URL Display experiments have five populations: 1. Default group 2. Control group 3. Delayed Warnings only 4. Experiment group 1 5. Experiment group 2 Default and Control groups don't set any of the bits in the UrlDisplayExperiment proto, so it's impossible to distinguish them in the analysis stage. To address this issue, this CL adds SimplifiedUrlDisplay feature. This feature doesn't turn on any features itself. Instead, it will be enabled by a server side config for all display experiments except for the default group. This way, the new bit in the URLDisplayExperiment proto will allow us to differentiate between the default group and control group. Bug: 1132457 Change-Id: Ie45545248b9ad1a15c774158a30e5162a6911a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432054 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#812457}
-
Ben Joyce authored
Reduces time from 14123ms to 4339ms Bug: 989569 Change-Id: I12318738a72d6c17b0cc41de360a550e860392df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438633Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#812456}
-
- 30 Sep, 2020 11 commits
-
-
Ahmed Fakhry authored
This reverts commit af996d67. Reason for revert: Issue 1133923: Many NTP tests fail on linux-chromeos-chrome BUG=1133923 Original change's description: > Reland "Use JS modules for the NTP module" > > This is a reland of 7927c8a6 > > TBR=calamity@chromium.org,steimel@chromium.org > > Original change's description: > > Use JS modules for the NTP module > > > > Uses JS modules for the NTP module and updates > > closure so it can resolve chrome://kaleidoscope. > > > > Change-Id: I985b20a7faca215bd5194a4a21c790d5a4ff0262 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435441 > > Reviewed-by: calamity <calamity@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#811807} > > Change-Id: I348d2116dc851394804866642a24da48d25e3edf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441109 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812268} TBR=calamity@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: I303b81834a65df123e1abe797b02e4b0c4ccb0ec No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442169Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#812455}
-
Brian Malcolm authored
This is the UI name of the entity that manages the user's domain, which can either be a domain name (foo.com), or the admin's email address (user@foo.com). This function will be used in future cl's. BUG=chromium:1081272 Change-Id: If0526718a1ae593543711b5a65bff78671123bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432090 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812454}
-
Peter Kasting authored
Bug: 772945 Change-Id: I6ec2c460f5254736c48b35a15638f05320e00c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440909 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#812453}
-
Daniel Hosseinian authored
Bug: 652400 Change-Id: I44b3f9561c3186f9c40d52201ad4ec30b3f9c6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439433Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#812452}
-
Robert Ogden authored
Uses the PolicyTest browser test base, with minimal Isolated Prerender enabling on top. Bug: 1133815 Change-Id: I63c60a07aea25050cc750f575aa1841686c16a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440224Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#812451}
-
Fabrice de Gans-Riberi authored
Bug: 1073821 Change-Id: Ib1659d8bde4d020d768ecbe6eb11bab81b5db662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429610Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#812450}
-
Scott Little authored
This histogram is still in use, so this CL extends its expiration. Fixed: 1089164 Change-Id: I23a0a4ec11941360dbb2948415106b15b7ba9fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439426 Auto-Submit: Scott Little <sclittle@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#812449}
-
Willie Koomson authored
This change adds support for SetVmId() call to ConciergeClient, which is used by ArcVmClientAdapter to set the correct owner id for a mini-ARCVM instance. BUG=b:144542975 TEST=Use function from ArcVmClientAdapter, and check that vm_concierge receives the call and responds successfully. Cq-Depend: chromium:2354353 Change-Id: I098b3fa2c1e829b693906a234aae635fa0b3ae80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354493Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#812448}
-
Ian Kilpatrick authored
Previously when we had a specified main-size, and we were a table, we considered this to be the min-size instead. This was incorrect. Instead we should have been applying the min content-size as the floor for tables, and leaving the main size alone. Bug: 1128941 Change-Id: I7310b5d31990ff77a028837f742b3a0eba697318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438775 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#812447}
-
Mike Wasserman authored
Notify the renderer of user activation when the permission is granted: Override UserMadePermissionDecision to call NotifyUserActivation. Add RenderFrameHost[Impl] plumbing for the LocalFrame signal. Add UserActivationNotificationType plumbing for LocalFrame interface. Add a basic browser test. Bug: 1083357 Test: Scripts can requestFullscreen({screen: (await getScreens()[0])}) Change-Id: Ia72b7f003b7807ed13de6e76612d107f8050fc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426884 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#812446}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3773c401fe1a..f38f54f2f1a3 2020-09-30 kimstephanie@google.com Add optional enforce_fetch kwarg to fetch and refresh git cache If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1129235 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I4a41c9fc8a96538834c52553e675c5c405a14413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812445}
-