- 06 Aug, 2020 40 commits
-
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/01ee4caa5ab5..50c5bbd8f04a $ git log 01ee4caa5..50c5bbd8f --date=short --no-merges --format='%ad %ae %s' 2020-08-05 jdrago Minor changelog tweak 2020-08-05 jdrago Fix incorrect 16-to-8 monochrome YUV conversion 2020-08-03 kornel Make decoding optional 2020-08-03 linkmauve Add an ignoreAlpha field to avifRGBImage 2020-07-28 dnovomesky Save support in gdk-pixbuf component 2020-07-31 jdrago Update changelog 2020-07-31 jdrago Only ever create one iref box, filled with multiple cdsc boxes 2020-07-24 asn cmake: Include avif INTERFACE_INCLUDE_DIRECTORIES first 2020-07-22 asn cmake: Use correct include dir for apps/shared 2020-07-22 dnovomesky Fix a crash in the gdk-pixbuf loader, removed unnecessary asserts 2020-07-21 ccom CMake: Add -Wno-error=c11-extensions for dav1d 2020-07-19 ccom CMake: Set C standard to c99 2020-07-19 ccom CMake: Only enable CXX if using libgav1 2020-07-16 wtc Move ptrU8,ptrV8,ptrU16,ptrV16 out of i for loop 2020-07-17 linkmauve Fix a crash in the gdk-pixbuf loader when error is NULL 2020-07-19 jdrago Disable libgav1 until abseil-cpp stops using CMP0077 on newer CMake versions Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Change-Id: I2b93528963d3a56802a40a8f788f6158e247b726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340070 Commit-Queue: Wan-Teh Chang <wtc@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#795332}
-
Kartik Hegde authored
Use the proper term "Problems" instead of the the generic "Messages" and add sync message. BUG=chromium:956783 TEST=unit_tests --gtest_filter=NetworkDiagnosticsImplTest.* Change-Id: I54e21cf1b85eb16c733178dfe8816c1f5cf7e0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337391Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#795331}
-
Ankit Kumar 🌪️ authored
Bug: 1030242 Change-Id: I1ec4145d993385ee06ac3718f9b80a8d88996ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325528Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#795330} -
Ted Meyer authored
these structs are already in the media namespace, they dont need media:: Change-Id: I2844d35cf27d46b860b4969ea5e1960d522f3d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339390Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#795329}
-
Hajime Hoshi authored
This CL enables UseCounterPageLoadMetricsObserver for back-forward cache. The page load's UKM ID is used to record the use counters even after the page is restored from the cache. It is because the metrics are per-page-load metrics and not belong to history navigations. Bug: 1112282 Change-Id: I791713e1c2b5bcf610c49d8866527f9be20c9376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334787Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795328}
-
Peter Kasting authored
* Ordering better matches enum/member declaration order. * Most changes are just code movement, but in OnPaint() there's also some renaming and inlining of temps (+ resulting simplification). Bug: none Change-Id: Ia5046d91b701fabe9f31b69131de3d11e578706a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334086 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795327}
-
Mark Mentovai authored
Change-Id: Ia077c79f431afcb8af773af630aabea9c9a2e2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340173Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#795326}
-
Peter Kasting authored
Bug: none Change-Id: I24b64874e1ad946533dff9b491b8e6def2304362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332039 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795325}
-
sczs authored
- ContentSuggestionsMediator uses DiscoverFeedDelegate to notify its Coordinator of Discover Feed Changes. - ContentSuggestionsCoordinator refreshes the Feed and sets a new ViewController (Created with the refreshed model) via its mediator. - Creates a DiscoverFeed Observer and its bridge in DiscoverFeedProvider. Bug: 1085419 Change-Id: If5b91d1cf9c99e164f4d9a50b5071ae65816350b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327846 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#795324}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I8aaa41f4779e5343221845efd42d7a2e99e071b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339293Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795323}
-
John Delaney authored
What: This is a speculative fix for a high failure rate of sqlite open errors seen with conversion feature enable. How: Attempt to create the conversion database directory if it does not exist before init. Why: Similar errors have been seen when using profile paths to initialize storage, and there is not a guarantee currently that the directory we are passed does exist. See https://crbug.com/1098019 Bug: 1112629 Change-Id: I895f2155dba3d6d6734769b6ef1f8872622c0a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340285 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#795322}
-
Kuo-Hsin Yang authored
When there are JavaScript memory leak, V8 ArrayBuffer could take more than 90% of available virtual memory size and causes out of memory errors in other modules (e.g. video playback) and crashes the renderer process. Limit V8 ArrayBuffer allocation to 50% of available virtual memory size so JavaScript memory leak would not crash the renderer process. Bug: chromium:1100299 Change-Id: I147d05d2d25660016dec3e5fa48848c03c516a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335629Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795321}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f52572f002a6..dcb6f8084e45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I93782dcabcbe7dbc60fdc7ae99576aa9133fdbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795320}
-
Piotr Bialecki authored
We have moved away from allowing session reconfiguration, this change modifies implementation to rely on the requested features to decide whether detected plane information should be surfaced to the application or not. In addition, add "plane-detection" feature descriptor. Change-Id: I2070d1096ad31c451e295688c0be35ff149886a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333998 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#795319}
-
Ryan Hansberry authored
Implement mojom::Socket, a Mojo interface for interacting with device::BluetoothSocket. This implementation mirrors the implementation of tcp_socket.mojom: it uses a pair of Mojo DataPipes to stream sent and received data, instead of mirroring device::BluetoothSocket's Send() and Receive() methods. This CL only adds mojom::Adapter::ConnectToServiceInsecurely(), to allow clients to initiate a connection. A subsequent CL will add mojom::Adapter::CreateRfcommService() to allow listening for an incoming connection. This implementation has been manually verified by running a Nearby Share (go/nearby-chrome-bt) prototype on a Pixelbook, communicating with a Pixel 3. Please see design doc go/nearby-chrome-bt for more details. Bug: 1043300 Change-Id: Ice8110ef9bce905ab46cc38fee3110f8d0775644 Fixed: b:157750558, b:157484150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292871 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795318}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ded65da11a18..a28c7896f97f 2020-08-06 bsheedy@chromium.org [Telemetry] Fix LFBM tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1108432,chromium:1111474 Tbr: oysteine@google.com Change-Id: I1504824aa5da5a7bd70a89e367701c9f7ad0cd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340602Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795317}
-
Noah Rose Ledesma authored
Currently we do not support device switching for Cast sessions via the audio device selector in the zenith dialog. As such, the audio device selector view should not be added to cast zenith notifications. In order to distinguish cast notifications from local ones, a method was added to the MediaNotificationItem base class. Bug: 1104270 Change-Id: I16d57849b4370e6313c3cc8b4733d97d79af177f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321050 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#795316}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dba1d65a1999..b932a7fed903 2020-08-06 dpranke@google.com Remove dpranke@chromium.org from OWNERS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I8c611c243cbc5912085bf2bfc69faf37c0c6cce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340563Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795315}
-
John Palmer authored
BUG=1110772 Change-Id: Ia529efe32960a3b5ea356ee61a937e8db751a0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325493 Auto-Submit: John Palmer <jopalmer@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#795314}
-
Liviu Tinta authored
This is a reland of fc4093a6 My assumption is that the test failed on the bots because the code tried to serialize async_tests. I rewrote this wpt using promise_test instead. Original change's description: > Move mouse-pointer-preventdefault.html to wpt > > Move mouse pointerevents compat events to wpt > > Change-Id: I9581dde4d6016a3eb81ea16674c439e63897523c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199985 > Commit-Queue: Liviu Tinta <liviutinta@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771159} Change-Id: I3ec09bd5d180ae0c52c7a02bb3f3191cacf9b0d7 Bug: 1085549,1085647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330316Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#795313}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/91bbd01aed3e..e8789a53f539 2020-08-05 timvp@google.com Vulkan: Don't always end the render pass when updating the scissor 2020-08-05 ynovikov@chromium.org Make roll_chromium_deps executable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1104516 Tbr: geofflang@google.com Test: Test: CQ Change-Id: Ib5e604eec592bae768280f6e560fe8cc91d7508b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340273Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795312}
-
Trent Apted authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/1izNFT_phlvwP0ztDjyMFLL16mHtl9k3RMudmVlRzkkC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202008050800_RC00.html Bug: b/159394176, b/152915200, b/161194914, b/160021752, b/159850939, b/160019065, b/162468431, b/161761740, b/162102218, b/162541713 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I138acf68887d5cb8b9315fe267260c6b6dfe67be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340117 Commit-Queue: Bugs Nash <bugsnash@chromium.org> Auto-Submit: Trent Apted <tapted@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#795311}
-
Dale Curtis authored
These should expect BT.709 when the proper color spaces are not supported by the OS version. R=sandersd Fixed: 1113153 Change-Id: I86805fc80904236d5051ece61ce6612e3b64e74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339538 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#795310}
-
David Bokan authored
This mojo interface is dead code leftover from the "touchless" experiment. This CL effectively reverts the relevant bits of: https://chromium-review.googlesource.com/c/chromium/src/+/1562714 As well as the modifications introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1824504 Bug: 1062457 Change-Id: I582cbd342cde9c758eaaa217d09f755fd03c70fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339698Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795309}
-
Tibor Goldschwendt authored
Previously, the test didn't trigger a resize because width and height were initialized to 'undefinedpx' and that confused the transition system. Fixed: 1065812 Change-Id: I1fca652298fa5f5214946661a8d81ce51e06c8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340406Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795308}
-
Jeremy Roman authored
std::remove_if is incorrect, since it leaves the elements past the new end iterator in an unspecified state, but the code now accesses these elements in order to copy them to |completed_decodes|. This is not a purely theoretical concern: the natural implementation of std::remove_if works by keeping an output and input iterator into the range, moving an element from the input to the output iterator if the removal predicate does not apply. But consider this sequence: [complete, incomplete] std::remove_if can legally (and likely will) transform it into the following (noting that for blink::Member, moves are copies). [incomplete, incomplete] After which the incomplete request will be erroneously resolved. Instead, std::stable_partition should be used, which returns the partition point, to the left of which contains the matching elements and to the right of which are the non-matching elements. Like std::remove_if, order is preserved (for the elements where the value was specified). Note that the sense of the predicate is reversed here. Bug: 1108535 Change-Id: I52191943094042c09428f09857d5f62e3810e8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340367 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#795307}
-
Kent Tamura authored
fieldset content box LayoutNGFieldset should adopt LayoutObject::UpdateAnonymousChildStyle() to update properties correctly. Also, we need to add kFlowRoot support to LayoutBlock::CreateAnonymousWithParentAndDisplay(). Bug: 875235 Change-Id: I8601f1c576c8ee818e69d43dc299026a03879ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336565 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#795306}
-
Kai Ninomiya authored
This test recently became so slow that it now reliably times out. Still investigating why it's slow. No-Try: true TBR: kbr@chromium.org Bug: 1113404 Change-Id: I58e254c3f1d67667d301514979704ac4ab55b56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340589Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#795305}
-
David Stevens authored
Transforming a surface's damage into its target space involves a bit of floating point math. This can introduce small errors - for example, scaling 1680x945 by .8 results in 1344.000122x756.000061. If we don't ignore this error, the inflated enclosing rectangle can prevent overlay optimizations from operating effectively. Bug: 1113146 Change-Id: Ic08dd08180b054b2637e57ab68b1577214bec4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338277Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: David Stevens <stevensd@chromium.org> Cr-Commit-Position: refs/heads/master@{#795304}
-
edchin authored
Prevents drop if the bookmarks folder is the top-level folder. Bug: 1110310 Change-Id: I24a03449477e97caff694c2bd6aad9a7edd3b6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340341 Commit-Queue: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#795303}
-
Peter Kasting authored
* Construct more things in the declaration * Make more things const * Slightly improve variable names * Use AddChildView(std::make_unique<...>(...)) idiom for brevity * Remove various unnecessary setter calls * Enable auto color readability; set background colors correctly to make this work properly; use a solid background for the overall view while at it Bug: none Change-Id: Ie13ccdb0e620d2f80736daa8a41590a8dfc5116f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333500 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795302}
-
Minoru Chikamune authored
We are going to remove ipc_task_queue and ipc_task_runner. The scheduling policy of ipc_task_queue is the same as the default task queue. Nowadays, we are using per-frame task queues as much as possible. And if there are no relevant per-frame task queues, then we can use the (per-isolate) default task queues. [related design doc section] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A/edit#bookmark=id.eeuir8g768ou Bug: 1105403 Change-Id: Ic085105a952f99f6b0e3198515338ec458b7d560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336244Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#795301}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/672c47689dc1..b72037527fd5 2020-08-05 herb@google.com Revert "Switch GN defs on Mac and iOS to use frameworks, take 2." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I196ee68d138bdc3bcdb8df6e855795e2292d233d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339406Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795300}
-
Kuo Jen Wei authored
To avoid requiring to sort out js dependency for closure compiler check manually, this CL gather checked file into a single js_type_check and remove all 'deps' label. Bug: none Test: ninja -C out/Release chromeos/components/camera_app_ui/resources/src/js:closure_compile Change-Id: I2341609e243164ae640243642424739e2c5bd9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336246 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#795299}
-
Brian Sheedy authored
Restricts the test disable for the Telemetry minidump symbolization tests to Windows 7, as the issue that caused it to be disabled in the first place only occurred on that version. These are important tests to prevent symbolization regressions from making it in, so they disable should be as strict as possible. Bug: 1084931 Change-Id: If77bccf48420564a1792b2dad64c95356bed53af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340293 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795298}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9a43f48ed4cd..f52572f002a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7f61bb73ce89e8405cc27bf76000b88d1cd39dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340404Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795297}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6dacd170b8de..ded65da11a18 2020-08-06 dberris@chromium.org debt: Remove IP-based authorisation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036507,chromium:1051243 Tbr: oysteine@google.com Change-Id: I67a38856cf39361c25c7df098f01ba6a3393e71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340274Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795296}
-
Ben Wagner authored
Bug: 1018739 Change-Id: I1a68eac36ec536522d87a78b112a42e4609bed17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339717Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#795295}
-
David Schinazi authored
This is a followup to https://crrev.com/c/2337542 which forgot to update the documentation. R=nharper@chromium.org Bug: 1112925 Change-Id: Id1ed5fe2421367a26828da85ebae257add8c3bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340424 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#795294}
-
Charlene Yan authored
This regression was caused by this refactor: https://chromium-review.googlesource.com/c/chromium/src/+/2324113 The original code for building the submenu would skip ID values for groups that would not appear in the submenu. (The Build() method would call GetOrderedTabGroups then skip over groups that should not show in the submenu.) Skipping ID values was not done after the refactor since the subclasses would call the base classes with a vector of MenuItemInfo to populate the submenu. Bug: 1112719, 1112721, 1108062 Change-Id: I4a3490d646c553d1c60dd548fa13f53df9183561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337547Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795293}
-