GitLab

This CL also dynamically generates the tickmarks on the font size
slider based on the supported font sizes provided in the JS code.

Bug: 1027612
Change-Id: I4179430993ef31381f84099b6f4109b8b18fecd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960070
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726034}

The FCMInvalidations.SubscriptionResponseCodeForTopic histogram already
had suffixes for all Sync ModelTypes. However, FCM invalidations are
also used for other features (Drive, Policy). Previously, such cases
where not properly covered.
This CL introduces an "OTHER" suffix to catch all non-Sync
subscriptions. It might be possible to split this up further, but it's
not easy to do at this point in the code, and anyway it's not clear if
the possible set of topics is always known statically.

Bug: 1023813
Change-Id: I8571fa5061a6b7bb842353a3fbbddda0397acf5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970994Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726033}

A nullptr manager can be encountered if a cross-sequence operation
is begun during the shutdown of the storage partition.

Bug: 1033251
Change-Id: I98c77a714dc7eb04a31a103c95012a7a989b9580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964931Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726032}

Per the spec, the common ancestor element of the match range becomes the
target element[1] and should have the :target pseudo-class applied.

[1]
https://html.spec.whatwg.org/multipage/browsing-the-web.html#target-element

Bug: 959163
Change-Id: Idb462a17972f4758df9617653f03b88196fd565a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965273Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726031}

This means that if you abridge a benchmark or remove stories from
a benchmark then that information will be reflected in
http://go/chrome-benchmark-schedules as soon as you check in your
change.

Also, add a --filter-only option so that we can keep this up to
date without needing to run a slow bigquery query each time.
Also, add validation to presubmit so that this stays up to date.
Also, make the output deterministic by sorting it.


Bug: 1030840
Change-Id: I2cda6110a029953559874707852230693d0ac7b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973232Reviewed-by: John Chen <johnchen@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726030}

I somehow checked in the wrong schedules file in
https://chromium-review.googlesource.com/c/chromium/src/+/1956369
that didn't account for the changes in
https://chromium-review.googlesource.com/c/chromium/src/+/1956369

In this change, I manually skip the bigquery work to simply get
the whole thing in sync. Later I will add presubmit checks for all
of this.

Bug: 1030840
Change-Id: I20cc91b574396bdbb78642430d0effef86525025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973239
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726029}

Bug: 1018718
Change-Id: I1f43af0d604d58abe37f2cacf58283b795e1d725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948230
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726028}

Bug: 922145
Change-Id: Iefd23b8fc535628e6165b6a09608b205ed705096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973788
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Reviewed-by: Yun Liu <yliuyliu@google.com>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726027}

* Added name for wallpaper widget
* Renamed EndPendingAnimation to StopAnimating
* Renamed WallpaperWidgetController::property to GetWallpaperProperty().
  (It'll be delegated to wallpaper view in next CL).
* Added WallpaperView::proeprty(), instead of returning blur_sigma/opacity separately.

Bug: None
Test: None
Change-Id: Ic8aa86990a45e6a99472733f4949861be22dd89e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973963Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726026}

https://skia.googlesource.com/skia.git/+log/8d97c155be33..ee94693c7ab1

git log 8d97c155be33..ee94693c7ab1 --date=short --first-parent --format='%ad %ae %s'
2019-12-18 robertphillips@google.com Fix a sprinkling of GPU issues
2019-12-18 rmistry@google.com Make OUTPUT_DIRECTORY in ProdDoxyfile configurable
2019-12-18 csmartdalton@google.com Add a kWireframe flag to GrPipeline

Created with:
  gclient setdep -r src/third_party/skia@ee94693c7ab1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC borenet@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: borenet@google.com
Change-Id: Iab150c8bd8dc87a161348be0d2a267aa352dfba4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974196Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726025}

The flag to disable v1 DeviceSync is was named
"CryptAuthV1DeviceSyncDeprecate". The word "deprecate" is ambiguous.
Rename to "DisableCryptAuthV1DeviceSync". Also, change helper function
name from ShouldDeprecateV1DeviceSync() to ShouldUseV1DeviceSync() in
order to avoid double negation in the code.

Bug: 951969
Change-Id: Ibbc4286a9c2d6eac50dbfb428ecb3ca06abcacd5
Fixed: 1034041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972237Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726024}

The feature is launched everywhere so the feature checks are no longer
necessary.

Bug: 936425
Change-Id: I7ad1800cc44dc9260ea2348825b7d11aa330e842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972314
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726023}

After we switched to using mojo host resolver in
https://chromium-review.googlesource.com/c/chromium/src/+/1199848/
we need to make sure HostResolver is destroyed on the same thread
that it was created on.
Ensuring this with ref-counted DeviceProvider would require
a helper class, so just re-create it each time we need to
resolve a host for simplicity.
The overhead should be small considering to other things we
do (like not caching host resolution lately etc).

Bug: 1028292, 1025369, 921608

Change-Id: I6f8d2e663f0ac872964e1725e261232493bbbfe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972781
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726022}

Updates InfobarOverlayRequestCancelHandler to handle InfoBar
replacements.  When the corresponding request's InfoBar has been
replaced, the cancel handler creates an OverlayRequest for the
replacement and inserts it in the queue after the replaced InfoBar's
request.  Then, the existing request is cancelled, removing it from
the queue.

Bug: 1030357
Change-Id: Idff53a277c4115adb6075017db5aed4c4e3afac7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960810
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726021}

Improve and possibly de-flake the browser test
BrowserActionApiTest, CloseBackgroundPage. This includes:
- Moving away from the content::NotificationService system to an
  ExtensionHostObserver; this ensures we receive events for the right
  ExtensionHost.
- Waiting for the setBadgeText() call to finish before closing the
  background page.

Neither of these is guaranteed to fix the problem (which I was unable
to reproduce locally), but they're still desirable, so may as well give
it a shot.

Bug: 1035075
Change-Id: I6b24d64d7ddd95b46bb26aae411e8a7ce269e3d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972292
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726020}

Using wpt-import in Chromium ccf01bd7.
With Chromium commits locally applied on WPT:
c15c1083 "Add test that datachannels close when connection does."
fadf6027 "[css-pseudo] Recalculate viewport units in ::marker"
044ad8ad "[OT-PW] Make it work with OOP-R"
2ad15546 "Make interpolation-testcommon.js support composition"
9899425d "[css-layout-api] IntrinsicSizes Implementation"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I75fd3a0d9f748e42ba11b91ed1f051c1701e49e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973995Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726019}

source_id and sequence_number is used on BeginFrameArgs and
BeginFrameAck for identifying the frame. This Change creates a single
struct for these info.

TBR=sky@chromium.org, eseckler@chromium.org, meacer@chromium.org

Bug: none
Change-Id: Iabafca83472af0facd39ada5f11c6ad2017bf84d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966606
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726018}

- significant changes in this change when compared to upgrade to v3.11 (which was reverted)
t/l/w/liblouis_wrapper.js.
c/t/d/c/liblouis_wasm/test.js also exercises the
en-ueb-g2.ctb
table which actually caused many of the crashes with the original change.

Most notably, LibLouis now seems to more often than not, require a null terminated string. This is an improvement, though lou_translateString is quite unpredictable as to whether it counts the terminator in its out param (inLen).

Between the upgrade to v3.12, and the compile of the wasm module using the latest Emsdk (though fastcomp), seems to have resolved instability.

Bug: 1033082
Test: browser_tests --gtest_filter=ChormeVox*.* and --gtest_filter=LibLouis*.*.
Manually with a Focus 40 which has a hardware braille keyboard. Also, test with en-ueb-g2 which was causing crashes.

Change-Id: I930c6dbe771dafb7df39f50eb16ba15fda418609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970643
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726017}

Notable EG2 changes:
 - Use ensureAppLaunchedWithFeaturesEnabled to enable the feature
 - Do not tap back to dismiss settings (this does not fork in EG2 and
   tappoing back is irrrelevant for acessibility testing, which is the
   purpose of this test).

Bug: 987646
Change-Id: Ib3794661e09cd6a40d4e46999c31626f47d70124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972911
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726016}

This CL also adds the ability to remove configurations from expectations that do
not have bugs. This CL also affects the behavior of the rebaseline and try-flag tools
so that it will create expectations which do not have more than one mutually exclusive specifier.
It also adds a new presubmit check which prevents users from creating expectations that contain
more than one mutually exclusive specifier. We are doing this because the new test expectations
format does not allow expectations to have more than one mutually exclusive specifier.

Bug: 986447
Change-Id: Ic97c4f1bba1e57b71f4624ef88ad69b5c8122a9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970297
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726015}

This CL adds BrowserObserver to the public Browser target and updates
some BUILD.gn files to reference the public target.

Bug: none
Change-Id: I78a009fb6569121cd745f7f5771c43c1c538f24d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972586Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726014}

It's unused.

Bug: none
Change-Id: Ic080066b9502f834a5f77abdffe53a5967c8e79b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972457Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726013}

Use "sources" as substitute for "java_files" in Android build template
rules. This will allow us to have usages of "sources" and "java_files"
exist simultaneously while build files are migrated.

Bug: 1035073
Change-Id: I6941c8351c18d6a8162ff1907c3ffbbac3f33a7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971635Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726012}

IWYU, and fix the libstdc++ build:

../../chrome/browser/ui/autofill/payments/virtual_card_selection_dialog_controller.h:28:22: error: no template named 'vector' in namespace 'std'
  virtual const std::vector<CreditCard*>& GetCardList() const = 0;
                ~~~~~^
In file included from ../../chrome/browser/ui/autofill/payments/virtual_card_selection_dialog_controller_impl.cc:5:
../../chrome/browser/ui/autofill/payments/virtual_card_selection_dialog_controller_impl.h:36:55: error: only virtual member functions can be marked 'override'
  const std::vector<CreditCard*>& GetCardList() const override;
                                                      ^~~~~~~~

Bug: 957519
Change-Id: Ie4466ed7be0d8392149a64c89d0871621e4e4687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973822
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726011}

Migrates some directories off of deprecated base::Bind, base::Callback,
etc, and onto the newer APIs.

Specifically this covers files in components/search_provider_logos/

Fixed: 1007728
Change-Id: Icc664ea3b2fdfc690d0cfe32a879b4d8c071707e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972240Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#726010}

There was a bug caused by overlay refactor that affected Mac overlay
damage calculation. Add unittest to make sure it doesn't happen again.

R=ccameron

Bug: 1022116
Change-Id: Iaa2f67640b80f94070e25c8ebc25db81ab83dcba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972166Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726009}

Tbr: ellyjones@chromium.org
Bug: 1035485
Notry: True
Change-Id: I848704674470a5ae05de5229159fd4a27a28c358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974291Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726008}

Add diagnostics-related methods to cros_healthd::ServiceConnection.
These methods will allow Chrome to initiate and control diagnostic
routines on the platform. In the future, remote commands will
consume these diagnostics methods.

Bug: b:128683357
Test: chromeos_unittests --gtest_filter=CrosHealthdServiceConnection.*
Change-Id: I1629a5ae97fb731e49b160edb3d8c2d79f2fc863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967968Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726007}

This CL prevents the detectors from stopping the LCP computations when
a keyup is detected. This prevents refreshing via Ctrl+R from stopping
the computations prematurely, as the reloaded page receives a keup.

Bug: 1034080
Change-Id: Ic22193fd29e9cd939e57e7210b22918d5f203683
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969051Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726006}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/24f39c439784..fd2e3212e078

git log 24f39c439784..fd2e3212e078 --date=short --first-parent --format='%ad %ae %s'
2019-12-18 liviurau@chromium.org [presubmit] Allign authors check with the way we do it in V8

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@fd2e3212e078

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ie5e6342d1d34c2ea2c098168c650172f2fb6d747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973945Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726005}

https://android.googlesource.com/platform/external/perfetto.git/+log/3be20911d9a3..703bcab9106c

git log 3be20911d9a3..703bcab9106c --date=short --first-parent --format='%ad %ae %s'
2019-12-18 rsavitski@google.com traced_perf: in-tree builds: arm register parsing basics

Created with:
  gclient setdep -r src/third_party/perfetto@703bcab9106c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I12eaa304adf26342a73c67314fae9e05168a50b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973944Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726004}

This adds the field trials config as required for cl/285264679

Bug: 978139
Change-Id: Ifd9e354a9e7d4141f1bc8620d9c729a5f1d8bebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970740Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726003}

Change-Id: I2078a3fb0c795be2a879a036e73eec32ace4d2a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961268Reviewed-by: Darin Fisher <darin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726002}

This way, it can be used in QUIC code that does not depend on
QuicStreamFactory.

R=rch@chromium.org

Bug: 1011392
Change-Id: I5d585067012ec7e5c28779080326ebdd1318203a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973171Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726001}

Attempt to deflake ExtensionBindingsApiTest.LastError. The test was
failing with a segmentation fault, which most likely happened when
trying to de-reference an ExtensionHost that could be null. Try to
fix this by:
- ASSERTing the ExtensionHost exists (at least giving us a good error
  message if it does not)
- Waiting for a "ready" message from the extension, which guarantees
  the background page has been created.

Bug: 1035011

Change-Id: I13510ea649f6488f216bf50bd4cf00bb9d521292
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972263Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726000}

This is a reland of crrev.com/c/1894296

The commit was reverted in crrev.com/c/1971041 because the new browser
tests failed when run by the |linux-chromeos-chrome| trybot.

The tests failed because the |fake_s3_server_main| binary was not copied
over to the sandboxes used by the |linux-chromeos-chrome| trybot while
it runs its tests.

This is fixed by adding the |fake_s3_server_main| as a runtime dependency
of the |browser_unittests| build target.

Original change's description:
> Add Assistant integration tests using a fake S3 server.
>
> These tests run as browser tests, use the real libassistant code and use a fake
> s3 server to replay previously recorded conversations.
>
> This allows the Assistant to run CQ tests that verify the basic interactions
> are not broken.
>
> More specifically, this uses a FakeS3Server library that was previously
> created by the LibAssistant team. On the ChromeOS side I added hooks to
> tell LibAssistant to use the FakeS3Server, and a test-fixture to start/stop
> the fake S3 server during the browsertests.
>
> BUG: b/141264108
> TESTS: in target |browser_tests| with names |AssistantBrowserTest.*|
>
> Change-Id: I89985c9e34eaa21a17eef69fa5b472fa39486d30
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894296
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
> Cr-Commit-Position: refs/heads/master@{#725214}

TBR=xiyuan@chromium.org,sammc@chromium.org, xiaohuic@chromium.org
TBRing reviewers:
   - Note There were no changes in any file since crrev.com/c/1894296 except |chrome/test/BUILD.gn|
   - xiyuan@ please look at assistant_test_api.h
   - sammc@ please look at assistant.mojom
   - xiaohuic@ please look at the assistant code

Change-Id: I514daac006c1254db26adf8b0fd3f6be652f4581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971225Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#725999}

Bug: 825305
Change-Id: Ib3643d72e2ac9226a58838dad2738ecacccd569e
Tbr: sidereal@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972759Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725998}

This will allow chromeos::CrostiniManager to access
SchedulerConfigurationManager.

BUG=1011559
TEST=arc.Boot, ARCVM still starts

Change-Id: Idf76dbf595a652c09ca444fa90c9738976553dc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972293Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725997}

We're failing at unregistration time. See if the registration succeeded
at all.

Bug: 1030618
Change-Id: I34465971c8a622d9f4c86614b1514ab3282af2ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973959Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725996}

Bug links without numbers cannot be used in the new test expectations format.

Bug: 986447
Change-Id: I32c6dcf656c8bcc010bbb37b2aec76939f51d980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973153Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725995}