- 09 Oct, 2020 40 commits
-
-
Antonio Gomes authored
aura::Window* properties in this file will be accessed by both Ash and Lacros code. For now, it moves ash::kIsShowingInOverviewKey to the newly added //chromeos//ui/base/window_properties.h|cc files. The property is used by //ash/public/cpp/caption_buttons/ code. Today, Lacros code will access the properties directly, but the idea is to avoid a generic window property API, and instead have specific methods to access the properties (backed by Mojo) - follow up. This implements section 0, on the design doc [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/edit BUG=1113900 R=jamescook@chromium.org Change-Id: I4c10ab79b766839551fbb2322cf38d6b1dbf2b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450666 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#815464}
-
wutao authored
When the secondary user logs in, the OnLockStateChanged() was returned due to the Ambient mode is not allowed, therefore the ambient UI is not closed. This patch moves the close ui logic before the ambient enabled check. Bug: 1136302 Test: Added new unittest Change-Id: I2d9c93087b8e8139936271db2a797f6322bb55ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462246Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#815463}
-
Hajime Hoshi authored
Bug: 1136690 Change-Id: Icefa36ff77c21cb49e3ff65120e9a91ad679dec0 Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462758Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815462}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I63c1953958510d34850c8369be168c7360ddef8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461800Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815461}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602179909-9d7f0b29438414a4f2265cc4ee2a14492d697def.profdata to chrome-linux-master-1602201537-8720b3c79a1854f8e56100a84c355502c0dbbf4a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic7654b6af8076400cec97d018f5bb14790a44765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815460}
-
Roberto Moura authored
Resetting the grid view controller's |reorderingLayout| to a GridReorderingLayout (instead of a TabSwitcherReorderingLayout, which subclasses TabSwitcherLayout instead of a GridLayout) fixed the issue. Bug: 1135507 Change-Id: I35f9faa1bdb5962709bef528f9ec849fb499895f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454709 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#815459}
-
Tomasz Wiszkowski authored
This change: - Wires up all event signals for the MostVisitedTiles. - Adds the Integration tests for the MostVisitedTiles. - Adds CONTENT_DESCRIPTION TileView property. - Drops the proxy class 'AutocompleteCoordinatorTestUtils' consolidating the Omnibox Test support code within OmniboxTestUtils. - Explicitly calls some of the Test-specific methods so these are not accidentally used outside of test environment. MV Tiles still require the Unit-Testing part which will be introduced with the next related patchset. Skip-Translation-Screenshots-Check: True Change-Id: I600cae57f6242b6374d8f9d6e68a1179194ffeaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446771 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#815458}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/30378382aa3e..2ae1dd93d853 2020-10-09 jvanverth@google.com Revert "Add sk_Caps.builtinDeterminantSupport and use it in cross()." 2020-10-09 brianosman@google.com Remove custom iterators from SkSL::Program 2020-10-08 jvanverth@google.com Revert "Rename GrStencilAttachment class to generic GrAttachment" 2020-10-08 johnstiles@google.com Add sk_Caps.builtinDeterminantSupport and use it in cross(). 2020-10-08 michaelludwig@google.com Add SkImageFilters::Shader in place of Paint factory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: Ida4527b1fd606d491992707392c1750286a7e183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461687Reviewed-by:
-
Michael Checo authored
This is a reland of 4f4586fd Issue: FocusRowBehavior was not initializing properly which caused "keydown" events to target the Polymer element itself, most likely through event retargeting (http://shortn/_Nfy2DTMeen). Fix: After populating nearby printers, wait for the next render of the nearby printers page to ensure the FocusRowBehavior setup is completed. With this change, the element with the "focus-row-control" attribute now consistently becomes the focused element when navigating through the printer entries. Original change's description: > Printer settings: Make saved/nearby printers use FocusRowBehavior > > Description: > This change allows users to tab to the first printer in the saved > and nearby printer lists and use the arrow keys to navigate the > remaining printers. Users can also use the arrow keys to navigate > through a printer entry's associated buttons/icons. Lastly, the > printer entry row will be highlighted (blue background) if it is > being focused. > > Screenshots: > - http://shortn/_Fqf1Nn9qjF nearby printers > - http://shortn/_BSspETkjzV saved printers > > Bug: 987422 > Test: gtest_filter=OSSettingsCupsPrinterLandingPageV3Test.All > Change-Id: I68fc5fc3ff2ceec88ce81f95da5b451a6ad3beb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399601 > Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> > Commit-Queue: Michael Checo <michaelcheco@google.com> > Cr-Commit-Position: refs/heads/master@{#809354} Bug: 987422 Change-Id: I0982fe466e2c16d2b5b4a0f364808e223a668793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432306 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#815456}
-
Josh Nohle authored
This reverts commit cd0974ca. Reason for revert: Causes a crash (crbug/1136605). We will assign crbug/1136605 to melzhang@ to implement this change safely. Original change's description: > fix an instance of bugprone-unused-return-value > > This new clang-tidy check fires when the result of a function like > `unique_ptr.release()` is unused. Sometimes this is intentional, other > times, it's not (e.g., the dev intended to `.reset()`). > > Bug: 1134714 > Change-Id: Ia6a272a8b45bfc3eace44d94f244cbfcedede608 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457649 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: George Burgess <gbiv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815188} TBR=gbiv@chromium.org,dominickn@chromium.org Change-Id: I34a595e9773b1c9d28ce0fe713ca093625a5e2c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462629Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#815455}
-
Daniel Ng authored
We expect this test to call Cancel(), I've added the expectation. Tests: Run browsertests for Borealis Change-Id: Ic05b94cb73d3a859d55f90c6a47720bc12569c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454573Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#815454}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/628c64d7a14c..7c2d888fdffc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I558791cc032687fdec220c20bb3e0ce216d840d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462571Reviewed-by:
-
Adam Whiteside authored
Currently audio output streams inside MixerInputConnection have a fixed maximum buffer size of 8192 frames. This means that the overall delay changes depending on sample rate (with lower sample rates accumulating substantial delay, 512ms at 16000Hz). The current 8192 frame buffer is equivalent to 170ms of audio at 48000Hz, which is unnecessarily high. Set non-communications streams to 70ms and communications streams to 50ms. confirmed both with logging and listening test that the latency is substantially reduced. Bug: internal 168254375 Test: On device. Ran sample app at both 48000 and 16000 sample rates and Change-Id: I109df7dd10e3067f9cb4f9117c31e96cbdef581b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461218 Commit-Queue: Adam Whiteside <awhiteside@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#815452}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6740cd70. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I56d238e667cf29b7602413e1ab91dc8c1534e699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461637Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815451}
-
Chan Li authored
Bug: 1108016 Change-Id: I90beaf78f9f4b8508f6229b17b07a44943f442d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462049Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#815450}
-
James Cook authored
We've settled on "Lacros" instead of "LaCrOS". Bug: none Change-Id: Ie70ad8e81c1340466ad40f130495177aa0db9b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462297 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#815449}
-
Jimmy Gong authored
- Responsible for sending requests for displaying the notification access setup UI to the user's phone. Bug: 1106937 Test: chromeos_components_unittests Change-Id: If00b19664b4dd6240558e48b4bf5bb45c98e2723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453511 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#815448}
-
Darwin Huang authored
Refactoring change only. No functional change. Change-Id: If333b87c14cf8c9e06cd3bae544c5e71ce998678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458825 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#815447}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602179909-33e9e654a138340f2ff74cc84be2567f323eeba5.profdata to chrome-mac-master-1602201537-11aed398f2fb6b4c095a189eb8886f38c679c48f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I404f00803d14f78b77bd85afaec9e1ba3bedb46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461688Reviewed-by:
-
Clark DuVall authored
Review from Patchset 1 to get the right diffs on the changes in ChromeBackupAgentImpl. Bug: 1126301 Change-Id: I441e3dc4cf098212d6170db7f3913ef2edbc2066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461221Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815445}
-
Jing Wang authored
In some edge cases, these function may return nullptr which will crash chrome. TEST=passed unit tests and browser tests BUG=1121330 Change-Id: I4863ac4a43b5dcdae684f948abbf40d627c4ab9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462745Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815444}
-
Tarun Bansal authored
Bug: 1130607 Change-Id: If75e1cd436fc5383f5c786e95a6525f35606f627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462625 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#815443}
-
Hajime Hoshi authored
Bug: 1136687 Change-Id: Ic4b355611010a70ce4ae903c948fb67ed2a02ad9 Tbr: danakj@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462755Reviewed-by:
-
Brian Geffon authored
Because the pagemap uses the term present instead of in core we will rename those methods. Additionally, we add a little helper called IsFullyPresent. Bug: chromium:1067833 Change-Id: I98099cdd1afa5ed0bc3ded3f22592000719281a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462687Reviewed-by:
Kuo-Hsin Yang <vovoy@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Auto-Submit: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#815441}
-
Kenichi Ishibashi authored
This CL moves tests in ServiceWorkerStorageDiskTest to ServiceWorkerRegistryTest. These tests check that some fields of ServiceWorkerVersion and ServiceWorkerRegistration are appropriately set after simulating shutdown. Such tests should be moved to other place so that service_worker_storage_unittest.cc can be moved to the Storage Service. Bug: 1016064 Change-Id: I5d7deb91abc3a5d017aa2871cde152f6eabc5e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462747Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815440}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc36658f1442..557d8bce351a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hajimehoshi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1126301 Tbr: hajimehoshi@google.com Change-Id: I3986bffa31ced4c09e28179f68e16b15c92ae997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462603Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815439}
-
Thomas Guilbert authored
Currently, when using AAudio, we treat device changes like any other error, which causes video playback to fail when plugging in headphones. This CL changes this so we intercept device disconnection errors, and report them as kDeviceChange errors to the OutputController, which forces the graceful creation of a new stream. Bug: 1136559 Change-Id: I7969ad3edac2b7bbc9a3e2271f423cf7a029e7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462340 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#815438}
-
Moe Ahmadi authored
Adds Fieldtrial params to be used for fine-tuning the frecency score of local repeatable queries. These params allow fine tuning of the age threshold, recency decay, and frequency exponent of the score. The default values match those in http://shortn/_VLAOJTxx6J Bug: 1110077 Change-Id: I6d2cd1452d02c1133c7e2f6232b25168d81408da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422427 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#815437}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I2e4e8c883f4b6192ec4ec0aac048835a483c43b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462602Reviewed-by:
-
Zentaro Kavanagh authored
- Will later hold a list of routine results with the ability to update the status of the items Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Iaebb25b50b7fc35c8dbf67043e495762e3f2dec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462381 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#815435}
-
Andrey Kosyakov authored
TBR: altimin@chromium.org Bug: 1136683 Change-Id: I92fd979c419639a618a05920d1475a2afb6efd34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462570Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#815434}
-
Yoshifumi Inoue authored
This patch changes |TextOffsetMapping::InlineContents| not to use |LayoutRubyAsBlock| as container to avoid invalid DOM range. In <ruby>abc<rt>XYZ</rt></ruby>, before this patch |InlineContents| use <ruby> as container and having range start with <rt>@0 and "abc"[3] because in layout tree, <rt> comes before "abc". After this patch, we make |LayoutNGRubyRun| and |LayoutNGRubyBase| as container but |LayoutNGRubyAsBlock|. Layout tree: LayoutNGRubyAsBlock {RUBY} at (0,0) size 784x27 LayoutNGRubyRun (anonymous) at (0,7) size 22x20 LayoutNGRubyText {RT} at (0,-10) size 22x12 LayoutText {#text} at (2,0) size 18x12 text run at (2,0) width 18: "XYZ" LayoutNGRubyBase (anonymous) at (0,0) size 22x20 LayoutText {#text} at (0,0) size 22x19 text run at (0,0) width 22: "abc" Bug: 1124584 Change-Id: Id4006630a87127a6af2d1a5044a07e253457f8bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460551 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#815433}
-
Zentaro Kavanagh authored
- This is will represent a line item in the list of routine results Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I597f8f1d03e13d413978c185fa97a72611fe2072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461720 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
This CL introduces new AppType, called LACROS, and annotate it to the Lacros windows. Ran tast run ${DUTIP} lacros* Bug: 1090663 Test: Ran locally, and made sure AppType is annotated. Change-Id: I56c38ed03a655de8870fad298b962656f2b6156f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449830 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Roman Arora authored
Bug: 1128599 Change-Id: Ibbf2b73ab4da67ce5cfc6130bbef860b0ee21132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459126Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#815430}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/02a7aa75bb24..628c64d7a14c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0c306321de442c3d9b87fb6cc5c2ba96557fd41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462663Reviewed-by:
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I274a1e66cc2959f5e3655d7e0655293a1a4f6eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462349Reviewed-by:
-
John Lee authored
This CL replaces everything after the '#' if it exists in a URL to avoid chaining multiple refs such as #anchor#:~:text=selected%20text. Bug: 1136468 Change-Id: I22583af358c1169a2b97bfad12d2e75a2d8e172c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460797Reviewed-by:
-
Eric Willigers authored
As DesktopPWAsWithoutExtensions are enabled and shipped, we no longer need to mention the flag in tests. Bug: 1065748 Change-Id: I643757798cbe6ee1972a26d39e9df8f9dc7ef903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454353 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815426}
-
Maggie Chen authored
Syntax: drop-shadow(offset-x offset-y blur-radius color) The maximum pixel movement needs to include offset-x, offset-y, and blur-radius. Although blur-radius is optional, we still need to consider it. This CL adds Blur-radius to the comparison formula. Bug: 1064390 Change-Id: I3b9579335086bfda808c99cc263fdbcc8210fd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453338Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#815425}
-
