GitLab

This CL introduces bottom controls to compositor. Once the height of the
bottom controls is specified, a resize signal will be sent to cc and
renderer with a shortened view port height. Upon user scrolling, the
height of the bottom bar is computed by applying the shown ratio of the
top controls to the bottom controls. Since bottom control is less
sensitive, it will react to scrolling even if top controls is
constrained. Also please note that the shrinking and expanding of the
bottom area do not need to be pixel perfect, as such perfection cannot
be observed by human vision.

TODOs:
1. Implement main thread scrolling, like what we did for top controls.
2. Investigate to conduct standalone scrolling animation if the top
controls is totally absent.

BUG=581227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2106753004
Cr-Commit-Position: refs/heads/master@{#412738}

Reason: I can't see any particular reason why the port needs
to be gotten in the wrapper script, and this change simplifies
the wrapper script.

Review-Url: https://codereview.chromium.org/2253163002
Cr-Commit-Position: refs/heads/master@{#412737}

Since r412195, Blink uses a different path to notify that the
initial document was accessed: it no longer relies on the fact
that WindowProxy forced v8 to fallback to canAccess().

BUG=none

Review-Url: https://codereview.chromium.org/2250433005
Cr-Commit-Position: refs/heads/master@{#412736}

This CL destructs base::Thread and its underlying system thread before
WorkerThread::terminateAndWait returns. This is important to make sure that
the main thread calls WTF::shutdown() after ThreadSpecifics of all threads
are destructed. See 345240 for more details.

BUG=345240

Review-Url: https://codereview.chromium.org/2251903002
Cr-Commit-Position: refs/heads/master@{#412735}

They are RefPtr/PassRefPtr versions of std::static_pointer_cast, and
not used any longer in Blink.

This CL also removes unused SVGListPropertyHelper::toDerived(), which used
WTF::static_pointer_cast in pre-Oilpan era.

This CL has no behavior changes.

BUG=583200

Review-Url: https://codereview.chromium.org/2254073002
Cr-Commit-Position: refs/heads/master@{#412734}

During the execution of |UpdateDisplaysWith|, |active_display_list|
is being modified and temporarily contains displays that have been
removed.This causes a crash during SetBound operations for some display
change observers that use the removed displays as an active display.

- Adds unit tests that fails without the fix in this patchset.

COMPONENT=Ash, Display Manager, Panel Layout Manager, Ash unit test
BUG=632755

Review-Url: https://codereview.chromium.org/2254603002
Cr-Commit-Position: refs/heads/master@{#412733}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8b2e42bcefdd..8be763db2940

$ git log 8b2e42bce..8be763db2 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2254903003
Cr-Commit-Position: refs/heads/master@{#412732}

When a drive is right-clicked, the focus of fileManager is not set to the drive unless it has been left-clicked once before that.

test=manual test on device using a write-protected SD card and USB drive
BUG=636373

Review-Url: https://codereview.chromium.org/2253873002
Cr-Commit-Position: refs/heads/master@{#412731}

Currently, the CreateNativeWebModalManager() method declared inside the
web_modal component is defined outside of web_modal, which means linking it as a
shared component will fail. This is a layering violation.

This is now fixed for builds using Views, with constrained_window depending on
web_modal and web_modal providing definitions of all the symbols it declares.
Most unused implementations of CreateNativeWebModalManager() have been deleted,
with two remaining: create_native_web_modal_manager_cocoa.mm for Cocoa, and
test_create_native_web_modal_manager_cocoa.cc to prevent errors compiling
components_unittests, which isn't allowed to depend on the former file's
dependencies.

BUG=522654,492442

Review-Url: https://codereview.chromium.org/2087643003
Cr-Commit-Position: refs/heads/master@{#412730}

BUG=635947

Review-Url: https://codereview.chromium.org/2249743006
Cr-Commit-Position: refs/heads/master@{#412729}

The Box Alignment specification defines a new value 'normal' to be
used as default for the different layout models, which will define the
specific behavior for each case. This patch adds a new CSS value in
the parsing logic and adapts the Self Alignment properties to the new
value.

The 'auto' value is no longer valid for the 'align-items' property and
the Computed Value will be always the specified value. However, it's
still valid for justify-items and both of Self Alignment
properties. We will use the StyleAdjuster to resolve these 'auto'
values.

In order to deal with repaint and relayout whenever some alignment
property changes and resolve again the 'auto' values, current
implementation relies on triggering a Reattach whenever any of these
properties changes. This is a source of many problems for animations,
plugins, ... (See bug 580070 for details). The correct way of
implementing this is using "Inherit" instead so we can run the
StyleAdjuster again only for the nodes affected by the change.

This approach reduces considerably the number of style invalidations
and let us unskip the align-items repaint and relayout related
tests. These, as well as the justify-items related ones, had to be
rebaselined due the different invalidation areas generated.

Because of resolving everything in the StyleAdjuster, we don't need to
duplicate the resolution logic for generating the computed style. We
only have to deal with the 'auto' flag duality, which is not both
'auto' and 'normal' in any post-adjustement logic. This also gives us
the opportunity to get rid of the ShadowDOM and slotted elements
issues, since we don't have to deal with parent's style.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=565883, 474798,  448371, 582230

Review-Url: https://codereview.chromium.org/1709963002
Cr-Commit-Position: refs/heads/master@{#412728}

This is another CL for refactoring part of LayerTreeHost to LayerTree.

Refactored MutatorHostClient, and also follow Khushal's other CL, to
cache raw pointer of LayerTreeHost in LayerTree, and use unique_ptr to
wrap LayerTree in LayerTreeHost.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2216203002
Cr-Commit-Position: refs/heads/master@{#412727}

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2252963005
Cr-Commit-Position: refs/heads/master@{#412726}

https://chromium.googlesource.com/skia.git/+log/70f5251cc591..36e5adbaaac9

$ git log 70f5251cc..36e5adbaa --date=short --no-merges --format='%ad %ae %s'
2016-08-17 robertphillips Revert of Reduce window rectangles cap to 8 (patchset #1 id:1 of https://codereview.chromium.org/2254013002/ )
2016-08-17 robertphillips Revert of SkPDF:  cache metrics once. (patchset #4 id:60001 of https://codereview.chromium.org/2253993002/ )
2016-08-17 fmalita [SVGDom] Fix <ellipse> positioning

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2250283005
Cr-Commit-Position: refs/heads/master@{#412725}

Revert of Migrate WebVR Cardboard implementation to GVR (patchset #20 id:380001 of https://codereview.chromium.org/2219203002/ )

Reason for revert:
Android build failure on cronet:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20MIPS%20Builder/builds/4131

/b/build/slave/Android_Cronet_MIPS_Builder/build/src/buildtools/linux64/gn gen //out/Release --check
  -> returned 1
ERROR at //third_party/gvr-android-sdk/BUILD.gn:27:1: Empty sources for copy command.
copy("libgvr_shared_library") {
^------------------------------
You have to specify at least one file to copy in the "sources".
See //device/vr/BUILD.gn:47:7: which caused the file to be included.
      "//third_party/gvr-android-sdk:libgvr",
      ^-------------------------------------
GN gen failed: 1
step returned non-zero exit code: 1

Also suspect but have not confirmed causing these two build failures:
https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/7419
https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builder%20%28dbg%29/builds/7722

Original issue's description:
> Migrate WebVR Cardboard implementation to GVR
>
> BUG=389343
>
> Committed: https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3
> Cr-Commit-Position: refs/heads/master@{#412710}

TBR=dtrainor@chromium.org,girard@chromium.org,bshe@chromium.org,mthiesse@chromium.org,klausw@google.com,sievers@chromium.org,bajones@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=389343

Review-Url: https://codereview.chromium.org/2258513003
Cr-Commit-Position: refs/heads/master@{#412724}

Media Foundation is missing on Windows N, so attempting to use it will
crash the GPU process.

BUG=638747

Review-Url: https://codereview.chromium.org/2256933002
Cr-Commit-Position: refs/heads/master@{#412723}

The new section lists USB devices that the user has granted a website
permission to access. Tapping on a particular device brings you to the
site settings view for that site.

BUG=601627

Review-Url: https://codereview.chromium.org/2159533002
Cr-Commit-Position: refs/heads/master@{#412722}

https://chromium.googlesource.com/chromium/src/+/dfe9acda5

BUG=632274
TBR=ericrk@chromium.org

Review URL: https://codereview.chromium.org/2251293002 .

Cr-Commit-Position: refs/heads/master@{#412721}

Before this CL, incomplete responses through the Data Reduction Proxy
would be recorded as having 0 savings, even though a non-zero amount of
data was downloaded. After this CL, if the partial response had both
content-length and x-original-content-length headers, then the savings
are calculated with an effective original content length of
(partial_length * total_original_length / total_content_length).

BUG=439606

Review-Url: https://codereview.chromium.org/2242353003
Cr-Commit-Position: refs/heads/master@{#412720}

ComponentLoader::Add(int manifest_id, ...) is how most components extensions
get added. Couple of exceptions are: pdf_extension and IME. Otherwise,
ComponentLoader::Add gets the resource from ResourceBundle and then converts the
StringPiece representing the resource to std::string (copy) and feeds them to
ComponentLoader::ParseManifest().
ParseManifest construct a StringPiece from the std::string since
JSONStringValueDeserializer is capable of working with StringPiece-s.

This CL removes the intermediate conversion from StringPiece to string for
most of the cases.
This probably helps chormeos more than non-chromeos, since I saw 30 component
extension being loaded through ComponentLoader resulting in 49254 bytes
of unnecessary copy.

BUG=638775
Test=No observable change. FYI: this can affect built in chromeos extensions.

Review-Url: https://codereview.chromium.org/2252253003
Cr-Commit-Position: refs/heads/master@{#412719}

Peripheral mode is only supposed to work with auto-launched apps in a
Kiosk session. This check wasn't put in the API when this was first
implemented but we should fix this ASAP.

R=xiyuan@chromium.org,ortuno@chromium.org
BUG=638460

Review-Url: https://codereview.chromium.org/2249333002
Cr-Commit-Position: refs/heads/master@{#412718}

This CL:
* Re-combines cr-network-list items into one so that we will be able to use a single <iron-list> in a follow-up CL.
* Uses more data-binding in CrNetworkListItem for text contents, etc.
* Uses I18nBehavior instead of GetText.
* Normalizes look of cr-network-list to match Settings.
* Cleans up the CrNetworkList{Item} html to match current use patterns.
* Cleans up the CrNetworkList{Item} code.
* Adds better type checking for custom items.
* Modifies the chrome://network use of cr-network-select to not include buttons, handle events, and include custom items to better match how OOBE uses it.
* Eliminates a stale compiled_resources.gyp (compiled_resources2 is already used instead.)

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2250773002
Cr-Commit-Position: refs/heads/master@{#412717}

We started using OpenGL to render the host on the android client and the code
for the old renderer becomes obsolete. This CL removes code for the old
renderer so that we don't have burden to maintain unused code.

BUG=638305

Review-Url: https://codereview.chromium.org/2256943002
Cr-Commit-Position: refs/heads/master@{#412716}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/77756a527391..8b2e42bcefdd

$ git log 77756a527..8b2e42bce --date=short --no-merges --format='%ad %ae %s'

BUG=636690

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2253343002
Cr-Commit-Position: refs/heads/master@{#412715}

* Don't always throw up an Intent picker when a user
  asks to open a file.

* Don't even try to open deleted files.

BUG=616324

Review-Url: https://codereview.chromium.org/2256773003
Cr-Commit-Position: refs/heads/master@{#412714}

This CL makes ManifestUpgradeDetector refetch the homescreen icon. The icon
specified in the "icons" property of the Web Manifest
https://www.w3.org/TR/appmanifest/ is fetched if specified. If the icon URL
changed or the icon bitmap data has changed an upgrade request is sent to
the WebAPK server.

If the "icons" property of the Web Manifest is empty, the homescreen icon URL
that the WebAPK is currently using is refetched to check whether it has changed.
If it has changed an upgrade request is sent to the WebAPK server. For the sake
of simplicity, the ManifestUpgradeDetector does not determine the page's favicon
and fetch the favicon if the "icons" property of the Web Manifest is empty.

BUG=624834
TEST=ManifestUpgradeDetectorTest.*

Review-Url: https://codereview.chromium.org/2206493002
Cr-Commit-Position: refs/heads/master@{#412713}

https://chromium.googlesource.com/skia.git/+log/0e7bddfb340a..70f5251cc591

$ git log 0e7bddfb3..70f5251cc --date=short --no-merges --format='%ad %ae %s'
2016-08-17 senorblanco Fix assert caused by floating point error in tessellating path renderer.
2016-08-17 fmalita [SVGDom] Add support for assorted absolute units
2016-08-17 halcanary SkPDF:  cache metrics once.
2016-08-17 brianosman Add alphaType() to SkImage
2016-08-17 anmittal Fix BUILD.gn for arch other then x86 and x64
2016-08-17 bsalomon Fix computation of clipped src rect when tiling bitmaps in SkGpuDevice GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2252913004
2016-08-17 csmartdalton Reduce window rectangles cap to 8
2016-08-17 herb Eagerly update the unichar to glyphID mapping.

BUG=635005

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2251033004
Cr-Commit-Position: refs/heads/master@{#412712}

These will be shared in at least one more place (cros tray).

BUG=638702

Review-Url: https://codereview.chromium.org/2245143005
Cr-Commit-Position: refs/heads/master@{#412711}

BUG=389343

Review-Url: https://codereview.chromium.org/2219203002
Cr-Commit-Position: refs/heads/master@{#412710}

LocaleManager will manage the locale specific logic in Chrome. Currently
the only thing it does is to record some metrics in deferred startup.

BUG=630703

Review-Url: https://codereview.chromium.org/2248013004
Cr-Commit-Position: refs/heads/master@{#412709}

Currently the implementation of
CallbackHelper#waitUntilCriteria(Criteria, long, TimeUnit)
takes in a Criteria which has a failure message which is never surfaced up
when the waitUntilCriteria call times out.

This change will utilize the failure message whenever
the Criteria object contains a non null failure message.

BUG=631122

Review-Url: https://codereview.chromium.org/2178023002
Cr-Commit-Position: refs/heads/master@{#412708}

BUG=638693

Review URL: https://codereview.chromium.org/2256033002 .

Cr-Commit-Position: refs/heads/master@{#412707}

|visible_| was not initialized, leading to test flakes. Initializing
to false.

TBR=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2256903002
Cr-Commit-Position: refs/heads/master@{#412706}

BUG=616324

Review-Url: https://codereview.chromium.org/2256813004
Cr-Commit-Position: refs/heads/master@{#412705}

BUG=638724
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2256853002
Cr-Commit-Position: refs/heads/master@{#412704}

... also use range-based for loops in some nearby places.

R=cmumford@chromium.org
BUG=554289

Review-Url: https://codereview.chromium.org/2255853003
Cr-Commit-Position: refs/heads/master@{#412703}

Currently the following commands do not behave similarly to Cocoa textfields
when the selection direction changes-
-moveWordForwardAndModifySelection
-moveWordBackwardAndModifySelection
-moveToBeginningOfLineAndModifySelection
-moveToEndOfLineAndModifySelection
-moveToBeginningOfParagraphAndModifySelection
-moveToEndOfParagraphAndModifySelection
-moveToEndOfDocumentAndModifySelection
-moveToBeginningOfDocumentAndModifySelection
-moveParagraphForwardAndModifySelection
-moveParagraphBackwardAndModifySelection
-moveWordRightAndModifySelection
-moveWordLeftAndModifySelection
-moveToLeftEndOfLineAndModifySelection
-moveToRightEndOfLineAndModifySelection

This CL adds a new enum gfx::SelectionBehavior which specifies whether a
selection is to be made and how. RenderText::MoveCursor() is modified to take
this enum as a parameter. Also, two new text edit commands are added to the
ui::TextEditCommand enum-
-MOVE_PARAGRAPH_BACKWARD_AND_MODIFY_SELECTION
-MOVE_PARAGRAPH_FORWARD_AND_MODIFY_SELECTION

Textfield::IsTextEditCommandEnabled is modified to enable the following commands on
Mac-
 -MOVE_DOWN:
 -MOVE_DOWN_AND_MODIFY_SELECTION:
 -MOVE_PAGE_DOWN:
 -MOVE_PAGE_DOWN_AND_MODIFY_SELECTION:
 -MOVE_PAGE_UP:
 -MOVE_PAGE_UP_AND_MODIFY_SELECTION:
 -MOVE_UP:
 -MOVE_UP_AND_MODIFY_SELECTION:

Further, Textfield::ExecuteEditCommand is modified to set the correct
SelectionBehavior value for the different text editing commands. Also, lots of
tests are added.

This CL should have no behavior change for non-Mac platforms.

BUG=613438, 586985

Review-Url: https://codereview.chromium.org/2228833002
Cr-Commit-Position: refs/heads/master@{#412702}

https://chromium.googlesource.com/chromium/src/+/2cf52b959

BUG=482229
TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/2253353002 .

Cr-Commit-Position: refs/heads/master@{#412701}

Adds the number of prior dismissals and ignores to the permission report.

BUG=613883

Review-Url: https://codereview.chromium.org/2250893002
Cr-Commit-Position: refs/heads/master@{#412700}

This is in preparation for adding UI. Will keep the future code grouped
together.

BUG=609556

Review-Url: https://codereview.chromium.org/2258573002
Cr-Commit-Position: refs/heads/master@{#412699}