- 28 Aug, 2018 40 commits
 - 
- 
Jennifer Apacible authored
Change-Id: I854654be22abd217c3f8ed557bc3fb9118c557c6 Reviewed-on: https://chromium-review.googlesource.com/1192326Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#586820}
 - 
Brian Osman authored
These APIs (MakeICC and SkColorSpaceXform) are being deleted/replaced. The new APIs are already fuzzed directly (in skcms), and via other Chromium fuzzers. See also: https://cs.chromium.org/chromium/src/ui/gfx/color_transform_fuzzer.cc Change-Id: Iee511e354900c8208aa0c39b1989c1a51d1cd285 Reviewed-on: https://chromium-review.googlesource.com/1194488Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#586819}
 - 
erikchen authored
When ProcessMemoryMetricsEmitter is constructed with a pid, it only fetches and reports UKM metrics for a single process. The code was incorrectly still emitting UKM total memory metrics. Change-Id: I18c4e1da18f778e3cc06256051670fe0d944ddf7 Reviewed-on: https://chromium-review.googlesource.com/1183808 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#586818}
 - 
Chase Phillips authored
Part 3 in moving the IDB Mojo file from content/common/indexed_db/ to third_party/blink/public/mojom/indexeddb/indexeddb.mojom. This is the final IDB Mojo move CL in this series. Since this moves all of the remaining Mojo types to the Blink IDB Mojo file, this CL also removes the previous content/common/indexed_db/ Mojo file and its typemap infrastructure. This commit: - Move all classes and structs in content/common/indexed_db/ to Blink - Random cleanup: remove a "using" call in indexed_db_database.h This commit converts Chromium to the following Mojom types: - indexed_db.mojom.Callback -> blink.mojom.IDBCallback - indexed_db.mojom.Cursor -> blink.mojom.IDBCursor - indexed_db.mojom.Database -> blink.mojom.IDBDatabase - indexed_db.mojom.DatabaseCallback -> blink.mojom.IDBDatabaseCallback - indexed_db.mojom.DatabaseMetadata -> blink.mojom.IDBDatabaseMetadata - indexed_db.mojom.Factory -> blink.mojom.IDBFactory - indexed_db.mojom.IndexKeys -> blink.mojom.IDBIndexKeys - indexed_db.mojom.IndexMetadata -> blink.mojom.IDBIndexMetadata - indexed_db.mojom.KeyRange -> blink.mojom.IDBKeyRange - indexed_db.mojom.ObjectStoreMetadata -> blink.mojom.IDBObjectStoreMetadata - indexed_db.mojom.Observation -> blink.mojom.IDBObserveration - indexed_db.mojom.ObserverChanges -> blink.mojom.IDBObserverChanges - indexed_db.mojom.PutMode -> blink.mojom.IDBPutMode - indexed_db.mojom.ReturnValue -> blink.mojom.IDBReturnValue - indexed_db.mojom.Status -> blink.mojom.IDBStatus - indexed_db.mojom.TaskType -> blink.mojom.IDBTaskType - indexed_db.mojom.TransactionMode -> blink.mojom.IDBTransactionMode Bug: 717812 Change-Id: Ic1fcfce6efe89c043ca5f5cf06a32477d48419d6 Reviewed-on: https://chromium-review.googlesource.com/1189134 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#586817}
 - 
Reid Kleckner authored
Update clang_version from 7.0.0 to 8.0.0 and remove the code to remove the old library directory. Remove the _LIBCPP_HIDE_FROM_ABI define, it is no longer needed. Bug: 871418, 872926 Change-Id: Ic02dcfbf17c4190fc4359271d880b7e65bf7ba27 Reviewed-on: https://chromium-review.googlesource.com/1182196 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#586816}
 - 
yiyix authored
It records every time the compositor draws with a new active tree. For browser side, more than 90% of time the main-side started and finished within the same frame interval as the impl-side. This is because there is no pending tree on Browser side. Since the data it recorded is not important, remove the metrics Scheduling.Browser.MainAndImplFrameTimeDelta2 Bug: 856860 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibfbf715f644df1ed5c68c800a4ca9703622a555e Reviewed-on: https://chromium-review.googlesource.com/1189550Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#586815}
 - 
kristipark authored
The Material Design icons for Most Visited should be shown when custom backgrounds is enabled. Also moved kNTPIcons to ntp_features.h since it is no longer used in the ntp_tiles component. See go/chrome-ntp-birthday-flags Change-Id: If8e5d9cad0f09ace08aa8736df9b69b717fc4b34 Reviewed-on: https://chromium-review.googlesource.com/1191815 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#586814}
 - 
Aga Wronska authored
Change-Id: I82afbe9be844872b3eb4e0bc4193e37046f5064d Reviewed-on: https://chromium-review.googlesource.com/1194254Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#586813}
 - 
Lei Zhang authored
BUG=537099 Change-Id: I630acaa06e52222392dcfeae0c06bcc27236bbc0 Reviewed-on: https://chromium-review.googlesource.com/1188637Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#586812}
 - 
Lei Zhang authored
Change-Id: I9418402dc842cefd9df534be0df47ff47ae846aa Reviewed-on: https://chromium-review.googlesource.com/1192982Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#586811}
 - 
Joe Mason authored
This is a reland of 86ba94de, with one change: it uses the chrome_cleaner_mojo build template introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1187004 to disable the blink variants of all interfaces. Original change's description: > Add chrome_cleaner/json_parser > > This does not use services/data_decoder because it's closely tied to > the service manager, which chrome_cleaner does not support. > > R=csharp > > Bug: 830892 > Change-Id: Ia3138624c9d723916fdf1ba174c89cbcc6e71401 > Reviewed-on: https://chromium-review.googlesource.com/1180349 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Chris Sharp <csharp@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585408} TBR=tsepez TBR_REASON=Reland. Bug: 830892 Change-Id: I930c84a9d80c61e5a81a87e2ab84adcc963038d5 Reviewed-on: https://chromium-review.googlesource.com/1194292Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#586810}
 - 
Tanja Gornak authored
The Registration Manager, which is used for the invalidation should disable ids for which invalidations shouldn't be received. Bug: 870282, 801985 Change-Id: Idc7105d2924e9b1ac9d51b22add7a2b1ce6d94e9 Reviewed-on: https://chromium-review.googlesource.com/1160521 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#586809}
 - 
John Rummell authored
Desktop Chrome specifies the DecryptConfig with each DecoderBuffer, so having the pattern change is handled properly. Disabling the error check as it is only needed for Android/Chromecast. BUG=813845,877265 TEST=manual playback of faulty video Change-Id: I8815906388003dec66ef113148b33801034bb02f Reviewed-on: https://chromium-review.googlesource.com/1187713Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#586808}
 - 
kylechar authored
Remove RenderingWindowManager::DoSetParentOnChild(). This was added so that the call to SetParent() could happen on the UI thread instead of the IO thread where RegisterChild() is called. That sequence doesn't work with OOP-D as RegisterChild() isn't guaranteed to be called before DoSetParentOnChild(). RenderingWindowManager was already modified to call SetParent() on a worker thread with OOP-D. Also call SetParent() on a worker thread without OOP-D. Add a check on the worker thread that the parent/child hasn't changed since the task was posted for extra safety. Also switch out base::Singleton for base::NoDestructor. Bug: 791660 Change-Id: Id78684f63906f866577419c0975969a2e605760a Reviewed-on: https://chromium-review.googlesource.com/1176358Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#586807}
 - 
Raymond Toy authored
Currently the last three parameters to UpdateSchedulingInfo are actually return values. This is hard to remember, so change UpdateSchedulingInfo to return the three values as a tuple to make it clear what its inputs and outputs are. Bug: 878171 Test: all layout tests pass Change-Id: I43cdcc4127d3890fe6b2f1107e0f7731bdcfc2e5 Reviewed-on: https://chromium-review.googlesource.com/1192351Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#586806}
 - 
Dale Curtis authored
To allow media to eventually switch to sequences we should at least fix our most commonly used primitive to work on sequences. base::SequencedTaskRunnerHandle::Get() falls back to the threaded version if a sequence is unavailable, so this is a no-op. BUG=none TEST=everything still passes. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7c9884d94633598a55d96a2ca1a23a8decca731e Reviewed-on: https://chromium-review.googlesource.com/1192346 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#586805}
 - 
Adrienne Walker authored
Bug: 878315 Change-Id: I2ccae48290d4191efb5de6ea4ae4890a7a800fe0 Reviewed-on: https://chromium-review.googlesource.com/1194565Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#586804}
 - 
Becky Zhou authored
Bug: 876352 Change-Id: I0f9d8c16390c0f79c972a63f178616ef5a8e5083 Reviewed-on: https://chromium-review.googlesource.com/1192409Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#586803}
 - 
Travis Skare authored
Saves traffic while capacity is limited. Relevance also seems lower for those results vs text queries. Bug: 876596 Change-Id: I15cb3a19673946b888d20658d223b6097a1fe49d Reviewed-on: https://chromium-review.googlesource.com/1185496 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#586802}
 - 
Paul Miller authored
Google-internal design doc: https://docs.google.com/document/d/1X6Xoz9hl3qoAj3EhAKcvZ6hWLVcY_QpQgmUexpgDHKA/edit?usp=sharing Keep prefs that should be persisted across runs in a JsonPrefStore, and other prefs in an InMemoryPrefStore. Use SegregatedPrefStore to dispatch individual prefs to one or the other, based on a whitelist of persisted prefs. The whitelist is currently empty; prefs will be added as features require them. Also keep pref_registry in a scoped_refptr, rather than a raw pointer, for safety. BUG=866722 Change-Id: I55c819b14f130849b2066321fa4042bb0bd2b5ea Reviewed-on: https://chromium-review.googlesource.com/1189043Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#586801}
 - 
Jennifer Apacible authored
Currently, the controls on the Picture-in-Picture window are shown while the window is being resized or dragged. The scaling of the controls is not very smooth while the window is resized. The controls cannot be interacted with during the resize and dragging actions. They also slightly obscure the video, especially the play/pause icon. Removing the controls will allow the user to view the final video size and position. The controls are shown again when the user hovers over / interacts with the window. Bug: 877987 Change-Id: Ic50b2a330a811540914d9675b068cc561a652bbd Reviewed-on: https://chromium-review.googlesource.com/1191026Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#586800}
 - 
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a911eaf79bce..d941c09bc032 git log a911eaf79bce..d941c09bc032 --date=short --no-merges --format='%ad %ae %s' 2018-08-28 nisse@webrtc.org Delete unimplemented methods from the NetEq interface. 2018-08-28 phoglund@google.com Revert "Roll chromium_revision ca3a5e1c..076bef0a (585726:586605)" 2018-08-28 titovartem@webrtc.org Revert "Rename VideoQualityTestFixtureInterface::Params.pipe into config." 2018-08-28 phoglund@webrtc.org Roll chromium_revision ca3a5e1c..076bef0a (585726:586605) Created with: gclient setdep -r src/third_party/webrtc@d941c09bc032 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I007bd8043b68f75c35a2a954fda47c53f43fb0bc Reviewed-on: https://chromium-review.googlesource.com/1194266Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586799}
 - 
Matt Menke authored
Crashing the network service just after completing a network request can corrupt the cache. This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1193967, where I accidentally only disabled one of the two tests that crash the network service and expect an on-disk cache cache to work aftwards. Also do some cleanup to the earlier fix (Renable the other test when the network service is crash but there's no on disk cache, remove dead code) Bug: 878346 Change-Id: I7f483443aec4b0e60abd344676d4d197344b1b7f Reviewed-on: https://chromium-review.googlesource.com/1194466Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#586798}
 - 
Nicolas Ouellet-Payeur authored
Makes the Enterprise Reporting policies from a previous CL [1] effective. They now really control what gets reported and what doesn't, instead of just serving as placeholders. [1] https://chromium-review.googlesource.com/1187066 Bug: 877120 Change-Id: I5098e55ce337fd3e8a5a56fc98bdc08d105b6a86 Reviewed-on: https://chromium-review.googlesource.com/1190542 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#586797}
 - 
Varun Khaneja authored
Incorrectly deleted as part of http://crrev.com/c/1153969 Bug: 754341 Change-Id: I7f7fc998246a4ed1fd0b41c5168d37ff641105f9 Reviewed-on: https://chromium-review.googlesource.com/1192410Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#586796}
 - 
Zach Helfinstein authored
Adds several utility functions for accessing the accessibility tree, annotated with Switch Access predicates. Bug: None Change-Id: I48e5785c9ed7fa28a3ed396f493f0639e3fec340 Reviewed-on: https://chromium-review.googlesource.com/1188889 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#586795}
 - 
Ben Smith authored
This is no longer allowed in the WebAssembly spec, see https://webassembly.github.io/spec/web-api/index.html#serialization Bug: chromium:877286 Change-Id: I11f64cf8537eb893fc037e411f4eba80af8d946b Reviewed-on: https://chromium-review.googlesource.com/1192337Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#586794}
 - 
Allen Bauer authored
Consolidated the selected and hovered tabs into the same list. This list is then sorted based on their hover-animation state, selected state, and if the mouse is hovering the tab. This eliminated the second hovered_tabs list and hovered_tab variable. All 5 states are now managed together and painted in the following order: o Unselected with hover animating o Unselected with mouse hovered o Selected with no hover animations o Selected with hover animating o Selected with mouse hovered The unselected with no hover animations tabs are painted in the first pass and are not in this consolidated list. Bug: 876595 Change-Id: Ib77a7161485a08321f0f27e06f162263eaa891f0 Reviewed-on: https://chromium-review.googlesource.com/1188433 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#586793}
 - 
Sarah Hu authored
Bug: 875986 Change-Id: I99721c6555f6595bdc70088d0d0590523eef9f6e Reviewed-on: https://chromium-review.googlesource.com/1188967Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#586792}
 - 
Aleks Totic authored
Bug: LayoutBlock::LayoutPositionedObject had a static position check whether child reflow was necessary: if (.... || (!IsLayoutNGBlockFlow() && NeedsLayoutDueToStaticPosition(positioned_object)))) layout_scope.SetChildNeedsLayout(positioned_object); This check would skip reflow for all NGBlockFlow children. This is incorrect. If child abspos layout was initiated by Legacy, we should check static position. Fix: There was no way to tell in current code whether child abspos layout was initiated by legacy. Added a flag is_legacy_initiated_out_of_flow_layout_. Flag was added to LayoutBlock per ikilpatrick recommendation. Flag is set to true in LayoutNGBlockFlow::UpdateOutOfFlowBlockLayout Flag is set to false in NGOutOfFlowLayout. With this fix, checkboxes on code review page are correct. Bug: 863865 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ifc55ac03b76dd1aa2113181681bca1b5a2832fb2 Reviewed-on: https://chromium-review.googlesource.com/1190723 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#586791}
 - 
Eric Aleshire authored
My first CL into Autofill iOS automation - continuing off noyau@'s work by expanding the capabilities of the automation suite to match work done on other platforms. Previously, only the "click" action was implemented in iOS, and this adds the "waitFor" action, which waits until all associated Javascript assertions are true before continuing with the test script. This is meant to be a fairly 1:1 port of the equivalent actions (composed of TestRecipeReplayer::ExecuteWaitForStateAction, WaitForStateChange, and AllAssertionsPassed) here: https://chromium.googlesource.com/chromium/src/+/831f175d0cafe05c00306104bd86dfb4c00921da/chrome/browser/autofill/captured_sites_test_utils.cc#477 Next, I plan on adding the "autofill" action. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaea2e2ecd68eb29755fb4a8be6736bdaea64dcfb Reviewed-on: https://chromium-review.googlesource.com/1185920Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#586790}
 - 
Boris Sazonov authored
Previous divider implementation looked thicker than the standard ones (see the bug for screenshots). This CL fixes the issue by using listDivider theme attribute instead of explicitly specifying divider size and color. This CL also introduces a couple of textApperance styles to overcome presubmit errors. Bug: 877482 Change-Id: Iab448228ca34cd1d6fd443768fe009b14d7f9e3e Reviewed-on: https://chromium-review.googlesource.com/1191703 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#586789}
 - 
Vaclav Brozek authored
This CL runs clang-format on chrome/utility/importer/ie_importer_win.cc, to separate the behaviour-affecting changes of https://crrev.com/c/1174711 from style changes enforced by presubmit checks. This CL does not introduce any functional changes. Bug: 456119 Change-Id: I27a52f047c95a16648c550c045a2699fa1b40c61 Reviewed-on: https://chromium-review.googlesource.com/1193223 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#586788}
 - 
Saman Sami authored
This reverts commit af0b9e0e. Reason for revert: the original CL was for diagnostic purposes and is not needed anymore. Original change's description: > Check DrawQuad is given a valid pointer to SharedQuadState > > Bug: 852294 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: Iea27ee973f337f833b31a8c18e002b2772f7bacb > Reviewed-on: https://chromium-review.googlesource.com/1133579 > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Saman Sami <samans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574366} TBR=fsamuel@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 852294 Change-Id: I2001b68cc4b2a685517c5149302e6e8aacd081eb Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1194248Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#586787}
 - 
Philip Rogers authored
Page color overlays are used for extension "deemphasized" effects. These were integrated outside the blink lifecycle update but they can be moved entirely into blink now. This patch moves the page color overlay from WebViewImpl to Page and puts the update and paint calls in the blink document lifecycle. Bug: 870422 Change-Id: I92586ebeca29be24dfe35e033ca4099852d93ce4 Reviewed-on: https://chromium-review.googlesource.com/1192120Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#586786}
 - 
Yue Li authored
Bug: b/78190629 Test: Manual Test Change-Id: Ia24c946348544f3ebe4a9edc17972895fbc0df60 Reviewed-on: https://chromium-review.googlesource.com/1189709Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#586785}
 - 
Kai Ninomiya authored
A few more changes, following up to the previous commit which added the WebGPU command buffer. Bug: 868192 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iade27669c2bdebb598463b579a8dfaa6b91fbb9b Reviewed-on: https://chromium-review.googlesource.com/1192411Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#586784}
 - 
Farah Charab authored
Records the number of resource loading tasks split by net priority. Recorded each time a resource's request priority changes. Bug: 870349 Change-Id: Idef96f2e9e0a08045387b8bf78874727b2deeb91 Reviewed-on: https://chromium-review.googlesource.com/1185596Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#586783}
 - 
Nico Weber authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/a1750dbc79a8..9977619490e1 $ git log a1750dbc7..997761949 --date=short --no-merges --format='%ad %ae %s' 2018-08-28 thakis Move src.git/build/secondary/third_party/libjpeg_turbo in-tree. 2017-07-26 agable Upload libjpeg_turbo reviews to Gerrit by default Created with: roll-dep src/third_party/libjpeg_turbo Also remove now-unused build/secondary/third_party/libjpeg_turbo/BUILD.gn Bug: none Change-Id: I688b3c5f6d0250ba9f568203169d9bb504c49dd9 Reviewed-on: https://chromium-review.googlesource.com/1194482Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#586782}
 - 
Dan Harrington authored
Previously, offline content suggestions would show on any net error page. Now they only show on the dino page, as intended. As a beneficial side-effect, the error strings (available on page load) will indicate whether offline content may be inserted to the page later. This is important for implementing the final UI because, for instance, we need to hide error help suggestions to make room for content. I moved the feature flag from browser/ to chrome/common so that it is accessible from the error page code. This code was previously reviewed here: https://chromium-review.googlesource.com/c/chromium/src/+/1185282 and needed move to another issue for an OOO reviewer. Bug: 852872 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I86392d2b10d1f243525f043e0627b04f41f83b96 Reviewed-on: https://chromium-review.googlesource.com/1194245Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#586781}
 
 -