- 18 May, 2020 2 commits
-
-
Bo Majewski authored
Moves static functions and enums associated with sharing action to FileTasks. This is due to the fact that sharing with Android apps can take a path through FileTasks without touching FileManagerCommands. This CL just prepares the code for the additional UMA records, without actually adding new recoding actions. Bug: 1063169 Change-Id: Ic8833574241c0d9502b77356dbbb58c44211cf81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198849Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Bo Majewski <majewski@chromium.org> Cr-Commit-Position: refs/heads/master@{#769589}
-
Darren Shen authored
There's a race condition with the right-click emoji menu: 1. User clicks "emoji". 2. We change the input_view_url to be the emoji url. 3. We then force the keyboard to show by enabling it temporarily. 4. This will wake up the extension JS code if it's been suspended. 5. Extension JS will listen to 'onActivate' which triggers the engine to re-enable. 6. Enabling will reset the input_view_url to be the url specified in the XKB manifest and we overwrite the emoji URL set in step 2. Hence, we need to prevent step 6 from overidding. A crude way to do this to add a boolean flag to indicate whether the inputview url is currently overridden. If it's overridden, then enabling the engine should not reset the inputview url. This is not an ideal solution, but it's the simplest with lowest impact. Bug: 887612 Change-Id: I5530bb09ab9127bd0c56e86f8e08c89db84b0047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198856 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#769588}
-
- 17 May, 2020 38 commits
-
-
charleszhao authored
(1) The mojom interface is generated with the script "chromeos/services/machine_learning/public/mojom/roll_mojoms.sh" from https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2160576 (2) An implementation and fake implementation are also added for unit_tests. Tested: unit tests passed. Bug: 1054621 Change-Id: Ib74cdaf2332e7003d85601484a4d400bb06c3a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198318Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#769587}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1775de4b56cc..9e5a41a61ae5 Created with: gclient setdep -r src-internal@9e5a41a61ae5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tluk@google.com Change-Id: If2c7c4ef9b0414b2824220e0c24bc6827385cea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205863Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769586}
-
Saurabh Nijhara authored
When saving the CRX file to the cache, we have assumed(before this CL) without any check that its extension id and version are the same as we expect from the update manifest. If the time of update request on the client is close to the extension version update, we may encounter the issue of cache inconsistency: save cache entry marked with one version, while in fact it's another. This CL fixes this problem by inserting in the cache only when the crx meets the expected requirements from the manifest. This insertion logic has hence, been moved extension_downloader to the extension_updater which sets |expectations_passed_callback_| in the crx_installer. This callback is invoked when the crx passes the expectations and inserts a new entry in the cache. It also holds the responsibility to delete the crx file in case cache does not exist or insertion fails. Browser tests are also included in the CL to verify this fix. A new update manifest file has been added for testing which mentions an incorrect version for the contained crx file. Also fixed the existing tests that fail due to having incorrect extension version for their crx file. Bug: 1047637 Change-Id: I6bc291b3f5d21e536a5d8350d34d3dcc222c8f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179543Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#769585}
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: I34b70612605b04288bd374ce33c9227fe9f7c4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205981Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#769584}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a5d54d70915b..275a95c1dc64 git log a5d54d70915b..275a95c1dc64 --date=short --first-parent --format='%ad %ae %s' 2020-05-17 shuizhuyuanluo@gmail.com Fix missing headers with libstdc++ (GCC 10.1) Created with: gclient setdep -r src/third_party/dawn@275a95c1dc64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia3f4f345992f3e2334b297fddd9b512d8a8b18a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769583}
-
Peter Kotwicz authored
This CL: - Makes WebappActivity use CustomTabActivityTabController - Deletes WebappActivityModule - Registers for webapps observers which record custom tab metrics: - CustomTabNavigationEventObserver - CustomTabObserver - PageLoadMetricsObserver BUG=1082578 Change-Id: I18f2fb38460012dcc79823816667df4569391c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197527 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#769582}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1752fd9bc82b..85ae1392c509 git log 1752fd9bc82b..85ae1392c509 --date=short --first-parent --format='%ad %ae %s' 2020-05-17 bmeurer@chromium.org Update acorn to 7.2.0 Created with: gclient setdep -r src/third_party/devtools-frontend/src@85ae1392c509 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1009927 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I91dcafa3d1ac5ca9a9c4567e97eb16998335aabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205861Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a4653273a837..1775de4b56cc Created with: gclient setdep -r src-internal@1775de4b56cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tluk@google.com Change-Id: I80449412e793f82c32725acd3a48f3ae930b9724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205859Reviewed-by:
-
wutao authored
Previously we request one photo link and then download the photo to display. But on lock screen we only have limited time to use the access token, therefore, we request and handle a batch of photo link request. Bug: b/148462257 Test: new unittests Change-Id: I42a258f87e5d8b0b452a9b6b40fa981c4d2f6065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189697 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#769579}
-
Darwin Huang authored
await set_permission, which is an async function. Somehow, this was missed in https://crrev.com/c/2065346 and https://crrev.com/c/2200278, causing some of these tests to flake (1/10 times). Bug: 1083268, 1082747 Change-Id: Iedf7e63a02d200c76df0aaa431980493c6a35e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204838 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#769578}
-
Nicolás Peña Moreno authored
This CL applies fixes similar to a previous: we do not assume that the first callback to the PerformanceObserver will include the mousedown entry and instead abort and wait until a further callback which does include it. Bug: 1074048 Change-Id: Ifdf01b0abae025fa67f3ff355324d4b6204111a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204618 Auto-Submit: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#769577}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8fbdce47e36bcdae9407836deef0d16e1c82d37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205855Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/778f8bd09471..a4653273a837 Created with: gclient setdep -r src-internal@a4653273a837 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tluk@google.com Change-Id: If399be58566ac1e1b2c6f410f4415ef7c4009470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205854Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, C++ service worker payment app depended on PaymentRequestDelegate class, whose concrete implementation in ChromePaymentRequestDelegate depended on desktop-specific "Views" frameework, thus preventing usage of the C++ service worker payment app from Android. This patch replaces the PaymentRequestDelegate dependency from the C++ service worker with one boolean and one closure. After this patch, C++ service worker payment app has fewer dependencies on desktop specific code. Design doc: https://bit.ly/cross-platform-pay-app-factory Bug: 1063118 Change-Id: Ic1629d93ad09a3b1e3c6d54e0d36b5f747bcde13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196424 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#769574}
-
Noam Rosenthal authored
Limit IFD subdir recursion to one level when reading EXIF, to avoid a situation where a JPEG image can cause infinite recursion through EXIF subdirs. Use unsigned comparison instead of pointer comparison, as pointer comparison may provide invalid result on ARM platforms with large numbers. Bug: 1082634 Change-Id: I044bd4fba7e2cef6c8db6ec9a0efd2d0108a599b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202808Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#769573}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c49f3e20f7e6..778f8bd09471 Created with: gclient setdep -r src-internal@778f8bd09471 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tluk@google.com Change-Id: Ib0baa3b0c3c5923b3e50618196db68d2b5dddbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205722Reviewed-by:
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: I30ccb365db644e79210820f4eb2bb6e23846edc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205874Reviewed-by:
-
Jan Wilken Dörrie authored
This change fixes breakages in //base resulting from the switch from base::string16 to std::u16string and adds a few more utility functions to ease fixing other Chromium components. Bug: 911896 Change-Id: I93d1b027cea6ba95466418766b7623b81e763390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199151 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#769570}
-
Tommi authored
This reverts commit 2fa2af24. Reason for revert: Re-enabling webrtc perf tests Original change's description: > [Sheriff] Disable failing webrtc perf tests > > Disabling webrtc/multiple_peerconnections on linux and win10, > and disabling webrtc/pause_play_peerconnections on linux. > > Notry: true > Bug: 1081349 > Change-Id: I905824011d5c0a0c13c75ed13121021f8f5af6a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196941 > Auto-Submit: John Chen <johnchen@chromium.org> > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> > Cr-Commit-Position: refs/heads/master@{#767854} TBR=johnchen@chromium.org,wenbinzhang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1081349 Change-Id: I2d99a195f60a9a4f79b8fbc58d9c27c6189d5759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203073Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#769569}
-
Peter Kasting authored
Instead add both progress bar and separator to the container early, then toggle their visibility as necessary. Also does a bunch of other misc. code shortening and the like while I was touching these files. Bug: 1044687 Change-Id: I1d1c320b2652a0c0f3a59024f8bbff53d9326310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202526 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#769568}
-
Shengfa Lin authored
Bug: chromedriver:3482 Change-Id: I9beabe4f8c1c7786d0afcd9f9c7a1fcdbaf44dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204724Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#769567}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f27e9d854bd1..1752fd9bc82b git log f27e9d854bd1..1752fd9bc82b --date=short --first-parent --format='%ad %ae %s' 2020-05-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@1752fd9bc82b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic568a96c5a9568aef551f4fda5cb250cc5ac0a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205718Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4824014cca12..c49f3e20f7e6 Created with: gclient setdep -r src-internal@c49f3e20f7e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tluk@google.com Change-Id: I0b77c821a2b347cb4d78a2f0f4297387ac165789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205716Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5c604cd64f385339546298e6d4587dc648c69c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205717Reviewed-by:
-
Nazerke authored
This CL updates beginDismissingTabSwitcherWithCurrentModel to use Browser instead of tabModel in SceneController. Change-Id: Ie96f04c7480cb93e5f97556b26caf3719fb594f5 Bug: 1049846, 1045575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167861 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#769563}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9ff392c5e37c..ed409310e2c7 git log 9ff392c5e37c..ed409310e2c7 --date=short --first-parent --format='%ad %ae %s' 2020-05-17 ilkos@google.com Merge "Enhance the process state counters at LMK time" Created with: gclient setdep -r src/third_party/perfetto@ed409310e2c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I96127715ff091e5bfafa0a9038873fa1b059c601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205590Reviewed-by:
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: I65c93a43f095cbc99742699c6e9a64987e9a6b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205591Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c6401a349724..4824014cca12 Created with: gclient setdep -r src-internal@4824014cca12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tluk@google.com Change-Id: Iefc2c7836feee3004885b10112518cc5be00d967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205581Reviewed-by:
-
Nazerke authored
This CL removes extracting the metrics observer from TabModel in AppState, and updates shouldOpenNTPTabOnActivationOfTabModel to accept a Browser to get the values of WebStateList and BrowserState. Bug: 1045575 Change-Id: I9967b336804dedecb809c8ad8a574006bc207680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167852Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a35404ea0e2f..c6401a349724 Created with: gclient setdep -r src-internal@c6401a349724 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tluk@google.com Change-Id: Ifaf37de5cf9dc5717d11b298568fa686357f9751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205576Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/da722adec9a9..a5d54d70915b git log da722adec9a9..a5d54d70915b --date=short --first-parent --format='%ad %ae %s' 2020-05-16 yunchao.he@intel.com Add end2end tests for texture subresource 2020-05-15 enga@chromium.org Cleanup: Remove unnecessary TestSetUp overload Created with: gclient setdep -r src/third_party/dawn@a5d54d70915b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I75a5e44eb3b6f79d30ea0e23af8080ab64771bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205154Reviewed-by:
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I28090d64b0ecf6aab38aa19359a7ff1f3953a6e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205328 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#769556}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca4a9c1846a3..a35404ea0e2f Created with: gclient setdep -r src-internal@a35404ea0e2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tluk@google.com Change-Id: Ib401549684a00ccfc7a6e8c911f04f553b2711ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204095Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/44b5b6122870..f27e9d854bd1 git log 44b5b6122870..f27e9d854bd1 --date=short --first-parent --format='%ad %ae %s' 2020-05-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@f27e9d854bd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I55d89645a10b44c455a4ad9defe070c578854047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205574Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I398594866b9a36ddcb567ab0f1c0fb49423714ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205575Reviewed-by:
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: I552d8b59903168eea8b0700db4d00a254251708b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205520Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7776e78f011c..44b5b6122870 git log 7776e78f011c..44b5b6122870 --date=short --first-parent --format='%ad %ae %s' 2020-05-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@44b5b6122870 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icb373c3bb89041c96525ea2dd30b87914b1848db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205157Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I2735b701c6918642ab053fbde1d654b0724ad21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205573Reviewed-by:
-
