- 19 Apr, 2013 40 commits
-
-
simonhatch@chromium.org authored
BUG= NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14179005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195321 0039d316-1c4b-4281-b951-d872f2087c98
-
wittman@chromium.org authored
Breaks Mac ASAN compile: http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASAN%20Builder&number=19054 > Remove "Use billing for shipping" checkbox in favor of item in suggestions menu. > > BUG=225093 > > Review URL: https://codereview.chromium.org/14129005 TBR=estade@chromium.org Review URL: https://codereview.chromium.org/13877016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195320 0039d316-1c4b-4281-b951-d872f2087c98
-
simonhatch@chromium.org authored
BUG= NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14179004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195317 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=225093 Review URL: https://codereview.chromium.org/14129005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195316 0039d316-1c4b-4281-b951-d872f2087c98
-
mad@chromium.org authored
Trivial one line change, TBR'ing OWNER. TBR=pkasting@chromium.org BUG=226788 Review URL: https://chromiumcodereview.appspot.com/14192005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195315 0039d316-1c4b-4281-b951-d872f2087c98
-
dewittj@chromium.org authored
New design shows a notification bubble on a gray background when there are no unread notifications. When unread notifications exist, an image displaying the number of notifications (up to 9+) is rendered on a blue background. The new png is a sprite map of the digits. TEST=manually generate 11 notifications BUG=189129 Review URL: https://codereview.chromium.org/14192025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195314 0039d316-1c4b-4281-b951-d872f2087c98
-
haruki@chromium.org authored
BUG=233121 TEST=unittests Review URL: https://chromiumcodereview.appspot.com/14037011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195312 0039d316-1c4b-4281-b951-d872f2087c98
-
felt@chromium.org authored
Hi Michael, drovering this for you while you fix the memory leak. > Improved extension activity logging for the chrome.webRequest API. > > Add a new type of log item in the activitylog_urls table: WEBREQUEST, > used to summarize the changes made to an HTTP request using the > blocking WebRequest extension API. The types of modifications made > are always logged when the extension activity log is enabled; the > details of the modification are only kept if the activity log testing > flag is enabled (as the details may contain sensitive data). > > BUG=169628 > > Review URL: https://chromiumcodereview.appspot.com/12491012 TBR=mvrable@chromium.org Review URL: https://codereview.chromium.org/14378006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195311 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
BUG=189129 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/14267013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195310 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
But just emit something to NetLog for errors in a SETTINGS frame. Treat the receive window going negative as a valid error for SpdyStream. Remove net:: prefix from spdy_{session,stream}.*. Update some enums in histograms.xml. BUG=176592 Review URL: https://codereview.chromium.org/14348012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195309 0039d316-1c4b-4281-b951-d872f2087c98
-
jianli@chromium.org authored
Change to update panel positions after panels moved to the new collection when the unstacking happens When the unstacking happens, we should first move the panels to the new collection and then update their positions. If we're update panel positions first, the existing stack window will enclose 2 sets of panels that are not aligned which causes the background window to be seen. BUG=223155 TEST=existing tests Review URL: https://codereview.chromium.org/14175016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195307 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
TBR=sky BUG=226994 Review URL: https://chromiumcodereview.appspot.com/14367027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195306 0039d316-1c4b-4281-b951-d872f2087c98
-
petarj@mips.com authored
The test is not applicable for MIPS architecture. BUG= https://code.google.com/p/chromium/issues/detail?id=130022 TEST= Unit test Review URL: https://chromiumcodereview.appspot.com/14017018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195305 0039d316-1c4b-4281-b951-d872f2087c98
-
rtoy@google.com authored
BUG= Review URL: https://chromiumcodereview.appspot.com/13852039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195304 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195303 0039d316-1c4b-4281-b951-d872f2087c98
-
scheib@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=148721%3A148733&mode=html TBR=caseq@chromium.org Review URL: https://codereview.chromium.org/14362036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195302 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
This is the first of several steps. * Decouple Browser and BrowserView initialization * Dependency inject Browser into BrowserViewLayout * Modify BrowserWithTestWindowTest to allow it to use a BrowserView as its BrowserWindow * Add some trivial assertions BUG=233374 TEST=added unit_tests BrowserViewLayout.* Review URL: https://codereview.chromium.org/14348011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195301 0039d316-1c4b-4281-b951-d872f2087c98
-
kaanb@chromium.org authored
BUG=175012 Review URL: https://chromiumcodereview.appspot.com/14366025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195300 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
The widget's Close() will happen asynchronously and sometimes those operation can be called after the notification is removed. BUG=232895 Review URL: https://codereview.chromium.org/14320008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195299 0039d316-1c4b-4281-b951-d872f2087c98
-
hidehiko@chromium.org authored
This is not documented yet, but backslash characters should also be escaped. BUG=232352 TEST=Ran unit_tests Review URL: https://chromiumcodereview.appspot.com/14352007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195298 0039d316-1c4b-4281-b951-d872f2087c98
-
nileshagrawal@chromium.org authored
BUG=233118 R=yfriedman@chromium.org Review URL: https://chromiumcodereview.appspot.com/14328050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195297 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
BUG=NONE Review URL: https://chromiumcodereview.appspot.com/14320038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195296 0039d316-1c4b-4281-b951-d872f2087c98
-
dsinclair@chromium.org authored
Looks like the code to skip the default categories, and the unit test, were removed by accident in a merge. Restoring so the category selection dialog works correctly. BUG=195661 Review URL: https://chromiumcodereview.appspot.com/14320028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195295 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
This patch does two things: 1. It gives <webview> a tabIndex if it doesn't already have one so that it can participate in tab order and keyboard focus. 2. When <webview> gets keyboard focus then we pass the focus to BrowserPlugin. When <webview> loses keyboard focus then BrowserPlugin loses focus. BUG=231633 Test=WebViewTest.Focus Review URL: https://chromiumcodereview.appspot.com/14272003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195294 0039d316-1c4b-4281-b951-d872f2087c98
-
creis@chromium.org authored
BUG=233053 TEST=WebContentsImplBrowserTest.DidStopLoadingDetailsWithPending Review URL: https://chromiumcodereview.appspot.com/14066022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195293 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
BUG=none Review URL: https://chromiumcodereview.appspot.com/14247025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195292 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
Refactor flow control logic a bit. Also change names of related net log events slightly. BUG=176592 Review URL: https://codereview.chromium.org/13872016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195290 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
GLVirtualContext expects the share group to have a "real" context. BUG=230195 Android only change. Ran through android trybots. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14241033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195289 0039d316-1c4b-4281-b951-d872f2087c98
-
harrym@chromium.org authored
BUG= Review URL: https://chromiumcodereview.appspot.com/14232021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195288 0039d316-1c4b-4281-b951-d872f2087c98
-
grv@chromium.org authored
This CL is on top of 13885007. Review URL: https://chromiumcodereview.appspot.com/14232018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195287 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
This CL implements a blank tab-modal dialog that gets invoked when requestAutocomplete is used. TBR=jhawkins@chromium.org R=sail@chromium.org, estade@chromium.org BUG=157274 Review URL: https://chromiumcodereview.appspot.com/13470023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195286 0039d316-1c4b-4281-b951-d872f2087c98
-
sullivan@chromium.org authored
Add trace-info.json which contains information about perf traces. Also update test-info.json to use markdown for links. BUG= Review URL: https://codereview.chromium.org/14172018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195284 0039d316-1c4b-4281-b951-d872f2087c98
-
yusufo@chromium.org authored
This flag will be used by Android, iOS and CrOS. So removing the CrOS only registration and adding it to profile. BUG=227071 Review URL: https://chromiumcodereview.appspot.com/13874011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195283 0039d316-1c4b-4281-b951-d872f2087c98
-
tom.cassiotis@gmail.com authored
In the Bookmark manager the "Open..." context menu for the Recent and Search 'folder' items will apply to all the bookmarks in the bookmark list. BUG=180158 TEST=Confirm context menu for folder item, multiple selected bookmarks and empty bookmark list are enabled and the "Open..." launch the correct bookmarks. R=yosin@chromium.org Review URL: https://chromiumcodereview.appspot.com/13867005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195282 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=188567 Test=Manual, see instructions below. 1) Run Chrome with --ash-immersive-fullscreen 2) Go to http://html5-demos.appspot.com/static/fullscreen.html 3) Use F11 to toggle immersive fullscreen 4) With the top-of-window views closed, click on the "Toggle Fullscreen" button on the web page. 5) Hover at the top of the screen till the top-of-window views reveal. (Do this before the exit bubble fades out) Check that the exit fullscreen bubble animates with the top-of-window views. 6) Once the exit bubble disappears, check that it cannot be brought back by hovering at the top of the screen. 7) Exit tab fullscreen and browser fullscreen. 8) Enter tab fullscreen again by pressing the "Toggle fullscreen" button on the web page 9) Check that the exit fullscreen bubble slides in and out. (Note that when the exit bubble is initially shown it does not animate at all) 10) Go to chrome://settings > Show advanced settings... > Content settings... > Mouse cursor > Manage exceptions... 11) Remove an exception for www.html5rocks.com if there is one 12) Go to www.html5rocks.com/en/tutorials/pointerlock/intro 13) Use F11 to toggle immersive fullscreen 14) With the top-of-window views closed, click on the "Click me!" yellow box on the web page. (in the Interactive Example) section. 15) Hover at the top of the screen till the top-of-window views reveal. Check that the mouse lock bubble animates with the top-of-window views. 16) Click on the "Allow" button in the bubble. 17) Check that the mouse lock bubble fades out (as opposed to sliding out). 18) Press Escape and F11 to exit mouse lock and fullscreen 19) Click on the "Click me!" yellow box again. Check that the bubble slides out. Review URL: https://chromiumcodereview.appspot.com/13866033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195281 0039d316-1c4b-4281-b951-d872f2087c98
-
keybuk@chromium.org authored
This class will form the base of the 4.0 BR+LE compatible API, allowing for both incoming connections for profiles we're clients for and implementing services within Chrome. BUG=229636 TEST=none Review URL: https://chromiumcodereview.appspot.com/13862023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195280 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195278 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
tests for port 443. R=jar@chromium.org Review URL: https://chromiumcodereview.appspot.com/14247008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195277 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
Replace use of WebGraphicsContext3DInProcessImpl which is deprecated. R=piman BUG=224665 Review URL: https://chromiumcodereview.appspot.com/14241034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195276 0039d316-1c4b-4281-b951-d872f2087c98
-
epenner@chromium.org authored
Revert "gpu: Fix uninitialized variable." Reverting these two CLs so they can be landed behind #ifdef's (for merge safety). BUG=179250 NOTRY=true No try since this is just a revert. Review URL: https://chromiumcodereview.appspot.com/14241009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195275 0039d316-1c4b-4281-b951-d872f2087c98
-