GitLab

Bug: 667892
Change-Id: Icaaef380816473c677cf0cbf9fd24e98dafd8325
Reviewed-on: https://chromium-review.googlesource.com/558919Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484947}

Bug: 708118
Change-Id: Iffcbbd0fa78da87f6571b5ed6306a18ad3608c3d
Reviewed-on: https://chromium-review.googlesource.com/563618Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484946}

If a tab is created via Chrome's UI, hitting the back button will
eventually expand the bottom sheet before sending Chrome to the
background. Tests for the intended behaviors have been added as
well.

BUG=732833

Change-Id: I8d8308dcb7e21d1ee49fa3ab439cf7387c78f86b
Reviewed-on: https://chromium-review.googlesource.com/550929
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484945}

This issue is caused by in navigation backward (LoadInSameDocument) for Single
Page App, developer change DOM in onpopstate but not trigger a layout, then we
don't have correct content size for restore scroll position.

In this patch, we add a layout in RestoreScrollPositionAndViewState when the
size is not enough for restore scroll position. This change should only effect
SameDocumentLoad.

Bug: 721262
Change-Id: I2b2956828634884b926b4c5b3073210170f42263
Reviewed-on: https://chromium-review.googlesource.com/556979
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484944}

This will allow other Service processes to access the BPF policy without
requiring //content.

Bug: 730066
Bug: 739879
Change-Id: I7466d57ce42a038cd61c743a96d86f1684a603b8
Reviewed-on: https://chromium-review.googlesource.com/562776Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484943}

R=atwilson@chromium.org, poromov@chromium.org

Change-Id: I0827cc56ff65429706637cc77749eb4728dd5de1
Bug: 671393
Reviewed-on: https://chromium-review.googlesource.com/561277
Commit-Queue: Daria Iakovleva <yakovleva@google.com>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484942}

The new code uses functional binders and partial application to
get rid of some boilerplate code.

Due to name resolution of overloaded functions in the std::functional, 
the predicates must take the ComPtr argument by value instead of
reference to const.

TBR=waffles

Bug: 737730
Change-Id: I87d518b5e4d1b9a2fa4802ce00627cf01b887a81
Reviewed-on: https://chromium-review.googlesource.com/562909
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484941}

BUG=656015

Review-Url: https://codereview.chromium.org/2973923002
Cr-Commit-Position: refs/heads/master@{#484940}

BUG=728753

Review-Url: https://codereview.chromium.org/2973833002
Cr-Commit-Position: refs/heads/master@{#484939}

global "using namespace WTF" causes compiler warnings in jumbo builds
and in general extend the global namespace a lot which increases the
risk of symbol conflicts.

This patch changes a "using namespace WTF" to an explicit
WTF::CopePointCompareLessThan.
Review-Url: https://codereview.chromium.org/2975603002
Cr-Commit-Position: refs/heads/master@{#484938}

Some of the IDL files have outdated links that redirect to a different page.
The URLs have been updated to the newer pages. Additionally, some references
have been updated to use https instead of http

R=foolip@chromium.org

Change-Id: I73c00396825c1744d2bc29f6ebd3330cc84602ad
Reviewed-on: https://chromium-review.googlesource.com/558010
Commit-Queue: Michael Cheung <michaelcheung@google.com>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484937}

Revert of Disable flaky WebRtcMediaRecorderTest tests on TSAN (patchset #1 id:1 of https://codereview.chromium.org/2969613002/ )

Reason for revert:
The underlying problem should now be solved.

Original issue's description:
> Disable flaky WebRtcMediaRecorderTest tests on TSAN
>
> Disable the following flaky WebRtcMediaRecorderTest tests on TSAN:
>   StartAndDataAvailable
>   IllegalStopThrowsDOMError
>   IllegalStartWhileRecordingThrowsDOMError
>
> TBR=ossu
> BUG=736268
>
> Review-Url: https://codereview.chromium.org/2969613002
> Cr-Commit-Position: refs/heads/master@{#483633}
> Committed: https://chromium.googlesource.com/chromium/src/+/8e7f9967cab8bb7eba9af7f29d63c69dff2c72b5

TBR=timloh@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=736268

Review-Url: https://codereview.chromium.org/2974643002
Cr-Commit-Position: refs/heads/master@{#484936}

URLRequestSummary::request_url was unassigned for requests coming from the
memory cache. This field is used only by the origin database that never was
enabled in trunk yet.

Bug: 699080
Change-Id: I51a39d7e27be5fefcd3d477057f069bbfe9e7ce6
Reviewed-on: https://chromium-review.googlesource.com/563383Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484935}

The following tests were added recently:
PowerMonitorTest.TestGpuProcess
external/wpt/clear-site-data/navigation.https.html

BUG=729849
TBR=jam@chromium.org

Change-Id: I66bcbcce8a171ad73c2f65dc15f7649c2cd00418
Reviewed-on: https://chromium-review.googlesource.com/563696Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484934}

This reverts commit 1e35e703.

Reason for revert: The underlying problem should now be solved.

Original change's description:
> Disable flaky test WebRtcMediaRecorderTest.IllegalStartWhilePausedThrowsDOMError on TSAN
> 
> TBR=imcheng@chromium.org
> NOTRY=true
> 
> Bug: 736268
> Change-Id: I6abc58c3ad3fff9b03929e6d4cf45aff6573ce39
> Reviewed-on: https://chromium-review.googlesource.com/548915
> Reviewed-by: Xida Chen <xidachen@chromium.org>
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#482290}

TBR=imcheng@chromium.org,xidachen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 736268
Change-Id: I23910a3333d44e32167f16c797d9499d43e157cb
Reviewed-on: https://chromium-review.googlesource.com/563317Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484933}

If setAudioExperiments is called before the audio track has been
created, the value of the AEC3 experiment state should be chached and
later used when a track is created.

BUG=708475, 739379

Review-Url: https://codereview.chromium.org/2973643002
Cr-Commit-Position: refs/heads/master@{#484932}

Bug: 714018
Change-Id: I8abd34994d155c4d3173576dc6009430542d99c9
Reviewed-on: https://chromium-review.googlesource.com/562511Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484931}

https://skia.googlesource.com/skia.git/+log/6b65b98996eb..98308fb08168

$ git log 6b65b9899..98308fb08 --date=short --no-merges --format='%ad %ae %s'
2017-07-07 reed Plumb through need for unpremul/premul

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=borenet@chromium.org

Change-Id: I33ebacabff8f00811e3b0e58daba6422c14feab1
Reviewed-on: https://chromium-review.googlesource.com/563556Reviewed-by: Eric Boren <borenet@chromium.org>
Commit-Queue: Eric Boren <borenet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484930}

As of https://codereview.chromium.org/1354323003 WebappManagedActivities are not
created on L+

BUG=646608`

Review-Url: https://codereview.chromium.org/2652523002
Cr-Commit-Position: refs/heads/master@{#484929}

When using "using namespace Foo" at global level you will
introduce a lot of symbols into the global scope which will make
it harder for jumbo (unity builds/merged files) to compile without
symbol collisions.

Also, global using namespace statements will, with the current
implementation of jumbo not compile because of a compiler warning.

This patch changes to more explicit namespaces.

BUG=

Review-Url: https://codereview.chromium.org/2974653002
Cr-Commit-Position: refs/heads/master@{#484928}

ProcessMetricsMemoryDumpProvider uses a lot of ifdefs and is quite
confusing. Start pulling out the code into os_metrics.cc which will
have separate implementations for each platform.

Bug: 728199
Change-Id: I2cbc2b2e8860dce3ea1b819affb4dee2170fd5f7
Reviewed-on: https://chromium-review.googlesource.com/555497
Commit-Queue: Hector Dearman <hjd@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484927}

Bug: 618857
Change-Id: I2c17940cd681874a8f0582f2066069f47744a955
Reviewed-on: https://chromium-review.googlesource.com/550401
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484926}

Currently long lists will clip if for example 100 elements are added
to the autofill popup through datalist. This adds a ScrollView.

Bug: 375637
Change-Id: Ifa7d753369fea147db9cbcd5cc2f3562bc7557ab
Reviewed-on: https://chromium-review.googlesource.com/552324
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484925}

BUG=554289

Review-Url: https://codereview.chromium.org/2968273002
Cr-Commit-Position: refs/heads/master@{#484924}

BUG=554289

Review-Url: https://codereview.chromium.org/2974563002
Cr-Commit-Position: refs/heads/master@{#484923}

BUG=554289

Review-Url: https://codereview.chromium.org/2965273002
Cr-Commit-Position: refs/heads/master@{#484922}

The current situation is that using ScopedFeatureList resets to an
empty feature list and then enables/disables an explicit list of
features.

That's never what you want for browser tests (or other higher-level
tests) since it effectively overrides higher-level test configurations
(e.g. those in fieldtrial_testing_config.json, or a bot set up to
specifically test a feature).

In this patch:

1. Keep SFL::Init, SFL::InitWithFeatureList,
   SFL::InitFromCommandLine reset to empty list but add warning to
   remind developer should use them with care.
2. Change SFL::InitAndEnableFeature, SFL::InitAndDisableFeature and
   SFL::InitWithFeatures to not reset but override current FeatureList
   with given enables/disables.

We also add unit tests for ScopedFeatureList.

BUG=713390
Original-Review-Url: https://codereview.chromium.org/2834583002
Review-Url: https://codereview.chromium.org/2968793002
Cr-Commit-Position: refs/heads/master@{#484921}

Hooks into Android choreographer to regularly update the VSync timebase
and interval when necessary.

Bug: 733435
Change-Id: I77716e3abe89388bb56f7cac99e541dd5749290a
Reviewed-on: https://chromium-review.googlesource.com/559754Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484920}

moves Locale related static to FontGlobalContext

Bug: 730692
Change-Id: I0cf60421fbe07c13eacd1b8742920c052ccf255e
Reviewed-on: https://chromium-review.googlesource.com/544909Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484919}

Before this, upon scroll being stuck, we wait for 1 second then retry scrolling.
This wait time may not be enough on some slow machine, hence we change the logic
to wait for document.body.scrollHeight to expand which is more portable. This wait
will timeout after 30s in case the page is badly stuck.

This also reenables browse:social:twitter_infinite_scroll which is flaky on
Windows bot on Chromium waterfall (which is a VM instance).

Bug: 728464
Change-Id: I11dc94e55ba3f969406ed88a9f0b062b8f7ce942
Reviewed-on: https://chromium-review.googlesource.com/563340Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#484918}

As a follow-up to https://codereview.chromium.org/2966453002/, where we
added a logs upload permission checkbox to the modal dialog, this change
adds the same checkbox to the WebUI. The checkbox should be synchronized
with the dialog and other opened settings pages.

Also adds a "Learn More" link to Chrome Cleanup's help center article,
minor fixes for RTL languages, repositions the "Show files to be removed"
button and uses standard colors.

BUG=736465
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2971823002
Cr-Commit-Position: refs/heads/master@{#484917}

Also, EnumerateModulesModel can no longer override the conflicts URL
since it was never used.

Bug: 717696
Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I1a58c75200132eeb6f5fd81402af12955957897c
Reviewed-on: https://chromium-review.googlesource.com/559934Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484916}

We can in some cases receive resource completion callbacks for
resources associated with the previously committed document.

This change filters out callbacks for resources from a previous
RFH.


Bug: 730613
Change-Id: Ia0a677530826d94b13d56f56c53a01cbf9cade72
Reviewed-on: https://chromium-review.googlesource.com/558265Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484915}

Bug: 740036
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4673189e0825b79c4e978ba0a7f03435e3431ff4
Reviewed-on: https://chromium-review.googlesource.com/563303Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484914}

Bug:739718
Change-Id: I5c3dd5dc792cb97eee14158eabc5e1dab28ad6f7

NOPRESUBMIT=true
NOTRY=true

Change-Id: I5c3dd5dc792cb97eee14158eabc5e1dab28ad6f7
Reviewed-on: https://chromium-review.googlesource.com/562985
Commit-Queue: Jason Liu <jasonkliu@google.com>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484913}

Following bot results are included.
664 668

BUG=591099
TBR=eae@chromium.org
NOTRY=true

Change-Id: Ia433dcf298d50022db776956441b1e25048a7f1a
Reviewed-on: https://chromium-review.googlesource.com/563224Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484912}

ElementFactory is used for both SVG and HTML and some names it
exported were the same so in a jumbo build they would collide. By
making the name unique we don't have to exclude the generated files
from jumbo building.

R=fs@opera.com
BUG=

Review-Url: https://codereview.chromium.org/2965343002
Cr-Commit-Position: refs/heads/master@{#484911}

With the cl 2960843002 (see: crrev.com/2fd17068) we moved the functionality of Pending View from Items View to Bubble View.
This is a follow-up cl that moves the functionality of Update Pending View to Bubble View as well. 

Bug: 
Change-Id: I726981a1aa310eafe66e1158d124c3704ec56b38
Reviewed-on: https://chromium-review.googlesource.com/563296Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Irmak Kavasoğlu <irmakk@google.com>
Cr-Commit-Position: refs/heads/master@{#484910}

This CL replaces the IDC_STOP and IDC_RELOAD command-ids with selectors
in BrowserCommands. Call sites and ancillary usage is also updated.

This involves:

- Plumbing a dispatcher into the PageInfoController and having the 
reload button in that class target the dispatcher with the right method.

- Plumbing a dispatcher into the PopupMenuController (and subclasses), 
and the ToolsMenuViewController.

This CL also establishes the pattern for migrating tools menu items to
use the dispatcher. It is unfortunately hacky. The tools menu uses
the existing command IDs for two purposes: to tag the menu item so it
can be sent with chromeExecuteCommand, and for -commandWasSelected to
key off of to increment the right metric. Removing the first use (the
primary goal of this CL) means finding something else to use for the
second, and in this case it's a new enum defined in tools_menu_constants.h

These enum values are arbitrary *except* they are unique and need to be
distinguished from command IDs; to fit the latter criterion they are all
negative values.

This all comes together in ToolsMenuViewController:

- -collectionView:cellForItemAtIndexPath:, which already attaches
  -buttonPressed: as an action to every button in the menu, also 
  attaches the dispatcher methods for the stop and reload buttons.
- hideContent, similarly, removes those as actions.
- -buttonPressed: used to send ChromeExecuteCommand; now it only does
  so if the commandID is > 0. I realize this is terrible.

Because -buttonPressed, via two further levels of delegation(!), is 
responsible for dismissing the menu itself, the dispatcher methods must
be called *before* buttonPressed:, and so are added as actions before that
method is.

Note that because some downstream code uses IDC_RELOAD, the command ID
itself isn't removed in this CL, and the BVC switch still handles it.
That will be cleaned up in a follow-up CL.

Bug: 738881
Change-Id: Ibe2643c80b399e7a8ddee11c42c1ab7a569d7f2f
Reviewed-on: https://chromium-review.googlesource.com/561678
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484909}

The Identity Service implementation is currently making an implicit
assumption that the setting of the authenticated account happens
*before* the refresh token is made available for that account. However,
that assumption is not valid when account consistency is enabled: the
refresh token might be made available earlier, and the account made
the authenticated account only later.

This CL updates the Identity Service implementation to handle this case
by having it observe signin of the authenticated account as well as
the refresh token being made available, and checking for whether the
authenticated account is now available (i.e., authenticated with a
refresh token available) in each case.

The unittest requires that
which SigninManagerBase doesn't do by default. To enable this, we add
a method to FakeSigninManagerBase via which this observer callback can
manually be fired.

SigninManagerBase: :Observer::GoogleSigninSucceeded() be fired on signin,
Change-Id: If0fb42e868de76ec3816b5ba33e3e7c92d11fdf6
Reviewed-on: https://chromium-review.googlesource.com/561379
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484908}