Commits · e63373a237d6c59e2308f9f3d8fb7031d58eae57 · eriksson monteiro / tangled

25 Sep, 2020 40 commits

dav1d: Expand is_linux to is_linux || is_chromeos. · e63373a2

Hidehiko Abe authored Sep 25, 2020

Currently is_linux is set to true on Chrome OS build,
but it is planned to set it false. This is the preparation
to keep the current behavior for dav1d.

BUG=1131947, 1110266
TEST=Built locally.

Change-Id: I0e93a3d98f3587ea40ed704dfe87019e19b8e327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428265
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810471}

e63373a2

Change media document to no-quirks mode · 8f24aaaa

Mason Freed authored Sep 25, 2020

Better for layout.

Bug: 1131185
Change-Id: Icdbdab4906bd27afd30b0602f608939272e75aa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424980
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810470}

8f24aaaa

Roll Chrome Linux PGO Profile · e54761f9

chromium-autoroll authored Sep 25, 2020

Roll Chrome Linux PGO profile from chrome-linux-master-1600970122-55543164fcb4253994646347c53b84b49193c16a.profdata to chrome-linux-master-1600991906-4a92707280f1746bc65f64969bacfc1c677580e0.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com
Change-Id: I3ad40563709dca3ce45af444ee32613db89a01a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430237Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810469}

e54761f9

[AboutPage] Add search tag for "Copy build details" setting · b4431cbd

Daniel Classon authored Sep 25, 2020

Adds a string for "Copy build details" and loads that setting in the
About page's search concepts.

Bug: 1116553
Change-Id: Ib75e1c809fe146554a57a7a1a6dc9bf42ee6dce8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429311Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Daniel Classon <dclasson@google.com>
Cr-Commit-Position: refs/heads/master@{#810468}

b4431cbd

Roll Chrome Win64 PGO Profile · a1f5b1df

chromium-autoroll authored Sep 25, 2020

Roll Chrome Win64 PGO profile from chrome-win64-master-1600981042-72ca27b946abaa6539d1e0700f216205b0fe946d.profdata to chrome-win64-master-1600991906-91a7adfbdc345922f7abfd948645ae0f618ee88b.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com
Change-Id: I495883116dbc7d8f04f1d5918b4f4f0e04c99e81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430236Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810467}

a1f5b1df

Use the powerd-provided value for low-power adapter notifications. · 9d5a10f1

Sam McNally authored Sep 25, 2020

BUG=b:160854398

Change-Id: Ie75213a865d608835f93506c7f2b21c264880bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417670Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810466}

9d5a10f1

Get the thumbnail aspect ratio from the cached value · 6fd9af2e

Mei Liang authored Sep 25, 2020

This CL updates the two acquired thumbnail aspect ratio usages to use
the cached value. Both of the usages has been gated by
TabUiFeatureUtilities#isTabThumbnailAspectRatioNotOne which is already
using the cached valued.

Note: this CL is split from crrev.com/c/2427345

Change-Id: Ida6f5e1a4785896f4b9dd47ae81d4f2f74f92301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427149
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810465}

6fd9af2e

DevTools: deprecate success field in responses · a51a7473

Andrey Kosyakov authored Sep 25, 2020

This deprecates two of the three "boolean success" fields in the protocol.
The errors are indicated through standard protocol means, in case
the method returns a non-error result, success is always set to true.

Change-Id: Iada79f5c50d08112a996dad192e1c3cfc86fe6ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425305
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810464}

a51a7473

Fix race condition with WebSocket shutdown · adb77dad

Adam Rice authored Sep 25, 2020

There was a race condition in the network service where if a disconnect
on the writing or reading data pipes was detected before the disconnect
on the mojo interfaces it would fail to send a close frame. To fix, stop
resetting the connection when the data pipes are closed.

Re-enable the SendCloseFrameWhenTabIsClosed browser test. It should no
longer be flaky, and it's the only test we have for this behaviour.

Also modify the SendCloseFrameWhenTabIsClosed test to no longer timeout
on failure.

BUG=1123349

Change-Id: Ib4aaa46cb1f9f97e09509f59ef421228d02c941d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398036
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810463}

adb77dad

PDF Thumbnails: address comments from cl/2417790 · 16ab87b0

Bo Majewski authored Sep 25, 2020

Part 2 of 2:
Clean up mojo bound and call flow. reset() the pdf_thumbnailer_ when
the server replies with a Bitmap to make the code robust to server
errors (ignore disconnects) during post-processing of the Bitmap.

Bug: 1129607
No-try: true
Change-Id: I7dbbdecc667116c4d2a56e630b9f54162fb47279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426628
Commit-Queue: Bo Majewski <majewski@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810462}

16ab87b0

Move //ui/chromeos/search_box to //ash/search_box, part 2 · 55e88398

James Cook authored Sep 25, 2020

- Change namespace from search_box to ash.
- Rename some constants to add prefix kSearchBox
- Eliminate SEARCH_BOX_EXPORT macros. They aren't needed because
  search box is just a source_set.

Bug: 1131641
Test: compiles, ash_unittests
Change-Id: I55a4706bc57de90a823663a6f42f4554c09577b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430043
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810461}

55e88398

Roll DevTools Frontend from a3fd937cbdee to e11be3c4ad04 (15 revisions) · 79c9b550

chromium-autoroll authored Sep 25, 2020

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a3fd937cbdee..e11be3c4ad04

2020-09-24 cpinnamaneni@microsoft.com [DevTools] Shorthand properties bug fix
2020-09-24 tross@microsoft.com Add option to group issues by category
2020-09-24 sigurds@chromium.org Update DevTools protocol
2020-09-24 aerotwist@chromium.org TypeScriptify HeapSnapshot Worker supporting files
2020-09-24 sigurds@chromium.org [ts] Type-check front_end/coverage/CoverageModel.js with TypeScript
2020-09-24 jacktfranklin@chromium.org Move extractSearchRegex into StringUtilities
2020-09-24 mathias@chromium.org Remove the global spacesPadding and numberToStringWithSpacesPadding helpers
2020-09-24 wolfi@chromium.org Allow keyboard navigation on frame details view
2020-09-24 alexrudenko@chromium.org Typescriptify Distances tool in inspector overlay
2020-09-24 sigurds@chromium.org Show initiator URL in developer resources view
2020-09-24 jacktfranklin@chromium.org Migrate SearchView to TypeScript
2020-09-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-09-24 szuend@chromium.org Use object notation for MediaModel.js and enable TypeScript
2020-09-24 szuend@chromium.org [ts] Type-check media/TickingFlameChartHelpers.js with TypeScript
2020-09-24 szuend@chromium.org [ts] Remove unnecessary @ts-nocheck from media/PlayerDetailView.js

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1002914,chromium:1011811,chromium:1050549,chromium:1069378,chromium:1072331,chromium:1131801
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I0551708a1ccd38d99f52a5b7fc6e8cc0492f735b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430188Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810460}

79c9b550

Roll Skia from 7b97b3cb2bd0 to fe3d9a23095e (28 revisions) · c5683540

chromium-autoroll authored Sep 25, 2020

https://skia.googlesource.com/skia.git/+log/7b97b3cb2bd0..fe3d9a23095e

2020-09-24 fmalita@chromium.org Reland "[skottie] Reduce CompositionBuilder stack footprint"
2020-09-24 bsalomon@google.com Reland "Allow rect and circle blur fast cases to be used with rotation matrices."
2020-09-24 jlavrova@google.com ICU project: text break iterators in SkShaper
2020-09-24 fmalita@google.com Revert "[skottie] Reduce CompositionBuilder stack footprint"
2020-09-24 brianosman@google.com Add missing include to fix generated files bot
2020-09-24 mtklein@google.com q14 rethink
2020-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 9a7bc8d5 to 6a3c229f (401 revisions)
2020-09-24 fmalita@chromium.org [skottie] Reduce CompositionBuilder stack footprint
2020-09-24 csmartdalton@google.com Add "AllPathsVolatile" skpbench bots
2020-09-24 csmartdalton@google.com Begin implementing onPrePrepare for tessellation ops
2020-09-24 rmistry@google.com Add digital micrography svg to the RecreateSKPs bot
2020-09-24 johnstiles@google.com Update doc comments to match new enum structure.
2020-09-24 ethannicholas@google.com Revert "Revert "moved BinaryExpression's data into IRNode""
2020-09-24 brianosman@google.com Remove unsafe compiler methods related to external values
2020-09-24 robertphillips@google.com Revert "Allow rect and circle blur fast cases to be used with rotation matrices."
2020-09-24 adlai@google.com Revert "Reland "Take GrContext private, GrDDLContext inherit from GrRecordingContext""
2020-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6aadd31a5f98 to a09406249fa3 (1 revision)
2020-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 0b29732cd84f to 75e5ed6161fc (3 revisions)
2020-09-24 csmartdalton@google.com Make WangsFormula_* tests more tolerant of rsqrt approximation
2020-09-23 jvanverth@google.com Add AMD allocator to D3D12 backend.
2020-09-23 herb@google.com error on the side of safety for empty blobs
2020-09-23 adlai@google.com Reland "Take GrContext private, GrDDLContext inherit from GrRecordingContext"
2020-09-23 johnstiles@google.com Fix crash with invalid out parameters.
2020-09-23 csmartdalton@google.com Optimize GrWangsFormula
2020-09-23 johnstiles@google.com Add new unit tests for SkSL.
2020-09-23 bsalomon@google.com Allow rect and circle blur fast cases to be used with rotation matrices.
2020-09-23 brianosman@google.com Various cleanup related to symbol tables
2020-09-23 egdaniel@google.com Add optional param to setBackendTextureState to return previous state.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1087705
Tbr: csmartdalton@google.com
Change-Id: Ib95bf885bcc08c27023664f4534abae31c830525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429892Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810459}

c5683540

Tab Search: Disable context menu · a9f3932a

Roman Arora authored Sep 25, 2020

Bug: 1099917
Change-Id: I90dd2b7bf62d6289976c5ae53293773529f0e4a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429468Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810458}

a9f3932a

SuperSize: Fix missing metadata for Trichrome. · 29fb38f0

Andrew Grieve authored Sep 25, 2020

Reworks a lot of how arg parsing works so that there is less room for
failure (hopefully). Including:
 * Rename: --no-source-paths -> --no-output-directory
 * Make --ssargs-file top_args only.

Also allows passing --no-native via command-line and have that
work when .ssargs file is used.

Bug: 1132015
Change-Id: Ia4e46e056d9878e51d497041a231cb5dcde846fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429449
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810457}

29fb38f0

Re-enable SitePerProcessBrowserTest.RecreateMainFrameAfterCancelPending · 4421aa86

danakj authored Sep 25, 2020

The test was flaky but the underlying flakiness was fixed in
86ae1baf.

The MainThreadEventQueue now destroys its OneShotTimer on the main
thread in ClearClient() before the main thread reference to the
MainThreadEventQueue is dropped. This prevents the timer from being
destroyed along with the MainThreadEventQueue on the compositor
thread, if that is the last reference to the MainThreadEventQueue.

R=dtapuska@chromium.org

Bug: 1104826
Change-Id: I0e46906f731ea5c628cb997eb9b9e0b57f407daf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429803Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810456}

4421aa86

Roll Fuchsia SDK from 0.20200924.1.1 to 0.20200924.3.1 · 7bf467a1

chromium-autoroll authored Sep 25, 2020

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I189ed9d9e19b6d288a8da927c28d2b7734a5a019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430231Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810455}

7bf467a1

[fuchsia] Remove obsolete TODOs in blink/renderer · 0a37550a

Fabrice de Gans-Riberi authored Sep 25, 2020

Bug: 1104411

Change-Id: I0ad22ab8c852f5c66813136f4a4c07bdcc4e1234
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427186
Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810454}

0a37550a

gpu: Remove obsolete direct composition feature flags · 0e2b4943

Sunny Sachanandani authored Sep 25, 2020

Remove the NV12, decode swap chain, and underlay feature flags since
these features have shipped for quite some time. The NV12 feature flag
was also used for using YUY2 over NV12 for tests so introduce a new flag
for choosing the default SDR video overlay swap chain format. Add tests
for NV12, YUY2, and BGRA instead of just YUY2. Also cleanup some of the
testing code to be consistent in other_args, switch names, etc.

Bug: 869677
Change-Id: I0831b103506f394d6fe26bf1085401e2e2d50599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424576Reviewed-by: Maggie Chen <magchen@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810453}

0e2b4943

Use the normal compositing reasons rule for SVG transform node · 251eec12

Xianzhu Wang authored Sep 25, 2020

This avoids unnecessary transform node when there are compositing
reasons for other paint property nodes. For example, for backdrop-filter
we should create an effect node but not a transform node. In the future
will-change:opacity should not create a transform node either, when we
fix crbug.com/900241.

Change-Id: Ic9389137019381390c099688a078d65a5a6e56b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429394Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810452}

251eec12

More tests for scrollbar-gutter · 5d9f69a1

Felipe Erias authored Sep 25, 2020

Break up the scrollbar-gutter tests into separate files
for horizontal and vertical writing modes, and add
additional tests.

Move the tests to wpt_internal/css/css-overflow since
they require the non-standard feature ::-webkit-scrollbar

Bug: 710214
Change-Id: I988f2acd8cd17a6623765aedfb8938e71942a683
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417471
Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810451}

5d9f69a1

Use ScopedObserver for PluginVmHandler observing CrosUsbDetector · 9644fa56

Joel Hockey authored Sep 25, 2020

Bug: 1130361
Change-Id: Ic034197c38272e34b84849785fb5f9d29f491f0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428511
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810450}

9644fa56

[Autofill Offer] Add metrics logging for the sync flow · fb7faf41

Siyu An authored Sep 25, 2020

1. Add stored offer data count
2. Add logging for data validity

Bug: 1112095
Change-Id: I31c5ccbe555e9e0f1c314768b612c56eaecf32d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425391
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810449}

fb7faf41

Remove separator in SafetyCheck rows. · 7aca8e5d

Xinghui Lu authored Sep 25, 2020

The separator is only needed if clicking on the left and the right of
the row does different things.

SafetyCheck not run:
before: http://screen/Ak3K7GEyxFsMEb6
after: http://screen/Gm8y5irTtwbh7Be
SafetyCheck run:
before: http://screen/5XUCb2MoLjMV38R
after: http://screen/BJmxvGDGpxtKWSZ

Bug: 1128564
Change-Id: Ib9c24395180b24a58f0feee2c8a2f9674578f00e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426547Reviewed-by: Rainhard Findling <rainhard@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810448}

7aca8e5d

chrome://media-app : Do a case-insensitive comparison for matching media extensions. · 9de2b96f

Trent Apted authored Sep 25, 2020

Currently this only applies to .mkv files. Without the fix, '.MKV' in
the same folder as a photo won't be navigation options when Backlight
opens. (An .MKV will still be opened if selected by itself.)

Bug: b/169360871
Change-Id: I18cebbdadaa76466860784ab47230c75bfe0660b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428513Reviewed-by: Rachel Carpenter <carpenterr@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810447}

9de2b96f

Revert "Printer settings: Make saved/nearby printers use FocusRowBehavior" · 460861fc

Jimmy Gong authored Sep 25, 2020

This reverts commit 4f4586fd.

Reason for revert: Reverting due to flaky browsertests behaviors.
See more details: crbug/1131452

Original change's description:
> Printer settings: Make saved/nearby printers use FocusRowBehavior
>
> Description:
>  This change allows users to tab to the first printer in the saved
>  and nearby printer lists and use the arrow keys to navigate the
>  remaining printers. Users can also use the arrow keys to navigate
>  through a printer entry's associated buttons/icons. Lastly, the
>  printer entry row will be highlighted (blue background) if it is
>  being focused.
>
> Screenshots:
>  - http://shortn/_Fqf1Nn9qjF nearby printers
>  - http://shortn/_BSspETkjzV saved printers
>
> Bug: 987422
> Test: gtest_filter=OSSettingsCupsPrinterLandingPageV3Test.All
> Change-Id: I68fc5fc3ff2ceec88ce81f95da5b451a6ad3beb1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399601
> Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
> Commit-Queue: Michael Checo <michaelcheco@google.com>
> Cr-Commit-Position: refs/heads/master@{#809354}

TBR=jimmyxgong@chromium.org,michaelcheco@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 987422, 1131452
Change-Id: Id5f71a13ee85f9d58c4fa38ed9e0a7422f797160
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429289
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810446}

460861fc

Updating trunk VERSION from 4274.0 to 4275.0 · 171eecb9

chrome-release-bot authored Sep 25, 2020

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=pbommana@chromium.org

Change-Id: I766ce2f732ca991070bb87c98f8d677c80c24eb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429977Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810445}

171eecb9

[omnibox] Merge new header info with existing one rather than replacing it · 2fdcf053

Moe Ahmadi authored Sep 25, 2020

- Merges the new header info with the old one in ACResult rather than
  replacing it. The old header info may be needed by the old matches.
- Clears the header info along with matches in AutocompleteResult::Reset
- Moves the logic to strip the match group IDs that don't have an
  equivalent header string next to the logic for grouping and demoting
  matches with headers in ACResult for improved readability.  

Bug: 1122669, 1130826, 1130880
Change-Id: Ibddaa30ccd19969a71e10befa993adb688a1f572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424549Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810444}

2fdcf053

[TTS] Update Contextual Cards histogram expiry · 7676a1ad

Donn Denman authored Sep 25, 2020

Never expire one key histogram for Contextual Search that indicates how
often something useful is being shown in the Bar.

This is a key metric for usefulness of the feature.

BUG=1089460

Change-Id: Ic973ecfeb7e47d14aaeaf039aed2815ddc57ad2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425423
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810443}

7676a1ad

Stop using GetDownloadProgress() in the PDF viewer · 07cd7b0b

K. Moon authored Sep 25, 2020

Drops various GetDownloadProgress() APIs from the PDF viewer because:

1. We never call pp::URLRequestInfo::SetRecordDownloadProgress(), so
   calls to pp::URLLoader::GetDownloadProgress() always return false.
2. We only use GetDownloadProgress() in DocumentLoaderImpl, to try to
   get the total content length if we fail to get it from the
   Content-Length header. But the total content length reported by
   GetDownloadProgress() also comes from Content-Length, so this is not
   useful.
3. GetDownloadProgress() won't be useful post-Pepper, as
   blink::WebAssociatedURLLoader does not have a similar API. Instead,
   the client is expected to track this internally.

Bug: 1099022
Change-Id: I6f2f183e84b2d9e4c0dee2c116ac08bce3dc4ed0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429545Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810442}

07cd7b0b

Instrument BarcodeDetector.getSupportedFormats for identifiability study · cc19848d

Alex Turner authored Sep 25, 2020

Bug: 973801
Change-Id: I001b71e204baaaf5cfd7f8e14b8683a58d1907a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429244Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810441}

cc19848d

Updating XTBs based on .GRDs from branch master · b1005e87

Krishna Govind authored Sep 25, 2020

TBR=benmason@chromium.org

Change-Id: Id98e0e2c3f27a7077205fd991e6f79cc64a38434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429429Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810440}

b1005e87

gpu: Remove permanently disabled device trace tests · 81ce9217

Sunny Sachanandani authored Sep 25, 2020

These tests have been disabled for a long time, and don't seem to be
testing anything useful.  Remove them completely.

Bug: None
Change-Id: I86126e852498d51d28ba2ded0f42ca61c9ad1798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424725Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810439}

81ce9217

Make Launch.Modes an enum histogram, not sparse. · 085b583f

David Bienvenu authored Sep 25, 2020

In response to comment on crrev.com/c/2384332.

Per mpearson@: For enums versus sparses, the underlying UMA
data / logs will look the same.  It's only the implementation
in Chromium that would be different.

Change-Id: Ia75d78379977f36ec7873d5fb5d52998e6a366d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429975Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810438}

085b583f

Disable built-in TTS engine during Chrome OS accessibility E2E tests · 67def4fd

Dominic Mazzoni authored Sep 25, 2020

All of these tests were triggering starting the "real" TTS engine, even
though a mock TTS engine was installed.

I ran all of the ChromeVoxBackground tests before and after this change
on my system with --test-launcher-jobs=20. If the speech engine is
installed, the average test time drops 30%, from 8200 ms to 6200 ms.
Even if the speech engine is not installed, it still drops 25% from
7700 ms to 6200 ms.

Bug: none
Change-Id: Iea23951ce397176cd1fda64d801422f3031a1fba
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422585
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810437}

67def4fd

Check for removed RenderFrameHost in payment_request_factory.cc · c176476e

Liquan (Max) Gu authored Sep 25, 2020

RendererFrameHost could have been removed (e.g., because the page has
navigating away), when payment_request_factory is trying to create the
desktop PaymentRequest service. So payment_request_factory should
check RendererFrameHost.isCurrent() before the creation of the service.

Bug: 1131214f

Change-Id: Idde6077f1ce559072f7272b52b0d994d93aab805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426252Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810436}

c176476e

Add finch flag for SecurePaymentConfirmation · 12b6133d

Nick Burris authored Sep 25, 2020

This patch adds a browser-side flag that can be used to disable the
feature regardless of the Blink feature state.

Bug: 1131040
Change-Id: Ie879301e62404c6c73cf7dc39b2c12ad5908e4a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430044
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810435}

12b6133d

Check SODA paths before launching service · 8e8bb6ea

evliu authored Sep 25, 2020

This CL moves the code checking the SODA paths to before the service
is launched.

Bug: 1121384
Change-Id: I70e1caf6086dce94a25c425a2959381293545bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429745Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#810434}

8e8bb6ea

Fix obvious copy and paste fail. · d9d6db5a

Peter Kasting authored Sep 25, 2020

Bug: 1131842
Change-Id: I0612adf1075e417bcb43cd24b69b19b96be6b7c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429785
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810433}

d9d6db5a

[OsSettingsLanguages] Ensure only one translate-target label show up · e3b36a4f

My Nguyen authored Sep 25, 2020

This wasn't carried over when I added the translate-target because
I don't really understand its intention. Update test and comment.

Before: http://screen/3Uh7wzmoFjZVHTN
After: http://screen/BVcaJp66E8CpSvs

Bug: 1113439
Change-Id: I10fc16aa8287a0901ffc41599eba5cda42a0c926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428510
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810432}

e3b36a4f