- 21 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fd17a12ec7ac..d69ae20edf94 git log fd17a12ec7ac..d69ae20edf94 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 perezju@chromium.org [soundwave] Add timeseries2 API Created with: gclient setdep -r src/third_party/catapult@d69ae20edf94 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900218 TBR=sullivan@chromium.org Change-Id: I15708dc6e61810aa55530c6e1713f11350b2f545 Reviewed-on: https://chromium-review.googlesource.com/c/1347071Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610151}
-
Alexandr Ilin authored
This CL updates the expiry from M72 to M73 for the following histograms: - CustomTabs.ResourcePrefetch.Duration.Failure - CustomTabs.ResourcePrefetch.Duration.Success - CustomTabs.ResourcePrefetch.FinalStatus The experiment these histograms were added for isn't complete yet. Bug: 899952 Change-Id: I9963e520c8ed966525b9e172a2acbe0e568da673 Reviewed-on: https://chromium-review.googlesource.com/c/1343006Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610150}
-
Guido Urdaneta authored
Since screen capture does not have a clear concept of native resolution, rescaling will be enabled by default and will be disabled only if explicitly requested. This maintains existing behavior in all existing applications that use content capture. This CL concludes the resizeMode series. Bug: 854980 Change-Id: I8658e36f22501f18d1d9dc9b6b0fe6e24063140b Reviewed-on: https://chromium-review.googlesource.com/c/1310716 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610149}
-
Ella Ge authored
This change is under a blink flag MovementXYInBlink. With the flag on, MouseEvent and PointerEvent's movement_x/y is calculated in blink instead of in browser. The movement_x/y for pointerrawmove event is not set yet. And also this CL does not handle the calculation when pointer is locked. These is going to be done in the following changes. See the design doc: https://docs.google.com/document/d/1jL93PMbNHLhr6jYd4AWkjB8wgS73C5EDUa_2kYOjOn4/ With the flag, movement_x/y is in dip (same scale with screenX/Y), which is different the current behavior(physical pixel). The coordinate space is discuss in this doc: https://docs.google.com/document/d/1mYk4qMxBVsFweqFOku2FZvMajejp2Q7XWGIld9ivlXE/ It needs to be changed or clarified before we enable the flag. Bug: 802067 Change-Id: I5abb71181702c3b5265985f6ff8d2537116c5e18 Reviewed-on: https://chromium-review.googlesource.com/c/1297744Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#610148}
-
Fredrik Söderquist authored
Three 'w' should be enough for everyone... Bug: 907470 Change-Id: I7a724e708b73e4d5a80bcd28a2a459912e5ae69b Reviewed-on: https://chromium-review.googlesource.com/c/1346399Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#610147}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ae57ced21615..1b079a6aacab git log ae57ced21615..1b079a6aacab --date=short --no-merges --format='%ad %ae %s' 2018-11-21 chrome-bot@chromium.org Update config settings by config-updater. 2018-11-21 achuith@chromium.org cros_vm: Move Device/VM to lib/vm.py Created with: gclient setdep -r src/third_party/chromite@1b079a6aacab The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic1f1a64ef8cc7d34fb271e9ebfe667f6bd2e475d Reviewed-on: https://chromium-review.googlesource.com/c/1346793Reviewed-by:
-
Darwin Huang authored
Change-Id: I0e650bc3a98e7778278ef0e4f474c435c6d36611 Reviewed-on: https://chromium-review.googlesource.com/c/1328229 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#610145}
-
Collin Baker authored
Fixes promo display on Windows, where promo bubble is activated then immediately deactivated when opening a new tab. Change-Id: Icc764660b5a4840edf7e345fdd460126cc1c1600 Reviewed-on: https://chromium-review.googlesource.com/c/1344869Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#610144}
-
Andreas Butler authored
Implemented the proper throwing behaviour for handling the case of an opaque origin for IDBFactory.databases(). Also included is a WPT for verifying the behaviour written by jsbell@. Spec PR: https://github.com/w3c/IndexedDB/pull/250 Change-Id: I506f82bf69b27d34b499eacbe12aaa18a69b63be Reviewed-on: https://chromium-review.googlesource.com/c/1344629 Commit-Queue: Andreas Butler <andreasbutler@google.com> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#610143}
-
Matt Menke authored
Also move all PrivacyMode logic up to URLRequestJob layer and rename CanEnablePrivacyMode to ForcePrivacyMode, to mode accurately reflect what it does. TBR=droger@chromium.org Bug: 906864 Change-Id: I6527cc34579e474292491886a2fb54ba2003561e Reviewed-on: https://chromium-review.googlesource.com/c/1343051Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#610142}
-
Bruce Dawson authored
Until recently Chrome required the 10.0.17134 SDK to build because it needed declarations from that SDK and there was no more recent SDK. Now there is a more recent (10.0.17763) SDK which can also build Chrome and the 10.0.17134 requirement is annoying. Removing the requirement for a specific version means that some new Chromium developer might try building with an *older* version, but that is unlikely, and they will hit errors and will then just need to install the latest. That is better than forcing developers to install an old SDK version. Bug: 907300 Change-Id: Iad5a5bb1cdab944926df030cb1adb46ae0d55b56 Reviewed-on: https://chromium-review.googlesource.com/c/1345652Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#610141}
-
Kevin McNee authored
Add crash keys to identify why the forbidden access is happening and which WebView extension function(s) are involved in the kill. Bug: 780728 Change-Id: I7b68103696ef3c5c46a5e00299aceef422e136bd Reviewed-on: https://chromium-review.googlesource.com/c/1344874Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610140}
-
Yi Su authored
google_services_settings_egtest. google_services_settings_egtest.testActivityAndInteractionsDisabledWithHistoryDisabled is disabled on both simulators and devices. Update the message in macro EARL_GREY_TEST_DISABLED. Change-Id: I8c25d3031067f2c571f0c3ceb56a9742f5f55ddf Reviewed-on: https://chromium-review.googlesource.com/c/1345438Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610139}
-
Allen Bauer authored
Change-Id: Ibf1c13b9cd48393bafe12c4c38d7fc7dba976699 Reviewed-on: https://chromium-review.googlesource.com/c/1342764 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#610138}
-
edchin authored
The private method |-(CGFloat)headerHeightForTab:(Tab*)tab| was not using the |tab| argument in calculations. Therefore, the argument was unnecessary. Furthermore, there already exists a property called |headerHeight|, which called this private method. This CL simplifies and removes unnecessary references to Tab. Change-Id: Ib56aef51929d59e672197d2c9d58cf62061209f0 Reviewed-on: https://chromium-review.googlesource.com/c/1344834Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610137}
-
Nate Chapin authored
1. When selecting a thread for a task, consider which thread all prerequisites were assigned, not just the ones still pending. 2. Store the v8::Value for completed tasks. 3. If a task will run on the same thread as a completed prerequisite, hop to the worker thread and pass the prerequisite's result directly without a deserialization. (2) enables this, and (1) increases the frequency in which this optimization can be used. 4. Given that it is no longer guaranteed that the serialized result will be needed (i.e., if all dependents run on the same thread and task.result is never requested on the main thread, only the v8::Value will be used), move to a lazy serialization model, where the result is only serialized when it is promised via task.result or when a dependent is assigned to a different thread. Bug: 879306 Change-Id: I22fe5f201f22b376861a5fb6d6e881ce0d5785cc Reviewed-on: https://chromium-review.googlesource.com/c/1311498 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#610136}
-
Peter Kasting authored
This also tries to get closer/improve debuggability for RenderTextTest.MoveLeftRightByWordInBidiText, which remains disabled. Bug: 196326, 906308 Change-Id: I1e9c1217d5ef2e05aa49315de5138c5ad8de0f99 Reviewed-on: https://chromium-review.googlesource.com/c/1343564 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#610135}
-
jdoerrie authored
This change modifies HttpPasswordStoreMigrator to not replace the signon_realm if the previous signon_realm did not have a HTTP scheme. While rare, this scenario can happen for federated credentials that have been saved on a secure HTTP origin, such as http://localhost. Bug: 687968 Change-Id: Ib777aac0aadd1ca39723de40b40fd75193954f7e Reviewed-on: https://chromium-review.googlesource.com/c/1346458 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#610134}
-
Ryan Meier authored
Change-Id: I6d2fcdf455cb65faa67450754b8fea4084783afb Reviewed-on: https://chromium-review.googlesource.com/c/1340957 Commit-Queue: Ryan Meier <rameier@chromium.org> Reviewed-by:
-
Ryan Meier authored
Change-Id: Idc5ad051bdbe1699ddcf018e33f9f09e8de54f48 Reviewed-on: https://chromium-review.googlesource.com/c/1345413 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
This overlay also blocks users from interacting with the website until the onboarding screen is closed. Before: https://screenshot.googleplex.com/Xx1bJCk0YBp.png After: https://screenshot.googleplex.com/zBX6vYLym2c.png Bug: 806868 Change-Id: Id4cbb9c19ef561c5e61d70891830541e4dcfadbb Reviewed-on: https://chromium-review.googlesource.com/c/1346302 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610131}
-
Benjamin Wright authored
CryptoOptions recently was promoted to the api directory and the semantics were changed such that it should be set per PeerConnection. This aligns with its extended scope as a general place for all crypto related options in WebRTC. This change removes setting these options on the Factory itself which is deprecated in favor of explicitly setting them per PeerConnection. This will eventually be expanded to other options such as disable encryption which are still in the process of being merged into webrtc::CryptoOptions. Bug: webrtc:10020 Change-Id: I8ea7198ca12ecf5a663bc87dbe3d122f3feebf71 Reviewed-on: https://chromium-review.googlesource.com/c/1344827Reviewed-by:
Steve Anton <steveanton@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Ben Wright <benwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#610130}
-
Victor Vasiliev authored
This platformizes absl::CHexEscape, absl::Hex, ABSL_FALLTHROUGH_INTENDED and UNREACHED(), EstimateMemoryUsage. All uses are fixed, as well as some of the other minor changes. Merge internal change: 222281858 R=bnc@chromium.org Change-Id: I905726a43e8a97b8258fb5c689871a5df511815e Reviewed-on: https://chromium-review.googlesource.com/c/1344951 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610129}
-
Alex Newcomer authored
Do not SEND_GESTURE_EVENTS_TO_OWNER unless the icon is in a drag. Example: We used to send this runtype for all gesture events. This does not work as expected for two finger taps. Bug: 906692 Change-Id: Ie1c5f16f2d0552df6147b9abf3b495c63b69ce93 Reviewed-on: https://chromium-review.googlesource.com/c/1346953Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#610128}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bbe98fbac5e1..a285cdeb4d1a Created with: gclient setdep -r src-internal@a285cdeb4d1a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I53b58d75faaef00c737a8fe22670379a9fef9474 Reviewed-on: https://chromium-review.googlesource.com/c/1346790Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610127}
-
Scott Violet authored
This patch makes showing/hiding the WindowTreeHost's window behave the same as if Widget Show/Hide was called. This is necessary for transient windows to work. In particular it's expected that hiding the transient parent hides transient children. TransientWindowManager does that by way of calling show/hide directly on the aura window. I could have added the ability to inject function to accomplish that, but I know I've run into other code expecting show/hide on the aura window to map to showing/hiding the widget. BUG=883371 TEST=covered by tests Change-Id: I6ee9009732ba1b5f47e888a1a841f462a1f5a851 Reviewed-on: https://chromium-review.googlesource.com/c/1340964 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Ryan Tseng authored
Bug: 889221 Change-Id: Ie26aca388f600ee6a0983ee378c9b5b70e5efba6 Reviewed-on: https://chromium-review.googlesource.com/c/1342400Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#610125}
-
Roger Tawa authored
with no internet. Bug: 906767 Change-Id: Ib98660b4a27f6d0f5f1d5b5706813307b06bc80b Reviewed-on: https://chromium-review.googlesource.com/c/1343286 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610124}
-
Robert Kroeger authored
WebglConformance_conformance_textures_video_tex_2d_rgba_rgba_unsigned_short_5_5_5_1 is flaky on Android Android Release (Nexus 5X). Add a suppression. BUG=907512 TBR=kbr@chromium.org Change-Id: I13c43db1d7f9ee216e250e861d16c1a4879dbe5e Reviewed-on: https://chromium-review.googlesource.com/c/1346870Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#610123}
-
Hao Zhang authored
Bug: 899057 Change-Id: Id1a0c15bfb3dbe8c0f1f967b25ce6dd7f2bd240e Reviewed-on: https://chromium-review.googlesource.com/c/1334928 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#610122}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6aab06e0e5d4..9f379f493cd7 git log 6aab06e0e5d4..9f379f493cd7 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 courtneygo@google.com Revert "Fix AndroidManifest package name" Created with: gclient setdep -r src/third_party/angle@9f379f493cd7 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ie64341555da3e24a466fec4f9fbeab6227c10e47 Reviewed-on: https://chromium-review.googlesource.com/c/1347070Reviewed-by:
-
jdoerrie authored
This change fixes a DCHECK in GetSignonRealmWithProtocolExcluded triggered when operating on credentials where the form's origin contained a port, but the signon_realm did not. For example. this can happen for federated credentials. Furthermore, this change improves the robustness of InvalidRealmCredentialCleaner and HttpCredentialCleaner by performing the HTTP / HTTPS check on the form's signon_realm instead of the origin. Bug: 871140 Change-Id: If4c531e0c8741db05f5e1b7565c5fd6026836ae6 Reviewed-on: https://chromium-review.googlesource.com/c/1345512 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#610120}
-
Saman Sami authored
WebglConformance_conformance_uniforms_uniform_default_values is flaking on Win10 FYI Release (NVIDIA). TBR=kbr@chromium.org Bug: 907544 Change-Id: Ib41ff367449b0fd3c424d95fdf39f4fdcf7e4633 Reviewed-on: https://chromium-review.googlesource.com/c/1346673Reviewed-by:
-
Ben Pastene authored
The luci version is currently broken. Will switch it back when bug 790372 is fixed. Bug: 907542, 790372 Change-Id: Ic51139317f7a330ee9bd719b97cfb111154b7da2 Reviewed-on: https://chromium-review.googlesource.com/c/1347056Reviewed-by:
-
Morten Stenshorne authored
The extrinsic constraint space was used to calculate the intrinsic min/max sizes of orthogonal roots. However, now that our orthogonal flow fallback available inline size calculation is good enough, we no longer need the concept of "extrinsic constraint space". Instead create one with infinite sizes, but with correct fallback inline size. One change is required, though: We need to honor fixed block-size (and not just block-max-size and block-min-size) when calculating the fallback size. During layout, that size is already taken care of and put in the constraint space, but during intrinsic sizing, that isn't the case. Create the infinite constraint space in ComputeMinAndMaxContentContribution(), rather than at all call sites. Make the NGConstraintSpace parameter non-optional, and make it clear that it's the parent constraint space we take as input; previously it was sometimes the child's and sometimes the parent's. Change-Id: I7c884e383266c67bfa9438e98ad1312b39ea9372 Reviewed-on: https://chromium-review.googlesource.com/c/1341513 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610117}
-
Jonathan Backer authored
With the transition to SharedImage, many of the RasterInterface methods are not longer used. This will make it easier to support RasterDecoder with passthrough textures. Change-Id: Ie62c4ecfa978a85a6f74a996c0e75ce9dcc38315 Reviewed-on: https://chromium-review.googlesource.com/c/1327607 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610116}
-
Peter Kasting authored
The tests currently assume that the normal and CJK fonts have different metrics. On Android, this is not true for all platforms we support. The tests still have some value when run with fonts with identical metrics, so modify the test expectations slightly to work in that case and enable these tests. Bug: 865540 Change-Id: I6cd98a254f9ae0e6c6a9818e37c9ae69ca954f13 Reviewed-on: https://chromium-review.googlesource.com/c/1343531 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610115}
-
Stephane Zermatten authored
With this patch, scripts can use a 'prompt' action to ask questions instead of ending the script. The UI of 'prompt' looks just like the UI that appears between scripts, so the choice between a prompt and multiple scripts should be a scripter implementation decision. The prompt action, can: - allow a subset of the page to be touchable, as controlled by the focus action, like what happens between scripts - propose suggestions to be displayed in chips, to simulate script execution - react to element existence, to simulate preconditions Limitation: Prompt does not allow navigation outside of the current page, nor page reloads. Bug: 1340309 Change-Id: I033399621e5afa0d02021cac6cab6765c913970c Reviewed-on: https://chromium-review.googlesource.com/c/1343266 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#610114}
-
Alex Newcomer authored
During long press, we request menu options twice. Avoid making this expensive call twice. Before, we returned early on the callback. Keep that incase race conditions, but also return early before the request if a menu already exists. Bug: 907556 Change-Id: Ie7798e25faea5128651f4a06415d978a5a6cbe35 Reviewed-on: https://chromium-review.googlesource.com/c/1347090Reviewed-by:
-
Nico Weber authored
luci-milo.cfg linter: Lint bot category, and check that each toplevel category on the main waterfall has a subwaterfall. Also tweak a few categories to make main and subwaterfalls match. Bug: none Change-Id: I15ac12e6854be01af39da8869b87102ec17f305a Reviewed-on: https://chromium-review.googlesource.com/c/1346731Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610112}
-
