GitLab

This change avoids automatically opening the tutorial in OOBE if the
device is in tablet mode. We want to avoid showing the tutorial in this
case because none of the content is relevant to ChromeVox touch.

To implement this behavior, this change adds an accessibility private
API to fetch the tablet mode enabled state of the device, which is
used when deciding whether to show the tutorial or not.

Once we create a tutorial for ChromeVox touch, we can remove this
behavior and choose which tutorial to show depending on the user's
device tablet mode.

and tablet mode. Verify that tutorial only opens in laptop mode.

Test: Manually test change on Eve. Start ChromeVox in OOBE in laptop
Fixed: 1132081
AX-Relnotes: N/A
Change-Id: I30d237ba0d30f41fcda3420fe8832c70fdfb886d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472598
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818112}

First step in componentizing site engagement so that it can be used
for e.g. lookalike checks on iOS.

Bug: 775390
Change-Id: I23c267011907da94a95292f4e3fbc43feb98c036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473139
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818111}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b0723ad5..2851aa91

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4a9c856056f4a30c071a35f6d77ab22730cf03f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480664Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818110}

Transfering ImageBitmap should decrement memory usage on the original
V8 isolate, and closing should decrement memory usage, otherwise
unnecessary GCs are triggered.

Change-Id: Iff36735ad67136650869da90a4bb07ca0632d4dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700636Reviewed-by: Yi Xu <yiyix@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818109}

FillOSMemoryDump already does the work of populating a memory dump.
This data is now being reported correctly instead of being unused.

Bug: 1102040
Change-Id: I85ca28bd7543576f1c43773721832485eeb7a480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472463
Commit-Queue: Rohan Pavone <rohpavone@google.com>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818108}

Also do some unrelated minor cleanups along the way.

Bug: 1012811
Change-Id: Ie0f621f13e9bc32ec56b474c8f054edd9482fcc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478682Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818107}

This CL adds special rendering for screenshots in the drag image for
Holding Space UI.

Note that we will only use this rendering if there are *only* screenshot
type items being dragged. Per the spec, if any non-screenshot items are
being dragged we will render them all as chips.

Demo: http://shortn/_3ngh0ZDucQ
Note that the screen recorder did not capture the cursor moving with
the drag image but it actually does so on device.

Bug: 1139113
Change-Id: I5f2f0012ee1fda3f1f3b51c51275889959e08e1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481005
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818106}

As part of crbug.com/1132206, I'm merging the CrOS VM pool to the main
chromium.tests pool. A couple of suites have already moved over, and the
isolate-input overhead looks pretty similar to those that haven't
switched after I bumped max cache size in crrev.com/i/3338983

So this continues with the merging by moving over webgl_conformance
tests. This suite takes up about 20% of the current run time in the
current VM pool. So I'll move 20% of the VM pool's bots to the main pool
in crrev.com/i/3344206 prior to landing this.

Bug: 1132206
Change-Id: I05ae7b309853102eb0a9dccb5017349d85b74169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481291Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818105}

Bug: 1138684
Change-Id: Ie4a64447dc71a9809d5e431e2842c45c1accc0fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476729Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818104}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71478928d7c2..68ab63fe46c8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC rbpotter@google.com,juanmihd@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: rbpotter@google.com,juanmihd@google.com
Change-Id: I2412c5f5d907d0ac38761ac8514ff9bd5e53e469
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481090Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818103}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I3deaa9551b9927515ace9da8895a29208cc15035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481418Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818102}

This CL extends expiry for a histogram that will still be useful for
experimentation in a few following milestones.

Bug: 1117116
Change-Id: I4722a1452a92ceb99669b83735b542b0225f8b8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478602
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818101}

min-height: auto had been using the image's natural height as the
content size suggestion, ignoring a specified definite inline size, but
according to this spec chain, the specified definite inline size should
transfer through the aspect ratio and affect the min-content size.

https://drafts.csswg.org/css-sizing-3/#min-content ->
https://drafts.csswg.org/css-sizing-3/#intrinsic-sizes ->
https://www.w3.org/TR/CSS2/visudet.html#float-replaced-width ->
https://www.w3.org/TR/CSS2/visudet.html#inline-replaced-width ->

"""
if 'width' has a computed value of 'auto', 'height' has some other
computed value, and the element does have an intrinsic ratio; then the
used value of 'width' is:

(used height) * (intrinsic ratio)
"""

This fix also made clear that the regression caused by
https://chromium-review.googlesource.com/c/chromium/src/+/2333530 was
not so harmless -- the issue wasn't a wrong test in align-items-007, but
rather an incorrect block size given to a replaced element with aspect
ratio but no size in the content size suggestion. We had been giving
such element a 150px intrinsic block size; the correct size is the
available inline size passed through the aspect ratio. This is now fixed
in this patch.

The changed case at the end of flex-aspect-ratio-img-column-011.html was
asserting the opposite behavior of
flex-minimum-height-flex-items-007.xht

(Gerrit or something keeps adding a bogus "fixed" line under Change-Id,
in case this CL shows up someplace random)

Change-Id: I05cb4b3ca796b3df02dfa5d8e3790d6164213be9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462574
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818100}

Bug: 1109792
Change-Id: I92b09982b2ce2c6be9b9e81d28965cdd2e329a8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472417
Commit-Queue: Eric Orth <ericorth@chromium.org>
Auto-Submit: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818099}

TBR: michaelbai@chromium.org
Bug: 1133535
Change-Id: I3bb2ac2dbbd3e9349afca8603de90521ddf0f5ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481009Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818098}

Extend the expiration date and update the ownership for the following
histograms:
* ManagedUsers.SafeSitesDelay*
* Supervision.ParentAccessCode*

Bug: 1138331, 1138414
Change-Id: Icdec80809c3195a20ed64c7ca1076d22ff8012c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471218Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818097}

This CL is adding a Shutdown method to the TTS Platform.
Since the TTS Platform is a leaky object, it remains live
until the end of process.

On Windows, the implementation is using COM objects. During
the shutdown, COM is uninitialized. We observed crashes/hangs
during shutdown related to these objects being alive.

R=fdoray@chromium.org

Bug: 1136220
Change-Id: Ib6e43970e479077ec02f684cd56858d9f6028cdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468466Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Randy Rossi <rmrossi@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818096}

The current estimate of net_perftests is inaccurate. After synced with benchmark owners, we decided to remove it from waterfall.

Bug: chromium:1130157
Change-Id: I4751ebd7569dc19c6ae94937b77e78661448c52b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473166
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818095}

The move assignment operator was not properly cleaning up the current
state before taking the values from the other instance.

This CL fixes the bug and adds a test to ensures it works.

Bug: 1139433
Change-Id: I100bf33600f7441ef798a9e9d66e092ffdc1e058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481444
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818094}

https://chromium.googlesource.com/angle/angle.git/+log/119d867c232d..09ac7d906427

2020-10-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 20073b86 to 7e36b15b (145 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: ynovikov@google.com
Change-Id: I314bae62ae31aa51175e4f028cf33f45700ca125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480933Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818093}

This is a reland of 1bcf9a08

Original change's description:
> Fix render issue with render pass overlays on macOS
>
> The problem is because damage of a frame may not contain the whole
> render pass area, and then the overlay backing will not be drawn
> completely. Fix the problem by ignoring the frame damage area.
> This CL also fixes some sync token issues.
>
> Bug: 1135727
> Change-Id: I6354b235fb9a7ffdeffe9c9270576ee648a7ba4d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464914
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#816651}

Bug: 1135727
Change-Id: I0b2aa8668dd73120828587bd013f12b0e4348ddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481342
Commit-Queue: Peng Huang <penghuang@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818092}

With this CL, we can update the bottom padding of grid tab switcher
by changing the value of tab_grid_bottom_padding in dimens.xml.

Bug: 997250
Change-Id: I2f31e3492950c7a38677f298d9ce1d0e4c6ea904
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452552Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com>
Cr-Commit-Position: refs/heads/master@{#818091}

This CL makes unbound webapk hide disclosure when when navigating out of
the verified origin, same as TWA behaviour.

Bug: 1128675
Change-Id: Ic8c359a693d1661f57c46537f6f56647248959f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473040
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818090}

It's not used after a recent change and now browser_tests
compilation with "-Werror,-Wunused-function" flags fails.

Test: Run trybots.
Change-Id: I843fa36c0b6d0474098f2cc067d3a8d4ea98d628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480763
Auto-Submit: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818089}

Add a new behavior, SelectBehavior, for shared functions of custom
elements that implement scan settings using select elements.

Bug: 1059779
Change-Id: Ieba696d8844c994fb4a944d0dc91edbd85ac04c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480809Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818088}

This flag temporarily disables this feature for stability reasons
and it will be merged to M87.

More details:

Every platform, including Windows (IA2 and UIA), Mac and Linux ATK, uses its own separate code for collecting
and exposing document markers in the accessibility tree for that platform.
Document markers are used e.g. by screen readers to announce spelling and grammar mistakes to users.

Our goal is to ultimately consolidate the logic for collecting such markers in ui/accessibility/ax_position.
In order to do this, we first have to expose document markers on AXInlineTextBox objects in Blink.

This patch adds a flag that will guard this new feature
because some instability was discovered during its development and we want to disable it for
M87, while safely continuing its development behind a flag for release in M88.

AX-Relnotes: n/a.

R=dmazzoni@chromium.org, aleventhal@chromium.org

Bug: 1124394

Change-Id: I67f7a943c32a016ca7937463c40842d1eede227e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472444
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818087}

Moved sent_nodes and changed_nodes to DocumentSession, it makes
the code more clear, and improves the performance a little bit,
because the node is regroup to a number of small one according
to the document.

This patch also ignores the content change of the unsent node,
adds test for this case.

Bug: 1137463
Change-Id: Id8146bdbd374d09ba27e22851e13ede4f1511b2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469220Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818086}

Omnibox context menu show full URLs option is fully launched, so these
histograms are no longer needed. This CL removes instrumentation from
code and marks the histograms as obsolete.

Bug: 1138297
Change-Id: I511b460e9358a433ecd50d4c83577361d641f743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472583
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818085}

Roll Chrome Mac PGO profile from chrome-mac-master-1602849330-a9b7aee9583f24ea33d238dab5bbe64a57e40269.profdata to chrome-mac-master-1602870879-c4d95eb6e866d4e52485aa00dae385a889389fa8.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I925e885a2815d0df50e9ffc186c907b7a8467695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481410Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818084}

This change adds support for MockFeedback.prototype.replay() to be used in an async function.

For example:
async function test() {
  await doSomething();
  await mockFeedback.expectSpeech('foo')
      .call(() => doSomethingElse)
      .replay();
}

Alternatively, the following is similar, but bad usage:
async function test() {
  await doSomething();
  mockFeedback.expectSpeech('foo')
      .call(() => doSomethingElse)
      .replay();
}

because the return statement is |undefined|. In CallbackHelper, test functions are only expected to return promises, and an async function that returns undefined automatically converts that value to a promise which automatically gets resolved.
Such a promise passes the test incorrectly even if the test throws an assertion. THis occurs when MockFeedback which loops over all actions, gets an assertion, and does not hault execution and keeps trying to match expectations. If at some point, the expectation is matched in the future, the test passes.

For existing tests that are not async, this change does not make any diffference.

e.g.

function test() {
  mockFeedback.call(() => doSomething)
      .expectSpeech('foo')
      .call(() => doSomethingElse)
      .replay();
}

because CallbackHelper, when it receives no return value, goes back to the standard way of counting callbacks; when it hits zero, it finishes the test.
The promise returned by replay doesn't make any impact on the test since the test is not async so returning undefined (implicitly here) does not convert it to a promise.

AX-Relnotes: n/a

Change-Id: I61509222a28730ee3bf8b80349bd11f4b9516636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473805
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818083}

Bug: 1137474
Change-Id: I4dd8d3af9d978d5f99c7fc3a7dc8264b801eff37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480966
Auto-Submit: Haiyang Pan <hypan@google.com>
Reviewed-by: benjamin joyce <bjoyce@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818082}

Making a context current could fail if context is lost. Hence account
for that correctly while destroying |texture_|.

Bug: 1135073
Change-Id: I232e92a1dac27606e2e4762d0b4856e7ab85c058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469372Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818081}

TBR=govind@chromium.org

Change-Id: Ib61a0a7db3e3683fbe146694001970c41d80a188
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481303Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818080}

No behavior change expected.

The CL also removes a trailing include to
chrome/.../ash/tablet_mode_page_behavior.h

BUG=1113900
R=jamescook@chromium.org, sky@chromium.org

Change-Id: I1fe091dbe400afe974fb0f7da90263a2c4cd4f00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472203
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818079}

In RTC video en-/decoder factories, wait until codec support status in
GPU factory is known before querying supported formats and creating
codecs.

This feature is controlled by kRTCGpuCodecSupportWaiter field trial and
is enabled by default with 3 seconds timeout.

Bug: 1047994
Change-Id: Ia822b399b3007815e2f5a15270bbc7cec1801aca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453251
Commit-Queue: Sergey Silkin <ssilkin@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818078}

https://skia.googlesource.com/skia.git/+log/7db7139f4032..fd0b15801ff8

2020-10-16 michaelludwig@google.com Visualize perspective scaling in filter bounds sample
2020-10-16 bungeman@google.com Cannot create SkFontData with no data.
2020-10-16 jlavrova@google.com ICU project: script iterator in SkShaper
2020-10-16 fmalita@chromium.org Cleanup gn_to_bp_utils
2020-10-16 bsalomon@google.com fix always true comparison in assert
2020-10-16 mtklein@google.com update SkTPin()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: robertphillips@google.com
Change-Id: I1194c2bddb25e72ba9dc07577e379d43ee71ac71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481044Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818077}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/acbaac2aa7cd..97cf11a427e8

2020-10-16 bmgordon@chromium.org service/sdk: Explicitly request chroot image type
2020-10-16 chrome-bot@chromium.org Update config settings by config-updater.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: Ia690744e3d334c5434c3b77b687c302e0062ff1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480931
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818076}

This is a reland of 2c428e54

Reason for revert: Breaking:
- win7 All/DumpAccessibilityEventsTest.AccessibilityEventsLiveRegionChange/uia
https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/72572

This reland updates the failing win7 test.

Original change's description:
> Fix TextChanged UIA events
>
> Blink fires the TextChanged event for all sorts of reasons, and it
> leads to flakiness and difficulty fixing other bugs.
>
> Instead, fire this event when a static text node has changed its text
> using AXEventGenerator, which is more stable and predictable.
>
> When static text changes under UIA, fire a text-changed event
> rather than raising a property-changed for UIA_NamePropertyId.
>
> Add AXEventGenerator::Event::EDITABLE_TEXT_CHANGED which is fired on an
> editable root when static text within an editable text region changes.
>
> Bug: 904977, 1062063, 1085481, 1105262
> Change-Id: Ic655deba0d1a5ab1fb575ffa8a56cef1c538c923
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393067
> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#816341}

Bug: 904977
Bug: 1062063
Bug: 1085481
Bug: 1105262
Tbr: dmazzoni@chromium.org
Change-Id: Ia485dee949d063e22befd3532475f0136775bcf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465213Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#818075}

Bug: 1114563
Change-Id: Ia6115e15bfcd377e517c4877c014a2ef4c186857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481003Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#818074}

Roll Chrome Linux PGO profile from chrome-linux-master-1602849330-e626db1a42614bd1b3dbd5e4d956205e419c269d.profdata to chrome-linux-master-1602870879-71fddc22f2ceb12188759a1d8869c82a8b2155fa.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia1adbba45d703b5709fcbc3e285021baa7f0ce1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481405Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818073}