GitLab

This CL replaces the deprecated openURL: call with
openURL:options:completionHandler:.

Bug: 774483
Change-Id: Idf9414bbacc9e633c98f1190a6aee89e2d0ebacd
Reviewed-on: https://chromium-review.googlesource.com/728733
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510251}

This CL adds dirtiness detection to UiScene::OnBeginFrame() as
preparation for future optimizations. It also adds very minor
optimizations to OnBeginFrame by returning early when nothing is dirty.

The concept of dirtying the scene graph is a workaround while we
migrate all of the existing code that modifies UI elements directly to
use bindings.

This shouldn't have any user-visible changes, so is safe to land
sans-flag.

Bug: 776521
Change-Id: I470e8494bd05dd8278c124313bae7df94795861b
Reviewed-on: https://chromium-review.googlesource.com/728943
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510250}

There was no spaces between the title and the rest of the message.
This doesn't solve the issue at crbug.com/773717, but at least it
is less broken now.

Bug: None
Change-Id: Ifda5b20c8a2f1f9cbb0eb32878c56bd1dbc2ebe0
Reviewed-on: https://chromium-review.googlesource.com/726342
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510249}

TBR=haraken@chromium.org
BUG=757374, 776334
NOTRY=true
NOTREECHECKS=true
NOPRESUBMIT=true

Change-Id: I36c3f44119b547c8c85efa7a03c66357c3f1a118
Reviewed-on: https://chromium-review.googlesource.com/729302
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510248}

This reverts commit 71c0f5b5.

Reason for revert: This CL logs to stderr on every test, causing the archive_webkit_layout_tests step to explode. See crbug.com/776334.

Original change's description:
> Reland: Add UKM Document.OutliveTimeAfterShutdown
>
> This is basically same as https://chromium-review.googlesource.com/c/chromium/src/+/647050.
> This CL tries to reland the change after rebasing.
>
> This CL adds a new UKM Document.OutliveTimeAfterShutdown, that is
> recorded when a Document object survives 5, 10, 20 or 50 garbage
> collections after detached. If a document outlives such long time, the
> document might be leaked. The UKM would be very useful to know where such
> leaky documents exist and to fix them.
>
> Design doc: https://docs.google.com/document/d/1fbs5smdd-pBLLMpq7u8EkyddZILtI7CZPJlo_AA1kak/edit?usp=sharing
>
> Bug: 757374
> Change-Id: I1f64d2a9260d898c386bb948dd25a1c5586f8eb7
> Reviewed-on: https://chromium-review.googlesource.com/722301
> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510029}

TBR=palmer@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,holte@chromium.org

Change-Id: I59155476ced5620a87e027225f9f017c296813e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 757374
Reviewed-on: https://chromium-review.googlesource.com/729462
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510247}

Currently this UMA is reported in ContentDecryptorDelegate which is only
used in the pepper CDM path. This CL makes sure we report the same UMA
in the mojo CDM path as well.

TBR=bbudge@chromium.org
BUG=412987,721876
TEST=Manually tested and checked about://histograms

Change-Id: I4687e5115ee6d03e6a2701250bae50acf2dec2a8
Reviewed-on: https://chromium-review.googlesource.com/727700
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510246}

After these changes there are two new browser_test failures:

 * https://chromium-review.googlesource.com/725385
 * https://chromium-review.googlesource.com/665657

The later failure appears to be an existing test failure uncovered by a
change which prevented the Network Service from being enabled during the
test run.

TBR=jam@chromium.org

Bug: 769401
Change-Id: If1d8af9fcfccc9491a5005bd545c1679e820045e
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/729521Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510245}

Also a stepping stone in getting deps from .rc files correct automatically.

The driver script rc.py works like rc.exe; it supports printing resource
names on /showIncludes:

$ cat test.rc
4 ICON "icon.ico"
$ build/toolchain/win/rc/rc.py /showIncludes test.rc
Note: including file: ./foo.h
Note: including file: /Users/thakis/src/chrome/src/icon.ico
$ file test.res
test.res: MSVC .res

The driver script behind the scenes calls a deps'd-in "rc" binary.
This CL includes a script to build new versions of that binary.
It's ~150kB on Mac and Linux, and ~600kb on Windows.

The compiler isn't hooked up to anything yet. I plan to change
tool_wrapper.py to call both it and rc.exe in ExecRcWrapper() when
on Windows (and compare the two outputs and make sure they're identical),
and to call only rc.py when on non-Windows.

Eventually I also want to make ExecRcWrapper() use rc.py's /showIncludes
to get dependencies for .rc files right.

The README.md has some more details. We're in the process of slowly
upstreaming this to LLVM, but it looks like that'll take a while longer,
so in the meantime let's do this until the LLVM version is ready.

Bug: 774193,132660
Change-Id: I9a9ee1e271bf403ddb7f8d18ecd97730762c6cbc
Reviewed-on: https://chromium-review.googlesource.com/727110
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510244}

Previously some compositing layout tests used references which contained
styles and elements which were not enough different from the test. This
increased chances that the same bug affects both the test and the
reference and the test still passes.

This CL removes unnecessary styles and elements from references to make
them more different from the tests.

Change-Id: I7c452c27f44fb34460217697ce1dd9bf98456d48
Reviewed-on: https://chromium-review.googlesource.com/726542
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510243}

NOTRY=true

Bug: 776575
Change-Id: I986136822ee7d835f94af1dffd48399be03ce43a
Reviewed-on: https://chromium-review.googlesource.com/729439
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510242}

These are behavior-driven tests, each test testing a specific behavior:
- addTrack() with a track and no stream should fire ontrack with a
  remote track with the same ID and no streams.
- addTrack() with a track and a stream should fire ontrack with a
  remote track and stream with matching IDs.
- addTrack() with two tracks and a shared stream should fire ontrack
  twice with remote tracks and a shared remote stream, with matching
  IDs.
- addTrack() with a track and two streams should fire ontrack with a
  track and two streams with matching IDs.
- ontrack should fire before setRemoteDescription()'s promise resolves.
- ontrack's receiver should match getReceivers().
- removeTrack() should not result in a receiver being removed.

Unlike RTCPeerConnection-ontrack.https.html, these tests do not rely on
transceiver support. When testing a behavior like "fires an event with
a track" the test does not test unrelated things like the event being a
complete implementation of RTCTrackEvent with transceivers and all.

In a follow-up, I will add tests for other behavior associated with the
removal of a track, including onmute events firing and the track being
removed from the remote streams.

Bug: 774303
Change-Id: I87d8a79d9e2e385610f749a9146b740cc649cf3f
Reviewed-on: https://chromium-review.googlesource.com/719615
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510241}

Whenever the Page Info bubble needs to update the number of cookies being used
on a site, it will update the text in the Page Info bubble to reflect this,
which will then trigger a layout update and reanchor the bubble. However, if
this occurs while the browser window is moving into full screen mode, the Page
Info parent window will be null and this operation will crash.

Fix by checking whether the parent window exists before trying to reanchor.
Moving into full screen will also close the Page Info bubble, so the reanchor is
unnecessary anyway - it will be correctly positioned the next time it is opened.

Bug: 773283
Change-Id: I6f7418fcc96a95b8e3f0a3276ac009cef6eda92e
Reviewed-on: https://chromium-review.googlesource.com/720579
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510240}

At this point, the id_mapping functionality is only used for GetSynciv
(and IsSync, but it's a noop there), whereas this can be simplified by
using a Do function that does the same thing (and is much smaller code
than the corresponding autogen logic).

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I65128d736ea07f034ac3f5c93eb3d0445095ee27
Reviewed-on: https://chromium-review.googlesource.com/728703Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510239}

In addition to registering the name with the global ThreadIdManager, the
platform thread object's name is set with zx_object_set_property(), so
that it will be reflected in logging from e.g. the platform's crash
handler.

Bug: 725726
Change-Id: Id47efa77857b35c2317b5eed05aa2e630a044113
Reviewed-on: https://chromium-review.googlesource.com/727699Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510238}

Bug: 768782
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7fd7a16c3c4493c71662ed5ddc4a7906b6bafeee
Reviewed-on: https://chromium-review.googlesource.com/727188Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510237}

Updating the comment per miu@'s comments on crrev.com/c/713406

Bug: 765337
Change-Id: I80a1ebaabfa70479f724cb2b86697fc3231db61e
Reviewed-on: https://chromium-review.googlesource.com/726385Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510236}

UpdateInternalDisplay should register the display info
only if
1) no internal display info  is registered. (it'll be
  treated as new display)
2) it's disconnected

BUG=774383
TEST=covered by unit test. manually tested on kevin.

Change-Id: Ifdf74ad7e61a0d5ffa617e0a72622e2ddb9bbebd
Reviewed-on: https://chromium-review.googlesource.com/726262
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510235}

The OnDragEnd coordinates was incorrect at mac,
because the api we are using:
draggedImage:endedAt:operation
(https://developer.apple.com/documentation/appkit/
nsdraggingsource/1806949-draggedimage?language=objc)
The endedAt location is the image’s origin in screen
coordinate, but we used it as dragend coordinate.

In this patch, I added a offset similar to startDrag
to correct the coordinates.

Bug: 762701
Change-Id: Ie92e84998d076c58f099215a548ab1934c973958
Reviewed-on: https://chromium-review.googlesource.com/655977Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510234}

Change-Id: Ied26e0a5eeed8ed2f4ca572f1d43bb27a126fa3a
Reviewed-on: https://chromium-review.googlesource.com/704020Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510233}

This reverts commit 14aa2e0e.

Reason for revert:
<select> tags non-functional (both web and chrome:// pages).
See http://crbug.com/776548

Original change's description:
> Fix crash with MojoInputMessages
> 
> Once WillShutdown is called the InputHandlerProxy object should be destroyed
> since it is no longer valid.
> 
> BUG=775483
> 
> Change-Id: I3dc1cf7d7295ff08bbcec3d8ee2b12690961af2e
> Reviewed-on: https://chromium-review.googlesource.com/725860
> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509894}

TBR=dtapuska@chromium.org,mustaq@chromium.org

Change-Id: I7e8f0d3f6a8e41acf12bda09993aac1b2cbfccf3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775483
Reviewed-on: https://chromium-review.googlesource.com/729206Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510232}

Bug: 774814
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I442f55b957017119b5241993ee0f90ae63a86557
Reviewed-on: https://chromium-review.googlesource.com/729126Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510231}

TraceWrappers() is simple enough to just declare and define directly.
This avoids potential issues with the chrome clang plugin checks for
virtual and the final/override specifiers, and makes it consistent with
how Oilpan tracing methods are now declared/defined. Replacement was
automated using perl regex to expand the macros.

Bug: 775741
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I315a1a57d082ece7750d8223ddd1c4f5e7a535d9
Reviewed-on: https://chromium-review.googlesource.com/727533
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510230}

BUG=751892

Change-Id: I8323075c239ba3a1abc785c4b6b14c6ae9c8e144
Reviewed-on: https://chromium-review.googlesource.com/726966Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510229}

AFAICT it's not used

BUG=none
TEST=none

Change-Id: I170fc14bdb064524cecb8f90c17b35fac3f7f2b5
Reviewed-on: https://chromium-review.googlesource.com/728867Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510228}

- Use base::TimeDelta for timers.
- Initialize more members in headers.
- Put some members near related members.
- Add FormFillTimerData which is more readable than a std::pair.

Change-Id: Ifc2ad1004abe3d83b66b68f678ef7ebb04098c3c
Reviewed-on: https://chromium-review.googlesource.com/727409
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510227}

Blacklist the remaining icall buildbot failures in NaCl. I've avoided
categorizing the failures as NaCl is deprecated.

Bug: 772906
Change-Id: I824a763bc86d64ab83c55774bcee03d24efb4376
Reviewed-on: https://chromium-review.googlesource.com/728304Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510226}

Change-Id: I28b772e92fdf05013ee4fc95e76e370c81daed52
Reviewed-on: https://chromium-review.googlesource.com/726946Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510225}

This isn't ideal, but it does make things faster.

A few more tests pass (don't timeout) only 1-2 additional failure.
So a net win?

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Id95bdd4ebcfd2534dbbf07b50a730c9961349713
Reviewed-on: https://chromium-review.googlesource.com/726846
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510224}

Dependency from platform/loader to url/mojo/url.mojom-shared-internal.h
was still missed in the previous change.

This is a reland of ab4da6c8
Original change's description:
> Reland "Reland "Reland "Split WebKit platform build file"""
> 
> blobs.mojom-blink.h internally depends on url.mojom-blink.h.
> So, we should have //url/mojo:url_mojom_gurl_blink__generator
> dependency in blob:generator target on which other test_support
> source_set depends.
> 
> confirmed that generated ninja files, i.e.
> ../obj/third_party/WebKit/Source/platform/loader/test_support.ninja
> has a dependency to obj/url/mojo/url_mojom_gurl_blink_generator.stamp
> 
> This is a reland of 1cf9f36e
> Original change's description:
> > Reland "Reland "Split WebKit platform build file""
> > 
> > test_support of platform/loader and platform/network should
> > depends on //storage/public/interfaces:interfaces_blink__generator
> > because it indirectly includes generated mojo interface headers.
> > 
> > This is the root cause of the original issue, and it seems
> > BUILD file splitting makes it happens more easily.
> > 
> > This is a reland of 997ce7ad
> > Original change's description:
> > > Reland "Split WebKit platform build file"
> > > 
> > > platform/network/BUILD.gn lacked mojo_bindings_blink dependency.
> > > This caused a race on compiling.
> > > 
> > > This is a reland of 080c70a7
> > > Original change's description:
> > > > Split WebKit platform build file
> > > > 
> > > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader.
> > > > To resolve it necessary to extract targets  //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed.
> > > > All of these done in this CL.
> > > > 
> > > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it
> > > > to submit since it needs quick rebase works to catch up HEAD.
> > > > 
> > > > Bug: 754600
> > > > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e
> > > > Test: gn check out/Release && ninja -C out/Release
> > > > Reviewed-on: https://chromium-review.googlesource.com/612284
> > > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> > > > Reviewed-by: Daniel Bratell <bratell@opera.com>
> > > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#508661}
> > > 
> > > TBR=engedy@chromium.org
> > > 
> > > Bug: 754600
> > > Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc
> > > Reviewed-on: https://chromium-review.googlesource.com/718243
> > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#508993}
> > 
> > TBR=engedy@chromium.org
> > 
> > Bug: 754600
> > Change-Id: Ia1231a3ee2213bb44474bd8ffeacf67b86002bfd
> > Reviewed-on: https://chromium-review.googlesource.com/720542
> > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> > Reviewed-by: Emil A Eklund <eae@chromium.org>
> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#509359}
> 
> TBR=jam@chromium.org
> 
> Bug: 754600
> Change-Id: Ica01cdfc20e7cf26e1adf4c42a5fae7ac83a310e
> Reviewed-on: https://chromium-review.googlesource.com/725139
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509749}

TBR=ccameron@chromium.org

Bug: 754600
Change-Id: Id13528a0181a589ad85dc67ea2c57fa384c68b36
Reviewed-on: https://chromium-review.googlesource.com/727443
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510223}

Previously GetNetworkList was calling getifaddrs(), but it isn't
implemented on Fuchsia yet. Replaced it with a GetNetworkList()
implementation that calls Fuchsia-specific ioctl.

Bug: 768916
Change-Id: I5e6e5c2f06867c3d4a3ec08cf2526bb24f4b7e60
Reviewed-on: https://chromium-review.googlesource.com/728919Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510222}

Needed to set |enable_surface_synchronization| correctly in the
ClientLayerTreeFrameSink::InitParams.

Bug: 770833
Change-Id: Ibfbb810a1d787e6736e0522998175252977e7bee
Reviewed-on: https://chromium-review.googlesource.com/728706Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510221}

Release non-official builds are used for dev purposes, so it's useful
to have backtraces.

Bug: Internal 67965579
Change-Id: I91f2642ed27acb06255aa4d43db1e39e50c863f3
Reviewed-on: https://chromium-review.googlesource.com/728727Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510220}

This reverts commit 37d5fc56.

Reason for revert: Speculative revert for SOLINK failure in https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/46752

Original change's description:
> Add speech recognition API wrapper in VR
> 
> This CL adds an invisible button which should trigger voice search.
> Note that the UI will change significantly. The main purpose of this
> CL is to add speech recognition API wrapper.
> 
> Bug: 773767
> Change-Id: If760a88cc950b231d3b2c14b94403afd8f23c56b
> Reviewed-on: https://chromium-review.googlesource.com/701174
> Commit-Queue: Biao She <bshe@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510182}

TBR=vollick@chromium.org,bshe@chromium.org

Change-Id: I2943d46e3d7d160852371a33f16e44ba1d62fbb6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773767
Reviewed-on: https://chromium-review.googlesource.com/729319Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510219}

Remove old touch scrolling metrics that were
replaced back in M56.

Bug: 649754
Change-Id: If47392ac6902bd9cf4e8a001752943e0f615ba70
Reviewed-on: https://chromium-review.googlesource.com/728714Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510218}

For all cases where it returned the non-default value (true), replace
with setting the clickable field in Notification.

Bug: 776187
Change-Id: I24c99a651a0753b8ab474102ed50ee94b72b0d90
Reviewed-on: https://chromium-review.googlesource.com/727468Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510217}

Bug: 722942
Change-Id: If2151274f2cfd1eaddd3a0cbeaf99636b8534a05
Reviewed-on: https://chromium-review.googlesource.com/726976
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510216}

Change-Id: I07e088d2b98be4bb7872e69a730b618b9258d734
Reviewed-on: https://chromium-review.googlesource.com/728367Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510215}

Bug: 769572
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I87beab786bcc3644290ff555994af980f3dbe59d
Reviewed-on: https://chromium-review.googlesource.com/723610Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510214}

Removing dead code and for loop not used.

Bug: 
Change-Id: Id562defd8b748bdf5f984e3a0f4850e6acef0ad2
Reviewed-on: https://chromium-review.googlesource.com/727199Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510213}

This adjusts the precedence for the
--webview-enable-safebrowsing-support switch, ensuring that application
opt-out always has higher precedence.

The switch value will only be used if the application specifies no
opt-in preference.

Bug: 773798
Test: Manual - apply flag, start application with opt-out & with no opt-in preference
Change-Id: I514179e6b51ec90dc0bfefe13236d66e9bfbc14b
Reviewed-on: https://chromium-review.googlesource.com/726950Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510212}