GitLab

Mojo requires event types to not be undefined. There appear to be a few
cases on Android where undefined types are possibly sent to the renderer.

I hope this addresses the crash as the stack traces don't appear to be
very good.

BUG=791986

Change-Id: Ibdd76a47b7ecd19fa91ee43d4200e3140407d187
Reviewed-on: https://chromium-review.googlesource.com/820230Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523184}

https://chromium.googlesource.com/catapult.git/+log/665b8b46209c..c2efefbc3625

$ git log 665b8b462..c2efefbc3 --date=short --no-merges --format='%ad %ae %s'
2017-12-11 simonhatch Dashboard - Batching in /add_histograms

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I1c746da5c47dc250760a7ff2bd9f392d08ed8829
Reviewed-on: https://chromium-review.googlesource.com/820110
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523183}

Will start a background task to create an AddressValidator in the
constructor.

When the AddressValidator is loaded, it will load rules for any
pending normalization request.

Reland with ValidationRulesStorageFactory destruction fix.

Bug: 789711
Test: components_unittests
Change-Id: Ib08581c5afd48ddfe016d3024f28b228e33f646f
Reviewed-on: https://chromium-review.googlesource.com/819594Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523182}

This new test* fails with the NetworkService enabled because it reaches
out to google.com and is surprised that there is a redirect served by
the real thing. Tests should not be making actual network requests.

* ExtensionApiTest.DoNotOpenUninstallUrlForBlacklistedExtension

Bug: 793899
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic866fd1f8ac48428a8179f5cecbd60d5ff17b5be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Tbr: jam@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/820152Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523181}

When a crashed OOPIF is navigated again the RenderWidget is recreated but
RenderWidgetHost is reused. Therefore RenderWidgt assumes no page focus while
RenderWidgetHost might be focused. This leads to caret not showing for a focused
input (and the text area no being highlighted).

This CL adds a method to RenderFrameHostManager to ensure page focus consistency
similar to page visibility.

Bug: 752140
Change-Id: I1baaaa6c4b2c720a73f1cb72a3ad80e30e9036dc
Reviewed-on: https://chromium-review.googlesource.com/818732Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523180}

Currently we defer the impl-side invalidation until the draw deadline
in order to merge them with the incoming main frame. But delaying until
the deadline implies that this invalidation's raster will miss this
frame's draw and result in a pending tree that has to wait until the
next impl frame, which will block the pipeline.

Instead use data from CompositorTimingHistory to decide whether
invalidations should be prioritized over the main frame at the
beginning of the impl frame.

R=brianderson@chromium.org

Bug: 691735
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I7764cb2934aa2d3bf2d72534e128391341f75d10
Reviewed-on: https://chromium-review.googlesource.com/802414
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Brian Anderson <brianderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523179}

1- Add Feature flag for WKSystemCookieStore usage.
2- Create SystemCookieStoreUtil to create the correct type of
   HTTPSystemCookieStore based on iOS version and the feature flag value.

Bug: 779106,759229
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie4da0c3c49ede43e27368ef40162cdd7bc164a34
Reviewed-on: https://chromium-review.googlesource.com/809307
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523178}

This reverts commit 8fabb768.

Reason for revert: Incomplete migration. Will try again soonish

Original change's description:
> Migrate to metadata v2 and support PPD Restrictions
>
> Update the GetPrintersURL call to utilize metadata_v2. This allows for certain
> restrictions to be placed on the model to determine whether or not the printer should be displayed
>
> Bug: chromium:773766
> Change-Id: Iaade00489a066340a095b3b07bbd853f13f8e35a
> Reviewed-on: https://chromium-review.googlesource.com/797476
> Commit-Queue: Luum Habtemariam <luum@chromium.org>
> Reviewed-by: Sean Kau <skau@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521064}

TBR=stevenjb@chromium.org,skau@chromium.org,justincarlson@chromium.org,luum@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:773766
Change-Id: Ia17119151bf2d88951589b47e2ea0c1c38796cd2
Reviewed-on: https://chromium-review.googlesource.com/820291Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523177}

5e16410ad448 fuchsia: Download the toolchain to distinct directories per
             build host
1ee9fee37c44 Update buildtools, gtest, and gyp
ef3ce94fbfbb Python 3 support for Python scripts (without compromising
             Python 2)
3f5c939c848a gn: Next step in getting compilation working
593ede52e053 Fixes for drive-by review comments after ef3ce94fbfbb
9465fc72ad90 gn: Move sources out to explicit blocks
d25b0242c6c5 gn: Fix a couple of things after 9465fc72ad90 and
             2bb56fafe3bd
7e9dbd53fb74 fuchsia: Misc fixes to get more pieces compiling
eeb31321f706 gn, fuchsia: Add //testing forwarding and GN build file
5969d6b1eb22 android: NDK r16 compatibility
741a84a2987f fuchsia: Add runner, get crashpad_test_test building and
             running
7a0daa6989a9 Enable reading notes from ELF images
2403d066c4a5 fuchsia: Support runtime_deps of directories
bfeb194b017e fuchsia: Get crashpad_util_test building
6719610b8c76 fuchsia: Get crashpad_snapshot_test building
612237a0328a android: Fix 32-bit test to build at API [21, 24) with
             unified headers
e0f396313154 Sever the connection between the test support library and
             snapshot
15c4fff902ea Get crashpad_client_test and crashpad_handler_test building
82a80acd3155 Roll mini_chromium 96e32dd4..a12ed4a6
a4fc880278e7 gn, mac: Get basic generation working
914b0d675528 Fix enum vs unsigned -Wsign-compare warnings
659420bc7d7e android: Run tests by running run_tests.py on the build
             host
00e6bd088725 fuchsia: Get 'all' to build
ac3cc1b884e0 Provide a non-explicit constructor for StringAnnotation

Also modifies .gn to set crashpad_in_chromium=true.

Change-Id: Ie886774e753e76cf6c2bfa11aa522c8c789c9d6f
Reviewed-on: https://chromium-review.googlesource.com/817479
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523176}

The WebView Support Library glue layer should post tasks to the
WebViewChromiumRunQueue owned by WebViewChromiumFactoryProvider, so that
new glue layer needs access to the WebViewChromiumRunQueue class
definition. Therefore we move that definition out of the existing glue
layer.

BUG=785928

Change-Id: I5b4e41baf6bef11d8dd6762372e5a764732ad96f
Reviewed-on: https://chromium-review.googlesource.com/819638
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523175}

Adds a test to ensure that WebVR presentation on Android causes
window.requestAnimationFrame to stop firing, but resumes once
presentation is finished.

Bug: 716647
Change-Id: I1569ba8813fbb74ffdfa0a741b0e5889069ee24f
Reviewed-on: https://chromium-review.googlesource.com/818204
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523174}

Add a vaapi-specific OWNERS file and populate it. This is a refry
of crrev.com/c/818381 and has been lgtm'd separately.

Also removed 'messages' entry from the current OWNERS file because
it's contemplated in //media/gpu/ipc/common/OWNERS.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I85676373a8c1d6ffa56eb41ed2ba1892f7793155
Reviewed-on: https://chromium-review.googlesource.com/820035Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523173}

After a phone number field is marked as fill_only_when_focused by rationalization,
we should log the quality metrics differently compared to normal fields. For
example, if a field is left empty and being fill_only_when_focused, it should be
logged as true negative, meaning we anticipated this field will be left empty.

Bug: 780471
Change-Id: I3457b6381430055c7c4cb8431f0da193f396065d
Reviewed-on: https://chromium-review.googlesource.com/786340
Commit-Queue: Hui Wu <wuandy@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523172}

There's really no reason for us to be posting this for every single
Render() call. They can be updated nearly as quickly during each
FrameReady() call. There's also no reason for us to create a new
PipelineStatistics structure every time either. Instead replace
a multitude of member variables with a PipelineStatistics member.

This is an optimization of PipelineStatistics usage so that we
can add a Decoder enum value later.

BUG=793151
TEST=existing tests pass.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5375acf74a625e1095e6631e177b4a04a4a0e54d
Reviewed-on: https://chromium-review.googlesource.com/816019Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523171}

Update the Critical section of the Security Severity FAQ.

Change-Id: I167cb99f3778e8c1f68c65de65a81a6354a5a346
Reviewed-on: https://chromium-review.googlesource.com/820172Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523170}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0356476340d3ad2f6bc9a41f99bd904b4fcab79f
Reviewed-on: https://chromium-review.googlesource.com/817755Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523169}

Instead of hardcoding GL_TEXTURE_EXTERNAL_OES or GL_TEXTURE_2D

This will be useful for the subsequent CL,
https://chromium-review.googlesource.com/c/chromium/src/+/766787

Bug: 785201
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2678181b4b9389c39999d07cb9e56c102fc5f299
Tests: media_unittests --gtest_filter=*VaapiVideoDecodeAcceleratorTest*
Reviewed-on: https://chromium-review.googlesource.com/819131Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523168}

Override virtual keyboard overscrolling for view based lock and login
screens. Virtual keyboard overscrolling is interfering with resizing
window properly. The override is used in web based lock and login
screens.
See crbug.com/363635 for context.

Bug: 791817
Change-Id: Ic04b0823db1ffc2f4e96983f0ac9606ee6dadbb2
Reviewed-on: https://chromium-review.googlesource.com/818628Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523167}

The ARC VPN feature will go live in M64.  Leave the flag in place in
case it causes trouble, but enable the feature by default.

BUG=696865
TEST=buildbots

Change-Id: If64e60945d299f5ef6c538471e07a41e47024ea1
Reviewed-on: https://chromium-review.googlesource.com/812499Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Kevin Cernekee <cernekee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523166}

A recent change caused us to display the broken image for src=""
in img tags. Revert that case because other browsers (Safari, Firefox)
display nothing.

R=chrishtr@chromium.org
BUG=793206

Change-Id: Iaa531976d76b7b20b238f23d1bf220126a82b64b
Reviewed-on: https://chromium-review.googlesource.com/817960
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523165}

The following metrics are added:
- The bookmarks panel is opened
- Any bookmark is followed
- Change page by typing the number on the toolbar
- Rotate
- Fit to width
- Fit to page

We need these metrics to make informed decisions about tweaks to
our current UI and an upcoming overhaul.

Bug: 768982

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia871b4d390ea7dc28f9017780c9622fb5d54cbce
Reviewed-on: https://chromium-review.googlesource.com/801634
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523164}

This reverts commit 3738ee85.

Reason for revert: Patch is wrong, and is probably causing a crash on device. When running ash, target is actually set correctly. It's not set correctly in the unit tests though.

Original change's description:
> Start fixing ImmersiveFullscreenController tests.
> 
> The OnPointerEventObserved() interface acts differently between mash and
> mus/classic. In mus/classic, the target window is taken from the
> LocatedEvent's target(), relying on previous event dispatch metadata. On
> mash, this event came from a remote service which hasn't been targeted,
> target is therefore the top of the window tree. In the --mash case only,
> target the event on the window and use that as the window we pass to the
> rest of the system.
> 
> Bug: 698085
> Change-Id: I8a1859055d9427b269cd5256c7ff114a1e97574d
> Reviewed-on: https://chromium-review.googlesource.com/801976
> Reviewed-by: James Cook <jamescook@chromium.org>
> Commit-Queue: Elliot Glaysher <erg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521090}

TBR=jamescook@chromium.org,erg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 698085, 793839
Change-Id: I5d9325b72853c8793f5ce1f3e66fe74461eea9be
Reviewed-on: https://chromium-review.googlesource.com/820290Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523163}

Automatic comment fixing:

sed -i -e 's|(crbug.com|(https://crbug.com|' `grep -rn "(crbug" media/gpu/ | cut -d: -f1 | uniq`
sed -i -e 's| crbug.com| https://crbug.com|' `grep -rn " crbug" media/gpu/ | cut -d: -f1 | uniq`
git cl format

..because otherwise cs.chromium.org doesn't linkify them.

TEST: No new code.
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icc0244dd61031cbd51a53044ef2d7aca77d2a3cc
Reviewed-on: https://chromium-review.googlesource.com/818192
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523162}

Some WebRTC tests were failing when executed in the same process with
others because they were leaving base::TaskScheduler intialized. Updated
WebRTC tests to use ScopedTaskEnvironment to ensure that TaskScheduler
is destroyed.

Bug: 750940
Change-Id: I7420aba0c2a990ecfd2fd44df7ac014a76a73ba7
Reviewed-on: https://chromium-review.googlesource.com/817525Reviewed-by: Per Kjellander <perkj@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523161}

This change also puts some more files that don't expose public interfaces
into mojo/public/js/lib.

BUG=699569

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia84ec62323140c374fbe3def41152758a51cd337
Reviewed-on: https://chromium-review.googlesource.com/812106Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523160}

This CL fixes a small typo that was not spotted in

https: //chromium-review.googlesource.com/c/chromium/src/+/798192
Change-Id: Id76e38416a3634e18e5edb9cd2c20f81996879e6
Reviewed-on: https://chromium-review.googlesource.com/804434Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523159}

In order to support CSS counters in a display:contents context, we need
to track current element instead of LayoutObject in FindPlaceForCounter
since display:contents do not have LayoutObjects.

Also corrected documentation and variable/method names according to
coding style.

Bug: 766650
Change-Id: I399511184f3a22a19b6279a6c921787b96b84cef
Reviewed-on: https://chromium-review.googlesource.com/818341Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523158}

And finish the rest of the permutations, since they're easy
to implement...

Bug: 789067, 656015
Change-Id: I32893ff6ce2ef1d0221abc117a42a09e8ee7b136
Reviewed-on: https://chromium-review.googlesource.com/813916Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523157}

Bug: 667560
Change-Id: I87aee8e9e35a01c4be655f43cf07fed1da3cb6d2
Reviewed-on: https://chromium-review.googlesource.com/780781
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523156}

This change removes the 60 second time restriction from the info-promo
and adds a shared preference to determine whether it was shown. As to
not conflict with the opt-in/out promo, when that experiment is
disabled, the info preference is set so that promo will not be
presented to the user.

BUG=789685

Change-Id: Iabe72822dd6e51b35427719454b48e1fb7818bd3
Reviewed-on: https://chromium-review.googlesource.com/809344
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523155}

Bug: 507755
Change-Id: I369d942e9c9afe3d600885377ce79e09f91ccaea
Reviewed-on: https://chromium-review.googlesource.com/818529Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523154}

Convert the native event location to the target's host if it's different
from the source's host.

BUG=714578

Change-Id: I09d64fe043c9d872331dd35babd41ca62280f9c7
Reviewed-on: https://chromium-review.googlesource.com/804954Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523153}

Fix reporting a size of 2x2 on the video element during the loading
phase.

Bug: 684288
Change-Id: Id4adceefaf4c3df57a1ba41fd285862d72792b1a
Reviewed-on: https://chromium-review.googlesource.com/806215
Commit-Queue: Florent Castelli <orphis@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523152}

Caching the network state is dangerous, because a single missed network
connection update can indefinitely block all subsequent requests. Moreover,
there is no benefit to caching the state – it's just extra overhead.

R=pauljensen@chromium.org

Bug: 793103
Change-Id: I21d6318b3b85fb7125cc53b8e3d54842c2ce7564
Reviewed-on: https://chromium-review.googlesource.com/818527Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523151}

Remove a test-only method from DataReductionProxyServer, and update
the callers.

Bug: 760294
Change-Id: Ib90a4fb896df9b14839373aa8741ac8ca2ff8ed1
Reviewed-on: https://chromium-review.googlesource.com/814855
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523150}

X11 header files are infamous for creating macros with common
names such as None, True, False, Status, Bool, ...

To save oursaves the mess that creates, they are now wrapped
in a header, ui/gfx/x/x11.h, which puts those symbols in the
x11 namespace and removes the global macros.

This means we can remove various undefs in files that have had
problems in the past.

Bug: 782184
Change-Id: Ie48fe619e3101344d53ea837b0b21570516185ca
Reviewed-on: https://chromium-review.googlesource.com/814676Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#523149}

Adds recordBoolean and recordEnumerationValue to metricsPrivate.

Bug: 792744
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id4f3e2baf8f15b6010af1115b34c89f542712f66
Reviewed-on: https://chromium-review.googlesource.com/815296Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Katie D <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523148}

This change removes the functions using TestRunner from
bluetooth-helpers.js and places them in a separate
bluetooth-fake-adapter.js file. For the mean time, the new file will be
loaded in loadChromiumResources until all the tests that depend on
TestRunner are converted to use Web Platform Tests. This will allow us
to migrate tests that use bluetooth-helpers.js into the wpt/ directory
since references to TestRunner should not exist in wpt/.

This change also updates the cross-origin-iframe.html test to load the
new bluetooth-fake-adapter.js file in order for the test to run
properly.

BUG=509038

Change-Id: Ic0bc7f5309123f77d7627abf7b63dbd0e6e9dadd
Reviewed-on: https://chromium-review.googlesource.com/817694
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523147}

cache_storage and notifications both had "CurrentWorkerId()" with
the same (trivial) implementation but used differently. For
jumbo builds to not have those clash, this patch renames the
one in notifications -> NotificationWorkerId()

Bug: 746953
Change-Id: Ic00a4e23448bd2d50315a5561f798ed40be56fdc
Reviewed-on: https://chromium-review.googlesource.com/819558
Commit-Queue: Daniel Bratell <bratell@opera.com>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523146}

The issue is that during initialization HistoryBackend passes raw pointer of
HistoryDatabase to TypedURLSyncBridge. Later when database error is detected
HistoryBackend resets HistoryDatabase object leaving TypedURLSyncBridge with
invalid pointer. When updates from server arrive TypedURLSyncBridge tries to
write them to database causing crash.

The fix is to notify TypedURLSyncBridge about database error, reset
sync_metadata_database_ pointer and report error to sync so that datatype is
disabled and doesn't receive updates from server.

BUG=789876
R=skym@chromium.org

Change-Id: Ic62709f37eef24f19e7f729998cee56943024084
Reviewed-on: https://chromium-review.googlesource.com/815880Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523145}