- 28 Nov, 2017 40 commits
-
-
Mostyn Bramley-Moore authored
Change-Id: Ia9af79c05b910e2fa345825d225ff6cfc3a1ec78 Reviewed-on: https://chromium-review.googlesource.com/791590Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#519597}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: Id3a68d0efd803d9ab3c1670bfa641ca9641c3af9 Reviewed-on: https://chromium-review.googlesource.com/776641Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#519596}
-
Ricky Liang authored
The typical way of handling system suspend and resume of Android camera HAL is to close the device on suspend and re-open the device on resume. We should register to system suspend / resume events and close / open the camera device accordingly. BUG=b:63984332 TEST=Open Chrome camera app and enter suspend then resume. Verify the camera preview still works after resume. Change-Id: I204b04416e8993d0cb71e14c202021a195d2ef45 Reviewed-on: https://chromium-review.googlesource.com/597987Reviewed-by:Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#519595}
-
Xianzhu Wang authored
- Use LocalBorderBoxProperties as the PropertyTreeState of the layers. - After https://chromium-review.googlesource.com/c/chromium/src/+/786130, scrollbar and scroll corner layers have the same OffsetFromLayoutObject logic as the other layers, so just use the same logic to set layer offsets. - Set default chunk property state with the layer state before painting a GraphicsLayer. Bug: 771643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ica8ca0199c64549b499270166eec0743b8bbed57 Reviewed-on: https://chromium-review.googlesource.com/780376 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#519594}
-
Makoto Shimazu authored
This CL implements long standing event timer on the renderer. Events dispatched to the service worker will be aborted in ServiceWorkerEventTimer::kEventTimeout. ServiceWorkerEventTimer needs to track each event individually, so the event timer issues an unique id to each event. For that reason, all of IDMaps used for keeping the event callbacks are replaced to std::map. Design doc: bit.ly/sw-timers-on-renderer Bug: 774374 Change-Id: I77f8c9cd01e1e02ff856306c42de298eebf318ca Reviewed-on: https://chromium-review.googlesource.com/760083Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Alexander Yashkin authored
This patch fixes memory leak in BrowsingHistoryServiceTest tests detected by ASAN build. Also changed TestingProfile to use already implemented and correct(non leaking) version of BlockUntilHistoryProcessesPendingRequests. Leaking object was QuittingHistoryDBTask which is created and passed to ScheduleDBTask function of HistoryService. To delete this object HistoryBackend posts DeletePoiner task back to original loop in ~QueuedHistoryDBTask. Yet nobody processes this task in tests and its leakage is catched by ASAN. history::BlockUntilHistoryProcessesPendingRequests in history_service_test_util.cc calls HistoryService::FlushForTest which does not create any objects in heap and is leak safe. Change-Id: I76040ab9f52656d4c92b874d24ba0bc514e6a031 Reviewed-on: https://chromium-review.googlesource.com/789112 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#519592}
-
Pavol Marko authored
Generate a unique StoragePartition for each subsequent sign-in attempt. This is part of the effort to enable client certificate authentication in the sign-in frame, to ensure that subsequent sign-in attempts are properly isolated from each other. Details: SigninPartitionManager manages the currently-used StoragePartition for the sign-in frame and clears data from the last one. The webview hosting gaia (the sign-in frame) has to be re-created on each StoragePartition change, because a webview which has already navigated is bound to a StoragePartition. Access to the sign-in StoragePartition (e.g. for cookies or proxy authentication data), as well as explicit clearing of the Sign-in StoragePartition is now also performed through SigninPartitionManager. The Enrollment screen also uses SigninPartitionManager, to make sure that if proxy authentication data is entered in the context of the enrollment webview, it can be extracted using the same mechanism. BUG=723849 TEST=unit_tests --gtest_filter=SigninPartitionManagerTest.* && browser_tests --gtest_filter=WebviewLoginTest.* Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8b7bfd4d6650c9756b0800942cd7cf36ec9e0b9e Reviewed-on: https://chromium-review.googlesource.com/776814Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#519591}
-
Takashi Toyoshima authored
In Finalize(), MidiManagerAndroid clears |input_port_to_index_| and |output_port_to_index_| explicitly, but checks |all_input_ports| and |all_output_ports| to be empty in the destructor. We should clear and check all four members in Finalize() and destructor. Bug: 788684 Change-Id: Ia60f57a6faedb89559b0bb1019605bbcc0b78522 Reviewed-on: https://chromium-review.googlesource.com/790076Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#519590}
-
Dan Beam authored
Track whether the page is being created (or refreshed) with dev mode on by tracking the preference in C++ and changing the shim HTML/CSS via the $i18n{...} mechanism. Also set inDevMode in <extensions-manager> as soon as possible. Bug: 788018 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I131cb04024cbfbaf4159a110ee1112346ea59a8c Reviewed-on: https://chromium-review.googlesource.com/786441 Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#519589}
-
Blake O'Hare authored
Almost all implementations of this method are empty so there isn't really a good reason why it should be required. Bug: Change-Id: I1e680280db194a8af6d00f689e70ad64c9a9062f Reviewed-on: https://chromium-review.googlesource.com/792755Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#519588}
-
Khushal authored
Reject SkImage filters if they fail to deserialize, instead of creating a FilterOperation with a null filter. Also fix incorrect enum type on ImageFilterPaintFilter. R=enne@chromium.org, tsepez@chromium.org Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I3cd93fd671e679ac6e8881d75abc47a50d9b5d59 Reviewed-on: https://chromium-review.googlesource.com/791937 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#519587}
-
Matt Giuca authored
Change-Id: Ic11c98558f29eeafc05b2bf3a082c808f5ace023 Reviewed-on: https://chromium-review.googlesource.com/792831Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#519586}
-
Dan Beam authored
It's duplicative with input validation messaging and this was requested by designer bettes@ during a polish pass. Bug: 787227 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1e9f3267b8a62f886ebb0b6ff93d59f6d1006aa2 Reviewed-on: https://chromium-review.googlesource.com/786398 Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This patch removes [Native] and IPC_STRUCT for EmbeddedWorkerStartParams. In a following patch, we can move all of params passed to EmbeddedWorkerInstanceClient::StartWorker() to the mojom::EmbeddedWorkerStartParams. This patch is adding a typemap from content.mojom.EmbeddedWorkerStartParams to content::EmbeddedWorkerStartParams in order to avoid fixing all users of the params. Bug: 776263 Change-Id: I7973e49be869b67e86e1a1b6cee7891b17c2f997 Reviewed-on: https://chromium-review.googlesource.com/784732Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Michael McGreevy authored
The dialogs should be tab modal, but don't currently attach properly to the WebContentsModalDialogManager. Using ShowWebModalDialogViews(..) fixes the attachment. Bug: 788656 Change-Id: Ib4fcb4c5597e831fad027364b278f1f28be89dae Reviewed-on: https://chromium-review.googlesource.com/792370 Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#519583}
-
Tatsuhisa Yamaguchi authored
The message will help identify whether changelist fetch was triggered by a push notification or internal polling timer from the logs in about://drive-internals. Bug: 783184 Change-Id: I3463aad2751b0adab7d708e0c2eb636893ea550d Reviewed-on: https://chromium-review.googlesource.com/790037Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#519582}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77ce4bdc7d9c..24650b6c5ad7 $ git log 77ce4bdc7..24650b6c5 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Ic8e5233e0bdb407aeeb2339596bd9d57b4ae53a6 Reviewed-on: https://chromium-review.googlesource.com/792457Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519581}
-
Shuhei Takahashi authored
Bug: 788311 Test: chrome://histograms Change-Id: I0680689bd151ae07924a9b397112f08710ce1b99 Reviewed-on: https://chromium-review.googlesource.com/788726 Commit-Queue: Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#519580}
-
Xiaocheng Hu authored
This patch adds the above function, so that when writing unit tests, we can check the correctness of functions returning positions in an easier way. This is a preparation patch for crrev.com/c/791856 Bug: Change-Id: If7de011090dca69830a4d8a404f1321934971488 Reviewed-on: https://chromium-review.googlesource.com/706575Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#519579}
-
Hayato Ito authored
virtual/incremental-shadow-dom/external/wpt/shadow-dom/slotchange-event.html is failing for other reasons, which I'll look deeper later. TBR=kochi Bug: 788608,788635 Change-Id: I1e5cb26d7202588b02b04d871e614e178b20225d Reviewed-on: https://chromium-review.googlesource.com/792832 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#519578}
-
Will Chen authored
Bug: 667560 Change-Id: Ic64cbb7d423a928fe102954c41165c608245c8c0 Reviewed-on: https://chromium-review.googlesource.com/792338 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#519577}
-
Eero Häkkinen authored
On Mac, OS provided vectorized functions are used which results in different rounding errors and NaN handling. Bug: 778262 Change-Id: I28479415bfd7117f0b2e712637e9e344b77c4645 Reviewed-on: https://chromium-review.googlesource.com/786153Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#519576}
-
Giovanni Ortuño Urquidi authored
Desktop PWAs should not be allowed to run if there is a problem with their certificate. So when users click proceed on an interstitial we open a new tab in a regular Chrome window and proceed there. To make transient interstitial tests work, this patch also changes ProceedThroughInterstitial to use SendInterstitialCommand instead of InterstitialPage::Proceed for non-committed interstitials. Directly calling InterstitialPage::Proceed skips calling through to SSLErrorControllerClient which is where the logic to open the app window is. Bug: 779857 Change-Id: If90a7f56076977b8cfaf5b3837a0a35c8dbe54cc Reviewed-on: https://chromium-review.googlesource.com/786873Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#519575}
-
Peter Beverloo authored
The header view includes a number of DCHECKs to verify that the metrics of the created layout match the mocks. This is fine, but there's a subtlety in the preferred height of views::Label: the text's size is determined by using the maximum of the font height and the line height. The line height is set in Label's constructor based on the text style, where it consults the typography provider available from the layout provider. There are three versions of this: DefaultTypographyProvider, LegacyTypographyProvider and HarmonyTypographyProvider. The first two return 0, and thereby defer to the font list. The harmony provider has a calculation involving platform-specific values. This grows the height of the labels, thereby failing the DCHECKs. Instead, change the labels to always defer to the font list for their line height. This removes the platform-specific dependency. BUG= Change-Id: I6530b4517bd7bf6ba62f36cd595e05e616b580d4 Reviewed-on: https://chromium-review.googlesource.com/788957Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#519574}
-
Eric Willigers authored
The animation tests complete quickly. There is no need to mark them as slow. BUG=248938 Change-Id: I5d1da5212851ce905706730b7086e8783a4b7df2 Reviewed-on: https://chromium-review.googlesource.com/792752Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#519573}
-
khmel authored
Test: Manually Bug: N/A Change-Id: Ic178c9b6b6c512c2720c7c638a7903657c418d99 Reviewed-on: https://chromium-review.googlesource.com/792016Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#519572}
-
Yuzu Saijo authored
This CL intends to change the leak detection bot name from perf to non-perf. Bug: 777765 Change-Id: I786aa2b756553e64671477170e3afde7aa8bb460 Reviewed-on: https://chromium-review.googlesource.com/790054Reviewed-by:
-
Andrew Grieve authored
Shrinks thin-lto android build by ~3MB Bug: 742655 Change-Id: I12ccaa8b13f021bae96a704ae5edadb2540cedb6 Reviewed-on: https://chromium-review.googlesource.com/789441 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#519570}
-
Austin Tankiang authored
mojo::ReportBadMessageCallback is documented in mojo::GetBadMessageCallback() to only be allowed to be called at most once. Change it from the legacy base::Callback to be a base::OnceCallback to enforce this. Bug: 787653 Change-Id: I674c364bcbd523f31829f48754971e2d624f9348 Reviewed-on: https://chromium-review.googlesource.com/786592Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@google.com> Cr-Commit-Position: refs/heads/master@{#519569}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 676a19bd. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6424 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: worker-dev@chromium.org: external/wpt/service-workers TBR=rbyers No-Export: true Change-Id: Id8a4c9144cf3974057f3550ac95c6b001de4196e Reviewed-on: https://chromium-review.googlesource.com/792216 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519568}
-
Dan Beam authored
There's a rule in the web styleguide[1] about CSS .classes-use-dashes. Our brilliant presubmit uses regex and is silly. So strip $i18n{...} from the cases that have it so the presubmit still works, but just don't show line contents in those cases. [1] https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/web.md Bug: None Change-Id: Ic5aaa0caa3087465b6b40946e113b52ddf635f8c Reviewed-on: https://chromium-review.googlesource.com/785795 Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Reviewed-by: -
Nathan Bruer authored
Fixed bugs where if navigating pages it would sometimes not bind properly and end up creating two files for every save. R=lushnikov BUG=754371 Change-Id: I6c978148ab7ff49e7f86f68ee246b6755e0c5e5c Reviewed-on: https://chromium-review.googlesource.com/791812 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#519566}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c9c97b7fd5f9..37b501d2c9d2 $ git log c9c97b7fd..37b501d2c --date=short --no-merges --format='%ad %ae %s' 2017-11-27 angle-deps-roller Roll skia/third_party/externals/angle2/ ebee5b3b7..0b684ce3c (2 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: I8ff4b32c55dc94ba0e167c136abfc40ca14a76b5 Reviewed-on: https://chromium-review.googlesource.com/792630Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519565}
-
Xianzhu Wang authored
This shortens code like PaintChunkProperties properties( paint_controller.CurrentPaintChunkProperties()); properties.property_tree_state = new_state; ScopedPaintChunkProperties scope(paint_controller, ..., properties); to ScopedPaintChunkProperties scope(paint_controller, new_state, ...); and reduces number of copied bytes, and shortens code like PaintChunkProperties properties( paint_controller.CurrentPaintChunkProperties()); properties.property_tree_state.SetTransform(new_transform); ScopedPaintChunkProperties scope(paint_controller, ..., properties); to ScopedPaintChunkProperties scope(paint_controller, new_transform, ...); Also change the type of Id parameter from a pointer to Optional<> to allow temporary construction of the parameter. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: Ice99a338cccef489791b09e4761f7de314c11f80 Bug: Reviewed-on: https://chromium-review.googlesource.com/791430 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#519564}
-
Blake O'Hare authored
Either 675084 left this code dead or any remaining usage was removed afterwards. Either way, it's safe to remove now. My dream of fixing a CL with an identical bug number was narrowly thwarted. :( Bug: 788649 Change-Id: Icc408f328be611cff06320f4a93e81d0757e153b Reviewed-on: https://chromium-review.googlesource.com/788648Reviewed-by:
-
Christopher Lam authored
This CL adds ContentSettingImageViews to the HostedAppButtonContainer by: - Factoring out a Delegate for ContentSettingImageView which the HostedAppButtonContainer and LocationBarView implement - Adding an icon color override to ContentSettingImageView - Moving the HostedAppButtonContainer to BrowserNonClientView instead of BrowserNonClientViewAsh so that BrowserView can access it (which also prepares its addition to OpaqueBrowserFrameView). This all allows the content setting indicators to be embedded in the hosted app frame, get notified of content setting changes, and respond to active/inactive states. Bug: 762401 Change-Id: I3f65f022201740c8e5a066937d32c189f283a048 Reviewed-on: https://chromium-review.googlesource.com/756634 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 Change-Id: I24839a6d9994a861a58986bfcca6d8050273dcce Reviewed-on: https://chromium-review.googlesource.com/789745 Commit-Queue: Chris Watkins <watk@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#519561}
-
Tom Anderson authored
Many *-dbg packages are being replaced with *-dbgsym ones. This CL begins using those packages when they are available, instead of just skipping the package. BUG=785818 R=dpranke@chromium.org Change-Id: If2d3ea398353628caec77b202a1526451d628931 Reviewed-on: https://chromium-review.googlesource.com/792608Reviewed-by:
-
Theresa Wellington authored
- Show the IPH bubble for at least 10 seconds or until the bottom sheet is opened or tab switcher is entered - Record more IPH events for sheet opened from swipe, sheet opened from button, and pull-to-refresh - Add a new IPH feature that uses pull-to-refresh as a trigger BUG=787030 Change-Id: I864029dc5b8d737f26d088613a515e88d78a320d Reviewed-on: https://chromium-review.googlesource.com/779944 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#519559}
-
chrome-release-bot authored
TBR=amineer@chromium.org Change-Id: I59232b67fab1ac0ef1cd3a2851df5dfd093b37d7 Reviewed-on: https://chromium-review.googlesource.com/792277Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#519558}
-
