- 07 Aug, 2020 40 commits
-
-
Himanshu Jaju authored
- Implements code to reject an incoming connection - Adds checks in tests for data written to remote connection Bug: 1085068 Change-Id: Ic8b1220b881b2adc20b0cd14793b38a1be50732e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332707 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795873}
-
Denis Kuznetsov authored
Seems that changes made in recent month made testing code more stable, so tests are not flaky anymore. TEST=run tests with --gtest_repeat=25 --gtest_break_on_failure with affinity to 2 codes + simulated CPU load on same cores Bug: 997685 Change-Id: I687e0191bddfe569d5a9fcdf60761c66024e7476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339989 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795872}
-
Eleonora Rocchi authored
This CL adds to the mediator the logic to handle updates of the status needed for the UI of the status header. Two new properties are added to the model: - Timestamp of the last check completed - Progress of the current check (if running) It also adds tests to check that the model is being correctly updated. Bug: 1109691, 1092444 Change-Id: I07daefc8df1dff609a86505618483f4eefa2646a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320835 Commit-Queue: Eleonora Rocchi <erocchi@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795871}
-
Vikas Soni authored
1. This CL implements a zero copy path for video playback on webview. 2. It is enabled only when AImageReader is supported. 3. Added a finch flag to roll out this feature via finch. 4. Currently it is implemented and enabled only for MCVD. TBR=rsesek@chromium.org Bug: 1091945 Change-Id: I7b6a2cd71c0c82d0eaff08fbbac0cfa60ccfcd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294347 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#795870}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter.This CL passes |Profile#getLastUsedRegularProfile| to |getIdentityManager| function. Using always regular profile is safe, since code block is only called for regular profile, while there is no plan to be called for off-the-record profile. Bug: 1041781, 1075562 Change-Id: I8253a9c6baf4b5f5d9034e61ff180da37102ae62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339660Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#795869}
-
Eleonora Rocchi authored
This CL adds an icon/progress bar to the header of Check Passwords. It also adds the tests to verify the correct visibility of the elements of the header. Screenshot in the linked bug. Bug: 1109691,1092444 Change-Id: I329f9a21904288f1042417a67be9cb57583355f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317875 Commit-Queue: Eleonora Rocchi <erocchi@google.com> Reviewed-by:
-
Ramin Halavati authored
Deprecated function is removed and all use cases are updated. Bug: 1023759 Change-Id: I1b085e1a796af0f7745ca35c7b4ddb5632cd1e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340050Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#795867}
-
Stephen Nusko authored
This is failing consistently since being added so disabling and will assign to benchmark owner. Bug: 1114112 Change-Id: Ib58444d46f5ee43f0cc55f6298c6aa02119c77d6 No-Try: True TBR: johnchen@chromium.org CC: dmazzoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341641Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#795866}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3546945795af..99589a53ddd5 2020-08-07 patrick.brosset@microsoft.com Grid: Turn the v1 grid overlay ON If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0109e1a06f9cb8af5201728b4e0c9da02d4d3972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343044Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795865}
-
Saurabh Nijhara authored
As part of UI review, feedback is received to replace 'device' in the strings with actual device type as 'Chromebook' or 'Chromebox'. This can be found in the launch bug (1048607) linked in the below mentioned bug for this CL. This CL incorporates this feedback. Additionally, it migrates some feature strings to plural format. Screenshots: 1) Update required screen https://screenshot.googleplex.com/Pogoq9YYYi7 https://screenshot.googleplex.com/WvS4mrKGsdY 2) Settings https://screenshot.googleplex.com/6upicf2NxKD https://screenshot.googleplex.com/ydJ1q9j2TRu 3) Notifications End of Life (days) - https://screenshot.googleplex.com/FJ06EmTTeE8 End of Life (weeks) - https://screenshot.googleplex.com/B5PKaOyMPSL Metered network (days) - https://screenshot.googleplex.com/MHL7EbHkjaN Metered network (weeks) - https://screenshot.googleplex.com/XU6FKf9ooCZ No network - https://screenshot.googleplex.com/dXVm4RdDRpj Bug: 1113263 Change-Id: I7d22e09183594d024510a45e797a1c9d0f362169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339480 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Greg Levin <glevin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#795864}
-
Brian Manthos authored
Change-Id: Id7dc42ffdf40842e09e11a1a7434a0e9ed503b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341815 Commit-Queue: Brian Manthos <brianman@microsoft.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795863}
-
Vasilii Sukhanov authored
Tbr: apotapchuk@chromium.org Bug: 1106305 Change-Id: I031bbc3160cb9dc6510b56ccc80773abb0125a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339750Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#795862}
-
Nohemi Fernandez authored
ITP restrictions in iOS 14 may delete Gaia authentication cookies after 30 days of not visiting a site domain. Ensure that the user can be reconnected (with a slight delay) to their account. https://webkit.org/tracking-prevention/ Bug: 1102794 Change-Id: I76252ca07aa43d9df7157efa40c8dee9301f48e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326410 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#795861}
-
Morten Stenshorne authored
LayoutNG block fragmentation is rendering this one correctly, while the legacy engine gets it wrong. Rebaseline overrides for virtual/layout_ng_block_frag/ Bug: 1066625 Change-Id: I4469beca64a50ca36e53cab93e99324d24e1b936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339520 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795860}
-
Alice Wang authored
This CL removes redundant scrolling offset implementation in web sign-in bottom sheet. Bug: 1093795 Change-Id: I2b1e87e56a1b0b62ef237b7dad6c168143294aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333836Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#795859}
-
Francois Beaufort authored
This CL changes MediaSettingsRange and PhotoCapabilities interfaces to dictionaries for logging purposes. This way, web developers will be able to simply call JSON.stringify(myTrack.getCapabilities()). Spec: https://github.com/w3c/mediacapture-image/pull/238 Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/QI8BS5bL5CQ Bug: 934063 Change-Id: I604d3b119b0e3e8bff48d86b87ea4213325b8a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317186Reviewed-by:
Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#795858}
-
Himanshu Jaju authored
- Implements the accept flow for a share request. Todo - PayloadStatusTracker Bug: 1085068 Change-Id: Ife793c110e39995d5484ae5edbd34103b64e69ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332273 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#795857}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e163bc182576..3546945795af 2020-08-07 kprokopenko@google.com [issues] Add affected resource 'blocked' status for CSP issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1082628 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie8e6c4ec3c5c4836efb80a49ab07d919de0b879b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342761Reviewed-by:
-
Kenichi Ishibashi authored
Most tests called LazyInitializeForTest() to make GetNew{Registration,Version,Resource}Id() work. Since these methods now return IDs asynchronously we can call LazyInitialize() inside these methods like other ServiceWorkerStorage methods. This CL changes these getter methods to call LazyInitialize() internally to remove most LazyInitializeForTest() calls. The motivation of this change is not to expose LazyInitializeForTest() as a mojo method. Bug: 1055677 Change-Id: I055e7b9e2872a8e9d2d55de2d9f415d7eee2b864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342537Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795855}
-
Ewann authored
Adding: - Open in New Tab - Open in New Incognito Tab - Open in New Window (if Multi-Window is supported and iPad) - Delete - Edit Bug: 1093302 Change-Id: Id18e46c4119cae3a9d253cea95c62c4764c1c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336085 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#795854}
-
Ehimare Okoyomon authored
Add method that removes unneeded preferences and another that determines the page action to do after data reset. Use both for page info permissions page. Screenshot: https://screenshot.googleplex.com/gdDXORTDkSe.png Bug: 1077766 Change-Id: I3bbb067722d8566f6648c84e4aa264e7707370e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312819Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#795853}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ea70694da8b1..2cc251fd9b34 2020-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bedac4f06b5c to 3831ac2043e4 (14 revisions) 2020-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 69b685d4 to 2acf87cc (445 revisions) 2020-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from be7c55a2a8ce to a202c209bc91 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Test: Test: Test: SimpleStateChangeTestES31.InvalidateThenStorageWriteThenBlendPpoTest: Test: VertexAttributeTestES31.UsePpoComputeShaderToUpdateVertexBuffer Change-Id: I5b113406982e8cb4d950ce8adf66a379c080e664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342755Reviewed-by:
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. Since RequestGenerator runs only in regular mode, using |Profile#getLastUsedRegularProfile| is safe. Note: This is only clean up and does not change any code behaviour. Bug: 1041781, 1075562 Change-Id: Ib536bcd927bf91c2a26fd98e970a54f0446b1f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339740Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#795851}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff9cb9b4ed1b..57fe7caa9699 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: vasilii@google.com Change-Id: I64331be925fcca6ddf1ef42ea785bbec1ae79fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342760Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795850}
-
My Nguyen authored
Clusterfuzz reported Null-dereference READ. Fixed: 1113759 Change-Id: I74a3233ed8d85f7ab5aa1e2157f1bf5fea0f4aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342488 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795849}
-
Javier Ernesto Flores Robles authored
Bug: N/A Change-Id: I5d24e01cc4480190ac7db75535e6ec16b177dd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332714 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
-
Kateryna Prokopenko authored
Doc: https://docs.google.com/document/d/1hmC2R-f2_024I3urdEpKm34V5tSWeIk8MuRts7rggso/edit# Bug: chromium:1082628 Change-Id: I41aa7243473a7e7d4ef6da7fec4cef0336a27ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316098 Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#795847}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5fd92a7e0c84..7b2dd11dda7a 2020-08-06 antonikarp@google.com spirv-fuzz: TransformationReplaceAddSubMulWithCarryingExtended (#3598) 2020-08-06 andreperezmaselco.developer@gmail.com spirv-fuzz: Add TransformationMakeVectorOperationDynamic (#3597) 2020-08-06 andreperezmaselco.developer@gmail.com spirv-fuzz: iterate over blocks in replace linear algebra pass (#3654) 2020-08-06 stefanomil@google.com spirv-fuzz: make outliner pass use additional transformations (#3604) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: Ieeef1b49dc021050fe555b6e9b23aa9e1fbdd51c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342756Reviewed-by:
-
Greg Thompson authored
Metrics show that a big surge of cleanups happened when the code shipped, and that there are now diminishing returns. This reverts commit 6cd33735, modulo histogram definitions. BUG=980487,1097919 Change-Id: Ib47cfbc402e6a73afa36e08209eaf5faa69e6592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340051Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#795845}
-
Maxim Kolosovskiy authored
As password scripts have a confirmation step, we don't need to validate an intent to change a password. We still need to check whether a running script is a password script (if yes, the password manager should be notified that a script is running). For that, we will check whether |TriggerContext| has PASSWORD_CHANGE_USERNAME param. (For convenience, this CL moves that parameter's name and also kOverlayColorsParameterName to trigger_context.cc). This CL also changes what origin is used for password store request. If a password script is started from Settings, GetLastCommittedURL is not set yet. So, we have to use the deep url provided. Bug: 1086109 Change-Id: I7c38388b06f433dc51bce1a2b54a7d48bb322bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332594 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#795844}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3831ac2043e4..3c7f144a738e 2020-08-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from ef36eedb0d09 to aba3ab0ce72f (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ib60a4c24213840b0bcea765fc697ada95d08c599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342759Reviewed-by:
-
Pavol Marko authored
PK11_ListCertsInSlot can return nullptr. One of the cases is that the PKCS#11 token that is backing the slot has been removed. Treat the nullptr return value at all call sites as no certs on the slot. Rationale: This happens e.g. during browsertest shut down. Also, re-enable PlatformKeysServicePerUnavailableTokenBrowserTest which was disabled due to this. Bug: 1109635, 1059434 Test: 400 repetitions of PlatformKeysServicePerUnavailableTokenBrowserTest don't crash Change-Id: I585bd6872ca91e9c10cc9fd49265afbaf414756e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317801Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#795842}
-
arthursonzogni authored
Check what is the reported sourceFile depending on the script's origin. Currently, the full URL isn't exposed in the case of a cross-origin script. This is an issue. See https://crbug.com/1113163 TODO: Add checks with redirects. Bug: 1113163 Change-Id: I8bbd1234a485568127a21c6abfbd4d4a623494f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341125 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#795841}
-
Tanmoy Mollik authored
This cl adds the SyncOffPreference in the ManageSyncSettings page. It also adds "Advanced" category after the Preference. The preference is only shown after the user has signed in. So it is not shown in the advanced sync consent flow. The code for ClearDataProgressDialog from AccountManagementFragment is reused here. Bug: 1092410 Change-Id: I0b70ad5cfc32d4c8325680f9929aaae6ccfca65f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273193 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#795840}
-
Ewann authored
This CL removes icons that are no longer supported. It also updates some icons and add a new safety_check icon. Bug: 1078782 Change-Id: I5ad94555379d850f53190185b997f6115dfd5c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340965Reviewed-by:
-
Renato Silva authored
Make the error message on the login screen more generic. Change the subject of the message from 'password' to 'PIN or password' to be reused for the upcoming PIN auto submit feature. UX Writer Document: http://doc/1dyo1BsQ3o7IyDFGvEgWqH1wiZJlEeUuny1G9IQk2r6M Bug: 663982 Change-Id: Idf8f0363b10a9982bdaec42a345a010bf0388e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339358Reviewed-by:
-
Maksim Moskvitin authored
SecureBoxKeyPair::CreateByPrivateKeyImport() now accepts span<const uint8_t> instead of span<uint8_t> to allow passing const containers. SecureBoxPrivateKey::CreateByImport() now reuses ImportECPrivateKey(), that used to duplicate its logic. This CL is a pure refactoring. Bug: 1101813 Change-Id: Id99edd3f069a7742474a17b73cb5fe69d528eb78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340971 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Andrey Zaytsev authored
* Removed bulk_leak_check_controller_android classes, as they were part of the temporary API for the password check and never actually got used * Used an instance of the PasswordCheck class to manage the lifecycle of the password check in Safety check * Changed the initialization logic to account for the asynchronous availability of the # of saved and compromised passwords * Added logic to block displaying successful states without compromises on fetching the data from disk (# of saved and compromised passwords) * Added unit tests to verify various asynchronous timing scenarios Bug: 1070620 Change-Id: Ia4aee1b06ba820f551a4f66c923174d20b5f8007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336078Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8d4d469c0e498bc61dd8955687f34f208c3981da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342757Reviewed-by:
-
David Jean authored
Force resize of content when the content doesn't detect it by itself. Bug: 1091515, 1073446, 1071811 Change-Id: I1d548c3b11ad95b8c26998cf189b0cdc72095f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339459 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#795834}
-
