GitLab

Bug: None
Change-Id: I619491887eb97abc493debfeaf20ae260c222f33
Reviewed-on: https://chromium-review.googlesource.com/568820Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486147}

This is needed to run Mus in-process until crbug.com/741106 is fixed.

BUG=722527

Review-Url: https://codereview.chromium.org/2978833002
Cr-Commit-Position: refs/heads/master@{#486146}

I am factoring out some code in DropdownPopupWindow.measureContentWidth() that
determines the widest view in a ListView into a helper method in UiUtils so I
can use it for the spell check menu I'm working on in
https://codereview.chromium.org/2931443003.

Bug: 715365
Change-Id: I59bfc348eac62d07c6deb375bca6b808856911dd
Reviewed-on: https://chromium-review.googlesource.com/566594
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486145}

Right now in html canvas 2d's drawImage API, the image decoding are done
on the main thread, and this task could be heavy when the image is big.
What we hope is to give people an option to call createImageBitmap(SVG)
which does the image decoding in a background thread, and then canvas
drawImage API can draw the image bitmap which is already in a decoded
state.

Bug: 580202
Change-Id: I79cfd46b4e2f154e9fde111b932125a9745571a2
Reviewed-on: https://chromium-review.googlesource.com/558398Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486144}

The counters added here are for methods and attributes that take up
a non-trivial portion (4-10%) of time spent doing Blink C++ on some websites
from the v8_top25 benchmark.

Bug: 724543
Change-Id: Idbab1de4b7128a4a934ca22a7b739c2fa5b035bc
Reviewed-on: https://chromium-review.googlesource.com/565682
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486143}

These methods are never called by other classes, no need to mark them public.

Bug: 
Change-Id: I453e5831d60ac2970029c16fdd3011b012120695
Reviewed-on: https://chromium-review.googlesource.com/565963Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486142}

Bug: 713188
Change-Id: If8d923129a063160caaef22d3908f6f5f7aef2bc
Reviewed-on: https://chromium-review.googlesource.com/565446Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486141}

This new Mojo channel connects the profiling process and the browser process. It should be run only when the enable_oop_heap_profiling is enabled, and when run with --memlog.

Fixes a bug on Posix memlog streams because sendmsg is not atomic for large messages.

Various refactoring of the profiling process. The separate IO thread has been removed and the main thread is now the IO thread.

NOPRESUBMIT=true (seems to crash presubmit checks, bug filed)

Change-Id: I93909bb95bfbd10348c0c7d51c80aa44cb26f7aa
Reviewed-on: https://chromium-review.googlesource.com/564157
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486140}

Remove the parameter in ChromeLauncherActivity#launchTabbedMode() because the
function is always called with false

BUG=None

Change-Id: Ia17c3dbcd98c9b30014dedbc85d82ffbe791ac1d
Reviewed-on: https://chromium-review.googlesource.com/565843Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486139}

This CL fixes discrepancies between the histogram names used in LocalNetworkRequestsPageLoadMetricsObserver and the ones registered in histograms.xml. The desired histogram names are the ones present in histograms.xml.

This CL also sets the histogram prefixes in histograms.xml associated with LocalNetworkRequestsPLMO as histogram bases so they are not generated unnecessarily.

BUG=

Change-Id: Ib8370037078f924ec44472f463724025593eb0cc
Reviewed-on: https://chromium-review.googlesource.com/568681Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: U Thakore <uthakore@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486138}

According to the EME spec, during update(), expiration should be updated
before resolving the update() promise.

BUG=730762
TEST=Fixes and enables a test case.

Change-Id: I145f707aee8cbc53413417654282dafe6edc9f28
Reviewed-on: https://chromium-review.googlesource.com/567873Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486137}

BUG=741310

Change-Id: I324c0403af2d351373536897a7f2bc282c870e41
Reviewed-on: https://chromium-review.googlesource.com/568682Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486136}

This matches the behavior of old Options, but it will also show
up an all Polymer WebUI pages using cr-dialog.

Bug: 740771
Change-Id: Ieb5db50b4796264a87be38e01ebfd1f362ff9d39
Reviewed-on: https://chromium-review.googlesource.com/566093Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486135}

Bug: 741709
Change-Id: I7b57cd6bb597d0a28bb32acffe801284d15c9c07
Reviewed-on: https://chromium-review.googlesource.com/568486Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486134}

Some fallout from https://chromium-review.googlesource.com/c/567267

Bug=skia:6836
NOTRY=true
TBR=reed@google.com

Change-Id: Ib30e51f7877ca70c23a8980373b27114608abcfe
Reviewed-on: https://chromium-review.googlesource.com/569007Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486133}

This reverts commit 5ddcccf7.

Reason for revert: Breaks ubsan on clusterfuzz.

Original change's description:
> Roll buildtools to 3d2d34
> 
> This roll includes only a single revision:
> https://chromium.googlesource.com/chromium/buildtools/+/3d2d34dde457f07ca410d1c06f4f3b9063c28643
> 
> TBR=michaelpg@chromium.org
> 
> Bug: 701919
> Change-Id: I2924e4db1cad21ce8aa4c99f5090dea69d53a720
> Reviewed-on: https://chromium-review.googlesource.com/567777
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485860}

TBR=thakis@chromium.org,michaelpg@chromium.org,pcc@chromium.org,thomasanderson@chromium.org

Change-Id: I51fd086f9f486b24727549f385c1238b8d4c39fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 701919, 741604
Reviewed-on: https://chromium-review.googlesource.com/568414Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486132}

When a link is opened in a new tab, the source tab value might be delayed.
This change makes it so that if the source tab id is present, and the task
tracker doesn't have a matching parent id, it will overwrite the tasks for that
tab with the tasks from the source tab.

This fixes the case where the user deliberately opens a link in a new tab
via middle click.

Bug: 707978
Change-Id: I74be1a3527a6cda0187d7eb24477d83b57d2adbe
Reviewed-on: https://chromium-review.googlesource.com/567649
Commit-Queue: Nicolas Zea <zea@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486131}

The new(ish) FileDescriptorWatcher POSIX wrapper automagically maintains
the watch, so don't keep re-creating it.

Also fixes a typo in the name of a constant.

Bug: 
Change-Id: I595ef09575e6079f3aa97f7c31f789ef24f270fc
Reviewed-on: https://chromium-review.googlesource.com/568598Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486130}

When the "Spurious power button window" flag is set to a
nonzero value, additionally log the duration that the tablet
power button was held whenever it's released. This will be
used to gather more information from user tests.

BUG=736936
TEST=enabled the flag and checked
     /home/chronos/user/log/chrome after pressing the power
     button

Change-Id: Ic34e788035323c4493be0d082ff88c8440510275
Reviewed-on: https://chromium-review.googlesource.com/568174Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486129}

Revert of Allow presenting DXGI share handles as overlays. (patchset #5 id:80001 of https://codereview.chromium.org/2968503003/ )

Reason for revert:
On NVIDIA drivers it causes an error -
 [396:4308:0711/184358.172:ERROR:direct_composition_surface_win.cc(640)] Error acquiring keyed mutex: 887a0001

See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.gpu.fyi%2FWin10_Debug__NVIDIA_%2F1504%2F%2B%2Frecipes%2Fsteps%2Fpixel_test_on_NVIDIA_GPU_on_Windows_on_Windows-10%2F0%2Fstdout

Original issue's description:
> Allow presenting DXGI share handles as overlays.
>
> Create a new type of GLImage representing an NV12 DXGI share handle (and
> array level) and support displaying it in an overlay.
>
> BUG=729238
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2968503003
> Cr-Commit-Position: refs/heads/master@{#485701}
> Committed: https://chromium.googlesource.com/chromium/src/+/fc666dc7bc9d5141a6457ee08b0004c705463140

TBR=sunnyps@chromium.org,sandersd@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=729238

Review-Url: https://codereview.chromium.org/2981713002
Cr-Commit-Position: refs/heads/master@{#486128}

Added jamesr, kmarshall, scottmg, sergeyu and wez to OWNERS for
testing/buildbot/filters/fuchsia*.

Change-Id: I02f7a67f46300667fee8be71416f185163fd7d6e
Reviewed-on: https://chromium-review.googlesource.com/568563Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486127}

With these changes it's possible to compile mojo unittests on Fuchsia

Bug: 740791
Change-Id: I6b558a5415d7a11b3fbd3b2711125da14bc5719f
Reviewed-on: https://chromium-review.googlesource.com/566259
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486126}

Serialization of page state can be a cpu intensive process as the serializer
must recursively traverse a tree of iframes. One of the common cases for
serializing navigation entries is Sync, which does not actually use the
encoded page state information.

This CL adds a new SerializationOptions param and support for using it to
exclude the page state when serializing a NavigationEntry, allowing Sync's
tab delegate to bypass encoding the page state.

Bug: 738187
Change-Id: Ib758db83e3f688c7016044e16a9f2818062e1da0
Reviewed-on: https://chromium-review.googlesource.com/560696
Commit-Queue: Nicolas Zea <zea@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486125}

Bug: chromium:689306
Change-Id: I84dafbb5f54c90615f2422a59a1cd14f10394b34
Reviewed-on: https://chromium-review.googlesource.com/568844
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486124}

GeolocationConfig is designed to be used from the chrome/browser.
For now the only method is IsHighAccuracyLocationBeingCaptured, that
indicates if the location is captured with high_accuracy=enabled flag.

BUG=731758

Review-Url: https://codereview.chromium.org/2975683002
Cr-Commit-Position: refs/heads/master@{#486123}

BUG=NONE

Review-Url: https://codereview.chromium.org/2974393002
Cr-Commit-Position: refs/heads/master@{#486122}

Revert of Block redirects to renderer-debug urls. (patchset #11 id:420001 of https://codereview.chromium.org/2973433003/ )

Reason for revert:
Compile error.

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/89468

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLinux_ChromiumOS_Builder__dbg_%2F89468%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

FAILED: obj/content/test/content_browsertests/navigation_handle_impl_browsertest.o
/b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/test/content_browsertests/navigation_handle_impl_browsertest.o.d -DHAS_OUT_OF_PROC_TEST_RUNNER -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"307486-1\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DOS_CHROMEOS -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_GLIBCXX_DEBUG=1 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DGTEST_API_= -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DTOOLKIT_VIEWS=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DPROTOBUF_USE_DLLS -DBORINGSSL_SHARED_LIBRARY -DUSING_V8_SHARED -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSING_V8_SHARED -DUNIT_TEST -DLEVELDB_PLATFORM_CHROMIUM=1 -I../.. -Igen -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_jessie_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/googletest/src/googletest/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/third_party/vulkan -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/mesa/src/include -I../../third_party/libwebm/source -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/nss -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/nspr -Igen -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen/v8/include -I../../third_party/WebKit/Source -I../../third_party/WebKit -Igen/blink -Igen/third_party/WebKit -I../../third_party/libjpeg_turbo -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/ots/include -I../../v8/include -Igen/v8/include -I../../third_party/googletest/custom -I../../third_party/googletest/src/googlemock/include -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/dbus-1.0 -I../../build/linux/debian_jessie_amd64-sysroot/usr/lib/x86_64-linux-gnu/dbus-1.0/include -fno-strict-aliasing -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -fdebug-prefix-map=/b/c/b/linux_chromeos/src=. -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -O0 -fno-omit-frame-pointer -g2 -gsplit-dwarf --sysroot=../../build/linux/debian_jessie_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-header-guard -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.so -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang use-chromium-style-naming -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -c ../../content/browser/frame_host/navigation_handle_impl_browsertest.cc -o obj/content/test/content_browsertests/navigation_handle_impl_browsertest.o
../../content/browser/frame_host/navigation_handle_impl_browsertest.cc:1562:23: error: chosen constructor is explicit in copy-initialization
    std::vector<GURL> redirected_navigation = {};
                      ^                       ~~
../../build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/debug/vector:79:7: note: explicit constructor declared here
      vector(const _Allocator& __a = _Allocator())
      ^
../../content/browser/frame_host/navigation_handle_impl_browsertest.cc:1565:5: error: no type named 'Compare' in the global namespace
    EXPECT_EQ(redirected_navigation, logger.redirected_navigation_urls());
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/googletest/src/googletest/include/gtest/gtest.h:1924:63: note: expanded from macro 'EXPECT_EQ'
                      EqHelper<GTEST_IS_NULL_LITERAL_(val1)>::Compare, \
                                                            ~~^
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:162:23: note: expanded from macro 'EXPECT_PRED_FORMAT2'
  GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
                      ^~~~~~~~~~~
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:147:17: note: expanded from macro 'GTEST_PRED_FORMAT2_'
  GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \
                ^~~~~~~~~~~
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:77:52: note: expanded from macro 'GTEST_ASSERT_'
  if (const ::testing::AssertionResult gtest_ar = (expression)) \
                                                   ^~~~~~~~~~
../../content/browser/frame_host/navigation_handle_impl_browsertest.cc:1565:5: error: expected ')'
../../third_party/googletest/src/googletest/include/gtest/gtest.h:1923:3: note: expanded from macro 'EXPECT_EQ'
  EXPECT_PRED_FORMAT2(::testing::internal:: \
  ^
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:162:3: note: expanded from macro 'EXPECT_PRED_FORMAT2'
  GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
  ^
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:147:29: note: expanded from macro 'GTEST_PRED_FORMAT2_'
  GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \
                            ^
<scratch space>:36:1: note: expanded from here
"redirected_navigation"
^
../../content/browser/frame_host/navigation_handle_impl_browsertest.cc:1565:5: note: to match this '('
../../third_party/googletest/src/googletest/include/gtest/gtest.h:1923:3: note: expanded from macro 'EXPECT_EQ'
  EXPECT_PRED_FORMAT2(::testing::internal:: \
  ^
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:162:3: note: expanded from macro 'EXPECT_PRED_FORMAT2'
  GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
  ^
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:147:28: note: expanded from macro 'GTEST_PRED_FORMAT2_'
  GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \
                           ^
3 errors generated.

Original issue's description:
> Block redirects to renderer-debug urls.
>
> Redirects toward renderer-debug urls (chrome://crash, javascript:[...],
> ...) were not expected to happen in the NavigationHandleImpl. It caused
> WebContentsObserver::DidFinishNavigation not being called and
> consequently, bugs in some WebContentsObservers.
>
> This CL blocks any redirects to renderer-debug urls. One test is added.
>
> The blocking of the URL was moved (and partially removed?) in:
> https://crrev.com/2436253002
> This CL tries to restore the previous behavior.
>
> BUG=728398
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel
>
> Review-Url: https://codereview.chromium.org/2973433003
> Cr-Commit-Position: refs/heads/master@{#486091}
> Committed: https://chromium.googlesource.com/chromium/src/+/b980b4b5d4408bea7e83cbf1f70e7143edb41716

TBR=clamy@chromium.org,mmenke@chromium.org,creis@chromium.org,mkwst@chromium.org,csharrison@chromium.org,arthursonzogni@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=728398

Review-Url: https://codereview.chromium.org/2982623002
Cr-Commit-Position: refs/heads/master@{#486121}

This tracks the time from when UI is shown to user after sign in to
when the user activates first ARC app.

TEST=Manually on device
BUG=b/63276467

For minor changes in c/b/ui/app_list/
TBR=xiyuan@chromium.org

Change-Id: If77dbcba01e0d17dd702887c22e60706f7311928
Reviewed-on: https://chromium-review.googlesource.com/563479
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486120}

Mac's "Open in Preview" is treated as a local printer in the C++
handler. Always treat it as a local printer in print_preview.js as well
so that the "print" promise resolution correctly closes the dialog and
prompts Preview to open.

BUG=741341,741528

Change-Id: I831df003019274edecf73172ef1e06bd6ebc960e
Reviewed-on: https://chromium-review.googlesource.com/568239Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486119}

BUG=727616

Change-Id: I0d8843c34d82a99ef815cab090b0c08ff7065c7c
Reviewed-on: https://chromium-review.googlesource.com/564180Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486118}

HQP currently shares a FormatUrl call between the match.fill_into_edit
and match.contents calls.

This is no longer appropriate given that the path may be elided. Per
discussions with pkasting, none of the destructive elisions should
be applied to the match.fill_into_edit fields.

Bug: 732582
Change-Id: I91b1181edaa2d3b9f150a9313951bf6ff59103a4
Reviewed-on: https://chromium-review.googlesource.com/567236Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486117}

This is a reland of 7fa78bb0
Original change's description:
> Add memory UKMs for existing UMA metrics.
> 
> Bug: 730783, 728707
> Change-Id: I744c73d36ca76d97eff1e202fa20ba5d4a9adb7b
> Reviewed-on: https://chromium-review.googlesource.com/531804
> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485159}

Bug: 730783, 728707
Change-Id: I314ecfa620bbd317e2cd4164279eb86a2248bbfb
Reviewed-on: https://chromium-review.googlesource.com/567220Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486116}

This is an old hack to preserve behavior of certain tests. These tests
have since been fixed to not rely on this. Get rid of it and just call
UpdateAnimationsAndScheduleFrameIfNeeded(...) instead to schedule the
first frame just like any other.

BUG=726362

Change-Id: I1ff2673a8d4b71ea237a2902f10599e08bcfb7d6
Reviewed-on: https://chromium-review.googlesource.com/564608Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#486115}

This also changes the timing with which startup metrics are recorded: Previously they were recorded ~45 seconds after startup; now they're recorded whenever the TaskScheduler schedules them to be.  This is not expected to change the values recorded to these metrics.

BUG=667892, 741816
TEST=none
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2955063005
Cr-Commit-Position: refs/heads/master@{#486114}

In our current implementation, the histogram timer in the above function
doesn't account for the time that spends on decoding the source image.
That part of time can be significant for some image sources like SVG.

This CL fixes the timer to include the image source decoding time.

Bug: None
Change-Id: Ic7a09ed1ec5524870d2bb64d4cd01dbfd05a7dac
Reviewed-on: https://chromium-review.googlesource.com/563778Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486113}

Some try bots have been timed out on this test. Reduced the thread
count to avoid such failure. (2500 -> 1000)

Bug: 741699
Change-Id: Iec63bd67c991d43932803b734826d6d385e5cc03
Reviewed-on: https://chromium-review.googlesource.com/568586Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486112}

BUG=736375

Change-Id: I73c225fed86f536074f6886d22f9a65e43fcde3e
Reviewed-on: https://chromium-review.googlesource.com/567495
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486111}

See https://skia-review.googlesource.com/c/22721

NOTRY=True

Bug: Skia:6828
Change-Id: I7c98d62c3453a142a64a3e7fc31a814c4292142a
Reviewed-on: https://chromium-review.googlesource.com/568838
Commit-Queue: Mike Reed <reed@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486110}

On the NTP, the app menu button now remains visible. On regular new
tabs, the menu options are "New incognito tab", "Recent tabs",
"Settings", and "Help & feedback". On incognito new tabs, the menu
options are "New tab", "Settings", and "Help & feedback".

BUG=734123,695973

Change-Id: I38b3b4e8dbf5cc4a6a62f98bf6dfd6a5d2f4a905
Reviewed-on: https://chromium-review.googlesource.com/560538
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486109}

Names don't need to say net:: when already inside the namespace.

Bug: none
Change-Id: I11972d69236f22848a39bb86b2b1845c26a78a4c
Reviewed-on: https://chromium-review.googlesource.com/566065Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486108}