- 07 Mar, 2019 37 commits
-
-
John Abd-El-Malek authored
Bug: 937803 Change-Id: I68cc01cf8c2a6f5bd5232f2c3f4296352ef181d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507193 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#638384}
-
Scott Violet authored
The histogram is logged any time the user resizes a window via mouse/touch. The delta is the time between when the resize started, and when the next frame was presented (pixels painted on screen). This doesn't cover some cases (such as tablet-mode resizing) but is a good start. BUG=none TEST=covered by tests Change-Id: I509a34203f76c198f3135a8cb386a0b11e20c90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495377 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#638383}
-
Tom Anderson authored
The issue is that |msg_iov| and |msgvec| use std::vector as the underlying container, but the usage of the container is something like: msg_iov.reserve(kWriteAsyncMaxBuffersThreshold + 1); msg_iov[0].field = ...; // Access an element that doesn't yet exist. This CL changes the usage to msg_iov->push_back(...) so that the underlying vector updates its size and operator[] will work. This is necessary to fix the build with _LIBCPP_DEBUG=0. Otherwise we get errors of the form: buildtools/third_party/libc++/trunk/include/vector:1542: _LIBCPP_ASSERT '__n < size()' failed. vector[] index out of bounds BUG=923166 R=davidben Change-Id: I364be618011c4c0e65627e530dde9e6dc3f7375f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506384 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#638382}
-
Robert Ma authored
Mostly about a cross-origin test. See the linked bug for details. TBR=foolip No-Try: True Bug: 939181 Change-Id: Id970e97379073fe878dc19d1eb0200479fded894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507246Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#638381}
-
Hayato Ito authored
Remove TreeScopeEventContext::Create and use MakeGarbageCollected at caller side. Change-Id: I7ea353ab29dfb28e1b274a534eea567de8e782a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504487 Auto-Submit: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#638380}
-
Alex Danilo authored
Change https://chromium-review.googlesource.com/c/chromium/src/+/1491736 adds a test that uses the gear menu to select files in the main FilesApp list view. This change simplifies the unit test to use Ctrl-A to select which is simpler and decouples the test from behavior of the gear menu. Bug: 935345 Tests: Changed integration test and checked it still works. Change-Id: I5e52209d2d9e7ae383b6b5bcb87266f2f2459fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504595 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#638379}
-
Josh Nohle authored
In the CryptAuth v2 Enrollment flow, a key derivation function (HKDF) is needed for symmetric key generation and symmetric key proof computation. The v2 Enrollment protocol specifies that the "info" input parameter to HKDF should be the key bundle name, e.g. "PublicKey" or "authzen"; however, we were previously using the key handle. We verified this through manual testing. Bug: 899080 Change-Id: I31e6d5d4aba819f17b960744bd70f80c07ea9867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504310 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#638378}
-
Nektarios Paisios authored
Also ensures that an empty annotation will set the appropriate status Bug: 905419 TBR: nasko@chromium.org Change-Id: I09eb4ddc6489f015ff137564c89cbc88328e80cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506373 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#638377}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61a1b5f31059..48f640f5365e git log 61a1b5f31059..48f640f5365e --date=short --no-merges --format='%ad %ae %s' 2019-03-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@48f640f5365e The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia75a46bd678e86bd089f0b572085de4820c045c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506609Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638376}
-
Scott Violet authored
If the server changes the bounds, we should not consult the delegate to enforce the min/max size. To do othewise means the server and client are not in sync with the bounds. In classic mode, bounds changes done directly to the aura::Window don't flow through the min/max either. This effectively gives that behavior. BUG=938548 TEST=covered by test Change-Id: I8d898365fc9e949e4d68758575d0337deff339a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506879Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#638375}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b47470daa737..1cc386687cde git log b47470daa737..1cc386687cde --date=short --no-merges --format='%ad %ae %s' 2019-03-06 enga@chromium.org Move CreateFence from Device to Queue Created with: gclient setdep -r src/third_party/dawn@1cc386687cde The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I06be864d30adc32e7fb93f5cf64f14d29c855ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506608Reviewed-by:
-
Oksana Zhuravlova authored
This change adds a link to 'Receiving responses' section in C++ reference and updates the link to the IPC to Mojo conversion page. Change-Id: I91316b16d9ca2ed51518ebe9671849b4c13ce8f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506610Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638373}
-
Pedro Amaral authored
Introduces a new root MVC component for bottom controls UI. This component has a composited component to allow the bottom controls to be scrolled offscreen. Currently only the split toolbar lives in the bottom controls component but soon tab groups bottom toobar will also live there. Change-Id: I2070301da2faf6a2182dacf0a75b66b2bd97e61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496599 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#638372}
-
Dan Beam authored
Screenshot: https://imgur.com/a/REuT5VD R=hcarmona@chromium.org BUG=926658 Change-Id: I7ec299554e136a7fd7a948bbeadba73b0af829d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506479 Commit-Queue: Dan Beam (slow; perfing) <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Auto-Submit: Dan Beam (slow; perfing) <dbeam@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#638371}
-
Greg Kerr authored
This calls the modern UnmountEx method in cryptohome instead of the deprecated Unmount method. Bug: 811551 Change-Id: I262b3b29eaf2dba969c95f9d0a7cfc70468f4f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464453Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638370}
-
Aga Wronska authored
Instead of enabling lock screen authentication, store info about local overrides in a pref and pass it to UsageTimeLimitProccessor to calculate state. That way local override is preserved in-between the sessions and works consistently with remote overrides. Bug: 911326 Test: UsageTimeLimitProcessorTest Change-Id: I8135a2093f805188dd75b48d10c5c1a8aac1c711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497611 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638369}
-
Pete Williamson authored
Bug: 939037 Change-Id: I41ba9332d7a52921cd61d49bda105d66dda52f1d TBR: rockot@chromium.org Change-Id: I41ba9332d7a52921cd61d49bda105d66dda52f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506878 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#638368}
-
Becky Zhou authored
Bug: 936983 Change-Id: Iea620167cd0885da55b36ccd0a74e6405c7565bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506106Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638367}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/07f80c4df1b0..a2ef7be242bc git log 07f80c4df1b0..a2ef7be242bc --date=short --no-merges --format='%ad %ae %s' 2019-03-06 fjhenigman@users.noreply.github.com Add Linux ASAN bot configs. (#2427) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@a2ef7be242bc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iffffd9b79247600577b3656afb6d1c3f644d46bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505902Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f094bac94992..14126505b237 git log f094bac94992..14126505b237 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 jmadill@chromium.org Revert "Use a constexpr array for es3 copy conversion table." 2019-03-06 cwallez@chromium.org Revert "Allow enabling trace annotations" 2019-03-06 jmadill@chromium.org Disable non-conformant configs on official builds. 2019-03-06 syoussefi@chromium.org Vulkan: Decouple EGLSync from renderer serial 2019-03-06 syoussefi@chromium.org Vulkan: shave off 60 bytes from AttachmentOpsArray 2019-03-05 courtneygo@google.com Fix scoped trace events 2019-03-05 syoussefi@chromium.org Add Orientation and Starter-Projects docs 2019-03-05 jmadill@chromium.org Use a constexpr array for es3 copy conversion table. 2019-03-05 jmadill@chromium.org Add glmark2 to build. Created with: gclient setdep -r src/third_party/angle@14126505b237 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ic68a7f10cd056ea6d1659ee4e9fa9087bf2ec3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505900Reviewed-by:
-
Juan Antonio Navarro Perez authored
Graduating these out of experimental folder in catapult. Bug: 922030 Change-Id: I3ac3679f865aa4f409c96608348cf65d6941f82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494880Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#638364}
-
Peter Williamson authored
This reverts commit 08c128cd. Reason for revert: Reverterd on suspicion of causing build failures on Mac 10.11 TBR: carlosil@chromium.org failures: SSLClientSocketReadTest.Read/1 SSLClientSocketReadTest.Read/0 HTTPSEVCRLSetTest.FreshCRLSetNotCovered WebSocketEndToEndTest.BasicSmokeTest SSLClientSocketReadTest.DumpMemoryStats/0 SSLClientSocketReadTest.DumpMemoryStats/1 URLRequestTestFTP.FTPCheckWrongUser WebSocketEndToEndTest.TruncatedResponse WebSocketEndToEndTest.HstsWebSocketToWebSocket WebSocketEndToEndTest.TrailingWhitespace HTTPSOCSPTest.IntermediateResponseTooOld URLRequestTestFTP.FTPCheckWrongUserRestart URLRequestTestFTP.FTPCheckWrongPasswordRestart HTTPSOCSPTest.Revoked HTTPSFallbackTest.TLSv1_1NoFallback HTTPSFallbackTest.TLSv1_3Interference URLRequestTestFTP.FTPCheckWrongPassword WebSocketEndToEndTest.HeaderContinuations HTTPSCRLSetTest.ExpiredCRLSetAndRevoked HTTPSEVCRLSetTest.FreshCRLSetCovered SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/1 SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/0 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/18 HTTPSOCSPTest.Valid HTTPSEVCRLSetTest.ExpiredCRLSet OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/12 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/13 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/10 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/11 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/16 … 70 more (100 total) … Original change's description: > Refactor SSLCertificateErrorPageController > > SSLCertificateErrorPageController is no longer only used on SSL errors, > renamed it to SecurityInterstitialErrorPageController, and removed the > net::Error code passed to EnablePageHelperFunctions since it's no > longer used. > > Bug: 910794 > Change-Id: I718e0fcbcb2643cb0c47818dda1f317aef4e75cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503910 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Carlos IL <carlosil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638232} TBR=sky@chromium.org,mmenke@chromium.org,carlosil@chromium.org Change-Id: I39489effa3e0029b5ff65f5bc9cbd991aef1ddea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507039Reviewed-by:
-
Sajjad Mirza authored
This is a reland of 6b7213a4 Original change's description: > Adding an exclusion list to the coverage wrapper script. > > The script now assumes GN adds coverage flags to the cflags for each > source file. The script removes the flag if the file is in an exclusion > list, or if `--files-to-instrument` is set it will also remove flags if > the file is not listed in that argument. > > The script supports multiple exclusion lists that can be selected with > the `--target-os` flag. > > It's expected that GN will set these flags correctly and invoke the > script in all coverage builds. http://crrev.com/c/1496002 does that. > > > Bug: 918215 > Change-Id: I4454f67067a083581f31a22cfef85368825789f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495994 > Commit-Queue: Sajjad Mirza <sajjadm@google.com> > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637892} Bug: 918215 Change-Id: I1254d288ff263ff94c46b46e6be99738e31b9574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506974Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@google.com> Cr-Commit-Position: refs/heads/master@{#638362}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ab64c504cf5..b9c4c2512141 Created with: gclient setdep -r src-internal@b9c4c2512141 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:936957 TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: Ifab15f85eb4ff18ae228a0f4ade6c945a042ad20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505899Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638361}
-
Alex Moshchuk authored
Previously, isolated origins would apply globally for all profiles in the entire browser. This CL introduces support for associating isolated origins with specific BrowserContexts (i.e., profiles): 1. The API for adding new isolated origins, ChildProcessSecurityPolicyImpl::AddIsolatedOrigins(), can now take a BrowserContext in which the origin should apply. 2. Entries in the map of isolated origins are extended to optionally contain the BrowserContext to which they apply. If this is not specified, the corresponding isolated origin still applies globally to all profiles. To facilitate checks on the IO thread, the ResourceContext (BrowserContext's representation on the IO thread) is also stored in the entry. 3. IsolationContext now also carries profile information (as BrowserOrResourceContext), and GetMatchingIsolatedOrigin() consults it to see if the profiles match when looking for matching isolated origins. Various tests are updated to pass a proper BrowserContext to the IsolationContexts they construct. Bug: 905513 Change-Id: Iad1fd2ca4ea701f9e088d30fa1b8582de9fbed67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497794 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#638360}
-
Li Lin authored
Bug: b:124796759 Test: Manual Change-Id: I197f984578e9f80096ada1701e0399058bf9e848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480726Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638359}
-
Nigel Tao authored
Previously, the plan was to re-use the low bits of the IconKey.u_key to represent icon post-processing effects such as desaturation to gray. On further thought, we would also like to apply such effects to IconKeys that already use the u_key to represent a resource ID, and do not use an IncrementingIconKeyFactory. It is therefore clearer to have an explicit field for icon effects. In this commit, this new field is always zero. A follow-up commit will use non-zero values. BUG=826982 Change-Id: I6453a648ed2608a2af59d0d01e1fe9bf4af5c90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505741Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638358}
-
Peter Wen authored
- This is the first step in converting autofill_assistant to a DFM. - Create a new //chrome/android/features/autofill_assistant:java target that includes almost all files that used to be under org.chromium.chrome.browser.autofill_assistant.*. - Create separate strings and resources targets. - Split out instrumentation test code. - Add the resulting target to chrome_all_java. - Due to a dependency from CustomTabs, this move excludes: - AutofillAssistantClient.java - AutofillAssistantFacade.java - AutofillAssistantMetrics.java - AutofillAssistantPreferencesUtil.java Tbr: Just moving existing DEPS into a new DEPS file Bug: 846440,922053 Change-Id: I0ee13a75f5f0ce59496e924bcc8e54ef6e960957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499720Reviewed-by:Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638357}
-
Siye Liu authored
This CL fixes two issues with the TSF support on windows. 1. Add TS_SS_TRANSITORY flag to the return value of TsfTextStore::GetStatus. By adding the flag, Korean reconversion feature is disabled. User can only do conversion during composition. Editing frameworks may not support Korean reconversion by design. 2. Fix Japanese IME implicit commit on draft.js framework. Editing frameworks like draft.js may manage their own selection during composition. We should not set selection after inserting composition text during composition. Bug: 657623 Change-Id: Ic9fb3d9187b2a1228807b15132e20e3227bf1de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504035 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#638356}
-
Owen Min authored
With policy enabled, component cloud policies use POLICY_SOURCE_PRIORITY_CLOUD instead to override platform policies that have same scope. Bug: 749530 Change-Id: I7d53034073ebd24034fb3c0dfe7034229d683089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489902 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#638355}
-
Ken Rockot authored
This type is an internal dependency of Mojo bindings and nested enum definitions are currently broken in JS lite bindings. Work around that by pulling this enum out of SerializedHandle. Bug: 939078 Change-Id: I9be1737a6271201d9b56a1cb69d6018e26514b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506767 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638354}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3df5c7cf7b58..a07afc58f2d7 git log 3df5c7cf7b58..a07afc58f2d7 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 tsepez@chromium.org Fix lookahead check in CFGAS_FormatString::GetNumericFormat(). Created with: gclient setdep -r src/third_party/pdfium@a07afc58f2d7 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:938626 TBR=dsinclair@chromium.org Change-Id: Ib5903f320f3cb33ac354420058f13300527f562b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506607Reviewed-by:
-
Jérôme Lebel authored
Some of the code were using TableViewImageCell.textLabel, without compiler errors, since UITableView.textLabel exists. To avoid any errors, titleLabel is renamed into textLabel. Bug introduced: crrev.com/c/1478795 Change-Id: I5c07d31565d7c23a212a44103371a311ef327e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503575Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638352}
-
Varun Khaneja authored
Functionally, this is a NO-OP but it does simplify the code and eliminates the NOT_SENT_MISSING_WEB_CONTENTS scenario. R=drubery Bug: 938559,907280 Change-Id: Ifd3e27b865df97aa07d5a1b7653cd0f01910454a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504958Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638351}
-
Daniel Murphy authored
This is a reland of 1bc0f674 Original change's description: > [IndexedDB] Moving IDBDatabase's PendingConnection to use ScopesLockManager > > This allows scopes to be used in the DeleteDatabase call, and cleans up > some code in the IndexedDBDatabase class. > > The last part of the codebase that doesn't have locks before being used > is the IndexedDBBackingStore::Initialize call. Since this happens on the > opening of the database, this can probably use just the raw database + > a WriteBatch. > > Bug: 862456 > Change-Id: I89c79ec89a4450e21f1ee700b007ec867b3a4f48 > Reviewed-on: https://chromium-review.googlesource.com/c/1478391 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Chase Phillips <cmp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634358} Bug: 862456 Change-Id: I821c28b93fde903678737d49eaeb44c1b7369e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506552Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#638350}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9584fe43a9c2..2c25b14c34c1 git log 9584fe43a9c2..2c25b14c34c1 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 chrisforbes@google.com Implement GetPhysicalDeviceSparseImageFormatProperties Created with: gclient setdep -r src/third_party/swiftshader@2c25b14c34c1 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/118429780 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ice50ccffd1bc0d3cb54e1d8d1659183aa6785d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506692Reviewed-by:
-
Yulun Wu authored
Improper use of GetLsbReleaseBoard() is tracked here: https://bugs.chromium.org/p/chromium/issues/detail?id=938738 Bug: b:120050686 Change-Id: I386fff94be6350ce9ae80e4891251e92d31fb92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501760Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#638348}
-
- 06 Mar, 2019 3 commits
-
-
Mei Liang authored
The CL only caches the TabGroupAndroid feature flag for devices that are eligible for tab group. Bug: 934557 Change-Id: I200bd417e60897c39675eb80b37abbe610e957df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501912 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638347}
-
Jinsuk Kim authored
The RTL property can be obtained dynamically from Tab's title. This CL updates a single callsite so that Tab doesn't have to manage the property. Bug: 925242 Change-Id: Ia9e55818b1f07e320337da4c7991a344c88b1b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501894Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Tom Anderson authored
Change necessary to fix Windows build: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+/417a7dee1c4653bd3a4753710a84c8fd356ba7d9 Change necessary to fix _LIBCPP_DEBUG=1 build: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+/9ae8fb4a3c5fef4e9d41e97bbd9397a412932ab0 Full changelist: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/22d3f6dd25e5efc59124ba1c00b8f98b14be4201..9ae8fb4a3c5fef4e9d41e97bbd9397a412932ab0 BUG=801780,923166 R=thakis Change-Id: Ib4d81c9a756d84fb2e7b0d5912c3cea493728608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506566 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638345}
-
