- 03 Jun, 2020 40 commits
-
-
Alex Moshchuk authored
This CL follows up on the session history changes in https://chromium-review.googlesource.com/c/chromium/src/+/2181973. Prior to that CL, inactive frames or frames with no FrameNavigationEntry returned early from FindFramesToNavigate(), without recursing down into subframes. After that CL, we will now recurse into subframes and keep looking for navigations in those cases. This is harmless, since an inactive frame's children should all be inactive as well, and subframes of a frame with no FNE also won't have FNEs, but it's also redundant. This CL modifies the new flow through DetermineActionForHistoryNavigation() to match the old behavior and stop looking for navigations in subframes in those cases. Bug: 705550 Change-Id: Ida707fc9e108f7102b26cf4e44f4d9761e7dd7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225353 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#774702}
-
Nazih Almalki authored
Ack a pending surface early the client's scheduler to schedule frames or future surface changes This case happens when screen rotation takes place while there is an active frame when this takes place it has a unique signature of 2 consecutive submit frame requests with clients_needs_begin_frame_ is set (high) and 1st frame is not a new surface and 2nd frame is a new surface. Earlier review: https://chromium-review.googlesource.com/c/chromium/src/+/2222918 Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1060058 Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1087865 Change-Id: I6707d264064d16357a0ffe5bdfe5521a7e903bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222803Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Nazih Almalki <nalmalki@google.com> Cr-Commit-Position: refs/heads/master@{#774701}
-
Elly Fong-Jones authored
Presently, BubbleDialogDelegate is a WidgetObserver, and observes both its anchor widget and its own widget for various events. There is a problem with this: subclasses are unintentionally abusing the fact that BubbleDialogDelegate is a WidgetObserver to observe changes to either the anchor widget or the bubble widget. Very few of these subclasses: * Are aware that BubbleDialogDelegate actually observes multiple widgets * Are aware of the intricacies of when BubbleDialogDelegate starts & stops observing widgets * Bother to call the BubbleDialogDelegate implementations of the WidgetObserver methods from their overrides Change-Id: I9de0d1429431f33e80b564ad3e545c976d141a7e Bug: 1011446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227054 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#774700}
-
cfredric authored
Bug: 973801 Change-Id: Ibc35f2e986fd9f9ed13a720a4c275aff132a4b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226773Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#774699}
-
Dan Harrington authored
We need to pick the action upload endpoint based on the Chrome channel. While I was here, I refactored some code to hopefully make it more clear. There was one actual improvement: we were needlessly copying the request body before gzipping it. See b/156953207 for some additional information about the api endpoint. Bug: 1044139 Change-Id: I7ddac54abca3471d68dfffb080ede929ad178848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222801Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#774698}
-
Dominic Mazzoni authored
Previously, in order to do a hit test for accessibility we'd send an action to the renderer with the x,y coordinates, and the renderer would fire an accessibility event on the matching node. It'd be more flexible if we had an API that could do a hit test and call a callback function with the result. That eliminates the need for keeping track of requests and matching them up with events. This patch refactors the way hit testing works so that a hit testing request may contain a request for an accessibility event to fire, or a callback function to call, or both. Existing tests are extended to cover both mechanisms. Bug: 1083834 Change-Id: Idb4c1f302361a0eb6d6344bcee9da7f086caf3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209630Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774697}
-
haozhe authored
Directly accessing iteration_duration is unsafe since it is an optional timing property. Instead, this patch uses a getter function, which has the necessary safeguards to prevent nullpot dereferencing. Bug: 1084547 Change-Id: I617dfa8af9aee02253386ea9ee26934760a02cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225511 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#774696}
-
Jonathan Ross authored
The current suppression for tex-2d-rgb-rgb-unsigned_byte was only for non-angle. However the test also flakes on angle. This updates the suppression to reflect that. TBR=kbr@chromium.org TEST=conformance/textures/image_bitmap_from_video/tex-2d-rgb-rgb-unsigned_byte.html webgl_conformance_tests Bug:834933 Change-Id: I170c6c4cae5c0ba039b7505d4b4f5461f9774591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229238Reviewed-by:
-
François Doray authored
This reverts commit e1f9cdbe. Reason for revert: https://crbug.com/943668#c14 Original change's description: > Third reland of Add LayoutInstabilityTest.OOPIFSubframeWeighting. > > Refactor test to focus on subframe; print window width/height. > > Bug: 943668 > Change-Id: I28f9c66350f709fa792b242334d117255c36dc1e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227184 > Reviewed-by: Steve Kobes <skobes@chromium.org> > Commit-Queue: Annie Sullivan <sullivan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774591} TBR=sullivan@chromium.org,skobes@chromium.org Change-Id: I2c3747481e371bd918eb69a0983bae35939df50c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 943668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227864Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#774694}
-
Victor Fei authored
The motivation behind this change is that for content like below, Windows Narrator cannot trigger the links in the tabs. <div role="tablist"> <a href="https://twitter.com" role="tab">tab1</a> <a href="https://wikipedia.org" role="tab">tab2</a> <a href="https://w3.org" role="tab">tab3</a> </div> This is because for single-selection container we have the behavior that selection follows focus. https://www.w3.org/TR/wai-aria-practices-1.1/#kbd_selection_follows_focus In Item Navigation, Narrator sets focus first to the tab, but upon focus the a11y selected state is set to true. When Narrator attempts to perform ISelectionItemProvider::Select (Enter) on the tab to trigger the link, no action would occur because the selected state is already set to true. This CL fixes UIA::ISelectionItemProvider::Select() to still perform action::kDoDefault if the element is already selected due to focus. Previously, if an element is already selected, for any reason, Select() would not perform any a11y action. This CL also introduces ax::mojom::BoolAttribute::kSelectedFromFocus and uses it to communicate between renderer process and browser process that an element is selected due to it being focused. This CL should not affect ISelectionItemProvider::Select() behavior on multiselectable containers. AX-Relnotes: Windows Narrator can now trigger default action on an element in a single-selection container such as a tabitem. Bug: 847971 Change-Id: I12026b37ed25b867384895eb520eba658aad6f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219155Reviewed-by:Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774693}
-
Yue Zhang authored
Currently, when the activity is destroyed and re-created due to dark/light mode switching, the TabModelSelectorTabObserver in TabGroupUiMediator is not properly destroyed. This CL fixes this issue by destroying it when tab is detached from activity. Bug: 1087826 Change-Id: Ia11138923cb9d4e16e2ce35db18ca74afa50412f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227890Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#774692}
-
Javier Ernesto Flores Robles authored
Bug: 1084033 Change-Id: Ibb7ea1e93b61325ae45360be09aba036f8c6158d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226852Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#774691}
-
Thomas Lukaszewicz authored
Removed the need for set_owned_by_client() in EditingHandleView. Fixed ownership semantics for the Widget holding EditingHandleViews to eliminate the use of WIDGET_OWNS_NATIVE_WIDGET. Currently this ownership model is aimed primarily at enabling easier testing and is in the process of being removed. Bug: 1044687 Change-Id: I51861ca2d9f2a505d86f92fe208868a562f585b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218502 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774690}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fae05624ec66..341434e4da2c 2020-06-03 olka@webrtc.org Revert "Added mid to error messages reported during SDP apply." 2020-06-03 danilchap@webrtc.org Delete field trial WebRTC-GenericDescriptor 2020-06-03 danilchap@webrtc.org Add unittests to validate scalability structures without encoder 2020-06-03 peah@webrtc.org Reland "Change to using the new Ooura constructor" 2020-06-03 yura.yaroshevich@gmail.com Added mid to error messages reported during SDP apply. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3424674a2c86d183bca36fa60ed9f8be15aee745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229145Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774689}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/724a60fb10c7..c9201dd611b0 2020-06-03 jophba@chromium.org Move std::chrono using statements to util/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ia432186a099f5c5ef1b4a7ad7e8f76511ced3df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229143Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fb2bd34e2d92..84515482ba9a 2020-06-03 treehugger-gerrit@google.com Merge "tp: metatrace parser: fix counter track names" 2020-06-03 fmayer@google.com Merge "Do not associate incorrect symbol_set_id." 2020-06-03 simonmacm@google.com Merge "Determine an overall view of when any wakelock was held by merging slices." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I944599cbe64b3817996c76cc0bb269a8b4deeca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229259Reviewed-by:
-
Philip Rogers authored
Based on early results in dev/canary[1], this feature is looking promising and we would like to continue this experiment in Beta. To unblock that we are enabling this experiment for the perf bots now to get more data on the impact. [1] Canary/dev UMA data: https://uma.googleplex.com/p/chrome/variations/?sid=1aeb80b2fff1543c20033559d40b2917 Bug: 1079418 Change-Id: I09573cb89e969970bd172c82ffcf83cbbecc6791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228999 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Crops the screenshot captured for the Maps_maps GPU pixel test before comparison. This should prevent the issue we're running into where the white space around the part of the image we care about is inconsistent. TBR=kbr@chromium.org Bug: 1090518 Change-Id: I1e83afc52e2843dad33e7853bae4dcaaa634b7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227119Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#774685}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c042e00faa0e..2a1801d336fc 2020-06-03 patrick.brosset@microsoft.com Make the grid gap hatch and background colors independent If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I506215a21c9307e955df0c9e194f4dadaeaccbcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229146Reviewed-by:
-
Juanmi Huertas authored
According to comment below in line 787, this method expects the canvas resource provider to provide always GPU resources. This also currently passes all the existing tests, so it's probably safe to remove this fallback. Bug: 1035589 Change-Id: I82a426d29a8a37755ee36d2a14f006bd62fa5bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225479Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#774683}
-
Francois Doray authored
TBR=fdoray@chromium.org Bug: 1081908 Change-Id: I81a9cdf75492a8b3c00eaa7e6654452b4b0dff90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228980Reviewed-by:
-
Sujie Zhu authored
addNewCreditCard creates a credit card without nickname. updateExistingCreditCard will add a nickname to this card. Bug: 1082013 Change-Id: I0e333f55552481070437777d40e1376a6f10404e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226088Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#774681}
-
Etienne Bergeron authored
R=gab@chromium.org,eseckler@chromium.org Bug: 1082916 Change-Id: Ie0f50d29df84b360ecc7a556bcbaea5801b73f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225245 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#774680}
-
Pavel Feldman authored
Bug: 1090797 Change-Id: I53bb57df832253aab581f448ea8c773e0107b579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226298Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Auto-Submit: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774679}
-
Mugdha Lakhani authored
Bug: 1057771 Change-Id: Idc0e96fca215cc847a30e942017aa13c55a429b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226751Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I817671dad2c387b3324e6bdc5c3c6d3933e70ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228134Reviewed-by:
-
Daniel McArdle authored
Bug: 1052476 Change-Id: I6cd83d21b574c475ce867bfb818cf2d9c424ec85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202337 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#774676}
-
nancylingwang@google.com authored
Sometimes the browser is removed first, and the tab close callback OnTabClosing is not called (e.g. launch media apps in browser, then shutdown), so the tab windows are not removed from browser_window_to_tab_window_. Modify that code, when the browser is removed, go through the list of browser_window_to_tab_window_ to remove the tab windows in the browser. BUG=1090615 Change-Id: I83346b648110fd4f831661cfd168a69676cb39e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228018Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#774675}
-
Francois Doray authored
[sheriff] Expect failure for virtual/cascade/fast/forms/month/month-appearance-basic.html on Mac10.10. TBR=fdoray@chromium.org Bug: 1090822 Change-Id: I85dacc2c73624f9e34985764cd99e6fbe660835c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228119Reviewed-by:
-
Harkiran Bolaria authored
Delta: fix for flakey testing failures on Mac10.10 trybot because of kOutstandingNetworkRequestOthers From previous submit: As a note - this patch jumps from 47 to 49 in WebSchedulerTrackedFeature so as to prevent merge conflicts with the patch here: https://chromium-review.googlesource.com/c/chromium/src/+/2212934 Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Change-Id: I884e7b5262938c453cea7e1792b505c3a55447bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225355 Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#773982} Change-Id: I6629b885731398846257fd2ab767b1c9669a8565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227097Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
James Long authored
Three command-line tools created: - generate_json_dependency_graph (renamed from process_jdeps) - print_class_dependencies - print_package_dependencies The README file has been updated with information about tool usage, and the tools can all be run with --help flags for more information. Bug: 1081895 Change-Id: I07e5e13adbec029b54cce89e3f243526823279eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224651 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#774672}
-
Wei Li authored
Desk mini view can be owned by the views hierarchy instead of directly owned by desks bar view. Desks bar view will only store the raw pointers of those mini views until they are removed. BUG=1044687 Change-Id: I0e613a562df4a93f1d6da74673272a445e5148cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220394 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#774671}
-
Anders Hartvoll Ruud authored
Since enumeration does not guarantee any specific order, we can get test failures when the order changes for an unrelated reason (typically when adding a new CSS property). Fix by sorting the keys before comparing, which ensures that we fail the same way every time. Change-Id: I7bbc8e98bc17120084c6934d71f092ee0ba016da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228724Reviewed-by:
-
David Bokan authored
Most tests failing here were expecting ScrollingShouldSwitchToMainThread to be called. This method goes away with scroll unification so we simply avoid expecting it in these cases. A few tests were explicitly checking behavior related to sending events to the main thread; these are no longer relevant when unification is enabled so they simply early out and can be removed when the flag ships. This CL also makes these tests run with both states of the flag (and improves the parameterized test fixture). Bug: 1086625 Change-Id: Id088a7808741fb91e13d1836aa8522e881a17f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227850Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#774669}
-
Gabriel Charette authored
base::PostTask with no traits implicitly posted to base::ThreadPool. This isn't necessary here. The correct semantics would have been to post to ThreadTaskRunnerHandle::Get(). But even that seems unnecessary as RunLoop::Quit() can be invoked directly in this context. Assuming the test doesn't need to let pending tasks run before quitting the loop. This change is blocking https://chromium-review.googlesource.com/c/chromium/src/+/2225541 Bug: 968047, 1026641 Change-Id: I6caea1ee7c7f3089ebc8a7786a4755eb784cac80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228118Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Anupam Snigdha <snianu@microsoft.com> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#774668}
-
Marc Treib authored
An "unsynced deletion" is a password deletion that has been applied locally, but not committed to the server yet. Clear Browsing Data is interested in the existence of unsynced deletions, so it can track when a deletion has actually been committed. Bug: 1086433 Change-Id: Ieec2b5b57b2ffa49caa8f697662953892ec61f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214953Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#774667}
-
Luke Zielinski authored
In PR https://github.com/web-platform-tests/wpt/pull/23922 a command was added to the docs/ directory, and docs/ was added to tools/wpt/paths. This means that running wpt now requires docs/command.json to exist. The WPT Waterfall (go/wpt-waterfall) is currently broken by this. Change-Id: Ie5514a6257f1d87f7a3da1fa758e655dd2312841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229063 Commit-Queue: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#774666}
-
Robert Ogden authored
This class manages all the subresources on a prefetch page and how they are loaded. This is only a plumbing and ownership change, no behaviorial changes. Bug: 1082505 Change-Id: I7f09cf32235c089591bed8f2608224a29bcf2a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224822Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#774665}
-
Reilly Grant authored
This is an alternate to crrev.com/c/2216317 to fix test flake in geolocation-api/watchPosition-page-visibility.html now that page visibility changes are asynchronous. The original mock required a call to setGeolocationPosition() for every call by Blink to queryNextPosition(). This is a difficult invariant to maintain because Blink will always call queryNextPosition() after calling the success callback. Most tests avoided the error by marking the test passing during the watch position callback and so the error generated by the next "tick" was ignored. The page visibility test is sensitive to this issue because the call to queryNextPosition() after state 2 races with the change in visibility. If it wins then there is no position available and the test fails. This version of the mock allows queryNextPosition() and setGeolocationPosition() to be called in any order, matching up the request from Blink to the position update when it is available. In this case if queryNextPosition() is called before the visibility state change then it will wait for the position to be updated after the page is hidden. This position update will still be ignored by Blink because it has, at that point, already closed the Mojo connection to the geolocation service. Bug: 1083585, 866140 Change-Id: Ida2469738b19d0862c7af3870360c755c71f7e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219148Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#774664}
-
Alison Maher authored
This change updates the name of the forced-colors media query within the UA stylesheets to ua-forced-colors. This is done to make it clear that it is a UA-specific hack for forced-colors. This is based on feedback from https://chromium-review.googlesource.com/c/chromium/src/+/2211124. Bug: 970285 Change-Id: Ic99620f7886a82cfbb87d929bf7f985f474714c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227098Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774663}
-
