- 13 Dec, 2019 40 commits
-
-
Alexander Hendrich authored
Tests have been flaky on bot linux-chromeos-rel [1], e.g. [2] and [3]. [1] https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel [2] https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/32337 [3] https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/32327 TBR=afakhry@chromium.org Bug: 1033651, 1033650, 1033648 Change-Id: I605abaf2ae67fac9c182079778a7ff33415c9c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965659Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#724579}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/928e3835d93d..bca1deb32d4c git log 928e3835d93d..bca1deb32d4c --date=short --first-parent --format='%ad %ae %s' 2019-12-13 cjamcl@chromium.org Add report.js to all_devtools_files. Created with: gclient setdep -r src/third_party/devtools-frontend/src@bca1deb32d4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1033368 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I34f2d961c47251b9411e0a530b3bf5dbb33fc45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967038Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724578}
-
Rune Lillesveen authored
The 'none' keyword is not generally disallowed for <custom-ident>, and the css-color-adjust spec does not explicitly disallows it either. Bug: 939811 Change-Id: I13935b313ec374ddda551580d000cb54e40e2b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965581Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#724577}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 39474466. With Chromium commits locally applied on WPT: 830911ba "Enabled unbounded reference spaces for OpenXR." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I2133d5fbf43c46eb19cb101831c8fb05cb5c92fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965382Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724576}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5c019b5923c1..96354f5047bf git log 5c019b5923c1..96354f5047bf --date=short --first-parent --format='%ad %ae %s' 2019-12-12 afdx@google.com spirv-fuzz: Fuzzer pass to merge blocks (#3097) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@96354f5047bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliot@google.com Change-Id: Ic3fab5d32d63dd4d0218a816cda2d74bc46177f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966030Reviewed-by:
-
Alexander Hendrich authored
virtual/webrtc-wpt-plan-b/external/wpt/webrtc/idlharness.https.window.html has been failing consistently on Win7 [1] since CL [2] in build 97905 [3]. [1] https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 [2] https://crrev.com/c/1966191 [3] https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/97905 TBR=smcgruer@chromium.org Bug: 1033652 Change-Id: I503e51db7590c0b1b8bf9ad37d8cfa39501c1fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967231Reviewed-by:
-
Carlos Caballero authored
MessageLoop is going away soon. Bug: 891670 Change-Id: I98905417dc914afd4fcc0640ace29b88fc591f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964497Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#724573}
-
Toni Barzic authored
The issue that caused the test to be disabled is suspected to be resolved. BUG=1028336 Change-Id: I74abccbe5483e4a398de0e5baadc0c45b646e307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965994Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#724572}
-
Benoît Lizé authored
A sizable fraction of Windows 32 crashes are due to discardable memory (see linked bug). In many cases, this is suspected to be due to address space exhaustion, while the renderer process holds a lot of unlocked discardable memory. A solution is to drop some discardable memory when an allocation fails (instead of crashing), and retry it afterwards. However the memory allocator doesn't have a list of allocated spans, so the allocator must either be updated to add this, or the client has to drop the memory. In the renderer case, the only client of Discardable Memory right now is the image decode cache, which keeps track of all allocated spans. As a consequence, the easiest change is to let the client drop the memory in case of allocation failure. Another motivation for proceeding this way is that the Discardable Memory system is likely going to be simplified drastically soon, so it does not feel useful to do invasive work there in the meantime. This patch: - Adds support for client-provided "on_no_memory" callback to allocations, and retry. - Updates the two renderer clients to drop all the cache in case of allocation failure Bug: 983348 Change-Id: Ie393dbec1b8e964284b30c9ea9f946b46e5c1829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939967Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#724571}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16a293640fd0..f6ee053f050e Created with: gclient setdep -r src-internal@f6ee053f050e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I67ce8d3326b358a74fa2bbd5dcc62b4a5ead1250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967036Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724570}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: Ibe16414ba0a669a42fd2d2a5e28eaa53980c883b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965750Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#724569}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1d77542f5681..ef11f849b71b git log 1d77542f5681..ef11f849b71b --date=short --first-parent --format='%ad %ae %s' 2019-12-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 6c479796f6e4..ebf634bcaa3e (1 commits) Created with: gclient setdep -r src/third_party/angle@ef11f849b71b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliot@google.com Change-Id: Id8ab139a2f1e008b2325598653d39794652db2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967032Reviewed-by:
-
Marcin Radomski authored
If set to true, mixer inactivity timer is not started, preventing the mixer from dropping connection after kInactivityTimeout of no incoming data. Bug: b/138551750 Change-Id: Iacf3327a0b185e76d0976d2bc50a6a0b95de942b Merge-With: eureka-internal/343509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960318Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Marcin Radomski <dextero@google.com> Auto-Submit: Marcin Radomski <dextero@google.com> Cr-Commit-Position: refs/heads/master@{#724567}
-
Ella Ge authored
Mouse button type are used for both dispatchMouseEvent and emulateTouchFromMouseEvent. They are using separate enum, but same logic converting to WebMouseEvent type. This is not very clean and not good for maintenance. This CL makes both method use a MouseButton type, and the comment for emulateTouchFromMouseEvent (it fires contextmenu for right button, ignores events with middle/forward/back button) Also adds back/forward button to the tests. This change is not going to change the usage for these two function. Change-Id: Ib6d151c7472008cee04aef8792b67a68eb2d44bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948827Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#724566}
-
Sigurd Schneider authored
Tbr: yangguo@chromium.org Bug: chromium:1004203 Change-Id: I2757221c14ca2b931cb9e5cf0db4a32f9eb543b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967171Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#724565}
-
Bret Sepulveda authored
When ExtensionsToolbarMenu is enabled, the DCHECK asserting that the toolbar browser actions container exists will always fail. It looks like when we moved the views cast dialog anchor from the browser actions container to the trusted area we missed changing the DCHECK, so this patch replaces it with a more appropriate one. Bug: 984654 Change-Id: I126a30692c4e48073fc376602e3da9c5d416c27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964072Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#724564}
-
Bret Sepulveda authored
This patch fixes more expectations in ExtensionContextMenuShowAndHide when ExtensionsToolbarMenu is enabled. The "show" and "keep" strings are now both "Pin", and the browser action is now pinned before being unpinned (via activating the "Unpin" context menu option) to avoid hitting a DCHECK. Bug: 984654 Change-Id: I624b2f0de441625160ea76340f11da255406e6b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963857Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#724563}
-
sandromaggi authored
Change the details card to use Clank defaults. Before: https://screenshot.googleplex.com/W3pqsrCyrCW After: https://screenshot.googleplex.com/as5h195BKB8 (note that the data for price is mocked text) Bug: 144277634 Change-Id: Ic203a99d36710b928c8e36d939efe883f55d7f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963801Reviewed-by:
-
sandromaggi authored
This removes out overwrites of colors in the progress bar of the header. Before: https://screenshot.googleplex.com/MgYfzEV6buu After: https://screenshot.googleplex.com/gxumKL9NPfp Bug: b/144149405 Change-Id: Ie745d1d76dd06e24c24b4e7f95b5bed431799c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963800Reviewed-by:
-
Rohit Agarwal authored
Ambient authentication is enabled to be allowed for OTR profiles by default. Due to this, the user can be ambiently signed-in to sites that support ambient authentication. This could be needed for an enterprise users and we have policy now that the enterprise admins can set to allow ambient authentication for these profiles. This CL makes ambient authentication disabled by default for OTR profiles. Bug: 458508 Change-Id: I79a48c3b454d4ca5868dfc886ce5b4d337fbdd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964570Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#724560}
-
Kenichi Ishibashi authored
The [Constructor] extended attribute was superseded by constructor operations [1] and the blink code generator now supports it. Convert [Constructor] to operations. This CL was generated by a script. I manually checked that generated bindings aren't changed. [1] https://heycam.github.io/webidl/#idl-constructors Bug: 999961 Change-Id: I38d2c04ee33bb03bc58741f13b1b7b4386d05953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967012Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#724559}
-
Ilia Samsonov authored
FetchUrlTest calls mojo::core::Init() for each test. This is uneccessary and causing failure on exit in asan builder. Bug: 1018424 Change-Id: I61d66a532dfcc08987ba18df7e1cee18be657a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966694Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#724558}
-
Tomasz Moniuszko authored
Bug: 1033438 Change-Id: I0e892a2c8ea7b15e9f2c13f86162b011a3e75100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963852Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#724557}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f17b6b86ac6e..16a293640fd0 Created with: gclient setdep -r src-internal@16a293640fd0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I954aeb911f71f46a541e73eca4ac1384642b97a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966027Reviewed-by:
-
Rakesh Soma authored
Note: This is an incremental change to [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1900159 Change-Id: I401bf6ea8f30cf83b68a216e40bd1187ed9717a6 Bug: 1032807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961785 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#724555}
-
Arthur Hemery authored
A CL aimed at reducing dependencies of other concurrent CLs. Does nothing in itself but introduce an unused cross_origin_opener_policy_ member to RenderFrameHostImpl. Based on and grouped with COEP. Bug: 922191 Change-Id: I5331da7ad287d56294029fbb2885b02799ed1d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963795 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#724554}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b7e9343b7617..7d4575c695a1 git log b7e9343b7617..7d4575c695a1 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 dberris@chromium.org Save culprit finding task payload for every update Created with: gclient setdep -r src/third_party/catapult@7d4575c695a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1032855 Tbr: skyostil@google.com Change-Id: I40125cdb4fb88912766fe18286f2cde6aa520c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966022Reviewed-by:
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Ifb9eef57c3dc506d1eeb3c95fbde4615971bb520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950729Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up comments about old Mojo types since the code has been converted already to new Mojo types. NOTRY=true Bug: 955171 Change-Id: Iab9cb76e5ddee5fb494d5f1833a5eddbeb50f6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950046Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#724551}
-
Chih-Yu Huang authored
Originally |flush_callback_| is accessed on both child sequence and encoder sequence. This CL makes V4L2VEA only access this variable on encoder sequence to avoid race condition. Bug: 827448 Test: Run video_encode_accelerator_unittests on Kevin Change-Id: I2963aff4959527d0e0cb3ad3adf11f2076ddc8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959918Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#724550}
-
Lachlan Ford authored
Fixes: 1028408 Change-Id: I6315094b905bce84df92d74058ffb684a73a6fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935727 Commit-Queue: Lachlan Ford <laford@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#724549}
-
Miyoung Shin authored
This CL replaces Platform::GetInterfaceProvider with Platform::GetBrowserInterfaceBroker in Blink to use BrowserInterfaceBroker. Platform::GetInterfaceProvider proxies the calls to BrowserInterfaceBroker so no browser-side changes are necessary. [1] [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/exported/platform.cc?rcl=465931c14fbb262700f157ef085768b29bebaf1d&l=82 Bug: 936482 Change-Id: I9b82b1aec95dc391bf3735e032ad427840423534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961839Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#724548}
-
Peter Kotwicz authored
BUG=1032291 Change-Id: Ic2c6a4fa9bc31bcd9222df5d8f88ba70b5cff7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959047 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#724547}
-
Francois Beaufort authored
Infrared camera are supported only in Android Q and later. This CL makes sure support is checked only on those platforms. Bug: 1033422 Change-Id: Ica032c91713ede7bb0514492854d02dd8e761b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963792Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#724546}
-
Simon Que authored
This builder starts up Goma but doesn't use it. Bug: 1025334 Change-Id: I0fd2b267f3250e3a56312c3f48c43bd530767c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966807Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#724545}
-
Kuo Jen Wei authored
cca.models.Gallery serves as model of old gallery view. Remove related classes after deprecation of old gallery. Bug: 1032514 Test: Manually test on functionality of gallery button. Change-Id: Ib15e047c9dbfee5ce1a241253b109e41093bdc18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961841Reviewed-by:
-
Mike Dougherty authored
BreadcrumbPersistentStorage stores breadcrumbs to disk and returns the breadcrumbs from the persisted file. This will allow breadcrumbs to be saved during an application run and retrieved after a crash on the next launch. Bug: 1003922 Change-Id: Iffa9dc2797b66eda0793c9eafef6bddc8c73200d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959777 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#724543}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I371431ee0ee035a8af8230fa56ab0b6852ff6db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960087Reviewed-by:
-
Victor Fei authored
This change exposes hierarchical level for list items in the accessibility tree. Hierarchical level is determined from `aria-level` or the DOM structure of the listitem in relation to its parent list group. Previously hierarchical level was only exposed for tree items and headings. WAI-ARIA spec for aria-level for list item: https://www.w3.org/TR/wai-aria-1.1/#listitem https://www.w3.org/TR/wai-aria-1.1/#aria-level Change-Id: I0ef177a3bf68cdde52a7c02f9364e61b0995f99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928639 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#724541}
-
Vitaly Buka authored
This is a reland of 4c424ef5 Windows bot is fix: crrev.com/c/1946985 base_unittests fix: crrev.com/c/1949643 crashpad_tests fix: crrev.com/c/1949846 Bug: 977230, 1030261 Original change's description: > Enable init_stack_vars for non-official Windows builds > > With crrev.com/c/1914359 merged so we can enable the flag on Windows. > Patch is similar to crrev.com/c/1795632 and crrev.com/c/1838383. > > Bug: 977230 > Change-Id: I166392ee0f65ed7fd7f68cbdd5b7a3b7d589539b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854805 > Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> > Auto-Submit: Vitaly Buka <vitalybuka@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719737} Change-Id: I6f70b2a3c51fafd2ccce543a19b9d9bda5e982b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948914 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#724540}
-
