GitLab

In order to be notified that page is translated, we simply implement CompactInfobar as observer of Translate Driver.
But now we found from the translate button is clicked to the page is translated, there are many steps. If any step is returned, we are not be notified at all.

In order to fix the loose relationship, we create a responder inside the delegate.
So no matter what delegate is going to do, we will be notified, which keep infobar always consistent with delegate.

What's more, on some corner cases listed in bug/723426, the relationship between infobar and translate driver causes crash. And the new strong relationship will fix it.

BUG=720164,703887,723426, 724428
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2894553002
Cr-Commit-Position: refs/heads/master@{#473799}

Remove the per-detect() UMA counters and use instead constructors,
because in a normal usage pattern the detect() method can be called
many times on the same object, and we don't want to skew the UMA.

Bug: 659138
Change-Id: Ib4aef88c35dd4853ececbf71cc12a96eaca020f3
Reviewed-on: https://chromium-review.googlesource.com/511344
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473798}

https://skia.googlesource.com/skia.git/+log/5592382a7ad1..79a1a97db7c4

$ git log 5592382a7..79a1a97db --date=short --no-merges --format='%ad %ae %s'
2017-05-22 jvanverth Fix TSAN bot

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I81e44d772c5f2d8fb3eb2a62a68d189600fb041c
Reviewed-on: https://chromium-review.googlesource.com/511768Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473797}

Merges google_input_tools extension into google_xkb extension. The google input tools extension relative clean up will be in other CL.

BUG=709360
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

patch from issue 2894793002 at patchset 1 (http://crrev.com/2894793002#ps1)

Review-Url: https://codereview.chromium.org/2898873002
Cr-Commit-Position: refs/heads/master@{#473796}

https://pdfium.googlesource.com/pdfium.git/+log/355954b8f09a..1b02d0180403

$ git log 355954b8f..1b02d0180 --date=short --no-merges --format='%ad %ae %s'
2017-05-22 thestig Remove CBC_HighLevelEncoder::isSpecialB256().
2017-05-22 thestig Use NOTREACHED() in more places.
2017-05-22 tsepez Convert more c-style pointers to CFX_UnownedPtr

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I0d89ce38e35d38bda5d57e0d0cb00726c05aa6cd
Reviewed-on: https://chromium-review.googlesource.com/511823
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473795}

Cr-Commit-Position: refs/heads/master@{#473794}

InputMethodController::SetSelectionOffsets function is
changed to use SetSelection instead of SetSelectedRange.

BUG=721190

Review-Url: https://codereview.chromium.org/2893303002
Cr-Commit-Position: refs/heads/master@{#473793}

BUG=596760
TBR=mkwst

Review-Url: https://codereview.chromium.org/2896443003
Cr-Commit-Position: refs/heads/master@{#473792}

Header files should be listed in the sources list, so gn analyze
can work.

https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0

https://groups.google.com/a/chromium.org/d/topic/chromium-dev/1kK45mVemBc/discussion

BUG=661774

Change-Id: I46e72232a525833bd805a306a4a1e2075f78adef
Reviewed-on: https://chromium-review.googlesource.com/508669Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473791}

Revert of Track task ids for navigations cross multiple tabs. (patchset #4 id:80001 of https://codereview.chromium.org/2868043003/ )

Reason for revert:
crbug.com/725026 and crbug.com/724497

Original issue's description:
> Track task ids for navigations cross multiple tabs.
>
> This is a following step to generate task ids for navigations. Now we
> can track navigation relationship cross multiple tabs. If navigation B
> in tab2 is clicked from navigation A in tab1, then navigation A is B's
> parent task. And this is generalized to more than 2 tabs.
>
> BUG=707978
> R=zea@chromium.org
>
> Review-Url: https://codereview.chromium.org/2868043003
> Cr-Commit-Position: refs/heads/master@{#472667}
> Committed: https://chromium.googlesource.com/chromium/src/+/854b8bcfc787413293c86eddd979a3fd1936fb1a

TBR=shenchao@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=707978

Review-Url: https://codereview.chromium.org/2901533003
Cr-Commit-Position: refs/heads/master@{#473790}

This reverts commit bce55d7b.

BUG=

TBR=mikecase,bsheedy

Review-Url: https://codereview.chromium.org/2896933002
Cr-Commit-Position: refs/heads/master@{#473789}

BUG=723977
TEST=browser_tests --gtest_filter=FileManagerJsTest.DirectoryTree*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2897973002
Cr-Commit-Position: refs/heads/master@{#473788}

This was a regression introduced by my patch https://codereview.chromium.org/2813353002/ for
bugs 665412, 656198. This patch ensured that the parent views get notified when a child adds a layer.

This notification is handled by the scrollview, where we enable layering on the viewport.

We need to call SetFillsBoundsOpaquely() on the viewport layer for the scrollview to ensure that
transparent views like the overflow menu work correctly.

Thanks for timbrown for helping debug on his Linux Box and to sky for
the suggestions.

BUG=722965

Review-Url: https://codereview.chromium.org/2895003002
Cr-Commit-Position: refs/heads/master@{#473787}

This reverts commit 107bc421.

Reason for revert: reenable the benchmark to see which tests are failing.

Original change's description:
> Disable performance_browser_tests on failing bots
> 
> The failing bots are:
> 
> Mac Air 10.11 Perf 
> Mac Pro 10.11 Perf
> Mac Retina Perf
> Win 7 ATI GPU Perf
> Win 7 Nvidia GPU Perf 
> Win 7 Perf
> 
> Bug:722367
> Change-Id: Iffb4d077312a69c3fb2386603183c3737ecb6540
> 
> NOTRY=true (since this doesn't affect any CQ test)
> TBR=sullivan@chromium.org
> 
> Change-Id: Iffb4d077312a69c3fb2386603183c3737ecb6540
> Reviewed-on: https://chromium-review.googlesource.com/509989
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#473326}

TBR=nednguyen@google.com,martiniss@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug:722367

Change-Id: Ife4777108c4318b808d7bf1f8b9ffe2a9dda1ec1
Reviewed-on: https://chromium-review.googlesource.com/511462Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#473786}

Revert of No extra space emission in TextIterator::HandleTextNode (patchset #6 id:100001 of https://codereview.chromium.org/2894543002/ )

Reason for revert:
Breaking this case:

<div class=container id=div4 style="width:30px">
foooooooooooooooo

<span style="white-space: pre">bar</span>
</div>

Original issue's description:
> No extra space emission in TextIterator::HandleTextNode
>
> Due to historical reasons, TextIterator emits an extra space before a text node
> with "white-space: pre" style if the last text node contains only collapsed
> whitespaces. This might be a workaround for some other buggy behavior, which
> no longer exists today.
>
> Hence, this patch removes the extra space emission.
>
> BUG=721957
>
> Review-Url: https://codereview.chromium.org/2894543002
> Cr-Commit-Position: refs/heads/master@{#473072}
> Committed: https://chromium.googlesource.com/chromium/src/+/9b781c354432f97658390c848359d2d70ceb1cb5

TBR=yosin@chromium.org,xiaochengh@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=721957

Review-Url: https://codereview.chromium.org/2896033003
Cr-Commit-Position: refs/heads/master@{#473785}

This makes sure that the VS environment is always properly set when
calling vs_toolchain.FindVCToolsRoot from the bots.

Review-Url: https://codereview.chromium.org/2893293004
Cr-Commit-Position: refs/heads/master@{#473784}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2282ee55..4aaca535

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2895143003
Cr-Commit-Position: refs/heads/master@{#473783}

Android framework does not provide an easy way to remove keyboard app
from the testing (unless you use Robolectric).

So far we have been allowing the current keyboard app to interfere with
test and thus flaked test results. Especially, when you make selection
change, Google Latin Keyboard tries to look at the new status by running

beginBatchEdit() -> getTextBeforeCursor() -> endBatchEdit().

And this disrupted batch edit logic such as mInBatchEditMode.

With this change, onCreateInputConnection() will now return null, so
keyboard app cannot interact with the text. Also, dispatchKeyEvent
will ignore key events when it has to.

Note that the test can still interact with BaseInputConnection's method
and thus affects EditText's Editable through UrlBar#getInputConnection().

In doing so, I've guarded KeyUtils#dispatchKeyEventToView() to work with
UI thread.

BUG=723901

Review-Url: https://codereview.chromium.org/2894073002
Cr-Commit-Position: refs/heads/master@{#473782}

Instead replace it with an appropriately styled div.

As a fortunate side-effect, this CL makes the box-shadow effect work
in Vulcanized mode, because it side-steps https://github.com/Polymer/polymer-css-build/issues/13

BUG=598516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2885363006
Cr-Commit-Position: refs/heads/master@{#473781}

Clarified that the crx_file.* refers to CRX₂, moved verification out of the CRX₂ code to allow callers to specify CRX₃-permissive policies.

Also fixed a potential crash in extension_creator.cc.

BUG=720092

Review-Url: https://codereview.chromium.org/2874503002
Cr-Commit-Position: refs/heads/master@{#473780}

https://skia.googlesource.com/skia.git/+log/bcd8637772e3..5592382a7ad1

$ git log bcd863777..5592382a7 --date=short --no-merges --format='%ad %ae %s'
2017-05-22 egdaniel Remove setting of alpha coverage in text ops when in LCD mode
2017-05-22 jvanverth Cache ambient and spot shadows at a canonical position
2017-05-22 egdaniel Fix to lcd blending in ganesh
2017-05-22 mtklein Revert "Revert "mark SkRasterPipelineBlitter final""
2017-05-22 brianosman Revert "Remove compressed (ETC1) texture support from Ganesh"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I4df06228d04a5eb3354998ed45ca124c03ae6185
Reviewed-on: https://chromium-review.googlesource.com/511643Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473779}

When user selects "Always translate page", if the page is untranslated,
then translate the page, and make UI changes to indicate selected
tab on the infobar.

BUG=724670

Review-Url: https://codereview.chromium.org/2899663002
Cr-Commit-Position: refs/heads/master@{#473778}

Revert of Switch BrowserAccessibilityStateImpl to the TaskScheduler API. (patchset #3 id:40001 of https://codereview.chromium.org/2888773002/ )

Reason for revert:
This is causing some issues on ChromeOS.

See crbug.com/725247

Original issue's description:
> Switch BrowserAccessibilityStateImpl to the TaskScheduler API.
>
> It doesn't look like the #if defined(OS_WIN) block is necessary here, everything could be handled by the task scheduler directly.
>
> BUG=689520
>
> Review-Url: https://codereview.chromium.org/2888773002
> Cr-Commit-Position: refs/heads/master@{#473281}
> Committed: https://chromium.googlesource.com/chromium/src/+/1e0346d1ef0851ad07bf00fafefdd747bf30baed

TBR=dmazzoni@chromium.org,fdoray@chromium.org,aboxhall@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=689520

Review-Url: https://codereview.chromium.org/2899623003
Cr-Commit-Position: refs/heads/master@{#473777}

https://pdfium.googlesource.com/pdfium.git/+log/ed75ee25f40a..355954b8f09a

$ git log ed75ee25f..355954b8f --date=short --no-merges --format='%ad %ae %s'
2017-05-22 weili Fix crypto calculation regression due to typo

Created with:
  roll-dep src/third_party/pdfium
BUG=725267


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Iad57886e1fbfd37c21a956653333f1d820415c46
Reviewed-on: https://chromium-review.googlesource.com/511187
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473776}

These are the first Web Platform Tests for the Individual Transform
Properties.

Spec:
https://drafts.csswg.org/css-transforms-2/#individual-transforms

BUG=722696

Review-Url: https://codereview.chromium.org/2882153004
Cr-Commit-Position: refs/heads/master@{#473775}

This regressed in r472101 wich made the network service pointer get initialized in non-test code earlier.

BUG=720374

Review-Url: https://codereview.chromium.org/2895353002
Cr-Commit-Position: refs/heads/master@{#473774}

- Added WebPresentationReceiver::RemoveConnection() API
- Added WebPresentationReceiver pointer to ReceiverConnectionProxy. WebPresentationReceiver::RemoveConnection() is invoked when receiver connection changes to 'closed'
- In PresentationDispatcher::OnReceiverConnectionAvailable, pass receiver_ pointer to ReceiverConnectionProxy

BUG=713227

Review-Url: https://codereview.chromium.org/2874483002
Cr-Commit-Position: refs/heads/master@{#473773}

When non-base-level texture image is attached, it is required that texture is
mipmap complete for the fbo to be complete. Currently command buffer doesn't
check this.

BUG=722684
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2895493002
Cr-Commit-Position: refs/heads/master@{#473772}

This CL allows us to override the AXPlatformNode's GetFromUniqueId
method.  In BrowserAccessibilityComWin we implement this by using the
BrowserAccessibility GetFromUniqueId.

BUG=703369

Review-Url: https://codereview.chromium.org/2894673003
Cr-Commit-Position: refs/heads/master@{#473771}

BUG=725265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2901643002
Cr-Commit-Position: refs/heads/master@{#473770}

This CL:

1) Replaced AwContentsIoThreadClient with AwContentsIoThreadClientImpl
2) Replaced InputStream with InputStreamImpl
3) Replaced AwWebResourceResponse with AwWebResourceResponseImpl, and
   moved implementation into browser/net/.

Replacing them due to the merge of native/ and browser/

BUG=716604

Review-Url: https://codereview.chromium.org/2889193004
Cr-Commit-Position: refs/heads/master@{#473769}

With BLE, we only check the RSSI, so we can now remove all references to the TX
power proximity strategy.

Review-Url: https://codereview.chromium.org/2898513002
Cr-Commit-Position: refs/heads/master@{#473768}

Links the native visualizers into the PDB so that Visual Studio will pick up the visualizers with no user action.

Adds visualizers for base::flat_set, base::flat_tree (these two had the info buried in several levels of tree), base::ManualConstructor (requires a cast), and base::Value (decodes the union).

Removes some aura visualizers. I didn't see these as adding much value.

Simplifies many of the other visualizers to only improve the summary and not list any <Expand> items. This causes VS to show the default expansion. Many of these seemed unhelpful and possibly confusing (converting gfx::Point's "x_" to "X"), dangerously misleading (converting Skia's rect which is left, top, right, button to use width, height format), and broken (GURL's components had typos and didn't work).

Review-Url: https://codereview.chromium.org/2895043002
Cr-Commit-Position: refs/heads/master@{#473767}

check whether the printing render frame host has been initialised before accepting a message in the headless print manager

BUG=

Review-Url: https://codereview.chromium.org/2890133002
Cr-Commit-Position: refs/heads/master@{#473766}

Notable changes:
 - Do not use WaitForCondition method that times out (tests should not
   timeout) and use one that returns bool.
 - Moved setup code from constructor to SetUp, so it is executed after
   the server actually started.
 - Increased timeout for the test to 5 seconds, which is a reasonable
   timeout to allow page load and one roundtrip message exchange.
 - Marked test as flaky to let it run on bots before fully enabling it.

BUG=720098

Review-Url: https://codereview.chromium.org/2895333003
Cr-Commit-Position: refs/heads/master@{#473765}

FontList::Derive(..) is slow (typically requiring IPC with the font
server), has unpredictable results with special UI fonts on Mac, and
encourages use of magic numbers like "-1".

Instead, use context and style constants from the Chrome typography
spec, where available. When an equivalent font is not available, use
ResourceBundle to avoid a behavior change in this CL.

BUG=721834

Review-Url: https://codereview.chromium.org/2899653002
Cr-Commit-Position: refs/heads/master@{#473764}

This class contains GC pointers and should be traced. Due to
a bug in the GC plugin, this wasn't being enforced. This also
changes the class to be a part object to clarify lifetimes.

Bug: 724418
Change-Id: I46d037d7f5040bc942b6bdf54d8d8a134914134b
Reviewed-on: https://chromium-review.googlesource.com/509149Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473763}

For more on JUnit4 migration, please check src/testing/android/docs/junit4.md

BUG=640116

Review-Url: https://codereview.chromium.org/2876273004
Cr-Commit-Position: refs/heads/master@{#473762}

The add printer dialog was crashing in Guest Mode because a
PrinterDetector could not be constructed.  It is okay for
PrinterDetector to be shared between logged in profiles.

BUG=724278

Review-Url: https://codereview.chromium.org/2898833002
Cr-Commit-Position: refs/heads/master@{#473761}

Revert of Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0 on Win bots. (patchset #2 id:20001 of https://codereview.chromium.org/2893523004/ )

Reason for revert:
This test passes after the fixes on issue webrtc:7532. See the explanation https://bugs.chromium.org/p/chromium/issues/detail?id=722746#c21 for how they are related.

Original issue's description:
> Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0 on Win bots.
>
> BUG=chromium:722746
>
> Review-Url: https://codereview.chromium.org/2893523004
> Cr-Commit-Position: refs/heads/master@{#472824}
> Committed: https://chromium.googlesource.com/chromium/src/+/7498e9b31a8ed8fd1d1fac071916cf824e48e2c5

TBR=tommi@chromium.org,philipel@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:722746

Review-Url: https://codereview.chromium.org/2903463002
Cr-Commit-Position: refs/heads/master@{#473760}