GitLab

The same script as in https://chromium-review.googlesource.com/654817 was used.

css/README.md cleanup is in https://github.com/w3c/web-platform-tests/pull/8309.

Change-Id: I0019e26cacebc32595e947c52c51d2c34590fc03
Reviewed-on: https://chromium-review.googlesource.com/778862Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517919}

This test case is unrealistic as words are usually never that long.
Slowing down selection of a word this long is acceptable as most words
on a webpage can still be selected in under 100ms.

Bug: 783345
Change-Id: I55ca93401b94018f45d9a3dbccbe00b9677ab9c1
Reviewed-on: https://chromium-review.googlesource.com/779441Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#517918}

(0, 0) was always an element center previously. But with the concept of
local_origin for an element introduced, this is no longer true. This CL uses
(local_origin, 0) instead of using (0, 0, 0) when construct an element's
bound.

Bug: NONE
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If5b03f0c0a0a4329ce19ecc1a465469f57d77983
Reviewed-on: https://chromium-review.googlesource.com/779560
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517917}

LayerDelegate::OnDelegatedFrameDamage and WindowObserver::OnDelegatedFrameDamage
were only used for the old video detector and are incompatible with Viz,so get rid
of them. There are some usages in tests but those can be written in other ways.

TBR=sky@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I507b9f9139527b85ee34efe50e115a24a7f99bc7
Reviewed-on: https://chromium-review.googlesource.com/777504
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517916}

Bug: 403687
Change-Id: Ida37ffe1870b599513ccbbf50095e02c94a280be
Reviewed-on: https://chromium-review.googlesource.com/775454
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517915}

Calling GetFileInfo() is a blocking call and because the desktop feature
tracker needs the first run creation time, it was performing file I/O on
the UI thread causing jank. This change moves getting the creation time to
sentinel creation and caches that result in a static variable.

Bug: 785189
Change-Id: Ia4b4e5783bf3e6d06c9812661d7930384cbf9b21
Reviewed-on: https://chromium-review.googlesource.com/773445Reviewed-by: Carlos Pizano <cpu@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517914}

Adds simple opener-based grouping to the experimental tab controller.

Clicks are not handled for activation. Tabs are rendered overlapped
properly.

Bug: 778461
Change-Id: Ic93cb109875d815018a6197e35b10b358959ac02
Reviewed-on: https://chromium-review.googlesource.com/777735Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517913}

- When possible, detect chunk_to_layer_clip change;
- When possible, issue incremental raster invalidation on clip change.

Bug: 771643
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8cea00f3c3ebcd035eae9bfcf29971a7a02a96df
Reviewed-on: https://chromium-review.googlesource.com/753540
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517912}

This simplifies some memory management works.

Bug: 773503
Change-Id: I00ddaab4f2e6709115741cdf796acda1021fd24d
Reviewed-on: https://chromium-review.googlesource.com/777973Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517911}

Bug: 787084
Change-Id: Ie7ebf42fb869383a031c43fc5d2a533afe3be6d7
Reviewed-on: https://chromium-review.googlesource.com/779248Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517910}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9a932274..1ef92548

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I880fba765d9df4cf9d3426c32384c1e2786863d2
Reviewed-on: https://chromium-review.googlesource.com/779083Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517909}

After cl 776197, SessionOptions can be referred by protocol/ and codec/, so we
can use it to forward the session options instead of using pure string for
video codec selection.

This change should have no behavior impact.

Bug: chromium:781432
Change-Id: Id7b87d460a4789dead75806f6f33d731cf8ddada
Reviewed-on: https://chromium-review.googlesource.com/777776
Commit-Queue: Zijie He <zijiehe@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517908}

If the resource coordinator purges a tab, the contents for that
tab will be destroyed after it is removed from the tabstrip.
Watch the tabstrip to make sure to handle that case.

BUG=786178
TEST=as in that case

Change-Id: I3d2c2e9fab29fe639615eed330ca769243c9a8f7
Reviewed-on: https://chromium-review.googlesource.com/777470Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517907}

This change replaces usages of the deprecated base::Value::GetType() in
//chromeos with base::Value::type().

Bug: 646113
Change-Id: Ia6a967ed41be10410a306e3c65c7a69a8cbeee87
Reviewed-on: https://chromium-review.googlesource.com/779188Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517906}

The tests were failing due to the test using double instead of int64.

Bug: 785292
Change-Id: Ifa523140ae9e7ff407867ff0b2628a6d4f29d2fb
Reviewed-on: https://chromium-review.googlesource.com/776002
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517905}

BUG=786059
TEST=none

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Idc2e64f53f5a22ca8db71c69ddab42e50a83232e
Reviewed-on: https://chromium-review.googlesource.com/779702Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517904}

Correct sequence on focus:
- focus changes
- range updates
- create text edit handler if needed

The last check (to create text edit handler) depends on the ChromeVox range
having previously been updated.

character doesn't get read prior to patch and does get read post patch.

Test: manually tab to the question text field in Classroom. Verify that initial
Bug: 785283
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id0a4bd8ad17fc2895b802961e739db8e415b9026
Reviewed-on: https://chromium-review.googlesource.com/777900
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517903}

Bug: 787002
Change-Id: I4b7bd26638bb5dffccb52e6d2a06b8cc92ac6f41
Reviewed-on: https://chromium-review.googlesource.com/779626Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517902}

Bug: 
Change-Id: Id6d1150ff524aa5b37f615b5b6cbbb0bb5000d65
Reviewed-on: https://chromium-review.googlesource.com/764880Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517901}

This is a preparation step to migrate DevTools for shared workers to Mojo.

Bug: 776009
Change-Id: I3960cb7ae593f5c46ef8b28b2c70b6b5d2a2e722
Reviewed-on: https://chromium-review.googlesource.com/777746
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517900}

This change replaces usages of the deprecated base::Value::GetType() in
//chrome with base::Value::type().

Bug: 646113
Change-Id: I530efad268c056156874689d8c1c1088ec7dffac
Reviewed-on: https://chromium-review.googlesource.com/779187
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517899}

For Classic Ash, ArcVideo*Accelerator and ProtectedBufferManager interfaces
are implemented in GPU process and requested from browser process. And the
the message pipes for ArcVideo*Accelerators interfaces can be forward from
the browser process into ARC container.

This CL adds CreateArcVideo*Accelerator() and CreateProtectedBufferManager()
methods in viz::mojom::GpuService. Those methods can only be used by the
ui(window server) process via the viz::mojo::VizMain interface.

This CL also adds a new ui::mojom::Arc interface. It is exposed from ui
process, and can only be used by browser process.

For mushrome, the workflow is, ARC requests ArcVideo*Accelerator interfaces
from browser process, and then browser process requests ui::mojom::Arc
interface exposed by ui process and then uses the ui::mojom::Arc to create the
ArcVideo*Accelerators interfaces implemented in viz process, and then forwards
the message handle for ArcVideo*Accelerator interface to ARC. The workflow looks
like:

[ARC]<--arc.mojom.ArcBridgeHost-->[browser]<--ui.mojom.Arc-->[ui]<--viz.mojom.GpuService-->[viz]


Test: Test ARC youtube on device
Bug: 769755
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If8ff4aeeffc378d12bd86161bf705497bcfc28e5
Reviewed-on: https://chromium-review.googlesource.com/759092Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517898}

A couple of bounds calculations used bounds().x(). bounds() is
relative to the parent, where as these calculations are meant to be
relative to the tree. So, they shouldn't use bounds().x() and should
instead always be 0 based.

BUG=779983
TEST=none

Change-Id: I92ffd99c9c7caef25b06bb7bdf3c05bbae466775
Reviewed-on: https://chromium-review.googlesource.com/777768Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517897}

more place in NativeNotificationDisplayService

Bug: 786866
Change-Id: I908f8db4e75f5fba6d1082c98e4a491da0dc148e
Reviewed-on: https://chromium-review.googlesource.com/779759Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517896}

This patch wraps code in ComputeInlineBoxPosition into a new
function, so that the code flow becomes clearer.

Bug: 771398
Change-Id: I6b702f736fe7e21b454aa207180aebadeba63699
Reviewed-on: https://chromium-review.googlesource.com/777702Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517895}

BUG=739622
TEST=Ran trybots.

Change-Id: I6b2d0fc454c6915449c3955b83c5b954119b0626
Reviewed-on: https://chromium-review.googlesource.com/768928Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517894}

With these CL the permission indicators have their colors and visibility
determined by bindings to model properties.

Bug: 768512
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4aff56e1a5e986ad11cb157f47b5e86a800c5084
Reviewed-on: https://chromium-review.googlesource.com/779240Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517893}

The markdown renderer used here fails to handle this non-ascii character:
https://chromium.googlesource.com/chromium/src/+/3224cfecf5bcdd37378f54ec1751d790c79cb00f/docs/new_port_policy.md

TBR=jam@chromium.org

Change-Id: I82511db8e377488d87be767fe0b15dbcacb7e04e
Reviewed-on: https://chromium-review.googlesource.com/779124
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#517892}

By spamming it with DCHECK_CURRENTLY_ON() everywhere. Since no DCHECKs
failed, delete the lock and all the related code that assume the class
can be accessed on other threads. Add threading checks to ZoomController
as well.

Change-Id: I04f8315eaebd5839889a771fd5c13bf43c4d8f31
Reviewed-on: https://chromium-review.googlesource.com/762529Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517891}

Only increment stability proto renderer crash rate if the crash dump is
valid.

BUG=786992

Change-Id: I63e4d24bdd9d258775bba21b611414770424d57c
Reviewed-on: https://chromium-review.googlesource.com/779480
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517890}

This reverts commit fdb31883.

Reason for revert: Causing VR segfaults https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FAndroid_VR_Tests%2F13834%2F%2B%2Frecipes%2Fsteps%2Fstack_tool_with_logcat_dump%2F0%2Fstdout

Original change's description:
> Use the LegacyLinker instead of the ModernLinker
> 
> Remove the ModernLinker since it becomes unused. Also remove the possibility to
> set the linker differently in tests.
> 
> Public document explaining the motivation: https://goo.gl/kWnHYr
> 
> BUG=719977 (google-internal)
> 
> Change-Id: I5b9b85817093b36127fa4a607bced57b4350a5b8
> Reviewed-on: https://chromium-review.googlesource.com/538582
> Commit-Queue: Egor Pasko <pasko@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517838}

TBR=pasko@chromium.org,yfriedman@chromium.org,torne@chromium.org

Change-Id: I638bd3223567a5a40babd036feca310257deaa6f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 719977 (google-internal)
Reviewed-on: https://chromium-review.googlesource.com/779921Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517889}

Change-Id: Ica3c6123f77f4838fb45b6c05669f90089a861bb
Reviewed-on: https://chromium-review.googlesource.com/777980Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517888}

This reverts commit 8de2c837.

Reason for revert:
Likely causing consistent failures in "Mac10.9 Tests (dbg)".
See: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/47340

Original change's description:
> Improvements to autocomplete suggestion announcements
> 
> Provide friendlier-sounding suggestions that are more efficient for screen reader use.
> 
> Bug: 785436
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: Ifbf93609bc274f445e8ae81cccb5cb60a705da2e
> Reviewed-on: https://chromium-review.googlesource.com/772316
> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517851}

TBR=ellyjones@chromium.org,flackr@chromium.org,jdonnelly@chromium.org,justincohen@chromium.org,rsesek@chromium.org,bsep@chromium.org,aleventhal@chromium.org

Change-Id: I31d7e24d7d7e9c2874763c27e4ecd53f349cdaaa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 785436
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/779920Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517887}

Added is_view_source boolean to VisibleSecurityState.
GetSecurityLevelForRequest now checks that flag and returns 'NONE' for
pages that would return SECURE or EV_SECURE without the flag.
Added tests that validate the new behavior

Bug: 712482
Change-Id: Ic23c20ffdb92262987dae2119148932cb9d187a6
Reviewed-on: https://chromium-review.googlesource.com/773218
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517886}

Bug: 718413
Change-Id: I51a6a4b65c51495098778226d8976d2a7136cb78
Reviewed-on: https://chromium-review.googlesource.com/779183
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517885}

Bug: 783977
Change-Id: Ib9977a73f9f8021bf9204cd594a9e40fd8d03341
Reviewed-on: https://chromium-review.googlesource.com/777553
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517884}

Also stop observing the MessageCenter, which is in another process (in
--mash).

The UMA is a little wonky, even before this change, because manually
closing the notification is not explicitly logged. It will need to be
reworked in the new style of notifications because if closing doesn't
count as "decline" then nothing does. For now this more or less
maintains existing behavior.

Bug: 783018
Change-Id: I69278c0653d8548ccd1fe6a66015b7cf08a0d08c
Reviewed-on: https://chromium-review.googlesource.com/777739Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517883}

Since we switched to error prone to do static analysis, fixing warnings
introduced by my changes.

Bug: None
Change-Id: I9b4e2593f217b424658e344957f8f4aadff2d2cd
Reviewed-on: https://chromium-review.googlesource.com/777947Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517882}

SSIA.

This is a follow up of https://crrev.com/c/644946.

TBR=spang@chromium.org
BUG=786761

Change-Id: I23b278b0e32b00b8fbfccbe0cbc89a5cc9ca4833
Reviewed-on: https://chromium-review.googlesource.com/779779
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#517881}

Currently, InstantAppsSettings.shouldShowBanner will never allow a
banner to be shown if the instant app is default, so this change allows
the banner to show even if the app is installed.

This won't change the behaviour as it stands, because we currently
launch the instant app if it's installed before we launch a banner.
The shouldLaunchInstantApp method is added for the purpose of
overriding downstream to avoid launching an instant app when we want
to launch a banner.

Bug: 781003
Change-Id: I430e29839f2592517d2583c5d7589d3044b0174e
Reviewed-on: https://chromium-review.googlesource.com/772809
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517880}