GitLab

Was no longer being used. As well, rename StartUploadProcess to
MaybeStartVoteUploadProcess.

Tbr: vabr@chromium.org
Bug: None
Test: existing
Change-Id: I7594bd79daa5f7878806de528c3e62ec0b70909b
Reviewed-on: https://chromium-review.googlesource.com/1032752
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554440}

Extracted from https://chromium-review.googlesource.com/1015743
Required in order to move Blink's scheduler/base to //base.

Bug: 783309
Change-Id: Iff610ed6da964fb6c93de070ac81916bec5dceba
Reviewed-on: https://chromium-review.googlesource.com/1032781Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554439}

Background:
The dcheck in AppListView::SetIsIgnoringScrollEvents fails when user
scroll up and down quickly. (The pagination transition starts again
before ends).

Changes:
Do not make decision based on |is_ignoring_scroll_events_| which is set
by state change animation or pagination transition. Instead, check the
animator and pagination model directly to decide whether to ignore
scroll events.

BUG=836088

Change-Id: Ic7aef13e53d299af3165082d7dfa2f89974e20c0
Reviewed-on: https://chromium-review.googlesource.com/1031207
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554438}

Bug: 831782
Change-Id: I7558d68a41f30120b6c573b9752612215e35b115
Reviewed-on: https://chromium-review.googlesource.com/1031293Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554437}

When a remote frame is navigated to about:blank#foo in --site-per-process mode
it is routed to the browser process through a RenderFrameProxyHost. It then
considers the navigation to be cross-site due to check for explicit
"about:blank" URL in DetermineSiteInstanceForURL. This causes a
cross-process navigation and Blink considers the about:blank#foo URL to be
same-document with the initial empty document. In turn, it sends a same
document commit to the browser process, which considers it a mismatch and
terminates the renderer.

This CL fixes DetermineSiteInstanceForURL to use GURL::IsAboutBlank, which
should cover various types of about:blank URLs. It also ensures that Blink
does not consider the first navigation in a provisional LocalFrame to be
eligible for same-document commit.

Bug: 833005
Change-Id: Ia7d849effbc52efb242b65ca822512bd44b016ff
Reviewed-on: https://chromium-review.googlesource.com/1031374Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554436}

Change-Id: I86cd999b70f7bf5b7437aa15b9ac610e2f1b1c70
Reviewed-on: https://chromium-review.googlesource.com/1032852Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554435}

This patch fixes a number of small issues:

- The tab model observer for the controller is attached to the tab
  model when the browser starts instead of the first tab model change.
- The 'suppressed' flag is reset if bottom sheet show requests are
  cleared.
- The didSelectTab event is blocked if the selected tab is the same
  as the previously selected tab.

Bug: 835875, 836403
Change-Id: Ic6688674d3af11e880da8666d5e85e736c6f37ec
Reviewed-on: https://chromium-review.googlesource.com/1026151
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554434}

Inspired by https://chromium-review.googlesource.com/1015743
but not moving it yet, because move will happen in one go.

Bug: 783309
Change-Id: I4ef38820accab561b73b28d9bfa9fcd2ee2f47a8
Reviewed-on: https://chromium-review.googlesource.com/1032773Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554433}

The test does not require nor use "server-side substitution" and the
flag ".sub" was left by mistake.

Bug: 611982
Change-Id: I5674911c22d1fb55e7aa41125d343966f4b8a84f
Reviewed-on: https://chromium-review.googlesource.com/1033352Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554432}

Wait until the physical threads are up and ready to service the task runners
before starting the clock to avoid depending on the time it takes to bring
up a physical thread (can be slow in simulation environments like Fuchsia+QEMU).

R=fdoray@chromium.org, wez@chromium.org

Bug: 837341
Change-Id: I7acbec7808c1aa4ad7fefdff6f80693fbfb8e74e
Reviewed-on: https://chromium-review.googlesource.com/1030904
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554431}

It was originally disabled because it was broken in mus, but it works
now.

Also update the comments for related disabled WebView tests.

Bug: 755328
Change-Id: I888957ed89a0a3fb101b965be1666e11d32ebdb9
Reviewed-on: https://chromium-review.googlesource.com/1029226Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554430}

This test fails on OS_IOS as mentioned in the bug below. So disable it to
unblock any related work. This is fine as PersistentHistogramStorage is
used only on OS_WIN now.

Bug: 836789
Change-Id: I4e86cf4053663d4736cb3242ffaf22c0a1030781
Reviewed-on: https://chromium-review.googlesource.com/1033016Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554429}

- Use the fallback Chrome logo instead of attempting to set a custom
badge as the status bar icon for all web notifications on Marshmallow
Coolpad devices, same as what we do on Samsung Marshmallow devices, to
avoid a crash.

- Tested with a Coolpad 3600i (the model experiencing most of the
non-Samsung crashes) which reports its Build.MANUFACTURER to be
'YuLong'.

R=nyquist@chromium.org

Bug: 831220
Change-Id: Id475bbda198c7c61fbb4d114bb562826ffd351e5
Reviewed-on: https://chromium-review.googlesource.com/1028271Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554428}

This CL hooks android download code to media gallery util service, which
provides the functionality to safely parse media metadata in an utility
process. Also includes necessary change to build media gallery util
service on Android.


Bug: 826021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie76992ed65b746b784374b5acefcdebe4e26fe50
Reviewed-on: https://chromium-review.googlesource.com/1028614Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554427}

This CL adds multiple user support for Crostini apps.
Crostini app window is registered to the user who launches it so when
user switch happens, Crostini app window will not leak to other users
in the session.
When user switch occurs, Crostini app windows launched by previous user
will be removed from the Shelf and Crostini app windows launched by the
current user will be added to the Shelf.

BUG=chromium:829159
TEST=Manually tested on an eve device.

Change-Id: I2983d7087ffb87764954c2e8799b29a1ba46feec
Reviewed-on: https://chromium-review.googlesource.com/1031746Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554426}

Layered API [1] is planning to insert a step that modifies |url| to
#fetch-a-module-script-tree, and thus the URLs for #fetch-a-module-script-tree
and #internal-module-script-graph-fetching-procedure can be different.
However, ModuleScriptFetchRequest::Url() has been used for both of them and
thus the same URL is used for both.

This CL stops using ModuleScriptFetchRequest for #fetch-a-module-script-tree
(i.e. ModuleTreeLinker::FetchRoot() and its callers) and instead pass URL and
ScriptFetchOptions separately, in order to modify the URL inside
ModuleTreeLinker::FetchRoot() in a following CL [2].

[1] https://github.com/drufball/layered-apis/blob/master/spec.md
[2] https://chromium-review.googlesource.com/1013321

This CL also introduced ModuleScriptFetchRequest::CreateForTest(), and
make non-test users call the full (previously private) constructor of
ModuleScriptFetchRequest.

Bug: 829084
Change-Id: I17d34475f0a85a5a1b7212d9bc8530d838e75f20
Reviewed-on: https://chromium-review.googlesource.com/1013317
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554425}

This CL was uploaded by git cl split.

R=dcheng@chromium.org

Bug: 428099
Change-Id: I50af2e37e8f60b8ca3de001d19528db50ae983a8
Reviewed-on: https://chromium-review.googlesource.com/1032464Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554424}

Bug: 790520
Change-Id: I02235478ea226e87dd7630e4c579f11fc26c2beb
Reviewed-on: https://chromium-review.googlesource.com/1031621
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554423}

Re-lands https://chromium-review.googlesource.com/1031050 after
fixes to downstream changes.

Bug: 810904
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2cb00c90d6d35cb7c4dd5cb8ac7c5ffb8746894f
Reviewed-on: https://chromium-review.googlesource.com/1033019Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Daniel Blakemore <danblakemore@google.com>
Cr-Commit-Position: refs/heads/master@{#554422}

This CL adds super.onActivityResult calls to all methods that override
onActivityResult in Activity and Fragment subclasses. This should fix
an issue when Fragment.onActivityResult isn't called when expected.
super.onActivityResult calls in activities that subclass
AppCompatActivity end up in FragmentActivity.onActivityResult that
dispatches onActivityResult calls to Fragments that have started
activities using Fragment.startActivityForResult.

Bug: 836921
Change-Id: I19550c7106ad01bf6acccb0fe0d985561c7a1f81
Reviewed-on: https://chromium-review.googlesource.com/1028690Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554421}

TBR=lukasza@chromium.org

Bug: 792546
Change-Id: I5142b81d26f7221b8fe03d70ed3b14ffeaa461d4
Reviewed-on: https://chromium-review.googlesource.com/1032881
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554420}

BUG=837312
R=dpranke

Change-Id: Ia5c57f596388a4ba325208c638fac558984202f0
Reviewed-on: https://chromium-review.googlesource.com/1030895Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554419}

This changes the DownloadURL IPC to pass along a blob URL token, and
uses that to later construct a URLLoaderFactory for the blob URL.

Only works with the network service enabled, but at least fixes ordering
issues already present with the network service and downloading soon to
be revoked blob URLs.

Eventually this should let us remove the other blob specific codepaths
from (at least the network service branch of) the downloads code.

Design doc: https://docs.google.com/document/d/1DqVcTWE9Qb_3KpIRH2bFV-6hWEr8S92c4ppY67YL1KI/edit#heading=h.pvtybbkgf0vd

Bug: 800901, 808759
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5879fdc65f4843a1296a49496fc73ed6c3a04be1
Reviewed-on: https://chromium-review.googlesource.com/1026808
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554418}

As per consensus among existing API_OWNERS

Change-Id: I64131c5c0f9daf3333603762467da8f4da40292b
Reviewed-on: https://chromium-review.googlesource.com/1030961Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554417}

Using wpt-import in Chromium 59bde77b.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16306

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
smcgruer@chromium.org:
  external/wpt/css/css-position
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=foolip

No-Export: true
Change-Id: Ib40634f3b14402635670aca7754f20d3bd8a5c4b
Reviewed-on: https://chromium-review.googlesource.com/1032814
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554416}

Change-Id: Ia2344c54f8ce6c312833c9cff23e71eb31ff67bf
Reviewed-on: https://chromium-review.googlesource.com/1033021Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554415}

This reverts commit b0468d94.

Reason for revert: https://crbug.com/837541

Original change's description:
> Adding metrics for native window occlusion count on Windows
>
> These metrics will record the number of occluded/visible/hidden native Chrome windows on Windows. This information will be polled and computed on a repeating timer. This information will be used to determine if occlusion tracking on Windows is worth pursuing going forward.
>
> Bug: 813093
> Change-Id: Icc9d18ddd6ef293aca15a787b3fc5c1d64b4a4cd
> Reviewed-on: https://chromium-review.googlesource.com/1025074
> Commit-Queue: Varun Mohan <varunmohan@google.com>
> Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554213}

TBR=rkaplow@chromium.org,sebmarchand@chromium.org,varunmohan@google.com

Change-Id: I3d97eba54f60641b7284195314e9d4bf0b65ee33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 813093, 837541
Reviewed-on: https://chromium-review.googlesource.com/1032858
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554414}

Previously, the plugin completely skipped virtual specifier checks on
Gmock objects since it wasn't smart enough to filter out warnings caused
by Gmock macros. In preparation for making the plugin smarter, this CL
fixes existing virtual specifier warnings in //base.

Bug: 837148
Change-Id: Id5e0a556b4c4c501076f586068aef4034e0156cd
Reviewed-on: https://chromium-review.googlesource.com/1031016Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554413}

This reverts commit 14f86890.

I think the flakely behaviour on Windows 10 (only) in the previous test is actually indicative of a real problem, so I'm going to revert this and reland with a clean solution, including all the tests.

TBR=engedy,nasko

Change-Id: Ia742844bea7c3be5552f5671634f8aa014cf1b90
Reviewed-on: https://chromium-review.googlesource.com/1032912
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554412}

Using a double timestamp is prone to errors, since nothing stops a
numerical quantity with the wrong units from being passed in. This CL
is part of a series to make more time interactions in Blink saner.

Bug: 763980

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2b0d6ee0b43a63a6af44352f929f57fc6d0cf82a
Reviewed-on: https://chromium-review.googlesource.com/1030908Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554411}

Previously is only deleted form the main profile table. The sub tables
need to be deleted too.

Bug: 836737
Change-Id: I1e5fc74ace5b073cc66fcece422c2fd50d208743
Reviewed-on: https://chromium-review.googlesource.com/1031311Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554410}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: Iddee22e8dbc7887d144f7991aeaaa0aa97639645
Reviewed-on: https://chromium-review.googlesource.com/1032765Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554409}

It has nothing to do with PasswordDetailsItem and probably just a copy/paste error.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iab8bc4784141d9bef3461c987a57780d4734a99e
Reviewed-on: https://chromium-review.googlesource.com/1032437Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554408}

Skip Waiting for Fullscreen for Mac in BrowserCommandControllerInteractiveTest.ShortcutsShouldTakeEffectInWindowMode

ScopedFakeNSWindowFullscreen just makes the NSWindow larger without
taking Chrome into fullscreen. As a result,
chrome::NOTIFICATION_FULLSCREEN_CHANGED does not fire.

Fullscreen appears to be performed synchronously with the keyboard
event, so skipping the wait works.

BUG=834754,837438

Change-Id: I337a44eefedfd382cc253aaf69590140fc557ba1
Reviewed-on: https://chromium-review.googlesource.com/1031617Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554407}

This CL was uploaded by git cl split.

R=dcheng@chromium.org

Bug: 428099
Change-Id: I74496862747910cda6503376d82ccbd1cedeb368
Reviewed-on: https://chromium-review.googlesource.com/1032462Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554406}

This CL was uploaded by git cl split.

R=piman@chromium.org

Bug: 428099
Change-Id: Ie75f7c7e67ccd91c1e8fd8c0e51f9c66112cfe50
Reviewed-on: https://chromium-review.googlesource.com/1032461Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554405}

This CL was uploaded by git cl split.

R=xhwang@chromium.org

Bug: 428099
Change-Id: Ie3224f24c5b43337ca9dc4e26b8301f591c9565f
Reviewed-on: https://chromium-review.googlesource.com/1032460
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554404}

R=sky@chromium.org

Bug: 428099
Change-Id: I72061d567877f53af9271a6b2cda18701c590cf9
Reviewed-on: https://chromium-review.googlesource.com/1032465Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554403}

This CL was uploaded by git cl split.

R=jochen@chromium.org

Bug: 428099
Change-Id: Ibf3ee895938492cad26720d8b1d00a9fb102b033
Reviewed-on: https://chromium-review.googlesource.com/1032466
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554402}

Adding a comment to answer a common question around Surfaces and
Picture-in-Picture behavior.

Change-Id: Ibebb4ce87aea1360db14246baf952a6384fbeb5f
Reviewed-on: https://chromium-review.googlesource.com/1030827Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554401}