GitLab

Also, this reduces duplication in comments and fixes them to refer to
RenderViewHost.

Review URL: http://codereview.chromium.org/8745009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112263 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104776
TBR=jar@chromium.org

Review URL: http://codereview.chromium.org/8749011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112262 0039d316-1c4b-4281-b951-d872f2087c98

Win SpellingBubble is accessible via textfield context menu:
"Spell-checker options"->"Ask Google..."

BUG=98323,99130
TEST=ConfirmBubble (SpellingBubble) works as before.

Review URL: http://codereview.chromium.org/8746001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104752



Review URL: http://codereview.chromium.org/8570023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112260 0039d316-1c4b-4281-b951-d872f2087c98

Remove child_process.h includes from chrome (specifically WaitForDebugger). I moved the browser process usage to content. For the NaCl usage, it wasn't working anyways since it wasn't being passed to the process (and if it was, the message box wouldn't work on Windows because of sandbox). When this is needed again, we can figure out a good way of doing it.

BUG=98716
Review URL: http://codereview.chromium.org/8686014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112259 0039d316-1c4b-4281-b951-d872f2087c98

This API replaces gdk_window_lookup and gdk_xid_table_lookup which are
deprecated in 2.24. gdk_x11_window_lookup_for_display was added in 2.24.

As well porting the users to use this new API a compatability version was
added to the ui/base/gtk/gtk_compat.h file.

BUG=79722
TEST=Compiles and ui_unittests run. Chrome also runs.


Review URL: http://codereview.chromium.org/8632021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112258 0039d316-1c4b-4281-b951-d872f2087c98

This commit also renames the histograms so we can obsolete the old names
and ignore all the stats gathered while the labels were swapped.

BUG=105777
TEST=

Review URL: http://codereview.chromium.org/8735007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112257 0039d316-1c4b-4281-b951-d872f2087c98

R=erg@chromium.org


Review URL: http://codereview.chromium.org/8741017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102792
TEST=Download a big file on unity. Should display a progress bar on the dock icon.


Review URL: http://codereview.chromium.org/8741008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112255 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105907
TBR=reed@chromium.org

Review URL: http://codereview.chromium.org/8743016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105902
TEST=
TBR=munjal

Review URL: http://codereview.chromium.org/8747019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112253 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=remoting_unittests --gtest_filter=DebugLogUnitTest.*


Review URL: http://codereview.chromium.org/8599010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112252 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81846
TEST=none

R=isherman@chromium.org

Review URL: http://codereview.chromium.org/8745018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112251 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99370
TBR=nkostylev@chromium.org

Review URL: http://codereview.chromium.org/8752002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112250 0039d316-1c4b-4281-b951-d872f2087c98

Also merge content/ MockCrControlApp into base/ MockCrApp.

BUG=102224

Review URL: http://codereview.chromium.org/8724004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112249 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112248 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8748010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112247 0039d316-1c4b-4281-b951-d872f2087c98

Should use startAnimation in acceleratorController in order for the animator to use the preemption strategy in starting the new animation.

scheduleAnimation will queue up animations. Holding down
Ctrl-Home will after a while keep on rotating well after the accelerator key has been released

Review URL: http://codereview.chromium.org/8741016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112246 0039d316-1c4b-4281-b951-d872f2087c98

Bug=82559
Review URL: http://codereview.chromium.org/8513017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112245 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2413
TEST= python idl_gen_pnacl.py --test --wnone

Also
** ./generator.py doesn't change
** ./generator.py --wnone --pnacl --pnaclshim=pnacl_shim.c
generates a shim that compiles and works in the NaCl repo.

Review URL: http://codereview.chromium.org/8568025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112244 0039d316-1c4b-4281-b951-d872f2087c98

callback_forward.h will be committed separately, before this commit, and is included here only to assist in running try jobs. It will be removed before the final commit.

You are asked to review this as you have OWNERS for these files.

BUG=None
TEST=Compiles
R=ben@chromium.org


Review URL: http://codereview.chromium.org/8699008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112243 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8549019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112242 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97845
TEST=none


Review URL: http://codereview.chromium.org/8682029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=./generator.py --wnone --cgen --range=start,end  --out private/ppb_flash_fullscreen.idl


Review URL: http://codereview.chromium.org/8735013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112239 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103351

Review URL: http://codereview.chromium.org/8750002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112238 0039d316-1c4b-4281-b951-d872f2087c98

My version of MSVC 2008 has a bug in ADL that prevents it from finding the
operators in the global namespace if the class in question is nested.  This
meant I was unable to compile the BrowsingDataQuotaHelperTest.FetchData test
because it tried to use std::set<QuotaInfo>.  Moving the operators into the
class itself solves the problem, and should work properly with all other
compilers as well.

TEST=BrowsingDataQuotaHelperTest
R=tzik@chromium.org

Review URL: http://codereview.chromium.org/8735001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112237 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105443
TEST=None


Review URL: http://codereview.chromium.org/8700013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112236 0039d316-1c4b-4281-b951-d872f2087c98

Alt-L (print layer tree)

Added name in RenderWidgetHostViewAura

Made Window::SetName update the layer name.

Review URL: http://codereview.chromium.org/8585007

TBR=pkotwicz@chromium.org
Review URL: http://codereview.chromium.org/8741018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112234 0039d316-1c4b-4281-b951-d872f2087c98

Change the way we are sending audio data to driver when using WaveOut API.
Before, we were "feeding" the driver in the callback when OS returned audio
buffer to us. MSDN disallows that, but We were avoiding deadlock when stopping
the stream by using some clever tricks. Unfortunately, exactly the same
deadlock happens when Windows were draining audio stream when switching
the device, and our tricks did not help, as we were not controlling exact timing.

Fix is to separate receiving freed buffer and "feeding" audio driver. Now we are
using CALLBACK_EVENT wave out mode in which Windows signal event when buffer runs
out of data, and using RegisterWaitForSingleObject() so our callback is called by
one of thread pool threads.

Stopping of playback became slower because now it is synchronous. If that ever
become a problem we can use singleton that keeps track of the playing audio
streams, than stopping can become instaneous, at a cost of more complex checks
in the callback.

Unfortunately, no automatic test, as there is no documented way to programmatically
switch default audio device on Windows. People were able to figure it out (see
http://www.daveamenta.com/2011-05/programmatically-or-command-line-change-the-default-sound-playback-device-in-windows-7/),
but there is no guarantee it will continue to work in Win8, or even in next Service Pack
for Win7.

BUG=41036

TEST=Play any HTML5 audio/video on Windows and change default audio device
TEST=using "Control Panel | Sound". There should be no hang, you should hear
TEST=audio from the newly chosen device.

Review URL: http://codereview.chromium.org/8591028

TBR=enal@chromium.org
Review URL: http://codereview.chromium.org/8753001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112233 0039d316-1c4b-4281-b951-d872f2087c98

Alt-L (print layer tree)

Added name in RenderWidgetHostViewAura

Made Window::SetName update the layer name.

Review URL: http://codereview.chromium.org/8585007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112232 0039d316-1c4b-4281-b951-d872f2087c98

This is follow-up from review http://codereview.chromium.org/8486020.
This eliminates down-cast of GLSurface in CLContextNSView::Initialize in favor of
GLSurfaceNSView::OnMakeCurrent implementation.  Also, allows offscreen path in USE_AURA
due to its usage in SharedResourcesCC.

BUG=104390
TEST=compositor_unittests --gtest_filter=LayerWithRealCompositorTest.*
R=apatrick@chromium.org

Review URL: http://codereview.chromium.org/8687016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112231 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening
Review URL: http://codereview.chromium.org/8748011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112230 0039d316-1c4b-4281-b951-d872f2087c98

Also remove and clean-up the remaining vestiges of NTP3 support (they were left n the code just for touch_ntp which was built against them).

BUG=105046
TEST=NTP4WebUITest.TestBrowsePages

Review URL: http://codereview.chromium.org/8689013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112229 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63671
TBR=aa@chromium.org

Review URL: http://codereview.chromium.org/8747017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112228 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112227 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105667
TBR=atwilson@chromium.org

Review URL: http://codereview.chromium.org/8752001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112226 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8520009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22841
TEST=


Review URL: http://codereview.chromium.org/8748006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112224 0039d316-1c4b-4281-b951-d872f2087c98

Probably should have just fixed the problem given the number of bad ones.

BUG=105864
TBR=sail@chromium.org
TEST=waterfall.sh match

Review URL: http://codereview.chromium.org/8742017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112223 0039d316-1c4b-4281-b951-d872f2087c98

The scores across different versions of the V8 benchmark are NOT comparable. So
this will change the raw score number and expectations will need to be reset.

BUG=None
TEST=out/Debug/performance_ui_tests --gtest_filter=V8BenchmarkTest.Perf --run-v8-benchmark
TBR=cmp

Review URL: http://codereview.chromium.org/8749001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112219 0039d316-1c4b-4281-b951-d872f2087c98