GitLab

Regression:[Devtools]Unable to close 'This script is blackboxed..' warning message without closing 'pretty print' infobar.

BUG=581606

Review URL: https://codereview.chromium.org/1641573005

Cr-Commit-Position: refs/heads/master@{#371994}

BUG=546731
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1536553002

Cr-Commit-Position: refs/heads/master@{#371993}

We used to incorrectly allow content settings to be persisted in the guest
profile. This CL prevents them from being persisted and ensures that any
existing settings are deleted.

BUG=578130
TBR=asanka@chromium.org,bzanotti@chromium.org,droger@chromium.org

Review URL: https://codereview.chromium.org/1605453003

Cr-Commit-Position: refs/heads/master@{#371992}

As is, the bots cannot finish running the tests in time.

BUG=581583

Review URL: https://codereview.chromium.org/1647713003

Cr-Commit-Position: refs/heads/master@{#371991}

The location bar, omnibox, and find in page bar should look the same in
incognito and normal windows if we're using a custom theme. Since
changing to or from a custom theme can now affect the window's decision
of which NativeTheme to use, we have to make GetNativeTheme()
overrideable as well as propagate NativeTheme changes when the browser
theme changes.

BUG=581559
depends on http://crrev.com/1638063003#ps1

Review URL: https://codereview.chromium.org/1637203002

Cr-Commit-Position: refs/heads/master@{#371990}

BUG=581793
TEST=Extended GaiaAuthFetcherTest passes
TEST=Tested together https://codereview.chromium.org/1618193003/.
     Auth code is returned for GMS Core client id and is consumed
     at Android.

Review URL: https://codereview.chromium.org/1644713002

Cr-Commit-Position: refs/heads/master@{#371989}

BUG=

Review URL: https://codereview.chromium.org/1645823002

Cr-Commit-Position: refs/heads/master@{#371988}

This CL waits until the web page has loaded before
adding the startup pages handler as an observer
of the startup pages preferences.

BUG=581503

Review URL: https://codereview.chromium.org/1634353002

Cr-Commit-Position: refs/heads/master@{#371987}

These bots won't exist temporarily as "NextGen" builders. They also
won't use swarming.

Remove the "swarming" dictionary from tab_capture_end2end_tests on the
non-swarmed testers on this waterfall.

BUG=542370
NOTRY=true

Review URL: https://codereview.chromium.org/1646793002

Cr-Commit-Position: refs/heads/master@{#371986}

Turns out gitiles doesn't support markdown tables. Changed to just be
pre-formated code block.

Horizontal rules aren't supported either, but aren't needed as there
is ample spacing.

R=ortuno@chromium.org

Review URL: https://codereview.chromium.org/1644453003

Cr-Commit-Position: refs/heads/master@{#371985}

Should work now that https://codereview.chromium.org/1642553003/ is in.

BUG=580129

Review URL: https://codereview.chromium.org/1639333003

Cr-Commit-Position: refs/heads/master@{#371984}

BUG=525873

Review URL: https://codereview.chromium.org/1631153002

Cr-Commit-Position: refs/heads/master@{#371983}

BUG=341082
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/1648513002

Cr-Commit-Position: refs/heads/master@{#371982}

Requested by Benjamin Vaughn of United Airlines via email.

BUG=
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/1640123003

Cr-Commit-Position: refs/heads/master@{#371981}

Previously FakePortAllocator didn't keep reference to TransportContext
which was causing it to be destructed prematurely and crashing
remoting_perftests.

Review URL: https://codereview.chromium.org/1644593003

Cr-Commit-Position: refs/heads/master@{#371980}

Improve InspectorTest.TestFileSystem to support Entry.remove method.

BUG=None
R=pfeldman

Review URL: https://codereview.chromium.org/1641063002

Cr-Commit-Position: refs/heads/master@{#371979}

Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].

This data will be used in subsequent changes so no change in
behavior, no new tests.

[1] #!/bin/bash -v
# create an array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
 sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
   -e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c

BUG=570150

Review URL: https://codereview.chromium.org/1645443002

Cr-Commit-Position: refs/heads/master@{#371978}

BUG=540864

Review URL: https://codereview.chromium.org/1647653003

Cr-Commit-Position: refs/heads/master@{#371977}

This bug was exposed in https://codereview.chromium.org/1611783002

BUG=581909

Review URL: https://codereview.chromium.org/1643833002

Cr-Commit-Position: refs/heads/master@{#371976}

The old tests simply hardcoded various size strings.  This was brittle against
changes, and did not work correctly in material design.

The new tests basically compute the important aspects of various bounds, without
simply calling into the real OBFVL positioning functions (which would make the
tests vacuous).  These are sufficiently parameterized to handle not only
material design but a variety of other state changes (maximized vs. restored,
hidden caption buttons, caption buttons on left, etc.).  This unfortunately
results in fairly complicated math, but frame positioning is complex, so there's
not much for it.

Many of these states were tested in sort of a one-off fashion, but the tests
have now been expanded to run a significantly more complete set of tests, in
particular testing just about everything in both restored and maximized mode.

As part of this rewrite, the tests now make use of some of the constants from
opaque_browser_frame_view_layout.cc, which have been exposed in the header for
this purpose.  Along the way, some of these were simplified a bit when we had
several constants that had the same value and served similar purposes.

BUG=575257
TEST=Unittests pass even with --top-chrome-md=material[-hybrid]

Review URL: https://codereview.chromium.org/1643453002

Cr-Commit-Position: refs/heads/master@{#371975}

BUG=581807

Review URL: https://codereview.chromium.org/1646703002

Cr-Commit-Position: refs/heads/master@{#371974}

BUG=581753
TEST=manual

Review URL: https://codereview.chromium.org/1646543002

Cr-Commit-Position: refs/heads/master@{#371973}

BUG=574938
TEST=PaintLayerPaintTest.PaintPhaseFloat

Review URL: https://codereview.chromium.org/1581593003

Cr-Commit-Position: refs/heads/master@{#371972}

Nothing uses these on Mac.

They're used a lot on ChromeOS. On Windows, it shows a default browser
selection dialog. On Linux it shows the certificate viewer. On Mac I
think it was once used for a webui task manager.

BUG=None

Review URL: https://codereview.chromium.org/1640043002

Cr-Commit-Position: refs/heads/master@{#371971}

Unconditionally requesting the browser's toolbar view causes a null deref.  Try
to guard by checking if the toolbar is visible first.  This should fix the crash
unless at this point the toolbar feature is turned on but the toolbar view
itself has not been created.  Hopefully that's not the case.

BUG=581673
TEST=none
TBR=sky

Review URL: https://codereview.chromium.org/1649493003

Cr-Commit-Position: refs/heads/master@{#371970}

BUG=575234,578828
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1629013002

Cr-Commit-Position: refs/heads/master@{#371969}

For extended desktop (non mirrored) layouts, |displays_| should only
provide input parameters to the UI. Iteration over display layouts
should occur in DisplayLayoutManager. This is necessary to support
fake display layouts for testing (and provides a cleaner abstraction
in general).

This also fixes a couple of bugs related to changing the number of displays introduced in other recent re-factoring.

BUG=576375

Review URL: https://codereview.chromium.org/1648493002

Cr-Commit-Position: refs/heads/master@{#371968}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/497b8970..e85d78f6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1641793005

Cr-Commit-Position: refs/heads/master@{#371967}

Otherwise, ACK buffer will buildup in BlimpMessageOutputBuffer.

Review URL: https://codereview.chromium.org/1643813002

Cr-Commit-Position: refs/heads/master@{#371966}

This change alters SdkMediaCodecBridgeTest.DoNormal in
order to not have it assume that the AudioOutput will
get dequeued in three batches. While this is the maximum
number, some devices batch output (e.g. MT 8127 and MT 8135
chipsets), thus reducing the total number of dequeues required.

Since we also know the expected size of the output, this
test now also verifies the full expected output stream
has been dequeued.

BUG=578881

Review URL: https://codereview.chromium.org/1601863002

Cr-Commit-Position: refs/heads/master@{#371965}

The sync_id was int. This CL changes its type to string so
that it is more flexible and consistent with DevTools API's
preference. Now the tracing controller uses
base::GenerateGUID() to generate the ID.

BUG=542390

Review URL: https://codereview.chromium.org/1644653002

Cr-Commit-Position: refs/heads/master@{#371964}

Revert of Fails QUnit.test() after a timeout of 5 seconds. (patchset #2 id:80001 of https://codereview.chromium.org/1638753003/ )

Reason for revert:
Test failing on Linux and Mac.

Original issue's description:
> Fails QUnit.test() after a timeout of 5 seconds.
>
> Summary of changes:
> 1. Fails QUnit.test() it doesn't return within 5 seconds.
>    Timing dependent tests should use fake timers instead.
> 2. Adds an option to disable the timeout when debugging failed tests
>    locally.
> 3. Logs the current test to the console to ease debugging.
>
> NOTRY=true
>
> Trybots failing on tests that has already been deleted.
>
> Committed: https://crrev.com/ed48a6910aace9ad86ef10c2ecdfeae1bb31a40c
> Cr-Commit-Position: refs/heads/master@{#371890}

TBR=jamiewalch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1642643003

Cr-Commit-Position: refs/heads/master@{#371963}

This CL has no behavior changes.

BUG=537815
NOTRY=true

Review URL: https://codereview.chromium.org/1640293005

Cr-Commit-Position: refs/heads/master@{#371962}

https://chromium.googlesource.com/skia.git/+log/bbb6dc80fdfe..1c971faab7b2

$ git log bbb6dc80f..1c971faab --date=short --no-merges --format='%ad %ae %s'
2016-01-27 mtklein SkPngFilters: use normal pointer types.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1641953002

Cr-Commit-Position: refs/heads/master@{#371961}

This was intended only for use with NPAPI (now dead), and causes issues by thinking it can activate the DirectComposition child window.

BUG=580938

Review URL: https://codereview.chromium.org/1630873003

Cr-Commit-Position: refs/heads/master@{#371960}

BUG=561867

Review URL: https://codereview.chromium.org/1624853005

Cr-Commit-Position: refs/heads/master@{#371959}

The spec says that retry field is valid when the value consists of only ASCII
digits.
Currently Chrome accepts "retry: 12a", "retry:    5", etc. This change fixes
it.

BUG=578709

Review URL: https://codereview.chromium.org/1601553004

Cr-Commit-Position: refs/heads/master@{#371958}

TBR=phajdan.jr@chromium.org
R=mmoroz@chromium.org
BUG=581762

Review URL: https://codereview.chromium.org/1644743002

Cr-Commit-Position: refs/heads/master@{#371957}

https://codereview.chromium.org/1639223003/ makes it so clients can
use whatever ids they want for windows. This means when surfaces
resolve ids they need to resolve the id against the client that
submitted the frame. This patch does that.

BUG=566155
TEST=covered by tests
R=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/1640253003

Cr-Commit-Position: refs/heads/master@{#371956}

net::IOBuffer should be forward declared. This requires a number of
source files to add their own includes where they use net::IOBuffer.

BUG=None

Review URL: https://codereview.chromium.org/1642493005

Cr-Commit-Position: refs/heads/master@{#371955}