GitLab

This patch fixes a crash that occurred when checking the available
voices. Previously, we were assuming that TtsVoice objects, returned by
chrome.tts.getVoices(), had a certain structure e.g. that the voice
property was always set. This is not always the case, and the
documentation states that all properties are actually optional.

We now perform an error check before accessing TtsVoice.lang, which
was the root of the issue. The test suite has been updated to check
this case as well.

Bug: 923068
Change-Id: I5936ab683c46add944bd915b7722733dbdf761bd
Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163153
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762095}

Windows native spell checker integration in Chromium is still under
development and the two associated feature flags must be extended.

Bug: 978460
Change-Id: I10b252b84fd728b79f73f32e568c644830e3573f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163154Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#762094}

These changes were manually added into build.gn file for androidx
migration. They are no longer needed now that the import calls have
moved over.

Bug: 1067050,1067070
Change-Id: Ia7cd36bf52b39444a2dec6bdc065e41b187a2c1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160011Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762093}

This change:
1. Adds a new enum to ax_enums.mojom.
2. Creates a new output rule for IME candidates.
3. Adds a new method to PhoneticData to get phonetics for text.
4. Cleans up the goog.require() statements in output.js.

Bug: 1034146, 1056062
Relnotes: ChromeVox gives phonetic readings for IME candidates.

Change-Id: Idc620f2ef4b06dfcbf6f494ac900f92ee92831d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151852
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762092}

https://skia.googlesource.com/skia.git/+log/513720f28ece..ed6e82796bde

git log 513720f28ece..ed6e82796bde --date=short --first-parent --format='%ad %ae %s'
2020-04-23 csmartdalton@google.com Add a flag for suppressing tessellation shaders
2020-04-23 egdaniel@google.com Track d3d resources using sk_sp instead of raw pointers.
2020-04-23 jcgregorio@google.com Revert "Move SkFrontBufferedStream into Android-only dir"

Created with:
  gclient setdep -r src/third_party/skia@ed6e82796bde

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jcgregorio@google.com
Change-Id: I80661542f6af5f5b143deebad95307949755d21d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163461Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762091}

Do not announce a route has been navigated to when a OS Settings search
result is clicked/entered upon.

Fixed: 1071283
Change-Id: I522643ffa7d18afd49699eb83e6dabb7e059261b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158685
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762090}

Added the property to iOS CI and try builder definitions. Recipe side
change consuming the properties: crrev/c/2161434

Bug: 1072033
Change-Id: Id14eee275d92b4620156a99ec2d764767f204544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161624
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762089}

https://pdfium.googlesource.com/pdfium.git/+log/7f446cc3c798..dacaac7b0f29

git log 7f446cc3c798..dacaac7b0f29 --date=short --first-parent --format='%ad %ae %s'
2020-04-23 bravi@microsoft.com Implemented URI Action Handling for links
2020-04-23 thestig@chromium.org Fix nits in StructElement code.
2020-04-23 thestig@chromium.org Do IWYU to fix building with gcc.
2020-04-23 thestig@chromium.org Auto format GN build files.

Created with:
  gclient setdep -r src/third_party/pdfium@dacaac7b0f29

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:994500
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I860977fb5ed2a5b74398b98891480677f9ccd865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163457Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762088}

Change-Id: Ie44434f04b903ed4ae66098be3ac7d8ebfccf3d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163434Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762087}

This CL migrates device UI strings to a per-page provider and adds
TODOs for adding relevant search tags.

Bug: 1069849
Change-Id: Ia1c5a845ed54e377d8db6f4880759d9dca7f13b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162106
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762086}

Change-Id: Ic33e18618ad0dcc63c233d97d9c9f87132241f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163410Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762085}

After we merged the new GpuBenchmarking::SmoothScrollByXY, which has two
delta values, for vertical and horizontal scroll deltas, we should this
new function for all the scroll functions in resources/gesture-util.js.
So here we change wheelTick function to take deltaX and deltaY instead
of one delta and direction values, so now scroll deltaX and deltaY can
be different values.

Bug: 1047176
Change-Id: If692c7b807e9d2d5a00fefe09ce4b00a9be0c4f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161651
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762084}

This is symptomatic of crbug.com/1047818, but to stop the pain for
sheriffs lets mark it timeout=long for now.

Bug: 1073865
Change-Id: I60fa045c61402ec5c6df21c62918df5c109df5cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163081
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Auto-Submit: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762083}

Bug: 1073990
Change-Id: Icabcf162477719893fd0d84761bfad327ed764a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163253
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Auto-Submit: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762082}

The @property rule is relevant for CSS Typed OM, because the syntax of
a registered custom property can now be changed several times, or even
revert back to unregistered. This affects how values should reify.

Bug: 973830
Change-Id: I0ad5ba843b89d9153657e8b3f464e2dd33659cd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160894
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762081}

This was erroneously removed from r761522.

TBR=npm@chromium.org

Change-Id: I8245dc8f175b53b31c8b8d90b22ada8306dc6684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163418Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762080}

The created SkBitmap was not set to |splash_icon| correctly and it will
always be null.
Add a "splash_icon = " to fix that.

Bug: None
Change-Id: Id229c1658612b092cbaf5452dc9a7a250207f567
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163075
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762079}

This reverts commit 2864cb50.

Reason for revert: Reland with fix, see investigation in
https://crbug.com/1056216

Original change's description:
> Revert "Roll libunwind 43bb9f8722..d999d54f4b"
>
> This reverts commit 74270ce2.
>
> Reason for revert: Apparently causes crashes, https://crbug.com/1055188
>
> Original change's description:
> > Roll libunwind 43bb9f8722..d999d54f4b
> >
> > ...and enable Wbitwise-conditional-parentheses on android.
> >
> > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/43bb9f8722..d999d54f4b
> >
> >  Fix a -Wbitwise-conditional-parentheses warning in _LIBUNWIND_ARM_EHABI libunwind builds
> > 11b0129 [libunwind] Treat assembly files as C on mingw
> > 76f6916 [libunwind] Fix building standalone after c48974ffd7d1676
> > aea9f89 [libunwind] Set LIBUNWIND_ASM_SOURCES to the ASM source language from C
> > e4cbc26 Bump the trunk major version to 11
> > e12b248 [libunwind] Fix evaluating DWARF operation DW_OP_pick
> > c3889d9 [unwind] Don't link libpthread and libdl on Fuchsia
> > 81f7e17 [libunwind][RISCV] Add 64-bit RISC-V support
> > baf07ac Reland "Enable `-funwind-tables` flag when building libunwind"
> > 2ef1190 Revert "Enable `-funwind-tables` flag when building libunwind"
> > 2fd0a70 Enable `-funwind-tables` flag when building libunwind
> > f939ab7 [libunwind] Emit dependent libraries only when detected
> > 4cd4dca [libunwind] Adjust the signal_frame test for Arm
> > 0b1d80f change LLVM_VERSION_SUFFIX default from svn to git
> > b6a6639 Correctly update isSignalFrame when unwinding the stack via dwarf.
> > e7f96ac unwind: restore the LINKER_LANGUAGE
> > e24563d unwind: reflow some of the build rules (NFC)
> > f2c3035 unwind: disable RTTI during the build of libunwind
> > a4a7180 Revert "build: explicitly set the linker language for unwind"
> > ccff66b build: explicitly set the linker language for unwind
> > a914ec1 [libunwind] [Windows] Add a log message if EnumProcessModules fails
> > 2a4f136 [libunwind][Android] Fix findUnwindSections for ARM EHABI Bionic
> > b6bfd8b [libunwind][Android] Improve workaround for PIE zero-dlpi_addr bug
> > 1073ad9 [libunwind] Fix issues introduced in r374606
> > cfb6df8 [libunwind] Refactor CMake flag checks to match libc++ and libc++abi
> > 57be2d2 [libunwind] Adjust libunwind_01.pass.cpp test for ARM EHABI
> > 5342138 Unwind: avoid warning about unused typedef
> > 78b42cc Unwind: prevent unw_get_proc_info from returning stale data
> > 2aa34a8 unwind: remove a could of extraneous `else` (NFC)
> > c699521 [runtimes] Don't depend on libpthread on Android
> > 9d72a29 [libunwind][ARM] Fix types in _Unwind_VRS_Get.
> > d003462 [libunwind][ARM] Fix loading FP registers on big-endian targets
> > 558e694 Bump the trunk version to 10.0.0svn
> > 8d9ed37 [libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets
> > 0baf612 [libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto
> > b5b4a50 [Docs] Modernize references to macOS
> > 7aecb76 [CMake] Use find_package(LLVM) instead of LLVMConfig
> > e2fa4a0 [runtimes] Use -Wunknown-pragmas for the pragma check
> > 0e59516 [runtimes] Check if pragma comment(lib, ...) is supported first
> > 7b72703 [runtimes] Support ELF dependent libraries feature
> > 06a69dc [libunwind] [test] Fix inferring source paths
> > 1f9c24d [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++
> > 7611bf2 [PPC] Fix 32-bit build of libunwind
> > 8a6fc69 [PPC64][libunwind] Fix r2 not properly restored
> > 7f90e76 Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force
> > 22e7c0c [gn] Support for building libunwind
> > 103afa4 [NFC] Fix typo in debug log
> > f5d6a44 Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)
> > f8c730d [NFC] Move the export attribute after extern "C".
> > 59d0c60 [NFC] Correct outdated links to the Itanium C++ ABI documentation
> > 01fc413 [libunwind] Fix the typo in unw_save_vfp_as_X alias
> > 2b63e62 Move the alias definition of unw_getcontext to within !defined(__USING_SJLJ_EXCEPTIONS__)
> > 2ec9ffc [libunwind] Export the weak alias in Mach-O
> > 9bbfad5 [libunwind] Export the unw_* symbols as weak symbols
> > e63f955 [libunwind] Do not share an object library to create the static/shared libraries
> > 2a2b62e Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/"
> > 9021011 [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/
> > 4287808 [CMake][libunwind] Define add_target_flags which is missing
> > 3674fe4 [CMake] Don't cache LLVM_MAIN_SRC_DIR
> > 99b7c05 [CMake] Support compiler-rt builtins library in tests
> > a6a888a [CMake] Support CMake variables for setting target, sysroot and toolchain
> > 5f5036e Provide a placement new definition for the SEH version of UnwindCursor
> > 36f6154 [libunwind] Provide placement new definition
> > f50a5ed [libunwind] Remove the remote unwinding support
> > 370ec3f [CMake] Use correct visibility for linked libraries in CMake
> > a0f0700 Revert "[CMake] Use correct visibility for linked libraries in CMake"
> > d6e1714 [CMake] Use correct visibility for linked libraries in CMake
> > 809c2b5 [libunwind] Support building hermetic static library
> > ac0d9e0 Drop the dependency on <algorithm>, add placement new inline
> > 8835912 Adjust documentation for git migration.
> > fafb21e Don't define unw_fpreg_t to uint64_t for __ARM_DWARF_EH__
> > a9ccb4e Revert "[libunwind] Drop the dependency on <algorithm>, add placement new inline"
> > cf8d0d6 Revert "[CMake] Use __libc_start_main rather than fopen when checking for C library"
> > b31f294 [libunwind] Drop the dependency on <algorithm>, add placement new inline
> > 6a3a019 [CMake] Use __libc_start_main rather than fopen when checking for C library
> > 1f978e9 [libunwind] Use placement new to avoid dependency C++ library
> > 06be328 [libunwind] Don't abort if encoutering invalid .eh_frame_hdr
> > 059a163 Silence warnings about unused parameters
> > 13d23c8 Remove an unused variable
> > 688e594 Add casts to avoid warnings about implicit conversions losing precision
> > 985a1d1 Fix warnings about printf format strings
> > 55b1c00 Enable LLVM_ENABLE_WARNINGS when building standalone out of tree
> > 0dc7999 Fix typos throughout the license files that somehow I and my reviewers
> > 61860a5 Update more file headers across all of the LLVM projects in the monorepo
> > 60b38b7 Install new LLVM license structure and new developer policy.
> > 9180f77 [SjLj] Don't use __declspec(thread) in MinGW mode
> > 14d9c7b Bump the trunk version to 9.0.0svn
> > b9268be Update year in license files
> > 9f2f07a [Sparc] Add Sparc V8 support
> > 38d0a65 Revert "[Sparc] Add Sparc V8 support"
> > d71bc56 [Sparc] Add Sparc V8 support
> > ce15011 [SEH] Add initial support for AArch64
> > cba83c3 [AArch64][libunwind] Unwinding support for return address signing with B Key
> > 4d8e431 [AArch64][libunwind] Unwinding support for return address signing
> >
> > Bug: 1016947
> > Change-Id: I37d815a111ce4a5cf4a246fc4558d8c7ba5f7fad
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062638
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Auto-Submit: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#743604}
>
> TBR=thakis@chromium.org,thomasanderson@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1016947
> Change-Id: I057e99ca246ea87fbcc8799f3ba157915e24a54b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068735
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#743922}

TBR=thakis@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1016947,1056216,1055188
Cq-Do-Not-Cancel-Tryjobs: true
Change-Id: Ib8da66625a45529fb5f9d7ac407bae67bf569cb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163440
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762078}

In bringing Switch Access up to the visual specification, the menu is
being rewritten directly in views/.

This change adds the remaining buttons that may appear in the menu, as
well as adding the ability to specify which buttons are displayed and
firing an event when the button is pressed.

This code is not yet used by the feature; it will be fully incorporated
in a follow-up change.

Relnotes: N/A
Bug: 973719
Change-Id: Ibc3c820b2ad791ee8107ce86da75ba52471e71ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151826
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Auto-Submit: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#762077}

TBR=govind@chromium.org

Change-Id: I2fab28f9edee8fbdb9987e83777bc18b58b2f8a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163155Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762076}

While migrating ExecutionContext to LocalDOMWindow, several helpers
were introduced on Document (From(), DynamicFrom(),
ToExecutionContext()). This CL removes usage of these types from this
directory.

From() and DynamicFrom() are replaced with the standard
downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced
with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(),
or Document::GetExecutionContext(), whichever is most direct from the
callsite.

Bug: 1029822
Change-Id: I2f027d0fa2553367195e71359234b9a455c599a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112988
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762075}

Update cros_healthd telemetry handling code to check for and log errors
from BatteryInfo request.

Bug: chromium:1041153
Change-Id: Ic88d6146cfd81468d7023f02f7e4d0671e05a68f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153603
Commit-Queue: Trent Begin <tbegin@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Paul Moy <pmoy@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762074}

This simplifies the process of updating the buckets by moving the
defaults to a common location and highlighting the differences between
the versioned and master-only settings. Each file is no longer relying
on scoped defaults being set by another file executing it. It also has
the benefit of being able to see what is different between the branches
by doing a simple diff of the bucket files.

Change-Id: Ifc08e477c1d212a68f6cbe016ca93c4f1176501e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158917
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762073}

1. Fix some typos.
2. Some links are out-of-date.

Bug: 775198
Change-Id: I11d56530427d61c727ece0c8632d40b7e8faca9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163627
Auto-Submit: Lijin Shen <lazzzis@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762072}

This makes OnFileAttached an alternative to legacy policies to
configure scanning settings. This is gated by a new feature.

Bug: 1067631
Change-Id: Ib97200da493176a7a4254d2f891c1625c85d42cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162268Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762071}

This relands commit c71eaf36.

difference to original: leave a temporary ChannelDefinitions.java behind
so the clank compile doesn't break.

Original change's description:
> Componentize ChannelsInitializer
>
> ChannelDefinitions is made into an abstract class that exposes
> functionality to ChannelsInitializer, and defines useful types like
> PredefinedChannel. The channel definitions themselves live in the
> Chrome subclass, ChromeChannelDefinitions. Some of these definitions
> will be duplicated later for WebLayer.
>
> ChannelsInitializerTest uses ChromeChannelDefinitions so it's left
> in //chrome. (We could replace ChromeChannelDefinitions with a
> TestChannelDefinitions, but that would reduce coverage of production
> code.)
>
> Both the channel IDs and the channel group IDs will have to be different
> for WebLayer. It would be possible to account for this in code by
> judiciously prepending "org.chromium.weblayer.", and then keeping
> the channel definitions together, but that was both more complicated
> and seemed more error prone, as it would mean that the
> ChannelDefinitions.ChannelId type would no longer represent the Android
> system notification channel identifier. For example, code that used
> NotificationManagerProxy.getNotificationChannel() would have to be
> careful *not* to pass ChannelDefinitions.ChannelId without adding a
> prefix. In Chrome, which has no prefix, this would succeed, but in
> to-be-shared code, such as NotificationCompatBuilder, this would succeed
> for Chrome and fail for WebLayer.
>
> Bug: 1069895
> Change-Id: I55890466797aafc34ef8a821a1cb43de8e3d03ab
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150066
> Commit-Queue: Evan Stade <estade@chromium.org>
> Auto-Submit: Evan Stade <estade@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Xing Liu <xingliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#761922}

TBR=dtrainor@chromium.org,peter@chromium.org,xingliu@chromium.org
Bug: 1069895

Change-Id: I55cda0a935c2bc204e2ed00d4f6b64997c879843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163407Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762070}

This change adds a new test that covers the behavior of the button row,
as a prerequisite to a refactor of the button row's implementation. This
test does overlap with some of the other tests in this suite,
especially the button width linking tests.

Bug: 1011446
Change-Id: Ib7b60dbed5725f6e26a063bd851911d85cba53ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163394Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762069}

GpuInfoService is used for GPU info collection and is running on the
short-lived info-collection GPU process only.
This CL separates GpuInfoService from the regular GpuService because it
is not running on the same GPU process.

Bug:1048903

Change-Id: I6f11cbfec8b17d4e5c4ac9865b26542aa6dd619d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154388Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762068}

Enabling shelf controls disables gestures and should hide contextual
nudges related to gestures.
This CL changes the back gesture nudge controller to observe the shelf config and hide/disable the nudge when shelf controls are enabled.

Bug: 1071248
Change-Id: If43f22bb108660f8725b6d660e849d0317ddcd7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161734Reviewed-by: Yulun Wu <yulunwu@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762067}

And fix a couple things. We should now be able to fetch content
from the production server.

- Set app_type back to TEST_APP
- I've replaced the old test feed query response with a new one
  from the new server. I've hand-edited the response to remove
  content that might be copyrighted, but it's unchanged other
  than that.
- Use our proto-printers to simplify the
  stream_model_update_request_unittest
- Add more .sh scripts to translate protos, making them all
  pipe stdin/stdout.

Bug: 1044139
Change-Id: Ib0053471ff732b3f4d6fe6ef653c17c41769ce62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154811Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762066}

Our two flavors of sqlite_shim.c #include rename_exports.h and
sqlite_shim_fixups.h. These dependencies need to be recorded in
BUILD.gn, so incremental builds work correctly.

Change-Id: I13f3eaf26bdfaaf0be2d458eae07e7d9281833ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162046Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762065}

Bug: 1065879

Change-Id: I05ca50043d8efbcdc3ae6d4767fb289162d85198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127911
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762064}

https://swiftshader.googlesource.com/SwiftShader.git/+log/dc688a2f5c55..ba47db02daff

git log dc688a2f5c55..ba47db02daff --date=short --first-parent --format='%ad %ae %s'
2020-04-23 amaiorano@google.com Kokoro: fix SWIFTSHADER_LESS_DEBUG_INFO not being set

Created with:
  gclient setdep -r src/third_party/swiftshader@ba47db02daff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Iac1d08a428e6a7215b83bcac6dee427ac56f1c3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163451Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762063}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0f15c2729b8c..7a0b07a8a543

git log 0f15c2729b8c..7a0b07a8a543 --date=short --first-parent --format='%ad %ae %s'
2020-04-23 brucedawson@chromium.org Fix slash direction sensitivity in git cl owners

Created with:
  gclient setdep -r src/third_party/depot_tools@7a0b07a8a543

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1009104
Tbr: agable@chromium.org
Change-Id: I0d1b9ae8a2a295995a46aace214e7b8d93dea047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163453Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762062}

This test was running with an average speed close to its timeout and
was occasionally exceeding it, causing flakes. Marking it as slow as
per wpt guidelines.

Bug: 1073460
Change-Id: I2028d64ed727242ec3873c5172a08ecebbc45a73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163395
Commit-Queue: George Steel <gtsteel@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762061}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5d77448b5f68..ee97fa3e34e3

git log 5d77448b5f68..ee97fa3e34e3 --date=short --first-parent --format='%ad %ae %s'
2020-04-23 tvanderlippe@chromium.org Add ts_library definitions and ts-nocheck for Karma tests

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@ee97fa3e34e3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1061125
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Id906789ef4e3eadb763e10189e92c2af8f9d3937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163449Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762060}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8094fa603805..255d5014a0f2


Created with:
  gclient setdep -r src-internal@255d5014a0f2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1029357,chromium:1072472
Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com
Change-Id: I02039dfb24274701001f60caa114da3e2c4c0a46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163446Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762059}

Screenshots of the more complicated changes: https://imgur.com/a/9rTOCeK

Bug: 973674, 686905
Change-Id: Id55a0676982ffc46fca0d4d1edbb33b55e068218
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154226
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762058}

This CL adds tests to ensure that transitions work as expected with
@property. The most "unique" case related to @property is perhaps that
re-declaring a custom property with a different initial value can
actually start a transition.

Bug: 973830
Change-Id: Ib97837e6dcf53af7fbfbaa8ff258d3e3041001eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161825
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762057}

This CL updates the app launch confirmation overlays to use the new
AlertRequest and AlertConfig objects.  This allows for the removal of
the app launcher overlay mediator, allowing the app launch confirmation
dialog to use the shared AlertOverlayMediator implementation.

Bug: 1071543
Change-Id: Ic0548bbdeb728a9465fe013e1201e434413386f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155475
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762056}