- 06 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dbbc1ffe9924..d3b495fd53af 2020-08-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id69a8e9dc885dc0af55f45ff5fb979a1cc48fc0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340928Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795394}
-
Jose Dapena Paz authored
Build with libstdc++ fails: ../../base/cpu.h:93:15: error: ‘vector’ in namespace ‘std’ does not name a template type 93 | static std::vector<CoreType> GuessCoreTypes(); Bug: 957519 Change-Id: I83808e1714146c6fa1dbefea205620c600b32e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339339Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#795393}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8bc27a1cfbc1..5fd92a7e0c84 2020-08-05 jaebaek@google.com OpenCL.DebugInfo.100 DebugTypeArray with variable size (#3549) 2020-08-05 andreperezmaselco.developer@gmail.com spirv-opt: Improve the code of the Instruction class (#3610) 2020-08-05 vasniktel@gmail.com spirv-fuzz: Handle OpPhis in livesafe functions (#3642) 2020-08-05 vasniktel@gmail.com spirv-fuzz: Handle OpPhi during constant obfuscation (#3640) 2020-08-05 vasniktel@gmail.com spirv-fuzz: Fix FuzzerPassCopyObjects (#3638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I68882922b1ce41aa0ad6b3ae2d1cd3437e3c9cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340575Reviewed-by:
-
Yuke Liao authored
Win PGO trunk builders are having issues and result in uploading broken profiles. The auto rollers have been stopped and this CL reverts their profiles to last known good versions. Bug: 1113316 Change-Id: I51c3d4533a0f0845a302d9f71c8a18df33775fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340114 Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#795391}
-
Maxim Kolosovskiy authored
Bug: 1086114, 1092444 Change-Id: I2906d756d0090734b23a711da27f497ec7296937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336595 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795390}
-
Benoit Lize authored
Bug: 1112840 Change-Id: Ie903e92ac8d393c6cf1c0123656c4270cc9df113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339476 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1362c1eac458..7a171cca0ca4 2020-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6c873cfde957 to bedac4f06b5c (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1104516 Tbr: herb@google.com Test: Test: Test: CQ Change-Id: I11a7da040639041e1f7826d8f8847029b92ecc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340929Reviewed-by:
-
Wan-Teh Chang authored
Do not DCHECK CanDecodeToYUV() is true in GetYUVSubsampling(), because GetYUVSubsampling() is called by the hardware decoding code paths, not by the decoding-to-YUV code paths. Do not assert that the AVIF_PIXEL_FORMAT_YUV400 case is not reached, because that is the YUV format of monochrome AVIF images. Please refer to https://crrev.com/c/2327461. Bug: 915972 Change-Id: Iced2abe0f86b0f407855c371dbf5e6abef561946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340071Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795387}
-
Peter Kasting authored
* Error and warning icon use was reversed from Material guidelines, other Chrome use, etc. Swap these to fix. * "Warning" icon + "normal" color doesn't make sense; use the warning color there. * Apply the same styling to the filename in |file_name_label_| as in the other labels. This only has a visible effect when new-style warnings are enabled. * Schedule a paint when |complete_animation_| ends, too, not just when it progresses; this ensures the download item doesn't get "stuck until mouseover" when canceling, for example. Bug: none Change-Id: Icffc49980c23c3b42133c5c54af195924b33084c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333658 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795386}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a28c7896f97f..32be4523385c 2020-08-06 fancl@chromium.org chromeperf: Return multiple change points in FindChangePoints If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1091864 Tbr: oysteine@google.com Change-Id: I32296c69cb27fde4a1bfc7aa40f4647c27aea6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340927Reviewed-by:
-
Yutaka Hirano authored
RenderFrameImpl::WillSendRequest creates ThrottlingURLLoaders for redirects, which is weird because ThrottleURLLoader's lifetime spans across redirects. Bug: 1112310 Change-Id: Ib40f45cb0f044fea23cf5499ea94f421ad482c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335293Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#795384}
-
Eric Willigers authored
We do not enforce permissions policy for Web Share. Instead, we use count if permissions policy would have allowed or rejected the share. https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/E90gFDnqAQAJ Bug: 1079104 Change-Id: I003a5940bdcac3e567ede9ff17f174b3a912267b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336382 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#795383}
-
Eric Willigers authored
As discussed in github, the ShareData dictionary now contains a sequence instead of a FrozenArray. https://github.com/w3c/web-share/issues/165 Bug: 1112600 Change-Id: I58238f36158902ddcacf228ab32cd3ffbffdf2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327774 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL adds the wiring of the delete call to the native side. The actual deleting does not happen yet. Bug: 1108358, 1092444 Change-Id: Ibe312ca2eb5218188e8eefe3a064ad005a75b0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332825Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795381}
-
Christian Dullweber authored
Bug: 1104836 Change-Id: Icb2c9b31aea8d523d2dfbeaf67e7e92bd160a94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328907Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#795380}
-
Morten Stenshorne authored
Not sure what (or who) fixed it, but it's no longer flaky. Adding a simplified and non-flaky test that also passes now. Bug: 1066640 Change-Id: Ia82810e240eab6f3ee955afe89ebeeffebf808d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339521Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#795379}
-
chrome://flagsAlexey Baskakov authored
This reverts commit dcf6cef1. Reason for revert: Fails https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/7545 Original change's description: > Reland "Tab Search: Add chrome://flags entry for Tab Search" > > This is a reland of 5da77d64 > > Original change's description: > > Tab Search: Add chrome://flags entry for Tab Search > > > > This addition is necessary to allow users to disable the feature once > > the experiment is enabled. > > > > Bug: 1099917 > > Change-Id: I4e537a1fe92d1329c75ff8c190f92ce7f1cde8b7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336020 > > Reviewed-by: Robert Liao <robliao@chromium.org> > > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#794867} > > Bug: 1099917 > Change-Id: I639aea54269a221d32049f98b715b4853c94f2bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339922 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795337} TBR=robliao@chromium.org,tluk@chromium.org Change-Id: I5b4d345cc87d982139157babd52918c2fd89e70d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340353Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#795378}
-
Milica Selakovic authored
Reland https://chromium-review.googlesource.com/c/chromium/src/+/2332164 with proper sha1 file instead of png. Previous cl was reverted because: IDS_AUTOFILL_ASSISTANT_INIT_MESSAGE_PASSWORD_CHANGE.png.sha1 needs to be a sha1 not a PNG file Bug: 1110309 Change-Id: I50ba1f30e9b0bd6ed1539216b05cffdf3f0a614d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339324Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Milica Selakovic <selakovic@google.com> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#795377}
-
evliu authored
This CL updates |CaptionBubble::OnTextChanged| to support non-ASCII characters. Bug: 1111919 Change-Id: I1733160390f4e3fd6cae5da6d02edbcee0258fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332305Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#795376}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d2f4008a5291..1362c1eac458 2020-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b133b38a to 69b685d4 (479 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: Idceee762a6732486eddd89ca610b6573154a99bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340628Reviewed-by:
-
Tal Pressman authored
Bug: 1090251,1113134 Change-Id: I4d2efea46316d87332e700fe4dccd2aabfa87149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340569Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#795374}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9a4b91647e23..dbbc1ffe9924 2020-08-06 szuend@chromium.org [issues] Filter third-party issues in IssuesManager If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1080589 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I332680988172f715e16a51a0d3986dc68a3c1403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340349Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds implementations of the algorithms in [alg.partition] to //base/util/ranges. Bug: 1071094 Change-Id: I4288f35a2ab4e945a233cb282d63d051bfa7ee7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339517 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e8789a53f539..bedac4f06b5c 2020-08-06 syoussefi@chromium.org Move EXT_external_objects validation to validationESEXT.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I4f201f293ffb03dd027eda3e9738062c9977a763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340625Reviewed-by:
-
Alice Wang authored
This CL replaces the boolean flag IS_ACCOUNT_LIST_EXPANDED with enum state class to represent different states of the account picker bottom sheet. This refactoring will facilitate our future tasks of adding new screens like |sign-in in progress| to the bottom sheet. Bug: 1106442 Change-Id: I072693a393e14987c66888549956fdc49c386d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311577Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#795370}
-
Alexey Baskakov authored
This reverts commit d539d683. Reason for revert: Fails the bots https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/40249 Original change's description: > Allow termina to be installed via dlc > > Also refactor the current installer code out of CrostiniManager > > Bug: 953544 > Change-Id: Iad0850ffba616ac3f45adff63a5e21d57d3b5e7a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330111 > Commit-Queue: Fergus Dall <sidereal@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: David Munro <davidmunro@google.com> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795336} TBR=stevenjb@chromium.org,waffles@chromium.org,nverne@chromium.org,sidereal@google.com,kimjae@chromium.org,davidmunro@google.com,andrewlassalle@chromium.org Change-Id: Ia6eb9c6318ba41426eab212746af7e3344e67ad2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 953544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340926Reviewed-by:
-
Peng Huang authored
This change simplified the semaphore logic in VulkanSwapChain by reusing VkSemaphores. It also improved performance on Linux workstation slightly, but it could improve more if vkCreateSemaphore() is heavy for some other platforms. Bug: 1004772 Change-Id: Ifa5c5255627b4824b946f62d6edfa8d3f0c2ecb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331000 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#795368}
-
Alexey Baskakov authored
This reverts commit 6d67f881. Reason for revert: Fails https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel Original change's description: > Start setting StartVmRequest.vm > > This is currently ignored by concierge when starting termina, but > since termina can now be installed in multiple different locations we > need concierge to start taking the value that chrome sets. > > Bug: 953544 > Change-Id: I51b1ea50a5ae056d6af6baa0743a3cb0c8f8f5e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329126 > Commit-Queue: Fergus Dall <sidereal@google.com> > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Reviewed-by: David Munro <davidmunro@google.com> > Cr-Commit-Position: refs/heads/master@{#795346} TBR=nverne@chromium.org,sidereal@google.com,davidmunro@google.com Change-Id: I6635ec58a213c3f62a855a4487bc3cb96c9e4821 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 953544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340942Reviewed-by:
-
Alexey Baskakov authored
This reverts commit 1d21b497. Reason for revert: A culprit that fails virtual/text-antialias/mac-system-ui-weight.html on Mac https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/32138 Original change's description: > Roll src/third_party/harfbuzz-ng/src/ e3af529e5..cdb7d2b9b (284 commits) > > https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/e3af529e511c..cdb7d2b9bc0d > > $ git log e3af529e5..cdb7d2b9b --date=short --no-merges --format='%ad %ae %s' > 2020-08-02 ebrahim [docs] Update README.python.md with meson > 2020-08-02 ebrahim [docs] Adopt CONFIG.md with meson > 2020-08-02 ebrahim [docs] Remove packagers related part > 2020-08-02 ebrahim [ci] Disable Travis CI > 2020-08-02 ebrahim [meson] limit check-libstdc++ check to 0.55 > 2020-07-30 ebrahim [meson] Add darwin versions to library() > 2020-07-31 grieger [ENOMEM] check vector status in cmap subsetting. > 2020-07-31 grieger [ENOMEM] in GSUB ChainContext subsetting check maps for allocation errors. > 2020-07-31 grieger [ENOMEM] Check result of vector resize in CBDT subsetting. > 2020-07-31 ebrahim [ci] don't install rustc on linux-ci > 2020-07-31 ebrahim [cff] Check for scalars array resize result > 2020-07-30 grieger [ENOMEM] popragate packed/packed_map errors to the serializer. Will disable further modifications based on a bad state. > 2020-07-30 grieger [ENOMEM] unchecked resize in CFF2. > 2020-07-30 grieger [ENOMEM] Fix several instances of not checking resize in CFF. > 2020-07-30 grieger [ENOMEM] check for unset current in serializer->length(). > 2020-07-30 ebrahim Copy parts of README.md to README > 2020-07-30 ebrahim [meson] minor, use null_dep one more place > 2020-07-30 ebrahim Remove cmake build files > 2020-06-18 ebrahim Add comparison against ttf-parser > 2020-07-30 ebrahim [docs] Update TESTING.md with meson > 2020-07-29 grieger [ENOMEM] fix memory leak if allocation fails during pop_pack(). > 2020-07-29 grieger [ENOMEM] make serializer modification operations no-ops if it's in an error state. > 2020-07-30 ebrahim [icu] Remove support for versions older than 49 > 2020-07-30 ebrahim [icu] Remove useless HB_UNUSED tags > 2020-07-30 ebrahim [icu] Remove support of ICU versions before 42 > 2020-07-29 grieger [ENOMEM] Fix failure to check calloc return. Fixes https://oss-fuzz.com/testcase-detail/6246465148813312. > 2020-07-29 grieger [ENOMEM] check resize() return. Fixes https://oss-fuzz.com/testcase-detail/5641892164009984. > 2020-07-29 ebrahim [docs] Use untouched result of rsvg-convert for HarfBuzz.svg render > 2020-07-29 ebrahim [ci] Install meson's master > 2020-07-29 ebrahim minor spacing tweak > 2020-07-29 ebrahim minor spacing tweak > 2020-07-29 ebrahim minor spacing tweak > 2020-07-29 ebrahim [ENOMEM] Fix buffer's content check logic > 2020-07-14 ebrahim [fuzz] Implement failing allocator > 2020-07-29 ebrahim [glib] Default to glib's script type handling > 2020-07-28 grieger [subset] bail out of subsetting if plan allocation fails. > 2020-07-27 ebrahim [tests] minor > 2020-07-27 ebrahim [tests] Use TTFont of fonttools to avoid temp files > 2020-07-26 hamidrezabayat76 Use fonttools's python package instead of cli > 2020-07-25 ebrahim [ci] meson-gcc-mingw to crossbuild-win32 > 2020-07-25 ebrahim [releasing] unbreak the build > 2020-07-25 ebrahim [releasing] Use release buildtype > 2020-07-25 ebrahim 2.7.0 > 2020-07-23 razrfalcon Remove unused code from the Khmer shaper. > 2020-07-22 ebrahim [meson] Rename 'gtk_doc' option to 'docs' > 2020-07-22 ebrahim [ci] Don't run cov-analyze > 2020-07-22 ebrahim minor > 2020-07-22 ebrahim [fuzz] increase shape fuzzer timeout > 2020-07-20 boboniboni [tests] fix PGO build testing > 2020-07-20 ebrahim [ci] disable clang nightly installation > (...) > 2020-06-10 ebrahim [meson] Implement disabled state for cairo/freetype/icu > 2020-06-09 nirbheek meson: Export symbols for a DLL when not building statically > 2020-06-08 khaledhosny [coretext] Properly check for macOS 10.10 > 2020-06-06 ebrahim [meson] Remove with_libstdcxx build option > 2020-06-05 behdad s/blacklist/blocklist/g > 2020-06-05 ebrahim [meson] Add -Bsymbolic-functions > 2020-06-02 ebrahim [meson] Make gobject and introspection features automatic > 2020-06-05 ebrahim minor, improve the need for graphite comment > 2020-06-03 reiter.christoph [meson] Only pass required dependencies to everything > 2020-06-04 ebrahim [style] Hide behind HB_EXPERIMENTAL_API compile flag > 2020-04-21 ebrahim [style] Adopt with meson > 2020-02-08 ebrahim [style] give ptem value when asked for opsz > 2019-08-04 ebrahim [style] New experimental API, hb_style_get_value > 2020-06-04 ebrahim [meson] fix with_libstdcxx effect > 2020-06-04 ebrahim [meson] Update subset tests list from autotools > 2020-06-04 ebrahim [ci] fix meson-gcc-mingw bot > 2020-06-04 ebrahim [ci] check workability of meson based dist > 2020-06-04 ebrahim [ci] Deploy only when there is something to push > 2020-06-04 ebrahim [meson] Fix gen-hb-version.py run > 2020-06-04 ebrahim [meson] Remove amalgam build option > 2020-06-04 ebrahim [ci] Move docs deployment from autotools to meson > 2020-06-03 ebrahim [meson] fix gen script input > 2020-06-03 ebrahim Use output names in update-unicode-tables.make > 2020-06-03 ebrahim 2.6.7 > 2020-06-02 ebrahim Move unicode tables update script to its own make file > 2020-06-02 ebrahim minor, fix hb-version.h generation for out-of-tree builds > 2020-06-02 ebrahim minor fixes on src gen scripts > 2020-06-01 ebrahim Build win32 artifacts using meson > 2020-05-31 ebrahim [tests/aots] move the update script to update.py > 2020-05-31 ebrahim [tests/test-rendering-tests] run git pull on correct dir > 2020-05-31 ebrahim minor, fix extra dist list > 2020-05-31 ebrahim [test/text-rendering-tests] Adopt the update script with meson > 2020-05-31 ebrahim [test/text-rendering-tests] Update from upstream > 2020-05-31 ebrahim [tests] Port text-rendering-tests update script to python > 2020-05-30 ebrahim [meson] Categorize tests using `suite: [...]` > 2020-05-30 ebrahim [ci] fix alpine build issue > 2020-05-29 ebrahim [tests] Port check scripts to python > 2020-05-29 ebrahim [meson] reflect chosen linker update > 2020-05-29 ebrahim [meson] minor, find run-tests.py only once > 2020-02-18 qxliu [subset] GDEF AttachList subsetting support > 2020-05-29 ebrahim minor on python scripts > 2020-05-29 ebrahim minor, use py3's open(encoding=) > 2020-05-28 ebrahim minor, enable printing to stderr in run-tests.py > 2020-05-28 ebrahim minor, use sys.exit print shorthand > 2020-05-28 ebrahim minor, move scripts manuals to __doc__ > 2020-05-20 qxliu [subset] ChainContext subsetting fix: add lookup index remapping > 2020-03-30 simon More strictly follow noun/verb/identifier format for GPOS/GSUB lookups > 2020-03-30 simon Reformat kerx/morx instrumentation to 'verb noun identifier' > 2020-03-30 simon Add table index to lookup messages > 2020-03-30 simon Instrument entering GSUB/GPOS tables > > Created with: > roll-dep src/third_party/harfbuzz-ng/src > R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org > > Change-Id: I397e890f896e74221788acf630172fb18cdbe5f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336089 > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Auto-Submit: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795347} TBR=bashi@chromium.org,bungeman@chromium.org,eae@chromium.org,kojii@chromium.org,drott@chromium.org,jshin@chromium.org,behdad@chromium.org Change-Id: I0bf6d810a021e3827a6106c6a7edaa566f318d2b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340862Reviewed-by:
-
Rakina Zata Amni authored
With crrev.com/c/2121522, some main-frame same-site navigations will result in a new BrowsingInstance, SiteInstance, RenderFrameHost, RenderView, etc. This CL updates expectations of tests under contents/ that didn't expect a change of RenderFrameHosts etc. on same-site main frame navigations. This CL does not include: - Updates for navigation-related content_browsertests and content_unittests, which are handled in crrev.com/c/2195872 and crrev.com/c/22100358. - Updates for tests under chrome/, components/ and layout tests (fixed in other CLs) - Fix to ensure order of unload handlers on same-site cross-RFH navigations (will be fixed on a future CL) - Fix to ensure WebPreferences are carried over for cross-RFH same-site navigations (will be fixed on a future CL) For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing Bug: 977562 Change-Id: I1fc507538b48d7566be28a4bd2ef83ff3cacd843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210174Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#795365}
-
Sven Zheng authored
The filter list is based on the latest fyi bot runs: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-fyi-rel/209? Only filter out the failing tests. Flaky tests will be run. Bug: 1111979 Change-Id: Ieb722c2ad4b2a648c5eac9408427eaf03ad3d244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340264 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795364}
-
Alice Wang authored
This CL adds an empty method onDismiss to AccountPickerDelegate so we can release resources in this method later when working with WebSigninBridge. Bug: 1093741 Change-Id: Ibcea89c360431e102115faa3e7b34eb435253252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339514Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL doesn't change the behavior. Bug: 1111134 Change-Id: I297685e02f1cb1a2184fef9248f0a34081aa0a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331177Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iaeb43375a78b212f92f4c296e1a7a70846fec86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339053Reviewed-by:
-
Fred Mello authored
https://docs.google.com/document/d/1VGgqZjX4RCA7c5iKMeexJ-VU8PQ_vpbGM4mvT2mXKDY Bug: 1112872 Change-Id: I8c8d0d57b60d39a24f34c31ebc03517ad60f4087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337262 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#795360}
-
Hiroshige Hayashizaki authored
This CL doesn't change the behavior. Bug: 1111134 Change-Id: I571b274c736224d5dbef9e9ac4ae4fb847733ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330878 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b932a7fed903..8351dc1fb7c4 2020-08-06 bpastene@chromium.org Revert "[Fixed from older branch] Timing/RDB for lower-level checks" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106943,chromium:1113506 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I3e2a2fb65e87dc2615d67bdb61158183d592b86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340762Reviewed-by:
-
Kenichi Ishibashi authored
AllowJavascript() seems to depend on CookieStoreManager, and CookieStoreManager uses service workers. TSAN detected a data race in SiteSettingsHandlerTests when service worker code base is changed to replace a direct C++ method call with a mojo method call (see the linked bug for details). This CL adds a run loop in SetUp() to avoid the data race. Before this CL, the data race could happen because: * service worker tries to create leveldb_env::ChromiumEnv on a non-main thread. * ChromiumEnv reads FeatureList. * SiteSettingsHandlerTests use ScopedFeatureList and destruct it without waiting for ChromiumEnv creation on the main thread. Bug: 1112825 Change-Id: I74793045aa865410c032e651ee407c417424ba68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340297 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#795357}
-
Evan Stade authored
Bug: 1106641 Change-Id: I87570647e8b163f991c963eaa732a90b47c00bd4 Fixed: 1108038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336017Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Koji Ishii authored
This reverts commit fd0f9b34. This patch restarts collecting following histograms again, as we try to enable them on Win/Linux/ChromeOS, and the discussion restarted. > Stop collecting hyphenation histograms > > This patch removes following histograms: > Hyphenation.Open > Hyphenation.Open.File > > These are added to learn how long it will take to open > hyphenation dictionary. A concern was raised when I > implemented hyphenation on Android as the open operation is > synchronous. > > We do not see the data indicating needs to invest in > asynchronous hyphenation at this moment, and the data is > steady that further recording does not seem to be necessary. > > Bug: 975142 > Change-Id: I1d98eedf47a1afa5940f6e01b3c6fadcca4cbcdf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664092 > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670299} Bug: 975142 Change-Id: I72ed8a0a085b873abcab1db86c28a0ef0aa81a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340065 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
