GitLab

Bug: 1027373
Change-Id: I68f544db08731ec3c02213258dc0709589c27292
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095559Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748546}

This reverts commit b5046a36.

Reason for revert: system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/browse:tech:discourse_infinite_scroll:2018
is failing.

Original change's description:
> Changed infinite iterations's representation from -1 to infinity().
> 
> In blink we use -1 to represent infinite iterations for historical
> reasons. Rather, we should use std::numeric_limits<double>::infinity()
> to be more specification-complaint.
> 
> CL based on crrev.com/c/1373409.
> 
> Bug: 913662
> Change-Id: I3b2ff0c44d36c03654d77784c3867555603b0576
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071100
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Reviewed-by: Yi Gu <yigu@chromium.org>
> Reviewed-by: Daniel Libby <dlibby@microsoft.com>
> Commit-Queue: Annie Liu <t-hunliu@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#748383}

TBR=vollick@chromium.org,majidvp@chromium.org,yigu@chromium.org,dlibby@microsoft.com,t-hunliu@microsoft.com

Change-Id: Ic85093b6bb9f0d15a45cf65dbefa410e66b43346
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 913662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094489Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org>
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748545}

The IsUserVerifyingPlatformAuthenticator() WebAuthn API call needlessly
required the content embedder to provide their own implementation in an
AuthenticatorRequestClientDelegate specialization. This change moves the
ChromeAuthenticatorRequestDelegate implementation into the content layer
(AuthenticatorCommon). The implementation is general enough to be useful
for other embedders and it doesn't depend on any state internal to the
delegate.

Concretly, IsUVPAA()
- on Windows returns the corresponding value from the native WebAuthn
API;
- on macOS reflects TouchIdAuthenticator availability as long as the
embedder provides an implementation of GetTouchIdAuthenticatorConfig.

Also collapse methods in AuthenticatorCommon that determine which
transports to instantiate discoveries for, and also add a safeguard
against instantiating platform discoveries in contexts where IsUVPAA()
returns false.

Change-Id: I8eb68ca6f8cd17fae61d9d0294b872ef0cfb3465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083936
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748544}

Test: None
Bug: None
Change-Id: Ia7cd6efe90968e06c0a4a96f7e2104e05ee9e961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091091
Auto-Submit: David Munro <davidmunro@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#748543}

Replacing includes with forward declarations helps reduce compilation
time.

To be clear, I doubt that the CQ time burnt by this CL will ever be
recovered by the tiny savings in compilation time over all future
Chromium builds. However, I point folks building new APIs to the Cookie
Store API as an example of reasonably modern code, so I think there's
value in getting the details right.

Change-Id: I00ff2885b331bdd23fac392372e127c2e3817896
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093398
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748542}

Bug: 1054552
Change-Id: I7fc3d29498aec9a429e792145f865f0e6898d542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090606
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748541}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cdb673f91738..3e017d50fe09


Created with:
  gclient setdep -r src-internal@3e017d50fe09

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1024588,chromium:1052460,chromium:1054944
Tbr: jbudorick@google.com
Change-Id: I4adc846c99b94e127e2ee6ab66970463796d7e8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095166Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748540}

- For some of the flags, I've extended HelpAppUIDelegate to contain
logic that depends on code in "chrome/".
- Moved existing code to obtain board name, customization id and
version to HelpAppUIDelegate.


Bug: b/140150028
Change-Id: Ie2cbbdacf84692724a69c2b106f703ceadeb7a74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073438
Commit-Queue: Callistus Tan <callistus@google.com>
Auto-Submit: Callistus Tan <callistus@google.com>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748539}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/34d7ff92..a0a3e1a7

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I5becd8addba186eac8f4631faf1ca7a5f01d523c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095901Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748538}

Flaky on Mac 10.11, 10.12, 10.14

TBR=ellyjones@chromium.org

Bug: 1060063
Change-Id: I79f7ef374d582b8c585a663ed71cc99a1530db9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094487Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org>
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748537}

1. Move html out of string resources
2. polymer binding for UI properties most elements.
3. polymer binding for learn more callbacks
4. Move onNext/overlays to arc_terms_of_service for future
   reuse for in session opt-in extension.
5. Use multiple popup overlays with multiple <p> to support
   overlay text with multiple paragragh.
6. Remove skip button as it's no more supported for user.
   Add TODO for clean up.

Not all work is done with this cl. Things need follow up
1. Handle string loading before login.
2. Better handling webview.
3. Terms of service webview loading uses adding class to set
   display: none.
4. Large group of text are still not broken into blocks. 

Bug: 1047807
Test: Update browser tests
Test: Manual
Change-Id: If627f6680d416a134aa429359fb7352fe0cc5de3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081252Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#748536}

This patch does the following:
1) Converts RectHighlightPathGenerator to use RoundRect struct, which will
mean clipping on the ink drop layer will be done instead of masking.
2) Introduces EmptyHighlightPathGenerator which is equivalent to
overriding CreateInkDropMask to explicitly return nullptr.

Test: manual
Bug: 1056490
Change-Id: I4d17f148c719fce8dd6ded58e388369f2fe9aa19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079433Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748535}

This reduces the repainting during hotseat animation.

Bug: 1049355

Change-Id: I36cbdb73f7417494b224c0d71f2efb1a6929c5b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088972Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748534}

This commit enables resize for the virtual keyboard by default.

BUG=1019990

Change-Id: I4d4e24560a8cb6bc9adc157381ed598607fd01b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094379Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748533}

https://skia.googlesource.com/skia.git/+log/ea3ddc9aefde..8a44af5cbad5

git log ea3ddc9aefde..8a44af5cbad5 --date=short --first-parent --format='%ad %ae %s'
2020-03-09 reed@google.com remove unused isAPicture from shaderbase
2020-03-09 fmalita@chromium.org SkShaders::Blend/GPU: treat null inputs as input color
2020-03-09 mtklein@google.com add missing license line to SkVM_opts.h
2020-03-09 fmalita@chromium.org Remove SkMaskFilter::makeWithMatrix()
2020-03-09 nifong@google.com Add a canvas test to make and draw SkVertices
2020-03-09 scroggo@google.com Reland "Split building encoding from decoding"
2020-03-09 egdaniel@google.com Add d3d support for creating command lists.
2020-03-09 fmalita@chromium.org [skottie] Defibrillate wipe effects

Created with:
  gclient setdep -r src/third_party/skia@8a44af5cbad5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: brianosman@google.com
Change-Id: Ida1c5b5c95dfa74ce1c8b46f00f44eea5558e61f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095163Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748532}

When files in a folder are majority images, Grid View was hiding the
file name. This feature shouldn't be enabled in the new design, this CL
fixes this.

Bug: 1059664
Change-Id: I85c5ec0b29358bf141ccb831dd2071a37b991178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094380
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748531}

This is a reland of e19d9ff7

Original change's description:
> bluetooth: Implement FakeBluetoothDelegate
> 
> This change implements FakeBluetoothDelegate which fakes the behavior of
> the new Web Bluetooth permissions implemented behied the
> WebBluetoothNewPermissionsBackend flag. Therefore, the
> web-bluetooth-new-permissions-backend virtual test suite runs the Web
> Bluetooth tests with this flag enabled.
> 
> Design doc:
> https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/
> 
> Bug: 577953
> Change-Id: I5f81b92433009fc34a6a5e5495fdba72500db41e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080813
> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Vincent Scheib <scheib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#746429}

Bug: 577953
Change-Id: I7442aca2e2bb816a93873d0bb76c3ec7e153b6a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087904Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748530}

Extends HaTS flags for two more milestones to allow more testing.

Change-Id: I484e5f7d228fd1e07386aed41643c62c0d039aa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095334Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748529}

Added a check for the survey's status. When the survey is not
reachable or over its capacity, we won't show the HaTS bubble any more.
Also, we will record the over capacity information so we won't need to
check it again.

BUG=1048385

Change-Id: If547eefcb0992ba43d78ee07c46fb718fa309a96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034055
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748528}

symbol_level=1 on Windows was changed to include filename and line
number information which gives us better call stacks. However on Windows
7 the symbol lookup became much slower, leading to timeouts. This change
modifies symbol_level=0 so that it includes function names (but no
filenames or line numbers) so that it is what symbol_level=1 used to be.
The build machines can then selectively be changed to symbol_level=0 to
avoid the timeouts, while still giving higher quality call stacks when
symbol_level=1 is selected.

When auditing the .gn files to validate this files it is important to
search both for symbol_level == 0 and symbol_level != 0. This may still
miss some cases but I think the changes are correct.

The total elapsed time sum for linking all 330 PEFile targets in a debug
component build of the 'chrome' target at symbol_level=0, as reported by
post_build_ninja_summary.py, goes from 250 s to 325 s with this change.
The weighted time (an estimate of the impact on build time) goes from
~25 s to ~39 s with this change, so a 14 s increase in build time.
The total size of the PDBs generated in this scenario is about 2.1 GB.

Bug: 985255
Change-Id: I1ea25433a1cf22f906c493ee0df1e41c98ed923d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986973Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748527}

V4L2VEA doesn't allow change coded_size of VideoFrame during
encoding. If the size varies, it invokes NotifyError() with
kInvalidArgumentError. However, RtcVideoEncoder does not regard
the error as so critical that software encoder fallback should be
triggered. As a result, any frame will no longer be encoded if it
happens, which is viewed like encoding hangs.

This CL lets V4L2VEA invoke NotifyError() with KPlatformFailure
in the case so that software encoder fallback happens.

Bug: 1057528
Test: SW encoder fallback happens upon rotation on scarlet
Change-Id: I8300e42d3a913548736e9d17bba6d394f12345cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087329
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748526}

Implemented a functoin |clear|, which removes all elements in a linked list.

Change-Id: I94fc761eb7f779a532ccd7846254aff4f703c909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094897
Commit-Queue: Kei Nakashima <keinakashima@google.com>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748525}

This CL removes expected files for deleted autofocus tests in crrev.com/c/2094058.

Bug: 1059322
Change-Id: Ib68175b2a67ee2e5a258f9fd6fefc7bd10fb08c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094847
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748524}

The original V4L2VideoEncodeAccelerator execute IOCTLs to configure
framerate and bitrate every RequestEncodingParametersChange() even
though they are the same as the last configured values.

This CL have V4L2VEA reconfigure the framerate and bitrate only
if they vary. This also fixes the flood of the parameter change
logging in chrome log.

Bug: None
Test: run VEA test on scarlet
Test: appr.tc/?vsc=h264&debug=loopback
Change-Id: Ibe830797436a05d31f516af0845211f5da707fc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082739
Auto-Submit: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748523}

This enables LibyuvImageProcessor to crop (on scaling).

Bug: 1033799
Test: ip test
Change-Id: I5849a2c382e6828588a90f3b5272b24e7e11ae3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079779
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748522}

This reverts commit 6e6b8903.

Reason for revert: Suspected as causing a ProxyCommit regression.

Original change's description:
> Skip commits for threaded scrolls (reland)
> 
> Threaded scrolls unnecessarily cause commits on every change. This
> patch implements an optimization from pre-BlinkGenPropertyTrees in
> layer list mode to avoid these commits.
> 
> When an impl-side scroll occurs, cc can immediately apply the scroll
> before notifying blink so that the blink update only causes a commit if
> needed (e.g., interest rect changed). This has been implemented in
> LayerTreeHost::UpdateScrollOffsetFromImpl. A second change was needed in
> PropertyTreeManager::DirectlyUpdateScrollOffsetTransform to avoid
> commits if cc already matches blink.
> 
> The first version of this patch (https://crrev.com/743622) was reverted
> (https://crrev.com/743844) due to breaking scroll animation
> interruptions. This patch adds the missing call to
> Layer::SetNeedsPushProperties to ensure scroll animations are clobbered.
> 
> Bug: 1048384f
> Change-Id: Iadf7b5fb0471f74b46ed6d7ecf9edade51484646
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076419
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745110}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1048384f, 1059436
Change-Id: Ib71301c3c3bc234c3dbf837c47e3805b5cbfc8f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092418Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748521}

V4L2 encoder driver may need to adjust visible rectangle because of
their restrictions of hardware and firmware. If the adjusted visible
rectangle is different from the requested one, we should invoke the
error rather than processing the encoding.

Bug: 1033799
Test: video.EncodeAccel.* on scarlet
Change-Id: I686f3dc30ee325bb6020ffc87534971291602020
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078522Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748520}

This reverts commit 95a35640.

Reason for revert: crbug.com/1057025

After revert, I'm planning to reland this patch after M82 branch and
work on fix to crbug.com/1057025

Original change's description:
> Fixes Select elements drop-down doesn't follow update of the element position/size
>
> Prior to this fix, when a select element's popup is open, a script
> in the background can modify the page's DOM that changes the position
> of select element on the screen. However, select popup remains
> stationary thus appearing disconnect from the select element. The select
> popup also doesn't update to the correct size if the script adds
> an new option with a long text.
>
> The reason is that select element doesn't check to see if the position
> or size of the select element popup relative to the document changed.
> For example, after the popup is displayed, a script could modify the
> document that changes the position of the select element. It doesn't
> notify its popup, thus makes them appear as disconnected.
>
> The fix is to update the select popup, its position and size, at the
> end of frame's life-cycle phase. This will guarantee that all elements
> in the frame have been styled and layout correctly. At this point,
> we can update the popup if its owner's position and size has been
> changed. The fix also removes the PostTask as a performance and
> simplicity optimization.
>
> An alternative proposal, use intersection observer on the owner element,
> was discussed. However, it still has the draw backs of post task. Plus,
> it may not capture all cases.
>
> In addition, I also considered and tried using PostTask within the
> UpdateLifecycle method. However, that's not optimal since within the
> popup's update method, it requires another call to UpdateStyleAndLayout
> because the layout could have been dirtied since the time PostTask was
> added into the queue. InternalPopupMenu::Update() also updates the
> select element's internal state, options. I saw some intermittent
> failures in couple of tests that validate options index. These tests
> use SetTimeout(), which may partly be aggravate by PostTask. I didn't
> investigate further as this is not the approach to take.
>
> This fix works for both Linux and Windows. I updated test
> popup-menu-resize-after-open to reflect that. In addition, I removed
> the (TODO) in listPicker.js. This fixes select popup when placed inside
> an iframe.
> For platforms that use external_popup_menu, mac and android, will be
> migrated to use internal_popup_menu when forms-refresh is rolled out to
> those platforms in M83.
>
> One of the biggest problem I encountered when doing this fix is that popup
> content doesn't updated when the popup is moved only. This is the same
> issue as crbug.com/633140. This review,
> https://codereview.chromium.org/2228093003, goes into more details on
> popup bounds synchronization between browser and renderer. Regardless,
> I had to make a similar fix in  web_page_popup_impl.cc,
>  calling SetWindowRect() when force_update is true.
>
>
> Bug: 137495
> Change-Id: I7ef4c09a6d3d7bee3ef8988c815e07efa72d4a79
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013470
> Commit-Queue: Yu Han <yuzhehan@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740964}

TBR=chrishtr@chromium.org,yuzhehan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 137495
Change-Id: I403683f2b9bd05784cd6a5384a92c14ac8869ccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095839Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748519}

Before this CL, RequestHideIme() was called by Android side just after
the call of OnTextInputTypeChanged().
However, the interval between the call of OnTextInputTypeChanged() and
the call of RequestHideIme() can be larger than the length of the
animation of showing the virtual keyboard.
When it happens, the bounds of the shown virtual keyboard is notified to
Android side by OnKeyboardAppearanceChanged() and it causes confusion.
This CL fixes it by calling HideKeyboardImplicitlyBySystem() in
OnTextInputTypeChanged() and marks RequestHideIme() mojo call as
deprecated because it's not needed anymore.

Bug: b/148483295
Bug: 1023656
Change-Id: I32c46c18949323c0a33a26dd10a18e2e38cc277a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089434Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748518}

This is mechanical change for the component updater, because the
component updater gets state change notifications using the observer
interface of update client.

//chrome/updater code is not changed in the CL but the in the future,
a valid CrxStateChangeCallback is going to be provided when invoking
UpdateClient::{Install,Update}.


Bug: 1058858
Change-Id: Iba086a5b7a6e955125de4b5b114d6010c8526c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092422
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748517}

Change-Id: Icaba7ae63e2e26bcd85ae65eab9282dd269408fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090016
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748516}

Bug: 1058531
Change-Id: I3051b4b02ee568d5e24b7f390b5fbfe9b83510f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094072Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748515}

Thanks to the new set_permission method on test_runner, this CL
makes sure the nfc WPT tests with first granted permission and
adds tests for nfc permission status.

Bug: 520391
Change-Id: I50d114c1ac70d97a51fa0ce770c82f012d64f4e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094735
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#748514}

This method is useful for querying when the next "interval point"
(start or end) is from a given starting point. Which is quite handy
if you're using this class to represent some sort of timeline...

Speaking of which, this change was done to support
https://chromium-review.googlesource.com/c/chromium/src/+/2008079

It also cleans up the code a fair amount as well.

Change-Id: I2f9fc6fdce9ae8cb05264f73f4d392e79cc8e7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073058Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#748513}

Pointer lock and unlock requests were still using the old IPC workflow.
This updates the call to use Mojo.

This CL is a copy of a merged and reverted CL. For reference to the
discussions here is the original: https://crrev.com/c/2028453

Bug: 1042293
Change-Id: I26c3c3cabce06437698f8b9ebed01d8476bb5eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095402Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748512}

When handling a response on GetAssertionRequestHandler, it's possible
the device may be able to use PIN for fallback and not wait for a second
touch if it supports internal UV but not UV token. Fix a DCHECK to avoid
crashing in that case.

This patch also improves the internal user verification tests to verify
behaviour when PIN is supported.

Bug: 1059914
Change-Id: I5be2e4c85ee97f6298bc5f34ec111a757a027cc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095151
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#748511}

This CL supports VDA deferred initialization in TestVDAVideoDecoder.
The feature is used at the following CL:1928519.

Bug: b:136716838
Test: video_decode_accelerator_tests on Kevin and Octopus
Test: video_decode_accelerator_tests --use_vd on Kevin and Octopus

Change-Id: I2819d482d2050faf8bbc96832edd28e68d69c384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094431Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748510}

This is done to make clear what is the purpose of the navigation
controller.

Bug: None
Change-Id: I8207f16e4b8551b7d568bf017880bb9814c70bbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091529
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748509}

initial script evaluation.

This patch makes service worker check for fetch handle existence at the
end of initial script evaluation, which is more consistent with spec
(https://w3c.github.io/ServiceWorker/#should-skip-event).

Bug: 1005060
Change-Id: I3e389e5a641971398857fc40e6e5fcc79e074cb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995062Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Wei4 Wang <wei4.wang@intel.com>
Cr-Commit-Position: refs/heads/master@{#748508}

Fix Typo in "importance"

Test: None (build passes)
Bug: None (fix typo)
Change-Id: I47997140d94d50c633a02b22f6d7c96741a5e0fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093973Reviewed-by: Sara Kato <sarakato@chromium.org>
Reviewed-by: Hiroki Sato <hirokisato@chromium.org>
Commit-Queue: Sara Kato <sarakato@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748507}