- 16 May, 2018 40 commits
-
-
Fady Samuel authored
Bug: none Change-Id: I5dc0b8be17f8d88fb4650c1c564d7f295dc5c1fe Reviewed-on: https://chromium-review.googlesource.com/1061575Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559079}
-
Fady Samuel authored
We need to always update DelegatedFrameHost and call RenderWidgetHostImpl::SynchronizeVisualProperties when we receive a viz::LocalSurfaceId from the child renderer as auto-resize is no longer the only case for child allocated LocalSurfaceIds. Change-Id: I9fcd6b9b6fe2efcaf8bfb2c9eda988fb9f8cc67c Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/1058445Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559078}
-
Max Morin authored
Bug: 843103 Change-Id: I1040b014620079865b1141c52ac8ec90fec26ab7 Reviewed-on: https://chromium-review.googlesource.com/1061293Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559077}
-
Emily Hanley authored
Bug: 840427 Change-Id: I44364a9c3954b14118c77c51cfd454be3919c1f2 Reviewed-on: https://chromium-review.googlesource.com/1055776Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#559076}
-
danakj authored
This makes every method in WebLayer match the method name in cc::Layer, with exception of the constructor and the CcLayer() unwrapping methods. It also includes web_layer.h instead of forward delcaring it everywhere so when we change it to an alias, these files will know that, instead of having to change them all to also alias. We'll later change them back to cc::Layer forward declarations. R=pdr@chromium.org TBR=piman, dalecurtis Bug: 838693 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0b353da350326d57aeac03191dc88a775442d47f Reviewed-on: https://chromium-review.googlesource.com/1056067 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559075}
-
Justin Cohen authored
This reverts commit 8326d5f3. Reason for revert: Tests are still failing after this rolled in. Original change's description: > [ios] Revert smarter CellWithMatcher change for pre-Refresh > > Speculative fix for pre-Refresh content test failures. > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I743bb7e99a702ea300f0505d6d64a87b906db383 > Reviewed-on: https://chromium-review.googlesource.com/1057460 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558308} TBR=justincohen@chromium.org,gambard@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Idbbbb285dd8e53e3984b2314cb03775b872c25b6 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1060173Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559074}
-
Christian Dullweber authored
All cookie and localstorage tests for BrowsingDataRemover have been moved to StoragePartitionTest in 2013 (https://crrev.com/37843003) and replaced with testing a StoragePartitionMock. This code isn't needed anymore. Change-Id: I7b4278b8a926a2930a69430288c7ab560d162f46 Reviewed-on: https://chromium-review.googlesource.com/1061500Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#559073}
-
W. James MacLean authored
A test that should detect if invoking a tooltip on Android crashes the browser. This test requires that https://chromium-review.googlesource.com/c/chromium/src/+/1057993 is submitted first. Bug: 842410 Change-Id: Ib80b6f76355423b843fbcfa8a51440197b3bc78d Reviewed-on: https://chromium-review.googlesource.com/1059703 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559072}
-
Andrew Grieve authored
Change-Id: Ibf12b63c3651a41e45e80db477bee362b18eb081 Reviewed-on: https://chromium-review.googlesource.com/1060620Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#559071}
-
Chris Nardi authored
The upstream version of this test is already imported into Chromium at external/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects.html. Our copy doesn't appear to have diverged from upstream, so remove the outdated duplicate copy of this test. Bug: 723826 Change-Id: I580dbbaa8e88a90b96c5a34eccffa95b62596b21 Reviewed-on: https://chromium-review.googlesource.com/1060283Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559070}
-
Fredrik Söderquist authored
Sink the update of intrinsic_size_ out of the if-else in ComputeIntrinsicSizingInfoForReplacedContent, and then push GetNestedIntrinsicSizingInfo down into subclasses, folding it away to use the "local" constructs of the relevant subclasses. This leaves subclasses to deal with issues such as if whether to apply zoom or not et.c, and will with some additional tweaks allow for more succinct interfaces in the "nested" cases. It also makes LayoutReplaced much simpler. Bug: 722055 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie8493ffa89ffb34d2591d6a7ecdc8ebc20c6264f Reviewed-on: https://chromium-review.googlesource.com/1059776Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#559069}
-
Peter E Conn authored
Bug: 843092 Change-Id: I6e077e6a9db1cc6b36427fdd1238e141c158caeb Reviewed-on: https://chromium-review.googlesource.com/1061314 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559068}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d8600ccc2dde..9795ca36af56 $ git log d8600ccc2..9795ca36a --date=short --no-merges --format='%ad %ae %s' 2018-05-16 simonhatch Dashboard - Move logging statement up a bit. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Iee1e309d58f9bc821a9f7a7c3f593e10b8a177ea Reviewed-on: https://chromium-review.googlesource.com/1061573Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559067}
-
Chris Harrelson authored
Bug:795549 Change-Id: If7c933158b924800515cd09837ed16537adc8b45 Reviewed-on: https://chromium-review.googlesource.com/1060607 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#559066}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Change-Id: I676ea2ab347f2ff837d5b416ffc2df3a7bff13d4 Reviewed-on: https://chromium-review.googlesource.com/1061237 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559065}
-
David Roger authored
This constant was defined twice: in Profile and in AccountTrackerService. This CL removes the one in Profile and uses the AccountTrackerService one everywhere. TBR=imcheng Change-Id: I094f5e4fb66fb75d7420b664dd13a1d8b98ac0c1 Reviewed-on: https://chromium-review.googlesource.com/1061076 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#559064}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4dc1da47ad18..5f638a1091fb $ git log 4dc1da47a..5f638a109 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 achuith cros_build_lib: Support for stream_log. Created with: roll-dep src/third_party/chromite BUG=chromium:829481 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8fe6389f7a40c78f33c032f752f75b819892d83e Reviewed-on: https://chromium-review.googlesource.com/1061574 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559063}
-
Juan Antonio Navarro Perez authored
Disabling on Android_Go in system_health.memory_mobile. NOTRY=true TBR=nednguyen@google.com Bug: 843547 Change-Id: I5329ffb0dd5605e7c716b8bac290e336b4c6b8a7 Reviewed-on: https://chromium-review.googlesource.com/1061754Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#559062}
-
Jonathan Backer authored
Bug: 829469 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idc108797849100053d534c014538b602345f26df Reviewed-on: https://chromium-review.googlesource.com/1060028Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#559061}
-
Aldo Culquicondor authored
This UI element is used to build the scrollable overflow menu. Bug: 839488 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I930b2b13f61e1533d74df6c5a4aab60089987450 Reviewed-on: https://chromium-review.googlesource.com/1055987Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#559060}
-
Simon authored
Landing this for eakuefner@ since he's OOO this week. This CL switches various small (mostly V8 "press") benchmarks to the histogram pipeline. Bug: 744736 Change-Id: I2391ed93f53bd5471498513c9dc6effa8c25dfba Reviewed-on: https://chromium-review.googlesource.com/1059586 Commit-Queue: Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#559059}
-
Lucas Furukawa Gadani authored
This CL removes the typemaps for CacheStorage and converts the browser usage of CacheStorage types to mojo types. Bug: 612287 Change-Id: Ied68ed00f2cc7af71cc33660544be9894cbb2eb1 Reviewed-on: https://chromium-review.googlesource.com/1058334Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#559058}
-
Marina Ciocea authored
Reset ref factory in destructor to call ref factory's quit closure before other members get destroyed. Change-Id: Idbb7e22c60c309a2d72aa69af098a33f4b966fe2 Reviewed-on: https://chromium-review.googlesource.com/1060059 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559057}
-
Colin Blundell authored
Sylvain is ramping up to full co-ownership of the Identity Service. Add him as an OWNER now to allow him to make straightforward changes when the two existing OWNERS are both OOO. He will of course defer to the existing OWNERS for complex changes (either making or reviewing) while ramping up. Change-Id: I287b712c402c04dcbf384e3d78b6842f90b3fafc Reviewed-on: https://chromium-review.googlesource.com/1061459Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#559056}
-
Peter E Conn authored
My last attempt at solving this [1] didn't work. I suspect it may be to do with rounding errors, but have no data to back this up. Since the bug is a release block stable, I'll catch the error so we stop crashing. After merging this to branch, I'll commit another change to trunk causing this to throw, but with extra diagnosis information. [1] https://chromium-review.googlesource.com/c/chromium/src/+/908557 Bug: 842897 Change-Id: Iacbb4011cdb0acd92f6c2e0cca3ff5fe8ccc19d1 Reviewed-on: https://chromium-review.googlesource.com/1061313Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#559055}
-
W. James MacLean authored
Tooltips aren't used on Android, and neither are CursorManagers. This CL removes a CursorManager null-dereference in RenderWidgetHostViewChildFrame that occurs on Android. Bug: 842410 Change-Id: I737d7c4ab6a5befda660a9df5598469ac2802fe6 Reviewed-on: https://chromium-review.googlesource.com/1057993Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#559054}
-
Bruno Kim Medeiros Cesar authored
The "usm" service flag is not sent in IdToken. After USM support is launched, we'll want to delete this setting entirely. Bug: 836246 Change-Id: I4981132619ff1bd580bd10a6a47d7aa088394825 Reviewed-on: https://chromium-review.googlesource.com/1059457Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org> Cr-Commit-Position: refs/heads/master@{#559053}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Change-Id: Iee4f0a51ee32cc66d4a56620d181d2f090486041 Reviewed-on: https://chromium-review.googlesource.com/1061235Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#559052}
-
Noel Gordon authored
Mash does not support the BasicDrive tests causing flakes on the CQ in mash_browser_tests (with patch). Exclude them in Mash. MultiProfileFileManagerBrowserTest.BasicDrive MultiProfileFileManagerBrowserTest.PRE_BasicDrive Tbr: fukino No-Presubmit: true Bug: 836254, 842442 Change-Id: Ie03fce011bcdb6ba1b20bf2d832aedee0e792feb Reviewed-on: https://chromium-review.googlesource.com/1061433 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#559051}
-
Boris Sazonov authored
This CL implements a flow to add an account in SigninFragmentBase. It uses a different approach from the one of AccountSigninView, as it overrides onActivityResult to get the result of the activity that actually adds accounts. Intent used by AccountAdder doesn't return any results to onActivityResult, so this CL also adds AccountManagerFacade.createAddAccountIntent to get a proper intent from Android AccountManager. See https://crbug.com/814728#c50 for more details. Bug: 814728 Change-Id: I4d77f8685fff496a01d9e48c91659dc7355bf505 Reviewed-on: https://chromium-review.googlesource.com/1059518Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#559050}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Change-Id: I3d407c60b853ce62c37d00d97673d18e9b288b24 Reviewed-on: https://chromium-review.googlesource.com/1061236Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559049}
-
https://chromium.googlesource.com/angle/angle.git/+log/10e7e5013c41..80c32ccbbcc6 $ git log 10e7e5013..80c32ccbb --date=short --no-merges --format='%ad %ae %s' 2018-04-25 jiawei.shao ES31: Add extra transform feedback rules in EXT_geometry_shader Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I12dc3a21299ac557944e3330d23d63d12b5d066b Reviewed-on: https://chromium-review.googlesource.com/1061333 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559048}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Change-Id: I6e6e5acba61aa3f48bdf4770d6deab998f4723f3 Reviewed-on: https://chromium-review.googlesource.com/1061233Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559047}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/982a3ae5..41835253 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5c98f922655cb298ef472dcdb36aecd92ea004dd Reviewed-on: https://chromium-review.googlesource.com/1061095Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#559046}
-
Manuel Rego Casasnovas authored
An element with "contain: layout" should be the containing block of any absolutely or fixed positioned descendants. The spec is very clear regarding this (https://drafts.csswg.org/css-contain/#containment-layout): "The element acts as a containing block for absolutely positioned and fixed positioned descendants." The patch just adds a new condition to ComputedStyle::CanContainFixedPositionObjects(). We already had the condition for paint containment before, so this takes advantage to add WPT tests to verify that case too. This patch causes that contain-layout-005.html starts to fail, but that's because of crbug.com/843329. There are more failing tests related to that bug, so TestExpectations is modified to reference it. BUG=785212 TEST=external/wpt/css/css-contain/contain-layout-006.html TEST=external/wpt/css/css-contain/contain-layout-007.html Change-Id: I8bb1d637bd7742961a414a5007b8ee8a8d3e66ea Reviewed-on: https://chromium-review.googlesource.com/1059557Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#559045}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Change-Id: I361dc479f0e8bdb1054107bc9caf60b476608116 Reviewed-on: https://chromium-review.googlesource.com/1061253Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#559044}
-
Gabriel Charette authored
TBR=danakj@chromium.org, kylechar@chromium.org Bug: 825327 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0d9637bd1a7ef0c7096482d0e612f67da3a8dc1d Reviewed-on: https://chromium-review.googlesource.com/1055887Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#559043}
-
Guido Urdaneta authored
Bug: 843149 Change-Id: Ic7504928e13de7e19e286f351997d28b19e0e18f Reviewed-on: https://chromium-review.googlesource.com/1059625 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559042}
-
Noel Gordon authored
This creates Tasks/FileManagerBrowserTest. Move old fixtures into this new fixture. The old fixtures now go the way of the Dodo and Flakiness Dashboard will stop getting data from them. That's fine - the new test fixture provides the "tasks" test data. These test are not supported on mash: add mash test exclusions. Remove the "CanHandle type" comment: that bug was fixed. QuickView must still be excluded in my testing: retain its exclusion. Tbr: slangley No-Presubmit: true Bug: 843030 Change-Id: I7b3d9a1d3cd30d5934289ddc3a3ba0cd473246db Reviewed-on: https://chromium-review.googlesource.com/1060936 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#559041}
-
Sami Kyostila authored
Use the "Chrome" product when uploading crash reports in headless mode. In order to make the headlessness of these reports easier to spot, we also set a permanent "headless=true" crash key. BUG=824850 Change-Id: I389134f46ce101c6cb88bd15a885cf1877a70483 Reviewed-on: https://chromium-review.googlesource.com/1059621Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#559040}
-