GitLab

func_name has been removed in Python 3.
__name__ does the same thing and exists in both Python 2 and 3.

Traceback (most recent call last):
  File "../../third_party/blink/renderer/build/scripts/make_document_policy_features.py", line 38, in <module>
    json5_generator.Maker(DocumentPolicyFeatureWriter).main()
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 337, in main
    writer = self._writer_class(args.files, args.output_dir)
  File "../../third_party/blink/renderer/build/scripts/make_document_policy_features.py", line 19, in __init__
    def generate_implementation():
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\template_expander.py", line 76, in real_decorator
    generator_internal.func_name = generator.func_name
AttributeError: 'function' object has no attribute 'func_name'

Bug: 941669
Change-Id: Idc9654bfb71c2a0a53448ad81e680c6f460c8c62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089842
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747444}

As preparation for NativeUnwinderAndroid, Chrome Module is injected into
ChromeUnwinderAndroid. Module are compared using their addresses.
The chrome module will eventually be created from proc/maps.

Bug: 989102
Change-Id: I3120c4e352fcefef577c4ef9d8c3e7ed7b5a370b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083439
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747443}

The test tries to tap the home button (using GetBoundsInScreen to get
the button location), but misses it in some cases (because it gets
coordinates that are outside the screen bounds).

This started flaking out when the navingation buttons bounds
animator was switched to use transforms instead of bounds - CL:2086257 -
when setting home button bounds without animation, ShelfNavigationWidget
would just set the new button bounds rect, without stopping any in
progress bounds animation. This works well if only bounds are animated,
but it doesn't stop the transform animation. So if the bounds are set
directly, the transform would keep animating, but transform would be
calculated relative to the actual target bounds.

BUG=1058514

Change-Id: Ib53f40bcb828ce4fce01364e02c48b8c28586b92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090460Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747442}

This is a speculative fix. But I think it has few / no side effects.

Not 100% sure what's causing this crash, but I have two theories:
 1. Perhaps navigation_handle()->GetWebContents() can return nullptr
    now. On Android only maybe?
 2. I think posting to the UI thread is wrong in any case, we should be
    posting to the current sequence, as otherwise dereferencing the
    weak pointer is invalid. (It's not sequence-safe).

Bug: 1058303
Change-Id: I75fcb86d58602d26e7b8d6991fd933b70881bd99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090300
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747441}

Notifications should be shown only when app limit has changed. To
know if app limit has changed at the beginning of each session, check
if the new limit's update is after the latest seen before. If so, show
notification.

Bug: 1056463
Change-Id: I5a66563898c46cbee1b91e30d2306cfc68efebce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086254
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747440}

This is a reland of b5018edf

Original change's description:
> [Offline indicator v2] Add Java animations
> 
> This CL implements the color and text transition animations that run when
> showing or hiding the status indicator.
> 
> Show:
> 1- Transition the status bar color.
> 2- Wait for the browser controls animation in cc to finish.
> 3- Fade in text.
> 
> Hide:
> 1- Transition the status bar and the indicator color.
> 2- Wait 2 seconds.
> 3- Fade out text, and transition the status bar and indicator color back
> to the original status bar color.
> 4- Let the browser controls hide animation run in cc.
> 
> Bug: 989148
> Change-Id: If19a51e6c5091436d78e34ef50f11ffa0118ee0d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067095
> Commit-Queue: Sinan Sahin <sinansahin@google.com>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747080}

Bug: 989148
Change-Id: I0bf7813c4ef7833d66e449863d16cc1068bc9572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090015Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#747439}

Upon receiving the updated metadata and position information for the
active media session from Media Session Controller, cras_audio_handler
will parse and repack the data for the audio client for further
processing.

Categorize the MediaSessionInfo::SessionState::kDucking to "playing"
instead of "stopped" for audio client.

BUG=b:147365593, b:147365793, b:147367068
TEST=chromeos_unittests

Change-Id: Iea65b931580b5725b807ae268958cf225e121195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088799Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Michael Sun <michaelfsun@google.com>
Cr-Commit-Position: refs/heads/master@{#747438}

Also, add warnings, because far too many people see a file with
alphabetized contents and then just drop their stuff at the end.

BUG=none

Change-Id: Ib2acab6ae1e4ff041ea8665790524a8494ca29eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087114
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747437}

Bug: 1007815
Change-Id: Ie29c204ced96f1975cb5f2c287dfb8a3a6a36325
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089875Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747436}

If the user has more than one profile,
specify the profile directory in the jumplist menu item.

Bug: 19072
Change-Id: I6ece249f4414d01779f30473a24984a73164e08e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079216
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747435}

CL 2088233 wrapped some elements on the privacy page into dom-if's such
that they no longer appear in the static element map accessed with .$.

Code that relied on these elements existing in this map thus failed.
This CL changes these call sites to instead use the query selector $$
call, which will successfully return the elements inside a dom-if.

Bug: 1058960
Change-Id: I2e0380a7e5f4251865f5ae809037401fccbc7446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090456
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747434}

Also added rich UI element for KpEntityResultParser.

Bug: b/150783279
Test: unit tests
Change-Id: Ia40b848f9e9caf8b246627d415b4b41fe188b28b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088212Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747433}

This being the source of the crowd's recent oh-ah noises.

Bug: 992819
Change-Id: I22c56910f25b1e9b704950ca84716a1fa05a9593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089432Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747432}

The LoadProgress MVC refactoring inadvertently dropped a check against
starting load progress for same-doc navs; this patch restores that check.

Bug: 1058778
Change-Id: I17087cdefe9ecadb37e6ca84cc75839a7ccee59c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088833
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747431}

Bug: 1058447
Change-Id: I6783cd081f5396f2c9fd098a31fadd5835c1af67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089990Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747430}

Bug: 1020720, 1009638
Change-Id: If6abc991ec412400449b6501012e200bdf01fb59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078556Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747429}

Currently table layout interfaces are used in IsDataTable(), but
unfortunately these interfaces will not work if a table is styled using
another display type, e.g. display: block / flex, etc.

This CL does not change how ordinary <table> elements are exposed.
It only makes the display style irrelevant in how a table is exposed.

Bug: 1011067

Change-Id: I2044015e1ec1345a9bc636f867526c7b75a78041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083602
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747428}

This CL adds the 3.11.4 protoc prebuilt binary to the repo to be used to
compile java protos used on chrome>Android.

Bug: 988512
Change-Id: I30b2d9fde9093f468f4d01b19ece39f4bfb23428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079617
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747427}

It was enabled by default in M81.

Bug: 1032324
Change-Id: I6e9aa76c5cfbae1c239de6b968b1b9e9d66ff7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088342Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747426}

https://webrtc.googlesource.com/src.git/+log/b05ca4b6168c..987ef4825826

git log b05ca4b6168c..987ef4825826 --date=short --first-parent --format='%ad %ae %s'
2020-03-05 terelius@webrtc.org Adds field trial to separate audio and video packets for delay-based overuse detection.
2020-03-05 srte@webrtc.org Always limit delay based bitrate by the acknowledged rate.
2020-03-05 danilchap@webrtc.org Fix dependency templates for VP8 3 temporal layers

Created with:
  gclient setdep -r src/third_party/webrtc@987ef4825826

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I8e9ad1082995ae7cff049053b602810cef9b574c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090215Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747425}

Previously, IE would be launched directly from the UI thread. This was
not only causing jank, but also browser freezes when `DdeConnect()'
would take a long time to complete (>1min in some cases).

This CL makes `DdeConnect()' and `base::LaunchProcess()' run on a worker
thread with blocking allowed, so the browser is still responsive in the
meantime.

Bug: 1054895
Change-Id: I305063c12ebce67a9feffecfeb9f1d4c75211cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082994
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747424}

This DCHECK is occasionally hit. Printing the error description will
provide more details in order to determine the cause.

Bug: 1058354
Change-Id: Ib36ed843aaccb3f83ff0b915bebfe05ac2ce066e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090027
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747423}

https://chromium.googlesource.com/openscreen.git/+log/af823daff93a..1bdc5980b3a4

git log af823daff93a..1bdc5980b3a4 --date=short --first-parent --format='%ad %ae %s'
2020-03-05 rwkeane@google.com Discovery: Update config comments

Created with:
  gclient setdep -r src/third_party/openscreen/src@1bdc5980b3a4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I92515b019049197b5b210e62e000f276be0f1612
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090221Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747422}

Add files-ng classes and attribute to main.html so files-ng styles are
applied during app startup (to avoid a FOUC flash of non-files-ng blue
color).

Enable file-ng by default in FilesApp and its browser test harness.

Bug: 992818
Change-Id: If437271c5604d36b4b0908abb663a84e52b6ae35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087308Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747421}

Bug: 1054829
Change-Id: I92c11dbac5541ca783895b7afc5d5c172c50f73e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089975Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747420}

Supersize tiger viewer until now used just a regular fetch since it only
dealt with public files. This cl allows it to use Google Cloud Storage'
json api to access private files which the user has access to.

Bug: 1048299
Change-Id: If4f4015efddea771c0de9fa36193d861a72902e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088639
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747419}

https://skia.googlesource.com/skia.git/+log/2dbcbe8b12e8..456f9b5fe9d2

git log 2dbcbe8b12e8..456f9b5fe9d2 --date=short --first-parent --format='%ad %ae %s'
2020-03-05 egdaniel@google.com Reland "Move GrGpuResource GrSurface and GrTexture into src."
2020-03-05 robertphillips@google.com Clean up for DDL program pre-compilation
2020-03-05 robertphillips@google.com Clarify expected compatibility matrix in CharacterizationFBO0nessTest
2020-03-05 nifong@google.com Remove all uses of bones
2020-03-05 herb@google.com Add Multiply-Subtract (fms) to SkVM
2020-03-05 reed@google.com expose per-vertex-data variant of SkVertices
2020-03-05 csmartdalton@google.com Don't rely on primProc textures when adding samplers
2020-03-05 tdenniston@google.com Add command line argument to specify the rendertests file.
2020-03-05 mtklein@google.com move skvm interpreter to SkOpts again
2020-03-05 jlavrova@google.com Adjusting getRectsForRange to grapheme edges.

Created with:
  gclient setdep -r src/third_party/skia@456f9b5fe9d2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: herb@google.com
Change-Id: I44ab28e14bf7aa4ccbcb737e4844958589403297
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090219Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747418}

This CL deduplicates and consolidates Phone and Tablet behavior.

Bug: 1050813
Change-Id: I6bf10f973c1b569570bc56fa821e53a0d69924fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086552
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747417}

StyleResolverState::DistributedToV0InsertionPoint() doesn't mean that
it is a V0 host child. There is no use in trying to make sense of that
now as Shadow DOM v0 is going away, but the fact that it can actually
be a shadow root child means parentElement() might be null.

Bug: 1058605
Change-Id: Ia791f2caa1a4c7c19935135611a1fbdcfb07dc47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089753Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747416}

- ProfileCardView inherit from textbubble
- Add DEPs

Bug: 1058144
Change-Id: I1c84bddc824993f170949fa919e8a18e9d9db542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085876
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747415}

win-archive-rel failure appears to be due to lack of dependency between
storage_access_api and //content/public/browser, which exports
//components/services/public/mojom.

Failure here:
https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/11508

TBR=engedy@chromium.org,sky@chromium.org

Change-Id: I31d62ce8e20b4920939842f2816ae3626208bf21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090601
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747414}

This reverts commit e8a71fe7.

Reason for revert: Broke downstream build (remaining reference: https://crrev.com/i/2687160)

Original change's description:
> [webauthn] Clean up adjusted_timeout
> 
> crrev.com/c/2084725 moved the timeout adjustment logic to the browser
> side while keeping the old behaviour to make internal android source
> happy. This removes the old behaviour.
> 
> Fixed: 976428
> Change-Id: I2c6acb06f3efc6c4efbfc917b06a06603b81e7e6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090091
> Commit-Queue: Nina Satragno <nsatragno@chromium.org>
> Commit-Queue: Ken Buchanan <kenrb@chromium.org>
> Auto-Submit: Nina Satragno <nsatragno@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747346}

TBR=kenrb@chromium.org,nsatragno@chromium.org

Change-Id: Ic94a92fdb09d498755d2ad5d6f038b73a23ed8d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090617Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747413}

This reverts commit bec9b617.

Reason for revert: breaks org.chromium.chrome.browser.compositor.overlays.strip.TabStripTest suite

Original change's description:
> Fix chopped text on tab switcher long-press menu when text size is huge
> 
> There exists some unknown issue on the measurement of a text view with
> a compound drawable. Using a linear layout containing an imageview and
> a textview inside can avoid this issue.
> 
> Bug: 1053448
> Change-Id: Ibdcd220e0eba7218c1d500d870da17d37c7e767c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083729
> Commit-Queue: Lijin Shen <lazzzis@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747078}

TBR=twellington@chromium.org,lazzzis@chromium.org

Change-Id: I8cc77daf8bfdf3a7a74a4288034de5a5ccdbc992
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1053448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090598Reviewed-by: Ender <ender@google.com>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#747412}

When a user clicks and drags the thumb, the sequence of events that
gets generated is pointerdown, pointermoves(s), pointerup. The very
first pointerdown sets up the state necessary for the scrollbar thumb
drag. The pointerdown also injects a synthetic GestureScrollBegin in
the CompositorThreadEventQueue. However, this GSB won't get dispatched
until the next VSync. Sometimes, a pointerdown and the following
pointermove can arrive at the ScrollbarController before the GSB is
dispatched at the VSync. When this happens, the value of the
currently_scrolling_node is null (since the GSB wasn't dispatched yet).
This in turn causes the drag_state_ to be nullopt and we get stuck in
a state where thumb drag doesn't work (because we keep early'ing out in
ScrollbarController::HandlePointerMove).

The fix here is to use ScrollbarLayerImplBase::scroll_element_id() to
look up the target node. That way, even tough the pointermove arrives
before the GSB, the node to be scrolled can still be queried by
ScrollbarController::HandlePointerMove.

Bug: 1057929
Change-Id: I5cd584b9298c97fc2feb058aa6b46d264f0cdc17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085533
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747411}

https://chromium.googlesource.com/angle/angle.git/+log/852653954526..55228e53750d

git log 852653954526..55228e53750d --date=short --first-parent --format='%ad %ae %s'
2020-03-05 spang@chromium.org Add Chrome texture formats test for VulkanExternalImageTest

Created with:
  gclient setdep -r src/third_party/angle@55228e53750d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1058521
Tbr: ianelliott@google.com
Change-Id: I3f0fa21b09c3270d3a413e208c717c340ee36075
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090218Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747410}

This CL ensures that restored AppStates are not overwritten
when OnAppAvailable calls are called.

Bug: 1056475, 1019837
Change-Id: I8f8d14300a1e9d63a7e1cfcb2de21beda6ea7123
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085844
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747409}

-[UIViewController popViewControllerAnimated:] should not be used to
know if a view controller is removed or not. This method is called when
the view starts to be swapped away. Unfortunately, the gesture can
cancel the swipe.
This is an issue since the coordinator is stopped and deallocated at
as soon as the method is called.

This method needs to be replaced by -[UIViewController
didMoveToParentViewController:]. This method is called when the view
controller is really popped out of the screen.

Cleanup for popViewControllerAnimated with: crrev.com/c/2089811

Bug: 1055782
Change-Id: Ibddec42996506eec3d6898ef4a2cc68ab8973784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088516Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747408}

In Display::RemoveOverdrawQuads we use the quad->rect area and
quad->visible_rect area to influence occlusion culling and quad
splitting. In some cases (as found by cluster_fuzz) the rect area does
not fit into an int. We prevent these cases by validating the quad rects
in mojom_traits.

Test: VizSerializationPerfTest.DelegatedFrame_ManyQuads_1_4000
Bug: 1055766
Change-Id: Ia7686f5f9073f39f99b560df32d01efb0faa6903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078737Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747407}

Add whitelist of stylus bluetooth button devices, and specify that
they don't have a keyboard.

Bug: b:139781900, b:147859473
Change-Id: Ice2f8bcef453526f2e1f06937fb947a32d92f198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084722
Commit-Queue: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747406}

This field will not be used when painting with LayoutNG fragment
traversal.

Bug: 1043787
Change-Id: I7196c9ea0175d357a3d7c3f0be4c4044c9a70461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089754Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747405}