Commits · e684d7bcf3549c24e12153985f974ac5dfd3a0eb · eriksson monteiro / tangled

05 Jun, 2014 40 commits

Make DummyPageHolder to have all empty clients · e684d7bc

yosin@chromium.org authored Jun 05, 2014

This patch changes DummyPageHolder to use fillWithEmptyClients() instead of making specific empty clients for writing tests depending on client objects not created in current DumpPageHolder class, e.g. spell checker client for editing test.

BUG=n/a
TEST=n/a

Review URL: https://codereview.chromium.org/311263007

git-svn-id: svn://svn.chromium.org/blink/trunk@175563 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e684d7bc

Trigger computation of font size when crossing foreignObject boundary · 18f0099a

davve@opera.com authored Jun 05, 2014

When crossing the svg -> html boundary through a foreignObject, the
zoom factor is reset to its initial value. This is because SVG has a
special zoom model where the SVG fragment root puts the scale factor
on the graphics context, in contrast to non-SVG content where each
value is scaled individually.

This means the FontBuilder can't just inherit the font from parent
when crossing a foreignObject boundary. It may have to recompute the
font size because the effective zoom, included in the computed font
size, may change.

Example of behavior after this patch:

<html> <!-- computed font size: 16px. -->
  <body style="zoom: 2"> <!-- computed font size: 32px. -->
    <svg> <!-- scale(2) is applied to the graphics context; computed font size: 32px. -->
      <text>Sample svg text.</text> <!-- svg ignores computed font size to be able to support minimal font size. -->
      <foreignObject> <!-- html rendering again but scale(2) still applied to GC. computed font size must be reset to 16px. -->
        Sample html text. <!-- Text drawn with computed font size 16px but scaled to 32px by the GC -->

In this annotated test, 'Sample html text.' and 'Sample svg text.'
should both be displayed with a 32px font size.

Note: One difference is that the 'sample html text' is not sensitive
to the correct minimal font size since that happens before the scale
on the GC is applied. In order to get proper minimal font size working
on foreignObject, we would probably have to put foreignObject in a
layer separated from the graphical context of the SVG.

BUG=374119

Review URL: https://codereview.chromium.org/308123010

git-svn-id: svn://svn.chromium.org/blink/trunk@175562 bbb929c8-8fbe-4397-9dbb-9b2b20218538

18f0099a

Revert of Remove scoped styles. (https://codereview.chromium.org/310443002/) · 649efb8f

peter@chromium.org authored Jun 05, 2014

Reason for revert:
Broke every incremental compile bot on the waterfall:

InternalRuntimeFlags.h: In member function 'bool WebCore::InternalRuntimeFlags::styleScopedEnabled()':
InternalRuntimeFlags.h:110:40: error: 'styleScopedEnabled' is not a member of 'WebCore::RuntimeEnabledFeatures'
     bool styleScopedEnabled() { return RuntimeEnabledFeatures::styleScopedEnabled(); }

While a clobber build indeed fixes the problem, it also breaks local
builds, which increases the cost of this CL significantly. Let's try
to find a proper solution in the bug.

BUG=381111

Original issue's description:
> Remove scoped styles.
> 
> Removes <style scoped>.
> 
> This was discussed and approved with LGTMs in blink-dev:
> https://groups.google.com/a/chromium.org/d/msg/blink-dev/R1x18ZLS5qQ/Bjuh_cENhlQJ
> 
> Chrome status dashboard entry:
> http://www.chromestatus.com/features/5374137958662144
> 
> Note:
> this is based on esprehn's original cl:
> https://codereview.chromium.org/214693002/
> 
> BUG=379096
> TEST=pass all layout tests
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175555

TBR=esprehn@chromium.org,tasak@google.com,kochi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=379096

Review URL: https://codereview.chromium.org/315173002

git-svn-id: svn://svn.chromium.org/blink/trunk@175561 bbb929c8-8fbe-4397-9dbb-9b2b20218538

649efb8f

GC_TRACING dumps its result to stderr · 518f4440

kouhei@chromium.org authored Jun 05, 2014

Before this patch, GC_TRACING dumped its result to stdout.
This has caused all LayoutTests to fail.

This patch changes dump output to stderr, so LayoutTest run is not affected.

Unfortunately there is no trybot with ENABLE(GC_TRACING).
NOTRY=true
BUG=381038

Review URL: https://codereview.chromium.org/314943004

git-svn-id: svn://svn.chromium.org/blink/trunk@175560 bbb929c8-8fbe-4397-9dbb-9b2b20218538

518f4440

Set correct Function.length on overloaded and variadic methods · a8af5587

jl@opera.com authored Jun 05, 2014

According to WebIDL, the Function.length property should be the length of
shortest argument list in the effective overload set for argument count 0.
This means for instance that variadic arguments don't contribute to the
length.

BUG=377718

Review URL: https://codereview.chromium.org/296403007

git-svn-id: svn://svn.chromium.org/blink/trunk@175559 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a8af5587

WebPrivatePtr: avoid creating temporary Persistent<> on assignment. · 1a949bb9

sigbjornf@opera.com authored Jun 05, 2014

For RefCountedGarbageCollected objects wrapped in a WebPrivatePtr, the
PtrStorageImpl::assign(PassRefPtr<T>) overload potentially created a
Persistent on assigning its underlying raw pointer, even if a RawPtr<>
was passed along (due to the implicit RawPtr<T> conversion that
PassRefPtr<T> provides.)

This assign() overload serves no real purpose with Oilpan enabled;
provide a more appropriate RawPtr<T> version there.

R=haraken@chromium.org,tkent@chromium.org
BUG=357163

Review URL: https://codereview.chromium.org/313173009

git-svn-id: svn://svn.chromium.org/blink/trunk@175558 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1a949bb9

Add UseCounters for the types of mixed content we currently don't block. · bb286a99

mkwst@chromium.org authored Jun 05, 2014

In order to evaluate when we can start dropping support for passive
mixed content, this patch adds counters to ResourceFetcher for the four
resource types we currently don't block: images, media, tracks, and raw.
This patch also drops the 'MixedContentFont' enum, as we now consider
that active content.

Review URL: https://codereview.chromium.org/312253003

git-svn-id: svn://svn.chromium.org/blink/trunk@175557 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bb286a99

Correctly handle accessing a replaced Attr object's attribute value. · 9c979f90

sigbjornf@opera.com authored Jun 05, 2014

If element.setAttributeNode(attr) is performed on an "element" with
an attribute that matches "attr.name", that attribute's value is
updated and attr is attached to "element".

Later accesses of "attr.value" must continue to resolve to "element"'s
underlying attribute, matching (local) names following the case
sensitivity of the element.

A normalized local name was previously assumed for the attribute,
leading to crashing conditions on both setting and getting "attr.value".
Address by having Attr record the local name of the element attribute
it is attached to and use that when looking up the attribute.

R=adamk@chromium.org
BUG=376718

Review URL: https://codereview.chromium.org/316583002

git-svn-id: svn://svn.chromium.org/blink/trunk@175556 bbb929c8-8fbe-4397-9dbb-9b2b20218538

9c979f90

Remove scoped styles. · 4f9c459c

kochi@chromium.org authored Jun 05, 2014

Removes <style scoped>.

This was discussed and approved with LGTMs in blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/R1x18ZLS5qQ/Bjuh_cENhlQJ

Chrome status dashboard entry:
http://www.chromestatus.com/features/5374137958662144

Note:
this is based on esprehn's original cl:
https://codereview.chromium.org/214693002/

BUG=379096
TEST=pass all layout tests

Review URL: https://codereview.chromium.org/310443002

git-svn-id: svn://svn.chromium.org/blink/trunk@175555 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4f9c459c

IDL build: Split global object computation into core and modules · 47742ce6

nbarth@chromium.org authored Jun 05, 2014

This completes the split!

Note that this deletes the top-level:
* bindings/generated.gypi
* bindings/idl.gypi
...and eliminates the variable bindings_output_dir, b/c we do not output
anything to there any longer!

One layering violation is:
constructors for interfaces in core need to know about
global objects defined in modules,
namely ServiceWorker, because some of these are exposed
to ServiceWorker.

This can be fixed by moving
ServiceWorkerGlobalScopeCoreConstructors.idl
to modules, which I'll do in a followup.

R=haraken
BUG=358074

Review URL: https://codereview.chromium.org/315003004

git-svn-id: svn://svn.chromium.org/blink/trunk@175554 bbb929c8-8fbe-4397-9dbb-9b2b20218538

47742ce6

DevTools: add test to verify matched styles for :host selector · e9da1f90

lushnikov@chromium.org authored Jun 05, 2014

This patch adds test based on the regression issue with styles sidebar
pane not showing styles for :host selectors. This test was originally
added in r174963, but the commit got reverted.

BUG=363468
TBR=apavlov

Review URL: https://codereview.chromium.org/317703002

git-svn-id: svn://svn.chromium.org/blink/trunk@175553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e9da1f90

Revert of Remove scoped styles. (https://codereview.chromium.org/310443002/) · daac6100

sergeyv@chromium.org authored Jun 05, 2014

Reason for revert:
Speculative revert: looks like this change broke compilation
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder%20%28dbg%29/builds/14856/steps/compile/logs/stdio

Original issue's description:
> Remove scoped styles.
> 
> Removes <style scoped>.
> 
> This was discussed and approved with LGTMs in blink-dev:
> https://groups.google.com/a/chromium.org/d/msg/blink-dev/R1x18ZLS5qQ/Bjuh_cENhlQJ
> 
> Chrome status dashboard entry:
> http://www.chromestatus.com/features/5374137958662144
> 
> Note:
> this is based on esprehn's original cl:
> https://codereview.chromium.org/214693002/
> 
> BUG=379096
> TEST=pass all layout tests
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175550

TBR=esprehn@chromium.org,tasak@google.com,kochi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=379096

Review URL: https://codereview.chromium.org/317143002

git-svn-id: svn://svn.chromium.org/blink/trunk@175552 bbb929c8-8fbe-4397-9dbb-9b2b20218538

daac6100

Cleanup v8 usage in core · 2258521f

nbarth@chromium.org authored Jun 05, 2014

* Explicitly include v8.h where used.
* Do *not* forward declare v8 symbols in headers, per:
http://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Exceptions

There are 27 files in core (9 .h + 18 .cpp) that use v8.
This corrects usage.

Review URL: https://codereview.chromium.org/318843003

git-svn-id: svn://svn.chromium.org/blink/trunk@175551 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2258521f

Remove scoped styles. · 174ba371

kochi@chromium.org authored Jun 05, 2014

Removes <style scoped>.

This was discussed and approved with LGTMs in blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/R1x18ZLS5qQ/Bjuh_cENhlQJ

Chrome status dashboard entry:
http://www.chromestatus.com/features/5374137958662144

Note:
this is based on esprehn's original cl:
https://codereview.chromium.org/214693002/

BUG=379096
TEST=pass all layout tests

Review URL: https://codereview.chromium.org/310443002

git-svn-id: svn://svn.chromium.org/blink/trunk@175550 bbb929c8-8fbe-4397-9dbb-9b2b20218538

174ba371

Cleanup v8 usage in modules · b23e470a

nbarth@chromium.org authored Jun 05, 2014

Followup to:
Cleanup v8 usage in core
https://codereview.chromium.org/318843003/

Review URL: https://codereview.chromium.org/319653002

git-svn-id: svn://svn.chromium.org/blink/trunk@175549 bbb929c8-8fbe-4397-9dbb-9b2b20218538

b23e470a

Test that cookies set by document.cookie are sent in a WebSocket handshake. · 1c0d2d33

tyoshino@chromium.org authored Jun 05, 2014

BUG=none

Review URL: https://codereview.chromium.org/315113002

git-svn-id: svn://svn.chromium.org/blink/trunk@175548 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1c0d2d33

Eliminate MediaPlayer & MediaPlayerClient abstractions(seek, duration, poster APIs) · ee175426

srirama.m@samsung.com authored Jun 05, 2014

Bug=350571

Review URL: https://codereview.chromium.org/306123003

git-svn-id: svn://svn.chromium.org/blink/trunk@175546 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ee175426

Add toV8Value which takes creation context and isolate to WebBlob as arguments. · a37d69ec

tasak@google.com authored Jun 05, 2014

BUG=369451

Review URL: https://codereview.chromium.org/313263002

git-svn-id: svn://svn.chromium.org/blink/trunk@175545 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a37d69ec

[WebSocket] Add tests for permessage deflate split frames. · 0665b8d7

yhirano@chromium.org authored Jun 05, 2014

Upgrade pywebsocket to r804.

BUG=NONE
R=tyoshino

Review URL: https://codereview.chromium.org/314043002

git-svn-id: svn://svn.chromium.org/blink/trunk@175544 bbb929c8-8fbe-4397-9dbb-9b2b20218538

0665b8d7

Fix bug with context menu in Layers3DView. · 23fb6337

malch@chromium.org authored Jun 05, 2014

Review URL: https://codereview.chromium.org/312193002

git-svn-id: svn://svn.chromium.org/blink/trunk@175543 bbb929c8-8fbe-4397-9dbb-9b2b20218538

23fb6337

s/scheduleLayerUpdate/setNeedsCompositingUpdate in setRemoteWebLayer. · 4510654b

ojan@chromium.org authored Jun 05, 2014

Now that frames always get a RenderLayer, we don't need to
actually do a layer update anymore.

Not sure how to test this. The original patch that added it
https://codereview.chromium.org/104433003 didn't have any
new tests.

Review URL: https://codereview.chromium.org/318863002

git-svn-id: svn://svn.chromium.org/blink/trunk@175542 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4510654b

Oilpan: update WebNotification and WebDOMMediaStreamTrack type conversions · bcf10d8c

sigbjornf@opera.com authored Jun 05, 2014

These two public/web/ types hadn't been updated to use transition types
over their underlying Oilpan-converted objects.

R=tkent@chromium.org,haraken@chromium.org
BUG=357163

Review URL: https://codereview.chromium.org/310393004

git-svn-id: svn://svn.chromium.org/blink/trunk@175540 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bcf10d8c

ServiceWorker: Add layout tests for fetch event response body · a458b890

falken@chromium.org authored Jun 05, 2014

Multi-sided patch to implement blob-type fetch event 
response bodies:
1: blink-side, https://codereview.chromium.org/307063002/
2: chromium-side, https://codereview.chromium.org/315023003/
3: blink-side, THIS PATCH

BUG=379074

Review URL: https://codereview.chromium.org/304233017

git-svn-id: svn://svn.chromium.org/blink/trunk@175538 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a458b890

Oilpan: Prepare to move EventHandler to Oilpan heap. · e7497abb

tkent@chromium.org authored Jun 05, 2014

BUG=

Review URL: https://codereview.chromium.org/317073007

git-svn-id: svn://svn.chromium.org/blink/trunk@175537 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e7497abb

Reduce dynamicscompressor threshold. · 968ecb13

rtoy@chromium.org authored Jun 05, 2014

This allows the test to pass on Windows, but still detects that
pre-emphasis is off.

BUG=349523

Review URL: https://codereview.chromium.org/314743002

git-svn-id: svn://svn.chromium.org/blink/trunk@175536 bbb929c8-8fbe-4397-9dbb-9b2b20218538

968ecb13

DevTools: show HTTP headers of cached resources in network panel. · b5669370

eustas@chromium.org authored Jun 05, 2014

Screenshot: http://picpaste.com/RaGXNCAZ.png

BUG=91276

Review URL: https://codereview.chromium.org/300913002

git-svn-id: svn://svn.chromium.org/blink/trunk@175535 bbb929c8-8fbe-4397-9dbb-9b2b20218538

b5669370

When performing a fast-path scroll, issue repaints for viewport-constrained layers · 0bb5f0a4

chrishtr@chromium.org authored Jun 05, 2014

relative to their repaint container, not their enclosing composited ancestor.

The latter is wrong for squashing.
BUG=370664

Review URL: https://codereview.chromium.org/318793002

git-svn-id: svn://svn.chromium.org/blink/trunk@175534 bbb929c8-8fbe-4397-9dbb-9b2b20218538

0bb5f0a4

Oilpan: Move ClickHandlingState to heap · f58818f5

keishi@chromium.org authored Jun 05, 2014

BUG=357163

Review URL: https://codereview.chromium.org/298963003

git-svn-id: svn://svn.chromium.org/blink/trunk@175533 bbb929c8-8fbe-4397-9dbb-9b2b20218538

f58818f5

Allow empty header value in the blink HTTP header parser. · 9e882a70

yhirano@chromium.org authored Jun 05, 2014

The HTTP header parser in Blink forbids empty header values which should
be allowed. This CL fix the issue.

BUG=380075
R=tyoshino@chromium.org

Review URL: https://codereview.chromium.org/318613002

git-svn-id: svn://svn.chromium.org/blink/trunk@175532 bbb929c8-8fbe-4397-9dbb-9b2b20218538

9e882a70

Remove some code now that forceCompositingMode is gone. · 0f4a0969

ojan@chromium.org authored Jun 05, 2014

Review URL: https://codereview.chromium.org/313053008

git-svn-id: svn://svn.chromium.org/blink/trunk@175531 bbb929c8-8fbe-4397-9dbb-9b2b20218538

0f4a0969

Frozen animations still contribute to the sandwich/animation stack · aa2b88d6

fs@opera.com authored Jun 05, 2014

With (for instance) a to-animation, the frozen element will for instance
provide the 'underlying value' to any following element.

BUG=374793

Review URL: https://codereview.chromium.org/316013003

git-svn-id: svn://svn.chromium.org/blink/trunk@175530 bbb929c8-8fbe-4397-9dbb-9b2b20218538

aa2b88d6

Oilpan: Replace RefPtr<Node> in core/svg/ with Oilpan transition types. · e687e732

tkent@chromium.org authored Jun 05, 2014

BUG=357163

Review URL: https://codereview.chromium.org/311193007

git-svn-id: svn://svn.chromium.org/blink/trunk@175529 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e687e732

Allow hitting the SVG root when its display-type is 'block' · ffa7b8b7

fs@opera.com authored Jun 05, 2014

The 'HitTestChildBlockBackground' hit test action needs to be considered
as well when detecting hits on the SVG root container itself.

BUG=379299

Review URL: https://codereview.chromium.org/318663002

git-svn-id: svn://svn.chromium.org/blink/trunk@175528 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ffa7b8b7

ResourceLoaderOptions also must be updated by updateRequestForAccessControl() · 6218d039

tyoshino@chromium.org authored Jun 05, 2014

updateRequestForAccessControl() updates ResourceRequest for access
control, but ResourceLoaderOptions passed to FetchRequest also contains
configuration items that must be updated for access control.

This CL removes cookie handling code and iframe from the following
layout tests since they're testing user:pass but not cookie.
- access-control-preflight-credential-async.html
- access-control-preflight-credential-sync.html

A new test is added to check that no cookie is set in a preflight
request. This new test uses third-party-cookie-relaxing-iframe.html
which was loaded by the two tests but was not actually used.

Missing testRunner.setAlwaysAcceptCookies() calls are added to
third-party-cookie-relaxing-iframe.html.

BUG=377541
R=japhet

Review URL: https://codereview.chromium.org/312653002

git-svn-id: svn://svn.chromium.org/blink/trunk@175527 bbb929c8-8fbe-4397-9dbb-9b2b20218538

6218d039

[GOM] Improve the display of the roll information · 8a812887

jchaffraix@chromium.org authored Jun 05, 2014

The current UI was racy and would output the last roll
and current roll in random order. This change fixes this
and puts the roll information to a new line, so that it
stands out from the bot information.

Review URL: https://codereview.chromium.org/314913002

git-svn-id: svn://svn.chromium.org/blink/trunk@175525 bbb929c8-8fbe-4397-9dbb-9b2b20218538

8a812887

Avoid calling slower Node::firstChild() / Node::lastChild() when possible · 122f1562

ch.dumez@samsung.com authored Jun 05, 2014

Avoid calling slower Node::firstChild() / Node::lastChild() when possible by
using tighter typing. This way, we end up using ContainerNode::firstChild() /
ContainerNode::lastChild(), bypassing a useless isContainerNode() check.

R=eseidel@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/307243004

git-svn-id: svn://svn.chromium.org/blink/trunk@175524 bbb929c8-8fbe-4397-9dbb-9b2b20218538

122f1562

Make sure calling moveParagaph() with proper parameters in... · a87e2853

yosin@chromium.org authored Jun 05, 2014

Make sure calling moveParagaph() with proper parameters in CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary()

This patch changes CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary()
to calculate start and end positions of paragraph to move before calling
moveParagraph(), because inserting paragraph element at |upstream| can change
start and end positions represented by |VisiblePosition|.

This patch is similar to http://crrev.com/311593003, for
InsertListCommand::listifyParagraph().

BUG=325222, 351291
TEST=LayoutTests/editing/execCommand/apply-style-empty-paragraph-start-crash.html

Review URL: https://codereview.chromium.org/315513003

git-svn-id: svn://svn.chromium.org/blink/trunk@175523 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a87e2853

Oilpan: Replace RefPtrs to Node and its subclasses in core/dom/ with Oilpan transtion types. · 131c6b2d

tkent@chromium.org authored Jun 05, 2014

- We need to update RefPtrs not in core/dom/ too because argument types of
  insertBefore/replaceChid/appendChild are changed.

- Member<T> should support implicit conversion to
  RawPtr<SuperClassOfT>.  This is necessary for code like:

    Member<HTMLFooElement> m_foo;
    ....
    parent->appendChild(m_foo);


BUG=357163

Review URL: https://codereview.chromium.org/313813002

git-svn-id: svn://svn.chromium.org/blink/trunk@175522 bbb929c8-8fbe-4397-9dbb-9b2b20218538

131c6b2d

Add the navigator.serviceWorker.waiting property. · 7e4d2558

dominicc@chromium.org authored Jun 05, 2014

The value of this property will be null because it is not being set by
the embedder yet.

BUG=379012

Review URL: https://codereview.chromium.org/313553002

git-svn-id: svn://svn.chromium.org/blink/trunk@175520 bbb929c8-8fbe-4397-9dbb-9b2b20218538

7e4d2558

Set referrer for CSS resources · e738ef9f

bashi@chromium.org authored Jun 05, 2014

The previous CL (r172433) was reverted because it caused regression.
This is second attempt to set referrer for css resource fetching.

- Add WebCore::Referrer (not String) object to CSSParserContext
- Pass the referrer to CSSImageValue, CSSImageSetValue, and CSSFontFaceSrcValue
- Set the referrer when fetching

BUG=380457,377864

Review URL: https://codereview.chromium.org/314893003

git-svn-id: svn://svn.chromium.org/blink/trunk@175519 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e738ef9f