- 25 Sep, 2020 40 commits
-
-
Collin Baker authored
As a stopgap before adding proper documentation, this comment discourages use of FeaturePromoBubbleView and redirects users to FeaturePromoController. Bug: 1132335 Change-Id: Ia036dea11232645227d62124fd6683f1a74b32b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431767Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#810710}
-
Scott Violet authored
Renames variable in LayoutBoxModelObject::ComputeStickyConstrainingRect to indicate it's a scroll-container. Changes CompositingInputsUpdater to look for scroll-container. BUG=1087667 Change-Id: If75314386fd7a2cb0afd1afcae6e0315ab951693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430184 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810709}
-
Elly Fong-Jones authored
The layout owners file is gone, which renders the test owners file broken. This was broken in r810403. This change requires a presubmit skip because the presubmit errors out on the missing owners file. NOPRESUBMIT=true Bug: None Change-Id: Ic0945a2abf3bf54908176b7ea87e6a6f62ef507f Tbr: pkasting@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431773 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#810708}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/c947efabcbc38dcf93e8ad0e6a76206cf0ec8072..3743aafdacff2f7b083615a043a37101f740fa53 The following commits have update notes: ca3f243cf Require non-NULL store in X509_STORE_CTX_init. 6d70353ca Const-correct X509V3_CONF_METHOD. 49e9f67d8 Bump OPENSSL_VERSION_NUMBER to 1.1.1. 6ad3b46b2 Remove ASN1_STRING_length_set. 1c58648f1 Remove sxnet and pkey_usage_period extensions. 9372f38cd Bound RSA and DSA key sizes better. Bug: none Change-Id: Ice42742981210fc8fa2302a5ae09080abd3d9ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431451 Commit-Queue: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#810707}
-
Charlie Hu authored
Support for intrinsicSize attribute on media element has been removed in CL (https://chromium-review.googlesource.com/c/chromium/src/+/1782660). Test on image policy with this attribute should also be removed. This CL removes related test case in document-policy-oversized-images-responsive-image.html test. Bug: 997286 Change-Id: Ib8535808c320157b7871a786cf98fbfde4bc6f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424708Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#810706}
-
Sammie Quon authored
Adds tests for crrev.com/c/2404945. Test: added Bug: 1120132 Change-Id: Ifb42fa1f8979ef7762614d6edd90dbfefa4d2f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422459 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#810705}
-
Francois Doray authored
TBR=drubery Bug: 1132307 Change-Id: I1407c77bd93d01bfa41bd5e846ea9973253e5db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431791Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#810704}
-
Yue Zhang authored
Since with instant start TabListMediator could be created before native is ready, we can no longer depend on looking at the type of current TabModelFilter in TabListMediator constructor for observer setup. Therefore, this CL moves the observer setup to initWithNative() where we are confident about using the type of TabModelFilter to decide whether we should set up observers for tab group. Bug: 1125451, 1125471 Change-Id: If156674137d64b829728402555e2cf4e06916519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429467Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#810703}
-
Henrique Nakashima authored
This is a step to unblock some classes that depend on it (list below) and allow modularized code to reuse it. 11 inbound dependency(ies) into .c.b.DeviceConditions: [chrome_java] <- .c.b.background_sync.BackgroundSyncBackgroundTask <- .c.b.background_sync.PeriodicBackgroundSyncChromeWakeUpTask <- .c.b.download.DownloadInfoBarController <- .c.b.explore_sites.ExploreSitesBackgroundTask <- .c.b.offlinepages.BackgroundSchedulerBridge <- .c.b.offlinepages.BackgroundSchedulerProcessor <- .c.b.offlinepages.OfflineBackgroundTask <- .c.b.offlinepages.prefetch.OfflineNotificationBackgroundTask <- .c.b.offlinepages.prefetch.PrefetchBackgroundTask <- .c.b.services.gcm.ChromeGcmListenerService <- .c.b.sharing.click_to_call.ClickToCallMessageHandler This also breaks about 0.4% of the existing package cycles. Change-Id: I8ff8b665af2269161811ff76a4087b7e38d38172 Bug: 1132380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429587 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#810702}
-
Mohamed Amir Yosef authored
After recent CLs, no conversion from legacy server proto to the new API server protos is required. This CL is getting rid of the code responsible for that. Bug: 1114655 Change-Id: I98d04fca0a13a13b43a950bbcb4c3f400259115a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431044 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#810701}
-
Sunny Sachanandani authored
This reverts commit 0e2b4943. Reason for revert: Trace tests failing on multiple FYI bots: crbug.com/1132375, crbug.com/1132381 Original change's description: > gpu: Remove obsolete direct composition feature flags > > Remove the NV12, decode swap chain, and underlay feature flags since > these features have shipped for quite some time. The NV12 feature flag > was also used for using YUY2 over NV12 for tests so introduce a new flag > for choosing the default SDR video overlay swap chain format. Add tests > for NV12, YUY2, and BGRA instead of just YUY2. Also cleanup some of the > testing code to be consistent in other_args, switch names, etc. > > Bug: 869677 > Change-Id: I0831b103506f394d6fe26bf1085401e2e2d50599 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424576 > Reviewed-by: Maggie Chen <magchen@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810453} TBR=zmo@chromium.org,sunnyps@chromium.org,magchen@chromium.org,enga@chromium.org Change-Id: Id3a7de405887326d0fd09d2e8efa36637ffbf4c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869677, 1132375, 1132381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432207Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#810700}
-
Evan Stade authored
Code that is required by Android must be moved. Code that is only used on desktop is generally not moved as it would require extra refactoring (e.g. because it accesses g_browser_process). The code is mostly moved without substantive changes, with a few exceptions: - KeyedServiceFactories are split into a base class and a Chrome specialization. The Chrome specialization holds the singleton LazyInstance. The base class expects exactly one instantiation. This should be safe so long as the Chrome factory's getter is called first. This applies to MediaRouterFactory and LocalPresentationManagerFactory. - Metrics code which relies on types that are now //chrome specific is inlined (moved from media_router_metrics). In wider Chrome, metrics code is not typically centralized, especially when it only has a single caller. Even in media router code, this central file was not being used consistently. - Media router dialog uses a factory method instead of a creation function that's defined at compile time. This is necessary for components_unittests to compile (the Views version no longer lives near the cross-platform MediaRouterDialogController). Bug: 1057100 Change-Id: I636eb89c121890ff9409d946ee988fc8c04a411a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405519Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#810699}
-
Michael Ludwig authored
Bug: skia:10205 Change-Id: I9a9ef9ab522741f5ed3091884f1f202a310ba8d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423314 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#810698}
-
Mohamed Amir Yosef authored
Before this patch: The old query proto was created first and then converted to the new proto. After this patch: The new query proto is created directly Bug: 1114655 Change-Id: I08255787e05f99622d9ead139cd932ced1b4a87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429407Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#810697}
-
Francois Doray authored
Bug: 1121725 Change-Id: I6ae687a4ed0324d32b76b4ec4d60b7b948245d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376445Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#810696}
-
Bence Béky authored
Change-Id: I106a5c95c36a9f885a81ff8d010d3bcbdb5cc4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431453 Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810695}
-
Bin Wu authored
https://quiche.googlesource.com/quiche.git/+log/9a74ee9f6be4..ba9d95e4328b $ git log 9a74ee9f6..ba9d95e43 --date=short --no-merges --format='%ad %ae %s' 2020-09-24 fayang Add a regression test of b/168294218, also verified gfe2_reloadable_flag_quic_fix_missing_initial_keys fixes the issue. 2020-09-24 wub Add a quic::CryptoBuffers class to own a std::vector<CRYPTO_BUFFER*> and the buffers the elements point to. Use it in TlsServerHandshaker. 2020-09-24 fayang Make sure we have the right key before sending data. 2020-09-24 fayang Add explicit signal of coalscing done to QuicConnection. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=dschinazi@chromium.org Change-Id: Ief25b2bba04ac6a0a95c92347bc69e8df36aa467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432104 Commit-Queue: Bin Wu <wub@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Bin Wu <wub@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810694}
-
Eric Orth authored
Replace |DnsConfigOverrides::hosts| with a simple |clear_hosts| bool that merely specifies to not use HOSTS read from the system. Shouldn't ever be any reason to ever override with made-up HOSTS values. This simplification cleans up a lot of unnecessary complexity and reduces net-external dependencies. Bug: 1129993 Change-Id: Ie86b5e0394f763dcbe22b1d8db127c84d3501045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419536 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#810693}
-
Pavol Drotar authored
We require the ability to tell whether the browser supports site settings shortcuts for WebApks. This change will allow us to turn site settings shortcut on/off by adding/removing a category from the manifest. Bug: 1128985 Change-Id: If1f1d672bbee162287db401ebfc947cf4ce567fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428965 Commit-Queue: Pavol Drotár <pavoldrotar@google.com> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#810692}
-
Joshua Pawlicki authored
This file should have been deleted in https://chromium-review.googlesource.com/c/chromium/src/+/2424149/4 but a bad merge resolution removed it from that CL (oops). Bug: 1131080 Change-Id: Ia07af7e19a87784049be5a8dc4fe81e66526c6e1 Fixed: 1131080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431793 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810691}
-
Charlene Yan authored
Currently layer scrolling is only enabled on mac by default. Providing a constructor arg allows users of ScrollView to enable layer scrolling regardless of platform. This will initially be used for the ScrollView container that holds the tabstrip for Tab Scrolling. Bug: 1129675 Change-Id: Ie1a34d45eac952fcaf08daa313ee15bb36aa58ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416943Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810690}
-
Austin Sullivan authored
Prefer casts to .data() when converting StringPieces to std::String. .data() returns a buffer which may not be null-terminated. Makes style consistent with FileStreamWriterTest https://crrev.com/c/2422682/comment/44d13478_d54456b9/ Change-Id: I06560e2876f58e8ce719eded41249be51707d68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425460Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#810689}
-
Kyra Moed authored
Updated LorgnetteManagerClient::StartScan() to require ScanSettings proto instead of ScanProperties struct parameter. Updated all relevant functions (including LorgnetteScannerManager::Scan() and DocumentScanScanFunction::OnNamesReceived()) to use proto as argument. Bug: b:169083357 Change-Id: I44f1314ce7c9595f675fa277599e4335da9f72d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428752Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyra Moed <kmoed@google.com> Cr-Commit-Position: refs/heads/master@{#810688}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009250800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/wdyeXKN2Sqps4c-dKz5p7osNT-u5oIOm6T_oySHQw9gC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/154881537,b/159892033,b/161496439,b/168081365,b/169107664 Tbr: media-app@grotations.appspotmail.com Change-Id: I873d94d3ad5ebd2e0dc19c9ee20ef7c78cbc12a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431833Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810687}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I16df6385534dfc88202a2b7768b5d5e340224afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431835Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810686}
-
James Vecore authored
Turns out we were not handling the peer reset events on the SendMore and ReceiveMore functions which could cause an infinite looping when the other side resets. Fixed: 1132118 Change-Id: I87113518b01f56497f09e361931cc64647819df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430294 Auto-Submit: James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#810685}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/39a3f081c129..d3db8535d3a9 2020-09-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fb765f65..063275b4 (810252:810396) 2020-09-24 deadbeef@webrtc.org Check length before dereferencing SCTP notifications. 2020-09-24 hta@webrtc.org When stopping a transceiver, end the receiver's track. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1127774 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I91eaab5b48b6ad382a1d735393629451cc14a6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430845Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810684}
-
Aaron Leventhal authored
- Display: none objects should not get an accessible name. - EnsureComputedStyle() should not be called during a potentially unsafe time. This is fixed by calling it during Init(), in cases where it will likely be needed (inside a display:none subtree). - Remove unnecessary and often incorrect heuristic for determining when inside an aria-labelledby or aria-describedy calculation. This flag is already passed in via recursion when following that kind of relation. - Do not recurse into children that are explicitly hidden - Improve explicitly hidden computation for CSS visibility. Explicitly hidden means that the element was specifically hidden, and that it didn't just inherit the fact that it's hidden. - Improve results in name-calc-visibility, where an element explicitly referenced by aria-labelledby wasn't included in the name because it was visibility:hidden element. Elements that are explicitly referenced must be included in a name or description even if they are hidden. TBR: dmazzoni@chromium.org Bug: 1130436 Change-Id: I52d11208a9658a53bf0af7313a41f4bb8eafc24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431448Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#810683}
-
Daniel Rubery authored
This CL extends a few high-level metrics for Safe Browsing download scanning: Download.DangerousFile.DownloadValidatedByType Download.ShowedDownloadWarning Download.UserValidatedDangerousDownload SBClientDownload.CheckWhitelistResult SBClientDownload.DmgFileSuccessByType SBClientDownload.DownloadRequestPayloadSize And expires: SafeBrowsing.UnverifiedDownloads.Allowed SafeBrowsing.UnverifiedDownloads.AllowedByWhitelist SafeBrowsing.UnverifiedDownloads.AllowedDueToDisabledService SafeBrowsing.UnverifiedDownloads.AlternateExtensionCount SafeBrowsing.UnverifiedDownloads.Blocked SBClientDownload.RarFileArchivedBinariesCount Fixed: 1089447, 1089446, 1089430, 1088739, 1088727 Change-Id: I7034520fc0b4241feee8c59775f0aadf57472d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429228 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#810682}
-
Nela Kaczmarek authored
This change moves the implementation of MockAffiliationFetcherDelegate from affiliation_fetcher_unittest.cc to mock_affiliation_fetcher_delegate.h. It is required to use the instance of MockAffiliationFetcherDelegate in the unit tests of HashAffiliationFetcher yet to be implemented. Bug: 1108279 Change-Id: I902cc13f1c66bc079a28b76d904353196a1cb157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426584Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Cr-Commit-Position: refs/heads/master@{#810681}
-
Collin Baker authored
This is a reland of 944aea5f The test relied on the toolbar being hidden at the start. This CL shows IPH bubble on the toolbar, causing a toolbar reveal. While this is desired behvaior in production, the test needs to disable the IPH to work correctly. This reland adds a FeaturePromoControllerViews method to cancel the current IPH promo and block later ones. The test is changed to call it at the beginning. Original change's description: > Show in-product help when WebUI tab strip is first shown > > Before, an IPH bubble was shown when a second tab was opened. With > this CL it is shown as soon as possible after the WebUI tab strip is > initialized. > > Bug: None > Change-Id: I2f3e7a7dd04229953af5eefe99e00dbcbbfaa8da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418566 > Commit-Queue: Dana Fried <dfried@chromium.org> > Reviewed-by: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810097} Bug: None Change-Id: Ic3c06f6c35ce9014c3370abc86c029de5af3bb22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429400 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810680}
-
Dave Tapuska authored
WebFloatSize has been replaced with gfx::SizeF and is no longer used. BUG=1097816 Change-Id: Ifa45a28d412fb134614e4447e196e5480db760e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428827Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#810679}
-
Gyuyoung Kim authored
In public/common, *Web* prefix doesn't tend to be used. So, this PR removes *Web* prefix in the WebViewportStyle. Bug: 919392 Change-Id: I3fd0b104f8b003c09f96caf7e34b3e86a4646f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423755Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#810678}
-
Jan Wilken Dörrie authored
This change replaces usages of autofill::PasswordForm with password_manager::PasswordForm in the file range [leak...orig] in the //components/password_manager/core/browser directory. Bug: 1067347 Change-Id: I952a90a51ad52740f755683752ceaf81768e9e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430985Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#810677}
-
Jan Wilken Dörrie authored
TBR=sebsg Bug: 1132310 Change-Id: Ie981d1cb4675cb8656b0f182b75491800e1941ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431485Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#810676}
-
Harvey Yang authored
This commit adds MojoConnectionServiceProvider in //chrome/browser/chromeos, which lets processes connect to Chrome, bootstrap to mojo network, and establish the required mojo channel. Currently it supports IIO Service and Sensor Clients, such as iioservice_simpleclient and powerd. BUG=b:162189963 TEST=builds and test with IIO Service and iioservice_simpleclient on octopus. Cq-Depend: chromium:2392288 Change-Id: I58acb88045b398031bedbf47474a913eb0ed4913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352298Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810675}
-
Marijn Kruisselbrink authored
We would like to keep monitoring these for a while as this API starts getting more use. Bug: 1104951 Change-Id: Idfe971411ee812343ede0197cd27ff0297795c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430229Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#810674}
-
Esmael El-Moslimany authored
The restyle to match the modules is only enabled when the ntp-modules feature flag is enabled. Bug: 1110067 Change-Id: Ib394df60498bca8845b3cbd49bd49cdedd72c2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429230 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#810673}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5d6c6b52. With Chromium commits locally applied on WPT: 8f02a380 "Use allow attribute for delegation in web serial WPT" c1a7d15a "[LayoutNG] Multicol baseline propagation support." f30daabb "[COOP] access reporting: test with redirects." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I6cf9507279b12fa0bf4ddeeb5afdbc059b027d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432044Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810672}
-
Orin Jaworski authored
Bug: 893183 Change-Id: I26120d43a87e2faf313c9cf2cafb7664f17759e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430185 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#810671}
-