GitLab

Revert of Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA (patchset #1 id:20001 of https://codereview.chromium.org/813693006/)

Reason for revert:
This is breaking arm builds. See for example:

https://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%29/builds/4129/steps/cbuildbot/logs/stdio

Original issue's description:
> Reland: Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA.
>
> This is a reland as the previous CL has an issue with BUILD.gn and failed gn build.
>
> An AcceleratedVideoDecoder is a video decoder that requires support from an
> external accelerator (typically a hardware accelerator) to partially
> offload the decode process after parsing stream headers, and performing
> reference frame and state management.
>
> In this design, the hardware-independent decoder implementation interfaces
> with a HW-specific Accelerator to offload last stages of the decode process.
>
> Add the interface for AcceleratedVideoDecoder, decoders for VP8 and H264,
> V4L2-specific Accelerators for VP8 and H264 and a common accelerator/client
> class for V4L2.
>
> TEST=vdatest VP8/H264, mp4 local video playback, apprtc decode
> BUG=chrome-os-partner:33728
> TBR=wuchengli@chromium.org,kcwu@chromium.org,owenlin@chromium.org,xhwang@chromium.org,scherkus@chromium.org,dalecurtis@chromium.org
>
> Committed: https://crrev.com/3c09b9b26ee6fc8b43c7535070cfa08aba1285cf
> Cr-Commit-Position: refs/heads/master@{#311464}

TBR=wuchengli@chromium.org,kcwu@chromium.org,owenlin@chromium.org,xhwang@chromium.org,scherkus@chromium.org,dalecurtis@chromium.org,posciak@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chrome-os-partner:33728

Review URL: https://codereview.chromium.org/852103002

Cr-Commit-Position: refs/heads/master@{#311561}

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/849073005

Cr-Commit-Position: refs/heads/master@{#311560}

On iOS the omnibox display a different icon for result coming from "history",
"search" and others sources, including different colors when in Incognito
mode.

Add iOS specific resources and introduce a variation in TypeToIcon() method
to allow distinguishing result coming from "history" from the rest.

BUG=446930

Review URL: https://codereview.chromium.org/847833002

Cr-Commit-Position: refs/heads/master@{#311559}

BUG=441409
NOTRY=true

Review URL: https://codereview.chromium.org/819363003

Cr-Commit-Position: refs/heads/master@{#311558}

BUG=448472

Review URL: https://codereview.chromium.org/846293002

Cr-Commit-Position: refs/heads/master@{#311557}

Also fix testMoveToElementAndClick on Android.

BUG=

Review URL: https://codereview.chromium.org/817913004

Cr-Commit-Position: refs/heads/master@{#311556}

Revert of Disable spdy tests for constant failures on Volantis bot (patchset #2 id:20001 of https://codereview.chromium.org/836033006/)

Reason for revert:
https://crrev.com/852053002 fixes the tests, they can be re-enabled.

Original issue's description:
> Disable spdy tests for constant failures on Volantis bot
>
> Per
> https://uberchromegw.corp.google.com/i/clank/builders/instrumentation-volantis-clankium-lmp,
> all spdy related tests have failed on volantis bot.
>
> BUG=447837
>
> Committed: https://crrev.com/f13f7dbe2ec8d008d7aefa4c625d297685e62435
> Cr-Commit-Position: refs/heads/master@{#311401}

BUG=447837

Review URL: https://codereview.chromium.org/800613008

Cr-Commit-Position: refs/heads/master@{#311555}

- Switching behavior of command line to send all field trials from the browser to the renderers.
- Added notification from renderer to browser whenever a trial is activated.

BUG=430924

Review URL: https://codereview.chromium.org/700953002

Cr-Commit-Position: refs/heads/master@{#311554}

Change the WebCrypto behavior when exporting EC private keys that were imported without a public key.

Before such keys were exported to PKCS8 format, the publicKey would be missing in the ECPrivateKey.

Now instead the publicKey is written to exported bytes even if it was not provided during import.

This is more consistent with how export works for JWK, where the public key is a required parameter.

It also speeds up the structured (de) cloning of such keys, which uses PKCS8 format under the hood (and for which if the publicKey was not provided, BoringSSL computes it).

BUG=445635

Review URL: https://codereview.chromium.org/835633002

Cr-Commit-Position: refs/heads/master@{#311553}

Revert of Update V8 to version 4.2.3 (based on b62f094884b95cf7b45484a27a9721a8477efc91). (patchset #1 id:1 of https://codereview.chromium.org/807183004/)

Reason for revert:
Breaks win8 gn

Original issue's description:
> Update V8 to version 4.2.3 (based on b62f094884b95cf7b45484a27a9721a8477efc91).
>
> TBR=machenbach@chromium.org
>
> Committed: https://crrev.com/1f4c50ac8b1359e524b5da7e444a667c6b41d19b
> Cr-Commit-Position: refs/heads/master@{#311548}

TBR=v8-autoroll@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/853763002

Cr-Commit-Position: refs/heads/master@{#311552}

Revert of [Telemetry] Fix WPR files not being downloaded when required. (patchset #4 id:60001 of https://codereview.chromium.org/834173006/)

Reason for revert:
Possible suspect for newly introduced telemetry unit test flake, e.g.:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/1965/steps/telemetry_unittests/logs/stdio

Reverting to see what happens.

Original issue's description:
> [Telemetry] Fix WPR files not being downloaded when required.
>
> BUG=
>
> Committed: https://crrev.com/672e7140315568e9bfc442770a23fee66e045cb2
> Cr-Commit-Position: refs/heads/master@{#311496}

TBR=nednguyen@google.com,aiolos@chromium.org,lizeb@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/852863003

Cr-Commit-Position: refs/heads/master@{#311551}

Only license requests should not specify |legacy_destination_url|.

BUG=448242

Review URL: https://codereview.chromium.org/804713003

Cr-Commit-Position: refs/heads/master@{#311550}

Uses a RenderFrameHost instance to hold the reference to the respective
SiteInstance and its pre-spawned renderer process.

BUG=376094

Review URL: https://codereview.chromium.org/701953006

Cr-Commit-Position: refs/heads/master@{#311549}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/807183004

Cr-Commit-Position: refs/heads/master@{#311548}

Review URL: https://codereview.chromium.org/853643004

Cr-Commit-Position: refs/heads/master@{#311547}

This is a preparation for crbug.com/448190, where we're going
to allow Mojo MessagePipe being sent over Chrome IPC.

The plan is that we'll extend existing FileDescriptorSet to
carry both platform handles and Mojo's MessagePipes, then
let ChannelMojo take care of these handles.

As the first step, this change renames FileDescriptorSet to
MessageAttachmentSet and moves it out from the OS_POSIX guard.
Although this change doesn't do anything significant, we'll
generalize it to carry both platform files and mojo handles
eventually.

R=agl@chromium.org, viettrungluu@chromium.org
BUG=448190

Review URL: https://codereview.chromium.org/835873004

Cr-Commit-Position: refs/heads/master@{#311546}

Cause:
This is a regression of the HRD change, in which we pass in an unique
ID everytime when we create an app window.  This causes a new window
to be created whenever the user clicks on the app icon in the app
launcher.

Fix:
Only create a new app window when:
1. There are no existing windows or
2. The user clicks on the New Window context menu

BUG=448128

Review URL: https://codereview.chromium.org/844503007

Cr-Commit-Position: refs/heads/master@{#311545}

messages to enable componentizing printing. Basically, we have
modified two print messages
PrintHostMsg_AllocateTempFileForPrinting
PrintHostMsg_TempFileForPrintingWritten

to a routed message rather then a control message to simplify
implementation. However, this prevents moving the code to components.

BUG=446509

Review URL: https://codereview.chromium.org/854513002

Cr-Commit-Position: refs/heads/master@{#311544}

Extension background page is only allowed for the incognito profile
on sign-in screen, so in order to run the app on sign-in, the app
must be run in split incognito mode.

To avoid having two background pages per user (for original and otr
profile) in regular user session, set split incognito mode only for the
app running on signin screen (by using different manifest than for a
regular session)

TEST=
1. Make sure easy sign-in works
2. Lock screen with an incognito window open.
   Verify that the screen can be unlocked using Smart Lock
BUG=448634,445048

Review URL: https://codereview.chromium.org/834233005

Cr-Commit-Position: refs/heads/master@{#311543}

- Fix defaultControl to return ok button for error screen;
- Add aria-live and aria-atomic to content div so that it is read out
  when the screen state is changed and all contents are updated;

BUG=413766
TEST=Test enable-debugging flow with ChromeVox and verify that title and message gets read on each step.

Review URL: https://codereview.chromium.org/788953005

Cr-Commit-Position: refs/heads/master@{#311542}

BUG=448025

Review URL: https://codereview.chromium.org/845993002

Cr-Commit-Position: refs/heads/master@{#311541}

BUG=448876
TEST=
TBR=mlamouri@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/831903008

Cr-Commit-Position: refs/heads/master@{#311540}

R=erikwright@chromium.org
BUG=412384

Review URL: https://codereview.chromium.org/846383003

Cr-Commit-Position: refs/heads/master@{#311539}

NormalSpdyTransactionHelper constructor is often (approximately 70 times) called
with a temporary BoundNetLog() argument.  Its log_ member currently takes
reference of that, which becomes dangling right after the constructor returns.

This is not an issue if there are no NetLog events, nor in the NetLog test which
creates a named CapturingBoundNetLog object that it keeps in scope.  The
dangling reference only became problematic in the HTTP11RequiredProxyRetry test,
and curiously enough, only for 64 bit Andoid builds.

This CL changes the NormalSpdyTransactionHelper.log_ member type from reference
to value to fix this issue.

BUG=447837

Review URL: https://codereview.chromium.org/852053002

Cr-Commit-Position: refs/heads/master@{#311538}

BUG=417532

Review URL: https://codereview.chromium.org/799323003

Cr-Commit-Position: refs/heads/master@{#311537}

BUG=446267

Review URL: https://codereview.chromium.org/840763003

Cr-Commit-Position: refs/heads/master@{#311536}

BUG=

Review URL: https://codereview.chromium.org/831453004

Cr-Commit-Position: refs/heads/master@{#311535}

test cases.

The multi profiles tests creates multiple profiles each in different user data
dirs and signs in each one separately. Then each profile performs sync related
operations and verifies results on the other sync'ed profile.

The CL also adds some helper functions to force a client to do a sync cycle.

Note: These tests are DISABLED and do not run on the normal bots.

BUG=431366

Review URL: https://codereview.chromium.org/772513004

Cr-Commit-Position: refs/heads/master@{#311534}

fyi and chromium_athena.json will be removed in separate CL

BUG=448472

Review URL: https://codereview.chromium.org/851743005

Cr-Commit-Position: refs/heads/master@{#311533}

This reverts commit a63c0394.

BUG=448829
R=knn@chromium.org

Review URL: https://codereview.chromium.org/841443005

Cr-Commit-Position: refs/heads/master@{#311532}

This cl updates the checker.py script in /third_party/closure_compiler to
add an option to process a set of JS files at once rather than one at a
time (the current default). It also adds a flag to enable additional compiler
checks (since Chromoting wants all checks enabled).

It also updates the Chromoting .gyp files to make use of the new compiler.

The remaining changes were motivated by the errors reported by the new
closure compiler.

BUG=

Review URL: https://codereview.chromium.org/803653004

Cr-Commit-Position: refs/heads/master@{#311531}

Test code that's used downstream needs to live in
chrome/test/android/javatests (which is included in the
chrome_java_test_support target), not chrome/android/javatests (which is
included only in the chrome_shell_test_apk target).

BUG=444675

Review URL: https://codereview.chromium.org/788163006

Cr-Commit-Position: refs/heads/master@{#311530}

Wikipedia now assigns a fallback classname to its 'tex' img nodes. ChromeVox, reading the className directly, needs to split the space delimited string.

BUG=448544
TEST=math now reads on wikipedia

Review URL: https://codereview.chromium.org/828373007

Cr-Commit-Position: refs/heads/master@{#311529}

Strict virtual annotation checks were enabled on Mac in r311365.

This gets toolkit_views for Mac on board.

BUG=417463

Review URL: https://codereview.chromium.org/850843003

Cr-Commit-Position: refs/heads/master@{#311528}

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/854643002

Cr-Commit-Position: refs/heads/master@{#311527}

BUG=421063,439661

Review URL: https://codereview.chromium.org/826083004

Cr-Commit-Position: refs/heads/master@{#311526}

BUG=447732
TEST=Manually inspect chrome:histograms.

Review URL: https://codereview.chromium.org/847223002

Cr-Commit-Position: refs/heads/master@{#311525}

Since map<Key, Value>::value_type is std::pair<const Key, Value>, we
need to ensure that we use this type to avoid an extra copy/temporary
creation. This patch does this by explicitly using value_type where
it is clear what the type is, and adding const to the key where it's not.

Review URL: https://codereview.chromium.org/853533002

Cr-Commit-Position: refs/heads/master@{#311524}

In r311421 a test was modified that called into
XkbKeyboardLayoutEngine::ParseLayoutName but this function was not exposed in
the header file. This change exposes this method in the header file and fixes
the build.

Original CL that introduced issue: https://codereview.chromium.org/848833002

BUG=None
TEST=Compile of events_unittests completes

Review URL: https://codereview.chromium.org/812613004

Cr-Commit-Position: refs/heads/master@{#311523}

Review URL: https://codereview.chromium.org/842113004

Cr-Commit-Position: refs/heads/master@{#311522}