GitLab

Per the linked bug, RenderTextMac is effectively dead.  While I was touching
render_text_unittest.cc anyway, I thought I'd help a little with the cleanup.

Bug: 131618
Change-Id: I679ce91e4eebc9984ff44b0a8e899f0c36910ee7
Reviewed-on: https://chromium-review.googlesource.com/c/1343106
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609946}

This might invoke V8, and V8 should not be executed on per-thread task
runners. This CL gives a per-frame task runner at binding.

Bug: 870606
Change-Id: Ib814c717e2805beca341a6ad1a10926b231c361f
Reviewed-on: https://chromium-review.googlesource.com/c/1343878Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609945}

BUG=607592
R=zmin@chromium.org

Change-Id: I1c1c346c39cfeed164e1a3a56513356a2a142a5e
Reviewed-on: https://chromium-review.googlesource.com/c/1337491Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609944}

Change-Id: I9e7274f3ac67f57f1d0c62eb9223f437e9b1da8b
Reviewed-on: https://chromium-review.googlesource.com/c/1340832
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609943}

This CL enables WebAssembly trap handlers on MacOS. In this CL we use
the default trap handler provided by V8.

Bug: chromium:906565

Change-Id: I2d007da1a86ca05010a0a7bf830586767f19a24d
Reviewed-on: https://chromium-review.googlesource.com/c/1290955
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609942}

This flag is no longer used in YUV draw quad and dc layer overlay. The first clean-up
of this flag in video frame metadata has been checked in. This CL will remove this
flag completely.

Bug:1340270



Change-Id: Id5816ca0aaf4dc99f22988c4eba4ff5818a94678
Reviewed-on: https://chromium-review.googlesource.com/c/1340270
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609941}

In jumbo build experiments, files get merged and variables and
functions with the same name may end up in the same namespace/scope
and conflict. This happens for g_singleton in :
bluetooth_adapter_factory.cc
bluetooth_adapter_factory_wrapper.cc

[1] https://chromium.googlesource.com/chromium/src/+/lkgr/docs/jumbo.md

Bug: 887254
Change-Id: I97ff48a6aae71be0b935db1f7623da7ef65bac97
Reviewed-on: https://chromium-review.googlesource.com/c/1325109Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#609940}

This CL has no behavior changes.

Change-Id: I11622b7dd02221b7a449a784284595a7edbab5c3
Reviewed-on: https://chromium-review.googlesource.com/c/1345691Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609939}

Bug: 875402
Change-Id: I1404711a00a26ce65eae614fc4f027ddf240b136
Reviewed-on: https://chromium-review.googlesource.com/c/1345680Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609938}

Change-Id: If33a6bd0bd57a5c9313402a1b78b3f2d815f73e4
Reviewed-on: https://chromium-review.googlesource.com/c/1345681Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609937}

V4L2VEA wrongly calls V4L2Device::V4L2PixFmtToVideoPixelFormat to
VideoPixelFormat in VideoFrameLayout::Create. Just pass the VideoPixelFormat
without calling.

BUG=chromium:907132
TEST=VEA unittest on peach_pit

Change-Id: I3800cc81403a19e7521f724f972f63e937f0873b
Reviewed-on: https://chromium-review.googlesource.com/c/1345700Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609936}

1. Add method for finding forms on the page and replace the old delegate
   approach.
2. Add delegate method to be fired whenever new form related elements
   are inserted into the page.

Bug: 905546
Change-Id: I6b46bf396f8b34be71ef664a16840dddb5ace86a
Reviewed-on: https://chromium-review.googlesource.com/c/1345810
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609935}

We need to wait until |camera_info_| is updated in
OnGotCameraInfoOnIpcThread() before we fire ProcessDevicesChanged() to
prevent the race condition.

To easily reproduce the race without this CL, add
--disable-features=MojoVideoCapture as the command line argument of
Chrome.

BUG=b:118418068,b:118408452,b:64996728,b:77833131
TEST=10.times do
       Plug the external camera
       Check the external camera is shown in settings
       Unplug the extencal camera
       Check the external camera is not shown in settings
     end

Change-Id: I3774c456099724f2bb5ac2d21caf3229d0045a4e
Reviewed-on: https://chromium-review.googlesource.com/c/1345677Reviewed-by: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609934}

R=dgozman

Change-Id: Ieef8860b2ee7e65f013e4a01144b7812f3cf5af9
Reviewed-on: https://chromium-review.googlesource.com/c/1345534Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609933}

ClientPaintCache::Purge was not modifying the map that it was generating
PurgeData from.  This meant that to generate a budget to remove, it
would loop over the same element repeatedly and generate a large list
of the same item to purge.  (This is why this is intermintent and hard
to repro.)  However, it would then inform the service that this one
entry was removed, but the client would still think it was there.
If anything used it at that point, the client would assume it was
cached, but the service would fail because it would not be cached.

Bug: 906510
Change-Id: I71bf22833649875ea2486f5e8518b897f354b6c1
Reviewed-on: https://chromium-review.googlesource.com/c/1345418Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609932}

A checkerboard background was introduced to help see transparent
PNG images when using quick view in the FilesApp. If the image
being decompressed is large, the checkerboard is visible until
the image finishes decoding causing display flicker. This
change detaches the image node from the tree and uses the
decode() method on the image element to decode in the
background and then reattach when ready, eliminating the
flicker.

      and on real device.

Bug: 645021
Test: ran all browser tests, verified manually on workstation
Change-Id: Icd3dbdfb65015649acd539471ebe42cb8cf9a98e
Reviewed-on: https://chromium-review.googlesource.com/c/1345378Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609931}

It is invalid for a WebIDL dictionary member that resolves to a nullable
type to be marked with '?'. This change is effectively a no-op because
these fields remain nullable.

This patch implements the changes to the specification in:
https://github.com/w3c/deviceorientation/pull/55

Change-Id: I43222ec37ec216f8cb2932aedbddfb307ec4374f
Reviewed-on: https://chromium-review.googlesource.com/c/1239722
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609930}

For the Intra only frames in profile0, we assign the default
color_space :BT_601 as per the spec. But there are lazily encoded
streams with UNKNOWN color space information in non-intra-only frames
and that will cause enum comparison mismatch for the current frame header
with the frame in the reference list. So we relax the requirement
a bit to cover more streams similar to the other media stacks like
libvpx, gstreamer etc

BUG=889768
R=dalecurtis@chromium.org, hiroh@chromium.org

Change-Id: I5c343d03a941a3aa1447d4f0d3cd4979b92c4adb
Reviewed-on: https://chromium-review.googlesource.com/c/1342776Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609929}

Move this enum into its namespace file (extern import_history): avoids
mistakes in our FilesApp BUILD file where developer forgot to add both
these dependent extern files.

These externs are used to closure compile parts of Files app including
our JS unittests (this change is covered by two unittests for example)
so they are useful (see bug).

No change in test behavior, no new tests.

Bug: 905934
Change-Id: I126d8486425fa16098eb16d52376a1622e656d14
Reviewed-on: https://chromium-review.googlesource.com/c/1345697
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609928}

Adds repaint stories for 10 top desktop sites.  Stories use snapshots
made with 'snap-it', to reduce potential noise from page script.

Local run-time on Linux: 4m9s

BUG=906757

Change-Id: Ic08be0509f7cf66008ede33e2e26525856c58c9d
Reviewed-on: https://chromium-review.googlesource.com/c/1343079
Commit-Queue: Victor Miura <vmiura@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609927}

BUG=826982

Change-Id: I93e8b96ac058bc4c6d76cbd0af417727a0680b27
Reviewed-on: https://chromium-review.googlesource.com/c/1335071Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609926}

This option was added recently without any tests. This change adds a
simple test for this.

Bug: 902937
Change-Id: If35b91e8c43db434921a0a6b01beb708957aecb3
Reviewed-on: https://chromium-review.googlesource.com/c/1343813
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609925}

Previously the mask was applied only to the first PIP window. This CL
fixes this bug.

Bug: 902637
Test: Tested manually with the steps on the issue
Test: Added test passes

Change-Id: I4f86fa1713a861243ab3c87d051ff491f7b6bd32
Reviewed-on: https://chromium-review.googlesource.com/c/1322188Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609924}

For example, when viewing Downloads, the title in English would be
"Files - Downloads".

Bug: 762691
Change-Id: Icb9047da7f5e635db2c845d15e98a3165286689f
Reviewed-on: https://chromium-review.googlesource.com/c/1345712
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609923}

This constant was only set to false on OS_FUCHSIA and has been
shipping as true for several years on all other platforms.

Cleans up the code to not need this constant in most places and
adds a OS_FUCHSIA ifdef around InstantiateFieldTrialAllocatorIfNeeded()
which is the only place that needed custom logic to disable it for
Fuchsia.

Bug: 867558
Change-Id: Idbf49ce571a50d67debeafe2cdacee086ebca537
Reviewed-on: https://chromium-review.googlesource.com/c/1343020
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609922}

with repetitive names. The correct form should get filled.

Problem:
1. When an element would go invalid, we would use the section of
elements as one of the hints to find the new version of the old
element in the refill, but only the section of the autofilled fields
were passed. This would break the refills when the visibility of a
field changes. => Set and pass section of all fields.
2. In finding the new version of the old element, the case with more
than two elements with the matching names were not considered.
3. There was a bug in the logic for the nameless forms.

Fixes: https://jsfiddle.net/parastoog/tnh8j9ws/, ~/ds5h7kg4/,
~/w81yc6La/

Bug: 900185
Change-Id: I26fda7a50b3beb7f7c484a697633ab3b7b5a76d8
Reviewed-on: https://chromium-review.googlesource.com/c/1336492
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609921}

Add Http2MockLog and macros in net/third_party/http2/platform.
Remove small divergences from internal code.
Add HpackEntryTypeTest.OutputHpackEntryType test.

This lands server side change 221917881 by bnc.

Bug: 488484

Change-Id: I936519be0dff2bbee4a49f3b0af9e8ee699d2831
Reviewed-on: https://chromium-review.googlesource.com/c/1341199
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Reviewed-by: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609920}

If the right click context menu has not been displayed at least once
then some commands are not available in the file select menu.

If the use is clicking through files, we will assume that the menu
context should be FILE_LIST temporarily so that the correct options
appear in the file selection menu.

Added integration test to validate.

Bug: 875466
Change-Id: Idc79f1c25690b6c8bb7f585e0c9261ea4bec3996
Reviewed-on: https://chromium-review.googlesource.com/c/1343812
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609919}

This CL adds a UI egtest that tests that the tools menu dismisses
automatically when the device is rotated.

Change-Id: I23bbca383f83b3ea549be9ba9a5542c2d4f92d29
Reviewed-on: https://chromium-review.googlesource.com/c/1343571
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609918}

Bug: 802219
Change-Id: Id442745aebf4f71e0f4fa60510bea8b70a28d2d2
Reviewed-on: https://chromium-review.googlesource.com/c/1345713Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609917}

This comment was added in http://crrev.com/335223003; however, it's no
longer applicable as of http://crrev.com/1928863002. The FeatureList
initialization occurs before RendererMain is reached.

Change-Id: I6a0609de03aa1c69319021adf0ccea9d76bac2cf
Reviewed-on: https://chromium-review.googlesource.com/c/1343253
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609916}

R=hansberry@chromium.org

Bug: 903991
Test: none
Change-Id: Ibadb61a2bd30653b1e09629e73c0b07092259f8a
Reviewed-on: https://chromium-review.googlesource.com/c/1345656Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609915}

Follow up to r1341437. We should not remove the flag, but always set
it to true instead.

Once the flag has been removed from the extension code, we can remove
these flags in chromium too.

TBR=stevenjb@chromium.org

Bug: 856195
Change-Id: I396910c98289b1634123a16074e7f6c980baf1f1
Reviewed-on: https://chromium-review.googlesource.com/c/1345710Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609914}

This has two side effects:
* We no longer need to check that a navigation is in the main frame,
  but I did leave a DCHECK there anyways.
* The temp hack for ORIGINAL_REQUEST_URL is removed.

Bug: 898557, 864646
Change-Id: Ib767fd0b2e8d7675cf1b6e5ae7a4eec282378680
Reviewed-on: https://chromium-review.googlesource.com/c/1344551Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609913}

Update README for iWebApkApi.java inside runtime_library to include a final "git cl format" command.

The reason for this CL is that, in certain scenarios where the aidl has to be updated to handle more complicated parameters (such as list of ParcelFileDescriptors), then it won't actually work until I run a git cl format to fix the iWebApkApi java file.

Change-Id: I1bb184b4edaa576a4b23994cf5018262f0b0ebd5
Reviewed-on: https://chromium-review.googlesource.com/c/1344211
Commit-Queue: Ethan Xu <xuethan@google.com>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609912}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: Ia70ab8d6553e967a3c318124b5db9a16be6e5d0b
Reviewed-on: https://chromium-review.googlesource.com/c/1344940Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609911}

Bug: 825779
Change-Id: I19fb082887c3383ba6e5d4db43cc20bfab7c999c
Reviewed-on: https://chromium-review.googlesource.com/c/1345376Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609910}

Following bot results are included.
11941 11946 11952 11955 11962 11964 11966 11972 11979 11984
11988 11991 11995 12003 12006

0 lines were removed and 2 lines were deflaked by consecutive
results since 11955.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Change-Id: I0c6a705f9f50f460f1ac1973819cd3885b7dedf6
Reviewed-on: https://chromium-review.googlesource.com/c/1341740
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609909}

Chromium Build Sheriffing.

TBR=yusufo@chromium.org

Bug: 906831
Change-Id: Iaa9db6b2cd31ece2c0a84159418ced80d65557cb
Reviewed-on: https://chromium-review.googlesource.com/c/1344610Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609908}

Change the test helper function openAndWaitForClosingDialog to wait for
isFileManagerLoaded instead of waiting for the default entry set as a
way to determine if the Files app has finished loading.

Enable some FileDialog tests to run with flag MyFilesVolume enabled.

Test: --gtest_filter="FileDialog/FilesAppBrowserTest.*"
Bug: 873539
Change-Id: I26177fcbe32bdd285c8067ccf85f1f8fa329502f
Reviewed-on: https://chromium-review.googlesource.com/c/1345380Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609907}