- 24 Jul, 2018 40 commits
-
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2edae10bfbfe..d7a1188a3b5a git log 2edae10bfbfe..d7a1188a3b5a --date=short --no-merges --format='%ad %ae %s' 2018-07-24 dtu@chromium.org [pinpoint] Remove suffix from results2 tasks. Created with: gclient setdep -r src/third_party/catapult@d7a1188a3b5a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7e7343442cf33f424afb29810fdc82b24e05844d Reviewed-on: https://chromium-review.googlesource.com/1147941Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577452}
-
Yuichiro Hanada authored
This reverts commit ce0157f4. Reason for revert: This change breaks text input on ARC windows. Bug: 866784 Original change's description: > Cleanup IsArcAppWindow() in ArcWindowDelegateImpl. > > Now aura::client::kAppType property is set for an ARC notification > window. We can use it for check. > > Change-Id: Id27f5ab83492a4c1a517b1350ae1fc30bfbf8fae > Reviewed-on: https://chromium-review.googlesource.com/1146626 > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577422} TBR=yusukes@chromium.org,yhanada@chromium.org Change-Id: I9a58768a0ae0d84d13d9943674ed60954a9b39d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1148120Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#577451}
-
Orsi Batiz authored
Function String GetString(StringOrTrustedHTML, const Document*, ExceptionState&) has been added to trusted_html.cc All other callsites (setInnerHTML, setOuterHTML, setAttribute in element.cc, parseFromString in dom_parser.cc and createContextualFragment in range.cc, setInnerHTML in shadow_root.cc) have been updated to call this function Bug: 739170 Change-Id: Ie84462cd233669e55f2b76e685d5d3545198ee59 Reviewed-on: https://chromium-review.googlesource.com/1142768 Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#577450}
-
Orsi Batiz authored
Function String GetString(USVStringOrTrustedURL, const Document*, ExceptionState&) has been added to trusted_url.cc All other callsites (setAttribute in element.cc, open in local_dom_window.cc, assign, replace and setHref in location.cc) have been updated to call this function setHref in html_base_element.cc has been changed to call a different setAttribute from element.cc (the one mentioned above), this way there was no need to call GetString in there as well Bug: 739170 Change-Id: I07b9fee53ea62aa706bb59814f147a394f214549 Reviewed-on: https://chromium-review.googlesource.com/1144927 Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#577449}
-
Gauthier Ambard authored
This CL adds an InProduct help to indicate to the user that it is possible to long press on the toolbar buttons to have menus with new options. This in product help should only be displayed after the user opened a new tab. It should also be displayed after having the InProductHelp for the bottom toolbar displayed few days ago. This condition is handled server side. Bug: 849621 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I440cfe7cbf0b230454b1d2615e62d33d73c60b88 Reviewed-on: https://chromium-review.googlesource.com/1138243 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#577448}
-
Matt Falkenhagen authored
The ServiceWorkerNavigationPreload feature flag was removed in r494256. Bug: 753230 Change-Id: Ie2fe09c477dbffe1bc19cc050f1e6f413b1a8358 Reviewed-on: https://chromium-review.googlesource.com/1148021Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577447}
-
Hajime Hoshi authored
This function is not used anywhere. Change-Id: I4116ef0634a1db7b1aacfc5326e662ce3abfe136 Reviewed-on: https://chromium-review.googlesource.com/1144816Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577446}
-
Alan Cutter authored
This CL: - Renames FrameHeaderOriginText to HostedAppOriginText as it's not intended to be used for anything other than hosted app windows and for consistency with other HostedApp* views. - Moves HostedAppOriginText from ash/frame to chrome/browser/ui/views/frame. - Moves the animation timing logic from BrowserNonClientFrameViewAsh into HostedAppButtonContainer. This is in preparation to add the origin text animation to GlassBrowserFrameView (see https://chromium-review.googlesource.com/c/chromium/src/+/1136270). There are no behavioural changes in this CL. Bug: 854479 Change-Id: I69934e5b4595356d10e707011a231f9c095338db Reviewed-on: https://chromium-review.googlesource.com/1134713 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#577445}
-
Colin Blundell authored
The AccountTracker unittest currently plays fast-and-loose with the notion of an "account ID", which can be either the Gaia ID or the email address for a given account depending on the platform. This is a blocker to porting AccountTracker to use IdentityManager, as the IdentityManager test infrastructure deliberately makes a much more explicit and enforced separation between email address, Gaia ID, and account ID, reflecting how these elements are used in production. In particular: - Adding an account takes in the gaia ID and email and returns an account ID. - Calls that interact with the token service take in the account ID. This CL paves the way for that porting by changing the AccountTracker unittest to be explicit about its usage of the email address, Gaia ID, and account ID of a given account. The test now adds accounts by passing the gaia ID/email, obtains the account IDs of the added accounts, and interacts with the token service via those account IDs. Bug: 809923 Change-Id: Ia0bf7fc90c035976f8c578563e7d81c597d4d635 Reviewed-on: https://chromium-review.googlesource.com/1138082 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#577444}
-
Yutaka Hirano authored
...instead of mojom::CORSError. Currently they return a mojom::CORSError and callers need to compose a CORSErrorStatus from it. That requires callers to know which specific errors are returned from the function, which is not good. Bug: 736308 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5b0dfaf5b906e0203c9a72ebaef759a8fafa4ad3 Reviewed-on: https://chromium-review.googlesource.com/1147681Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#577443}
-
Zhongyi Shi authored
Bug: 790547 Change-Id: I68d3afb4a8bce843eee9e3b5456ed3103c7d2914 Reviewed-on: https://chromium-review.googlesource.com/1147545Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577442}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5389d34c833d..b96253cab7d9 git log 5389d34c833d..b96253cab7d9 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 ahassani@chromium.org cros_payload: deprecate it Created with: gclient setdep -r src/third_party/chromite@b96253cab7d9 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4e22d4c869c617f04eeefdf80b55f0769991eccc Reviewed-on: https://chromium-review.googlesource.com/1147940Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577441}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I42560e53d8cb727e6ae59e4dc7f698a470c26cea Reviewed-on: https://chromium-review.googlesource.com/1147930Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577440}
-
Hajime Hoshi authored
This reverts commit 47a44d77. Reason for revert: Test failures on some bots https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2064 ../../chrome/chrome_cleaner/os/disk_util_unittest.cc(892): error: Value of: HasZoneIdentifier(target_exe_path) Actual: false Expected: true Stack trace: Backtrace: StackTraceGetter::CurrentStackTrace [0x00007FF663FC6FE0+80] testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF663FE254A+90] testing::internal::AssertHelper::operator= [0x00007FF663FE204A+90] chrome_cleaner::DiskUtilTests_ZoneIdentifierWhenProcessIsRunning_Test::TestBody [0x00007FF663EECF4C+2924] ../../chrome/chrome_cleaner/os/disk_util_unittest.cc(897): error: Value of: base::ReadFileToString(stream_path, &content) Actual: false Expected: true Original change's description: > chrome_cleaner/os unit tests, part 1: a-f > > Also add test_util add extra setup that uses it to the test harness/ > > Bug: 830892 > Change-Id: Iae1bb4323f6a0b25339d13e702135c2a3625c99d > Reviewed-on: https://chromium-review.googlesource.com/1141146 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Chris Sharp <csharp@chromium.org> > Reviewed-by: Penny MacNeil <pennymac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577240} TBR=csharp@chromium.org,pennymac@chromium.org,joenotcharles@chromium.org Change-Id: Icf4ceab27056789e7aeb20f7c979aa9a3e52f3f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830892 Reviewed-on: https://chromium-review.googlesource.com/1147961Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577439}
-
Luciano Pacheco authored
Fix issues where Files app failed to mount .zip files, and also failed to zip files in M69 dev. Cause was on the Zip Archiver extension failing to load its own JS files due the manifest Content Security Policy (CSP) changes submitted in issue 836412. Bug: 864256, 865197, 836412 Change-Id: I8ffd382671deac0a23dfa5688830d9608a919bf5 Reviewed-on: https://chromium-review.googlesource.com/1147893Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#577438}
-
Kenichi Ishibashi authored
This CL adds three tests which basically correspond to ServiceWorkerContextRequestHandlerTest.ErrorCases. Bug: 860361 Change-Id: I57bca1d4ad53ffa53e45fd6b3e340d678133a856 Reviewed-on: https://chromium-review.googlesource.com/1146539Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577437}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4206a0a8498a..dcff0bd78e26 git log 4206a0a8498a..dcff0bd78e26 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 buildbot@webrtc.org Roll chromium_revision 0aff707f..bc855194 (577150:577382) 2018-07-23 steveanton@webrtc.org Add CreateIceCandidate overload which takes a cricket::Candidate Created with: gclient setdep -r src/third_party/webrtc@dcff0bd78e26 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2e5bc6c6e1e2915692ee15556b8c18a18b541e38 Reviewed-on: https://chromium-review.googlesource.com/1147901Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577436}
-
Matt Falkenhagen authored
Since issue 864731 was fixed in r576288, this workaround is no longer needed. Bug: 854993 Change-Id: I789dfb18cdb82ec51aa0ce5185586163c92269ec Reviewed-on: https://chromium-review.googlesource.com/1147889Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577435}
-
Hiroki Nakagawa authored
This is a follow-up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1146134 Bug: 825740 Change-Id: I401fb219d074546fcc13a49f50aab4a37e485010 Reviewed-on: https://chromium-review.googlesource.com/1147880Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#577434}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6a1002b4d937..2edae10bfbfe git log 6a1002b4d937..2edae10bfbfe --date=short --no-merges --format='%ad %ae %s' 2018-07-23 simonhatch@chromium.org Dashboard - Add new mojo linux name Created with: gclient setdep -r src/third_party/catapult@2edae10bfbfe The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863995 TBR=sullivan@chromium.org Change-Id: Id43b4f146c27fedc610a0feb59ba418aa708ec68 Reviewed-on: https://chromium-review.googlesource.com/1147722Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577433}
-
Kunihiko Sakamoto authored
Bug: 803774 Change-Id: Ic0d8445643d3a0639ce9b4527675be50d1f4b1af Reviewed-on: https://chromium-review.googlesource.com/1147886 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#577432}
-
Philip Rogers authored
This patch makes link highlights draw using foreign layers. To achieve this, link highlights have been more tightly integrated into the blink lifecycle. There are five big changes: 1) With BlinkGenPropertyTrees, link highlights paint above all other content and without inherited effects. This will be better UX, and it resolves an issue where link highlight painting could change painting in a subtle way. 2) Link highlight animations require an effect paint property node so a new effect node is now created/updated on LayoutObjects that have link highlights. When link highlights are added or removed, we now mark the associated layout object as needing a paint property update. 3) LinkHighlights::UpdateGeometry has been moved from WebViewImpl::UpdateLifecycle to LocalFrameView::PaintTree. This ensures link highlight layers are created/updated before the drawable layers are collected. 4) CollectLinkHighlightLayersForLayerListRecursively now collects link highlight layers, associates them with the link highlight effect node, and creates foreign layers for them. Because there can be multiple highlights, LinkHighlight has been made a DisplayItemClient to ensure the foreign layer ids are unique. 5) LinkHighlightImplTest has been parameterized to run with and without BlinkGenPropertyTrees which required some refactoring to ensure the test teardown occurred while the BlinkGenPropertyTrees setting was in scope. This change does not remove the GraphicsLayer dependency of the link highlight implementation, which will be required for SPV2, but it moves the implementation much closer to a SPV2-compatible design. BUG=857501 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8ed54a56b4cb23ae581e8a848db921baf09afcce Reviewed-on: https://chromium-review.googlesource.com/1125295Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577431}
-
Matt Falkenhagen authored
Remove the instrumentation from issue 854993 (and duped issue 838410) as it is now fixed. This is mostly a straight revert of the CLs, but it retains some checks as DCHECKs and other improvements like adding constness. Bug: 866769, 854993 Change-Id: Id617e06e85e2b947258ba5f80c1d7aa0396888af Reviewed-on: https://chromium-review.googlesource.com/1147888Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577430}
-
Luis Hector Chavez authored
This change adds Interface.Manager.buildThreadSafeProxy(), which is roughly analogous to mojo::ThreadSafeInterfacePtr<T>. Given that Java does not have move-only semantics, the Proxy object that is passed is unbound and a new object is returned. Bug: 810084 Test: cheets_ContainerSmokeTest in Chrome OS Change-Id: I6565f9e526e3fa8f8cb222cb8cd11e95bb57f7d3 Reviewed-on: https://chromium-review.googlesource.com/1147320Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#577429}
-
Yutaka Hirano authored
OriginRestriction has three values: - kUseDefaultOriginRestrictionForType - kRestrictToSameOrigin - kNoOriginRestriction kRestrictToSameOrigin is equivalent to "same-origin" request mode. kUseDefaultOriginRestrictionForType works as kRestrictToSameOrigin for certain resource types. kNoOriginRestriction works completely differently, it bypasses a CanDisplay check in BaseFetchContext::CanRequest. This CL replaces kRestrictToSameOrigin with "same-origin" request mode, kUseDefaultOriginRestrictionForType with "same-origin" request mode for the corresponding resource types. This CL also replaces kNoOriginRestriction with SecurityOrigin::GrantUniversalAccess because the CL which introduced the value[1] seems to want to bypass checks for requests with has_universal_access_ in PepperURLLoaderHost. 1: https://codereview.chromium.org/344883006 Bug: 736308 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0fb39b9f59aa6fd3c25244516e735b72a7183593 Reviewed-on: https://chromium-review.googlesource.com/1143669Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#577428}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f0bf9a40..0f6c4505 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I90a39b6b0f08ac4870cb3c58550a5459069d983c Reviewed-on: https://chromium-review.googlesource.com/1147864Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577427}
-
Maksim Sisov authored
Just creating an OWNERS file in the ozone/wayland and adding myself and Antonio as owners. Change-Id: I684e74b6ff2c8ec000a2b0f1fe98d6843d9cea46 Reviewed-on: https://chromium-review.googlesource.com/1146931Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#577426}
-
Sam McNally authored
Drive syncing can be paused when on a cellular connection. Monitor the pref backing this option and the network connectivity type, and use it to toggle DriveFS syncing. Bug: 854155 Change-Id: I0e6602b4055f5bf8926728933b84c78fa2fa19d2 Reviewed-on: https://chromium-review.googlesource.com/1147801Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#577425}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a76af0ca2e8c..4206a0a8498a git log a76af0ca2e8c..4206a0a8498a --date=short --no-merges --format='%ad %ae %s' 2018-07-23 ouj@fb.com Exposing video bitrate allocator into API 2018-07-23 steveanton@webrtc.org Change DtlsTransport to use a ThreadChecker 2018-07-23 steveanton@webrtc.org Cleanup networkroute.h 2018-07-23 steveanton@webrtc.org Step 1: Add RemoveTrackNew which returns an RTCError Created with: gclient setdep -r src/third_party/webrtc@4206a0a8498a The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3ccbf37df904212e5f20a6c30cbc6233738ed649 Reviewed-on: https://chromium-review.googlesource.com/1147900Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577424}
-
Victor Costan authored
This CL includes the following inter-dependent changes. 1) Use SQLITE_DEFAULT_LOOKASIDE instead of a sqlite_db_config() call. 2) Use SQLITE_OMIT_COMPILEOPTION_DIAGS. This is needed to avoid a compilation error after the previous change. 3) Rework the way Chome-specific defines are injected into the SQLite amalgamation. This is needed to get the code linking after the previous change, and is explained in detail below. 4) Replace Chromium -> Chrome in SQLite's BUILD.gn file. While the project's name is Chromium, the codebase refers to the resulting product as Chrome. This is not strongly related to the above, but is bundled to avoid merge conflicts. Chrome's SQLite version is first generated using the standard amalgamation process [1]. Then we inject a set of macros [2] adding a prefix to every symbol exported by SQLite. This is currently done by taking advantage of the fact that a standard build of SQLite #includes a "config.h" header if the _HAVE_SQLITE_CONFIG_H macro is defined. Our current approach relies on the fact that the amalgamation generation script simply happens to list ctime.c as the first file in the amalgamation [3]. When the file's content is ignored by defining the SQLITE_OMIT_COMPILEOPTION_DIAGS macro, the assumption does not hold anymore. This CL replaces the _HAVE_SQLITE_CONFIG_H macro with an approach guaranteed to surive changes in SQLite's amalgamation process. Instead of building amalgamation/sqlite3.c directly, this CL introduces a sqlite3_shim.c which sets up the Chrome-specific compilation environment, including our rename macros, and then #includes amalgamation/sqlite3.c. [1] https://www.sqlite.org/amalgamation.html [2] https://cs.chromium.org/chromium/src/third_party/sqlite/amalgamation/rename_exports.h [3] https://cs.chromium.org/chromium/src/third_party/sqlite/src/tool/mksqlite3c.tcl?q=ctime.c Change-Id: Ib4ccea5f9c025114e7d2ebf0305687ed21bf68b7 Reviewed-on: https://chromium-review.googlesource.com/1146155 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#577423}
-
Yuichiro Hanada authored
Now aura::client::kAppType property is set for an ARC notification window. We can use it for check. Change-Id: Id27f5ab83492a4c1a517b1350ae1fc30bfbf8fae Reviewed-on: https://chromium-review.googlesource.com/1146626 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#577422}
-
Zhongyi Shi authored
Bug: 790547 Change-Id: Icb1fd8643db0b344b41fc5a31340d44be0d0be2a Reviewed-on: https://chromium-review.googlesource.com/1145786Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577421}
-
Ryan Hamilton authored
TBR=asvitkine@chromium.org Bug: 862555 Change-Id: I87b37b6c2ebfd27d86e3116693dd71f18e608aaa Reviewed-on: https://chromium-review.googlesource.com/1147513Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577420}
-
Koji Ishii authored
Following bot results are included. 8184 8185 8186 8193 8195 8196 8197 8203 8207 8211 8217 8222 8232 8240 8253 8258 2 lines were removed and 4 lines were deflaked by consecutive results since 8195. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I043a191621b414909e17b48d34c6e1815ef28ef9 Reviewed-on: https://chromium-review.googlesource.com/1146121 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577419}
-
Luciano Pacheco authored
Re-enables the call to |notifyEntriesChanged| and refresh all required metadata which includes "share", "modificationTime" and "size" among others. The method |notifyEntriesChanged| invalidates all metadata, so we should update all required metadata fields. This fixes the issue where file list (RHS) wouldn't display modification time column, because sometimes when it would try to display the metadata had been invalidated due to the call to |notifyEntriesChanged|. |notifyEntriesChanged|, so the fact that they're all passing now it's the the actual test. Test: Several tests were failing when re-enabling Bug: 857343 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5a1e243c22c4040530c55d3d41708740dd617d88 Reviewed-on: https://chromium-review.googlesource.com/1117966Reviewed-by:
Daichi Hirono <hirono@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#577418}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I896d5cd0bdc2f76cc139717c2d8d4b625e46039c Reviewed-on: https://chromium-review.googlesource.com/1147710Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#577417}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b8eeb808d84f..903fb041a2f8 git log b8eeb808d84f..903fb041a2f8 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 94c91a95358b..522095f7d7fe (6 commits) Created with: gclient setdep -r src/third_party/skia@903fb041a2f8 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I920b1d59d2b324868922865cd9edfc6140146468 Reviewed-on: https://chromium-review.googlesource.com/1147721Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577416}
-
Sergey Ulanov authored
VideoCaptureSystemImpl expects to have non-null VideoCaptureDeviceFactory, but it was getting nullptr value on Fuchsia. As result the browser was crashing Bug: 866669 Change-Id: I73ec5c850acdc392a7984f62d9f66edb0961809a Reviewed-on: https://chromium-review.googlesource.com/1147514 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#577415}
-
Erik Luo authored
Screenshot: https://imgur.com/a/8u2tq05 Bug: 845449 Change-Id: Ibe8ca7b40133891cfe2701f90d26a2850b7d7497 Reviewed-on: https://chromium-review.googlesource.com/1077101Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577414}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1116ef0b1c45..c62aa207e9ac git log 1116ef0b1c45..c62aa207e9ac --date=short --no-merges --format='%ad %ae %s' 2018-07-23 tsepez@chromium.org Tighten up ThisProxy casts. Created with: gclient setdep -r src/third_party/pdfium@c62aa207e9ac The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I70086cea92cab118a977e75a9ee23e97e49730a8 Reviewed-on: https://chromium-review.googlesource.com/1147723Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577413}
-