GitLab

This is to enable developers to turn it off for testing what future
deprecation will look like.

Bug: 582750,1055010
Change-Id: I7ea0570ec6cda99ec8027219ba5f272d875b679c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124237
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755426}

`allocate()` with a hint is deprecated in C++17 and removed in C++20.
Note that while `allocate(size_t)` isn't provided prior to C++17,
`allocate(size_t, void* = nullptr)` is and will behave equivalently.

Bug: 752720
Fixed: 1065435
Change-Id: I27a7a22a752e8304988f44d9a2e330a6b2b97db5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131045Reviewed-by: Tiancong Wang <tcwang@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755425}

This change applies the BindOnceRewriter in //android_webview.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=changwan@chromium.org

Bug: 714018
Change-Id: Idb3efb3cb232b948d227c4bd238327e3556afae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132148
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755424}

This change applies the BindOnceRewriter in //chrome.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=avi@chromium.org

Bug: 714018
Change-Id: I448d5a70b2027b4bbcaa91543cb6a1bd66c211cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132369
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755423}

Bug: 1066560
Change-Id: Icb6ae8ffc1cd5e4c7884e1984b584aa1f301433d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130180
Commit-Queue: Rakesh Soma <rakeshsoma@google.com>
Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#755422}

Roll ChromeOS orderfile from 82-4085.6-1584957322-benchmark-82.0.4085.18-r1 to 83-4085.6-1584956258-benchmark-83.0.4091.0-r2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I5aacbe7cb136a728b817231ec9af1e64d5e383a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132580Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755421}

This reverts commit e6de1039.

Reason for revert: The crash was caused by a xml text failure. The original change also delete one of the test file unintentionally. A fix will be update as a patch set of this CL.

Original change's description:
> Revert "Move settings.homepage to homepage"
>
> This reverts commit e2054b9b.
>
> Reason for revert: this CL cause crashing. Tracked in crbug.com/1062959
>
> Original change's description:
> > Move settings.homepage to homepage
> >
> > Moving Homepage related settings code to homepage.settings package
> >
> > Change-Id: Iaf198f4a25cc03b32a1de997577d466916470437
> > Bug: 1052060
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095468
> > Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
> > Reviewed-by: Theresa  <twellington@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#751162}
>
> TBR=twellington@chromium.org,wychen@chromium.org,wenyufu@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1052060
> Change-Id: I97b75da16bf58834ba555242476b9e3f7bfd71be
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109816
> Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751748}

TBR=twellington@chromium.org,wychen@chromium.org,wenyufu@chromium.org

Bug: 1052060
Change-Id: I0f0a1200755471478feb6966b21211694dd9710e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125467Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755420}

A content::RenderView should always have a valid blink::WebView if it is
observable by non-content internal code.

Change-Id: I4afd471b5b46e16865c5b46d3bbdc23a06b7f95a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131246Reviewed-by: Sean Topping <seantopping@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755419}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7108574e87d0..0a34c98ea0b0

git log 7108574e87d0..0a34c98ea0b0 --date=short --first-parent --format='%ad %ae %s'
2020-04-01 surma@chromium.org Important changes to Whitespace

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@0a34c98ea0b0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I940dbb8c24267a41a9ec7d2af20efb82cd4106b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131689Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755418}

This property is required for iOS builders running on chromium recipe.
It was removed in crrev/c/2122472 by mistake.

Change-Id: I0c4cf69ba6605ab73562d3eb125084afde828a76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128567Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755417}

https://chromium.googlesource.com/angle/angle.git/+log/38df4ab61807..afd2cfa6c14d

git log 38df4ab61807..afd2cfa6c14d --date=short --first-parent --format='%ad %ae %s'
2020-04-01 ancheng.qiao@arm.com Add gles1 covgl tests

Created with:
  gclient setdep -r src/third_party/angle@afd2cfa6c14d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cwallez@google.com
Change-Id: I9f19cfa63b33d41257b9300a5037e494269d6a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132506Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755416}

Move feature_switch_unittest.cc to //extensions to neighbor its
source file (feature_switch.[h|cc]). It has no //chrome dependencies.

Bug: None
Change-Id: Ie98bdd50d973e168e5ab593047fd697deec53bf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131626Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755415}

I'm not ready to remove the instrumentation code yet, so this CL punts
the expiry of the SupervisedUsers.ExtensionsAllowlist UMA histogram to
M84. The SupervisedUserAllowlistExtensionInstall feature flag will
probably remain disabled throughout M83, so there likely won't be any
data recorded on this histogram during M83.

Bug: 1066071
Change-Id: I90d3a2d08e12d6cef514e00190fbf92773ca87e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131155Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755414}

This change applies the BindOnceRewriter in //chrome/browser/notifications.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=mukai@chromium.org

Bug: 714018
Change-Id: I88ad0171b45602b8467c2261e08bdf89701d6016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132256
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755413}

Move some of the logic in PasswordSaveUpdateWithAccountStoreViewTest to
a dedicated class so that it can be used by other bubble unit tests.

Change-Id: Ib1a1eb5f769ccfdf6abff8d8b31d374a8dd36438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129530
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755412}

Bug: 1059820
Change-Id: I197d3d53f3db4fded2b7578b0aae38027812ed91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132188
Commit-Queue: Monica Basta <msalama@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755411}

Using wpt-import in Chromium d53bf048.
With Chromium commits locally applied on WPT:
d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers"
2688e49a "De-flake two lazyload WPT tests."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
cbiesinger@chromium.org:
  external/wpt/css/css-flexbox
emilio@chromium.org:
  external/wpt/css/css-display
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
jfernandez@igalia.com:
  external/wpt/css/css-align
mstensho@chromium.org:
  external/wpt/css/css-multicol
panicker@chromium.org, tdresser@chromium.org:
  external/wpt/paint-timing
rego@igalia.com:
  external/wpt/css/css-grid
  external/wpt/css/css-ui
  external/wpt/css/selectors
xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com:
  external/wpt/css/geometry

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I0879e73878115144bc72fac1d302db687596390a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132028Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755410}

This converts the //device/vr:fakes static_library to a component. This
means that it can be included without needing to define
"DEVICE_VR_IMPLEMENTATION."

Change-Id: Ice6145301893c730109a4b7dd3432d2a366729a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131212
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755409}

This change applies the BindOnceRewriter in //chrome/browser/extensions.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Bug: 714018
Change-Id: I16a08028678bbfd28689c76fdea7e4baf570cc03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132390
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755408}

All of the experimental try builders mirror either dummy builders or
builders that are mirrored by other builders with the exception of
ci/fuchsia-x64-dbg which is only mirrored by
try/fuchsia-compile-x64-dbg.

Change-Id: I2b682d3ac41514ec7c134634de246c44b8fbfb24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128367Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755407}

This reverts commit 2a103d18.

Reason for revert: Will fix the flakiness in follow up patch sets.

Original change's description:
> Revert "Add MainSettingsFragmentTest"
>
> This reverts commit 8aee0918.
>
> Reason for revert: Test being added is flaky. See
> https://bugs.chromium.org/p/chromium/issues/detail?id=1066619
>
> Original change's description:
> > Add MainSettingsFragmentTest
> >
> > MainSettings.java have bit less test coverage over some of the
> > preferences, for example, the HomepageSettings at this moment. Adding
> > MainSettingsFragmentTest is aiming for more test coverage for the
> > list of preferences on the settings screen.
> >
> > Bug: 1052060, 1066362
> > Change-Id: Ib51c133f2a73f4ec85cc185c4101833bc3fa0b58
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124729
> > Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
> > Reviewed-by: Theresa  <twellington@chromium.org>
> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#754957}
>
> TBR=twellington@chromium.org,wychen@chromium.org,chouinard@chromium.org,wenyufu@chromium.org
>
> Change-Id: If15e22de962484fc87b3b5dc5eb1cfcf550cf024
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1052060, 1066362
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131017
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755115}

TBR=twellington@chromium.org,wychen@chromium.org,rbpotter@chromium.org,chouinard@chromium.org,wenyufu@chromium.org

Change-Id: I0404143a0d074621d2433a5329ff6db9d7f41d73
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1052060, 1066362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130774Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755406}

Setting ownership to
vakh for all safe browsing metrics.
jdorrie for all Password Manager metrics.

Bug:1050655

Change-Id: I21dd75bd707e048cdda50ed2cacdee24716aed2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128318
Commit-Queue: Vadym Doroshenko  <dvadym@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Auto-Submit: Vadym Doroshenko  <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755405}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71a7f0fe976c..85b8bc1b0e14


Created with:
  gclient setdep -r src-internal@85b8bc1b0e14

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1049638
Tbr: jbudorick@google.com
Change-Id: I04a3d979609a48453727276d373553f2dcc57be2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132507Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755404}

DownloadManagerTestCase is flaky on the bots with slow CPU but works
fine on the bot with fast CPU. So it is possible that flakiness is
related to test server performance.

Before this CL test server would produce a 50KB download file by yielding
blocks of 1 byte size. This CL updates the server to yield 1KB blocks
to improve performance, and introduces 100ms delay between yielding each
block to keep the download realistically slow.

Bug: 1066150, 914113
Change-Id: Ib3a35eb1e849e82dd47cda45b68261634813114e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130817
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755403}

This is essentially the same CL as crrev.com/c/2120454 and
crrev.com/c/2122861, but a follow-up CL accidentally deleted this logic,
so reinstate it.

Bug: 1061576
Change-Id: I4a916a27dcebd5825cccdfd6071dd644114cdfa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131020
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755402}

Password icon for the page action icon for passwords is seen inverted in
RTL mode. This CL prevented the mirroring of the icon. This is
consistent with the behavior of the password icon in the settings page.

Bug: 1066402
Change-Id: I9c2df6d46fd7b34745da62e170eca5b68a6b3c88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128310Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755401}

These were discovered when trying to roll testharness.js; missed in
earlier work because they didn't have an opening parenthesis after the
function name.

Bug: 1051932
Change-Id: I09b7a25b093636bfca58b4e1067a3a10ffcdc9b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132138Reviewed-by: Luke Z <lpz@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755400}

It's dead code. It had been there before the blink reformat.

Change-Id: Ibddd1f4994a5ec38a61e69fc19d9598b6dc2c01e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131527Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755399}

Add a check to only call the cookie controls service if the new state is
different from the previous state, because calling setChecked
programmatically triggers onCheckedChanged.

Bug: 1040091
Change-Id: I639a08cf47e365a3542c94b18ba680defca55b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132209Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755398}

This change applies the BindOnceRewriter in //chrome/browser/media.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=raymes@chromium.org, tommi@chromium.org

Bug: 714018
Change-Id: Ie7f42f27b2b92a1c0529a1e712ed627a4fe05803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132255
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755397}

Add calculation logic for maximum simultaneous load inside
BackgroundTabLoadingPolicy.

This will be used for restricting the number of background tabs
loading in a future CL.

Bug: 1059341
Change-Id: I7ecd751fafb202ffda09472a2121f72a02a22cb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120267
Commit-Queue: Hailey Wang <haileywang@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755396}

The geolocation permission was getting automatically denied on some test
runs. This should verify if it is because the prefs are getting
persisted across test runs.

Bug: 1064500
Change-Id: I385bb1326efa51c7885181a0f2557c8081bc313a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132669
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755395}

This change applies the BindOnceRewriter in //chrome/browser/chromeos/attestation.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=emaxx@chromium.org

Bug: 714018
Change-Id: Iebee9bd19db9cd252dffa538ea34ebb1d169df62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132253
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755394}

This is a core Sync health metric.

Bug: 1063924
Change-Id: Ie7b6c047bc6be518f41cf8ff5b8bfded202c2cc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131827
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755393}

Translation team flagged this string for having an erroneous period.

Bug: 1032584
Change-Id: Iedc92d023a6fe9e223c1be426daf4370122d1d43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131916Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755392}

This check was missing.

Bug: 522357
Change-Id: I6dfa88e07f30c0c6c3a4f09378c75554f3b3fc91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130988Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755391}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3459bf5bf9c9..eafb2c3665f7

git log 3459bf5bf9c9..eafb2c3665f7 --date=short --first-parent --format='%ad %ae %s'
2020-04-01 chrome-bot@chromium.org Update config settings by config-updater.
2020-03-31 chrome-bot@chromium.org Update config settings by config-updater.
2020-03-31 khmel@chromium.org arc: Support AndroidMetadata in union build
2020-03-31 saklein@chromium.org scripts: Remove -v short options for not verbose.
2020-03-31 dhanyaganesh@chromium.org report_stages: Add master_bb_id to metadata.json
2020-03-31 lamontjones@chromium.org Revert "Refactor to use service/artifacts for BuildAutotestTarballsForHWTest."
2020-03-31 chrome-bot@chromium.org Update config settings by config-updater.

Created with:
  gclient setdep -r src/third_party/chromite@eafb2c3665f7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I59c4b19633862ee596acf615548d0e1a4e4719af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131688Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755390}

This reverts commit 83dccf5d.

Reason for revert: this patch contains refactoring of client tag based
model type processor. To prevent too many changes in one release it is
better to reland this patch after M83 will be branched.

Original change's description:
> [Sync] Refactor model type processor: entity tracker lifetime
> 
> Make entity tracker's lifetime same as initial sync done. The tracker
> won't exist if we still have no data from the server.
> 
> In this patch also authentication_account_id is not set explicitly for
> metadata coming from ModelReadyToSync. The behavior for this field
> becomes similar to cache_guid. If authentication_account_id differs from
> activation request then the metadata will be reset. Generally it should
> not affect anything.
> 
> In the next patch unittests will be added.
> 
> Bug: 947044
> Change-Id: I34a75006d1f31888f8ca485a94538b6dd98923c1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038733
> Commit-Queue: Rushan Suleymanov <rushans@google.com>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#750920}

TBR=mastiz@chromium.org,rushans@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 947044
Change-Id: Icc0ae96eb2afa549024bf5b61efb799a6a92969c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130212Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#755389}

Change DisplayResourceProvider so that it records memory dumps when used
with SkiaRenderer. Also shared ownership edges were broken with shared
image backed resources, so update both GLRenderer and SkiaRenderer to
make a GUID based on mailbox. This might break shared ownership in
GLRenderer with things that aren't on shared image yet, but it fixes
shared ownership for everything that uses shared image.

Bug: 1058974
Change-Id: Iaaf981f28212cabe4d5e4535158afabaff2bd6af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131016Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755388}

Migrate this test out of third_party/blink/web_tests/css3/flexbox
and into the WPT-specific directory, adding links to the relevant
specs and a test assertion describing its purpose.

Bug: 1063749
Change-Id: I1644b62216c9ada36516027caf4f3166f5735fc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117913Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#755387}