- 29 Apr, 2019 40 commits
-
-
Gabriel Charette authored
TBR=fdoray@chromium.org Bug: 951388 Change-Id: Ib11e1538c7a8f02a705c166c00edfbd703ed79db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588438Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#654884}
-
Gabriel Charette authored
The tricky part is the need to yield to java before declaring idle. Previously this was done by only yielding to java if we did any work. With DoSomeWork() however we do not know if we did any work, we only know whether there's more work to come. As such we use a special bit to yield to java once and declare idle if no other work is scheduled in-between now and java invoking us again. Bug: 885371 Change-Id: Id9c8271cc216d06a2db7b9a95636fe87b285eb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1485130Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#654883}
-
Yao Xiao authored
Bug: 954976 Change-Id: Ida97131002fee400f12379607a7b277336f25058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572699 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#654882}
-
Raymond Toy authored
The existing implementation was confusing because it looked like it was modifying the filter coefficients of the running biquad filter. Change this so that the biquad kernel is passed that will be used to compute the response. This makes it clear that the filter coefficients aren't being modified. It's up to the caller to use the correct biquad kernel. Bug: 390266 Change-Id: Ib67afa9112dfa666875b40be3e7c582eef767e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582869 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#654881}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0a0741eb598..6d096f7ef0a0 Created with: gclient setdep -r src-internal@6d096f7ef0a0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: Iebc6c10f4cc5ef7c619694788f901d35b8f8bc17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588515Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654880}
-
Aleks Totic authored
MarkParentForOutOfFlowPositionedChange would skip chain invalidation if elements in chain were already invalidated. This change makes this occurrence less frequent. Additional minor optimization I can make because I understand MarkParentForOutOfFlowPositionedChange call sites: LayoutBox::StyleWillChange used to call MarkParentForOutOfFlowPositionedChange This is not necessary, because MarkParentForOutOfFlowPositionedChange is also called by LayoutObject::StyleDidChange. Legacy code fails the new test case. Cause of the failure is the same, insufficient invalidation. But the fix needs to be different, becasue Legacy does not call MarkParentForOutOfFlowPositionedChange. Tentative legacy fix is, but I think applying it is not worth the risk. --- a/third_party/blink/renderer/core/layout/layout_block_flow_line.cc +++ b/third_party/blink/renderer/core/layout/layout_block_flow_line.cc @@ -1978,6 +1978,7 @@ void LayoutBlockFlow::LayoutInlineChildren(bool relayout_children, if (o->IsOutOfFlowPositioned()) { o->ContainingBlock()->InsertPositionedObject(box); + o->MarkContainerChainForLayout(); Bug: 952644, 949615 Change-Id: Iaf7114660ae10cb9117b7a8b95e1e86c59d10dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578358 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#654879}
-
David Bokan authored
The spatial navigation algorithm attempts to prioritize targets fully contained within another target. However, the current implementation has a bug because it uses unclipped rects to determine containment. This CL fixes the issue by using MapToVisualRectInAncestorSpace which does account for clipping. Small cleanup: Remove the |ignore_border| option since it's always true. Bug: 957240 Change-Id: Id032bb9d354ec06d075b2de6bd53a8799f7a8af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586660Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#654878}
-
Koji Ishii authored
This patch unifies two loops into one when adding cached line boxes. Before this change, it needed to abort when floating or out- of-flow objects were found. By adding |HasPropagatedDescendants()|, the logic can break when line boxes that have such descendants. This avoids the needs of keeping the lines in a temporary vector. Bug: 636993 Change-Id: I321ecf31e96a4df35c8bf4ce6ade8276af4f4006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585742Reviewed-by:
-
Dale Curtis authored
This just converts utility functions to pass-by-value, const AudioBuffer&, or AudioBuffer* where applicable. BUG=946265 TEST=cq Change-Id: I67a2edc07944da45845587a0235753139da7d8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586552 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#654876}
-
Henrique Nakashima authored
These comments that say "BrowserContextKeyed_Base_Factory" are outdated and should refer to "BrowserContextKeyed_Service_Factory" instead. Bug: 937770 Change-Id: Ie810020033d7337481649b5b3c87bcc1d365eea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574420Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#654875}
-
David Bokan authored
The spatial navigation algorithm attempts to select an inner-most element when fully contained by using a hit test. However, hit testing descends into shadow DOM so in order for this comparison to work it must also descend through shadow roots. Bug: 957240 Change-Id: I5f8d62187548becfa5dc3ad95c255ba54bcdb7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586271Reviewed-by:
-
Maksim Moskvitin authored
It was used for the ClearServerData flow which has been removed. All the code removed by this CL was efficiently no-op, since saved_nigori_state was never set. Bug: 490836 Change-Id: Idcb658e229b983f006937e943baaf9aade5ac8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583735 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#654873}
-
Yiming Zhou authored
This cipd update fixes a number of autofill captured sites tests that were failing before: abercrombie barnes and noble cvs davidsbridal dell home_depot nba Most tests were failing because the test recipe has the wrong expection for phone number types. A few tests were failing because the recipe was missing a step that unchecks the 'billing addr same as shipping addr' checkbox. Bug: 847905 Change-Id: I0e73c762104d611b18e7da438c5dbaf6d2d31323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574426 Auto-Submit: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#654872}
-
Adithya Srinivasan authored
This reverts commit a3996e55. Reason for revert: This is causing GlobalErrorBubbleViewTest.Basic to fail in MSAN builds (example failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/12590) Original change's description: > Change BubbleDialogDelegateView RTL mirroring to happen when setting the arrow. > > Previously this was done during creation of the nonclient view. This created issues in cases where the arrow was explicitly reset to a value fitting for only LTR after nonclient view creation. > > Bug: 956001 > Change-Id: I2d71c3a97df1192337f7548ab1da733604526c3a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585930 > Commit-Queue: Caroline Rising <corising@chromium.org> > Reviewed-by: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#654625} TBR=dfried@chromium.org,corising@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 956001 Change-Id: Ib4367b996d9c4e3418e8463558912f641713a5fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588440Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#654871}
-
Daniele Castagna authored
This patch adds zcr_vsync_feedback_v1 support to wayland clients. It additionally adds a new CL flag "--log-vsync-timing-updates" to wayland_simple_client that can be used to print on the std output updates on vsync timing information. Test: build wayland_simple_client, scp to dut and run 'export XDG_RUNTIME_DIR=/var/run/chrome; ./wayland_simple_client --log-vsync-timing-updates' Change-Id: Idcb13cf2e4cc9357cf454de6a8416da3b089eab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580469Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#654870}
-
Amr Aboelkher authored
Bug: 552439 Change-Id: Icf1102bd8c7e6d8dc723c94ea02824d34767feb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581624 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#654869}
-
Dominik Röttsches authored
This is not shipping and the flag is no longer used. Change-Id: I7c3449db6e665c1e1a7148375914284f7b35a5e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572120 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Robert Phillips authored
As of the following CL, Skia no longer uses this #define https://skia-review.googlesource.com/c/skia/+/210630 (Enable opList sorting everywhere) Change-Id: I96e4958244e453ae63b0b84b7ceaf9822736afb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584823Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#654867}
-
Philip Rogers authored
cc::TransformNode::in_subtree_of_page_scale_layer is important for avoiding raster during pinch-zoom (see ideal_page_scale calculation in PictureLayerImpl::UpdateIdealScales) and was not being set at the blink->cc boundary when BlinkGenPropertyTrees was enabled. This patch adds in_subtree_of_page_scale to TransformPaintPropertyNode and sets it when building the VisualViewport property nodes. This is then used to update cc::TransformNode::in_subtree_of_page_scale_layer in PaintPropertyTreeManager. Bug: 951861 Change-Id: Ic3bd0f48fb3a383825503b04b4f42d7db51bd651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586996Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#654866}
-
chrome://discardsSigurdur Asgeirsson authored
This makes it easier to visually associate frames to their process. Also make the nodes slightly bigger and turn the stroke around them black for better contrast, as the colors are fairly muted. Change-Id: I80b9a817bbed852aa558fbfcacc6d28690f477b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586228 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#654865}
-
Adithya Srinivasan authored
Bug: 957584 Change-Id: I6b102ebff3ba6b36032e93cf43d82c39ad4e6710 Tbr: tbarzic@chromium.org, xiyuan@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588198Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dfd2f8c4fcb0..c50e142db744 git log dfd2f8c4fcb0..c50e142db744 --date=short --no-merges --format='%ad %ae %s' 2019-04-29 lalitm@google.com trace_processor: fix missing header 2019-04-29 fmayer@google.com Merge "Add some detailed docs for heapprofd." 2019-04-29 fmayer@google.com Merge "Warn about rejected concurrent sessions in trace_to_profile" 2019-04-29 ilkos@google.com Merge "Fix LMK process association" 2019-04-29 lalitm@google.com Merge "trace_processor: remove RawCursor and associated virtual function calls." Created with: gclient setdep -r src/third_party/perfetto@c50e142db744 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3b0a1c5e8d7ef40ee97fd10757452ee22d52044e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654863}
-
Ross McIlroy authored
This will update the Pixel2 bots to use the MonoChrome6432.aab which is a 64bit browser. In making this change a new 'exact_browser' option is added to tester_config in perf_data_generator to allow specifying a particular binary to be run rather than guessing. Reland of: https://chromium-review.googlesource.com/c/chromium/src/+/1511455 TBR=crouleau@chromium.org BUG=934251 Change-Id: I21bf7ae8e42f0e4c127748eeecc58a8af34334a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587563Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#654862}
-
Jan Wilken Dörrie authored
This change introduces a feature flag for the upcoming Touch To Fill feature on Android. Furthermore it rearranges the definitions of Password Manager flags so that they are sorted alphabetically and match the order of declaration in the header file. Bug: 957532 Change-Id: I69445c15231bffbdd2852ade004a0279c364fa79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587028Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#654861}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9286adcb0f7e..bbed4577964d git log 9286adcb0f7e..bbed4577964d --date=short --no-merges --format='%ad %ae %s' 2019-04-29 cwallez@chromium.org Texture: Add validation that the mip chain can't be too large Created with: gclient setdep -r src/third_party/dawn@bbed4577964d The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel BUG=chromium:954769 TBR=cwallez@chromium.org Change-Id: Ie307b4471d59976c6dfeb4c8f7d5d2fec98a1062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586992Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e670fd97951a..c0c7d36e80b4 git log e670fd97951a..c0c7d36e80b4 --date=short --no-merges --format='%ad %ae %s' 2019-04-29 alessiob@webrtc.org RNN VAD: clean-up unit tests 2019-04-29 henrika@webrtc.org Revert "Piping audio interruption metrics to API layer" 2019-04-29 danilchap@webrtc.org Remove deprecated AudioDeviceModule factory 2019-04-29 peah@webrtc.org Only create AECm when needed 2019-04-29 nisse@webrtc.org Delete unused StartAecDump method with filename argument 2019-04-29 ilnik@webrtc.org Make FrameBuffer be able to signal if it's trivially convertible to I420 2019-04-29 nisse@webrtc.org Delete deprecated version of AudioPacketizationCallback::SendData. 2019-04-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 982e2994..8ce20eb9 (654706:654807) 2019-04-28 ilnik@webrtc.org Crash with error message if failed to allocate memory via AlignedMalloc 2019-04-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 59aee65d..982e2994 (654597:654706) 2019-04-27 mellem@webrtc.org Stop DCHECK which occurs in ANA BitrateController when overhead is zero. 2019-04-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9e7b598a..59aee65d (654486:654597) 2019-04-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 19227549..9e7b598a (654383:654486) 2019-04-26 srte@webrtc.org Revert "Reland "Improving robustness of feedback matching code in event log parser."" 2019-04-26 nisse@webrtc.org Delete unused methods of VCMJitterEstimator 2019-04-26 henrik.lundin@webrtc.org Piping audio interruption metrics to API layer 2019-04-26 nisse@webrtc.org Deprecate RTPFragmentationHeader argument to AudioPacketizationCallback::SendData Created with: gclient setdep -r src/third_party/webrtc@c0c7d36e80b4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:930186,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9bc479c92351a47b0450f64980b2e80704433d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587443Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d235eb236573..8c4839fee907 git log d235eb236573..8c4839fee907 --date=short --no-merges --format='%ad %ae %s' 2019-04-29 perezju@chromium.org Reland "[trace_data] Add AddTraceFileFor method" Created with: gclient setdep -r src/third_party/catapult@8c4839fee907 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:928278 TBR=eyaich@chromium.org Change-Id: I3e7cecc5dd485b4a4d29e4bbed52472c04053d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586994Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0a278d06..9b91e472 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic1398a4ad4d3d5085a03bb28689e991464c021f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587835Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654857}
-
Owen Min authored
"RetainingOneShotTimer doesn't repeat the task itself like *OneShotTimer*" This should be *RepeatingTimer* as OneShotTimer doesn't repeat. Change-Id: I087bd65d83f1652d1baca71550f009c8dc5c18ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586541 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
This reverts commit 7e9b4790. Reason for revert: Causing test failure on Msan bot https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/12589 Original change's description: > Ash Tray: Add fade out animation for notification controls when sliding. > > This change removes a double slide animation when the user flings to > dismiss a notification. > > TEST=manually verified, new unit test > BUG=933640 > > Change-Id: I7f9f4e558dfa53e8acf0abdbd86cf4449c1ea891 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583344 > Commit-Queue: Tim Song <tengs@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#654564} TBR=tengs@chromium.org,tetsui@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 933640 Change-Id: Idb4c0f5be2dfc764db01b702ccd7a938b565ed0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588435Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib537f20a24673cabcf9e4da617d559916610d56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587445Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc94e79eb7b6..d425dee662d1 git log bc94e79eb7b6..d425dee662d1 --date=short --no-merges --format='%ad %ae %s' 2019-04-29 robertphillips@google.com Enable opList sorting everywhere Created with: gclient setdep -r src/third_party/skia@d425dee662d1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I9058b88ad67c53c9f313a6c0196e53d4fc0de287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588195Reviewed-by:
-
Amr Aboelkher authored
- Check for the policy's pref value before appending its switch Bug: 949184 Change-Id: Ib25e61ada0ba0592e6b91619313ec402c5a8a062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578605 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#654852}
-
Gauthier Ambard authored
The provider is used to install overrides. Reland of https://crrev.com/c/1584265 Bug: 954570 Change-Id: I424b6d59c702094020fec20495145f76b6c18646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587886Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#654851}
-
Xi Han authored
Rename profile_policy_connector_factory.h(cc) to profile_policy_connector_builder.h(cc). We can preserve the history of this file. Bug: 937469 Change-Id: I91d8957370824d58869999e8f6ad0cadd2ea3e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585462 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This does not remove the backing code or feature. Bug: 957297 Change-Id: I2dcb70048963d2ab31d5780a051f423f1cc231d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585538 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#654849}
-
Leonard Grey authored
This gets called a *lot* when fetching colors while painting which assumes it's cheap. In fact, it's responsible for about 25% of paint time on Windows and ~6% on Mac (per profiling in the field). Bug: 950063 Change-Id: I57905fffeb51b884a0e94bac28e10b05caacd180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565063Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Stephane Zermatten authored
Before this change, WebController would attempt to scroll an element to be clicked using the same logic as used to focus on an element. This produced strange behavior on some websites, when zoomed, with the element to click appearing and disappearing from the viewport. This is a likely cause of reported issues with clicking when zoomed in. With this change, WebController calls ScrollIntoViewIfNeeded instead of trying to scroll nicely. It results in stabler behavior when zoomed: It removes the flickering of element to click that was observed. Bug: b/123958732 Change-Id: Id890737ffe48ee6ed21061222a65c2488041b73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587027Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#654847}
-
Wojciech Dzierżanowski authored
Each Web Worker runs on a separate worker thread, and each worker has an associated URLLoaderThrottleProvider. When spawning a nested worker, the outer worker's throttle provider is cloned on the outer worker's thread and then used on the inner worker's thread. To accomodate this scenario: - Postpone the creation of DataReductionProxyThrottleManager until a moment when we are running on the target thread. This makes sure the DataReductionProxyThrottleConfigObserver binding is used on the same thread that it's created on. - Postpone the binding of DataReductionProxy until a moment when we are running on the target thread. DataReductionProxyPtrInfo serves as a holder of the interface request that can move between threads. Bug: 942011 Change-Id: Ieed17fb499bbcb0545e3e0323f751c1ea55a33d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565873Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#654846}
-
Xi Han authored
In this CL, we add a getter in Profile to access ProfilePolicyConnector, which is owned by Profile. With this CL, ProfilePolicyConnector should always be accessed via Profile::GetProfilePolicyConnector(). Bug: 937469 Change-Id: I7a6104f4a09be01b6e35663b7989d0bc01afd629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572366 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
-
