- 07 May, 2019 40 commits
-
-
Andrew Xu authored
Both issues are fixed since 76.0.3787.0. But there were no tests related with speaking text under mouse. Add a browser test case for this feature. Bug: 958120, 921182 Change-Id: I9a4aafea1bf3a8f9d23fb606a5afdc9925eeef19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597652 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#657385}
-
Morten Stenshorne authored
These DCHECKs were there to assert correct layout, and over the years they have served us well in finding and fixing bugs that (more often than not) caused bad layout. While there are still bugs that would trigger these DCHECKs, the problematic legacy multicol design (the flowthread idea, and the assumption that it should be possible to 1:1-map any flowthread coordinate to column rows (fragmentainer groups)) makes it practically impossible to avoid problems with these DCHECKs. We're not aware that these DCHECKs would fail on real websites (only with tests generated by the fuzzers), and, given that the multicol implementation will eventually be replaced by LayoutNG, it's time to accept the remaining and mostly unfixable flaws in the current multicol implementation. Bug: 950308, 958671 Change-Id: I0210e073d177bc8fcd02dbf1f1ed5aabb8ccbcf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598817Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#657384}
-
Nick Harper authored
Header Protection requires packets be padded to a minimum size. This modifies QuicTestPacketMaker to add that padding when header protection is in use. Bug: b/124998446 Change-Id: I86a0f990f27280f05b20aa0f7df6805305428d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593603Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#657383}
-
Kyle Spiers authored
Attempting to use the print this page extension results in Unchecked runtime.lastError: JavaScript URLs are not allowed in chrome.tabs.update. Use chrome.tabs.executeScript instead. https://developer.chrome.com/extensions/samples needs to be updated as well. Change-Id: Iea56f32cae87dc4286fe5e1cd61cb5e4ada1e478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554794Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kyle Spiers <ksspiers@google.com> Cr-Commit-Position: refs/heads/master@{#657382}
-
Ben Pastene authored
The immediate outage has passed. It's still got pretty high swarming test pending times, but that was the case prior to the outage, and I don't think that should block us from adding it back to the CQ. R=jbudorick, dpranke Bug: 960100 Change-Id: I6254ddb07da89ed8b85fa410bffbe9d5a332887b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599876 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#657381}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bdce6c8361a0..4403107f9908 git log bdce6c8361a0..4403107f9908 --date=short --no-merges --format='%ad %ae %s' 2019-05-07 nodir@google.com Roll bb Created with: gclient setdep -r src/third_party/depot_tools@4403107f9908 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I897d80abceeb2020516a0b88a15e37ed30d7c8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598879Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657380}
-
Reilly Grant authored
This change fixes a crash due to reentrancy in the ClearGattServices() method when called during disconnect. Destroying a GATT service object and associated characteristic and descriptor objects can run callbacks for pending read or write operations. If these themselves attempt to close the connection an unsafe reentrancy into std::map::clear() will occur. This change reverts the temporary fix for this issue. Bug: 950204 Change-Id: I3b1028389c58dc49e5aefc9ab77fd6be51d86fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597345 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#657379}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8b7597e64f17..60a6a2e77188 git log 8b7597e64f17..60a6a2e77188 --date=short --no-merges --format='%ad %ae %s' 2019-05-07 capn@google.com Fix clamp-to-border addressing mode Created with: gclient setdep -r src/third_party/swiftshader@60a6a2e77188 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129523279 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I7dee8c9740b9ccf7031b9830a8177952918cb609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599515Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657378}
-
Greg Kerr authored
This is a temporary CL to locate and diagnose a mach service acccess that is hanging. Bug: 871280 Change-Id: I8ef068baa2f6f4b6eb3dd7a15671dffc399db2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599251 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#657377}
-
Ahmed Fakhry authored
When a desk is activated, this CL adds a horizontal movement from the starting (current) desk to the ending (to be activated) desk on all displays, since a desk spans all displays. Demos: https://bugs.chromium.org/p/chromium/issues/detail?id=866622#c24 BUG=866622 TEST=Manual, added tests to increase code coverage in the case of multi displays. Change-Id: I901b000a6ff89173d70e3ab07cbb7656c34d8357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591000 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#657376}
-
Katie D authored
Autoclick menu icons should not be mirrored in RTL languages because they have a directionality: The click types correspond to mouse buttons left and right, and the positions correspond to corners of the screen. Also adds a default screen position. This will be the same as where the volume and brightness sliders show up on the screen in LTR/RTL languages, and change with language direction. However, as soon as the user explicitly picks another position using the autoclick menu position button, the position will be fixed no matter if the user changes their system language direction. See go/chromeos-dwell-menu-design under the "Positioning" subheading. Bug: 958998 Change-Id: I28b3bf44b1f9081d6709e0b8255913f69ccac3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594654 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#657375}
-
Kevin Marshall authored
Defines the FIDL service which will be provided by the CastAgent to supply the CastRunner with bindings scripts and receive channels connected to the scripts. Bug: 953958 Change-Id: Ie1962e1395975b5daf3e3a0f13140f79676adfde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592854 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#657374}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/808c6984e664..5f3a01805f61 git log 808c6984e664..5f3a01805f61 --date=short --no-merges --format='%ad %ae %s' 2019-05-07 lalitm@google.com trace_processor: add template substitution support for SQL metrics Created with: gclient setdep -r src/third_party/perfetto@5f3a01805f61 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:129747127 TBR=perfetto-bugs@google.com Change-Id: Iac3a2e0d1e0c7d038e8c7a2da5be49164c1c122c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598877Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657373}
-
Kenneth Russell authored
One sub-test of this test is changing sense (from failing to passing) and must be suppressed during the change. Bug: angleproject:1293 Bug: angleproject:3285 Tbr: jmadill@chromium.org Change-Id: I322a57abe2a9702a1cdaa444f3d1420b93b89dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598716 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#657372}
-
Dominic Mazzoni authored
The JAWS screen reader is not announcing the text of a bubble dialog when it appears unless the user presses a hot key to read the whole dialog. This can be mitigated by adding a "describedby" relation between the dialog and the main label text. Bug: 953325 Change-Id: I8f9a68a80d7d7e91ea51f2816a3d85e312e93b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582844Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#657371}
-
Kurt Horimoto authored
This allows BrowserObservers to remove themselves in tests to avoid the checks_empty=true DCHECK in the ObserverList. Bug: none Change-Id: I3d87782a29c72b800333cd9eb4b79244daf45adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598874 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#657370}
-
Mehran Mahmoudi authored
This makes the progressbar invisible by default which prevents it from showing on startup. Bug: 959227 Change-Id: I710d2409f80ba4ec85a16e4c9cbc5e631c056eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595983 Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#657369}
-
Sam Goto authored
Report back to the renderer timeouts and task failures. Introduce an MojoInterceptor-based framework to enable us to test more corner cases. Bug: 670299 Change-Id: I13ed957e5bd291f47b775a7a0b817b06f3ba6c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574425 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#657368}
-
Kevin Marshall authored
Redesigns the NamedMessagePortConnector system so that ports are created in JS and pushed to native code, instead of being created on the native side and pushed to JS. The resulting implementation is cleaner because it allows callers to use HTML5 MessagePorts directly, without any need for a buffered wrapper class. * Adapts JS callers to use MessagePort functions and events. * Cleanup: modifies native dependents to take InterfaceHandle<MessagePort> instead of MessagePortPtrs. Bug: 922718 Change-Id: I4ad7b381bd95e42859cd48abccee4fc8e4f64a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595175 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#657367}
-
rajendrant authored
Bug: 952435 Change-Id: Ied1ab046d74eb091beb48937505af8cb3fdea1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566352Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#657366}
-
Bruno Santos authored
Add entry in translation expectations to list grd files that should not be processed by translation tools, since they might contain parts not available publicly. Bug: 959449 Change-Id: Ic5da08cdb8465b7b7d7922d33b2ed0801a556ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596969 Commit-Queue: Bruno Santos <brunoad@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#657365}
-
Ehsan Karamad authored
'autofocus' post tasks the a callback to run Element::focus(). At this point it is possible that the Docuemnt::frame_ does not exist. This CL checks for frame_ before dereferencing. Bug: 960224, 954349 Change-Id: I9ee544343ef5314c0d9ffef3ba472cd438d528fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598197 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#657364}
-
Antonio Gomes authored
This method is needed when convert a CrossThreadFunction [1] to pass it out of Blink. In this particular case, AudioDestination can pass a CrossThreadFunction instance to blink::MediaMultiChannelResampler without converting it back to base::RepeatingCallback. BUG=None R=jbroman@chromium.org [1] third_party/blink/renderer/platform/wtf/functional.h Change-Id: Ifc5d19049dd3e4b295dd6e88d72d2d5d99ee49b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599712 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#657363}
-
Xiaohan Wang authored
Remove the include of "base/values.h" since it doesn't need anything from it. Bug: 960460 Change-Id: I08050e552bd3d8ddad2b1e909a3e708168c488db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599511 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#657362}
-
Katie D authored
Bug: 960038,960026 Change-Id: I19338b1c3d36ea9adb9aa803d06afaa71c77e5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597968Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#657361}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f0eeac8204f..06e14afaa7db git log 9f0eeac8204f..06e14afaa7db --date=short --no-merges --format='%ad %ae %s' 2019-05-07 brianosman@google.com Add no-nonportable-include-path when building ANGLE with Windows-Clang Created with: gclient setdep -r src/third_party/skia@06e14afaa7db The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I546bc7875f000723e7277aa2a2e589c6da08db09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598285Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657360}
-
Becca Hughes authored
There used to be a video EnterPictureInPicture method and an element EnterPictureInPicture method. However, this resulted in callers accidentally calling the wrong overload since the video element is derived from element. Therefore this combines the two methods to make it more robust. BUG=959778 Change-Id: Icc5272d6b3f667af6719fd4cd15ae3b660da13a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596220 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#657359}
-
Natalie Chouinard authored
This feature is no longer used and the flag to enable it has been removed. Bug: 957297 Change-Id: Idbd337e137b9f2a888ca11bf9577db129d5ec438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597753Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#657358}
-
Ella Ge authored
When lock cursor, we want to move the cursor to window center, to ensure that the cursor is inside window, but the center coordinates was wrong (need flip y). Adding the coordinate conversion to fix it. Bug: 956980 Change-Id: Ifc668fe8a4bfcd24630143d77c50986857b6a884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595658Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#657357}
-
Bailey Berro authored
- Adds a Remove() method to remove a printer from a given class. Change-Id: Ib229e42b472a0d9cf637c116d1f35ae50d5a9a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575863 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#657356}
-
Jonah Ryan-Davis authored
ANGLE has consolidated primaryGPUIndex into activeGPUIndex, which is used to represent the expected index of the GPU that graphics calls are sent to. Bug: angleproject:3383 Change-Id: Id229f82417bb15e5e07e509beaf559d909b385a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592115Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#657355}
-
kdillon authored
Adding a flag for this feature so that developers can enable and test application changes. (https://bugs.chromium.org/p/chromium/issues/detail?id=952452#c55) Bug: 827324 Change-Id: If4b8f20fe5803b18e771bbb361c7ca0a71236c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590059Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#657354}
-
Michael Giuffrida authored
Bug: 960032 Change-Id: I0e64cc87e64e4f4b53dc21d81c6840f7d7ebbb71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597692 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#657353}
-
Caroline Rising authored
Bug: 910739 Change-Id: I744d3df03c67ee934ca1e665d5d5dc3e1d69da18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599768Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#657352}
-
Robert Sesek authored
Bug: 958163 Change-Id: I840a02427c4f027692e46341734637f43f90d2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594709 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#657351}
-
Reilly Grant authored
This change adds checks to verify that the ArrayBuffers passed to WebUSB functions controlTransferOut(), isochronousTransferOut(), and transferOut() have not been detached. If so then an InvalidStateError is thrown. While the previous behavior was safe from use-after-frees it silently sent the USB device an empty buffer which would be difficult to debug. Change-Id: I94249dd0097991b2b4933093ac85f50f0ccda7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598048Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#657350}
-
Kyle Milka authored
Switch from an explanatory comment to the string 'no-include-guard-because-multiply-included' to stop the warning every time the file is edited. Also add NOLINT(build/header_guard) to stop Tricium from flagging the same problem. Change-Id: Iccaf808919606c36ff2c770b44e39b6ba6504bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582459Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#657349}
-
Etienne Bergeron authored
This CL is removing the code that is forcing the font smoothing. The setting is system-wide and can't be used with other unittests. see: https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-systemparametersinfoa "Retrieves or sets the value of one of the system-wide parameters. This function can also update the user profile while setting a parameter." The unittests should be able to detect both states if needed. R=robliao@chromium.org, CC=tapted@chromium.org Bug: 759870,953293 Change-Id: I2f79320daef4bcbdade6076960f4a13f235bd3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570527 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#657348}
-
Fabrice de Gans-Riberi authored
The test is flaky on Fuchsia. Bug: 760687 Change-Id: I7cfbd58fc0a1c5641e1f5d2e78d470536a100f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599672 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#657347}
-
Scott Violet authored
BUG=958121 TEST=covered by tests Change-Id: I27bbdb4021ff506ac683948b383fc0559a2b823a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595980Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#657346}
-