GitLab

Bug: b:154268518
Change-Id: I50639eb364d74c3c7cfc42842b85dd915850015f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199993Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769006}

This reverts commit a79f5b3b.

Reason for revert: Enabled the optimization on the wrong platforms and it causes flickering (crbug.com/1082947)

Original change's description:
> viz: Re-enable ignore_undamaged on platforms using GL buffer queue
> 
> SurfaceAggregator has an option to output only the quads that
> intersect the damage rect computed by SA itself.
> 
> This optimization was disabled on devices with HW overlays or where
> the renderer might expand the damage, since SA would not know the
> final damage rect.
> 
> This CL re-enables the optimization on devices where we can estimate
> a bounding rect of the renderer expanded damage.
> 
> This is achieved by asking to the renderer for a bounding rect that
> represents the maximum area that can be expanded.
> SurfaceAggregator will aggregate the boundingrect union the damage.
> 
> The damage on the root render pass will be unchanged, so that HW
> overlays damage computation won't be affected.
> 
> 
> Bug: 1077210
> Test: viz_unittest (new test and Display tests)
> Change-Id: Ie94d1f09923959e2e025845f89a9b3eae759a64a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179763
> Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#768572}

TBR=dcastagna@chromium.org,sunnyps@chromium.org,kylechar@chromium.org

Change-Id: Id7453435c8b50981e5b7752855e3fd2190076676
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1077210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203219Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769005}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/053213d049fa..176bf641480b

git log 053213d049fa..176bf641480b --date=short --first-parent --format='%ad %ae %s'
2020-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@176bf641480b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Ice51f7ccc42785e85fb2a9647515174c4b62f942
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202488Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#769004}

Add two more metrics to track the number of times HomepagePromo is seen
until user take action or dismiss the promo.

Bug: 1068831
Change-Id: Iddb9777ef58289d4a97708dd1c61b30f316a056a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199931Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769003}

This is a licensed third-party controller for the Nintendo Switch. It
doesn't support vibration, and doesn't report valid calibration data for
the joysticks so default values are used instead.

BUG=1077889

Change-Id: If5fdecf5a9a3d92ffd85ac67a6c2ccd438c8428c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188611
Commit-Queue: Andrew Walbran <qwandor@google.com>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769002}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8e272a6a2895..446c499de196

git log 8e272a6a2895..446c499de196 --date=short --first-parent --format='%ad %ae %s'
2020-05-14 tmathmeyer@chromium.org Match some color schemes to the other parts of devtools

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@446c499de196

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:794255
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Id98f594e3cbaf5af9265a6379e1af21c9e09903b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202490Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#769001}

Adds the ability to render the *full* version of autcomplete matches
(including entities) and handle interactions with them such as:
1. showing and hiding matches in a suggestion group.
2. removing a match using the RHS remove button.
3. navigating to a match via click.
4. updating the realbox icon/favicon as the match selection changes.

Bug: 1041129
Change-Id: Iee5d8192cd0b2b122a4c9b22a7860278fa5d37be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199361
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769000}

Adjusted the logic in ClientHints::IsJavaScriptAllowed
to better reflect the default value of `null` (and align
closer to most of the logic in most of Blink) and check
in even more places!

Bug: 1082674
Change-Id: I75cd95ef66c95e6633825e7657409b01fcf75db5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201976Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768999}

Bug: 866236
Change-Id: Ifd37272f147fba8cf068db10dbdf37bbecf09944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202662Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768998}

After we finish the scroll unification, the scrolls happens mainly on
the compositor thread, and the scroll code in the main thread will be
removed. eventSender sends the scroll events to main thread, so it
would not work after the scroll unification. We should replace
eventSender.gestureScroll* with gpuBenchmarking.smoothScrollByXY in
third_party/blink/web_tests/fast/scroll-behavior/scroll-over-resizer.html.


Bug: 1047176
Change-Id: I48ab79295e22e350f577200ead7fdbd15624a6e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183480Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768997}

Adding drainUntilIdle after "Manage Sync" is tapped and before to open
again the settings. When "Manage Sync" is tapped, the sign-in UI
can take a little bit of time to be dismissed.

Fixed: 1077187
Change-Id: I7c2e0da6c1d0912e3374b1761f54f648673c590c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178889Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768996}

Change-Id: Ib13ad2a8d2300cf8de7d6cd0f2bb991d7c4f91e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132594
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768995}

AX-Relnotes: n/a.
Bug: None
Change-Id: I4677d686f6a9508df6cd5fdde0908b40934b3960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199180
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Auto-Submit: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#768994}

This reverts commit ce5b93b3.

Reason for revert: We have collected enough data. We do not want
the DumpWithoutCrashing in release branch.

Original change's description:
> [threadpool] Report when a sequence holds more than 10000 tasks.
> 
> That suggests that there is code that posts tasks faster than they can
> be executed by the pool, leading to unbounded memory usage growth.
> These cases should be identified and fixed.
> 
> crbug.com/1071127 is a known instance of this problem.
> 
> PendingTask is 72 bytes. 10000 tasks ~ 720 KB
> 
> From the ThreadPool.NumTasksInSequenceOnPush histogram that was briefly
> recorded in 84.0.4121.0, the max value recorded by a user in a day is
> above 10000 tasks for less than 0.01% of users. Therefore, we don't
> expect this change to flood the crash server.
> 
> Bug: 1071127
> Change-Id: I08e4d44f36a816439931fc187a7753f3af4ddd1d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151686
> Commit-Queue: François Doray <fdoray@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#763872}

TBR=gab@chromium.org,fdoray@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1071127
Change-Id: Iab689966dfe9552fb2ffabcb4ab4d17467e1760f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202506Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768993}

This CL gates conversion registration on the redirect being same origin.
This is done to prevent sites from triggering registration events for
other reporting origins without their consent.

This change introduces a new struct on ResourceRequest containing the
previous url in the redirect chain. This url is then used to perform
a same-origin check when looking for a conversion redirect.

Bug: 1042919
Change-Id: I444dfacdb5209e5c63019c369a7900db25250b66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171545
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768992}

This is a follow up to https://crrev.com/c/2146212 which added support
for App Icon Shortcuts Menu on Windows.

This CL adds UMA metrics for shortcuts menu registration and
unregistration on Windows. These will help us track the stability of
this newly added feature.

Bug: 1077083
Change-Id: Ie41aa70f1a7f07253d11d0b516877281b188b5c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191322Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Chris Mumford <cmumford@google.com>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Rahul Singh <rahsin@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#768991}

Bug: 1077766
Change-Id: I8079081f01ac1c69b28b169d0b159dedf121a783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199288
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org>
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768990}

These are based on https://github.com/WICG/origin-isolation/blob/master/scenarios.md#session-history-scenarios.

Bug: 1042415
Change-Id: If58a573764cb31ac34e17627555403134edac30a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202657
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768989}

Added Datalist into FormFieldData.
Remove SetDataList() mojo interface.
This patch doesn't change any feature.

Bug: 949555
Change-Id: I7b8c79a73ab37c6f66d59e32d40b72dcd8f6996d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197199Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768988}

This reverts commit ca2e472b.

Reason for revert: breaks compile, see https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/4247?

Original change's description:
> [ios] Reduce pointer boilerplate in Credential Provider
> 
> crrev.com/c/2199891 introduces a reusable class for pointer
> interactions for non-button views. This class internally handles
> all the delegate callbacks. So usage is simplified to a single line.
> 
> This CL should have no impact/change on the UI.
> 
> Bug: 1073961
> Change-Id: I28904804916d0c112f73fe6e372bea6aede504d0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199727
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Commit-Queue: edchin <edchin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#768924}

TBR=edchin@chromium.org,javierrobles@chromium.org

Change-Id: Ib4e9c99203d3dbb673d49f302b342d2055561b3d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1073961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203138Reviewed-by: Dana Fried <dfried@google.com>
Commit-Queue: Dana Fried <dfried@google.com>
Cr-Commit-Position: refs/heads/master@{#768987}

This reverts commit 16307825.

Reason for revert: crashes in tests on Mac Release (Intel) - see attached bug for information

Bug: 1082966

Original change's description:
> Metal: Run test shaders on a ThreadPriority::DISPLAY thread
> 
> The Metal test shaders are compiled in a function that comes from
> a PostTask.  There is currently no path through which a PostTask
> will end up running on a ThreadPriority::DISPLAY thread.
> 
> Change the Metal test code to create a ThreadPriority::DISPLAY
> thread and do its work there. A separate change is making that
> correspond to a pthread priority of 50.
> 
> Of note is that Metal's callback to Chrome comes from a Metal-created
> thread which has priority 31.
> 
> Also change the default test shader to be a Compile instead of a
> Link (the Link tests have not been completed).
> 
> Bug: 974219
> Change-Id: Ieb5ab0748b3aa255ee7dd3348870ddf812caa682
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200357
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: ccameron <ccameron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#768962}

TBR=avi@chromium.org,ccameron@chromium.org

Change-Id: I852346697048fc916711ea60dd050b646a53705c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 974219
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203257Reviewed-by: Dana Fried <dfried@google.com>
Cr-Commit-Position: refs/heads/master@{#768986}

The NTP omnibox pointer hover effect looks slightly oversized.
This CL reduces it by 1 point.

Bug: 1073961
Change-Id: Idd6daa3952cf4521083c2110a6d6b5645157f6b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203018Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768985}

The WebKit build directory contains a copy of
libclang_rt.asan_osx_dynamic.dylib inside
WebKitTestRunnerApp.app. This file is also needed at the top
level when fuzzing, since trying to dynamically load a
version of this library from other locations leads to crashes.

This CL makes copy_webkit_for_clusterfuzz.py copy this
library to the top level, and makes run-clusterfuzz.sh set
DYLD_LIBRARY_PATH to this top level directory.

Bug: 1064181
Change-Id: I7de42891c39c12ae422beb6e8031745ff36640b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202682Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768984}

This logs a histogram to check crash collection state.

This does a small refactor to move the work of creating the error
message into the callback. This is a small optimization (this work is
only needed if crash collection is disabled), but also makes it easier
to only log these cases when they're user facing.

Fixed: 1082506
Test: Verify the error UI looks correct in each state
Change-Id: Ib78bc5e788e7ec53a4ce591a3121ecdc8c17ec36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200277
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768983}

Intent to ship: bit.ly/clssesi2s

Bug: 1053510
Change-Id: Ibd24c3f11c08c71c3e83eb6f2ae1749f13170202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197557Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768982}

DBus method calls to |Uninstall()| and |Purge()| to dlcservice will not
be queue'ed and all dlcservice errors will be propaged to callers.

This change is to reduce complexity in the client and transition the
complexity into the platform dlcservice.

BUG=chromium:1071656
TEST=./unit_tests

Change-Id: Ic58432cd09dc8f41422ab6ff5667e5e36a4d6c3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199687
Commit-Queue: Jae Hoon Kim <kimjae@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Jae Hoon Kim <kimjae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768981}

This also adds an allow list of crash keys, derived from the WebView
set.

Bug: 1064594
Change-Id: I8e476444a8b2bb7a3e9301598fbed719809c6e7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202996
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768980}

No change to logic. This logs the length of the crash UI's user-facing
list to UMA.

Fixed: 1082468
Test: None
Change-Id: Iff1436454c3e3f5aa7d5950414e6ab246f4d61f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199872
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768979}

https://webrtc.googlesource.com/src.git/+log/2b7d96959916..37120ab59d1f

git log 2b7d96959916..37120ab59d1f --date=short --first-parent --format='%ad %ae %s'
2020-05-14 danilchap@webrtc.org in RtpSenderVideo propagate chain_diffs into dependency descriptor

Created with:
  gclient setdep -r src/third_party/webrtc@37120ab59d1f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Id00984b6f7247d1517015b6f16b66b0330a59ae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202486Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#768978}

This CL adds new histogram to record whether sync error is shown to the
user because user action is required to fetch keys.

Bug: 1032526
Change-Id: I623576edc369f7355eed9f7ec5827df668670eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172685
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768977}

This addresses the setTextApearance version limitations.
Unclear how this passed presubmit.

Related change: https://crrev.com/c/2191195

Bug: 1082222
Change-Id: Ida9588ecdac4324c0cd54aac19b00614b9826b40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202957
Commit-Queue: Ender <ender@google.com>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Auto-Submit: Ender <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768976}

And stop using the FocusedFrame() in them, instead use the current
frame.

R=avi@chromium.org

Bug: 866140, 1069111
Change-Id: If43e1a38c9ebb6acd682ba7abd5c3abdde550814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202158
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768975}

Bug: 1076295
Change-Id: I85a9e2af5517cdcb42a667de28fbbc5ae7b1ffdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200376
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768974}

No change to logic. This adds a histogram to track which menu items the
user interacts with. This includes the "refresh" button in the crash UI.

Fixed: 1079073
Test: None
Change-Id: Icaf80a7e895ccf8815e7be7c3d559fa30f41873d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186754
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768973}

Previously, Feed articles would always open the offline version of a
page if it exists, which isn't ideal for users who are online.

This CL changes this behavior to open the article normally, which
leaves it up to Offline Pages to decide whether or not to open the
offline version of the page (e.g. when offline).

TBR=twellington@chromium.org,wychen@chromium.org

Bug: 1069906
Change-Id: I5723e418747867411511ede72f43c323b493b154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151175Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768972}

Trust Tokens (https://github.com/wicg/trust-token-api) is a new feature
allowing callers to specify cryptographic operations to execute
alongside certain requests. It currently provides an iframe interface
executing these operations alongside subframe navigations, and fetch
and XHR interfaces allowing executing the operations alongside
subresource requests.

Two of the three Trust Tokens operations ("redemption" and "signing,"
in contrast to "issuance") require that the trust-token-redemption
Feature Policy feature be present in the executing context.

This is the second of a series of two CLs enforcing this Feature Policy
requirement in the browser. It binds a frame's trust-token-redemption
feature policy value to its subresource loaders, so that the network
service can verify that subresource requests bearing redemption or
signing operations originated from frames with the necessary policy.

to the network service; adds NetworkContext unit tests confirming that
the checks work as intended given a value of the policy.

Test: Adds content browser tests confirming that the feature policy gets passed
Bug: 1071272
Change-Id: I2bfeff20ec44459f408b67cd48965757a6b987c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165645
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768971}

interstitial_page_impl.* was removed in d51e7703
so remove a reference to it in DEPS.

Bug: 1077074
Change-Id: I885f45f483175ec7bba627df10091aa8a3d0586f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202500
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768970}

There was a dangling clause left over from an earlier iteration of
TrustTokenRequestSigningHelper::Begin's method comment.


Change-Id: I011d9600200a063e00ae1b6d11a187c0cf4b5c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202499
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768969}

Bug: 1067979
Change-Id: Id9269a510d3e60aa9ae806f375d39df5c8a6ea41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202668Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768968}

Swipe from shelf generally means go to home, which would imply going
back if the home screen is showing search, or non-initial apps page.

BUG=1064739, 1057317

Change-Id: If9bb00a4879d4ec4c9605ac2d472912095ca1091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199182Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768967}