- 14 Jun, 2018 40 commits
-
-
Tom Anderson authored
Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround, [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to fix a use-after-free. Fontconfig also now requires libuuid as a dependency, so whitelist it as a dependency since we statically link fontconfig. [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914 [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74 [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde BUG=831146,822737,787020,829890,847323 TBR=thestig,dnicoara Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec Reviewed-on: https://chromium-review.googlesource.com/1095538 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#567445}
-
Mathieu Perreault authored
Bug: 827404 Change-Id: I30e9c4d44aa3c6583fbe26743dab964e99011d28 Reviewed-on: https://chromium-review.googlesource.com/1101642Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#567444}
-
Tom Anderson authored
On Mac, confirm-to-quit is a feature that is enabled with a menu item in the global menu bar. On Windows and Linux, this menu bar doesn't exist, so instead it's put in the settings menu, above the "Exit" entry. There's still some debate about whether the setting should go in the settings menu or in chrome://settings [1], so this may end up not being the final place for it. But either way, most of these changes are still necessary. In addition, this CL also * Adds localized strings for Win/Linux - The Mac ones won't work due to the difference in the shortcut (Cmd+Q vs Ctrl+Shift+Q) and terminology (quit vs exit). * Moves chrome/browser/ui/cocoa/confirm_quit.h to chrome/browser/ui so that some constants etc can be shared between Mac and Win/Linux. * Adds metrics for the Win/Linux impl. * Changes PrefNameRegistrar to unregister observers when PrefService is destroyed. This was necessary to prevent a crash when the user presses Ctrl+Shift+Q and then closes Chrome using the close button while the bubble was showing. This also fixes some log spam like "Pref observer found at shutdown" that used to get printed out in all debug builds during browser shutdown. [1] https://docs.google.com/presentation/d/1JDRUtKAXSON_13Ef9VbURk3L7yonzH9dDCj90BZDA6w/edit?usp=sharing BUG=243164 R=sky Change-Id: I671276a41b7878531ea216281f7c994914e1ddf3 Reviewed-on: https://chromium-review.googlesource.com/1099689Reviewed-by:
-
Ryan Landay authored
When I added the incognito toggle button in https://chromium-review.googlesource.com/1060560, I inadvertently removed some code from ChromeTabbedActivity#toggleOverview() for reasons I don't recall. This is now resulting in odd behavior occurring if you tab the tab switcher button immediately after selecting the "close all tabs" menu item. This CL re-adds the code I inadvertently removed and fixes this bug. Bug: 851971 Change-Id: I9c2e5a713c9528f05b7d12938246d44c406ad3d7 Reviewed-on: https://chromium-review.googlesource.com/1101819Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#567442}
-
Patrick Monette authored
The ModuleDatabase is the replacement for the EnumerateModulesModel that is now needed for the IncompatibleApplicationsWarning and ThirdPartyModulesBlocking features. It has been enabled on all channels via the experimentation for the incompatible applications warning. This CL removes the enumerate_modules_model.* files and remove the ModuleDatabase feature flag. This means that it will now be permanently enabled. Bug: 751136 Change-Id: Id49e49ec213dd1a81021346cdd8084ee407f8229 Reviewed-on: https://chromium-review.googlesource.com/1098016 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#567441}
-
Mathieu Perreault authored
Reuse the progress overlay (Throbber with "Confirming card...") to display a permanent error. The Throbber is changed into an error icon, and the error is shown in red. Test is changed to use a long string, for easier UI regression testing. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_valid_PermanentError --test-launcher-interactive Change-Id: I4d92ce0a8535e92f8707edf6f4444c53e80eea3e Reviewed-on: https://chromium-review.googlesource.com/1100336 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#567440}
-
Carlos IL authored
Added overrides for GetTopControlsHeight, GetBottomControlsHeight, and DoBrowserControlsShrinkBlinkSize to InterstitalPageImpl::InterstitialPageRVHDelegateView. The lack of those overrides was causing hit testing errors on Android for interstitials. Bug: 825765 Change-Id: If88506529a8eb3a8cb665edaa6416eeb4e3f8281 Reviewed-on: https://chromium-review.googlesource.com/1101397Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#567439}
-
Helen Li authored
net::HttpServer is being deprecated. This CL puts them into a separate target with limited visibility and adds comments. TBR=dgozman@chromium.org Bug: 721401 Change-Id: Id2a5be800ec0ceccb94d3a9987adc96d14e7f8b7 Reviewed-on: https://chromium-review.googlesource.com/1076498 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567438}
-
dpapad authored
Specifically fixing the following tests: MaterialBookmarksActionsTest.All MaterialBookmarksAppTest.All MaterialBookmarksCommandManagerTest.All MaterialBookmarksFolderNodeTest.All MaterialBookmarksItemTest.All MaterialBookmarksListTest.All MaterialBookmarksPolicyTest.All MaterialBookmarksReducersTest.All MaterialBookmarksToastManagerTest.All MaterialBookmarksToolbarTest.All MaterialBookmarksUtilTest.All Remaining bookmarks tests will be fixed in a follow up. Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I62bd58f80208e024953b7f44a110a28db07d7cb4 Reviewed-on: https://chromium-review.googlesource.com/1100108 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#567437}
-
Mounir Lamouri authored
Bug: 852159 Change-Id: I6b6f9c3ed2c8117405923d19d1e2b6ffee3e681d Reviewed-on: https://chromium-review.googlesource.com/1098140Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#567436}
-
Wenzhao Zang authored
This issue did not show up earlier because the old wallpaper picker only contained jpeg images. Also changes |shrink_to_fit| to true. Bug: 852844 Change-Id: Ia26a091ee38a6de43454eda0243ff24386e77da8 Reviewed-on: https://chromium-review.googlesource.com/1101400Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#567435}
-
Darren Shen authored
We currently explicitly add the keyboard container to the root window in each test case. We might as well do it in SetUp. We also clean up the tests a bit. This will be helpful when we remove the keyboard container. Bug: 849995 Change-Id: I9c188b215bca62f3fd5fddc5478d898106a05a53 Reviewed-on: https://chromium-review.googlesource.com/1098741Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#567434}
-
John Rummell authored
Recent versions of Widevine support 'cbcs' encrypted files, so add a query test to verify that it is supported. As well, on systems where Widevine is not component updated, indicate that the bundled Widevine does support 'cbcs' decryption. BUG=835009 TEST=new browser_tests pass Change-Id: Icc4294cca4ac9ba97c2a22816217c57e2262d30a Reviewed-on: https://chromium-review.googlesource.com/1101405Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
kylechar authored
1. BlockSwiftShader() and SwiftShaderAllowed() don't need to be publicly exposed. 2. UnlockedSession is just a copy of AutoUnlock at this point. The added functionality for |owner_| being null was removed. Replace usage with AutoUnlock. 3. GpuDataManagerPrivateImpl::Create() isn't needed. Delete it and use std::make_unique<> instead. 4. GpuDataManagerPrivateImpl initialize variables at definition instead of in constructor initializer list. 5. Remove UnlockedSession before doing something that might notify GpuDataManagerObservers. Observers are already in a ThreadSafeObserverList and are notified by PostTask. 6. GpuDataManagerImplPrivate::ProcessCrashed() doesn't need to run on browser UI thread. The observers are already notified by PostTask. 7. ScopedGpuDataManagerImpl[Private] doesn't need to hold a raw pointer. 8. Use base::NoDestructor<> instead of base::Singleton<>. Bug: none Change-Id: I8bd0829c9fb3b6c11c935872d81bca0971f31629 Reviewed-on: https://chromium-review.googlesource.com/1100974Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#567432}
-
Ben Pastene authored
The retry-without-patch recipe flow is currently broken (whoops!!) https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/chromeos-amd64-generic-rel/25559 Bug: 840967 Change-Id: I0beeb5657f79475089fd6bb355263d7b8543796c Reviewed-on: https://chromium-review.googlesource.com/1101316Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#567431}
-
Anna Offenwanger authored
In the WebVR 1.1 spec, the blink code was informed about devices then sent requests for pipelines to those devices via the mojo interfaces. In the WebXR spec, the decision about which device to use is left up to the browser, and not decided until the pipline request has been made. This CL moves the blink<->device interface pointers from being call parameters to being return parameters to better align with WebXR. As WebVR is being deprecated, as much of the old VR code as is possible has been cleaned out. Bug: 842042 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_vr Change-Id: I67da418829c05479eb3b2a6c5ef1633d8da92564 Reviewed-on: https://chromium-review.googlesource.com/1080967 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
Assuming that every child block end offset contribute to intrinsic block size of the container is wrong. There may be negative margins. Calculate it after child layout, rather than during child layout for each in-flow child. Some extra care was required for NG block fragmentation, because there was code that updated (and checked) the intrinsic size rather than logical block offset. Using intrinsic size will no longer get us anywhere, since it's now only updated at the end of container layout, not during child layout. Move the initialization of intrinsic block size (set to content edge) after layout instead of before layout, to reduce variable span. We may eventually want to change it to a local variable instead of a member. Fixes 9 tests, 7 of which were not marked as failing, but rather had incorrect NG-specific baselines. Also wrote 2 new tests that test this fix a bit more directly. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id57ba18b70f0cc8569deeff63fa5547cb8c44c98 Reviewed-on: https://chromium-review.googlesource.com/1100473Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#567429}
-
Clark DuVall authored
The ContentSettings for cookies are now synced to the network service, which allows us to delete cookies properly when the session ends. SessionCleanupCookieStore and tests are mostly moved over from QuotaPolicyCookieStore. Bug: 848801 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I53f8d7f6cb6439d3b39fad22c406bf058b758e52 Reviewed-on: https://chromium-review.googlesource.com/1090035 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
SecureChannelService is created in ChromeContentBrowserClient, instead of ProfileImpl, because it is intended to be global, i.e. not profile-specific. Also note that the Connector object provided to SecureChannelClient is tied to the browser process, not the active Profile. Bug: 824568, 752273 Change-Id: Ic99e22cc320b4e92e11bf48acd0592d7c1ef0eac Reviewed-on: https://chromium-review.googlesource.com/1097513Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#567427}
-
Peng Huang authored
The SkiaRenderer cannot handle SW compositing, chrome will crash if the SkiaRenderer is created with a SW output surface. This CL fixes the crash. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8e60c6e07a2f39cfda58af3a1ae7f190d3ed88f6 Reviewed-on: https://chromium-review.googlesource.com/1101159 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#567426}
-
Mike Wasserman authored
Default is disabled for now. Remove the old commandline switch. TBR=isherman@chromium.org Bug: 841020 Change-Id: Ie5df91612d6c976b0b7f056c7248dc92cee9be68 Reviewed-on: https://chromium-review.googlesource.com/1101505 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#567425}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8760e2f42857..28f5dd8a4c8a git log 8760e2f42857..28f5dd8a4c8a --date=short --no-merges --format='%ad %ae %s' 2018-06-14 fmalita@chromium.org [skjson] Fix ASAN undefined behavior 2018-06-14 fmalita@chromium.org [skjson] Size-constrained input API 2018-06-14 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 170766a36bd7..a5ac650d2031 (1 commits) 2018-06-14 halcanary@google.com SkImageInfo: make use of SkISize 2018-06-14 caryclark@skia.org refresh generated includes 2018-06-14 egdaniel@google.com Revert "added 565 to 8888 conversion for gpu LCD text rendering for macOS" 2018-06-14 csmartdalton@google.com ccpr: Generalize GrCCAtlas to work for cached atlases as well 2018-06-14 brianosman@google.com Remove GrPixelConfig argument to GrColorSpaceXform[Effect]::Make 2018-06-14 caryclark@skia.org docs fix external substitutions 2018-06-14 halcanary@google.com Revert "Remove SK_MaxSizeT, SK_M{in|ax}U{16|32}, #defines." 2018-06-14 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 d668be9ce66f..49aacad566aa (2 commits) 2018-06-14 fmalita@chromium.org Reland [skjson] Implementation/API tweaks 2018-06-14 fmalita@chromium.org Revert "[skjson] Implementation/API tweaks" 2018-06-14 fmalita@chromium.org [skjson] Implementation/API tweaks 2018-06-14 senorblanco@chromium.org GrTessellator: rename intersection check args. 2018-06-14 halcanary@google.com Revert "Revert "SkTypes: extract SkTo"" 2018-06-14 mtklein@chromium.org Reland "use std::enable_if instead of assert()" 2018-06-14 recipe-roller@chromium.org Roll recipe dependencies (nontrivial). 2018-06-14 halcanary@google.com SkImageInfo: MakeN32*() avoids extra ref/deref 2018-06-14 halcanary@google.com Remove SK_MaxSizeT, SK_M{in|ax}U{16|32}, #defines. 2018-06-14 mtklein@chromium.org Reland "simplify SkTFitsIn, try 2" 2018-06-14 jvanverth@google.com Add variable offset support 2018-06-14 egdaniel@google.com Add GrContext::MakeVulkan factory that doesn't take a ref'd GrVkBackendContext. 2018-06-14 timliang@google.com added 565 to 8888 conversion for gpu LCD text rendering for macOS 2018-06-14 brianosman@google.com Remove const from (immutable) SkColorSpace args to some functions Created with: gclient setdep -r src/third_party/skia@28f5dd8a4c8a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I28c906f4370c3af114d336a64f14768a15e1a26f Reviewed-on: https://chromium-review.googlesource.com/1101361Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567424}
-
jdoerrie authored
This change replaces a few contant sized vectors with their std::array equivalent. Furthermore, function parameters are updated to take static base::spans, as this allows for greater flexibility and more efficiency, even for temporary values. Bug: 838923 Change-Id: I41ea47ad757aec0740adb2b71f72fd80b558e1e9 Reviewed-on: https://chromium-review.googlesource.com/1039748 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#567423}
-
Dmitry Gozman authored
As a side effect, this makes ctrl+click on a submit button open a new background tab - similar to webkit and clicking on a link. Also covered ctrl+click functionality with tests. Bug: 849055 Change-Id: I344df4821a7c840129d239023d4a500a42e8f80b Reviewed-on: https://chromium-review.googlesource.com/1100107Reviewed-by:
-
Xiaoqian Dai authored
"Drag" is for dragging window on the title area. "Resize" is for resizing snapped windows by dragging the divider bar in splitscreen. Bug: None Change-Id: I8b768cf0286615c1ca0e925eee0295def2bf7ffe Reviewed-on: https://chromium-review.googlesource.com/1091928Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#567421}
-
Yue Cen authored
If the user clicks the Install button after ARC++ is provisioned, we should start the flow right away. If not, we delay the flow until Play Store is ready. ARC++ changes: ag/4174872 Bug: 835029 Change-Id: I36037df522addd9aec3f525157e2e5478c9d4836 Reviewed-on: https://chromium-review.googlesource.com/1080012Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#567420}
-
Ben Smith authored
* wasm_local_iframe_test doesn't appear to be flaky anymore * The wasm WPT tests all require the --enable-wasm flag, so must be run in the virtual/enable_wasm/ testsuite Bug: 736732 Change-Id: I6076a5aecdfb018ad81130721062955e2ede8d5c Reviewed-on: https://chromium-review.googlesource.com/1100078Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#567419}
-
Mike Wittman authored
Having addressed all known stability issues on Mac, updates Mac enable rate to be at parity with Windows. Bug: 531673 Change-Id: I941d2a6d91fcc3272cdd64c98b1af6358301ea8a Reviewed-on: https://chromium-review.googlesource.com/1101175Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
-
erikchen authored
Most clients only need private memory footprint, but the existing methods would still query all the MemoryDumpProviders and then filter the results. This CL adds a new method that avoids querying MemoryDumpProviders. Bug: 851712 Change-Id: I269be2b5a74c32205ba6f4087a9bb8affb9cffb6 Reviewed-on: https://chromium-review.googlesource.com/1098623Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
François Doray authored
This reverts commit e17dbaf1. Reason for revert: Compile failure https://crbug.com/852958 Original change's description: > Make base::ScopedZxHandle a zx::handle. > > - Add the ScopedZxHandle APIs to the base zx::handle. > - Add missing includes. > > This allows ScopedZxHandle to be removed incrementally from call-sites. > > Bug: 852541 > Change-Id: Idc452a450ce2bbe1266e9e0ee266115e2ea38f97 > Reviewed-on: https://chromium-review.googlesource.com/1100132 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567382} TBR=wez@chromium.org,gab@chromium.org,rockot@chromium.org,kmarshall@chromium.org Change-Id: I44b3be92d12a29a972ca3c59d3356f97b21292f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 852541 Reviewed-on: https://chromium-review.googlesource.com/1101777Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#567416}
-
Yi Gu authored
ATM Keyframe::PropertySpecificKeyframe::PropertySpecificKeyframe is implemented in keyframe_effect_model.cc, not keyframe.cc. Move it there for better readability. Change-Id: I5f103d03e6c8bc658a486dc4a9cdb3011adb6050 Reviewed-on: https://chromium-review.googlesource.com/1101476Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#567415}
-
Pavel Feldman authored
Similarly to content_shell, deploys headless_shell as a zip archive. Bug: 851125 Change-Id: Ie5403eb8912dcd1556c87b5da33b5552fa8c7d50 Reviewed-on: https://chromium-review.googlesource.com/1099759Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#567414}
-
Xiaocheng Hu authored
The layout test times out when hit test fails, making it hard to debug. Hence, this patch makes it not time out when failing. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I236c73783294086684d2fc71dc85ac71b8af4df2 Reviewed-on: https://chromium-review.googlesource.com/1101637 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#567413}
-
Gang Wu authored
This CL adds persistence for journal data, and unittest for it. Bug: 831633 Change-Id: I5d4d2821a595dc4be4d937ffd5d04ac4a79051c6 Reviewed-on: https://chromium-review.googlesource.com/1092411 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#567412}
-
Jonathon Kereliuk authored
Need to roll in this commit to fix a breakage caused by META.yml: https://github.com/web-platform-tests/wpt/pull/11486 Update WPTWhiteList due to the moving of third-party libs and a new dependency (webencodings) Change-Id: I67e270c9caa1c0efb3a80dd9f130c42f4f88c464 Reviewed-on: https://chromium-review.googlesource.com/1101503Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#567411}
-
W. James MacLean authored
This CL is in addition to https://chromium-review.googlesource.com/c/chromium/src/+/1099193, and fixes another case where an Optional<TouchAction> might have novalue. Bug: 824774 Change-Id: I21d18fa682d3de4cea7b54572f0bbef92eb9e6ca Reviewed-on: https://chromium-review.googlesource.com/1101478Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#567410}
-
Mustafa Emre Acer authored
This CL moves the generic portions of the Huffman encoded HSTS trie to a separate directory. This is in preparation for future work that will reuse these bits to store the top domain list. Bug: 843361 Change-Id: I9a715b3f0a1fd196df19de02696b3c7fb772be0a Reviewed-on: https://chromium-review.googlesource.com/1097549Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#567409}
-
Bret Sepulveda authored
Refresh is a project to redesign the core UI, primarily the tapstrip's height and shape. The result is that popup windows are slightly taller because of some added frame padding. This patch makes the test checking for the height of the window more lenient. Bug: 846410 Change-Id: If62e8076d78477b82b80f13d19c0838b32f9ea64 Reviewed-on: https://chromium-review.googlesource.com/1100386 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#567408}
-
Greg Kraynov authored
Bug: 783309 Change-Id: I3d179e286bd82b3fb6f4c63e0c3eb9a64aaa5f68 Reviewed-on: https://chromium-review.googlesource.com/1097410 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#567407}
-
danakj authored
Since property tree builder makes assumptions about scrolling things being snapped elsewhere, just have it snap scrollable things itself. Use the Layer only to snap TextureLayers. R=enne@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia47bcaa252c6bdf58b276a7ff0bcde8de0af594e Reviewed-on: https://chromium-review.googlesource.com/1100005Reviewed-by:
enne <enne@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#567406}
-
