- 31 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22b8657a5558..39c302bccf3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia184a139fb2e688e1a16ad006ee398d42dc7af5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793815}
-
Evan Stade authored
Dismiss the OSK before entering fullscreen. Otherwise, the tap that enters fullscreen also dismisses the OSK, and there could be a race between how those two actions affect the page height. I was unable to reproduce the flake so this is a speculative fix. Bug: 1107651 Change-Id: I92e3bb502305fa9468e5639d6411f6a6ecb0ba90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333058Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#793814}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22b8657a5558..39c302bccf3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I07ffa68ea19aa71569ad5fb1e5ea55efdc70c5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332981Reviewed-by:
-
Robbie McElrath authored
This CL makes the native TabImpl delegate its WebContentsDelegate:: GetTopControlsMinHeight/ShouldPinTopControlsToContentTop overrides to BrowserControlsContainerView instead of keeping its own copy. This makes these fields easier to reason about as there's only one copy of them and allows BrowserControlsContainerView to more easily modify them if needed. Bug: 1109035 Change-Id: Iedf6d40b85a3c2f5628ee3280bdd4ab287486285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330993Reviewed-by:
-
Ken MacKay authored
Bug: internal b/153672783 Change-Id: Iae40aeb3f2d5a0b5aa56ad70af3057fd1d4e0093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332326 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793811}
-
Haiyang Pan authored
AVD is generated by https://ci.chromium.org/p/chromium/builders/ci/android-avd-packager/68 This AVD includes the changes from crrev.com/c/2146136 and crrev.com/c/2321088 Bug: 1093602, 1110997, 1105697 Change-Id: I9f53cd4de196a4fd68c9df409dbf54080a9300a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333227Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#793810}
-
Jonathan Wright authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/7e3ad79800a7..0241a1304fd1 $ git log 7e3ad7980..0241a1304 --date=short --no-merges --format='%ad %ae %s' 2020-07-16 jonathan.wright Fix file path manipulation on Windows 2020-07-15 jonathan.wright Fix header dependency chains in BUILD.gn file 2020-06-30 jonathan.wright Fix guard for unit test target 2020-06-29 jonathan.wright Factor common gtest utility code 2020-06-29 jonathan.wright Move gtest files to separate folder 2020-06-21 jonathan.wright Add gtest wrapper for djpeg tests 2020-06-21 jonathan.wright Refactor djpeg.c to provide test interface 2020-06-23 jonathan.wright Add gtest wrapper for jpegtran tests 2020-06-27 jonathan.wright Add input JPEG images for djpeg and jpegtran tests 2020-06-23 jonathan.wright Refactor jpegtran.c to provide test interface 2020-06-16 jonathan.wright Add gtest wrapper for cjpeg tests 2020-06-21 jonathan.wright Refactor cjpeg.c to provide test interface 2020-06-19 jonathan.wright Write tjunittest output files to sdcard on Android 2020-06-12 jonathan.wright Move tbench logs from stdout to stderr 2020-06-12 jonathan.wright Add gtest wrapper for tjbench tests 2020-06-12 jonathan.wright Reinstate upstream test image data files 2020-06-12 jonathan.wright Refactor tjbench.c to provide test interface 2020-06-11 jonathan.wright Move tjunittest logs from stdout to stderr 2020-06-11 jonathan.wright Add gtest wrapper for tjunittests 2020-06-11 jonathan.wright Refactor tjunittest.c to provide test interface Created with: roll-dep src/third_party/libjpeg_turbo Bug: 993876 Change-Id: I6c1bfb77b0209b4882547477c1101227ad0d9613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299746Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Jonathan Wright <jonathan.wright@arm.com> Cr-Commit-Position: refs/heads/master@{#793809}
-
Josh Nohle authored
Add factory pattern to Nearby Share certificate storage, and create fake implementation. This will help in unit testing for classes that use certificate storage. Bug: b/154865267 Change-Id: I2d310edb4d0726e2cb0fe387dc57543ee81f59e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329885Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#793808}
-
Alison Maher authored
This change sets up the basics of handling break tokens for fragmented OOF positioned elements. We are currently starting layout for these elements in the first fragmentainer every time. The unit tests that were added reflect this. However, more complex tests will need to be added once we start to position these elements within the correct fragmentainer. I also realized that I had updated the incorrect constraint space in my previous change: http://crrev.com/c/2274246. As such, this change cleans this up and sets up the correct constraint space for fragmentation. abspos-after-break-after.html and mixed-positioning-stacking-order.html are now crashing because the OOF element in the tests fragments beyond the last fragmentainer in its fragmentation context. This is a known issue, and a TODO was added to handle this. static-becomes-relpos-has-abspos.html is now crashing because we are not skipping over spanning fragments when adding OOF elements. This is a known issue, and a TODO was added to handle this. Bug: 1079031 Change-Id: I6e4fed3a49a0f6d9b4ccd939689580227dbc6df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316885 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#793807}
-
Xianzhu Wang authored
This CL addresses the following issues of layout shift tracking: - Changed visual overflows triggered layout shift report (originally filed as crbug.com/1090763). - Descendant layout overflows were not included in ancestor's layout shift report. - Unnecessary descendant layout shift report. - Slow visual rect calculation for LayoutInline and LayoutText. It includes the following changes - Track LayoutBoxes and LayoutTexts only. - Track both old and new starting points and visual representations instead of using location of visual rects as starting points. - For a LayoutBox, the local visual representation is the layout overflow rect if the LayoutBox has layout overflow and doesn't clip overflow. Otherwise use the border box rect. - For a LayoutText, suppose its shift causes shift of all contents in containing block logically below the LayoutText, and use that part of visual representation of the containing block as the visual representation of the shift. - Map both local starting points and local visual representations to the initial containing block and viewport. This has the following benefits: - More accurate starting points and visual representations, conforming to the specs; - Better performance by * avoiding unnecessary layout shift reports of descendants * avoiding slow LayoutInline and LayoutText visual rect calculation. - sizeof(LayoutObject) is reduced by 16 bytes because now we use the previous geometry data in LayoutBoxes for paint invalidation. Bug: 1108622 Change-Id: I7ebb4e250e7ca2a03b4dadea50034e300e55ad84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319538Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793806}
-
Moe Ahmadi authored
The mojo definitions are located in chrome/browser/ to be accessible by Desktop and Android. A desktop implementation of the handler interface is added which will be bound to the NTP JS in a followup CL. For more information see go/promos-deeplinking-settings Bug: 1106421 Change-Id: Iae8fa63f8464ca2ecd4e45d611537cae1ed94dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327852 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#793805}
-
David Bienvenu authored
On Windows, Chrome doesn't generate a synthetic mouse exit event, see crbug.com/394672. Change-Id: I1b8ae0e43061f2c555c317cfd1f2f683b79db738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316843 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#793804}
-
Matthew Denton authored
Turn the CertVerifierService on by default in non-Chrome branded builds for desktop platforms. Bug: 1015134, 1094483 Change-Id: I853155582dde092c39ab1975a0b8081eed994600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324643 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
-
Brian Malcolm authored
This is intended to replace the NoteTakingAppsLockScreenWhitelist policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. BUG=chromium:1095910 Change-Id: I24c36696091a1a1af3cb125e6521ff709ee4b49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330436 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#793802}
-
Abigail Klein authored
When live caption is enabled for the first time, it kicks off downloading the on-device speech model, called SODA. This CL gives the user a progress update as the model is being downloaded. The accessibility settings page webui observes component updater events and sends a localized string containing the percent downloaded to the accessibility settings polymer client to be displayed. This CL also updates the text of the Enable Live Caption messaging according to the latest UX spec. This CL does not make any changes to the ChromeOS settings page. If there is an error when downloading, display an error message and toggle the live caption preference off. Screenshot (red arrow points to the progress update change): Default: https://screenshot.googleplex.com/aSqiAypyGW7 Progress update: https://screenshot.googleplex.com/fH5kxpYE8p5 Error message: https://screenshot.googleplex.com/q3XSUO3EzOZ Bug: 1055150, 1105686 Change-Id: I519a7166cf8543206db2ebd4c8301ac16499ae00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310784 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#793801}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Ic98b86ed2de34eeb676aa45d6fdfffafe54d2f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333287Reviewed-by:
-
Domenic Denicola authored
In https://chromium-review.googlesource.com/c/chromium/src/+/2243994 I introduced an implementation for window.originIsolationRestricted which pipes the isolation state from NavigationRequest to the navigated-to LocalDOMWindow. However, this does not work for the case of the initial about:blank, where no navigation is performed. Furthermore, it does not match the spec, where the Window property just reflects an agent cluster-wide property. This CL introduces an alternate approach, more similar to what is done for self.crossOriginIsolated in https://chromium-review.googlesource.com/c/chromium/src/+/2247463, which is another agent cluster-wide value. The origin isolation state is stored in the renderer-side Agent class. Then the LocalDOMWindow getter can just pick it up from the surrounding agent, as in the spec. Note that unlike the implementation for self.crossOriginIsolated, the value is per-Agent instead of static (process-wide). Currently the value is set several times per agent (roughly once on every navigation). This is redundant, but we don't yet have a good place to set it once (i.e., we don't have a browser-side "time of agent creation"). If that gets fixed, we can likely stop piping the value through navigation params. See https://docs.google.com/document/d/1MTnmyWAoAIKDH4yWaRthIUdi05MsjlML8gctvKP7-h8/edit for discussions around fixing that. This fixes the issue with about:blank iframes embedded in origin-isolated pages reporting false, because the agent's origin-isolated boolean was previously set to true by the containing frame. This does not yet fix the issue with data: URLs reporting false, tested in external/wpt/origin-isolation/getter-special-cases/data-url.https.html. However, that will be doable as a followup, by changing the navigation-time computation to pass true for them instead of false. (Currently it passes false because data: URLs don't get their own process, but it should pass true because they _do_ get their own agent cluster.) Bug: 1095653 Change-Id: I8dfa8fc4a4766efc0611d43a255673662c422776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300237 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#793799}
-
Yi Gu authored
Phone number collection is recorded in a list of metrics. For example: Autofill.Address.*Phone*. To measure WebOTP's impact on phone collection we need to aggregate it from them. It's better to have one histogram that shows all the collection. Bug: 1107590 Change-Id: Ibbc5e33ef2afc6395e683a1774ea1a1932bcf822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332878 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#793798}
-
Matthias Körber authored
This CL adds support for settings values with a ValidationStatus and to retrieve the latter from the AutofillProfile. It also partially integrates the new structured name component. The CL does not integrate the import and merging logic since this is not testable without SQLite support that is added in a subsequent CL. In a followup CL, all merge-related tests in the AutofillProfileTest have to be adapted. Change-Id: I37ebf201a7a7730cf6f4d7848090c2ab6be064a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288281 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/37710e42bb90..828c1805a64b 2020-07-31 t-olfly@microsoft.com Updating CDP and dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I78f9866c47c15d30b22d619073d71a96d4695194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332851Reviewed-by:
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: I8dc2315c348c3c47561947e6aaf30f1f44fd533f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292872Reviewed-by:
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: I598970475e76cb2d56825254008ad98ba5c532e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293158Reviewed-by:
-
Toni Barzic authored
Update shelf navigation widget metrics reporter to use the hotseat state from the time of reporter callback creation to select which hotseat state dependant metric to report. Note that shelf component layout happens after the hotseat state is set, so the hotseat state should have the desired value by the time navigation widget transitions start. The report callback is run asynchronously from the time the animation completes, so the hotseat state can change between the hotseat animation changing and the reporter callback running (e.g. if an app window is closed just after the animation to hidden hotseat ends, which may happen in perf tests). With the existing logic, where the reporter uses the current hotseat state to select the histogram to report, the animation may get registered for an incorrect transition. Also, when animating home button bounds, do not request animation, and create metrics reporter if the view is already animating to the same target bounds. BUG=1108641 TEST=ran ui.HotseatAnimation tast tests a couple of times Change-Id: Idde82ce98545d7ee7e54170abea588c9793e6d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333141Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#793793}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: I681631cee37468ab20e89d6bbefcdd82dea149b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293005Reviewed-by:
-
Jeffrey Cohen authored
Bug: 1024586 Change-Id: I586d8dc0a05c0aab3776b42c9145d0f6a586c1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032505 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#793791}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56387075825a..9aa97c0bd39e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pkasting@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1111845 Tbr: pkasting@google.com,nicolaso@google.com Change-Id: Ia1c7ae443e5f430ef1b0d4173e58209ac4b23b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333229Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793790}
-
Vasiliy Telezhnikov authored
In case of ImageReader the UpdateTexImage can fail even if RenderToTextureOwnerFrontBuffer succeeded. This can lead to situation when we don't have current frame to get size from. This CL handles this situation to fallback to visible size until we will be able to get right size. Bug: 1109016 Change-Id: I2fc6381cccc4560e97355ac465f62a72734facef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328013Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#793789}
-
Weilun Shi authored
For "exact" linear histograms, the bucket index for Sample |value| can be easily computed and thus we don't need to do a costly binary search for the bucket index. This could have a notable performance improvement given that some histograms (like TaskCount metrics, done after every queued task) can see huge numbers of lookups. the code is already covered by the HistogramFunctionsTest.ExactLinear test. Without this change, running 1 million times the logging part of the above test takes 640ms. With this change, it only takes 530ms which improves ~20% of the bucket lookup performance. Bug: 950536 Change-Id: I1fa9a1cfd0ccbf1967a678ba82b19f15f90c9848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328305Reviewed-by:
-
Julian Pastarmov authored
BUG=1104999 Change-Id: I4e97a51c6858506adc3a2f857fdae96d58af504e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332716 Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
-
Peter Kasting authored
* With this turned on, gtest unconditionally asks absl to initialize the symbol handler. This causes base's attempt to do the same thing to fail. Make base handle this by trying a force-reinit if this failure occurs. * Allow gtest to see the full absl sources, since it unconditionally #includes banned headers. * Fix include dirs not being set correctly, leading to compile failures. * Narrow gtest absl dependency from public_deps to deps, since we don't want "all targets depending on gtest" to silently be able to use absl. * Leave this flag disabled by default for NaCl, since the toolchain there can't compile some of the absl code. Bug: none Change-Id: I24930d1c2086bec1522922665708abee5ce8fc08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332038 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#793786}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596200193-009c7ebe0bb7420a825c0bad7e0cdc3d24f6a3ae.profdata to chrome-win32-master-1596214766-ef32b2ce97242365d96c5d969f5553eac2e23ec9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia16290fb18cfbabcd853f18ca14b5ae9b8179679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333102Reviewed-by:
-
Boris Sazonov authored
1. Moves the code that reconciles ChromeSigninController state with SigninManager state from GoogleServicesManager to SigninManager itself. 2. Removes now empty GoogleServicesManager. 3. Removes GoogleServicesManagerIntegrationTest (it contained no tests, so there's no behavior change). Bug: 1107942 Change-Id: I492f2e12ec1a8f6378d424ba54e0c022284323bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312697Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#793784}
-
Chris Harrelson authored
This is in preparation for separating them into different Blink lifecycle steps. Bug: 1100711 Change-Id: I8c76a57aa127795910a0db5f36fad2fc1ac60162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324205 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#793783}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/39c302bccf3a..fce06b20005c 2020-07-31 fmayer@google.com Merge "Add field for object size of java type." 2020-07-31 dproy@google.com Merge "ui: Add gn rule to copy protobufjs light" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iad2fb56471ee34af15eb3910aa293a719a7b1339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333104Reviewed-by:
-
Yi Gu authored
The metric helps with identifying cases that OTPs were being collected without WebOTP API. Note that we only report when a frame has forms parsed. Bug: 1107590 Change-Id: Ib0b81ef2208de1d86fab069a596cfb98f75c2e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323586 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
-
Jonathan Freed authored
Change-Id: Idd57fc3867bf88ee242d3bf09c68d05647600146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332848 Auto-Submit: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#793780}
-
John Delaney authored
What: No longer reset conversion sql::Database in the error callback Why: This is called synchronously within the sql::Database callstack, so we are actively freeing memory that is still in use. How: Use a bool to track db status for errors instead of the unique_ptr value. Bug: 1111047 Change-Id: I889a3c4e627062ed6472b1cd96301a69632af097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330335Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#793779}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9d3e5b57. With Chromium commits locally applied on WPT: 6d63b58a "Split iceGatheringState tests into separate files & update expectations" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I1a8f5537acd7e901c5498bd8f953d1629f1b86bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331912Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793778}
-
William Lin authored
To add unbundled consent for GetAuthToken in the extensions API, the token scopes returned from the server needs to be accessible for the extension to know which scopes were approved or rejected. This CL adds the functionality and API changes to allow extensions to obtain the list of accepted scopes. Until unbundled consent is implemented, these returned scopes do not add any additional useful information to the GetAuthToken function. Bug: 1100535 Change-Id: Iba3233ae8a33c49118e7093fd2e9020b2951575f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303596 Commit-Queue: William Lin <williamlin@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793777}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I626d94ff6d403a12c655255c9e69668732ce8d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332847Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793776}
-
